IRC logs for #openttd on OFTC at 2019-09-12
⏴ go to previous day
00:51:15 *** WormnestAndroid has quit IRC
00:52:08 *** WormnestAndroid has joined #openttd
01:14:41 *** Thedarkb-X40 has joined #openttd
01:41:46 *** Wormnest_ has joined #openttd
03:04:24 <DorpsGek_III> [OpenTTD/OpenTTD] Wormnest opened issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd
03:36:51 *** snail_UES_ has joined #openttd
03:50:33 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd
03:53:13 *** Lejving has joined #openttd
04:02:45 <DorpsGek_III> [OpenTTD/OpenTTD] Wormnest commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd
05:13:36 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd
06:09:57 *** sla_ro|master has joined #openttd
06:59:01 *** WormnestAndroid has quit IRC
07:27:08 *** WormnestAndroid has joined #openttd
11:39:10 *** D-HUND is now known as debdog
13:30:35 *** WormnestAndroid has quit IRC
13:30:49 *** WormnestAndroid has joined #openttd
13:44:51 *** andythenorth has joined #openttd
13:46:47 <AquaFiX> dbg: [net] Map generated, starting game
13:46:58 <AquaFiX> nothing happens after this line, and i'm not sure why.
13:48:30 <AquaFiX> im running debian 9 stretch
13:48:49 <AquaFiX> running 1.9.2 openttd -D
13:49:40 <LordAro> AquaFiX: are you expecting anything else to happen?
13:50:50 <AquaFiX> yes im expecting the master server to query it, and all sorts of other magic
13:51:39 <LordAro> are you sure it isn't, and just not outputting anything?
13:51:56 <LordAro> (disclaimer: no experience running servers dedicated or otherwise)
13:53:57 <AquaFiX> yeah its not outputting anything
14:34:30 *** snail_UES_ has joined #openttd
15:00:57 <AquaFiX> Anybody time to help me troubleshoot?
15:03:57 <Samu> maybe it's dedicated but not advertised
15:06:23 <AquaFiX> lan setting is 0 so it should be, i cant even connect via ip
15:28:34 <LordAro> AquaFiX: won't connect to the master server if it's not advertised
15:28:42 <LordAro> but i don't know why you can't connect via IP
15:28:43 <DorpsGek> LordAro: OpenTTD uses TCP and UDP port 3979 for server <-> client communication, UDP port 3978 for masterserver (advertise) communication (outbound), and TCP port 3978 for content service, a.k.a. BaNaNaS (outbound)
15:28:48 <LordAro> ^ i presume that's not relevant
15:33:51 *** sla_ro|master has joined #openttd
15:36:19 <AquaFiX> meh it all of sudden started working
15:41:39 *** andythenorth has joined #openttd
16:18:32 *** supermop_work has joined #openttd
16:55:14 <peter1139> ^^ yeah, andy's "normal" colours are way overbright...
16:55:38 <peter1139> The muted colours are not quite the same either, but seem to match a bit better.
16:56:51 <andythenorth> color matching is a sad story :P
16:58:55 <peter1139> Another OS X failure ;p
16:59:06 <supermop_work> I'm doing it with tile and terrazzo right now
17:00:08 <andythenorth> it's a frigging disaster without a colormeter
17:00:20 <andythenorth> or even a colorimeter
17:01:24 *** Wormnest_ has joined #openttd
17:02:41 <peter1139> Just check the hex values :p
17:04:48 <milek7> it doesn't end at the monitor; should everybody load color profiles calibrated for their own eyes? ;P
17:05:43 <andythenorth> my left eye and right eye are differently calibrated
17:05:49 <andythenorth> one is more yellow, the other is more blue
17:05:52 <andythenorth> not even trolling
17:06:00 <andythenorth> measurable difference
17:12:06 <andythenorth> probably just pigment or something dunno
17:12:22 <andythenorth> always there waiting for me
17:12:30 <andythenorth> even Brexit won't help me there
17:17:39 <Eddi|zuHause> are we even still having a brexit?
17:18:32 <Eddi|zuHause> and if the brexit never happens, what colour does it have?
17:18:58 <milek7> according to ishihara plates i have deuteranomaly
17:41:27 *** HerzogDeXtEr has joined #openttd
18:01:58 <DorpsGek_III> [OpenTTD/OpenTTD] Wormnest commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd
19:06:08 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd
19:09:38 <glx> my fast forward is too slow to trigger it I think
19:10:51 <Eddi|zuHause> sounds like a missing invalidation call?
19:11:37 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd
19:11:48 <Eddi|zuHause> also, might that have been my fault?
19:12:48 <DorpsGek_III> [OpenTTD/OpenTTD] Eddi-z commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd
19:16:30 <DorpsGek_III> [OpenTTD/OpenTTD] Eddi-z commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd
19:17:34 <Eddi|zuHause> glx: i seem to remember that money cheat going both ways
19:17:48 <milek7> seems to happen for any news, not just company trouble
19:17:58 <milek7> and reverting afbf6a5 fixes it
19:22:51 *** WormnestAndroid has quit IRC
19:23:54 *** WormnestAndroid has joined #openttd
19:28:27 <milek7> Error: Assertion failed at line 538 of /home/milek7/OpenTTD/src/news_gui.cpp: this->ni->reftype1 == NR_ENGINE
19:28:27 <glx> I think the checks in DoCommand() prevent money cheat to create a negative bank amount
19:29:27 <Eddi|zuHause> trying to read DeleteNewsItem but i don't see where i would have made a mistake
19:34:48 <glx> maybe MoveToNextTickerItem() doesn't close the window when it should
19:35:32 <Eddi|zuHause> but that should be handled by MoveToNextNewsItem()?
19:40:46 *** Progman has joined #openttd
19:41:11 <Eddi|zuHause> hm, in MoveToNext*Item() i changed a "return" to a "continue"... not sure why
19:41:33 <Eddi|zuHause> "if (_date - _news_type_data[type].age > ni->date) return;"
19:42:34 <glx> because you introduced a while loop
19:44:20 *** gelignite has joined #openttd
19:46:32 <glx> if there's something wrong it's not obvious
19:46:53 <Eddi|zuHause> might also be a bug in the original code that i just exposed
19:47:56 <Eddi|zuHause> could use a replay of what happened right before the crash...
19:49:08 <glx> I can't make it crash, so it's hard to debug for me :)
19:49:40 <Eddi|zuHause> well, if your FF can't trigger it, i don't see how it would for me :p
19:50:26 <glx> at most I get 1500 images/s
19:50:56 <glx> and that's with release build
19:51:27 <glx> but I was testing on 512²
19:53:04 <glx> hmm I could play with _settings_client.gui.news_message_timeout
19:53:06 <SpComb^> a global variable for ignoring merges to master? Maybe I'll stick to Jenkins :P
19:53:33 <Eddi|zuHause> if i make the window small i get about 1000 pictures and 2000 simulation rate
19:55:04 <milek7> i have graphics 800fps, simulation fps counter goes off scale
19:56:00 <Eddi|zuHause> and game is making weird noises if i resize while news is shown
19:56:04 <milek7> (with off scale i mean 9999,99)
19:56:28 <Eddi|zuHause> oh it crashed...
19:57:23 <nielsm> (I'm still amazed nobody thought to put an fps meter into the game before)
19:58:04 <Eddi|zuHause> why would you put an fps meter in a game that runs at fixed 30/33fps? :p
19:58:39 <SpComb^> competitive OpenTTD definitely needs 120fps
20:14:11 *** sla_ro|master has joined #openttd
20:21:08 *** WormnestAndroid has quit IRC
20:21:19 *** WormnestAndroid has joined #openttd
20:24:26 *** frosch123 has joined #openttd
20:34:14 <Eddi|zuHause> milek7: can you get to (NewsWindow*)w->ni?
20:39:37 <milek7> after `delete ni;` i inserted: NewsWindow *w = (NewsWindow*)FindWindowById(WC_NEWS_WINDOW, 0); if (w) assert(w->ni != ni);
20:39:57 <milek7> and this assert triggers
20:44:01 <Eddi|zuHause> right, that's the reason why it then goes on crashing, but it doesn't explain how it gets into this situation
20:47:37 <Eddi|zuHause> milek7: can you track _current_news vs. (NewsWindow*)w->ni?
20:51:02 *** andythenorth has joined #openttd
20:57:39 <Eddi|zuHause> i'm still drawing a blank here on what goes wrong when
20:58:23 <milek7> track? just printf two pointers?
20:58:45 <Eddi|zuHause> something like that
21:00:27 <milek7> printf("_current_news: %p, w->ni: %p\n", _current_news, w ? w->ni : nullptr);
21:00:35 <milek7> inserted at end of DeleteNewsItem
21:00:51 <Eddi|zuHause> milek7: maybe also in NewsLoop()
21:01:12 <Eddi|zuHause> (might be spammy)
21:03:22 <Eddi|zuHause> assumption would be w->ni is either null, _current_news or _forced_news
21:04:11 <milek7> piped through uniq for brevity
21:14:33 *** WormnestAndroid has quit IRC
21:15:10 *** WormnestAndroid has joined #openttd
21:17:24 <Samu> can you make engines reliability a bit more diversified
21:18:55 <Samu> doesn't feel random atm, 92%, 93%, 97%, 98%
21:20:43 <Samu> all road vehicles 97 or 98%
21:21:12 <Samu> what happened, it used to be more varied
21:25:22 <Eddi|zuHause> i have a suspicion
21:25:52 <milek7> below ShowNewspaper(ni);
21:25:59 <milek7> that break shouldn't be return?
21:26:13 <Eddi|zuHause> in ShowLastNewsMessage it might need to update _current_news
21:26:27 <milek7> because it's switch, it's essentialy noop
21:27:07 <milek7> and i guess it was meant to break while loop
21:27:37 <Eddi|zuHause> hum, yeah, that seems off
21:28:01 <Samu> when i watch youtube videos on chrome, I get 0 ads during video playback
21:28:16 <Samu> when i watch on internet explorer, ads during playback
21:28:42 <milek7> it doesn't crash with return
21:30:34 <Samu> I had an idea for town growth - upgrade bridges
21:31:09 <Samu> existing town owned bridges
21:31:46 <Eddi|zuHause> yeah, i don't see it diverging anymore either
21:31:51 <DorpsGek_III> [OpenTTD/OpenTTD] Milek7 commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd
21:32:42 <DorpsGek_III> [OpenTTD/OpenTTD] Eddi-z commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd
21:37:37 *** Wormnest_ has joined #openttd
21:37:46 <Eddi|zuHause> so the assumption that was violated was that there's only one news window
21:38:14 <Eddi|zuHause> also, why does ShowNewsMessage() delete the window twice?
21:40:11 <Eddi|zuHause> anyway, ShowLastNewsMessage should probably set _forced_news
21:41:15 <Eddi|zuHause> ah no, it does that by calling ShowLastMessage
21:45:22 <DorpsGek_III> [OpenTTD/OpenTTD] Milek7 opened pull request #7738: Fix #7737: Replace invalid breaks with returns in news_gui.cpp https://git.io/JeYUf
21:45:49 <Eddi|zuHause> aw, i was just about to commit :p
21:51:48 *** WormnestAndroid has quit IRC
21:52:17 *** WormnestAndroid has joined #openttd
21:53:33 <Eddi|zuHause> just noticed: there's a return after the switch in the first function, which makes it correct, but it's missing in the second one
21:54:41 <glx> yes it's just missing a return after the switch in the while loop
21:56:55 <DorpsGek_III> [OpenTTD/OpenTTD] Milek7 updated pull request #7738: Fix #7737: Replace invalid breaks with returns in news_gui.cpp https://git.io/JeYUf
21:57:30 <Eddi|zuHause> i'm too slow for this world :/
21:57:33 <DorpsGek_III> [OpenTTD/OpenTTD] Milek7 updated pull request #7738: Fix #7737: Replace invalid breaks with returns in news_gui.cpp https://git.io/JeYUf
21:59:10 <Eddi|zuHause> there, fight me :p
22:02:22 <Samu> to keep a town growing, i need to pay it £606k
22:02:35 <Samu> not sure if it's worth it
22:03:55 <Samu> with what the AI earns, i could keep 10 towns growing
22:03:56 <glx> oh using 64² I can trigger a crash
22:05:38 <Eddi|zuHause> glx: it'll crash when more than 1 news message window is open, and the news times out quicker than the news closes
22:06:03 <glx> I'm still on the unmodified source :)
22:06:25 <Eddi|zuHause> the missing return causes more than 1 news message to open
22:06:37 <Eddi|zuHause> which violates assumptions elsewhere that there's only 1
22:07:52 <glx> and as the previous news is supposed to be unshown it's deleted
22:10:09 <Eddi|zuHause> ... but i have endless space already
22:11:42 <Eddi|zuHause> "playtime: 11 minutes"... i think it didn't run properly
22:12:15 <Samu> Requires subscription to our newsletter.
22:12:25 <Samu> Requires spamming your email
22:12:38 <glx> they don't spam that much
22:13:15 <Samu> i doubt i can run it here
22:15:37 <Wolf01> <glx> they don't spam that much <- let's talk about this.. XD
22:15:40 <Eddi|zuHause> ... you can unsubscribe from the newsletter...
22:16:09 <Eddi|zuHause> Wolf01: you can forward them to /dev/null :p
22:16:29 <Wolf01> Yeah, I could, but the next day I need to subscribe again to get the new stuff :P
22:17:07 <Wolf01> I already have a folder filter, all the *bundle newsletter go there
22:17:48 <glx> I got 2 newsletter in august
22:18:59 <glx> but most categories are unchecked in the settings
22:19:04 <Samu> data collection practices
22:19:33 <Wolf01> Oh, there are settings? I think I have everything enabled XD
22:25:05 <DorpsGek_III> [OpenTTD/OpenTTD] bedrich-schindler commented on issue #7644: Mysteriously poor performance on macOS https://git.io/fjii3
22:27:36 <Samu> the chance that it will even offer something that interests me is probably 0%
22:31:06 <Samu> but Rondje cheats in more ways than that
23:14:02 *** andythenorth has left #openttd
continue to next day ⏵