IRC logs for #openttd on OFTC at 2019-01-05
            
00:10:21 <DorpsGek_II> [OpenTTD/OpenTTD] slhurst commented on issue #7011: Towns don't grow if first tile of station is outside authority area https://git.io/fh3TL
00:19:07 <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z commented on issue #7011: Towns don't grow if first tile of station is outside authority area https://git.io/fh3Tr
00:37:07 *** nielsm has quit IRC
00:39:26 <Samu> found a bug here https://github.com/OpenTTD/OpenTTD/blob/master/src/script/api/script_vehiclelist.cpp#L40
00:39:35 *** NoMorePacers_ has quit IRC
00:39:59 <Samu> it is looking for waypoints, but there is already a way to get waypoints
00:40:37 <Samu> https://github.com/OpenTTD/OpenTTD/blob/master/src/script/api/script_waypointlist.cpp#L20
00:40:38 <Samu> there
00:41:20 <Samu> actually line 36
00:43:18 <Samu> oh no, sorry, not a bug, I'm confused
00:57:06 *** Wacko1976_ has joined #openttd
01:03:47 *** Wacko1976 has quit IRC
01:11:19 *** chomwitt has quit IRC
01:41:02 *** Wolf01 has quit IRC
02:19:35 *** Flygon has joined #openttd
02:59:26 *** frosch123 has quit IRC
03:10:14 *** Oroburos has joined #openttd
03:18:09 *** Oroburos has quit IRC
03:21:18 *** Thedarkb-X40 has joined #openttd
03:25:05 *** Laedek has joined #openttd
03:27:31 *** Wormnest has quit IRC
03:47:11 *** Gja has quit IRC
03:49:07 *** smoke_fumus has quit IRC
03:49:55 *** Progman has quit IRC
04:20:50 *** glx has quit IRC
04:56:53 *** Samu has quit IRC
05:12:39 *** Thedarkb-X40 has quit IRC
05:18:02 *** Thedarkb-X40 has joined #openttd
05:26:35 *** Afdal has joined #openttd
05:26:47 *** Afdal has left #openttd
06:05:49 *** APTX has joined #openttd
06:09:26 *** APTX has quit IRC
06:09:53 *** APTX has joined #openttd
08:12:03 *** nielsm has joined #openttd
08:30:21 *** andythenorth has joined #openttd
08:33:25 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth updated pull request #6811: Feature: Add NotRoadTypes (NRT) https://git.io/vhlfg
08:43:17 <andythenorth> moin
08:53:39 <nielsm> hell-o
09:02:56 <andythenorth> cdist :P
09:03:14 <andythenorth> adding more trains at one node to clear the station
09:03:22 <andythenorth> just piles up pax at the next node :P
09:03:33 <andythenorth> adding more trains to that node to clear it
09:04:07 <andythenorth> they bring more pax back to the middle node
09:04:24 <andythenorth> can never clear the network :P
09:04:30 <andythenorth> some nodes will always be overflowing
09:11:14 *** Thedarkb-X40 has quit IRC
09:12:50 <nielsm> considered whether it might make sense to have a fast service cutting through some other transfer points?
09:13:19 <andythenorth> if it's fast enough
09:13:34 <andythenorth> the intermediate nodes will start distributing traffic onto the fast service :P
09:13:39 <andythenorth> you can't beat cdist :P
09:13:58 <andythenorth> except with 999mph trains with 2048 pax each
09:28:09 *** Wacko1976_ has quit IRC
09:36:27 *** synchris has joined #openttd
09:47:14 *** Borg has joined #openttd
09:58:15 *** chomwitt has joined #openttd
10:21:41 *** Progman has joined #openttd
10:37:04 *** Wolf01 has joined #openttd
10:37:08 <Wolf01> o/
10:39:37 <andythenorth> hi
10:43:00 <Borg> hoooi :)
10:48:43 *** Gabda has joined #openttd
11:01:44 <TrueBrain> still weird; for some CIs te start I have to visit the Azure Pipelines website, but not for all CI jobs
11:01:52 <TrueBrain> this needs more investigation :D
11:03:37 <TrueBrain> andythenorth: translation warnings in NRT
11:03:40 <TrueBrain> might be worth fixing :)
11:07:53 <TrueBrain> segfaults on Linux :D
11:07:54 <TrueBrain> nice
11:08:15 <TrueBrain> so yeah ... work to do :D
11:11:39 <TrueBrain> and MacOS doesn't stop when regression crashes, it seems
11:11:43 <TrueBrain> cancelled the job :)
11:14:18 <andythenorth> TrueBrain: translation warnings in form of 'x does not exist in master file'?
11:14:26 <andythenorth> or something else?
11:15:10 <TrueBrain> check the Pull Request results :)
11:15:25 <andythenorth> I did
11:15:38 <andythenorth> it just says build cancelled
11:15:44 <TrueBrain> so click the link
11:15:48 <TrueBrain> dig deeeeper
11:16:06 <andythenorth> got it
11:16:47 <andythenorth> 4 warnings
11:16:56 *** HerzogDeXtEr has quit IRC
11:16:59 <TrueBrain> and you want to look into why regression crashes :)
11:17:16 <TrueBrain> glx was busy adding it for Windows, but not sure where that is at
11:18:03 <andythenorth> what I really want is to stop having no_sound.obs and friends
11:18:14 <andythenorth> I guess I just add that to my local .gitignore
11:18:18 <andythenorth> and everyone else does too
11:18:28 <nielsm> a standard tool to clean up strings from translations would be nice imo
11:18:49 <andythenorth> nielsm: like this one? :P https://dev.openttdcoop.org/projects/iron-horse/repository/entry/bin/remove_dead_lang_strings.py
11:19:07 <andythenorth> only better
11:19:28 <andythenorth> where even is my .gitignore?
11:19:30 * andythenorth looks
11:19:40 <andythenorth> I hate modifying system-wide things for specific project
11:19:44 <andythenorth> it's dumbass
11:19:56 <andythenorth> and fragile
11:20:59 <andythenorth> these people who are like 'oh I just symlinked that from /bin and edited my bash conf'
11:21:16 <andythenorth> are the people who are like "can't do any work today, rebuilding my system again"
11:22:11 <Eddi|zuHause> andythenorth: there's usually a systemwide one, a project specific one, and a checkout specific one
11:22:21 <LordAro> and a user specific one
11:22:25 <andythenorth> ok so let's try and fix the root cause
11:22:34 <andythenorth> what am I doing wrong to cause these to be generated?
11:22:34 <andythenorth> https://paste.openttdcoop.org/pyrvrjpwp
11:22:37 <andythenorth> it must be user error?
11:22:54 <andythenorth> to build openttd I do 'make run -j13'
11:23:04 <TrueBrain> you have grfcodec or one of these installed
11:23:09 <TrueBrain> most people don't
11:23:17 <andythenorth> right, so I need to remove grfcodec from my path?
11:23:17 <TrueBrain> so for "normal people" those are not created
11:23:19 <TrueBrain> I was told last time
11:23:25 <TrueBrain> (rumours! I dont know if it is true)
11:23:27 <Eddi|zuHause> andythenorth: i think it's an error that should be resolved project-wide
11:23:29 <andythenorth> so I need a system for newgrf dev
11:23:34 <andythenorth> and a system for openttd dev
11:23:38 <TrueBrain> just add them to gitignore
11:23:41 <andythenorth> new laptop time!
11:23:41 <TrueBrain> I mean ... wont hurt anyone
11:23:42 <nielsm> yeah they are generated from a template and translations, so when the translations are updated and you have the tools to rebuild those files, they get rebuilt
11:23:43 <Eddi|zuHause> andythenorth: it's not specific to yourself
11:23:55 <LordAro> there might be a configure flag for dsiabling grfcodec
11:24:06 *** sla_ro|master has joined #openttd
11:24:13 <Eddi|zuHause> really, the translator commits should cover these
11:24:26 <nielsm> that would make the most sense yes
11:27:10 *** JimAcid has joined #openttd
11:28:28 <andythenorth> we have some work projects
11:28:32 <andythenorth> where you make a change and just ship it
11:28:47 <andythenorth> and others where touching anything, you discover that ~everything needs rebuilt
11:28:55 <andythenorth> OpenTTD is close to the second :P
11:29:28 <andythenorth> obvs. the size of the project usually correlates
11:29:33 <Eddi|zuHause> andythenorth: https://xkcd.com/1700/
11:29:37 <LordAro> some things are dependencies of everything :p
11:30:08 <nielsm> visual studio rebuilding almost all files when english.txt is updated is very annoying
11:30:31 <LordAro> make does the same
11:31:02 <Eddi|zuHause> that's because english.txt gets turned into a header file which is included in almost every cpp file
11:31:04 <LordAro> i don't think there's any way around it, due to string tables
11:31:26 <Eddi|zuHause> so each of these files must be rebuilt
11:31:39 <LordAro> needs more C++ modules
11:31:43 <LordAro> probably
11:31:54 <andythenorth> it took me a few years before I realised that all of this is what *success* looks like :P
11:31:56 <Eddi|zuHause> dunno what that would solve
11:31:57 <andythenorth> rather than failure
11:32:49 <andythenorth> TB it's nice that the azure page shows the warning in orange
11:32:52 <andythenorth> https://dev.azure.com/openttd/OpenTTD/_build/results?buildId=97
11:33:11 <TrueBrain> too bad it only does it for Windows
11:33:16 <andythenorth> oof
11:33:22 <andythenorth> well it's helpful :)
11:33:30 <LordAro> andythenorth: i've spent a significant time at work fixing/adding loads of build dependencies, so that people can now (fairly) reliably do incremental builds, rather than having to clean almost every time something unexpected changes
11:33:41 <andythenorth> time saved
11:33:45 <LordAro> when the build takes best part of an hour, this is significant
11:34:05 <Eddi|zuHause> dependencies is tricky
11:34:21 <andythenorth> we parallelised our selenium tests, than moved them to an EC2 pool, to reduce cycle times
11:34:47 <andythenorth> if commit->tests-fail is like 1 hour or more
11:34:49 <andythenorth> that's useless
11:35:02 <LordAro> yeah
11:35:20 <LordAro> we recently got several threadripper build servers (with all the cores)
11:35:26 <LordAro> cut build times in half
11:35:34 <LordAro> (and test times)
11:36:34 <andythenorth> I don't understand this warning
11:36:36 <andythenorth> "src/lang/indonesian.txt:4329: warning: String name 'STR_ERROR_CROSSING_DISALLOWED' does not exist in master file"
11:37:05 <andythenorth> oh I do, it was a bad grep
11:38:08 <andythenorth> can we merge this yet?
11:38:10 <andythenorth> https://github.com/OpenTTD/OpenTTD/pull/6917
11:38:23 <LordAro> i think so :p
11:38:29 <andythenorth> to do any openttd dev, I have to have a branch, then a separate branch with 6917+my branch
11:38:33 <andythenorth> then merge them constantly
11:39:45 <andythenorth> it was approved 8th Dec
11:39:54 <andythenorth> 3rd / 8th /s
11:40:04 <andythenorth> so what's the deal with getting approved PRs merged?
11:40:07 <andythenorth> who do I bribe?
11:40:08 <TrueBrain> needs a rebase for sure :)
11:41:22 <LordAro> bleh
11:41:38 <Eddi|zuHause> Passierschein A38
11:46:12 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth updated pull request #6811: Feature: Add NotRoadTypes (NRT) https://git.io/vhlfg
11:46:27 <andythenorth> probably need to rebase -i that :P
11:47:16 <andythenorth> hmm, how do I squash non-consecutive commits
11:47:17 <TrueBrain> you need to fix the crash first anyway, so that can wait :D
11:47:37 <andythenorth> no no the admin must be correct
11:47:42 <andythenorth> even if the code doesn't work
11:47:52 <andythenorth> engineering is bureaucracy :P
11:48:41 <TrueBrain> I am a bit annoyed that a crash can keep the regression from continueing .. we should fix that :(
11:48:54 <nielsm> now why is it repeatedly relinking strgen.exe for me... there aren't any changes to it
11:49:00 <Wolf01> andythenorth: since when there is 2.0 after 1.9?
11:49:08 <andythenorth> since we should
11:49:09 <andythenorth> in 2020
11:49:12 <andythenorth> because 2020
11:49:14 <andythenorth> and v2
11:49:19 <andythenorth> but yes
11:49:22 <andythenorth> I agree
11:49:27 <andythenorth> except v2 is better
11:49:29 <Wolf01> Bah, I want RCT terrain for 2.0
11:49:41 <Wolf01> After 1.9 there is 1.10 :P
11:49:44 <Eddi|zuHause> for sure the next version after 1.9 needs to be 20
11:50:44 <Eddi|zuHause> that way we can release OpenTTD 20.04 which will never be in the corresponding Ubuntu 20.04
11:50:52 <nielsm> meh yeah, the scale for my candy drill rig is wrong, it needs to be 2x in every dimension (visually)
11:51:41 <Eddi|zuHause> nielsm: primary rule of newgrf development: the scale is always wrong
11:54:06 <andythenorth> the scale is wrong
11:54:15 <andythenorth> just treat it like Lego
11:55:42 <andythenorth> ha ha, I found how to change my git editor
11:56:08 <andythenorth> oh it crashed
11:56:09 <andythenorth> nvm
12:01:40 <JimAcid> hi to all, I have a question, I remember that I was able to built roads end buildings over tunnel exits, but somehow I cant find how to enable it
12:01:48 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth updated pull request #6811: Feature: Add NotRoadTypes (NRT) https://git.io/vhlfg
12:01:59 <nielsm> I wonder if autodesk 360 would be better to model a technical-ish model with animation in? :D
12:02:38 <nielsm> JimAcid: that's the "new map features" patch: https://www.tt-forums.net/viewtopic.php?f=33&t=58420
12:02:49 <nielsm> it's not in the mainline version of ottd
12:03:23 <andythenorth> "src\tunnelbridge_cmd.cpp(723,0): Warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data" o_O
12:04:02 <nielsm> andythenorth: the win64 build has had that warning for a while now
12:04:08 <JimAcid> nielsm thank you
12:08:33 <andythenorth> so a crash in linux
12:08:41 * andythenorth no linux :P
12:08:46 <TrueBrain> Mac also fails
12:08:51 <TrueBrain> but the crash is not showing up because of bugs
12:08:59 <TrueBrain> and I strongly suspect the Windows also crashes
12:09:03 <TrueBrain> as there is a BUG
12:09:04 <TrueBrain> :)
12:09:50 <TrueBrain> _Z14GetAnyRoadBitsj8RoadTypeb <- part of the traceback
12:09:54 <TrueBrain> pretty sure it is NRT related :P
12:11:29 <andythenorth> hmm
12:11:36 <andythenorth> my local build is useless to diagnose this :P
12:11:46 <andythenorth> I can only compile with a havk
12:11:48 <andythenorth> hack *
12:11:57 <andythenorth> not science
12:12:01 <TrueBrain> and you think regression result changes because of that?
12:12:07 <TrueBrain> you are just looking for excuses to not look into this :)
12:12:29 <TrueBrain> you can safely assume that how ever you compile NRT, it will always crash regression :P
12:12:33 <andythenorth> wait, so it's a failing test?
12:12:35 <andythenorth> not a failing build?
12:12:54 <TrueBrain> did me telling you 10 times now it is a regression crash gave that away?
12:13:02 <TrueBrain> open the build results andythenorth .. :)
12:13:10 <TrueBrain> click on the full logs
12:13:14 <TrueBrain> scroll allllll the way down
12:13:48 <TrueBrain> https://dev.azure.com/openttd/OpenTTD/_build/results?buildId=99&view=logs&jobId=1100b651-10a9-541e-a625-0895f51cf5ef&taskId=f60a854d-b0b3-5331-77bc-16419f352ef3&lineStart=2382&lineEnd=2383&colStart=1&colEnd=1
12:14:06 <TrueBrain> hmm, that is stupid, that doesn open the logs
12:14:14 <TrueBrain> why does it show me a 'link' icon, if it doesnt link
12:14:56 <TrueBrain> I found a bug in Azure Pipelines I guess ... owh well
12:15:01 <TrueBrain> means you have to click it yourself :D
12:17:49 <andythenorth> I was looking at https://dev.azure.com/openttd/OpenTTD/_build/results?buildId=97&view=logs&lineStart=2589&jobId=1100b651-10a9-541e-a625-0895f51cf5ef&taskId=f60a854d-b0b3-5331-77bc-16419f352ef3
12:18:17 <andythenorth> 2585-2588
12:18:31 <andythenorth> I thought the makefile had died
12:38:43 <andythenorth> what do I need to build to get regression tests?
12:39:10 <andythenorth> can't find anything in CONTRIBUTING.md or README.md
12:39:46 <TrueBrain> make regression
12:39:46 <TrueBrain> :D
12:39:55 <TrueBrain> weird if it isnt mentioned in the readmes
12:40:04 <andythenorth> Azure test run shows ai/regression path, but I don't have it
12:40:09 <andythenorth> not mentioned
12:40:11 <andythenorth> afaict
12:40:17 <andythenorth> maybe in wiki?
12:40:18 * andythenorth looks
12:40:33 <andythenorth> https://wiki.openttd.org/To_do_for_releases
12:40:48 <andythenorth> oh it's bin/ai
12:40:49 <andythenorth> ok
12:41:14 *** chomwitt has quit IRC
12:41:49 <andythenorth> so any PR should have make regression run first, really
12:42:06 <TrueBrain> that is what the CI does :)
12:42:19 <andythenorth> it's noisy if the author doesn't do it
12:42:52 <andythenorth> so todo:
12:42:52 <TrueBrain> guess because it was never easy to do it on Windows, it isnt mentioned anywhere
12:42:56 <TrueBrain> so glx should finish his work :)
12:42:58 <andythenorth> - update docs
12:43:02 <andythenorth> - update .gitignore
12:43:05 <andythenorth> - rebase 6917
12:43:14 <andythenorth> - then learn how regression tests work
12:43:28 <TrueBrain> you cannot gitignore btw, I noticed. Those files are already in git, so they are always tracked
12:43:36 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh approved pull request #6995: Fix 59e42ea17, 1f083c3ac: make clean was not fully cleaning https://git.io/fh3RA
12:43:36 <andythenorth> ok
12:43:51 <andythenorth> update ~./gitignore then :P
12:44:06 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh merged pull request #6995: Fix 59e42ea17, 1f083c3ac: make clean was not fully cleaning https://git.io/fhk6u
12:44:24 <andythenorth> also todo: take children to soft play center
12:44:30 <andythenorth> such
12:44:40 <TrueBrain> sounds like a higher priority than the rest :P
12:45:00 <andythenorth> all I wanted was tramways with optional catenary :P
12:45:07 <andythenorth> NRT overkill :P
12:45:10 <TrueBrain> you wanted too much :D
12:49:40 <andythenorth> well at least I get to click all the buttons in Azure
12:49:56 <andythenorth> it has the same mystery meat feel as old jenkins
12:50:48 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh opened pull request #7012: Play Fluidsynth music through the mixer https://git.io/fh30T
12:51:21 <andythenorth> so the test fails silently on macOS?
12:51:27 <andythenorth> or gets stuck in a loop?
12:51:28 <nielsm> there we go, more music stuff! and also the foundation for actual sampled music support
12:51:47 <andythenorth> 🎼
12:52:13 <andythenorth> "-n Running ai/regression/tst_regression..." is getting boring to look at :P
12:53:47 <nielsm> hmm more stuff I should check/try on my linux machine while I have it up? :)
12:54:01 <andythenorth> NRT :P
12:54:32 <andythenorth> I guess it's not linux specific failure though
12:54:42 <andythenorth> https://github.com/OpenTTD/OpenTTD/pull/6811
12:55:13 <nielsm> "git fetch andy"
12:55:15 <nielsm> :P
12:55:33 <TrueBrain> andythenorth: again, regression is very likely to fail on any platform
12:55:43 <TrueBrain> sadly, the MacOS has a bug where if it crashes, it is not reported correctly
12:55:46 <TrueBrain> so .. it hangs
12:55:49 <TrueBrain> same when there are no GFX
12:56:02 <TrueBrain> (Windows also hangs if the gfx could not be loaded)
12:56:03 <andythenorth> that makes reading the test failure....harder :)
12:56:10 <TrueBrain> that is why you run it locally
12:56:12 <TrueBrain> and see what happens
12:56:21 <TrueBrain> the linux variant do show a backtrace, as I mentioned earlier :)
12:56:36 * andythenorth must now buy a linux computer
12:56:38 <TrueBrain> but if you run 'make regression' on your local machine, it should crash too :)
12:56:44 <TrueBrain> there is 0 need to do any of that
12:57:07 <TrueBrain> most likely the MacOS crash reported shows a dialog with the information
12:57:12 <TrueBrain> sadly, this is a poor idea for a CI
12:57:39 <TrueBrain> but on your local machine, that should be fine
12:57:46 <andythenorth> it doesn't do that
12:57:49 <andythenorth> it just hangs
12:57:55 <TrueBrain> so someone fucked up months ago already ;)
12:57:58 <andythenorth> no success / failure messages in stdout
12:58:01 <andythenorth> at all
12:58:21 <nielsm> building nrt branch now
12:58:24 <TrueBrain> I like how over 10 years the regression hasnt gotten any real attention, to the point it is simply forgotten :D
12:58:53 <TrueBrain> andythenorth: possibly if you attach gdb to it,it will report the crash
12:59:28 <nielsm> yeah I was about to suggest that, maybe run regressions under gdb in an automated manner, to catch crashes and maybe dump backtrace to the console
12:59:30 <TrueBrain> I wonder if the crash reporting works at all on MacOS ..
12:59:42 <TrueBrain> nielsm: we have crash reporting that does that
12:59:51 <TrueBrain> if you check the linux stuff, that is exactly what it does :)
13:00:05 <TrueBrain> on Windows we make a crash.log for this
13:00:13 <andythenorth> macOS gets crash.log
13:00:15 <TrueBrain> guess if regression fails we should output that content
13:00:24 <TrueBrain> andythenorth: well, that is good :)
13:01:11 <TrueBrain> if you run the 'regression.sh' with -g
13:01:13 <andythenorth> macOS doesn't get crash.log from regression it seems :P
13:01:14 <TrueBrain> it attaches gdb for you
13:01:46 <TrueBrain> so in bin: ai/regression/run.sh -g
13:01:53 <andythenorth> so... tmp.regression
13:01:55 <andythenorth> what is that?
13:01:59 <andythenorth> looks like a log
13:02:04 <TrueBrain> temporary stdout/stderr file
13:02:05 *** sushibear has quit IRC
13:02:39 <nielsm> https://github.com/andythenorth/OpenTTD/blob/master/src/tile_map.h#L91
13:02:42 <nielsm> that assert fails
13:02:46 <nielsm> when I run make regression
13:02:57 <andythenorth> ok
13:03:05 <andythenorth> fail the PR then I guess :)
13:03:05 <TrueBrain> lol .. that is bad :D
13:03:24 <TrueBrain> means something went wrong before that
13:03:47 <andythenorth> well
13:04:14 <andythenorth> that is probably the wrong rabbit hole for today
13:04:21 <andythenorth> but the PR fails
13:04:26 <TrueBrain> just make someone else fix it :D
13:04:44 <andythenorth> how about TrueBrain?!
13:04:57 <TrueBrain> I rather focus on the infrastructure
13:05:03 <TrueBrain> so we can release 1.9, and get NRT in for the next release
13:05:10 <andythenorth> far too sensible
13:05:19 <andythenorth> NRT isn't actually a priority for me
13:05:27 <andythenorth> I am doing this to learn how Azure and the tests work
13:05:43 <andythenorth> and practice rebasing and crap
13:06:04 * andythenorth is supposed to be drawing trains but eh
13:06:43 <TrueBrain> CI needs a lot of attention to become really useable :)
13:06:55 <TrueBrain> but that has no priority on my side ;)
13:07:04 <DorpsGek_II> [OpenTTD/website] TrueBrain opened pull request #14: Add: [#8] add 404/500 pages to serve when page-not-found / internal-server-error https://git.io/fh30g
13:07:55 <TrueBrain> getting ^^ reviewed does :D
13:07:58 <TrueBrain> :D:D
13:08:04 <DorpsGek_II> [OpenTTD/website] nielsmh commented on pull request #14: Add: [#8] add 404/500 pages to serve when page-not-found / internal-server-error https://git.io/fh30w
13:08:17 <TrueBrain> nielsm: it is?
13:08:20 <andythenorth> I was already looking :P
13:08:28 <Borg> NOOOOOOOO
13:08:29 <Borg> (0 << 0x0C) // newagerating
13:08:37 <Borg> no .ini var to set it.... :(
13:08:50 <TrueBrain> nielsm: for me that sounds like a fine sentence; can you indicate to me what is weird about it? (honest question)
13:09:33 <andythenorth> just approve them if the nginx is correct, then I'll fix the pages later
13:09:34 <nielsm> "procedure" is not a verb
13:09:40 <TrueBrain> to produce?
13:09:42 <nielsm> I think "produce" is the intended
13:09:44 <andythenorth> process
13:09:47 <nielsm> or process
13:09:50 <andythenorth> provide
13:09:51 <nielsm> or procure
13:09:59 <andythenorth> or just delete that sentence
13:10:03 <TrueBrain> ah! :D
13:10:09 <TrueBrain> well, I misread my own sentence only 10 times
13:10:10 <andythenorth> cute error messages died about 7 years ago
13:10:37 <TrueBrain> its not meant to be cute andythenorth :D
13:11:00 <andythenorth> at some point we need to not start our heading hierarchy with <h3>
13:11:05 * andythenorth also must fix that
13:11:12 <andythenorth> we need more of some people
13:11:16 <andythenorth> notably andythenorth
13:11:16 <DorpsGek_II> [OpenTTD/website] TrueBrain updated pull request #14: Add: [#8] add 404/500 pages to serve when page-not-found / internal-server-error https://git.io/fh30g
13:11:18 <TrueBrain> tnx nielsm; I really failed to read what I wrote :)
13:11:31 <andythenorth> I really failed to wrote what I read
13:11:49 <TrueBrain> when I was reading that sentence in my head, I kept reading produce :)
13:11:58 <TrueBrain> funny .. how brains are weird :D
13:12:20 <andythenorth> WAVE hates our page :P
13:12:40 <TrueBrain> good thing about it being on GitHub, that it is more likely someone will come and fix all these things :)
13:12:43 <andythenorth> W3 validator hates it too
13:12:56 <TrueBrain> it used to validate! :o
13:13:06 <TrueBrain> (we used to have a very high score on all these things .. 10 years ago :P)
13:13:19 <andythenorth> it's trivial things
13:13:51 <andythenorth> we could run TV on commits :P https://www.totalvalidator.com/index.html
13:13:55 <andythenorth> works great
13:14:09 <andythenorth> £5 / license, I pay
13:14:16 <andythenorth> you set it up on Docker :P
13:14:39 <TrueBrain> lol
13:15:01 <TrueBrain> its a gui tool :(
13:15:09 <andythenorth> it plays nice with jenkins
13:15:13 <andythenorth> we use it at work, I love it
13:15:14 <andythenorth> but eh
13:15:16 <andythenorth> maybe not
13:15:33 <andythenorth> oof I just found a CI tool in Docker for validating Docker images for your CI
13:15:51 <andythenorth> so you can use your CI to check the images you build your CI with
13:15:53 <andythenorth> so you can CI
13:15:56 <andythenorth> to make more images
13:15:57 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh requested changes for pull request #6811: Feature: Add NotRoadTypes (NRT) https://git.io/fh305
13:16:15 <TrueBrain> anyway, that tool can for sure be useful to remove a lot of issues to start with :)
13:16:26 <TrueBrain> but .. I hope others will contribute for these things :)
13:16:32 <andythenorth> $others
13:16:34 <TrueBrain> I amgoing to try to keep a focus on moving everything to github
13:17:47 <DorpsGek_II> [OpenTTD/website] nielsmh approved pull request #14: Add: [#8] add 404/500 pages to serve when page-not-found / internal-server-error https://git.io/fh30x
13:17:58 <andythenorth> focus :D
13:18:10 <andythenorth> so many distractions https://fit2b.us/wp-content/uploads/2015/11/internet-mess.jpg
13:18:19 <DorpsGek_II> [OpenTTD/website] nielsmh merged pull request #14: Add: [#8] add 404/500 pages to serve when page-not-found / internal-server-error https://git.io/fh30g
13:18:57 <andythenorth> has LordAro rebased 6917 yet? :D
13:19:17 <TrueBrain> tnx nielsm :)
13:19:36 <TrueBrain> holy crap @ that room ... someone should be fired
13:19:44 <Borg> its shame.. there is no way to set _ttdpatch_flags[] I mean enable/disabl bits.. via NewGRF or sth like that..
13:20:02 <andythenorth> that would be ass backward Borg :)
13:20:08 <andythenorth> what case is there for that?
13:20:12 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on issue #7006: Hardware mouse cursor https://git.io/fh3Ev
13:20:33 <Borg> andythenorth: (0 << 0x0C) // newagerating
13:21:24 <andythenorth> what does it even do? o_O
13:21:36 <andythenorth> station rating?
13:21:40 <Borg> change how station rating is calculated (one of the bonuses)
13:22:36 <Borg> actually. it should be pretty easy to implement ActD _ttdpatch_flags[] writing via 2 new commands.. setbv1 setbv0
13:24:51 <Borg> actually it fits pefectly
13:25:16 <Borg> first you call InitializeGRFSpecial() and then.. when NewGRF is initialized.. it can alter some bits via ActD
13:26:10 <andythenorth> newgrf setting player flags violates proper domain
13:26:12 <andythenorth> but eh
13:26:22 <andythenorth> 'probably fine' :P
13:26:54 <nielsm> I'd rather have the newgrf disable itself and show an error if the game flags are set wrong for its purpose
13:27:23 <Borg> nielsm: best would be to have proper .ini to access all flags
13:27:23 <nielsm> what if two newgrfs tried changing the same flag to opposite values?
13:27:24 <TrueBrain> hmm .. we really need a 'latest.html' for downloads .. you don't want to list your latest release as a versioned-URL
13:27:41 <Borg> nielsm: yeah.. thats the problem :)
13:27:46 <andythenorth> http://bundles.openttdcoop.org/firs/releases/LATEST/
13:28:05 <andythenorth> dunno how it works, probably magic
13:28:07 <TrueBrain> andythenorth: and that in jekyll :)
13:28:22 <andythenorth> we need planetmaker to join this party
13:28:22 <TrueBrain> I do have an idea :D
13:28:27 *** Gabda has quit IRC
13:28:34 <TrueBrain> every party needs a planetmaker :)
13:29:15 <Borg> I see other interesting flags too
13:29:29 <Borg> presignals.. for example..
13:29:35 <Borg> so if 0 ? only block + pbs?
13:30:03 <nielsm> yes except that you can't disable pbs in openttd (afaik?)
13:30:23 <Borg> yep, there is no flag for it..
13:30:23 <nielsm> or presignals
13:30:34 *** Gabda has joined #openttd
13:30:37 <Borg> hmm I see potential for _ttdpatch_flags[] modifing! :)
13:30:52 <nielsm> consider that the var you're looking at is called ttdpatch flags
13:30:54 <nielsm> not openttd flags
13:31:15 <Borg> right..
13:31:19 <Borg> it seems not used anywhere..
13:31:49 <Borg> okey.. forgot it.. it seems I got carried away
13:33:24 *** JimAcid has quit IRC
13:34:29 <Eddi|zuHause> Borg: most of the ttdpatchflags are hardcoded in openttd, others are mapped to ingame settings
13:34:58 <TrueBrain> andythenorth: the base stuff fails for 404 pages .. they can be in any folder :D
13:35:07 <TrueBrain> that needs a reinvestigation, I guess :P
13:35:33 <TrueBrain> why did we do it this way again? (totally forgot)
13:35:36 <Eddi|zuHause> "i herd u like failure so we put some failure in ur failpages"
13:35:47 <TrueBrain> (example: https://www.staging.openttd.org/downloads/catcodec-releases/adas)
13:36:23 <Eddi|zuHause> was catcodec ever used by more than 5 people?
13:39:56 <nielsm> do sound effects still need to be packed in cat files?
13:39:58 <nielsm> even
13:41:10 <Eddi|zuHause> not sure
13:41:23 <Eddi|zuHause> theoretically you can also put sounds into a .grf file
13:41:32 *** Flygon has quit IRC
13:41:37 <Eddi|zuHause> but i have no clue if openttd accepts that as a baseset
13:41:49 <nielsm> I don't think it would work as baseset no
13:42:05 <nielsm> but could be used as static newgrf overriding default sounds, I think
13:42:26 * andythenorth bbl
13:43:02 <Eddi|zuHause> i don't see a reason why it couldn't use a .tar file or simple directory as baseset either, but probably nobody bothered implementing that either
13:43:27 <nielsm> you'd need a more complete wav file reader then :)
13:45:29 <nielsm> was it not actually longer? https://github.com/nielsmh/OpenTTD/commit/3a3e0802eb3b084e8640b7759f64e99579024142#diff-a38b8a5f16c15ef8031a2a99263f5be8
13:45:39 <nielsm> I remember spending way too music time getting that hack to work
13:50:28 *** andythenorth has quit IRC
13:52:15 *** Samu has joined #openttd
13:54:46 <nielsm> what would everyone think about adding a soft dependency on ffmpeg for playing sampled music in-game?
13:56:14 <TrueBrain> you and your music :D
13:56:32 <DorpsGek_II> [OpenTTD/website] TrueBrain closed issue #8: No 404/500 html pages https://git.io/fhO17
13:57:43 <nielsm> or could just make something with libogg+libvorbis and support that as the only choice
13:58:11 <Eddi|zuHause> people will demand .flac support
13:58:28 <Eddi|zuHause> and by "people" i mean "that one person"
13:58:34 <nielsm> heh
13:59:10 <TrueBrain> :D
13:59:44 <nielsm> OPL3 emulation for the original adlib music is a more interesting project though =)
14:14:10 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh opened pull request #7013: Fix 6accbf9: Silence warnings about unused fread() result https://git.io/fh3ua
14:20:18 <planetmaker> I heard 'party'? :D
14:27:24 <TrueBrain> if this is your reponse time to parties .... :P
14:29:31 <Eddi|zuHause> github #7000 party?
14:29:53 <TrueBrain> lets do 10k :P
14:31:06 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh opened pull request #7014: Fix 6a3d411: Silence truncation warning https://git.io/fh3uh
14:38:44 *** Gabda has quit IRC
14:43:07 *** Progman has quit IRC
14:44:48 <TrueBrain> okay .. I want to download a file from a system that is purposely isolated from the ability to download from
14:44:49 <TrueBrain> hmm
14:45:07 <TrueBrain> (OpenTTD's main webserver is fully isolated, and only accepts port 80 traffic)
14:45:26 <TrueBrain> (a security aspect)
14:45:40 <TrueBrain> but I want the access.log from it, so I can check if I redirect all the URLs correctly :D
14:46:41 <nielsm> heh
14:47:15 <nielsm> let it connect to a logging server?`
14:47:26 <TrueBrain> the logging server too is fully isolated, but even worse
14:47:34 <nielsm> .-.
14:47:36 <TrueBrain> write-once etc etc
14:47:51 <TrueBrain> well, you want those systems to be very well protected :D
14:48:08 <TrueBrain> logging servers tend to contain data, that is broken into, are pretty .... hurtful :D
14:48:33 <TrueBrain> and I can request data from it, but not in a bulk-way :)
14:49:02 <TrueBrain> people are still requesting URLs on www.openttd.org that link to the old website ... 15 years ago
14:49:43 <planetmaker> might even be in our own wiki, the old links
14:49:53 <TrueBrain> I guess
14:49:56 <TrueBrain> screens.php
14:50:01 <TrueBrain> we havent been running php in .. euh .. a long time :P
15:03:11 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #7013: Fix 6accbf9: Silence warnings about unused fread() result https://git.io/fh3zF
15:07:39 <TrueBrain> 1650 valid URLs were served by www.openttd.org in the last 3 months
15:07:42 <TrueBrain> excluding server-listing hits
15:07:45 <TrueBrain> lol
15:10:42 <TrueBrain> over a 1000 of those are "hacking" attempts, which happened to hit an URL that returned a 200
15:10:43 <TrueBrain> lol
15:11:34 <Eddi|zuHause> a few years ago i watched a lecture about "how to run a tracker" where they said they accept "/announce.php" simply because people randomly write that into their torrents
15:12:27 <TrueBrain> hmm .. current URLs for news are like /en/news/123
15:12:32 <TrueBrain> the new URLs are different
15:12:34 <TrueBrain> do I want to map those
15:12:46 <TrueBrain> RSS and Atom feed .. hmm
15:13:02 <Eddi|zuHause> they also said they actually accept any url with "/a", because it's just wasted effort to check more, and they want to optimize for speed :p
15:13:13 <TrueBrain> https://www.openttd.org/en/download-all <- why did I ever make that page ..
15:13:20 <TrueBrain> well, that page will be gone, okay? :)
15:14:27 <Eddi|zuHause> i've no idea which target audience you wanted to reach with that page :p
15:15:18 <TrueBrain> 10 years ago it most likely was a very good idea
15:15:18 <TrueBrain> :D
15:15:26 <TrueBrain> okay .. I only offer download URLs for the last 90 nightlies
15:15:32 <TrueBrain> we used to support all of them
15:15:40 <TrueBrain> but that is 4000 more HTML pages
15:16:10 <Eddi|zuHause> there's a price for only serving static pages
15:16:16 <TrueBrain> :D
15:16:53 <Eddi|zuHause> just point them to the ftp-mirror for the older ones?
15:24:19 <LordAro> TrueBrain: i've never heard of anyone using atom, but would be a shame to lose rss
15:24:40 <TrueBrain> funny enough, Jekyll comes with Atom,not with RSS :P
15:24:46 <LordAro> ha
15:26:16 <LordAro> TrueBrain: nginx.default.conf refers to 50x.html, but 500.html exists
15:26:19 <TrueBrain> "Great question. In short, Atom is a better format. Think of it like RSS 3.0. For more information, see this discussion on why we chose Atom over RSS 2.0."
15:26:20 <TrueBrain> :D
15:26:32 <TrueBrain> LordAro: lol .. knew I forgot something
15:26:58 <TrueBrain> LordAro: https://github.com/jekyll/jekyll-feed/issues/2
15:27:34 <LordAro> interesting
15:27:40 <LordAro> (i don't use either, so..)
15:27:43 <TrueBrain> will see if there is another plugin to also give RSS :P
15:28:48 <Borg> guys.. Act7 or Act9 ?
15:28:59 <Borg> I read the comments... still not sure :) I motly use Act7
15:29:08 <Borg> s/motly/mostly/
15:29:09 <nielsm> does any tool of note still not support atom?
15:29:56 <TrueBrain> nielsm: they debate all tools do, except Apple :P
15:30:48 <TrueBrain> tempted to redirect the RSS to Atom :P
15:31:18 <TrueBrain> 129015 www.openttd.org /en/news/atom 200
15:31:18 <TrueBrain> 460652 www.openttd.org /en/news/rss 200
15:31:21 <TrueBrain> 3 times more RSS hits
15:31:21 *** andythenorth has joined #openttd
15:37:08 <TrueBrain> andythenorth: why again did you do this {{ base }} stuff?
15:37:12 <TrueBrain> why cant we do just / ?
15:37:19 <andythenorth> didn't you do it?
15:37:34 <TrueBrain> I haven't touched this (at all)
15:37:36 <andythenorth> hmm
15:37:40 <TrueBrain> you wrote base_variable.html :)
15:37:50 <andythenorth> I did?
15:37:54 <andythenorth> git doesn't lie
15:38:13 <TrueBrain> *facepalm* :P
15:38:24 <TrueBrain> so you dont remember why you did this?
15:38:29 <andythenorth> no
15:38:33 <TrueBrain> checking the depth of the page, and setting {{ base }} accordingly?
15:39:02 <TrueBrain> andythenorth: https://github.com/OpenTTD/website/blob/master/_includes/base_variable.html
15:39:03 <TrueBrain> that thing?
15:39:50 <andythenorth> what happens if we delete it?
15:40:36 * andythenorth deleting it
15:40:50 <TrueBrain> that is not the point; if you dont remember why you wrote it, it is hard to make any change to it, as you dont know what it solved :)
15:40:53 <TrueBrain> itmight be hiding :)
15:41:01 <TrueBrain> but okay .. I will replace it with {{ site.baseurl }}
15:42:00 <andythenorth> NFI, I rely on the commits to tell why
15:42:07 <andythenorth> but can't find relevant commit yet
15:42:33 <Borg> git log _include/base_variable.html ?
15:42:38 <andythenorth> just deleting it has no negative effects
15:43:51 <andythenorth> well it demands using 'jekyll serve' for local dev
15:43:52 <andythenorth> but eh
15:43:58 <andythenorth> that's not a hardship
15:44:02 <LordAro> TrueBrain: i've seen similar things used for when the site is not served at /
15:44:19 <LordAro> but if it's never intended to be anywhere else, it's probably fine
15:44:53 <TrueBrain> LordAro: that is called 'baseurl' :D
15:44:56 <TrueBrain> and Jekyll supports that :)
15:45:09 <andythenorth> delete delete
15:45:15 <TrueBrain> andythenorth: ah, wasnt it that you wanted to use it via file:// ?
15:45:23 <andythenorth> yeah but there's no need
15:45:33 <andythenorth> imo static html should not require a web server running
15:45:40 <andythenorth> but I don't need to win that argument here
15:46:00 <TrueBrain> you already lost :P
15:46:06 <TrueBrain> okay, then I will change it to baseurl :)
15:46:47 <TrueBrain> so does this also render a sitemap
15:48:26 * andythenorth wonders how this sprite generator works
15:48:33 <andythenorth> doubt anyone else is going to explain it to me
15:48:35 <andythenorth> as I wrote it :P
15:49:06 <andythenorth> maybe that reverse engineering guy could tell me https://dev.openttdcoop.org/projects/iron-horse/repository/entry/src/gestalt_graphics/pipelines.py
15:50:30 <TrueBrain> lol .. 800 lines :D
15:52:37 <andythenorth> think how much time I saved :P
15:52:45 <andythenorth> if only I knew how it worked :P
15:59:34 <TrueBrain> 235 mappings to map old news to new news :D
15:59:37 <TrueBrain> why noooottttt
16:12:16 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #7014: Fix 6a3d411: Silence truncation warning https://git.io/fh3rr
16:14:33 <TrueBrain> very useful, to have 600 URLs you know should be valid :D
16:15:29 <TrueBrain> 12 fail, rest works
16:15:40 <TrueBrain> and those 12, 8 are custom binaries we no longer do
16:16:03 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #7012: Play Fluidsynth music through the mixer https://git.io/fh3oO
16:18:12 <LordAro> TrueBrain: what are the remaining 4?
16:18:46 <TrueBrain> server-listing, stats, news/page/0, and a single screenshot
16:19:01 <TrueBrain> server-listing is a TODO, stats will be removed, fixed the pages, and the screenshot can kiss my ass :D
16:19:48 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #7009: Improve pathfinder behaviour for finding road depots (fix #7001; see #6410, #6928, #6929) https://git.io/fh3oC
16:21:17 <LordAro> seems a shame to lose stats
16:21:24 <LordAro> but not exactly feasible with a static site
16:21:34 <TrueBrain> not feasible with a cloud-solution
16:21:39 <LordAro> also that
16:21:52 <TrueBrain> and as we also want to enable Steam, Epic, Flatpack, Snap, ..
16:21:57 <TrueBrain> we will lose sight on downloads anyway
16:22:14 <TrueBrain> additionally, that stats page is VERY slow to load, and the table broke often and frequently :)
16:22:20 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #7002: Add: [Win32] regression testing with MSVC https://git.io/fh3o0
16:22:24 <TrueBrain> so yeah, I agree, it is a shame .. but ... guess progression sometimes means losing information
16:22:26 <LordAro> indeed :)
16:26:54 <DorpsGek_II> [OpenTTD/website] TrueBrain opened pull request #15: Add: [#9] Redirect old URLs to new URLs https://git.io/fh3oi
16:26:56 <TrueBrain> big blob :D
16:27:10 <TrueBrain> didnt feel like making 5 PRs, sorry about that :)
16:27:36 <LordAro> i'll cope :p
16:28:14 <TrueBrain> much appreciated :)
16:29:25 <DorpsGek_II> [OpenTTD/website] TrueBrain updated pull request #15: Add: [#9] Redirect old URLs to new URLs https://git.io/fh3oi
16:29:29 <TrueBrain> always finding this one bug just after pushing ... :D
16:30:56 <Samu> I have a problem with this function returning VehicleID 0 in test mode
16:30:59 <Samu> https://github.com/OpenTTD/OpenTTD/blob/master/src/script/api/script_vehicle.cpp#L64
16:31:09 <Samu> it could actually be a real vehicle
16:31:31 <TrueBrain> https://github.com/OpenTTD/website/blob/02caadd5b28fae776b1a34f9d5bbfce18907fc9e/nginx.default.conf <- for those who want to giggle
16:32:33 <DorpsGek_II> [OpenTTD/OpenTTD] Hezkore commented on issue #7006: Hardware mouse cursor https://git.io/fh3o5
16:33:22 <LordAro> TrueBrain: thoughts on using nginx to remove .html ?
16:33:31 <DorpsGek_II> [OpenTTD/website] LordAro approved pull request #15: Add: [#9] Redirect old URLs to new URLs https://git.io/fh3oA
16:33:34 <Samu> How do I check if I'm running in test mode vs exec mode?
16:33:45 <TrueBrain> LordAro: I .. checked .. seems I have no feeling for either one :)
16:34:08 <DorpsGek_II> [OpenTTD/website] TrueBrain merged pull request #15: Add: [#9] Redirect old URLs to new URLs https://git.io/fh3oi
16:34:12 <DorpsGek_II> [OpenTTD/website] TrueBrain closed issue #9: Redirect old URLs to new URLs https://git.io/fhOMe
16:34:21 <TrueBrain> tnx LordAro
16:35:48 <Samu> there's AIExecMode() and AITestMode(), but what I need is to know which mode the AI is currently running at
16:36:38 <andythenorth> hmm
16:36:40 <andythenorth> very pixels
16:38:44 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on pull request #7003: Feature #6918: Add option to adjust font size separately from GUI size. https://git.io/fh3KI
16:39:32 <Samu> moving the project to github is probably gonna be a bad decision in the long run
16:39:59 <Samu> everyone is editing it
16:40:14 <LordAro> ...and you think that's a bad thing?
16:40:27 <TrueBrain> collaboration is the worst!
16:40:31 <Samu> i can already see pull requests piling up
16:40:45 <LordAro> it's not like they weren't before
16:40:49 <LordAro> they just weren't so obvious
16:41:22 <peter1138> Contributions are bad? o_O
16:41:30 <TrueBrain> STOP DOING IT
16:41:36 <peter1138> I did :D
16:41:50 <TrueBrain> good
16:41:54 <LordAro> peter1138: you should finish your PRs :P
16:42:13 <TrueBrain> hmm .. 2 redirect lines are not hitting on staging
16:42:16 <TrueBrain> that is odd
16:42:49 <Eddi|zuHause> TrueBrain: it'll be a typo that is both obvious and impossible to find at the same time
16:43:38 <TrueBrain> oops, last minute change :D
16:43:45 <Eddi|zuHause> TrueBrain: and after you've searched yourself to death for 2 hours, someone else will come along, take a short look and immediately find it
16:44:35 <TrueBrain> took me 2 minutes, sorry :P
16:45:07 <Samu> I'm a guy with little faith and negative, so, maybe you see it in another way
16:45:09 <Eddi|zuHause> lucky :p
16:45:47 <TrueBrain> the thousands of projects on GitHub indeed give no indication what so ever that it is a good move :)
16:46:24 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on pull request #7005: Fix #7004: Redraw linkgraph overlay correctly after zoom https://git.io/fh3Kz
16:47:13 <Eddi|zuHause> <TrueBrain> STOP DOING IT <-- well "someone" wanted to change to github to get more contributions and better collaboration...
16:47:31 <TrueBrain> sounds like a horrible person
16:47:41 <Eddi|zuHause> he must have been an idiot...
16:48:04 <Samu> okay, I'm a different person
16:48:06 <DorpsGek_II> [OpenTTD/website] TrueBrain opened pull request #16: Minor mistakes in redirects https://git.io/fh3K2
16:48:23 <TrueBrain> no shit? SO AM I!
16:48:25 <TrueBrain> BESTIES!
16:49:07 <Samu> how would you decide what to merge, what not to merge, if the amount of code to review just keeps coming in form of pull requests?
16:49:09 *** Lejving has joined #openttd
16:49:20 <TrueBrain> luxary issues
16:49:21 <Samu> how can you control it
16:50:01 <DorpsGek_II> [OpenTTD/website] LordAro approved pull request #16: Minor mistakes in redirects https://git.io/fh3K6
16:51:16 <Samu> just worried it would get out of control one day
16:51:21 <andythenorth> same as we used to
16:51:23 <andythenorth> just ignore it
16:51:34 <andythenorth> there were hundreds of patches in flyspray and forums
16:51:43 <andythenorth> none of my patches were ever accepted
16:51:59 <andythenorth> but now we don't have to run our own git
16:52:11 <andythenorth> profit
16:52:21 <DorpsGek_II> [OpenTTD/website] TrueBrain merged pull request #16: Minor mistakes in redirects https://git.io/fh3K2
16:52:43 <andythenorth> hmm
16:52:50 <andythenorth> nielsm requested EMUs
16:53:02 <andythenorth> that means I need a sprite generator for pax coaches AND pantographs
16:53:10 <andythenorth> currently I have one of each, they don't mix
16:53:18 * andythenorth very python
16:53:36 <andythenorth> TrueBrain: have you written the 'close this PR' bot yet?
16:53:43 <TrueBrain> no
16:53:58 <TrueBrain> I have been looking how other projects go about 'rot'
16:53:59 <andythenorth> I can do it mechanical turk style? o_O
16:54:04 <TrueBrain> yes
16:54:14 <andythenorth> close after 6 months
16:54:26 <TrueBrain> most projects do rot like: a bot says something after N days, like: if you dont say this in M days, I will close this PR
16:54:30 <TrueBrain> that seems pretty efficient
16:54:42 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on pull request #6988: Change: AI/GS ScriptBridge::GetName takes one extra parameter to refer the vehicle type https://git.io/fh3KM
16:54:43 <andythenorth> yes
16:54:45 <andythenorth> just what is N?
16:54:48 <TrueBrain> so we might just copy/paste one of those bots out there
16:54:54 <TrueBrain> most have N of 90, and M of 30
16:54:58 <andythenorth> probably N days with nothing useful happening
16:55:03 <andythenorth> not N days since created :P
16:55:10 <TrueBrain> no, since last comment
16:55:13 <TrueBrain> activity
16:55:24 <andythenorth> +1
16:55:36 <andythenorth> let's see
16:55:48 <andythenorth> hmm maybe not
16:55:49 <TrueBrain> I wrote DorpsGek_II with the idea we all had to do it ourself; now a lot of stuff we no longer have to do ourself, it might be easier to use existing bots :)
16:55:56 * andythenorth is feeling too silly to do this today
16:56:02 <andythenorth> tempted to close all my PRs :P
16:56:28 <andythenorth> TrueBrain: do comments like this reset N? https://github.com/OpenTTD/OpenTTD/pull/6780#issuecomment-438065356
16:57:08 <TrueBrain> a bot would think so, I would not :)
16:58:01 <andythenorth> AI runs amok
16:58:04 <TrueBrain> https://github.com/probot/stale
16:58:22 <andythenorth> this is blatantly diverting andythenorth from reading 800 lines of sprite generator
16:58:41 <andythenorth> probot is winning
16:59:01 <TrueBrain> okay, staging now validates on all URLs I know of
16:59:07 <TrueBrain> so .. only serverlisting to go
16:59:27 <andythenorth> \o/
16:59:30 <TrueBrain> `The app uses GitHub's updated search qualifier to determine staleness. Any change to an issues and pull request is considered an update, including comments, changing labels, applying or removing milestones, or pushing commits.`
17:00:34 <TrueBrain> For Samu, from the URL I just linked:
17:00:36 <TrueBrain> `But in any successful software project, there's always more work to do than people to do it. As more and more work piles up, it becomes paralyzing. Just making decisions about what work should and shouldn't get done can exhaust all available resources. In the experience of the maintainers of this app—and the hundreds of other projects and organiza
17:00:36 <TrueBrain> tions that use it—focusing on issues that are actively affecting humans is an effective method for prioritizing work.`
17:01:14 <TrueBrain> lets ask frosch when he arrives if he agrees with deploying that bot; but that is otherwise an easy fix
17:01:22 <TrueBrain> lets do it for Pull Request only for now
17:01:25 <andythenorth> work paralysis
17:01:33 <TrueBrain> a lot of projects also deploy this for issues
17:01:36 <andythenorth> how many times I've had to explain why I keep backlogs to < 100 issues
17:01:40 <andythenorth> at work
17:01:46 <TrueBrain> dont get me started on that :P
17:01:51 <LordAro> i don't think it'd be very helpful on issues
17:01:52 <TrueBrain> I have seen the weirdest backlogs
17:01:53 <andythenorth> 'we have two weeks'
17:02:04 <LordAro> just generate noise
17:02:06 <TrueBrain> LordAro: it really is; we now have 20+ triage tickets
17:02:08 <andythenorth> 'so we can spend 4 days on a "proper" setup'
17:02:08 <TrueBrain> nobody is picking up any
17:02:12 <TrueBrain> how important are they still?
17:02:13 <andythenorth> or we can do the top 20
17:02:27 <LordAro> TrueBrain: oh, applied to some subset, yes
17:02:32 <TrueBrain> if you remove all triage, and a new one arrives, you are MUCH more likely to act on it
17:02:34 <andythenorth> TrueBrain: can we be ruthless about the reported weird defects?
17:02:49 <andythenorth> clearly if they were common, we'd hear about them more
17:03:09 <andythenorth> we track failure demand at work and only act on commonly recurring issues, unless it's an infosec issue
17:03:21 <TrueBrain> personally, I really dont care; closing them telling it was the first report, open if there are more, is fine by me
17:03:27 <TrueBrain> closing them with: wontfix, less fine :)
17:03:34 <andythenorth> I'lll look at them
17:03:48 <TrueBrain> in agile teams, I like to just have the stakeholders make their top N list
17:03:52 <TrueBrain> let them explain it
17:03:54 <TrueBrain> and vote on what to pick up
17:03:58 <TrueBrain> the N has to be small, as they only have an hour
17:04:04 <TrueBrain> (and you round-robin their list)
17:04:12 <Eddi|zuHause> is there something inbetween "open" and "closed"? "stale"?
17:04:26 <TrueBrain> so it is in their best interest to have the tickets clear, actionable, and their job to have others vote for theirs
17:04:32 <TrueBrain> important things always bubble up
17:04:58 <TrueBrain> but stakeholders in Open Source is DIFFICULT
17:05:09 <TrueBrain> Eddi|zuHause: with labels, yes
17:05:13 <peter1138> Yeah, sorry I'm just a shit dev.
17:05:22 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6688: Random game crash https://git.io/fh36I
17:05:23 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6688: Random game crash https://git.io/fh36L
17:05:36 <andythenorth> 'stakeholders'
17:05:45 <peter1138> I just code stuff. The rest of it is draining and too much like work so, yeah, I don't bother. I do this for fun.
17:05:50 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro requested changes for pull request #6983: Feature: Town name filtering https://git.io/fh36t
17:08:04 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6691: crash when first boat reaches destination for subsidised transport https://git.io/fh36W
17:08:06 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6691: crash when first boat reaches destination for subsidised transport https://git.io/fh36l
17:08:07 <andythenorth> peter1138: fair :P
17:08:24 <peter1138> I guess my PRs will die and that's a shame.
17:08:27 <LordAro> :(
17:09:14 <LordAro> peter1138: i'd really like to see #6780 done, if you want something to focus on :>. Just needs a rebase, afaict
17:09:41 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6677: Fast Forward Button https://git.io/fh36B
17:09:42 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6677: Fast Forward Button https://git.io/fh36R
17:09:53 <Eddi|zuHause> what's the magic git invocation to take a commit in master and apply it on top of a branch?
17:10:08 <andythenorth> cherrypick is my preferred
17:10:10 <LordAro> a specific commit? cherry-pick
17:10:12 <andythenorth> some would rebase
17:10:15 <andythenorth> to show off :P
17:10:44 <TrueBrain> I love 'rebase -i'
17:10:45 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6668: OpenTTD crash in ICU routine https://git.io/fh360
17:10:46 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6668: OpenTTD crash in ICU routine https://git.io/fh36E
17:10:49 <LordAro> andythenorth: surprised #6677 survived the previous issue cull
17:10:58 <Eddi|zuHause> how do i spell that out?
17:11:14 <andythenorth> well it is an issue, and was waiting for reporter to return LordAro
17:11:19 <andythenorth> but yeah, it's 2019 now
17:11:33 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6675: Crash when switching language in game https://git.io/fh36u
17:11:34 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6675: Crash when switching language in game https://git.io/fh36z
17:11:46 <TrueBrain> andythenorth: https://probot.github.io/apps/no-response/ ? :D
17:11:50 <andythenorth> Eddi|zuHause: https://git-scm.com/docs/git-cherry-pick
17:12:00 <peter1138> LordAro, I don't even know what needs doing to 6780 now
17:12:09 <LordAro> probably nothing :)
17:12:19 <peter1138> Then I'll do that then.
17:12:31 <LordAro> (except VS project file conflicts)
17:12:44 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6655: Crash: [ICU] The game never opens and the Arabic language in the form of numbers and symbols https://git.io/fh36a
17:12:45 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6655: Crash: [ICU] The game never opens and the Arabic language in the form of numbers and symbols https://git.io/fh36V
17:12:59 <andythenorth> I wish I didn't have an irc highlight on andythenorth right now :P
17:13:29 <Eddi|zuHause> make highlights silent
17:13:32 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6882: fatal application failure https://git.io/fh36o
17:13:32 <TrueBrain> so LordAro, what are the changes you rebase https://github.com/OpenTTD/OpenTTD/pull/6917 (while talking about rebases) :D
17:13:33 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6882: fatal application failure https://git.io/fh36K
17:13:43 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6563: Crash: [ICU] when using "Times New Roman" as large font https://git.io/fh366
17:13:44 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6563: Crash: [ICU] when using "Times New Roman" as large font https://git.io/fh36P
17:13:54 <Eddi|zuHause> or in advanced clientes, make it ignore the highlight if a bot says it
17:14:10 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6400: Crash: ctrl-clicking a factory type in map https://git.io/fh36X
17:14:11 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6400: Crash: ctrl-clicking a factory type in map https://git.io/fh361
17:14:55 <andythenorth> this is much better than fixing my sprite generator :)
17:14:59 <andythenorth> admin ftw
17:16:54 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro dismissed a review for pull request #6917: Fix iconv and clang version detection on OSX https://git.io/fpitd
17:16:55 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro updated pull request #6917: Fix iconv and clang version detection on OSX https://git.io/fpEvc
17:16:56 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh merged pull request #7013: Fix 6accbf9: Silence warnings about unused fread() result https://git.io/fh3ua
17:17:12 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh merged pull request #7012: Play Fluidsynth music through the mixer https://git.io/fh30T
17:17:40 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #994: Spectator cannot see list of available vehicles https://git.io/fh36F
17:17:41 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #994: Spectator cannot see list of available vehicles https://git.io/fh36b
17:17:45 <andythenorth> word soup
17:17:52 <LordAro> LOUD NOISES
17:18:17 <andythenorth> this is SO EASY TO FIX https://github.com/OpenTTD/OpenTTD/issues/3958
17:18:18 <TrueBrain> lets see if CI likes your work LordAro :)
17:18:20 <andythenorth> I shoudl do it :P
17:18:48 <TrueBrain> I like that the ticket reads: "Patching for this was harder than I thought - more lines to touch."
17:18:56 <TrueBrain> written by the same person who just yelled it is so easy to fix :D
17:19:00 <LordAro> ^
17:19:07 <LordAro> but yes, you should do it
17:19:41 <andythenorth> I was expecting a one line fix, not a five line fix
17:19:47 <andythenorth> 5x as much work :P
17:20:00 <andythenorth> also I'd have to learn some C++
17:20:07 <LordAro> well, get a move on then
17:20:16 <LordAro> and you can have the honour of fixing a 9 year old bug
17:20:25 <LordAro> i've been annoyed by this in the past as well
17:20:45 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5656: Orders: current order should be discard if orders are changed https://git.io/fh3if
17:20:46 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #5656: Orders: current order should be discard if orders are changed https://git.io/fh3iJ
17:20:56 <andythenorth> LordAro: I'm doing what I'm best at :P
17:21:01 <andythenorth> creating spam in the channel
17:21:06 <LordAro> haha
17:21:32 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh merged pull request #7014: Fix 6a3d411: Silence truncation warning https://git.io/fh3uh
17:21:32 <LordAro> how long until TB gives in and merges the "close with comment" messages? :p
17:21:36 <TrueBrain> LordAro: you cannot press merge on OpenTTD PRs?
17:21:41 <LordAro> TrueBrain: i cannot
17:21:41 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6250: Crash: (hang) dedicated server hang with 100% CPU utilization, possibly pathfinder? https://git.io/fh3iT
17:21:42 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6250: Crash: (hang) dedicated server hang with 100% CPU utilization, possibly pathfinder? https://git.io/fh3ik
17:21:56 <TrueBrain> odd
17:22:08 <TrueBrain> ah .. I get why
17:22:16 <TrueBrain> ugh, let me poke frosch when he joins :P
17:22:28 <Borg> hmm :(
17:22:29 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6298: Crash: R27221 assertion failed crash https://git.io/fh3iO
17:22:30 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6298: Crash: R27221 assertion failed crash https://git.io/fh3i3
17:22:36 <Borg> I cant find my ticket of industry text redraw issue
17:22:45 <Borg> will it ever be handled?
17:22:51 <TrueBrain> LordAro: merges? there is a PR for that?
17:22:51 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6382: Timetable: when loading a 1.4.4 saved game in 1.5.0 or 1.5.2, trains leave too early https://git.io/fh3iG
17:22:52 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6382: Timetable: when loading a 1.4.4 saved game in 1.5.0 or 1.5.2, trains leave too early https://git.io/fh3iZ
17:23:02 <LordAro> andythenorth: is it a good idea to close crash bugs?
17:23:15 <andythenorth> I wondered
17:23:18 <andythenorth> but on balanace yes
17:23:31 <andythenorth> unless there is a pattern of them, like ICU
17:23:33 *** Wormnest has joined #openttd
17:23:35 <andythenorth> or the AI overflow
17:23:36 <TrueBrain> I think with that message, it is fine
17:23:40 <LordAro> hmm
17:23:45 <andythenorth> ICU was really clear pattern
17:23:51 *** glx has joined #openttd
17:23:51 <andythenorth> and the AI crashes are too
17:23:51 *** ChanServ sets mode: +v glx
17:24:00 <TrueBrain> LordAro: I cannot make a "commented and closed", as the order of these events are unpredictable :(
17:24:05 <TrueBrain> so I cannot keep one or the other back
17:24:22 <LordAro> with ICU, sure (especially when they're mostly windows, which will be fixed in 1.9 anyway)
17:24:24 <TrueBrain> (at least, I wouldnt know how)
17:24:27 <andythenorth> well I can stop for a bit, to prevent the spam
17:24:32 <LordAro> but other crash bugs still exist, however unlikely they may be to hit
17:24:34 <nielsm> TrueBrain, what about delaying them by 5 seconds and coalescing if you see either order?
17:24:39 <Borg> https://github.com/OpenTTD/OpenTTD/issues/3701 <- pffft.. fixed my ass ;)
17:24:47 <andythenorth> LordAro: I'm not closing all of them
17:24:50 <TrueBrain> nielsm: that is possible; delaying is only annoying, but .. I guess that would work
17:24:58 <TrueBrain> its asyncio, so I can just start a timer in a coroutine
17:25:16 <andythenorth> but a report of a bug in an old savegame in a newer version, where a change was already made to fix a bug, meh
17:25:30 <andythenorth> we don't migrate all old broken savegame content, right?
17:25:55 <LordAro> andythenorth: that one made sense, sure
17:25:59 <glx> oh somehow is closing all ICU issues :)
17:26:15 <LordAro> but #6750 & #6298 seems less clear to me, especially when they have tracebacks
17:26:18 <andythenorth> it's not fixed yet, but we have an issue for fixing it
17:26:20 <LordAro> /assertions
17:26:43 <LordAro> issue lists aren't priority lists
17:26:56 <LordAro> if they get closed, the issue definitely will get lost, even if it's still there
17:27:55 <andythenorth> I am happy to reopen them
17:28:04 <TrueBrain> the problem is, we have 200+ tickets. The chance of these things to be picked up is ... currently VERY low
17:28:05 <andythenorth> I'm going by the date
17:28:09 <TrueBrain> we have nobody who is doing triage
17:28:18 <andythenorth> reported 2015...triage requested April 2018
17:28:21 <andythenorth> now it's 2019
17:28:26 <TrueBrain> and as these tickets are once-in-a-milion, the chance of it happning again is VERY low
17:28:36 <TrueBrain> so how ever bad it might seem, you are closing a real bug that "should be fixed"
17:28:39 <TrueBrain> we have finite time ..
17:28:44 <TrueBrain> so is keeping them around really contributing?
17:28:51 <TrueBrain> I rather have that new triages are picked up ASAP
17:29:15 <TrueBrain> (it is a bit of psychology)
17:29:23 <TrueBrain> would be nice to label them as "never resolved", in what-ever way
17:29:27 <TrueBrain> "stale" or what-ever
17:29:45 <TrueBrain> but keeping them around for the shake of keeping them around is, how ever weird it might sound, counterproductive
17:29:54 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on issue #6873: Jukebox not working in the flatpak version https://git.io/fh3i2
17:29:55 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh closed issue #6873: Jukebox not working in the flatpak version https://git.io/fh3ia
17:29:57 <andythenorth> unwinnable game
17:30:00 <andythenorth> make winnable games
17:30:07 <TrueBrain> prioritze :)
17:30:16 <andythenorth> want me to add 'unresolved bug report' or something?
17:30:26 <andythenorth> I can do that first as a label
17:30:26 <TrueBrain> I think "stale" is the word for this
17:30:28 <andythenorth> ok
17:30:31 <LordAro> that'd make me happier
17:30:36 <TrueBrain> but others might have other opinions :)
17:30:36 <LordAro> though not happy :p
17:30:36 <andythenorth> I can do the label first
17:30:40 <andythenorth> then close later
17:30:50 <TrueBrain> label + close now?
17:30:57 <TrueBrain> that label really is not going to change anything
17:31:02 <TrueBrain> just that label allows us to find them back, if needed
17:31:15 <TrueBrain> LordAro: I think everyone fully agrees with you; you just notice that andythenorth and me have management functions :D
17:31:29 <andythenorth> oof :(
17:31:30 <TrueBrain> we know from experience that it is a harsh world :)
17:31:41 <LordAro> :)
17:31:51 <Eddi|zuHause> my concern is, if you close them, nobody will ever look at them again
17:31:51 <LordAro> ok, someone can merge #6917 now :p
17:32:00 <andythenorth> Eddi|zuHause: nobody is ever looking at them :)
17:32:05 <andythenorth> what changed, in information terms?
17:32:07 <LordAro> what eddi said
17:32:13 <TrueBrain> what andythenorth said :P
17:32:13 <nielsm> well this certainly looks wrong... https://0x0.st/sRYi.png (re. https://github.com/OpenTTD/OpenTTD/issues/6666)
17:32:14 * andythenorth asserts things that may not be true
17:32:31 <andythenorth> to avoid irc hot air, these need triage https://github.com/OpenTTD/OpenTTD/issues?q=is%3Aopen+is%3Aissue+label%3A%22needs+triage%22
17:32:38 <andythenorth> there are 29
17:32:43 <LordAro> andythenorth: there's a difference between "unlikely for someone to look at them" and "no one will look at them"
17:32:51 <andythenorth> they haven't been triaged since ~April 2019
17:32:57 <Eddi|zuHause> "find them back" is also bad, because people who looked at it and said "legitimately closed", won't remove the "stale" tag
17:33:14 <andythenorth> I am fine to go and make a pixel generator :)
17:33:21 <TrueBrain> andythenorth: I call bullshit :P
17:33:22 <LordAro> i'd prefer open + stale label, personally
17:33:25 <andythenorth> no shortage of unfinished jobs :P
17:33:28 <TrueBrain> what does the 'open' part add?
17:33:36 <TrueBrain> nobody is going to look at these triages anyway
17:33:38 <andythenorth> not having to argue here?
17:33:39 <TrueBrain> nobody has in over 5 years
17:33:41 <TrueBrain> so ..... :D
17:33:59 <TrueBrain> I would suggest we either start doing triage
17:34:06 <TrueBrain> or we stop caring for 2+ year old triages
17:34:14 <TrueBrain> you can't have it both :D
17:34:14 * andythenorth wonders what we lost when I closed 600 issues in flyspray :P
17:34:31 <Eddi|zuHause> unfathomable values
17:34:33 <andythenorth> @calc 600 / 29
17:34:33 <DorpsGek> andythenorth: 20.6896551724
17:34:36 <andythenorth> 20x worse :P
17:34:53 <LordAro> idk
17:34:59 <LordAro> closed implies fixed, in my head
17:35:08 <TrueBrain> no; that is not true for sure :)
17:35:19 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5823: Update baseset translations atomatically via WebTranslator daemon https://git.io/fh3id
17:35:20 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #5823: Update baseset translations atomatically via WebTranslator daemon https://git.io/fh3iF
17:35:21 <TrueBrain> if someone reports a bug, you ask for extra information, and they don't reply in 3 months
17:35:34 <TrueBrain> closing them doesnt mean: fixed :)
17:35:39 <TrueBrain> it just means: never going to happen I guess
17:35:52 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5886: [Allegro] Messed up colors when switching to zBase and back to OpenGFX https://git.io/fh3iA
17:35:53 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #5886: [Allegro] Messed up colors when switching to zBase and back to OpenGFX https://git.io/fh3ix
17:35:55 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #6780: Change: Refactor window ticks into game ticks and realtime events. https://git.io/vpDSL
17:36:07 <TrueBrain> (that is why most systems btw have close-reason)
17:36:11 <LordAro> andythenorth: #5823 looks like it's literally the thing you were asking for earlier
17:36:16 <Eddi|zuHause> i think we need clearer rules to discuss: like which scenarios of tickets this applies to, which timeframe, ...?
17:36:47 <andythenorth> LordAro: proof!
17:36:48 <andythenorth> :)
17:36:49 <TrueBrain> best approach most projects are finding out: all issues / pull request: 3 months stale, mark stale and ask if anyone cares. Month later, close
17:37:01 <andythenorth> LordAro: but we already decided that it's just an issue local to me :)
17:37:09 <andythenorth> so I have patched my ~/.gitignore
17:37:49 <TrueBrain> we can just enable https://github.com/probot/stale on all issues too :D
17:37:56 <Eddi|zuHause> <andythenorth> LordAro: but we already decided that it's just an issue local to me :) <-- for what value of "we", "decided", "local" and "me"?
17:38:04 <andythenorth> Truebrain told me it was
17:38:14 <TrueBrain> stop having grfcodec installed
17:38:17 <Eddi|zuHause> he's an idiot and knows nothing
17:38:22 <TrueBrain> we established that, yes
17:38:23 <andythenorth> is this one *not* ICU? o_O https://github.com/OpenTTD/OpenTTD/issues/6221
17:39:06 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain approved pull request #6917: Fix iconv and clang version detection on OSX https://git.io/fh3PY
17:39:13 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain merged pull request #6917: Fix iconv and clang version detection on OSX https://git.io/fpEvc
17:39:17 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain closed issue #6880: Compile fails on src/economy.cpp:702:20: error: expected expression https://git.io/fh3PO
17:39:19 <andythenorth> wat
17:39:19 <TrueBrain> now andythenorth doesn't need to hack :P
17:39:26 <andythenorth> now andythenorth doesn't need to hack
17:39:42 <TrueBrain> I closed a ticket I know NOTHING OF :P
17:39:49 <andythenorth> now andythenorth needs to rebase :P
17:40:01 <peter1138> LordAro, #6780 rebased, hope it's correct :p
17:40:07 <nielsm> yep adding some {LRE} fixes the towns list: https://0x0.st/sRYX.png
17:40:09 <LordAro> peter1138: :)
17:40:25 <peter1138> Needs someone else to review becuase... er... it's my PR.
17:41:00 <peter1138> nielsm, what happens when it's not fixed?
17:41:01 <nielsm> how much taboo is it to edit foreign translations to fix an entirely technical issue? :)
17:41:14 <nielsm> peter1138: https://0x0.st/sRYi.png
17:41:26 <nielsm> or https://bugs.openttd.org/task/6666/getfile/10959/Arabic.png
17:41:29 <peter1138> Ooo
17:41:31 <Eddi|zuHause> <nielsm> how much taboo is it to edit foreign translations to fix an entirely technical issue? :) <-- i'm fairly sure that has been done
17:41:40 <LordAro> i wouldn't have an issue with it
17:41:46 <peter1138> Yeah, fine by me.
17:42:16 <nielsm> the text in that bug reporter's screenshot also looks very broken regardless
17:42:29 *** Oroburos has joined #openttd
17:42:33 <nielsm> I don't think there's supposed to be + and % signs everywhere
17:42:59 <nielsm> (date and window title, for example)
17:43:42 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth updated pull request #6811: Feature: Add NotRoadTypes (NRT) https://git.io/vhlfg
17:43:48 <andythenorth> that's gonna fail
17:43:59 <andythenorth> probably need a branch just for the PR
17:44:06 <andythenorth> and do fixes in a different branch until ready
17:44:09 <andythenorth> very admin
17:44:24 <TrueBrain> that is called a fork :)
17:45:07 <Eddi|zuHause> isn't that how github tells you to do things anyway?
17:45:49 <TrueBrain> funny enough, the first GitHub guide tells you to use a branch in the upstream repository
17:45:59 <TrueBrain> it is only later they talk about forks
17:46:26 <glx> step by step :)
17:46:35 <andythenorth> hang on I fork my fork?
17:46:38 <andythenorth> wat?
17:46:55 <LordAro> branch your branch, technically
17:47:01 <TrueBrain> or use your branch in your fork
17:47:06 <TrueBrain> that is a branch too :P
17:47:17 <Eddi|zuHause> i'm not sure what "first" is, but what i do is pull from the upstream github repo, make my branch, and push that to my forked github repo
17:47:17 <andythenorth> fork my branch
17:47:25 <LordAro> "fork" is usually used for more permanent divergences
17:47:57 <Eddi|zuHause> then make a PR from the forked repo into the upstream repo
17:48:21 <TrueBrain> hmm .. Azure Pipelines is still weird in when it picks up work .. experiments are slow-going :D
17:48:33 <Eddi|zuHause> only the last step needs access to github web interface (and the original forking, but that was ages ago)
17:48:45 <Eddi|zuHause> (needs to be done only once)
17:50:03 <TrueBrain> `The job running on agent Hosted Agent has exceeded the maximum execution time of 60. `
17:50:04 <TrueBrain> :D
17:50:06 <TrueBrain> gratz andythenorth :D
17:50:15 <andythenorth> oof
17:50:17 <andythenorth> FFS
17:50:22 * andythenorth hates everything now
17:50:32 <andythenorth> bug or intended? https://github.com/OpenTTD/OpenTTD/issues/6061
17:50:44 <Eddi|zuHause> 60 what? sausages?
17:51:31 <andythenorth> plenty of issues to triage here, if anyone wants a go
17:51:53 <TrueBrain> so mmmaaannnyyyyy :D
17:51:54 <LordAro> andythenorth: depends what the town is trying to do, i imagine
17:51:56 <nielsm> "git pull" and then it hangs... wtf
17:52:05 <LordAro> #blamegithub
17:52:13 <TrueBrain> #blameeddit
17:52:15 <TrueBrain> hmm
17:52:17 <TrueBrain> #blameeddi
17:52:33 <TrueBrain> no clue why typing 'eddi' followed a t instinctively
17:52:37 <TrueBrain> I am on reddit too much
17:52:49 <Eddi|zuHause> andythenorth: i'm leaning towards intended, but could be an obiwan somewhere
17:53:10 <andythenorth> I discovered today, reddit isn't just racism :o
17:53:17 <andythenorth> there are actual communities on there
17:53:39 <nielsm> argh I accidentally made another branch on main repo
17:53:44 <Eddi|zuHause> i thought racism was facebook, never heard reddit in that context
17:53:46 <andythenorth> bad nielsm
17:54:07 <andythenorth> I have quit facebook, but it was definitely racism
17:54:13 <TrueBrain> for every branch, a puppy dies, right? :P
17:54:46 <peter1138> modified: bin/baseset/no_sound.obs
17:54:49 <peter1138> what is this that happens
17:54:58 <LordAro> andythenorth: not just you
17:55:14 <LordAro> peter1138: baseset translations get updated when grfcodec on path
17:55:28 <andythenorth> LordAro: broke it https://github.com/OpenTTD/OpenTTD/issues/6507
17:55:44 <andythenorth> peter1138: remove grfcodec from your path
17:56:15 <DorpsGek_II> [OpenTTD/OpenTTD] ghisvail commented on issue #6873: Jukebox not working in the flatpak version https://git.io/fh3Pj
17:56:18 <LordAro> i think ./configure --without-grfcodec would be nicer
17:56:27 <andythenorth> LordAro: how did you break 2 depot tiles then? o_O
17:56:37 <LordAro> andythenorth: i have no idea
17:56:45 <LordAro> it is an extremely old save file
17:57:11 <TrueBrain> just close it: "incompetent user"
17:57:13 <TrueBrain> easy :D
17:57:14 <TrueBrain> <3
17:57:18 <LordAro> :(
17:57:23 <andythenorth> I have stopped closing issues
17:57:29 <andythenorth> to reduce localised anxiety levels
17:57:36 <TrueBrain> did .. someone just ask for a release date? OMG!
17:57:37 <Eddi|zuHause> <peter1138> modified: bin/baseset/no_sound.obs <-- it's updated translations that the translator commit for some reason doesn't do automatically
17:59:40 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on pull request #6780: Change: Refactor window ticks into game ticks and realtime events. https://git.io/fh3XI
17:59:52 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on issue #6873: Jukebox not working in the flatpak version https://git.io/fh3Xm
18:00:19 <nielsm> okay I can't make git delete that remote branch...
18:00:31 <TrueBrain> which one?
18:01:20 <nielsm> oh maybe I found the way
18:01:30 <nielsm> yes
18:01:30 <glx> click on delete in the PR
18:01:30 <Eddi|zuHause> nielsm: you mean the branch on the remote server, or your local knowledge of the branch on the remote server?
18:03:13 <TrueBrain> 343 commits since 1.8
18:03:25 <TrueBrain> that is almost twice as much as 1.7 -> 1.8 :P
18:03:30 <LordAro> :)
18:03:58 <andythenorth> loads more PRs too
18:04:03 <andythenorth> infinite amount more
18:04:43 <TrueBrain> okay, so I have to find a way to keep doing serverlisting via the old django thingy .. after that a release pipeline .. and setup the CDN so releases can be published there
18:04:49 <andythenorth> TB https://www.tt-forums.net/viewtopic.php?p=1213870#p1213870
18:05:01 <andythenorth> so 100 commits since October now
18:06:00 <TrueBrain> release pipeline is mostly done. Does Mac have any debug symbol-like file it leaves behind?
18:06:11 <TrueBrain> oeh!!! We can now make .dmg files for Mac! :o :D
18:06:17 <TrueBrain> I did not realise that yet
18:06:19 <TrueBrain> but that is awesome
18:06:20 <LordAro> !
18:07:04 <TrueBrain> owh, Windows installer .. that is one that might take a bit of time
18:07:24 <TrueBrain> NSIS is not installed on the agents
18:07:51 <TrueBrain> so we need to figure that out ..
18:07:55 <TrueBrain> linux releases are done
18:08:00 <TrueBrain> Mac is easy because of 'bundle_dmg'
18:08:03 <TrueBrain> given that it still works
18:08:17 <TrueBrain> andythenorth: if you have some spare time, can you check if 'make bundle_dmg' results in a file that still works on Mac?
18:08:40 <TrueBrain> it should be that if you double click that file it starts OpenTTD, I believe?
18:09:29 <andythenorth> dmg should give a disk image
18:09:30 <andythenorth> let's see
18:10:05 <nielsm> I think I tried make bundle_zip in my azure pipeline tests, and andy could run those builds produced
18:10:17 <DorpsGek_II> [OpenTTD/OpenTTD] glx22 merged pull request #7002: Add: [Win32] regression testing with MSVC https://git.io/fhLHR
18:10:36 <TrueBrain> nielsm: yeah, we used to do zips for Mac .. but dmgs are more powerful :D
18:10:42 <TrueBrain> so that would be a very nice cherry-on-top :D
18:10:49 <nielsm> dmg numbers
18:11:02 <nielsm> massive dmg
18:11:21 * andythenorth wonders why compiling is sooooooooooo slow
18:12:04 <andythenorth> yeah dmg arrived
18:12:05 <andythenorth> opens
18:12:12 <andythenorth> binary works on double click
18:12:14 <andythenorth> job done
18:12:18 <TrueBrain> cool :D
18:12:21 <glx> it can't be slower than a MSVC release build
18:12:25 <andythenorth> hmm
18:12:26 <TrueBrain> that improves the quality a bit :)
18:12:30 <andythenorth> didn't trigger gatekeeper
18:12:33 <andythenorth> that's interesting
18:12:39 <TrueBrain> so who wants to figure out how to run NSIS on Azure Pipelines? :D
18:13:01 <glx> there's a .bat somewhere
18:13:04 <TrueBrain> andythenorth: is producing the dmg alone enough? Or is it common to also publish the .zip ?
18:13:13 <TrueBrain> glx: it also needs to be installed on the agent :P
18:13:19 <glx> ah
18:13:23 <andythenorth> TrueBrain: probably just dmg, I'll check some sites
18:13:27 * andythenorth never downloads software
18:13:29 <TrueBrain> tnx andythenorth
18:14:03 <TrueBrain> hmm, I need a container that produces source binaries and docs
18:14:12 <nielsm> ugh, I think last I had problems with git not connecting to github via ssh I had to reboot
18:14:14 <glx> https://github.com/Microsoft/azure-pipelines-image-generation/blob/master/images/win/scripts/Installers/Install-NSIS.ps1
18:14:15 <nielsm> that's so annoying
18:14:39 <andythenorth> TrueBrain: major mac software vendors seem to use dmg and zip interchangeably
18:14:49 <andythenorth> dunno why, but eh, probably reasons
18:14:56 <TrueBrain> glx: cool . that suggest it is installed in the image :)
18:15:02 <TrueBrain> it is just not in the markdown telling about it :P
18:15:20 <Samu> what if you could refit vehicle types?
18:15:23 <TrueBrain> right; food!
18:17:24 <andythenorth> Samu: ??
18:18:03 <glx> I think it's something you must put in the image creation
18:19:33 <andythenorth> le cheval de fer? http://www.railpictures.net/photo/683010/
18:19:55 <Samu> refit a road vehicle into a ship or so
18:20:04 <Samu> or an aircraft into a train
18:20:07 <andythenorth> then the world would explode
18:20:57 <Eddi|zuHause> it has the pantograph up on the wrong end?
18:21:25 <glx> hmm no it should be already in vs2017-server2016
18:21:31 <andythenorth> maybe it's going backwards Eddi|zuHause? o_O
18:21:37 <andythenorth> which side do they run in France?
18:21:46 <Eddi|zuHause> the wrong side, iirc
18:21:50 <glx> left
18:21:51 <andythenorth> probably
18:21:55 <andythenorth> definitely wrong
18:21:58 <Samu> TestRefitVehicleUnitNumber().TryRefit(new_vehicle, AIVehicle.VT_ROAD, Utils.getCargoId(m_cargoClass))
18:22:16 <glx> comes from the steam era
18:22:40 <Samu> I have a requirement for the vehicle type when working with my functions, and it happened to be the refit function
18:22:43 <Eddi|zuHause> it's all the english's fault
18:22:53 <glx> the man putting coal in it was usually right handed
18:22:54 <Samu> so that's where the idea came from
18:23:28 <andythenorth> I think I broke it
18:23:31 <glx> but the metro runs on the right side
18:23:53 <glx> it was so the train won't go on the metro :)
18:23:56 <andythenorth> ha ha
18:25:49 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #4313: Mapgen: limit amount of desert in sub-Tropic https://git.io/fh31c
18:25:50 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #4313: Mapgen: limit amount of desert in sub-Tropic https://git.io/fh31W
18:26:09 <Eddi|zuHause> a propos dessert...
18:26:25 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #4076: Vehicle List: poor contrast of light red on grey for negative earnings https://git.io/fh31R
18:26:26 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #4076: Vehicle List: poor contrast of light red on grey for negative earnings https://git.io/fh310
18:26:44 <andythenorth> tropic mapgen is fixed by just using the temperate generator :P
18:26:46 <andythenorth> but eh
18:26:53 <andythenorth> we have to do it the hard way
18:27:17 <andythenorth> there's no rainforest because there's no high ground
18:27:26 <andythenorth> because somebody misguidedly applied a transform to TGP
18:27:31 <andythenorth> which makes the map flat
18:27:32 *** Oroburos has quit IRC
18:28:55 <andythenorth> https://www.tt-forums.net/viewtopic.php?f=33&t=74647&p=1165875&hilit=tropic#p1165875
18:31:06 <peter1138> Sorry about that.
18:31:43 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #2738: Vehicles: road vehicle overtaking https://git.io/fh31y
18:31:44 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #2738: Vehicles: road vehicle overtaking https://git.io/fh31S
18:32:02 <andythenorth> peter1138: it was you who told me it was misguided :P
18:32:05 <andythenorth> are you sure you did it?
18:32:12 <andythenorth> you were quite...cross about TGP at the time :P
18:32:40 <andythenorth> something like "how was this ever supposed to work"
18:32:57 <Eddi|zuHause> i'm pretty sure that part is older, and peter1138 was thinking of that time when he added the height distribution curves
18:33:02 <andythenorth> yeah
18:34:10 <peter1138> Both really.
18:36:06 *** Thedarkb-T60 has joined #openttd
18:37:23 <peter1138> I had (standalone) code to generate more interesting terrain but I think it got lost in my SSD crash.
18:37:51 <andythenorth> I played a map you made once
18:37:57 <andythenorth> some kind of big river
18:38:10 <andythenorth> hmm
18:38:22 <andythenorth> 'stale' doesn't make any sense for feature requests, right?
18:38:38 <andythenorth> TrueBrain: ^
18:39:03 <andythenorth> most feature requests *won't* have any activity
18:39:41 <Samu> I don't get callbacks, I never know where exactly they're triggered
18:40:42 <Eddi|zuHause> i think there need to be different timeframe based on whether anyone claimed it as "i'm working on this"
18:41:22 <Eddi|zuHause> and if there's code, the timeframe should not be less than 1 year
18:41:41 <andythenorth> I marked this stale, but I don't think it helps https://github.com/OpenTTD/OpenTTD/issues/4711
18:41:48 <andythenorth> as an example
18:43:12 <Eddi|zuHause> i think that can safely be closed as "won't implement"
18:44:08 <andythenorth> so are issues a roadmap?
18:44:11 * andythenorth is confused
18:44:36 *** Thedarkb1-T60 has joined #openttd
18:44:42 <Eddi|zuHause> np
18:44:44 <Eddi|zuHause> no
18:46:52 *** Thedarkb-T60 has quit IRC
18:53:21 <Thedarkb1-T60> In case you're wondering why I lagged out, I accidentally uninstalled my network manager.
18:53:25 <Thedarkb1-T60> Fun.
18:54:49 <andythenorth> this again https://github.com/OpenTTD/OpenTTD/issues/5881
18:54:55 <andythenorth> :P
19:00:42 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6230: Broken savegame - Referencing invalid Vehicle https://git.io/fh3Dv
19:01:44 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6210: More hotkeys for OpenTTD to improve gameplay https://git.io/fh3DU
19:01:46 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6210: More hotkeys for OpenTTD to improve gameplay https://git.io/fh3DT
19:03:04 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6207: Autorenew fails for articulated vehicles with mixed cargo https://git.io/fh3DL
19:03:05 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6207: Autorenew fails for articulated vehicles with mixed cargo https://git.io/fh3Dt
19:04:42 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6167: Does not display a summary of Finance https://git.io/fh3DO
19:04:43 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6167: Does not display a summary of Finance https://git.io/fh3D3
19:05:54 *** Thedarkb1-T60 has quit IRC
19:06:27 *** Gja has joined #openttd
19:06:48 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6544: Put into the AI company when loading savegame https://git.io/fh3DZ
19:06:49 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6544: Put into the AI company when loading savegame https://git.io/fh3Dn
19:08:42 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6525: Rating bonus for default economy also https://git.io/fh3D8
19:08:44 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6525: Rating bonus for default economy also https://git.io/fh3D4
19:10:30 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6490: appdata.xml metadata file for inclusion in Software Center https://git.io/fh3Du
19:11:15 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6476: Suggested changes for pathfinding for automatic servicing https://git.io/fh3D2
19:13:33 *** Thedarkb1-T60 has joined #openttd
19:15:46 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6546: Fast forward on macOS is restricted by frame refresh rate https://git.io/fh3DX
19:15:47 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6546: Fast forward on macOS is restricted by frame refresh rate https://git.io/fh3D1
19:18:37 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6661: Airport tiles overlap fence https://git.io/fh3D9
19:18:38 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6661: Airport tiles overlap fence https://git.io/fh3DH
19:19:53 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6647: Implicit order added after autorenew causing cargodist issues https://git.io/fh3D5
19:19:54 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6647: Implicit order added after autorenew causing cargodist issues https://git.io/fh3Dd
19:20:09 *** gelignite has joined #openttd
19:21:39 *** Thedarkb1-T60 has quit IRC
19:25:24 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6556: Windows installers creates shortcut for all users; not per user https://git.io/fh3yf
19:25:25 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6556: Windows installers creates shortcut for all users; not per user https://git.io/fh3yJ
19:26:19 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #6780: Change: Refactor window ticks into game ticks and realtime events. https://git.io/fh3yI
19:28:03 <Samu> spam
19:28:10 <nielsm> andythenorth, you were complaining about this exact issue earlier :) https://github.com/OpenTTD/OpenTTD/issues/5823
19:28:22 <Samu> https://github.com/notepad-plus-plus/notepad-plus-plus/issues/289 is a good question
19:28:23 <andythenorth> yes
19:28:41 <Samu> is there squirrel for notepad++ anywhere on the internet?
19:29:08 <andythenorth> nielsm: it's also referenced in passing here https://github.com/OpenTTD/OpenTTD/issues/5881
19:29:10 <LordAro> arguably it's an eints issue rather than OTTD, but...
19:29:11 <andythenorth> (comments)
19:29:28 <LordAro> Samu: C is usually close enough
19:30:11 <andythenorth> oh frosch fixed my issue here already https://github.com/OpenTTD/OpenTTD/issues/5823#issuecomment-379451860
19:30:17 <andythenorth> that's the answer then
19:30:35 *** HerzogDeXtEr has joined #openttd
19:30:57 <andythenorth> configure --without-grfcodec"
19:31:59 <LordAro> i also said that earlier :p
19:32:31 <nielsm> TrueBrain: could we maybe add a scheduled CI job that weekly (or whatever) regenerates the baseset files, makefiles, project files, etc. etc., and commits any changes?
19:32:55 <LordAro> just hook it into the existing translator stuff
19:32:57 <LordAro> imo
19:33:09 <nielsm> it's also for things not translations
19:33:15 <Samu> I notice that the paste webside has some kind of support
19:33:19 <Samu> website
19:33:50 <nielsm> e.g. source.list and the squirrel ui widgets headers
19:34:05 <Samu> Squirrel Script with OpenTTD AI/GS in the dropdown menu
19:34:21 <LordAro> nielsm: that should be done as part of commit checkers, imo
19:34:37 <LordAro> Samu: planetmaker might know
19:34:37 <Samu> https://paste.openttdcoop.org/
19:35:31 <planetmaker> hm?
19:36:04 <LordAro> planetmaker: squirrel syntax highlighting
19:36:12 <planetmaker> I never used squirrel.
19:36:37 <LordAro> how about anything to do with paste.ottdc.org?
19:37:50 <planetmaker> I'm still missing some context...
19:37:55 <glx> nielsm: I think I'll convert the awk to vbs for windows, should not be too hard
19:38:10 <LordAro> planetmaker: apparently paste.ottdc.org has a squirrel highlighting mode, and Samu was asking about it
19:38:16 <LordAro> Samu: https://www.tt-forums.net/viewtopic.php?t=69671 is this particularly helpful?
19:38:41 <glx> at least for generate_widget
19:38:55 <planetmaker> oh. It's mostly off-the shelf paste programme. We certainly didn't add our own highlighters :D
19:39:39 <Samu> hmm maybe, let me try
19:39:43 <LordAro> planetmaker: i feel like it's unlikely it would come with highlighting for "Squirrel Script with OpenTTD AI/GS"
19:40:35 <glx> doxygen_filter should be doable too, but squirrel_export is more complex, and I'm not even sure it still works
19:43:27 <andythenorth> 53 issues with patches from flyspray
19:43:31 <andythenorth> but patches are done in PRs
19:43:33 <planetmaker> :D I have to agree
19:43:42 <andythenorth> so
19:43:43 <andythenorth> https://github.com/OpenTTD/OpenTTD/issues?q=is%3Aopen+is%3Aissue+label%3A%22patch+from+FlySpray%22
19:44:00 <planetmaker> It's work of Ammler. That's how old it is
19:44:03 <planetmaker> @seen Ammler
19:44:03 <DorpsGek> planetmaker: Ammler was last seen in #openttd 3 years, 37 weeks, 0 days, 3 hours, 6 minutes, and 37 seconds ago: <Ammler> wow, nice openttd works now without any baseset
19:44:18 <andythenorth> bring back Ammler
19:44:19 <andythenorth> :P
19:45:26 <planetmaker> he seems very rarely online nowadays ...
19:45:52 <planetmaker> tbh, I tried, some time back.
19:46:01 <andythenorth> bring back DaleStan :P
19:46:15 <andythenorth> even...omg, bring back TrueBrain
19:46:43 <LordAro> Truelight, surely
19:47:05 <planetmaker> and... y3xo, robidium, th3rken
19:47:07 <Samu> nice, it works
19:47:14 <Samu> ugly colours, but it's something
19:47:16 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro closed issue #6649: Modernizing for C++11: replacing instances of SmallVector https://git.io/fh3Sv
19:47:17 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #6649: Modernizing for C++11: replacing instances of SmallVector https://git.io/fh3Sf
19:47:54 <LordAro> Samu: did you ever make #6657 into a PR?
19:48:22 <Samu> let me look
19:49:22 <Samu> looks like I didn't, because someone disagreed
19:50:47 <Samu> patch incomplete
19:50:51 <LordAro> fair
19:51:26 <Samu> my view on it is that the station is neutral
19:51:49 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6378: Erroneous behavior of Get/SetGrowthRate GS methods https://git.io/fh3SZ
19:52:08 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6657: Buying exclusive transport rights prevents oil rigs from using their own dock/helipad https://git.io/fh3Sn
19:52:24 <andythenorth> sorry spam incoming :(
19:52:31 <andythenorth> 53 issues to comment on, FFS
19:52:42 <LordAro> i feel it's unfair to threaten to close FS issues
19:52:56 <LordAro> given it's quite likely the actual owner hasn't noticed
19:53:20 <andythenorth> I wondered about that
19:53:29 <Samu> neutral would mean, anyone can use it, but that's just my point of view
19:53:33 <andythenorth> but nobody is picking them up?
19:53:37 <Samu> nielsm disagrees
19:53:43 <andythenorth> I mean, I tried to test a bunch of FS patches
19:53:55 <andythenorth> but they go nowhere
19:54:07 <andythenorth> even the ones that appear to work, diddly squat of them got merged
19:54:54 <andythenorth> e.g. https://github.com/OpenTTD/OpenTTD/issues/6078
19:55:01 <TrueBrain> nielsm: are those things that should have been part of a commit? As we might also tune the CI to fail of such files are not updated correctly?
19:55:09 <TrueBrain> nielsm: or are these things that just change once in a while, and need an update?
19:55:31 <LordAro> andythenorth: well, because no one made it a PR
19:55:34 * andythenorth tries to envision who is going to rebase 53 rotting patches and PR them
19:55:46 <andythenorth> what if they were done in small batches?
19:56:32 <LordAro> possibly
19:56:37 <LordAro> i could look at a few
19:56:53 <andythenorth> https://github.com/OpenTTD/OpenTTD/issues?q=is%3Aopen+is%3Aissue+label%3A%22patch+from+FlySpray%22
19:57:20 <andythenorth> I see no path to invite the original FS contributors to github
19:57:39 <LordAro> not without unarchiving FS
19:57:43 <LordAro> probably
19:57:54 <TrueBrain> even the emails on file are stale :P
19:58:20 <andythenorth> I don't know what basis the emails were collected under
19:58:21 <TrueBrain> I guess we can close any issue that takes more than 1 hour or so to put in a PR
19:58:33 * andythenorth food
19:58:51 <TrueBrain> we can think of all kind of ways to contact the authors .. but in all honesty, what are we expecting
19:59:00 <TrueBrain> they clearly haven't checked in for over a year
19:59:18 <TrueBrain> if you would have written a patch, and lost sight of this project .. would you make it into a PR?
19:59:29 <TrueBrain> so I think this is only the feeling of nostalgia to hold on
20:01:54 *** Wormnest has quit IRC
20:07:24 *** Borg has quit IRC
20:10:04 <TrueBrain> hmm .. was Make installed on Windows agents ..
20:12:20 <nielsm> I don't think they have a full mingw/msys environment
20:12:27 <nielsm> just msys-git
20:13:26 <TrueBrain> bah; that sucks :P
20:14:18 * andythenorth food complete
20:14:43 <TrueBrain> nielsm: from what I can tell, things like baseset and projects can be easily validated with the ci-commit-checker
20:14:46 <TrueBrain> just a few deps to install
20:14:53 <TrueBrain> does that help, preventing that PR, or is that more annoying?
20:15:19 <nielsm> I guess it's mostly that they're annoying to do
20:16:34 <TrueBrain> we can also automate the update; I dont really care tbh :)
20:17:24 <nielsm> the baseset things should probably be handled by eints, since it's closely tied to translations
20:17:50 <nielsm> and the rest could just be commit checker yelling at you
20:18:43 *** sla_ro|master2 has joined #openttd
20:18:43 *** sla_ro|master has quit IRC
20:18:55 <Samu> bad behaviour
20:19:11 <Samu> the squirrel lang you linked LordAro
20:19:20 <Samu> doesn't detect brackets that well
20:20:17 <TrueBrain> nielsm: k; will talk to frosch about eints, and I hope someone can look into hooks for the commit checker :) Would you mind making a bug ticket out of it? (I guess it should go in https://github.com/OpenTTD/OpenTTD-CF ; possibly in git-hooks)
20:21:10 *** Wormnest has joined #openttd
20:21:40 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6078: Orders: it does not jump order by remaining lifetime https://git.io/fh39a
20:22:50 <Samu> Lua looks almost good, but still with some issues
20:23:25 <andythenorth> anyone know if J0anJosep is juanjo?
20:23:28 <andythenorth> writing style is same
20:23:39 <LordAro> yeah
20:24:19 <TrueBrain> owh, Windows seems to have 'make' :D
20:24:21 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5978: Autoreplace window isn't updated after group hierarchy changes https://git.io/fh39K
20:24:22 <TrueBrain> ssswwweeettttt
20:24:37 <Samu> C# looks alright for squirrel
20:24:41 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5944: Track type change breaks Two-Way EOL https://git.io/fh39i
20:24:43 <Eddi|zuHause> duuuudeee
20:24:49 <TrueBrain> SWEEEETTTTTTT
20:25:00 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5735: Signals: signal window - show one signal variant at a time https://git.io/fh391
20:25:08 <Samu> well, not really, many stuff missing highlight
20:25:30 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5877: Motion counter continues to increase while train is waiting at non-path signals https://git.io/fh39M
20:25:47 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #4684: Use shift to estimate costs only with a certain type of commands https://git.io/fh39y
20:25:49 <Eddi|zuHause> <TrueBrain> owh, Windows seems to have 'make' :D <-- i'm pretty sure i've seen "make" in my dos days, but that might have been on Novell Dos
20:25:50 <TrueBrain> a release is 13 jobs .. lol
20:26:01 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #2155: Console: heightmaps for dedicated server https://git.io/fh39S
20:26:06 <Eddi|zuHause> also, i had no clue what that even did back then
20:26:24 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #2944: Timetable: auto-reset delay counter https://git.io/fh399
20:26:44 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #4540: Orders: toggle display of implicit orders https://git.io/fh39Q
20:27:45 <andythenorth> this one looks done?
20:27:46 <andythenorth> https://github.com/OpenTTD/OpenTTD/issues/6422
20:27:53 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6422: [patch] GS function to scroll viewport for all players in company https://git.io/fh395
20:28:12 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6640: Less towns than set in menu https://git.io/fh39F
20:28:19 <Samu> how is try { bla } catch (bla) { bla } used ? :(
20:28:28 <Samu> is it for callbacks?
20:28:30 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5078: NOAI API lack vehicle is old event https://git.io/fh39N
20:28:47 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5208: Console: make console commands 'ls' and 'load' work with scenarios https://git.io/fh39x
20:29:13 <Eddi|zuHause> if it has a patch, why not just commit it?
20:29:28 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5377: AIs cannot detect river tiles https://git.io/fh39p
20:29:54 <andythenorth> Eddi|zuHause: list the procedure for doing that....
20:30:26 * andythenorth tries
20:30:28 <andythenorth> - download
20:30:37 <andythenorth> - make a branch
20:30:42 <andythenorth> - rebase patch to current master
20:30:49 <andythenorth> - fix any conflicts
20:30:52 <andythenorth> - compile
20:30:57 <andythenorth> - fix any compile issues
20:30:58 <andythenorth> - test
20:31:05 <andythenorth> - check code style
20:31:13 <andythenorth> - check it actually is a good idea
20:31:16 <andythenorth> - make a PR
20:31:25 <andythenorth> - persuade someone to review
20:31:36 <TrueBrain> I like how you went all in on this :D
20:31:36 <Eddi|zuHause> easy, right?
20:31:39 <andythenorth> - persuade someone to merge
20:31:43 <andythenorth> - close issue
20:31:58 <TrueBrain> you forgot:
20:32:01 <andythenorth> just saying it's a lot of work for someone who's totally disinterested
20:32:04 <TrueBrain> - get frustrated as nobody really cared in the first place
20:32:07 <TrueBrain> - you let it go stale
20:32:11 <TrueBrain> - a bot closes your PR
20:32:20 <Eddi|zuHause> i'd put the "make a PR" step earlier
20:32:25 <andythenorth> otoh I've seen peter1138 commit about 30 FS patches in one day
20:32:32 <andythenorth> so eh, depends on your person
20:32:54 <TrueBrain> 2019-01-05T19:32:19.5571987Z /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/5/../../../x86_64-linux-gnu/liblzo2.a(lzo_util.o): relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC
20:32:54 <TrueBrain> 2019-01-05T19:32:19.5574721Z /usr/lib/gcc/x86_64-linux-gnu/5/../../../x86_64-linux-gnu/liblzo2.a: error adding symbols: Bad value
20:32:56 <TrueBrain> this sounds bad
20:32:58 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5321: AI: allow placing waypoints like human player (next to each, other, covering more than 1 tile etc) https://git.io/fh3HU
20:32:59 <Eddi|zuHause> it depends whether you're bureaucratically aligned or "just do it"
20:33:00 <nielsm> TrueBrain: https://github.com/OpenTTD/OpenTTD-CF/issues/14
20:33:25 <TrueBrain> nielsm: ty!!
20:33:43 <andythenorth> look this one I even made a frigging video https://github.com/OpenTTD/OpenTTD/issues/6145#issuecomment-379453516
20:33:48 <andythenorth> ok it's a .mov :P
20:34:02 <andythenorth> still no-one is picking it up and PR-ing it
20:34:40 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6145: High CPU usage for ships with empty orders https://git.io/fh3Hq
20:35:31 <andythenorth> ok this one, I'll eat my own advice https://github.com/OpenTTD/OpenTTD/issues/4754#issuecomment-381081296
20:35:34 <andythenorth> PR incoming
20:35:40 <TrueBrain> what can I do about the lzo error .. does it suggest I compile lzo with -fPIC, or OpenTTD with -fPIC ..
20:36:35 <TrueBrain> 2019-01-05T19:36:16.9944594Z cp: cannot stat 'objs//Release/openttd.pdb': No such file or directory
20:36:40 <TrueBrain> hmm .. why is the pdb not created ..
20:37:20 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6422: [patch] GS function to scroll viewport for all players in company https://git.io/fh3H3
20:37:21 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6422: [patch] GS function to scroll viewport for all players in company https://git.io/fh3Hs
20:37:26 <TrueBrain> glx: you happen to know?
20:37:33 <LordAro> TrueBrain: probably the former
20:37:45 <TrueBrain> owh, TARGET is empty ..
20:37:48 <TrueBrain> PLATFORM is empty
20:37:50 <TrueBrain> right, my bad
20:37:51 <TrueBrain> fixing :D
20:38:23 <Eddi|zuHause> ok, 2 out of 2 hunks failed, that's a good start?
20:38:33 <Eddi|zuHause> "at least the files still exist"? :p
20:38:59 <TrueBrain> LordAro: any clue why it happens, or what I can reasonably do about it?
20:41:08 <LordAro> TrueBrain: not really
20:41:20 <TrueBrain> it is weird, not? Most 64bit deb-based systems give me that error
20:43:58 <Xaroth> I blame TrueBrain.
20:44:16 <TrueBrain> go find a nice coop game to play plz
20:44:29 <Xaroth> OpenTTD? :P
20:44:33 <andythenorth> or do some PRs
20:44:42 <Xaroth> ... you really want -me- to go through PRs?
20:44:56 <andythenorth> eh how do I fake the author in a git commit?
20:44:59 <TrueBrain> there is a reason you don't have any permissions Xaroth
20:45:03 <Xaroth> ^
20:45:08 <andythenorth> I am making a PR for https://github.com/OpenTTD/OpenTTD/issues/4754#issuecomment-381081296
20:45:10 <TrueBrain> andythenorth: don't. Add (patch by ..) behind the commit message
20:45:12 <andythenorth> which is frosch
20:45:20 <TrueBrain> it is evil to fake authors :P
20:46:09 <TrueBrain> okay, I am just going to skip deb-based releases for nightlies :P
20:47:50 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth opened pull request #7015: Change: Desert tiles are now half-desert if a neighboured tile is non… https://git.io/fh3Ho
20:48:00 <TrueBrain> OMG THAT IDEA IS HORRIBLE
20:48:04 <TrueBrain> (sorry, I just had to)
20:48:30 <Eddi|zuHause> hm, i don't find a rev where the patch applies
20:49:00 <andythenorth> eh TB have any macOS binaries got built yet?
20:49:02 <andythenorth> I want to close this
20:49:03 <andythenorth> https://github.com/OpenTTD/OpenTTD/issues/6978
20:49:24 <TrueBrain> hold your horses :P
20:50:01 <andythenorth> Horses is only alpha 2
20:50:07 <andythenorth> I am holding it
20:50:19 <Xaroth> Alpha 2 doesn't sound like you're holding it
20:50:31 <andythenorth> I am supposed to be drawing more trains for it
20:50:36 <andythenorth> but TrueBrain made me do admin
20:51:07 <Xaroth> Admin is also useful
20:51:07 <TrueBrain> yes; I told him: YOU ARE NOT GOING TO SPEND YOUR TIMING UNDERSTANDING A PYTHON SCRIPT
20:51:08 <TrueBrain> and he listened
20:51:27 <Xaroth> o_O
20:51:31 <andythenorth> this is much more fun than combinatorial shit
20:51:57 <TrueBrain> hmm .. how to detect the name of the bundles ..
20:52:01 <TrueBrain> I forgot how we used to do that :(
20:52:23 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6851: Application data shouldn't be written to ~/Documents/OpenTTD on OSX https://git.io/fh3H1
20:52:24 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6851: Application data shouldn't be written to ~/Documents/OpenTTD on OSX https://git.io/fh3HM
20:53:10 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6865: Drawing vertical/horizontal lines of width>1 problem https://git.io/fh3Hy
20:54:32 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6634: Most AI scripts from official extensions crash frequently https://git.io/fh3HF
20:54:33 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6634: Most AI scripts from official extensions crash frequently https://git.io/fh3Hb
20:57:35 <TrueBrain> seems I am not the only one with issues related to fpic and lzo: https://bugs.launchpad.net/ubuntu/+source/lzo2/+bug/1638535
20:57:36 <TrueBrain> 2016
21:01:25 <DorpsGek_II> [OpenTTD/OpenTTD] George-VB opened issue #7016: New variables for railtype https://git.io/fh3QT
21:01:28 <andythenorth> anyone know the size of return values in cb36?
21:01:31 <andythenorth> I can't see it in docs
21:01:53 <andythenorth> for some reason my comments say frosch told me it's 32k
21:01:55 <andythenorth> which seems odd
21:02:08 <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z commented on issue #5944: Track type change breaks Two-Way EOL https://git.io/fh3QI
21:02:35 <andythenorth> all cbs are 15 bit return values?
21:02:39 <andythenorth> so that's 32k?
21:03:05 <Eddi|zuHause> yes
21:03:07 <LordAro> @calc 2**15
21:03:07 <DorpsGek> LordAro: 32768
21:03:35 <glx> <TrueBrain> owh, Windows seems to have 'make' :D <-- yes they have mingw32 installed it seems
21:04:23 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6581: NewGRF cannot configure purchase prices per wagon https://git.io/fh3QZ
21:04:25 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6581: NewGRF cannot configure purchase prices per wagon https://git.io/fh3Qn
21:04:30 <TrueBrain> glx: yup; works like a charm
21:04:41 <Eddi|zuHause> technically, it could be larger, if the content of var1C is evaluated instead of the "result"
21:04:43 <glx> so nsis should be installed too
21:04:45 <TrueBrain> 2019-01-05T20:04:14.0015138Z /usr/bin/sh: makensis.exe: command not found
21:04:46 <TrueBrain> awh
21:05:25 <TrueBrain> possibly it is not on path or something
21:05:31 <TrueBrain> or not known in mingw
21:06:12 <glx> probably not known in mingw if mingw doesn't use global path
21:08:02 <TrueBrain> do you happen to have NSIS installed? and mingw? what would the path be?
21:08:28 <glx> you could try to run the .bat, but I guess the hardcoded path is wrong in it
21:08:54 <TrueBrain> I am now running 'bundle_exe'
21:08:57 <TrueBrain> which runs makensis
21:09:24 <TrueBrain> .bat wont work, as it needs the 9x
21:09:59 <glx> .bat fails for me because nsis is in program files(x86)
21:10:23 <TrueBrain> in mingw this is just /c/Program Files (x86)/NSIS, right?
21:10:47 <glx> hmm you could echo the path somewhere ;)
21:11:06 <TrueBrain> good point
21:11:33 <glx> and same from a cmd task
21:11:38 <glx> to compare
21:12:12 <TrueBrain> right, while that is running .. how did we plan to do the versions with git?
21:12:19 <TrueBrain> openttd-trunk-r12345 will no longer fly
21:12:30 <TrueBrain> openttd-nightly-20190105-g96blabla ?
21:12:52 <glx> date and hash seems good
21:13:07 <Eddi|zuHause> we still skipped the question of how to do NewGRF version stepping between releases
21:13:13 <andythenorth> is this a performance problem? https://github.com/OpenTTD/OpenTTD/issues/7016
21:13:19 <andythenorth> or just we don't want to do it? ^
21:13:23 <TrueBrain> Eddi|zuHause: not my department :)
21:14:13 <Xaroth> andythenorth: define 'nearby' ?
21:15:00 <Eddi|zuHause> andythenorth: railtype vars were always discouraged because of "performance concerns", it was never checked whether that is actually a real "issue", i think...
21:15:08 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6505: Allow rail when ships are on lower halftile https://git.io/fh3QP
21:15:56 <andythenorth> surely we just cache them? :P
21:16:11 <andythenorth> easy to say :P
21:16:45 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5944: Track type change breaks Two-Way EOL https://git.io/fh3QS
21:16:46 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #5944: Track type change breaks Two-Way EOL https://git.io/fh3Q9
21:17:14 <Eddi|zuHause> andythenorth: cache the spriteID in mWhatever, and only recalculate in the tileloop?
21:18:32 <andythenorth> something like that
21:18:58 <Eddi|zuHause> that's not really going to work as there are multiple sprites per tile
21:19:24 <Eddi|zuHause> (6 potential trackbits plus 6 catenary bits)
21:20:12 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6381: Game Script: method to change company rating in town https://git.io/fh3Qj
21:21:40 <andythenorth> Eddi|zuHause: gravedig this one? o_O https://github.com/OpenTTD/OpenTTD/issues/6360
21:22:31 <andythenorth> planetmaker: is this the missing support for runway skid sprites? o_O https://github.com/OpenTTD/OpenTTD/issues/6334
21:23:34 <Eddi|zuHause> how do i close a branch in git?
21:23:36 <andythenorth> Samu: related to your AI work with autorenew? o_O https://github.com/OpenTTD/OpenTTD/issues/6323
21:23:40 <andythenorth> Eddi|zuHause: git branch -D?
21:23:48 <andythenorth> or -d
21:25:30 <Eddi|zuHause> no conflicts...
21:25:41 <Eddi|zuHause> (on 6360)
21:26:47 <Eddi|zuHause> but if i turn that into a PR, it will have my name attached instead of Cirdan's
21:27:01 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6053: Vehicle Groups: packing and unpacking subgroups https://git.io/fh37W
21:27:10 <andythenorth> Eddi|zuHause: yup
21:27:17 <andythenorth> :|
21:28:19 <andythenorth> Eddi|zuHause: cf https://github.com/OpenTTD/OpenTTD/pull/7015
21:28:23 <andythenorth> I am now frosch :P
21:29:29 <planetmaker> andythenorth, I think so, yes
21:29:41 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5872: No wait cursor while autosaving https://git.io/fh378
21:32:55 <Eddi|zuHause> bah, i forgot to check out the branch after creating it... again
21:37:46 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5679: Allow characters as hotkey instead of assuming everyone uses a Latin keyboard https://git.io/fh37P
21:38:04 <TrueBrain> hmm, Azure Pipelines uses a detached head ... hmmm
21:38:54 <dwfreed> that's pretty common in CI frameworks; they'll checkout the commit ID, thus detaching HEAD from a branch
21:39:05 <TrueBrain> yup; it is just annoying :D
21:40:37 <planetmaker> TrueBrain, *please* tell me how to get the branch name :) I'm struggling with that, too...
21:40:46 <planetmaker> once you find out :P
21:40:54 <planetmaker> I find that behaviour also super annoying
21:41:03 <TrueBrain> if you have a ref, it is impossible to know 100% sure what the branchname is, without additional information
21:41:06 <TrueBrain> as there might be several
21:41:09 <TrueBrain> but .. hmm
21:41:20 <TrueBrain> there is Build.SourceBranchName
21:41:24 <TrueBrain> and Build.SourceBranch
21:41:28 <TrueBrain> but that feels dirty :P
21:41:41 <planetmaker> it does... as it might potentially give you another ref
21:41:44 <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z opened pull request #7017: Add: Conditional order for max. reliability (patch by Cirdan, #6360) https://git.io/fh37d
21:41:46 <dwfreed> yeah, was going to say, Azure Pipelines should be including the branch information somewhere
21:41:46 <planetmaker> race conditions or stuff
21:41:53 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5564: Wagons: (non-powered train vehicles) show introduction date and lifetime https://git.io/fh37b
21:41:54 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #5564: Wagons: (non-powered train vehicles) show introduction date and lifetime https://git.io/fh37N
21:42:26 <TrueBrain> planetmaker: easily solved by doing a 'git checkout -B $(Build.SourceBranchName)' I guess
21:42:35 <TrueBrain> still keeps the current source, and names the head
21:42:40 <TrueBrain> but still ... feels ...
21:42:52 <planetmaker> hm
21:43:02 <Eddi|zuHause> andythenorth: did i even interpret the feature description right?
21:43:16 <planetmaker> so, are you then sure that it's the correct hash? Or is that given somewhere, too?
21:43:30 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5451: Do not overlap vehicle view window with child windows (orders, timetable, details) https://git.io/fh37x
21:44:08 <TrueBrain> planetmaker: capital B overwrites any existing branch, and makes the branchnamepoint to the current HEAD
21:44:10 <TrueBrain> forced
21:44:12 <glx> the hash should be correct as it's the one used to pull the source
21:44:14 <TrueBrain> so I guess that should work
21:44:23 <planetmaker> ah!
21:44:27 <TrueBrain> glx: NSIS is not in c:\Program Files (x86) .. I did expect it there :(
21:44:32 <planetmaker> yes, feels dirty. But meh
21:44:47 <planetmaker> go for it, seems to be the git way ;)
21:44:50 <andythenorth> Eddi|zuHause: afaict yes
21:45:05 <andythenorth> in the country of the blind, one eyed man is king :P
21:45:06 <glx> https://github.com/Microsoft/azure-pipelines-image-generation/blob/master/images/win/scripts/Installers/Install-NSIS.ps1
21:45:10 <TrueBrain> hmm .. so I change the BuildNumber, but other jobs do not see it ..
21:45:45 <planetmaker> Eddi|zuHause, andythenorth can't you set a different committer name in git?
21:46:07 <Xaroth> planetmaker: does this work perhaps: ``` git branch --remote --verbose --no-abbrev --contains | sed -rne 's/^[^\/]*\/([^\ ]+).*$/\1/p' ```
21:46:09 <Eddi|zuHause> planetmaker: possibly, but i wouldn't know how, and i can't be bothered to look up
21:46:14 <glx> it should be there, unless ${env:ProgramFiles(x86)} is not in c:
21:46:33 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5317: AI: Lack of RegisterAI in info.nut is not reported with enabled debug console https://git.io/fh35J
21:46:34 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #5317: AI: Lack of RegisterAI in info.nut is not reported with enabled debug console https://git.io/fh35U
21:47:00 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5304: Game Script: GSTown.SetCargoGoal() and GSTown.SetGrowthRate() affecting all towns in one step https://git.io/fh35k
21:47:01 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #5304: Game Script: GSTown.SetCargoGoal() and GSTown.SetGrowthRate() affecting all towns in one step https://git.io/fh35I
21:47:01 <Eddi|zuHause> planetmaker: does Cirdan have a github?
21:47:03 <glx> all these DorpsGek_II spam starts to be annoying
21:47:06 <andythenorth> :|
21:47:15 <andythenorth> I get highlighted everytime I do one
21:47:30 <Xaroth> use a different IRC name :P
21:47:36 <Eddi|zuHause> rightclick->ignore DorpsGek_II
21:47:44 <planetmaker> Not sure... what's his git URL for his branch?
21:47:51 <TrueBrain> people are always complaining ... either there is no notification in this channel, people complain .. and than there is too much ..
21:47:57 <planetmaker> I *thought* it was on GitHub - but I might be wrong
21:48:18 <planetmaker> TrueBrain, yes. But tbh it's good to see the notifications here.
21:48:21 <Eddi|zuHause> planetmaker: he apparently wasn't in 2014
21:48:26 <TrueBrain> planetmaker: I know :)
21:48:34 <TrueBrain> planetmaker: just someone had to complain again about it being here :P
21:48:46 <planetmaker> We used to have the .notice... but it's dead since the GitHub move - and I didn't shed a tear for it ;)
21:48:50 <andythenorth> Eddi|zuHause: I can't find a github
21:48:52 <andythenorth> just the thread
21:48:56 <andythenorth> I thought there was one
21:49:02 <TrueBrain> planetmaker: changing the Author name is evil .. I think I even configured GitHub to deny those pushes
21:49:18 <andythenorth> TrueBrain: the people complaining aren't the high activity ones :x
21:49:22 <TrueBrain> Author should always be the person pushing
21:49:35 <TrueBrain> (otherwise you can do some nasty nasty shit)
21:49:56 <Eddi|zuHause> andythenorth: there's only https://repo.or.cz/w/openttd/fttd.git which was linked in the earlier ticket
21:50:09 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5244: Allow editing new-game settings in-game https://git.io/fh35c
21:50:10 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #5244: Allow editing new-game settings in-game https://git.io/fh35C
21:50:17 <milek7> isn't author and commiter separate in git?
21:50:37 <TrueBrain> they are
21:50:53 <Eddi|zuHause> well, if you tell me how to set author, i can update the PR
21:50:58 <planetmaker> TrueBrain, you can always do nasty shit ;)
21:50:59 <TrueBrain> Eddi|zuHause: again, don't :)
21:51:17 <TrueBrain> give credit in your commit message, and you are good
21:51:17 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5006: Railtypes: 'hide railtype' flag https://git.io/fh35l
21:51:36 <Eddi|zuHause> did that
21:51:46 <TrueBrain> (most tools show Author as 'person responsible' for a commit .. it is very evil to put someone elses name there :D)
21:51:55 <TrueBrain> lets contribute all commits to ...... Donald Trump!
21:52:02 <TrueBrain> (please don't :P)
21:52:17 <Eddi|zuHause> Drumpf, please
21:52:27 <TrueBrain> I believe you have a Patch-By entry, if you want to be real fancy
21:52:54 <Eddi|zuHause> again, i wouldn't bother, but if people insist and give me a quick command...
21:53:01 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6323: AI: autorenew failed event https://git.io/fh35B
21:53:02 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6323: AI: autorenew failed event https://git.io/fh35R
21:53:08 <TrueBrain> again, I will promptly deny your PR in that case :)
21:53:28 <andythenorth> 198 issues now
21:53:33 <andythenorth> so about 40 killed today
21:53:55 <andythenorth> and about 50 will be gone next weekend
21:53:58 <TrueBrain> damn, this git branch issue is tricky as fuck
21:54:05 <andythenorth> TAF
21:54:05 <TrueBrain> nice work andythenorth :)
21:54:15 <TrueBrain> if we continue like this,w e might set reasonable goals for releases again
21:54:16 <ST2> call it a good "hunting season" - just to leave my thanks for all your efforts :)
21:54:21 <TrueBrain> like: no more than N open bugs :P
21:54:27 <Eddi|zuHause> andythenorth: problem with "batch-stale-ing" issues is that nobody can use the stirred up interest to actually review all of them
21:54:42 <andythenorth> +1
21:54:43 <Eddi|zuHause> andythenorth: if you picked one per day, that would catch more of them
21:54:53 <TrueBrain> only a one-time issue :)
21:54:58 <andythenorth> a bunch of them are junk anyway
21:55:19 <andythenorth> but there are maybe 10 or so
21:55:27 <andythenorth> that ought to be considered seriously
21:55:31 <Eddi|zuHause> yeah, 10. and we looked at... 2?
21:55:42 <andythenorth> yeah we have a week
21:55:45 <Eddi|zuHause> that's 8 down the drain which will never come back
21:55:48 <andythenorth> to triage the other 50 or so
21:56:21 <andythenorth> issue trackers are an object lesson in loss aversion theory
21:56:41 <planetmaker> hm, the one-per-day stir-up sounds like an idea worth trying
21:56:56 <andythenorth> based on what I know about frosch
21:56:59 <andythenorth> this is 'no'
21:57:00 <andythenorth> https://github.com/OpenTTD/OpenTTD/issues/6908#issuecomment-423330322
21:57:05 <andythenorth> only frosch is super polite
21:58:00 <TrueBrain> planetmaker: nah, we should install that bot, which automatically does it after 60 days of no activity
21:58:14 <TrueBrain> then it stirs up depending on the rate of the community :D
21:58:22 <TrueBrain> just a bit of backlog now :P
21:58:37 <TrueBrain> "nightly-20190105-azure_release-g37f997f5"
21:58:40 <TrueBrain> a nightly that is not master, lol
21:59:01 <LordAro> now that's definitely too long for the network version :p
21:59:04 <andythenorth> planetmaker: that airport one is a clear candidate
21:59:35 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6633: cargomonitor industry delivery https://git.io/fh35i
21:59:51 <planetmaker> andy: which #?
22:00:34 <TrueBrain> 145 unread mails
22:00:37 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6592: Missing symbols while linking with MinGW and LTO https://git.io/fh35S
22:00:49 <andythenorth> is this maybe one for glx? https://github.com/OpenTTD/OpenTTD/issues/6592
22:01:34 <TrueBrain> anyway, planetmaker, "git checkout -B ${BUILD_SOURCEBRANCHNAME}" works for me
22:01:54 <TrueBrain> findversion.sh also does what it should, in that case
22:02:55 <TrueBrain> openttd-nightly-20190105-azure_release-g37f997f5-linux-generic-amd64.tar.xz
22:02:55 <TrueBrain> LOL
22:03:26 <andythenorth> planetmaker: https://github.com/OpenTTD/OpenTTD/issues/6334
22:04:15 <glx> andythenorth: well it's silly a compiler should not optimise out the program entry point
22:05:09 <andythenorth> silly patch or silly issue? o_O
22:05:15 <glx> silly issue
22:05:17 <planetmaker> ty
22:05:28 <glx> it's like not finding main()
22:05:54 <andythenorth> PR? o_O
22:06:08 <TrueBrain> glx: turns out NSIS is not installed on the image I was using
22:06:09 <andythenorth> also so are we going to PR peter1138's patch here? https://github.com/OpenTTD/OpenTTD/issues/6145#issuecomment-379453512
22:06:16 <TrueBrain> "VS2017-Win2016"
22:06:50 <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z commented on issue #6908: Request: Persistent storage for vehicles https://git.io/fh35p
22:07:04 <glx> but it should be, it's in https://github.com/Microsoft/azure-pipelines-image-generation/blob/master/images/win/vs2017-Server2016-Azure.json
22:07:27 <TrueBrain> possibly they are not in sync?
22:07:30 <glx> line 438
22:07:46 <TrueBrain> 19th of October it got added
22:07:55 <Eddi|zuHause> andythenorth: if frosch's answer is a "no", then i'm on the opposing side
22:07:57 <TrueBrain> guess they havent updated yet .. I read more that they dont have a CI/CD on it :D
22:08:09 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6908: Request: Persistent storage for vehicles https://git.io/fh3de
22:09:42 <DorpsGek_II> [OpenTTD/OpenTTD] planetmaker commented on pull request #7017: Add: Conditional order for max. reliability (patch by Cirdan, #6360) https://git.io/fh3dL
22:10:01 <glx> you maybe need to build your own 2017 image
22:10:28 <DorpsGek_II> [OpenTTD/OpenTTD] planetmaker approved pull request #7017: Add: Conditional order for max. reliability (patch by Cirdan, #6360) https://git.io/fh3dq
22:10:38 <TrueBrain> glx: not possible for free accounts
22:10:39 <DorpsGek_II> [OpenTTD/OpenTTD] planetmaker merged pull request #7017: Add: Conditional order for max. reliability (patch by Cirdan, #6360) https://git.io/fh37d
22:10:52 <andythenorth> :)
22:11:23 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6360: Orders: 'max reliability' order filter https://git.io/fh3dm
22:11:24 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6360: Orders: 'max reliability' order filter https://git.io/fh3dY
22:11:28 <planetmaker> stupid github. I just wanted to merge it. But no, I first have to make a review :P
22:11:54 <glx> too bad because https://github.com/Microsoft/azure-pipelines-image-generation/blob/master/docs/vs2017.md clearly says to use vs2017-Server2016-Azure.json
22:12:59 <andythenorth> this is old, but looks like a candidate for PR https://github.com/OpenTTD/OpenTTD/issues/2155
22:13:12 <andythenorth> previous review by yexo, idea seems uncontroversial
22:13:25 <TrueBrain> glx: https://github.com/Microsoft/azure-pipelines-image-generation/issues/627
22:13:27 <TrueBrain> we are not alone :D
22:14:13 <glx> and https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=vsts&tabs=yaml says "Software on Microsoft-hosted agents is updated once each month."
22:14:20 <TrueBrain> LIES! :P
22:14:46 <andythenorth> everything is awful
22:14:54 <TrueBrain> for now, I can just do like the script would do :D
22:15:17 <Eddi|zuHause> "updated once a month" doesn't mean "uses bleeding edge"
22:15:31 <andythenorth> 'update: nope nothing stable'
22:15:47 <Eddi|zuHause> the "debian stable" kind of "update"
22:16:44 <andythenorth> so I already tested this one, someone reviewing it? o_O https://github.com/OpenTTD/OpenTTD/issues/6145
22:17:24 <TrueBrain> so that just leaves the liblzo2 issue for deb-based amd64 systems
22:17:29 <TrueBrain> really no clue how to approach that issue
22:17:42 <glx> TrueBrain: indeed, choco should at least be present and able to install nsis for us
22:18:14 <glx> it's clearly listed in the installed softwares
22:18:29 <planetmaker> andythenorth, so... how would I tell github "yes, please make a PR from the attached patch"?
22:18:34 <planetmaker> The procedure is not clear to me
22:18:50 <planetmaker> re #6956
22:19:02 <planetmaker> or #6145
22:19:06 <TrueBrain> create fork, download patch, checkout fork, checkout branch, apply patch, commit, push to fork, make pull request
22:19:07 <planetmaker> seem to be... similar?
22:19:26 <andythenorth> I would http://webster.openttdcoop.org/?channel=openttd&date=1546646400#1546716594
22:19:32 <glx> but they should indicate somewhere the current version of the image, or at least the build date
22:19:38 <TrueBrain> glx: I agree
22:19:49 <TrueBrain> seems we cannot have it all :D
22:20:21 <planetmaker> https://github.com/OpenTTD/OpenTTD/pull/6956 <-- what is this actually "waiting for status"? Will that ever turn green or is it ... just not working for those?
22:20:35 <glx> "Components marked with * have been upgraded since the previous version of the image." <-- means they indicate outdated stuff in the readme ?
22:20:36 <TrueBrain> planetmaker: needs rebase
22:20:54 <TrueBrain> guess I can comment that on all old PRs
22:21:19 <planetmaker> uh-oh. *That* is totally not clear from the status-report's wording as-is
22:21:28 <TrueBrain> I noticed; bit sad
22:22:15 <TrueBrain> "We recently switched from Jenkins as CI to Azure Pipelines as CI. This means you need to rebase before this Pull Request will pass its checks. Sorry for the troubles!" <- clear enough?
22:22:18 <TrueBrain> (before I post this 20 times)
22:22:21 <Eddi|zuHause> TrueBrain: additionally to all the build tasks a task that has a checkmark if it's based against current trunk?
22:22:49 <TrueBrain> Eddi|zuHause: ask GitHub plz :D
22:22:52 <andythenorth> TrueBrain: works for me
22:22:54 <TrueBrain> I have no means to implent that :(
22:23:02 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #6784: Ship cpu hog workaround for #6145 https://git.io/fh3dg
22:23:02 <planetmaker> I guess that's understandable, yes
22:23:20 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #6817: PR for Modernizing for C++11: replacing instances of SmallVector https://git.io/fh3d2
22:23:31 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #6846: Feature: Allow flip of train vehicles in depot independently of NewGRF property https://git.io/fh3dV
22:23:41 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #6848: Feature : New Trees Placement Algorithm "Forest". https://git.io/fh3dw
22:23:46 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #6872: Add: Houses can accept up to 16 different cargo types via NewGRF https://git.io/fh3dr
22:23:52 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #6925: Fix #6574 #6636 #5405 #6493: Aircraft hangar issues https://git.io/fh3do
22:23:56 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #6926: Change: Allow dock to be constructed in more locations https://git.io/fh3dK
22:24:01 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #6927: Change: Forbid dock placement on docking area https://git.io/fh3d6
22:24:06 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fh3di
22:24:12 <Eddi|zuHause> SPAAAAAAM
22:24:15 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #6929: Add #6410: [YAPF] Use a max penalty for finding the nearest road vehicle depot https://git.io/fh3dP
22:24:19 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #6931: Change: Prevent town growth from blocking ships https://git.io/fh3dX
22:24:25 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #6933: Fix #6233: Improve lock pricing and infrastructure counting, to achieve better consistency https://git.io/fh3d1
22:24:30 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #6935: Add: EnsureNoShipFromDiagDirs https://git.io/fh3dM
22:24:33 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #6956: Fix #6145: Prevent ships without valid orders from moving https://git.io/fh3dD
22:24:37 <planetmaker> eddi was faster :) Was going to say so, too :P
22:24:37 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #6965: Add: Four alternative town cargo generation methods https://git.io/fh3d9
22:24:41 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #6973: Add: Unique ID to savegames to prevent accidental overwriting https://git.io/fh3dH
22:25:10 <TrueBrain> I hate you both :P
22:25:15 <TrueBrain> there we go :)
22:25:15 <Eddi|zuHause> <planetmaker> eddi was faster :) <-- is not a sentence i hear very often :p
22:25:19 <TrueBrain> and a free poke for all of them!
22:25:33 <TrueBrain> glx: 2019-01-05T21:24:58.9757988Z Plugin not found, cannot call NSIS7z::Extract
22:25:36 <TrueBrain> ... *sad panda*
22:26:43 <nielsm> okay was just about to reboot, but then I randomly tried closing _all_ WSL windows etc, waiting a bit, and starting ubuntu bash again
22:26:56 <nielsm> and then it can connect to github again via ssh
22:27:03 <nielsm> yay didn't have to reboot
22:27:22 <TrueBrain> gratz :D
22:27:25 *** synchris has quit IRC
22:27:39 <Eddi|zuHause> "have you tried defragging"?
22:28:18 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #6872: Add: Houses can accept up to 16 different cargo types via NewGRF https://git.io/fNanB
22:28:58 <TrueBrain> ah, 7z stuff is needed for the external thingies
22:29:00 <TrueBrain> I remember ..
22:29:48 <TrueBrain> ironical, to install NSIS plugins you have to do some manual labor
22:30:25 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #6965: Add: Four alternative town cargo generation methods https://git.io/fpkqa
22:31:15 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #6990: Fix: Correct display of industry requires/produces in Build Industry window https://git.io/fhTef
22:32:09 <Eddi|zuHause> TrueBrain: that sounds better than "install an unzip program that is compressed as a zip"
22:32:34 <TrueBrain> the URL for NSIS7z ..... omg .. a forum attachment
22:32:37 <TrueBrain> that never went wrong etc etc
22:33:18 <andythenorth> omg so many GH notifications
22:33:21 <andythenorth> bloody hell
22:33:27 <andythenorth> 'mark all as read'
22:33:33 <glx> and a nice very outdated 7z version
22:34:17 <Samu> [20:23] <andythenorth> Samu: related to your AI work with autorenew? o_O https://github.com/OpenTTD/OpenTTD/issues/6323
22:34:22 <Samu> no
22:34:23 <glx> https://nsis.sourceforge.io/Nsis7z_plug-in it's on SF
22:34:45 <Samu> it's unrelated
22:34:45 <andythenorth> 'totally fine'
22:34:50 <andythenorth> ok thanks Samu
22:35:18 <Samu> but yeah, there's no event for that
22:35:28 <glx> but only the full version, indeed the binaries only are from a forum
22:36:34 <TrueBrain> glx: like I said ;)
22:36:41 <Samu> considering the vehicle failed to autorenew, the vehicle_id is unchanged, so no, it's not related
22:36:43 <TrueBrain> possibly it would be good if we can replace this plugin for something ... sane? :D
22:36:52 <nielsm> can I get some opinions on the remaining bullet point for this one? https://github.com/OpenTTD/OpenTTD/pull/6990 --- keep the number visible, re-introduce a "skip"/"ignore" insertable, or don't support pluralization?
22:37:35 <andythenorth> do we have precedent elsewhere nielsm ?
22:37:41 <andythenorth> re: pluralisation?
22:38:04 <nielsm> of the existing languages, turkish has singular for "requires" when there is only one
22:38:18 <nielsm> everything else uses the same term or something that looks like a mistake
22:38:44 <nielsm> (spanish or some other language had the same term for 1 and 3 requires, but a different for 2)
22:38:51 <andythenorth> industry window has 'requires' already
22:38:56 <andythenorth> do whatever that does :)
22:39:05 <nielsm> it does nothing about plurals
22:39:26 <andythenorth> do that then
22:39:28 <nielsm> so just do nothing here either
22:39:30 <andythenorth> it's a generic issue
22:39:35 <Eddi|zuHause> nielsm: i'd be in favour of "static text, no plural"
22:39:36 <andythenorth> so someone else can fix it :)
22:39:50 <TrueBrain> I agree with andythenorth; don't try to solve a generic issue in a PR doing something else :D
22:40:01 <TrueBrain> make a bug about it if you want to fix it :P
22:40:15 <glx> oh no DorpsGek doesn't recognize me
22:40:21 <TrueBrain> (the endless pit of: owh, and this bug, owh, and that bug, etc :D)
22:40:44 <Eddi|zuHause> how dare he?
22:40:56 <TrueBrain> @whoami
22:40:56 <DorpsGek> TrueBrain: I don't recognize you.
22:41:04 <TrueBrain> you are not alone
22:41:09 <Eddi|zuHause> he's feeling rebellious today?
22:41:13 <Samu> @whoami
22:41:13 <DorpsGek> Samu: I don't recognize you.
22:41:16 <Samu> ok then
22:41:20 <glx> ok fixed
22:41:23 <glx> whoami
22:41:28 <glx> @whoami
22:41:28 <DorpsGek> glx: glx
22:42:04 <TrueBrain> DorpsGek: forget glx
22:42:09 <DorpsGek> test
22:42:28 <TrueBrain> he is almost 14 years old ... guess it is that age
22:42:45 <glx> just needed to use the identify command
22:42:57 <glx> at least I was still registered :)
22:42:58 <Eddi|zuHause> they say that the younger one tends to be the rebellious one and the older one is more rules-abiding
22:45:08 <andythenorth> this _might_ be a good PR, but I don't get the benefit tbh https://github.com/OpenTTD/OpenTTD/issues/6613
22:45:14 <nielsm> wth happened? font rendering looks terrible all of a sudden: https://0x0.st/sRE6.png
22:45:15 <andythenorth> it's not solving a real issue afaict
22:45:32 <glx> vcpkg freetype
22:46:03 <glx> probably not compiled with the same options we used in our own freetype build
22:46:36 <TrueBrain> you can ... compile-time make freetype do different things?
22:46:39 <TrueBrain> that would be horrible :P
22:46:50 <Eddi|zuHause> andythenorth: what's the problem with that? i read that as "allow building non-rectangular airports on uneven ground"
22:46:56 <TrueBrain> but for sure we jumped a few versions .. openttd-useful uses an older version :P
22:47:07 <glx> some stuff is disabled by default IIRC in freetype
22:47:08 <andythenorth> Eddi|zuHause: how could we test it?
22:47:09 <andythenorth> o_O
22:47:21 <Eddi|zuHause> andythenorth: diagonal airport grf?
22:47:25 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #6990: Fix: Correct display of industry requires/produces in Build Industry window https://git.io/fhTef
22:48:13 <TrueBrain> awh, cannot run fakeroot with WSL :D
22:48:29 * andythenorth looks for diagonal airport
22:48:49 <TrueBrain> I find the order of findversion odd .. date-branch-git .. why not branch-date-git?
22:48:56 <TrueBrain> why is the date this important :P
22:49:15 <TrueBrain> guess if you are going to strip, this is better
22:49:18 <TrueBrain> but looks weird
22:49:47 <Eddi|zuHause> i agree with branch-date-git
22:50:40 <TrueBrain> not sure how to feel .. Eddi|zuHause agree's with me ... I am a bit scared now ...
22:50:43 <TrueBrain> :D <3 :)
22:50:59 <Eddi|zuHause> could be worse, i could agree with V453000 :p
22:51:02 <andythenorth> hmm newgrf airports died apparently
22:51:14 <TrueBrain> they crashed into a mountain?
22:51:19 <TrueBrain> it couldn't maintain lift?
22:51:22 <TrueBrain> there was too much drag?
22:51:25 <andythenorth> dunno
22:51:31 <andythenorth> mostly I think yexo left :P
22:51:36 <TrueBrain> booooooo
22:51:38 <Eddi|zuHause> Kracken... wait, wrong game
22:51:41 <TrueBrain> I am going to call my friends at Google
22:51:44 <TrueBrain> this is unacceptable
22:51:48 <TrueBrain> :D
22:52:30 <TrueBrain> Install the plugin, runs, fails
22:52:31 <TrueBrain> WUTH?!
22:52:47 <andythenorth> call Munich :P
22:53:00 <andythenorth> according to LinkedIn horrorshow
22:53:12 <Eddi|zuHause> Munich airport apparently also died :p
22:53:32 <andythenorth> so we're down to 38 stale patches from flyspray
22:53:47 <andythenorth> fill your boots if you want to save any
22:53:48 <andythenorth> https://github.com/OpenTTD/OpenTTD/issues?page=1&q=is%3Aopen+is%3Aissue+label%3A%22patch+from+FlySpray%22+label%3A%22stale%22&utf8=%E2%9C%93
22:53:59 <andythenorth> otherwise I close them next weekend, and they're.....gone forever! :O
22:59:02 <TrueBrain> okay, I think ..... that I have a nightly-like build working
22:59:08 <TrueBrain> still needs work, but it is a good first step
22:59:53 <andythenorth> \o/
23:01:52 <Samu> [20:59] <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6633: cargomonitor industry delivery https://git.io/fh35i eh... I was actually waiting for an answer
23:01:56 <Samu> but k
23:02:09 <Samu> will do a PR
23:02:33 <Samu> not the kind of answer I expected
23:04:07 <andythenorth> I have done about 40 of those comments today :)
23:04:12 <andythenorth> housecleaning
23:06:28 <nielsm> https://github.com/OpenTTD/OpenTTD/pull/6990 <-- squash to a single commit, or preseve "remove unused strings" as separate commit but squash rest?
23:07:14 *** andythenorth_ has joined #openttd
23:07:14 *** andythenorth is now known as Guest1797
23:07:14 *** andythenorth_ is now known as andythenorth
23:07:15 <TrueBrain> "2019-01-05T22:06:35.6391329Z Plugin not found, cannot call GetVersion::WindowsPlatformArchitecture" WHEN DOES THE HURTING STOP
23:07:53 <andythenorth> when you fall asleep
23:08:51 <Eddi|zuHause> i have no opinion on squashing
23:09:05 <TrueBrain> nielsm: I believe people prefer having the remove unused as a new commit
23:09:15 <TrueBrain> I think that is because the old old old WebTranslator couldn't handle it otherwise
23:09:26 <TrueBrain> so that might just became a policy out of a technical limitation :D
23:10:43 *** andythenorth has quit IRC
23:11:25 *** andythenorth has joined #openttd
23:12:49 *** Guest1797 has quit IRC
23:13:42 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #6990: Fix: Correct display of industry requires/produces in Build Industry window https://git.io/fhTef
23:16:27 *** andythenorth is now known as Guest1798
23:16:27 *** andythenorth has joined #openttd
23:16:37 *** Progman has joined #openttd
23:18:09 <andythenorth> worth saving from the bonfire? https://github.com/OpenTTD/OpenTTD/issues/6562
23:18:17 <andythenorth> 65k stations per grf
23:18:26 <andythenorth> because the UI works so well already
23:18:28 <Eddi|zuHause> <andythenorth> hmm newgrf airports died apparently <-- i think because of a lack of progress on statemachines. simple recombinations of existing statemachines with new graphics only gets you so far creatively...
23:18:55 <andythenorth> why the fuck, honestly do we need 65k stations per grf?
23:19:02 <andythenorth> unless we rework the UI to handle it
23:19:37 <TrueBrain> andythenorth: I think the question is not: do we need 64k, but: do we need more than 256
23:19:46 <Eddi|zuHause> andythenorth: needs collecting in a "when we bother updating to grfv9" topic
23:19:46 <TrueBrain> going from 256 to 64k .. is .. well, just the next step
23:19:55 <TrueBrain> and yes, 64k, not 65k. We do base2 here!
23:20:33 <andythenorth> ok so PR that one :)
23:20:57 <TrueBrain> I did not say we need more than 256 :)
23:21:01 <TrueBrain> I just said you were asking the wrong question :P
23:21:13 <andythenorth> frosch already told me it's a valid patch
23:21:20 <andythenorth> I was just being grumpy
23:21:34 <andythenorth> because the station UI is crap
23:21:34 <TrueBrain> an old grumpy dude
23:21:35 <TrueBrain> hmm
23:21:36 <TrueBrain> :D
23:21:37 <TrueBrain> <3
23:21:52 <andythenorth> but I can't open an issue about station UI because I am wading through all this old shit we keep around
23:22:15 <andythenorth> I will PR 6562
23:22:16 <TrueBrain> and I am constantly making a change, waiting 10 minutes ... failed, repeat
23:22:20 <TrueBrain> slow Windows binaries
23:22:23 <andythenorth> oof
23:22:30 <Eddi|zuHause> my laziness tells me that it's not worth PR-ing that before we decide to actually go forward with grfv9
23:22:59 <Eddi|zuHause> but that needs a "protect from stale-ness" flag
23:23:35 <Eddi|zuHause> and a "grfv9" flg
23:23:37 <Eddi|zuHause> flag
23:23:43 <andythenorth> we do things differently at work
23:23:49 *** Guest1798 has quit IRC
23:24:05 <andythenorth> there's a couple of hundred tickets open, but 'on ice'
23:24:18 <andythenorth> to take them out of sight, but avoid endless flail about closing them
23:24:23 <Eddi|zuHause> yes
23:24:25 <Eddi|zuHause> that
23:24:54 <TrueBrain> it would be nice if GitHub could support more workflow like behaviour
23:24:59 <andythenorth> then after 5 years or so I just close them all :)
23:25:01 <TrueBrain> you see that Azure DevOps does have that, for example
23:25:03 <Eddi|zuHause> once we decide to do grfv9, it must be easy to find that one
23:25:17 <TrueBrain> create a project?
23:25:23 <andythenorth> commit it to a branch
23:25:26 <andythenorth> grfv9
23:25:34 <TrueBrain> same effect, different form
23:25:39 <TrueBrain> (as closing the ticket)
23:26:11 <Eddi|zuHause> commiting to branch would close the ticket?
23:26:51 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6230: Broken savegame - Referencing invalid Vehicle https://git.io/fh3NH
23:27:02 <Eddi|zuHause> branch is probably the correct answer
23:27:06 <TrueBrain> its funny .. I knew Windows was going to take most of my time ... clearly it did ... I hate Windows :(
23:27:32 <Eddi|zuHause> TrueBrain: i said "i hate when i'm right" at least once last year
23:29:14 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6562: Stations: extended byte for NewStation ID https://git.io/fh3N7
23:29:18 <TrueBrain> 20 builds .. each build taking 2x10 + 2x8 + 6 = 42 ... I used ~1000 CPU minutes on Azure Pipelines this evening :P
23:29:38 <andythenorth> fix from frosch looks simple enough
23:29:40 <andythenorth> https://github.com/OpenTTD/OpenTTD/issues/5877#issuecomment-379452165
23:31:09 <Eddi|zuHause> "We need a property - vehicle_is_waiting_on_red_signal. Without it we can't test, it is moving very slow or stands on signal" <-- is a valid request, but probably outside of the scope of this ticket
23:31:53 <Eddi|zuHause> probably a vehicle flag: standing, accelerating, cruising, decelerating
23:32:15 <Eddi|zuHause> , unloading, loading
23:32:23 <TrueBrain> 2019-01-05T22:32:11.9806388Z Plugin not found, cannot call FindProcDLL::FindProc
23:32:28 <TrueBrain> could I already have known which plugins we needed?
23:33:09 <Eddi|zuHause> TrueBrain: no, you need to rerun a 10 minute process to find out a tiny bit of information that should be obvious
23:33:16 <peter1138> hi
23:33:18 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth opened pull request #7018: Fix: Don't increase motion counter while train is waiting at non-path… https://git.io/fh3Nb
23:33:19 <peter1138> what do i need to do?
23:33:39 <Eddi|zuHause> peter1138: turn an old patch of yours into a PR
23:33:48 <andythenorth> peter1138: mumble mumble ships
23:33:55 <peter1138> Oh, patches. Oh, ships.
23:34:01 <peter1138> I need to be able to... get into the game again.
23:34:11 <andythenorth> peter1138: https://github.com/OpenTTD/OpenTTD/issues/6145#issuecomment-379453512
23:35:10 <andythenorth> oh wait did nielsm commit that?
23:35:14 <andythenorth> the issue is still open
23:35:17 * andythenorth looks
23:35:37 <nielsm> no I offered an alternative fix
23:35:43 <nielsm> neither should be merged afaik?
23:35:45 <TrueBrain> okay, a fast scan indicates this should be the last plugin .. *fingers crossed*
23:36:00 <peter1138> I really dislike that alternative.
23:36:10 <Eddi|zuHause> the "alternate fix" seemed a bit off
23:36:29 <andythenorth> https://github.com/OpenTTD/OpenTTD/pull/6956
23:36:33 <andythenorth> nah it's weird
23:36:57 <TrueBrain> Eddi|zuHause: Trump is reaching all of us
23:37:14 <TrueBrain> "alternative" anything will never be the same again :P
23:37:30 <Eddi|zuHause> TrueBrain: i didn't even think of that
23:37:37 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on pull request #6956: Fix #6145: Prevent ships without valid orders from moving https://git.io/fh3Nh
23:37:49 <andythenorth> alternative alternative
23:38:02 <Eddi|zuHause> TrueBrain: means i can still successfully block him out of some of my thoughts
23:38:39 <TrueBrain> concratz :D
23:39:16 <TrueBrain> so we use 3 different NSIS plugins, which are all stored at a different location (wiki attachment, forum attachment, upload to random host), and all 3 are differently packed
23:39:22 <TrueBrain> I see NSIS is awesome :P
23:39:39 <TrueBrain> bit scared of the quality there, but who am I to judge :)
23:40:09 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6315: Advanced Fences: (with patch) https://git.io/fh3AI
23:40:11 <Eddi|zuHause> TrueBrain: you'll be the person most hated by the you 3 months from now
23:40:32 <TrueBrain> why?
23:40:36 <TrueBrain> what did I do? :(
23:40:44 <TrueBrain> the 3 months from now me wants to know now!
23:40:46 <Eddi|zuHause> we'll know in 3 months :p
23:40:51 <nielsm> I don't like NSIS either, for the record
23:41:24 <TrueBrain> I would be shocked if none of these plugins contain spyware :P
23:41:37 <TrueBrain> I didn't even have checksums to validate the content
23:41:46 <TrueBrain> *feels dirty*
23:41:58 <andythenorth> well can we at least keep the btc they'll mine?
23:42:38 <Eddi|zuHause> i'm assuming AWS will quickly tell us about the btc-miner
23:42:44 <andythenorth> oh just run that node.js vuln and we can steal the miners' btc
23:42:49 <andythenorth> all is well
23:42:50 <Eddi|zuHause> but i thought btc mining was dead anyway?
23:43:13 <andythenorth> Eddi|zuHause: you have to hodl
23:43:17 <andythenorth> and believe
23:43:25 <andythenorth> https://www.coinbase.com/price/bitcoin
23:43:36 <andythenorth> it's just like a currency
23:44:13 <Eddi|zuHause> if "a currency" is zimbabwe dollar?
23:44:30 <andythenorth> the problem with currency is if everyone hodls
23:44:30 <TrueBrain> okay, it ALMOST worked this time ...
23:44:33 <andythenorth> then it doesn't circulate
23:44:34 <TrueBrain> there were just some lies
23:44:52 <TrueBrain> 2019-01-05T22:44:06.2927597Z Output: "D:\a\1\s\os\windows\installer\openttd-1.9.0-beta1-win32.exe"
23:44:58 <TrueBrain> how ....... why .....that name is WRONG
23:44:59 <TrueBrain> ffs
23:45:16 <Eddi|zuHause> andythenorth: that was always the problem with btc, too many people speculating, too few people using as actual currency
23:45:25 <nielsm> you heard it, version 1.9.0 is officially in beta now!
23:45:26 <nielsm> :)
23:45:36 <andythenorth> but it's rising, quick buy! https://www.coinbase.com/price/bitcoin
23:45:48 <glx> maybe we could just switch to wix, but last time I used it (it was for OpenDUNE) it was not nice for me
23:45:49 <andythenorth> those charts are funny over the different time periods
23:46:00 <andythenorth> I could make them into any narrative I like :P
23:46:08 <nielsm> I've managed to build some (tiny) wix installers for internals tools at work
23:46:09 <andythenorth> 'bitcoin is crashed, sell'
23:46:18 <andythenorth> 'bitcoin is crashed, buy'
23:46:19 <andythenorth> etc
23:46:26 <glx> well for opendune it worked yes
23:46:29 <nielsm> but wix does feel very boilerplate-ey
23:46:48 <TrueBrain> it took me over 3 hours to get it working, WE ARE GOING TO USE NSIS NOW! :P
23:46:51 <TrueBrain> nah; I dont care
23:47:04 <glx> but I think it's less friendly to write than NSIS
23:47:07 <TrueBrain> I leave that to guys like you two, as I know nothing about Windows Installers .. I just now how to install them in a pipeline :)
23:47:26 <Eddi|zuHause> andythenorth: there was a "hacker conference" last week, and they asked the room "how many of you would have been bitcoin millionaires, if you hadn't bought a burger 10 years ago?"
23:47:48 <andythenorth> https://breakermag.com/trapped-at-sea-with-cryptos-nouveau-riche/
23:47:48 <Eddi|zuHause> lots of hands going up :p
23:49:03 <Eddi|zuHause> andythenorth: if you switch the view to "all", how can the current price be 3801 but the gain 3825?
23:49:11 <andythenorth> [shrug]
23:49:14 <nielsm> it's somewhat problematic to use as a currency when a single transaction requires several kWh of electricity to process, if not MWh
23:49:29 <andythenorth> that too
23:49:31 <TrueBrain> banks also consume power :P
23:49:41 <andythenorth> mining: nice business selling shovels
23:49:51 <andythenorth> the real money is in the custom ASIC designs
23:50:06 <andythenorth> meanwhile another vintage peter1138 https://github.com/OpenTTD/OpenTTD/issues/6155#issuecomment-379453570
23:50:28 <andythenorth> I hate issues like this
23:50:57 <andythenorth> it's probably wrong, but fixing it = politics
23:51:08 <andythenorth> and nobody will want to close it, because that's politics too
23:51:21 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6155: Vehicles are sometimes incorrectly shown as refittable https://git.io/fh3AV
23:51:25 * andythenorth does politics
23:53:09 <Eddi|zuHause> <andythenorth> the real money is in the custom ASIC designs <- you mean it was, 1 year ago
23:53:19 <andythenorth> well they made it now :)
23:53:42 <andythenorth> the real money is in custom ASIC designs which can switch to mining coin-du-jour
23:53:47 <andythenorth> or in just scamming people of course
23:56:04 <TrueBrain> okay, NSIS works now .. just ..
23:56:04 <TrueBrain> 2019-01-05T22:54:32.1573989Z /usr/bin/sh: zip: command not found
23:56:06 <TrueBrain> REALLY?! :P
23:57:13 <glx> that's for the zip version :)
23:57:18 <TrueBrain> I know
23:57:20 <TrueBrain> but ... GRR
23:57:26 <TrueBrain> how do I get zip ..
23:57:39 <glx> you could just install 7zip
23:57:42 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6155: Vehicles are sometimes incorrectly shown as refittable https://git.io/fh3AS
23:58:12 <andythenorth> all these little issues are so fricking dull :D
23:58:16 <TrueBrain> meh. bundle_zip should "just work"
23:59:12 <glx> no, zip is supported natively by explorer but there's no tool installed I think
23:59:20 <TrueBrain> *Facepalm*
23:59:36 <andythenorth> bye all, time for bed
23:59:44 <andythenorth> enough github paperwork
23:59:48 *** andythenorth has left #openttd