IRC logs for #openttd on OFTC at 2019-01-04
⏴ go to previous day
00:00:40 <Samu> local vehicleUNDepotList = AIVehicleList_Depot_UnitNumber(this.m_depotTile, AIVehicle.VT_ROAD);
00:07:39 <Samu> perhaps i don't need the vehicle type in this function
00:08:17 <Samu> i can take it from the depot tile
00:08:37 *** Thedarkb-T60 has joined #openttd
00:09:11 <Thedarkb-T60> Why why why why whywhywhyWHY?
00:09:38 <Thedarkb-T60> Does OpenTTD still need obsolete libicu and libpngs
00:10:13 <Samu> it's an obsolete game? i dunno
00:10:40 <Thedarkb-T60> I'm starting to get that impression.............
00:10:45 <Thedarkb-T60> I've been bitching about this for years.
00:12:38 <DorpsGek_II> [OpenTTD/OpenTTD] thedarkb opened issue #7008: The Debian builds all depend on shockingly out of date libicu and libpng packages. https://git.io/fhYX9
00:16:28 <andythenorth> do a PR to fix it? o_O
00:16:53 <andythenorth> as it stands that issue is likely to get closed
00:17:48 <Thedarkb-T60> I don't need to.
00:17:54 <Thedarkb-T60> It's the build farm.
00:18:16 <Samu> local vehicleUNDepotList = AIVehicleList_Depot_UnitNumber(this.m_depotTile);
00:18:20 <Samu> now without vehicle type
00:18:24 <planetmaker> libpng is not an issue really...
00:18:33 * andythenorth doesn't know how deb is packaged
00:18:44 <andythenorth> but 'shockingly out of date' is unlikely to prompt a fix
00:27:46 <glx> and as already mentionned it's not a simple upgrade ICU problem
00:28:58 <glx> because we still use stuff removed in recent ICU
00:41:04 <Samu> ScriptVehicleList_SharedOrders is a problem
00:43:17 <Samu> oh wait, it does not! wow, that's a relief
01:16:15 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #7008: The Debian and Ubuntu builds all depend on shockingly out of date libicu and libpng packages. https://git.io/fhYyM
01:16:16 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro closed issue #7008: The Debian and Ubuntu builds all depend on shockingly out of date libicu and libpng packages. https://git.io/fhYX9
01:28:29 <Thedarkb-T60> I thought neither Libpng nor libicu were a problem
01:28:37 <Thedarkb-T60> I was told a while ago that it was just the age of the build farm.
01:28:49 <Thedarkb-T60> Sorry about that.
01:28:52 <LordAro> it's a bit of both :p
01:29:01 <LordAro> but mostly not, in the case of icu
02:34:26 *** Oroburos has joined #openttd
02:47:11 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep opened pull request #7009: Improve pathfinder behaviour for finding road depots (fix #7001; see #6410, #6928, #6929) https://git.io/fhYQx
03:37:43 <Samu> Can you see where I'm going with that?
03:38:24 <Samu> I'm doing this because of autorenew/autoreplace, let's hope it's not for nothing
04:40:16 *** Wormnest has joined #openttd
08:25:04 *** andythenorth has joined #openttd
09:35:18 *** smoke_fumus has joined #openttd
10:14:28 *** andythenorth is now known as Guest1691
10:14:38 *** andythenorth has joined #openttd
10:38:57 *** chomwitt has joined #openttd
10:49:03 <crem> When is openttd 2.0.0? :)
11:07:21 *** Mahjong1 has joined #openttd
11:11:15 *** sla_ro|master has joined #openttd
11:18:13 *** Progman has joined #openttd
11:20:46 *** andythenorth has joined #openttd
11:25:34 *** andythenorth has joined #openttd
11:32:58 *** andythenorth has joined #openttd
12:52:34 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7009: Improve pathfinder behaviour for finding road depots (fix #7001; see #6410, #6928, #6929) https://git.io/fhOYO
12:54:50 <LordAro> crem: when it's finished
12:56:31 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on pull request #7009: Improve pathfinder behaviour for finding road depots (fix #7001; see #6410, #6928, #6929) https://git.io/fhOYz
13:03:57 <crem> Hm so 2.0.0 will be the ultimate openttd version when it's finished.. Make it last longer then!
13:18:25 <DorpsGek_II> [OpenTTD/website] LordAro requested changes for pull request #7: Add: downloads pages, and links from header/index to them https://git.io/fhOOw
13:38:40 <peter1138> LordAro, surely there should be a behaviour change with 7009?
13:39:38 *** Thedarkb-T60 has joined #openttd
13:41:40 <Eddi|zuHause> i think he forgot the word "unexpected"?
13:45:21 <Samu> do wagons have a unitnumber?
14:41:30 <Samu> Types of rail known to the game.
14:46:41 <LordAro> Samu: it's similar to the way "null" is used
14:55:19 *** Thedarkb-T60 has joined #openttd
14:57:00 *** synchris has joined #openttd
15:19:21 *** Thedarkb-T60 has joined #openttd
15:19:59 <Samu> so there are no rail types at all? can't be
15:25:41 <Samu> so, wagons vehicles have names
15:26:43 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7009: Improve pathfinder behaviour for finding road depots (fix #7001; see #6410, #6928, #6929) https://git.io/fhOW7
15:26:52 <Samu> unit number of wagons is 0
15:27:02 <Samu> what if i have multiple wagons?
15:45:00 <Samu> so -1 for invalid vehicle, 0 for wagons, 1 to 5000 for real vehicles
15:45:43 <Samu> i mean -1 for invalid unitnumber
15:48:15 <Samu> rail type 0 exists, but has no name, is that intended?
15:49:17 <Samu> the enumerator only got RAILTYPE_INVALID, where are the others
15:57:20 <Samu> there's VehicleID, can I invent UnitID?
15:57:28 <Samu> well, not invent, i mean reuse
15:57:37 <Samu> erm, dunno how to explain
15:58:32 <Samu> static bool IsValidVehicle_UnitNumber(UnitID vehicle_uid);
15:59:11 <Samu> _un ? _uid? what's better?
15:59:37 <nielsm> "uid" is commonly an abbreviation for Unique ID so it might be misunderstood
16:00:40 <dwfreed> why not vehicle_unitnumber?
16:01:06 <andythenorth> bigger the better
16:01:28 * andythenorth looks for some long var names
16:01:29 <dwfreed> descriptive is better than brief
16:02:24 <andythenorth> hmm can't find any really good ones
16:02:32 <Samu> static bool IsValidVehicle_UnitNumber(UnitID vehicle_unitnumber);
16:02:33 <andythenorth> visual_effect_override_by_railtype is kind of ok
16:02:59 <Samu> oh, that's actually incomplete
16:03:12 <Samu> static bool IsValidVehicle_UnitNumber(UnitID vehicle_unitnumber, ScriptVehicle::VehicleType vehicle_type);
16:03:26 <andythenorth> hehe classname PassengerVeryHighSpeedMiddleEngineConsist()
16:04:21 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep opened pull request #7010: Defined constants instead of their values https://git.io/fhOBJ
16:09:35 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7010: Defined constants instead of their values https://git.io/fhOB2
16:16:45 *** HerzogDeXtEr has joined #openttd
16:18:48 <Samu> vehicle_unitnumber <= max<UnitID>
16:18:58 <Samu> how do I extract the maximum value that UnitID can have?
16:19:15 <Samu> all I know is that it's uin16
16:19:40 <Samu> vehicle_unitnumber <= UINT16_MAX
16:19:57 <Samu> max<UnitID> doesn't work, im noob
16:21:17 *** GroovyNoodle has joined #openttd
16:21:27 <Samu> and if it's uint16, it can never be -1... uh oh, that is a problem
16:23:45 <Samu> looks like i'm gonna be forced to use int32
16:24:12 <nielsm> or you could do it like INVALID_CARGO etc. that uses the maximum value as sentinel
16:24:30 <nielsm> CargoID is a byte and the invalid value is 255
16:24:55 <Samu> can i define typedef or so?
16:25:05 <Samu> i saw a list of typedefs somewhere
16:27:06 <Samu> all the other typedefs are uints
16:28:32 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7010: Defined constants instead of their values https://git.io/fhO0M
16:29:55 <Samu> where do I see that table?
16:31:52 <nielsm> good question, it seems that file isn't included in the doxygen runs for some reason
16:37:05 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #7010: Defined constants instead of their values https://git.io/fhOE4
16:37:40 *** Wormnest has joined #openttd
16:38:43 <Samu> seems that it was documented the autorenew would screw vehicle ids
16:41:51 *** andythenorth is now known as Guest1710
16:41:52 *** andythenorth has joined #openttd
16:48:29 <Samu> typedef int32 UnitID; ///< The unitnumber of a vehicle-type of a company
16:48:34 <Samu> good english? explanation?
16:48:58 <Samu> the unit number of a full consist vehicle of a type of a company?
16:49:41 <Samu> i need to explain that wagons are not considered
16:49:57 <Samu> their ID is always 0, that would make it not unique
16:52:31 <Samu> and the invalid value is -1, if i want to maintain compatibility with the previous apis
16:53:54 <LordAro> Samu: get it working first, worry about wording of comments later
16:55:14 <Samu> ok, guess i need to make it compatible
16:56:11 *** frosch123 has joined #openttd
16:57:21 <Samu> current api treats it as a int32 and returns -1 for invalid, how to make it uint16 and return INVALID_UNITNUMBER
17:19:02 <LordAro> someone should merge some PRs
17:28:29 <andythenorth> that mac os fix :P
17:28:38 <andythenorth> which I have to merge into every PR I test currently
17:29:27 <Samu> static const UnitID INVALID_UNITNUMBER = 0xFFFFui16; ///< Invalid UnitID.
17:33:28 <andythenorth> 0xFFFFui16 isn't something I've seen before
17:35:12 <dwfreed> I don't think i16 is a thing
17:37:56 <Samu> dont know which one is uglier
17:42:47 <Samu> i'm unsure if i need to edit the bin/ai/compat_ files
17:43:31 <nielsm> those are only needed if the API of an old feature has changed
17:43:41 <nielsm> to translate from old calls to new calls
17:44:04 <Samu> i am changing a return value from -1 to UINT16_MAX
17:44:32 <andythenorth> I should make a bot
17:44:35 <nielsm> then you'd need to add some compat wrappers
17:46:46 <Samu> . /* static */ int32 ScriptVehicle::GetUnitNumber(VehicleID vehicle_id)
17:47:01 <Samu> int32 to UnitID which is uint16
17:47:13 <Samu> if (!IsValidVehicle(vehicle_id)) return -1;
17:47:35 <Samu> -1 to UNITNUMBER_INVALID which is UINT16_MAX
17:52:48 <Samu> ah, I think I know what to do
17:56:19 *** Thedarkb-T60 has joined #openttd
17:56:49 *** andythenorth is now known as Guest1713
17:56:49 *** andythenorth has joined #openttd
18:00:52 <Samu> i dont know if i want to return -1
18:19:37 <Samu> error C2371: 'UnitID': redefinition; different basic types
18:30:21 <Samu> i'm unsure what to do about GS'es
18:30:42 <Samu> it requires them to be in a company to get the correct vehicle
18:33:01 <Samu> there can be up to (15 companies * 4 vehicle types) vehicles with the same UnitNumber
18:33:26 <Samu> vehicle type is enforced as a parameter
18:37:16 <Samu> so... there can still be 15 vehicles with the same unitnumber when being OWNER_DEITY? or 0
18:41:05 <Samu> EnforcePrecondition(false, ScriptObject::GetCompany() != OWNER_DEITY);
19:08:17 <TrueBrain> andythenorth: yup, that python script will fill your _downloads folder for you
19:08:26 <TrueBrain> tnx LordAro, for review
19:09:48 <TrueBrain> so if you click resolve, it eats your comment
19:10:21 <andythenorth> oof which python version does it need
19:11:00 <LordAro> i didn't think to check that :p
19:11:00 <andythenorth> my 3.6 doesn't have aiohttp
19:11:08 <andythenorth> I will fix that...another time
19:11:16 <LordAro> well it's an external library, so it won't :p
19:11:18 <andythenorth> I read the html, it basically looks fine
19:11:18 <DorpsGek_II> [OpenTTD/website] TrueBrain commented on pull request #7: Add: downloads pages, and links from header/index to them https://git.io/fhOPh
19:12:10 <TrueBrain> LordAro: COPY .flake8 .flake8 copies the file .flake8 inside the docker under the same name
19:12:16 <TrueBrain> what did you find weird about the statement?
19:12:20 <TrueBrain> (your comment is a bit vague)
19:13:55 <LordAro> yeah, thought it was something like that
19:14:09 <LordAro> just my lack of knowledge of docker :)
19:14:26 <LordAro> (thought maybe it was doing `cp foo foo`)
19:14:42 <LordAro> given all the other COPYs have different destinations
19:15:20 <TrueBrain> hmm .. can I use a variable in openttd-releases.md
19:17:39 <LordAro> last commit 5 months ago isn't a great sign
19:20:02 <DorpsGek_II> [OpenTTD/website] TrueBrain commented on pull request #7: Add: downloads pages, and links from header/index to them https://git.io/fhOXw
19:20:18 <Borg> guys... will be easy to merge maglev -> monorail?
19:20:45 <DorpsGek_II> [OpenTTD/website] TrueBrain commented on pull request #7: Add: downloads pages, and links from header/index to them https://git.io/fhOXi
19:20:53 <TrueBrain> annoying, I cannot bundle my comments :(
19:21:25 <nielsm> Borg that has already been done?
19:22:13 <DorpsGek_II> [OpenTTD/website] TrueBrain updated pull request #7: Add: downloads pages, and links from header/index to them https://git.io/fhmIo
19:22:18 <Borg> I will read how to do it.. and I will do it myself :)
19:23:55 <TrueBrain> andythenorth: btw, I know how I want to solve downloads in the end-state; it won't stay in 'website' (but we just generate index.html files on the CDN which show a similar page). But that is future work :D
19:24:07 <TrueBrain> *focus TrueBrain, FOCUS*
19:25:54 <TrueBrain> so, nginx redirects and server-listing left
19:26:02 <TrueBrain> lets see if that can be done in this weekend or something
19:26:48 <TrueBrain> LordAro: bit difficult to see on gtihub, but I tihnk I fixed all the things you mentioned :) Tnx again!
19:29:00 <nielsm> hmm I swear I've seen a newgrf that just unifies monorail/maglev but maybe I'm confusing it with a ttdpatch option that does this?
19:30:24 <DorpsGek_II> [OpenTTD/website] LordAro approved pull request #7: Add: downloads pages, and links from header/index to them https://git.io/fhO1E
19:30:47 <LordAro> nielsm: pretty sure there's a grf that does something like that
19:31:03 <LordAro> i think it just makes the trains compatible with both track types
19:31:21 <nielsm> yes, or moves them to use the other type or somesuch
19:31:24 <LordAro> or, replaces them with trains that are compatible
19:31:29 <Samu> isn't EnforcePreCondition supposed to crash the script? I'm confused
19:32:43 <DorpsGek_II> [OpenTTD/website] TrueBrain merged pull request #7: Add: downloads pages, and links from header/index to them https://git.io/fhmIo
19:33:17 <Borg> nielsm: yeah.. I heard that is such newgrf.. cant find it for now
19:34:02 <nielsm> LordAro that's not quite the same :)
19:34:07 <TrueBrain> andythenorth: we also need a 404 and 500 page I guess; just to be fancy :)
19:34:25 <LordAro> nielsm: pretty sure that's the one i was thinking of, anyway :p
19:37:52 <LordAro> it even downloads stuff!
19:38:20 <andythenorth> TrueBrain: I'll do those in a bit
19:38:41 <Borg> nielsm: hmm seems u cannot merge it.. at least I dont think there is easy way to do it
19:38:55 <TrueBrain> andythenorth: no rush; I decided to make bug-tickets for all the missing stuff, so anyone can help (hint hint) :D
19:39:23 <nielsm> Borg no, the approach should be to change the (default) trains so they only run on one of the railtypes
19:41:52 <DorpsGek_II> [OpenTTD/website] TrueBrain opened issue #11: Make the copyright in the bottom automatically bump years https://git.io/fhOMR
19:43:28 <DorpsGek_II> [OpenTTD/website] LordAro commented on issue #11: Make the copyright in the bottom automatically bump years https://git.io/fhOMa
19:43:50 <LordAro> #10 seems very doable with some basic JS
19:44:06 * andythenorth likes the idea of more contributors
19:44:07 <andythenorth> maybe someone can kill the remaining 2001-style css :P
19:44:45 <LordAro> i fear i did not have as much time as i was expecting over christmas, so did not have any significant time for ottd :(
19:45:07 <DorpsGek_II> [OpenTTD/website] TrueBrain opened pull request #12: Fix: don't only print DATE after VERSION, but also set the BuildNumber as such https://git.io/fhOMX
19:45:14 * LordAro is currently on train heading away from parents
19:45:40 <TrueBrain> LordAro: nobody blames you; we are just a bit disapointed, that is all :P
19:45:46 <LordAro> TrueBrain: what did that cause?
19:46:03 <TrueBrain> LordAro: docker image names are wrong
19:46:08 <TrueBrain> the tag is only the git-tag
19:46:14 <TrueBrain> and I wanted it postfixed with the date :)
19:46:31 <DorpsGek_II> [OpenTTD/website] TrueBrain commented on issue #11: Make the copyright in the bottom automatically bump years https://git.io/fhOMH
19:47:02 <TrueBrain> LordAro: #10 is indeed doable, especially as we did it server-side already (and there you have less data)
19:47:08 <TrueBrain> we just have to pick a good javascript library which does this :)
19:47:22 <TrueBrain> (there are awesome small ones that do this for you)
19:47:38 <LordAro> pretty sure no external js is required
19:47:46 <LordAro> just a case of reading the user agent
19:47:49 <andythenorth> just install all of react, grunt, gulp, node
19:47:55 <TrueBrain> you want to use an existing library, as you dont want to know what you need to do to get it correct :P
19:48:30 <TrueBrain> (let others do the hard work :P)
19:49:46 <TrueBrain> I really would like to avoid writing "our own", where others did already figure it out :P
19:50:53 *** gelignite has joined #openttd
19:50:54 <DorpsGek_II> [OpenTTD/website] TrueBrain merged pull request #12: Fix: don't only print DATE after VERSION, but also set the BuildNumber as such https://git.io/fhOMX
19:51:49 <LordAro> TrueBrain: pretty sure that's just browser detection rather than os detection :p
19:52:32 <TrueBrain> I know that we use to do the simply checks
19:52:35 <TrueBrain> and that we were often wrong
19:52:40 <TrueBrain> so we used a python lib to do it for us
19:52:43 <TrueBrain> never had an issue since :D
19:52:49 <TrueBrain> that is my only scare here
19:54:07 <TrueBrain> openttd/website:0.0.0-79-g6b6309d-20190104-1851
19:54:12 <TrueBrain> is there a limit on tag-length? :P
19:55:29 <TrueBrain> possibly we need to put that tag in the HTML, so we can see what is served :)
19:55:33 <TrueBrain> expectation vs reality :P
19:57:18 <TrueBrain> that is a bit weird ... added a shitton of downloads, and it didnt icnrease in size
19:57:28 <TrueBrain> compression much? :P
20:00:07 <Samu> I've been thinking through this and wonder if I need more functions other than what i've done already
20:00:15 <DorpsGek_II> [OpenTTD/OpenTTD] Gabda87 commented on issue #6887: Add layer showing boundaries for local authorities https://git.io/fhOyU
20:00:55 <Samu> Vehicle lists returning the unitnumber and a function that redirects unitnumber to the current vehicle index
20:00:59 <LordAro> TrueBrain: nice, the same size as an electron app :p
20:01:19 <Samu> i can build my own valuators
20:01:36 <Samu> dont need the api to have them
20:03:03 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #6887: Add layer showing boundaries for local authorities https://git.io/fhOyZ
20:16:35 <andythenorth> TrueBrain: just keep using the python lib, via XHR :P
20:16:36 <Borg> is acceleration model of railtype is actually used?
20:16:41 <andythenorth> 'over-engineered'
20:16:53 <Borg> because engine have traction type..
20:17:13 <andythenorth> borg AIUI it's used
20:17:26 <LordAro> TrueBrain: it occurs to me that there's going to have to be a way to update the website every time the downloads list changes, without any actual change to the website content. i assume you've accounted for that?
20:20:19 <andythenorth> as I understand it, sorry
20:20:44 <Borg> got an idea how to merge maglev and monorail :)
20:23:05 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6887: Add layer showing boundaries for local authorities https://git.io/fhO9q
20:24:13 <Borg> btw, what ID should I use for railtype ID when Im changing existing one? this is noet clearnly documented
20:28:58 <andythenorth> dunno, railtypes are a mystery :)
20:36:16 <Borg> okey, lets use 00 and see what happens
20:36:37 <peter1138> Pretty they are GRF-local only, it's the labels that matter.
20:38:54 <Borg> used 00 and its all right
20:39:02 <Borg> YAY... merging maglev -> monorail was easy
20:43:34 <Samu> wow, i've been an idiot all this time
20:44:17 <Samu> the functions I am making for the API could be made on the AI
20:45:05 <Samu> it just that it takes tons of turns to do the same job
21:08:53 <Gabda> andythenorth: what are function of patch packs here? they are optional to add to their own copy, ot these pathes will be included after a while to the game?
21:11:35 <andythenorth> Gabda: patch packs are just personal projects by the author
21:11:41 <andythenorth> they have no relation to official release
21:11:45 <andythenorth> but they are encouraged
21:13:53 <Gabda> and what happens when a patch, like the zoning patch you mentioned solves two issues (requests)?
21:14:29 <andythenorth> nielsm: I'm looking
21:14:32 <Borg> nielsm: not merged technically.. but moved Maglev engines to monorail.. and kept monorail engines too.. now its mixed.. monorail/maglev
21:15:34 <Samu> but at least I didn't need to change the API
21:17:17 <nielsm> andythenorth: I can confirm my graphics is getting included at least, I can browse to them in the sprite aligner
21:17:17 <andythenorth> oof FIRS code :P
21:18:00 <andythenorth> what's the 'default' prop in 'graphics'?
21:18:19 <nielsm> as far as I understand, the actual spriteset to use
21:18:51 <andythenorth> hmm it's some kind of optional nml keyword I think
21:18:55 <andythenorth> FIRS doesn't use it, but docs do
21:20:28 <nielsm> actually, maybe the issue is in the tilelayout
21:21:09 <DorpsGek_II> [OpenTTD/OpenTTD] Gabda87 commented on issue #6887: Add layer showing boundaries for local authorities https://git.io/fhO5A
21:21:48 <nielsm> because it seems like it might really be using one of the original industrytiles
21:22:21 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6887: Add layer showing boundaries for local authorities https://git.io/fhOde
21:23:23 <andythenorth> can't see anything wrong with your tilelayout
21:24:08 <andythenorth> nielsm: does it show the water even?
21:24:27 <andythenorth> can you get the tile IDs out of debug tools?
21:24:46 <Samu> i see some kind of light at the end of the tunnel for my AI :)
21:25:31 <andythenorth> nielsm: no debug tools? o_O
21:25:46 <nielsm> running a release build atm because it's faster :)
21:26:39 <andythenorth> newgrf dev tools could use some extension :)
21:26:46 <andythenorth> tile ID would be helpful
21:27:11 <andythenorth> hmm maybe var 62 will give it
21:27:38 <andythenorth> yes it does, if given the offset 0000
21:30:06 <nielsm> m5 = 0 for all the tiles, that's the coal mine tile
21:33:44 <nielsm> 0A \b1 \d68 introduces the tilelayout, which looks correct (the industrytile ids are nonzero)
21:37:18 <andythenorth> it will be something obvious we're overlooking :P
21:38:41 <andythenorth> nielsm: try setting override
21:39:24 <andythenorth> don't think it's relevant but eh
21:41:49 <andythenorth> the docs say don't use override, but FIRS does, dunno why
21:44:17 <andythenorth> nielsm: try moving the tile definition above the layout definition
21:44:36 <andythenorth> I can't remember nfo FIRS, but iirc order of declaration was significant
21:45:07 <andythenorth> not sure how nml handles that :P
21:45:34 <andythenorth> if this was just a typo, you'd have a syntax errror, right?
21:45:39 <andythenorth> and the correct grf is loaded? o_O
21:59:21 <TrueBrain> LordAro: that is why I added the ${DATE} to the tag, yes :)
21:59:40 <TrueBrain> LordAro: over time, downloads will be removed from website; for now it needs to be triggered every time a new download is added
21:59:54 <TrueBrain> its a rare event, so we should be fine :)
22:00:28 <andythenorth> nielsm: you won :P
22:00:38 <andythenorth> x and y switched? o_O
22:01:13 <nielsm> nope, I overrode the oilrig tile ids and used those original ids in the tilelayout instead
22:01:19 <TrueBrain> hmm .. self host Sentry, or use the limited cloud solution .. hmm
22:01:51 <nielsm> but yes I switched x and y in the layout ;)
22:04:18 <TrueBrain> oeh, you can apply for a free Sentry account if you are Open Source .. that might be a good idea
22:04:34 <andythenorth> as long as you don't want too many nodes :P
22:04:44 <andythenorth> oh no I'm thinking of Server Density
22:04:52 <andythenorth> confused andythenorth
22:05:10 <LordAro> TrueBrain: sentry for error collection?
22:05:29 <TrueBrain> LordAro: yes; mostly for the Python parts
22:05:34 <LordAro> are you expecting lots of errors? :p
22:05:42 <TrueBrain> no; but errors will be invisible now
22:05:49 <TrueBrain> so I want something that creates a ticket for any error that comes by
22:06:17 <TrueBrain> I rather have a ticket about an error, than a user telling me something doesnt work :)
22:06:50 <LordAro> now you can have both!
22:09:13 <andythenorth> so can haxors own me through openttd?
22:09:52 <andythenorth> hey, I got one of those 'I have video of you watching adult content, send me btc' emails today
22:09:56 <LordAro> i feel like some sort of fail2ban integrarion shouls be possible...
22:10:03 <andythenorth> never had one before
22:10:03 <LordAro> but as a separate script, ofc
22:10:06 <nielsm> ugh can't override indtile 0x18 to not accept passengers, without losing the magic oilrig station behavior
22:10:17 <andythenorth> 'you will see that I have sent this from your account, proving I have your password'
22:10:23 <LordAro> oilrigs are still very magic
22:10:27 <andythenorth> nielsm: you can't
22:10:33 <andythenorth> there was a simple patch to provide it
22:10:51 <andythenorth> but it fell into the hellchasm called newgrf airports about 8 years ago
22:10:56 <andythenorth> so it died of course
22:11:13 <andythenorth> nothing kills good ideas like newgrf airports :P
22:11:39 <LordAro> i thought that was ntrt?
22:11:54 <andythenorth> nah, NRT hasn't blocked other stuff
22:11:56 <andythenorth> 'your anti-virus can't stop me, I have installed this malware via the driver'
22:12:04 <nielsm> should have an indtile special flag for "creates dock" and "creates helipad"
22:12:22 <andythenorth> nielsm: yes, but then THAT PREVENTS NEWGRF AIRPORTS EVER, or something silly :)
22:12:28 <andythenorth> I have a screenshot
22:12:48 <TrueBrain> lol @ tt-forums post andythenorth .. "aware of this problem" .. which problem?
22:13:25 <LordAro> someone had their password set to password, probably
22:13:39 <TrueBrain> or did the server got hacked? which runs OpenTTD? :P
22:13:56 <TrueBrain> right, requested access for an Open Source sentry account
22:14:13 <glx> maybe just company auto clean removed the password
22:14:47 <TrueBrain> the logs allow that option, yes
22:14:55 <TrueBrain> the logs just show someone that connects, and starts to play
22:15:08 <TrueBrain> maybe someone should ask nicely what the fuck he is on about :P
22:16:06 <andythenorth> I am all out of nice today
22:16:17 <LordAro> TrueBrain: but you're so good at it :p
22:16:59 <TrueBrain> I do the polite shit on GitHub, you can do it on tt-forums, okay? :)
22:17:14 <andythenorth> I did it on Flyspray
22:17:17 <andythenorth> in 500 tickets :P
22:17:25 <TrueBrain> so tag, LordAro is it
22:17:32 <andythenorth> just wait for Eddi|zuHause to do it
22:17:36 <andythenorth> Eddi|zuHause is good at it
22:17:47 <TrueBrain> the same way an axe is good in chopping wood, I assume
22:18:10 <andythenorth> eddi is unfailingly polite, but technically accurae
22:19:19 <andythenorth> there is a screaming difference
22:19:30 <andythenorth> the drop shadow doesn't use as many images
22:19:42 <TrueBrain> the bottom is different too
22:19:49 <TrueBrain> but .. that is fine
22:19:55 <TrueBrain> LordAro is going to fix it all anyway, he promised
22:19:58 <andythenorth> I changed it deliberatlely
22:20:11 <TrueBrain> we should cleanup the Developers list soon
22:20:20 <TrueBrain> if no activity for N years, remove from list
22:20:38 <TrueBrain> ludde is not on that list
22:20:57 <LordAro> oh, that developers list
22:21:32 <LordAro> i was thinking of the ingame/readme/wiki developers list
22:21:43 <TrueBrain> ah; yeah, we should just update there who is retired :)
22:22:03 <nielsm> I wrote a reply to that supposed vuln
22:22:18 <LordAro> retired/mia, same diff
22:22:57 <TrueBrain> LordAro: yup .. we have some MIAs ...
22:23:04 <TrueBrain> of some I still wonder what happened :P
22:23:22 <LordAro> Yexo went to google, i think pm said?
22:23:37 <TrueBrain> so people said, yes
22:23:44 <LordAro> adf had some polish weirdness happen
22:24:05 <LordAro> that's as detailed as i can get :p
22:24:16 <DorpsGek> LordAro: Belugas was last seen in #openttd 1 year, 39 weeks, 6 days, 1 hour, 5 minutes, and 44 seconds ago: <Belugas> yeah, a birthday :) a good friend of mine!
22:24:23 <TrueBrain> Terkhen is still idling here .. but I guess it is safe to remove him from the list :)
22:24:35 <DorpsGek> TrueBrain: Zuu was last seen in #openttd 1 week, 1 day, 20 hours, 13 minutes, and 51 seconds ago: <Zuu> So any data that is slow to determine for saving has to be pre-cached already before Save() is called. Load is easier, just save the data to this._save and handle it in Start() and you are good.
22:24:51 <LordAro> zuu's inactive at most
22:25:03 <DorpsGek> LordAro: Terkhen was last seen in #openttd 2 years, 47 weeks, 5 days, 2 hours, 48 minutes, and 7 seconds ago: <Terkhen> Hello
22:25:10 <TrueBrain> Rubidium isnt even on IRC anymore? :o
22:25:24 <TrueBrain> owh, he is, just not here :P
22:25:27 <TrueBrain> cannot blame him :D
22:25:29 <LordAro> when did that happen?
22:25:54 <DorpsGek> LordAro: Rubidium was last seen in #openttd 22 weeks, 6 days, 12 hours, 22 minutes, and 10 seconds ago: <Rubidium> peter1138: but then the 4-5 day shipping holds, right? Friday, Saturday, Sunday and finally arriving on Monday; I count 4 days of shipping ;)
22:26:37 <TrueBrain> I think mostly that list should be people who can be contacted
22:26:45 <TrueBrain> I dont care if they have commit-rights etc
22:27:00 <TrueBrain> but at least that list should somewhat give names which you can poke for certain stuff
22:27:07 <andythenorth> yeah yexo is apparently a google SRE in Munich
22:27:50 <andythenorth> time for a clean up then TB
22:28:07 <TrueBrain> yeah .. but first I am going to work towards getting it production-ready :P
22:30:00 <andythenorth> alpha 2 maybe :P
22:44:07 <nielsm> andythenorth: painting or deleting? :)
22:44:33 <andythenorth> urgh, I was about to ship an alpha using a var that doesn't exist
22:45:55 <andythenorth> kittens would have died
22:47:38 <TrueBrain> guess it is a good thing we only care about frogs
22:47:49 <andythenorth> oh I was better than I thought
22:47:57 <andythenorth> I'd already fixed that :P
22:49:30 <TrueBrain> we always knew you were awesome
22:49:43 <TrueBrain> too bad it took this long to shine; but better late than never!
22:50:45 <andythenorth> been hiding my ligth
22:58:06 <andythenorth> oops, I broke Jenkins
22:58:13 <andythenorth> jenkins doesn't have 'time'
23:04:20 <TrueBrain> we all have to make due
23:05:00 *** Wacko1976 has joined #openttd
23:12:29 <nielsm> okay I think there is a bug with newgrf handling of industry tiles
23:12:41 <nielsm> that don't have an override property set
23:14:21 <nielsm> INVALID_INDUSTRYTILE is 0x1FF
23:15:35 <nielsm> but the way the IndustryTileOverrideManager is implemented in newgrf_commons.(h|cpp) the override value is a byte, so the default of "not overridden" is not possible
23:16:17 <nielsm> as far as I can tell this means it's impossible to actually define a new and usable industrytile, you have to re-purpose an existing tile
23:17:34 <nielsm> okay the global instance _industile_mngr does get initialized with an invalidID=INVALID_INDUSTRYTILE
23:17:50 <nielsm> but I'm not sure I follow the conditions for the invalidID to actually get used
23:18:02 <andythenorth> all of the FIRS tiles use substitute
23:18:30 <andythenorth> but FIRS industry uses both substitute and over-ride, which I'm not sure why, might just be error
23:19:07 <nielsm> hmm FIRS tiles only substitute, never override?
23:24:39 <andythenorth> I don't know what nml is doing
23:27:06 <andythenorth> casual check suggests nml is doing prop 0x08 and 0x09 correctly
23:27:28 <nielsm> I've checked the generated NFO and it looks fine
23:42:50 <nielsm> well that was a wild chase
23:43:02 <nielsm> when the reason was indeed definition order in nml
23:43:15 <nielsm> the industry defined before the tiles
23:43:35 <nielsm> so when the tilelayout is read from the grf it refers to tiles that don't exist yet
23:43:49 <nielsm> moving the industry def below the tile defs makes it work
23:44:19 <andythenorth> feel like I could have saved you some time there, sorry :P
23:45:59 <nielsm> on the positive side, I learned some more about how grf loading happens :D
23:46:43 <DorpsGek_II> [OpenTTD/OpenTTD] slhurst opened issue #7011: Towns don't grow if first tile of station is outside authority area https://git.io/fh3Jg
23:47:40 <nielsm> and that also got me a bunch more indtiles fixed :)
23:48:15 *** andythenorth has left #openttd
23:51:57 *** NoMorePacers_ has joined #openttd
23:53:55 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on issue #7011: Towns don't grow if first tile of station is outside authority area https://git.io/fh3Jj
continue to next day ⏵
