IRC logs for #openttd on OFTC at 2018-10-11
            
00:32:40 *** Thedarkb-T60 has quit IRC
00:33:00 *** Thedarkb has quit IRC
00:35:29 *** GroovyNoodle has joined #openttd
00:43:05 *** Thedarkb-T60 has joined #openttd
01:02:54 *** ToBeFree has joined #openttd
01:04:35 <DorpsGek_II> [OpenTTD/OpenTTD] MiguelHorta opened pull request #6936: Fix #6898: Replace atoi() with strtoul() https://git.io/fxWPM
01:17:15 <DorpsGek_II> [OpenTTD/OpenTTD] MiguelHorta updated pull request #6936: Fix #6898: Replace atoi() with strtoul() https://git.io/fxWPM
01:19:17 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #6936: Fix #6898: Replace atoi() with strtoul() https://git.io/fxWXw
01:33:46 *** Oroburos has joined #openttd
01:34:38 <DorpsGek_II> [OpenTTD/OpenTTD] MiguelHorta dismissed a review for pull request #6936: Fix #6898: Replace atoi() with strtoul() https://git.io/fxWXw
01:34:39 <DorpsGek_II> [OpenTTD/OpenTTD] MiguelHorta updated pull request #6936: Fix #6898: Replace atoi() with strtoul() https://git.io/fxWPM
01:35:42 <Eddi|zuHause> wtf does "dismiss a review" mean?
01:37:14 <LordAro> invalidated
01:37:27 <LordAro> usually
01:37:35 <LordAro> it's github's terminology
01:38:03 <DorpsGek_II> [OpenTTD/OpenTTD] MiguelHorta commented on pull request #6936: Fix #6898: Replace atoi() with strtoul() https://git.io/fxW1x
01:38:34 <Eddi|zuHause> but if it's an automatic thing when updating a pull request, it's maybe a bit over the top to announce it like that
01:38:34 * LordAro wonders about error handling...
01:38:47 <LordAro> yeah, probably
01:39:02 <LordAro> i should sleep
01:39:25 <Eddi|zuHause> whenever i say that, it's guaranteed that i'm still here in 3 hours
01:44:57 <iSoSyS> oh snap :/ My whole embarrassing journey to github's pull requests is logged here. At least I got it right in the end. I think :D
01:46:38 *** rocky11384497 has quit IRC
01:56:07 *** iSoSyS has quit IRC
02:02:52 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick opened pull request #6937: Fix #4109: Add more water checks to the Oil Rig layout https://git.io/fxWDM
02:19:39 *** Flygon has joined #openttd
02:21:37 *** GroovyNoodle has quit IRC
02:24:39 *** Wormnest has quit IRC
02:37:31 *** Samu has quit IRC
02:39:25 *** Thedarkb-T60 has quit IRC
03:08:11 *** glx has quit IRC
03:08:19 *** APTX_ has joined #openttd
03:08:26 *** APTX| has quit IRC
03:18:01 *** Oroburos has quit IRC
03:20:49 *** WWacko1976-work has joined #openttd
03:38:27 *** peter1138 has quit IRC
03:38:34 *** peter1138 has joined #openttd
03:38:34 *** ChanServ sets mode: +o peter1138
03:52:35 *** triolus has quit IRC
03:55:09 *** sim-al2 has joined #openttd
03:57:40 *** triolus has joined #openttd
05:36:40 *** haudrauf has quit IRC
05:37:39 *** haudrauf has joined #openttd
06:19:14 *** ToBeFree has joined #openttd
07:03:20 *** ToBeFree has quit IRC
07:03:38 *** ToBeFree has joined #openttd
07:33:24 *** sla_ro|master has joined #openttd
07:34:46 *** andythenorth has joined #openttd
07:39:44 *** FLHerne has quit IRC
07:40:18 *** FLHerne has joined #openttd
07:44:33 <andythenorth> moin
07:48:19 *** sla_ro|master2 has joined #openttd
07:54:39 *** sla_ro|master has quit IRC
08:01:30 *** sla_ro|master2 has quit IRC
08:21:16 *** andythenorth has quit IRC
08:22:47 *** Gustavo6046 has quit IRC
08:58:23 <LordAro> o/
09:32:52 *** Samu has joined #openttd
10:10:47 *** andythenorth has joined #openttd
10:15:08 *** ChanServ sets mode: +o orudge
11:17:06 *** matt21347 has joined #openttd
11:20:39 *** tokai has joined #openttd
11:20:39 *** ChanServ sets mode: +v tokai
12:11:53 <DorpsGek_II> [OpenTTD/OpenTTD] James103 opened issue #6938: Incorrect value for "Cost to Clear" for Company Headquarters in tile inspector https://git.io/fxlnU
12:16:00 *** GroovyNoodle has joined #openttd
12:26:01 *** andythenorth has quit IRC
12:41:01 *** andythenorth has joined #openttd
12:53:57 *** andythenorth has quit IRC
13:20:21 *** andythenorth has joined #openttd
14:34:34 <DorpsGek_II> [OpenTTD/OpenTTD] MiguelHorta commented on issue #6938: Incorrect value for "Cost to Clear" for Company Headquarters in tile inspector https://git.io/fxluN
14:59:39 *** snail_UES_ has joined #openttd
15:06:12 *** sim-al2 has quit IRC
15:15:49 *** snail_UES_ has quit IRC
15:58:19 *** nielsm has joined #openttd
16:25:26 *** sla_ro|master has joined #openttd
16:32:27 *** Wormnest has joined #openttd
16:33:05 *** Gustavo6046 has joined #openttd
16:48:05 *** Alberth has joined #openttd
16:48:05 *** ChanServ sets mode: +o Alberth
16:48:13 <Alberth> o/
17:12:42 *** wodencafe has quit IRC
17:21:33 *** Thedarkb has joined #openttd
17:27:31 *** Alberth has left #openttd
17:33:45 *** TheMask96 has quit IRC
17:35:38 *** TheMask96 has joined #openttd
17:37:20 *** Gja has joined #openttd
17:40:46 *** Flygon has quit IRC
17:51:18 *** Thedarkb has quit IRC
17:57:47 *** Thedarkb has joined #openttd
18:04:08 *** HerzogDeXtEr has joined #openttd
18:16:16 <Samu> hi
18:16:36 <Xaroth> o7
18:16:49 <Samu> Xaroth?
18:16:59 <Xaroth> hm?
18:17:01 <Samu> my cat name is Xarick
18:17:21 <Xaroth> So you named your cat after me? how nice.
18:19:24 <Samu> i have 3 cats now, 2 died this year :(
18:19:55 <Xaroth> :(
18:21:49 <Samu> tintim died to a tumour in his brain
18:22:20 <Samu> oh well why do I talk about these things...
18:22:23 <Samu> sorry
18:26:17 *** andythenorth has quit IRC
18:44:23 <Samu> i have a few more patches here, but I bet there's a 99.99% chance they won't be implemented
18:45:43 <Samu> generate lock-friendly rivers
18:46:51 <Samu> distribute cargo to multiple stations or industries
18:47:06 <Samu> allow attaching multiple train engines
18:47:12 <Samu> allow company level crossings
18:47:20 <Samu> allow large aeroplane on short runway
18:47:43 <Samu> Bridge Over Lock - this one needs a graphic expert
18:47:53 <Samu> build on competitor canal
18:48:42 <Samu> disallow multiplayer ai company takeover - this goes against the TODO comments
18:49:38 <Samu> no wait cursor when autosaving
18:49:44 <Samu> pause running costs on standard road stops
18:50:19 <Samu> save empty script
18:50:36 <Samu> town bridge over rail
18:50:48 <Samu> unlimited destination distance for YAPF ships
18:51:33 <Samu> no plane crashes, unless runway is too short option
18:52:21 *** andythenorth has joined #openttd
18:52:31 <Samu> cargomonitor industry delivery fix - but I was told it's not a bug
18:55:02 *** andythenorth has quit IRC
19:00:37 *** andythenorth has joined #openttd
19:09:56 *** frosch123 has joined #openttd
19:20:19 *** andythenorth has joined #openttd
19:25:30 <andythenorth> well
19:26:00 <LordAro> yes
19:28:00 <andythenorth> is cat?
19:30:03 <LordAro> no, is lizard
19:30:54 *** haudrauf has quit IRC
19:31:18 <andythenorth> is horse?
19:31:19 <andythenorth> 77%
19:31:31 <andythenorth> it's fun, but I am temporarily tired of it :P
19:31:33 <andythenorth> has been a grind
19:31:37 <LordAro> that's nearly 78%!
19:31:44 <andythenorth> 167 trains drawn
19:31:49 <andythenorth> 48 to draw
19:35:04 *** haudrauf has joined #openttd
19:36:05 *** Progman has joined #openttd
19:49:59 *** Gja has quit IRC
19:52:41 *** Gja has joined #openttd
20:11:29 *** Thedarkb has quit IRC
20:18:06 *** Thedarkb has joined #openttd
20:25:34 *** Wolf01 has joined #openttd
20:25:43 <Wolf01> o/
20:25:59 *** Oroburos has joined #openttd
20:26:43 *** Oroburos has joined #openttd
20:40:28 <andythenorth> yo
20:41:52 *** Gja has quit IRC
20:53:49 *** glx has joined #openttd
20:53:49 *** ChanServ sets mode: +v glx
21:05:11 *** Gja has joined #openttd
21:05:33 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #6936: Fix #6898: Replace atoi() with strtoul() https://git.io/fx8ta
21:09:30 *** matt21347 has quit IRC
21:12:37 *** Wormnest has quit IRC
21:13:00 *** Oroburos has quit IRC
21:22:34 <DorpsGek_II> [OpenTTD/OpenTTD] orudge merged pull request #6936: Fix #6898: Replace atoi() with strtoul() https://git.io/fxWPM
21:22:38 <DorpsGek_II> [OpenTTD/OpenTTD] orudge closed issue #6898: Seeds above 32bit max int. https://git.io/fx8q9
21:23:08 <LordAro> osht, an orudge merge
21:23:47 * orudge rebases LordAro
21:24:04 <LordAro> :o
21:41:36 *** frosch123 has quit IRC
21:48:11 *** Wacko1976 has joined #openttd
21:48:25 *** sla_ro|master has quit IRC
21:51:21 *** rocky11384497 has joined #openttd
21:54:21 *** iSoSyS has joined #openttd
22:02:18 *** haudrauf has quit IRC
22:03:24 *** haudrauf has joined #openttd
22:28:42 *** matt21347 has joined #openttd
22:29:04 *** nielsm has quit IRC
22:32:07 <iSoSyS> has anyone tried to reproduce #6938? In my work's laptop I'm pretty sure I got the same result, but in my home pc I can't anymore, it just display N/A.
22:35:26 <LordAro> can't reproduce with just a basic AI test
22:35:32 <LordAro> would probably need a save game
22:37:01 <LordAro> i didn't see anything obvious when looking through the code earlier
22:37:11 <orudge> I can reproduce it if I enable the magic bulldozer cheat
22:38:05 <LordAro> no luck here...
22:38:57 <orudge> (this is with OpenTTD 1.8.0)
22:39:29 <LordAro> ah, bingo
22:39:44 <LordAro> i was trying with the AI company's HQs
22:39:58 <LordAro> yeah, magic bulldozer + your own HQ
22:40:51 <iSoSyS> can confirm. Magic bulldozer does the trick. Although, I'm pretty sure I didn't use it before. I need to check it tomorrow.
22:41:19 * LordAro wonders how magic bulldozer affects it
22:42:31 <orudge> It looks like the explanation in the bug is correct - the magic bulldozer must calculate 10% of the company value
22:42:42 <orudge> since money is temporarily sent to INT64_MAX, 10% of that is the £9 whateverillion in question
22:42:53 <orudge> (well, 10% of the company value, which is now grossly inflated)
22:43:46 <LordAro> object_cmd.cpp:498 i think
22:52:08 *** andythenorth has quit IRC
22:57:41 *** Thedarkb-T60 has joined #openttd
22:59:46 <LordAro> now that's interesting, at the end of CalculateCompanyValue, it seems to think that my company has INT64_MAX money
23:00:00 <LordAro> (c->money attribute, not even a function)
23:01:02 *** Progman has quit IRC
23:01:20 <iSoSyS> because it has. Look at misc_gui.cpp:197
23:01:34 <iSoSyS> it is in the ticket, 1st comment.
23:01:52 <LordAro> oh
23:02:25 <LordAro> yeah, that'd do it
23:17:01 <Wolf01> 'night
23:17:03 *** Wolf01 has quit IRC
23:18:49 *** GroovyNoodle has quit IRC
23:19:55 <LordAro> iSoSyS: i found https://github.com/OpenTTD/OpenTTD/blame/26e9b5ca5f0eafae421a640ea4e4753d6ac7ec0e/src/misc_gui.cpp#L105-L110
23:21:36 <iSoSyS> yeah that's how far I can go. But I'm yet to figure why such strategy, DC_QUERY_COST was thing back then.
23:22:09 <LordAro> yeah, seems so
23:22:18 <LordAro> hell, it could be an TTD bug :p
23:22:31 <LordAro> well, sorta
23:22:36 <LordAro> TTD didn't have cheats
23:22:37 <iSoSyS> that would be a hell of a find :D
23:23:43 <LordAro> if you could hack TTD to allow removal of your own HQ, it's possible this bug might appear
23:23:46 <LordAro> :p
23:24:29 <LordAro> https://www.tt-forums.net/openttd/ hmm...
23:24:32 <LordAro> i want to go digging now...
23:26:12 <iSoSyS> ok! 0.1 already had such entry
23:26:19 <iSoSyS> we need to go deeper
23:26:47 <LordAro> it also appears in the cvs repo
23:26:52 <LordAro> so yeah, maybe! :D
23:28:53 *** Thedarkb has quit IRC
23:34:13 *** Wacko1976 has quit IRC
23:35:12 <LordAro> iSoSyS: but yeah, go for it, i'd say :)
23:35:28 <LordAro> you can even put a Fix (r1) in the commit message :)
23:37:38 <iSoSyS> too bad I can't process x86 assembly. It shouldn't be too hard to find a 0x7FFFFFFF in 16bit x86
23:37:58 <LordAro> shouldn't be too hard to find that in a hexdump...
23:38:13 <LordAro> objdump should get you most of the way
23:38:22 <LordAro> i think it can do 16bit binaries...
23:41:28 *** Thedarkb-T60 has quit IRC
23:41:36 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #6938: Incorrect value for "Cost to Clear" for Company Headquarters in tile inspector https://git.io/fx885
23:41:44 <LordAro> damn these hilights
23:41:50 <LordAro> "ooh, someone said something to me"
23:41:54 <LordAro> "oh, yes, i just commented"
23:44:44 *** HerzogDeXtEr has quit IRC
23:55:08 <iSoSyS> well, no luck. Either 7fffffff is load with two instruction. Or it is a zero negated and shifted somewhere, or some weird shit. Hand written assembly is bound to have little tricks :|
23:55:18 *** Thedarkb-T60 has joined #openttd
23:55:33 <Samu> @calc 0x7fffffff
23:55:33 <DorpsGek> Samu: 2147483647
23:55:47 <LordAro> @calc 0x7fffffffffffffff
23:55:47 <DorpsGek> LordAro: 9223372036854775808
23:57:06 <iSoSyS> yeah, somewhere along the way we allowed the rich to be much much richer :D
23:58:07 <LordAro> iirc being able to overflow your money in TTD was a well known issue
23:58:50 <DorpsGek_II> [OpenTTD/OpenTTD] MiguelHorta commented on issue #6938: Incorrect value for "Cost to Clear" for Company Headquarters in tile inspector https://git.io/fx8Bm