IRC logs for #openttd on OFTC at 2017-11-14
⏴ go to previous day
00:38:49 *** samgunner has joined #openttd
00:47:13 *** ToffeeYogurtPots has quit IRC
00:47:31 *** ToffeeYogurtPots has joined #openttd
00:49:19 *** ToffeeYogurtPots has quit IRC
01:25:11 *** orudge` has joined #openttd
01:25:11 *** ChanServ sets mode: +o orudge`
02:35:08 *** sim-al2 has joined #openttd
03:46:41 *** Thedarkb1 has joined #openttd
04:13:43 *** Boggerm has joined #openttd
04:22:40 *** sim-al2 is now known as Guest496
04:22:42 *** sim-al2 has joined #openttd
04:33:22 *** orudge` has joined #openttd
04:33:22 *** ChanServ sets mode: +o orudge`
04:45:52 *** orudge` has joined #openttd
04:45:52 *** ChanServ sets mode: +o orudge`
07:05:28 *** sla_ro|master has joined #openttd
07:56:58 *** tokai|noir has joined #openttd
07:56:58 *** ChanServ sets mode: +v tokai|noir
08:35:52 *** Breckett has joined #openttd
08:39:03 *** Laedek_ has joined #openttd
09:29:54 *** Breckett has joined #openttd
10:21:22 <Samu> "go to the nearest hangar" orders are causing "dest too far" problems for aircraft with range
11:43:50 <Samu> when insering a "service at near depot", it puts destination 0 :(
11:47:49 <Samu> gonna try INVALID_STATION
12:04:04 <Samu> seriously, aircraft range is one of those poorly thought features
12:05:12 <Samu> aircraft is out of range, skip to a reachable dest, then skip back to the same out of range dest -> now it's not out of range and flies to it
12:27:37 *** sim-al2 has joined #openttd
12:29:19 *** ToffeeYogurtPots has joined #openttd
12:37:10 *** ToffeeYogurtPots has quit IRC
12:54:02 *** stefino has joined #openttd
13:10:23 *** Breckett_ has joined #openttd
13:30:33 *** ToffeeYogurtPots has joined #openttd
14:03:01 *** Breckett has joined #openttd
14:32:17 *** FLHerne has joined #openttd
14:51:44 *** Thedarkb1 has joined #openttd
15:05:32 *** sla_ro|master has joined #openttd
15:20:02 *** Gustavo6046 has joined #openttd
16:01:52 *** Alberth has joined #openttd
16:01:52 *** ChanServ sets mode: +o Alberth
16:32:51 *** samgunner has joined #openttd
16:52:15 <Samu> i have a problem related to aircraft range
16:52:45 <Alberth> use an aircraft with unlimited range, and gone is your problem
17:04:14 *** ToffeeYogurtPots has quit IRC
17:06:19 *** synchris has joined #openttd
17:06:28 <Samu> FindNearestHangar has a problem with range, and i'm unsure what can be done about
17:07:06 <Samu> Check if our current destination can be reached from the depot airport.
17:07:28 <Samu> current destination is ambiguous
17:07:46 <Samu> sometimes it's the airport the plane is at, sometimes it's the airport at the next destination
17:08:17 <Alberth> why would the current destination need to be reachable?
17:08:28 <Samu> because aircraft has range
17:08:54 <Samu> if the depot is reachable, but then it can't reach next destination... it won't get out after being serviced
17:09:01 <Alberth> you can obviously always fly back to where you are coming from and then go to the destination
17:10:19 <Alberth> if that is too complicated then indeed, check before accepting a hangar as destination
17:11:10 <Samu> the problem is: next destination isn't always the next airport, but the one he's at
17:11:41 <Samu> in this situation, it will be prone to be stuck inside depot with dest too far
17:12:34 <Samu> next destination isn't updated the way it should be
17:14:16 <Alberth> so first compute the true next destination?
17:14:48 <Samu> i'm trying to figure out how
17:15:52 <Samu> needs to know where he's at, the current station and the next one
17:16:35 <Alberth> I would go for where it is, and the next destination
17:16:48 <Samu> vtile tells me where the aircraft is atm
17:16:53 <Alberth> if both are the same, you must get the next next destination
17:16:59 <Samu> TileIndex vtile = TileVirtXY(v->x_pos, v->y_pos);
17:17:31 <Samu> yeah, unsure how am I detecting that
17:17:34 <Alberth> airport has no collection of tiles in some way?
17:18:16 <Alberth> ok, maybe some form of size then?
17:19:06 <Alberth> could be tricky if the aircraft is flying over an airport :p
17:20:50 <Samu> there's airport 0, 1 and 2
17:20:54 <Samu> only airport 0 has depot
17:21:12 <Samu> aircraft has just landed on airport 2
17:21:17 <Samu> now it checks for servicing
17:21:44 <Samu> airport 2 has no hangar, so it calls findsnearesthangar
17:22:56 <Samu> oh, right, forgot, aircraft is going from airport 1 to airport 2, important
17:23:21 <Samu> GetTargetAirportIfValid(v) is called for *cur_dest
17:23:32 <Samu> and the airport it comes up with is airport 2
17:23:44 <Samu> it should have been airport 1, which is the next in the orders
17:24:03 <Alberth> probably not until it has loaded/unloaded cargo
17:24:23 <Alberth> at which point the journey it is doing has been completed
17:24:25 <Samu> it is already doing the checkservcing
17:25:34 <Alberth> but sure, trains check for depots quite arbitrarily too
17:25:37 <Samu> i'm gonna try this with clean trunk
17:25:56 <Alberth> why is an aircraft a problem?
17:27:23 <Samu> the targetairport is only updated when the aircraft finishes helitakeoff
17:28:40 <Samu> when helicopter is raising up, and the check for servicing is called, and it needs to find a nearest hangar... it gets the wrong airport
17:30:42 <Alberth> aircraft and helitakeoff, that's confusing
17:31:32 <Samu> crap, i forgot an important order, the 3rd order was "service at nearest hangar"
17:32:32 <Samu> "service at nearest hangar" for some reason, uses StationID 0
17:33:19 <Alberth> and 0 triggers a search?
17:34:40 <Samu> order.MakeGoToDepot(0, ODTFB_PART_OF_ORDERS, _settings_client.gui.new_nonstop && this->vehicle->IsGroundVehicle() ? ONSF_NO_STOP_AT_INTERMEDIATE_STATIONS : ONSF_STOP_EVERYWHERE);
17:34:40 <Alberth> makes sense, as it's the only airport with a depot :p
17:35:07 <Samu> ...GoToDepot(0, ... this 0
17:35:45 <Samu> coincidence, 0 has hangar indeed
17:37:47 <Alberth> actually, it's a DepotID and not an airport id
17:38:02 <Alberth> unless these are linked
17:38:29 <Alberth> probably not, as that would break trains
17:38:48 <Samu> they are somewhat linked, airport hangars are belong to station tiles
17:40:08 <Alberth> /* Aircraft have StationIDs for depot orders and never use DepotIDs <-- ah, indeed
17:40:29 <Samu> okay, so the current order is "service at nearest hangar", right after landing, findnearest calls const Station *cur_dest = GetTargetAirportIfValid(v);
17:40:52 <Samu> it does Station *st = Station::GetIfValid(v->targetairport);
17:41:21 <Samu> v->targetairport is 0, per "service at nearest hangar", let's see
17:42:00 <Samu> damn, what the heck am i reporting then?
17:42:21 <Samu> because that's the next destination
17:42:43 <Alberth> if a train goes from station A to B
17:42:47 *** Progman has joined #openttd
17:43:15 <Alberth> and on the way to B it looks for depot, and finds depot X
17:43:32 <Alberth> it should still go to B after service right?
17:44:13 <Samu> this aircraft is doing a "service at nearest hangar"
17:44:20 <Alberth> it is heading for the passenger terminal at 2, it should continue to go there after service
17:44:48 <Alberth> why does it land on 2 then?
17:45:18 <Alberth> I mean, there is no hangar there
17:45:29 <Samu> order 1: go to airport 1
17:45:33 <Samu> order 2: go to airport 2
17:45:45 <Samu> order 3: service at nearesh hangar
17:45:52 <Samu> that hangar is at airport 0
17:46:11 <Samu> it's now executing order 3
17:46:28 <Alberth> it has loaded and unloaded already?
17:46:53 <Samu> it landed, unloaded and loaded, and now is executing order 3
17:47:16 <Samu> target airport brrings up airport 2, it should be 1, should it not?
17:47:28 <Samu> that's the next destination in the order
17:48:36 *** TheMask96 has joined #openttd
17:49:27 <Samu> about distances between airports, airport 1 and airport 2 are within aircraft range
17:49:42 <Samu> airport 1 and airport 0 are also within aircraft range
17:49:48 <Samu> airport 2 and airport 0 are not
17:50:41 <Samu> basically, airport 1 is in the middle of airport 0 and 2
17:52:54 <Samu> distance from aircraft to the iterated hangar (airport 0) is outside aircraft range
17:54:17 <Samu> DistanceSquare(st->airport.tile, cur_dest->airport.tile)
17:54:44 <Samu> distance from airport 0 to airport 2 > aircraft range, true
17:56:05 <Samu> v->IncrementRealOrderIndex();
17:56:17 <Samu> skips order 3, goes back to order 1
17:56:58 <Samu> then what was wrong, why did i ever bring this up :(
17:57:22 <Alberth> wrong scenario perhaps?
17:57:45 <Samu> gonna try service at nearest hangar before order 2
17:58:06 <Samu> order 1: go to airport 1
17:58:17 <Samu> order 2: service at nearest hangar
17:58:21 <Samu> order 3: go to airport 2
17:58:41 <Alberth> would probably skip order 3?
17:59:56 <Samu> helicopter landed at airport 1, loaded, unloaded, and now is starting order 2
18:00:20 <Samu> distance from airport 0 to airport 1 > aircraft range, false
18:00:46 <Samu> it flying to service at hangar 1
18:01:31 <Samu> too far to next destination, can't exit hangar
18:02:09 <Samu> is trying to execute order 3
18:03:16 <Samu> it should have checked distance from airport 0 to airport 2 > aircraft range
18:04:08 <Samu> r27930, with no M, clean trunk
18:04:18 <Samu> this was what I wanted to report
18:07:40 <Samu> must think how to solve this
18:08:33 <Samu> the problem is only for orders of type go to nearest hangar/service at nearest hangar
18:09:01 <Samu> i wonder how conditional orders work
18:10:15 <Samu> strange, i can't skip order
18:10:33 <Samu> still too far even when trying to go to airport 1, from airport 0
18:11:06 *** Thedarkb1 has joined #openttd
18:11:48 <Samu> now this is a real bug, aircraft is unresponsive
18:12:04 <Samu> stuck with "too far to near destination" without any orders atm
18:19:18 <Samu> bah game was paused, i'm stupid, sorry
18:19:44 <Alberth> working as intended thus :)
18:21:40 <Alberth> nah, I make such stupid mistakes all the time :)
18:22:01 <Alberth> as long as you realize what's happening afterwards :)
18:52:42 *** Thedarkb1 has joined #openttd
18:59:23 *** HerzogDeXtEr has joined #openttd
19:02:26 *** frosch123 has joined #openttd
19:07:21 *** chomwitt has joined #openttd
19:09:49 *** Wormnest has joined #openttd
19:27:28 *** Breckett has joined #openttd
19:40:35 *** Stimrol has joined #openttd
19:53:10 *** ToffeeYogurtPots has joined #openttd
20:19:31 *** andythenorth has joined #openttd
20:36:33 *** glx is now known as Guest537
20:50:33 *** Stimrol has joined #openttd
21:08:17 <Samu> const Station *next_station = v->current_order.IsType(OT_GOTO_STATION) || v->current_order.IsType(OT_GOTO_DEPOT) && v->current_order.GetDepotActionType() != ODATFB_NEAREST_DEPOT? Station::GetIfValid(v->current_order.GetDestination()) == cur_dest ? Station::GetIfValid(v->GetLastOrder()->GetDestination()) : Station::GetIfValid(v->current_order.GetDestination()) : Station::GetIfValid(v->GetNextStoppingStation().value);
21:24:37 *** ToffeeYogurtPots has quit IRC
21:35:05 *** ToffeeYogurtPots has joined #openttd
21:49:11 <Wolf01> Why don't you concatenate the entire source in one line?
21:53:12 *** ToffeeYogurtPots has quit IRC
21:56:43 <frosch123> [21:49] <Wolf01> Why don't you concatenate the entire source in one line? <- i found all fs bugs, they are caused by line 1
21:57:26 <Eddi|zuHause> what am i gonna do with this late medieval earth that has non-sentient birds on it?
21:58:28 <frosch123> he had too many senile birds
21:59:59 <Eddi|zuHause> not earth... Sol III
22:00:57 <frosch123> doesn't sound like moo2, so probably stellaris
22:01:30 <Eddi|zuHause> in my last game i had a Sol III that was a dead world, inhabited by non-sentient cockroaches
22:01:32 *** Arveen2 has joined #openttd
22:02:22 <frosch123> are they better than sentient cockroaches?
22:04:04 <Eddi|zuHause> well, you can uplift them and find out :p
22:11:53 <Wolf01> You are teasing me to play spore again
22:13:17 <V453000> haven't heard about that since all the hype when it came out and disappointed the shit out of me
22:18:02 <Wolf01> I liked a bit less the last part when you had to gather the spice and bring it to the other side of the galaxy with a really limited cargo bay
22:21:17 <Wolf01> Some kind of automated commercial routes which give you a cut of the profits would have been a lot better
22:23:35 <supermop_> did anyone play ascendancy?
22:25:28 <Wolf01> That one like master of orion?
22:30:05 <supermop_> maybe? it was from the early 90s
22:30:14 <supermop_> sort of turn-ish based
22:30:22 <supermop_> it incremented in 'days'
22:31:12 <supermop_> when nothing was happening you'd fly through 10s of thousands of days
22:31:30 <supermop_> until the next breakthrough, or arrival in another star system
22:37:26 <Wolf01> Just like civilization
22:41:49 *** Thedarkb1 has joined #openttd
23:30:57 *** samgunner has joined #openttd
23:32:16 *** samgunner has joined #openttd
23:32:47 *** samgunner has joined #openttd
23:55:42 *** Gustavo6046 has joined #openttd
23:57:24 *** Thedarkb1 has joined #openttd
continue to next day ⏵