IRC logs for #openttd on OFTC at 2016-10-09
⏴ go to previous day
00:00:32 <Samu> timetable translation is too confusing without watching the final result
00:05:30 <Samu> YESH! 0 strings missing, I win
00:05:38 <Samu> was already getting bored
00:10:43 <Samu> tomorrow i'll take a better look at this translation thing
00:20:18 <Samu> AIAI aircraft server ending in 3 years :)~
01:23:04 *** ConductorCat has joined #openttd
01:27:11 <Samu> woah, almost doubled AdmiralAI which was the current no.1
01:56:16 <Samu> a quick fast forward game of roadai shows that the new version is performing worse t.t
02:06:26 <Samu> question, is there a way to recompress a .sav file without loading and saving it again?
02:07:43 <Samu> i saved using zlib:1, but want to convert to using lzma:9 without loading/saving because it would break some AIs
02:09:31 <Samu> wanted to upload smaller files to the forum
02:45:13 *** tokai|noir has joined #openttd
02:45:13 *** ChanServ sets mode: +v tokai|noir
03:26:04 *** ChanServ sets mode: +v tokai
03:58:27 *** gelignite_ has joined #openttd
05:06:57 *** Lejving is now known as BIG_Lejving
05:08:22 *** BIG_Lejving is now known as Lejving
08:15:48 *** sla_ro|master has joined #openttd
08:18:11 *** Flygon_ has joined #openttd
08:40:37 *** Alberth has joined #openttd
08:40:37 *** ChanServ sets mode: +o Alberth
09:07:59 *** andythenorth has joined #openttd
09:20:53 *** Lejving has joined #openttd
09:26:51 *** andythenorth has joined #openttd
09:41:16 <Alberth> 1000 buildings project has major clashes in building style :)
09:57:23 *** Flygon_ has joined #openttd
10:08:02 <andythenorth> need to paint some unpainted angles
10:09:04 <Alberth> ah, I advise red or bright yellow for those angles, as they can be very sharp
10:09:35 *** Flygon__ has joined #openttd
10:20:42 <Alberth> If you have run out of red paint, black would work too :)
10:32:48 <andythenorth> so what’s current blocker on NRT? o_O
10:33:04 * andythenorth is hoping $someone will get interested and help :)
10:33:15 <andythenorth> the patch you posted, I am out of my depth
10:33:29 <Wolf01> It seem I don't have enough knowledge to fix it
10:35:35 <andythenorth> what does it do / not do? o_O
10:36:15 <Wolf01> I think I'm stuck on the pack/upack of roadtypes
10:37:06 *** frosch123 has joined #openttd
10:43:17 <andythenorth> Wolf01: where’s the patch?
10:50:08 *** Flygon_ has joined #openttd
11:06:13 <Wolf01> andythenorth, I have a question, why do you/supermop/whoever put 1 train station non track tile connected to every truck station in openttdcoop.pro?
11:06:31 <andythenorth> displays waiting cargo
11:06:37 <andythenorth> so can see if station is under-served
11:07:12 <Wolf01> Oh, you mean visually intead of clicking the station
11:07:42 <andythenorth> it’s much less useful if more than one cargo is collected though
11:07:55 <andythenorth> because station display of multiple cargos is crap
11:10:25 <andythenorth> Wolf01: which branch should I compile this against?
11:10:36 <andythenorth> or just put it in the repo, broken? o_O
11:10:59 <andythenorth> usually I hate that, but it’s a dev branch, in a fork of a fork :P
11:11:12 <andythenorth> no kittens will die
11:11:17 <Wolf01> I would like to have something working, it compiles and run, but asserts almost immediately
11:12:13 <Wolf01> It retrieves "roadtype = 2" which is ROADTYPE_END
11:14:02 * andythenorth trying to apply the patch
11:14:07 <andythenorth> it assumes svn file structure? o_O
11:14:13 <andythenorth> looks svn-ish :P
11:15:01 <Wolf01> Yes, it breaks if I do it as git because I usually try to apply the same patch to different working copies
11:15:19 <Wolf01> Or even branches, or trunk
11:23:31 * andythenorth manually resolved the paths in patch
11:23:59 <andythenorth> src/road_func.h:179:32: error: unknown type name 'RoadTypeIdentifier'
11:24:46 <andythenorth> might be uncommitted changes in the repo
11:24:50 * andythenorth tries from fresh
11:25:12 <Wolf01> Nah, RoadTypeIdentifier is in patch only
11:26:30 <Wolf01> Did it patch road.h fine?
11:26:53 <andythenorth> 4 out of 4 hunks FAILED -- saving rejects to file src/road.h.rej
11:27:30 *** Webster has joined #openttd
11:28:20 <andythenorth> not sure how to resolve a failed patch
11:28:31 * andythenorth goes by line number
11:29:00 <andythenorth> dunno if it’s the line numbers in the patch, or the .rej file
11:29:17 <Wolf01> Usually I try to resolve by applying each chunk with the helper, but some times I do it manually
11:32:03 *** Progman has joined #openttd
11:33:18 * andythenorth can’t see why that wouldn’t patch
11:38:47 <andythenorth> it fixed line endings in other files :|
11:39:20 <andythenorth> Wolf01: push it in dev-unpack branch? o_O
11:39:47 <Wolf01> Or directly in dev, as you said, it's a clone of a branch
11:41:16 <andythenorth> if we can get the unpack working, I think the rest is just work and yak-shaving
11:41:23 *** Wormnest has joined #openttd
11:42:47 <Wolf01> It's 3-patches-in-one because it's too wide spread to get all divided
11:45:57 <andythenorth> yeah asserts for me
11:46:12 <andythenorth> got a compile warning about “CompareRoadTypes” being unused also, probably not relevant?
11:46:15 <Wolf01> Yes, it asserts, with no doubt :P
11:46:54 <Wolf01> Not relevant, I disabled sorting
11:47:14 <Wolf01> I'll re-enable it when I'll get it working
11:47:33 <Wolf01> GetRoadTypeInfo() is the problem
11:49:01 <Wolf01> It's the entire RoadTypeIdentifier if we want to be precise
11:49:07 <andythenorth> ok it doesn’t assert with no grf
11:49:12 * andythenorth working through things
11:49:19 <andythenorth> we’re sure it’s not the grf is broken?
11:49:31 <andythenorth> but then if it was, the behaviour should be better handled than assert
12:07:14 *** Defaultti has joined #openttd
12:17:32 *** Myhorta has joined #openttd
12:18:56 <andythenorth> Wolf01: I’ve made a grf that has “ROAD” as label rather than “WOLF"
12:19:13 <andythenorth> appears not to assert, _if_ I’ve done it right :P
12:19:46 <Wolf01> It should appear in the road types dropdown if I made it right
12:21:16 <andythenorth> I just get one type, normal road
12:21:21 <andythenorth> that’s expected?
12:22:00 <andythenorth> can I get it to print the label in shell?
12:22:07 <andythenorth> it’s printing the roadtype props
12:22:29 <Wolf01> It only prints the uint32, I don't know how to print the string
12:25:14 <andythenorth> this is painful eh? :D
12:27:28 <Wolf01> It's depressing, not painful
12:28:46 <andythenorth> ok so changing the label from “ROAD” definitely triggers the assert
12:29:05 <andythenorth> so why doesn’t that assert when label is “ROAD”…? o_O
12:29:21 <Wolf01> Because it asserts when adding a roadtype
12:29:34 <Wolf01> Not when changing an existing one
12:29:52 <andythenorth> are the ranges for GB correct?
12:30:15 <Wolf01> Maybe thy are off by 1
12:30:46 <andythenorth> “C++ for dummies”: why is ret a bool?
12:31:00 <andythenorth> the return value from Unpack() is a bool?
12:31:14 <Wolf01> Yes, it returns if unpacked succesfully
12:35:06 * andythenorth needs a pencil and paper to draw bits :( :P
12:36:45 <argoneus> good morning train friends
12:41:29 <andythenorth> Wolf01: I can stop the assert on L207 of road.cpp :( (by commenting it out)
12:41:41 <andythenorth> that gets me more asserts in road.h
12:41:54 <Wolf01> Heh... that's because it's returning the wrong type
12:42:13 <Wolf01> There's an assert there for a reason :P
12:48:02 <Eddi|zuHause> andythenorth: if the grf is faulty, it should error out much earlier
12:49:32 <Wolf01> But I think it is already on the reservation for the newgrf which calls GetRailTypeInfo() to check if there's already a label
12:51:36 <andythenorth> I forced this->subtype = (RoadType)1;
12:51:43 <andythenorth> and now I am building tram instead of road :P
12:51:55 <andythenorth> (RoadType) is a cast?
12:52:29 <Eddi|zuHause> not to confuse with RoadType(1), which would be a constructor
12:56:17 <andythenorth> ach can’t just printf the result of GB
12:56:21 <andythenorth> have to format it
12:59:06 <andythenorth> Wolf01: if basetype is 0 and subtype is 1, what should the result be? o_O
12:59:10 <andythenorth> I get tram track and trams :P
13:00:03 <Wolf01> Basetype 0 is road, and subtype 1 should be a new roadtype
13:00:33 * andythenorth is prone to hard-coding things to test, rather than debugging ‘properly'
13:01:39 <Wolf01> I have a bigger problem now: need to transport gasoline, I only have fuel cargo O_o
13:08:34 *** Arveen2 has joined #openttd
13:08:34 *** Arveen is now known as Guest1575
13:08:34 *** Arveen2 is now known as Arveen
13:08:52 <andythenorth> sounds like something is changing cargo name?
13:09:43 <Wolf01> Italian translation is different, in english is correct
13:10:40 <Wolf01> UKRS "petrol" translate to "carburante (fuel)" while FIRS "petrol" translates to "benzina (gasoline)"
13:10:50 * andythenorth staring at RoadType() :P
13:29:05 *** gelignite has joined #openttd
13:32:31 <andythenorth> Wolf01: I got nothing :(
13:32:41 <andythenorth> needs code review from someone who isn’t andythenorth :(
13:32:44 <Wolf01> I'll give it a look too
13:35:05 <andythenorth> see if you can get Eddi|zuHause interested
13:35:38 <Wolf01> He just don't want us to know
13:35:40 <andythenorth> it’s an obiwan somewhere, € on it
13:35:42 <Eddi|zuHause> well, interested, just not motivated
13:36:06 <andythenorth> or subtype and basetype are transposed somewhere :P
13:36:23 <Wolf01> Samu, Roadtypes, but it asserts because I don't know how to do it right in the RoadTypeIdentifier
13:36:44 * andythenorth suspects subtype and basetype transposition in a way that doesn’t show up when both are 0
13:37:06 <andythenorth> Samu: you have to have a test grf also
13:38:45 <Samu> hmm, not really sure if i follow
13:40:05 <Samu> gonna try loading project in visual studio
13:40:50 <andythenorth> it’s a git repo forked from main openttd repo
13:43:56 <Samu> Visual studio does not like it "Security Warning for openttd_vs140: The project file openttd_vs140 may have come from a location that is not fully trusted.
13:44:17 <Samu> Would you like to open this project?
13:45:59 <Samu> is this project gonna do a format c: or something :o
13:46:41 <Wolf01> We are working on roadtypes and we don't know how to fix a thing, we just need more point ov views
13:51:29 <andythenorth> Samu: could just clone it with git? o_O
13:54:21 <Samu> ok, back, gonna try building it
13:55:26 <Samu> crap, needs those essentials stuff, brb
13:57:31 <Wolf01> Why don't you prepare an openttd_vs140.vcxproj.user file?
13:58:06 <Wolf01> I just copy that on every working copy and ba-dum! Useful included automagically
14:01:52 <Samu> tortoise scv checkout doesn't work
14:04:17 <Wolf01> Also I found why I missed key strokes, I connected again keyboard and mouse in the same usb hub...
14:04:36 <Samu> there's branches, and there's trunk, which one is it?
14:05:03 <Wolf01> I don't know why, but if I do that they miss key strokes or even mouse clicks
14:06:08 <Samu> whatt's the vcxproj.user file?
14:07:03 <Wolf01> A user file to store user-dependant project properties instead of modifying the distributed project file
14:08:56 <Wolf01> Where OTTD_IncludePath and OTTD_LibraryPath are environment variables, you can put the exact path if you want
14:16:28 <Samu> sorry for noob question, is that the conents of a 'openttd_vs140.vcxproj.user' file?
14:16:41 <Samu> i've never done it before
14:17:51 <Samu> well anyway, i just done it by editing the vcxproj, maybe next time
14:18:06 <Samu> how am i triggering the crash now?
14:18:45 <Wolf01> Loading the provided grf
14:21:40 <Samu> ah, crashed when starting a new game
14:36:32 <Samu> return (0< 16) && (2 < 2);
14:36:53 <Samu> i don't really know what these values mean
14:38:40 <Samu> where is this data = 2 coming from t.t o
14:39:27 <Wolf01> From Unpack(), and that, or pack, is wrong
14:42:14 <Samu> hmm i see there's 2 RoadTypes and 16 RoadSubTypes ...
14:42:24 <Samu> i'd need to learn how is this all organized
14:44:37 <Wolf01> RoadTypeIdentifier should be a tool to provide an unique number based on base type + sub type, for example "Road + paved road 120kmh" or "Tram + rack and pinion rail"
14:45:14 <Wolf01> And with that number you can know if it's road or tram
14:45:25 <Wolf01> And which one if road or tram
14:46:05 <Wolf01> It's needed in cases where you can't pass more parameters (sort functions)
14:46:32 <Wolf01> But also to keep the code clean instead of passing 2 parameters everywhere
14:46:59 <Samu> basetype can't be 2, i see that throughout the code
14:47:19 <Wolf01> Indeed, that's wrong, it can only be 0 and 1
14:48:00 <Samu> this->basetype = (RoadType)GB(2, 0, 2);
14:51:01 <Samu> return (this->basetype << ROADSUBTYPE_END) | this->subtype; trying to decipher this
14:51:17 <Samu> when it was packed it was 1, right?
14:51:37 <Samu> assert is there, so i suppose not
14:51:57 <Wolf01> It should be GB(2, 0, 1)
14:52:54 <Wolf01> And the following line GB(2, 2, 4)
14:53:48 <Wolf01> Need to store length in bits in the enum
15:08:09 <Wolf01> Ok, now it seem that there's a problem with the FOR_ALL_SORTED_ROADTYPES, I can't find other road types even if there are
15:08:24 <Samu> return (2 << 16) | 0 - who's a math expert
15:10:01 <Samu> or right, 2 is not possible
15:10:06 <Samu> return (1 << 16) | 0 - who's a math expert
15:11:24 <Samu> I'm getting 65.536 - is that what should be stored? I'm a bit confused now
15:13:20 <Wolf01> I mixed lengths with max values
15:13:58 <Samu> is pack and unpack related?
15:14:07 <Samu> how does it go from 65536 to 2
15:14:57 <Wolf01> Pack 0 and 0 -> *number* -> unpack -> 0 and 0
15:15:49 <Samu> pack returns 65536, then somehow it becomes 2 when it unpacks
15:16:45 <Wolf01> this->basetype = (RoadType)GB(data, 0, 1);
15:16:45 <Wolf01> this->subtype = (RoadType)GB(data, 2, 4);
15:24:44 <Samu> this->basetype = (RoadType)GB(data, 0, ROADTYPE_END -1);
15:25:43 <Samu> this->subtype = (RoadType)GB(data, ROADTYPE_END, calculate_4_somwhoe);
15:25:55 <Samu> this->subtype = (RoadType)GB(data, ROADTYPE_END, calculate_4_somehow);
15:27:08 <Samu> basetype is stored in 1 bit, right?
15:28:03 <Samu> I think you want this->subtype = (RoadType)GB(data, 1, 4);
15:30:11 *** HerzogDeXtEr has joined #openttd
15:31:45 <Samu> 000 x xxxx - RoadType + RoadSubType
15:31:51 <Samu> 000x xxxx - RoadType + RoadSubType
15:32:37 <Samu> but packing needs fixing
15:34:54 <Samu> return this->basetype | (this->subtype << 1); maybe this?
15:38:26 <Samu> it's generating world :)
15:39:09 *** HerzogDeXtEr1 has joined #openttd
15:40:11 <Samu> world generated but there's another assert when i get to road construction
15:43:12 <Samu> assert(list->Length() > 0);
15:43:51 <Samu> there are 0 items in the dropdown list
16:38:17 *** Alberth has joined #openttd
16:38:17 *** ChanServ sets mode: +o Alberth
16:53:14 <Samu> just started testing RoadRunner v10
17:27:21 *** andythenorth has joined #openttd
17:31:08 <Samu> how many road types are in your test grf
17:31:38 <Samu> I presume 1, but not sure
17:32:49 <Samu> i also tested the generic tram set
17:32:54 <Samu> and i could only build roads
17:33:16 <Samu> seems like 2 is 1, and 1 is 0
17:34:32 <andythenorth> Samu: just 1 in the grf I linked iirc
17:36:37 <Samu> seems to be it, when i access the road construction dropdown it crashes because there are 0 items to display
17:36:58 <Samu> but didn't crash with generic tram set
17:41:50 <andythenorth> nothing good will come of it
17:45:17 <Samu> i didn't read the whole topic, but it's about licenses?
17:45:41 <andythenorth> it’s about misunderstandings
17:46:01 <Samu> if i post something on the internet, it's not mine anymore
17:46:28 <Alberth> the law says it's still yours
17:46:34 <andythenorth> Samu: (1) you need the wtfpl :) (2) nah
17:46:37 <Samu> anymore can do whatever they want with it :o
17:46:46 <andythenorth> only if you license it for that
17:46:50 <Alberth> you have to explicitly say you give it away
17:47:05 <Samu> it's the internet, once there, always there
17:48:11 <Alberth> being around is not the same as being allowed to use
17:48:31 <Alberth> andy: indeed, post won't do much good
17:48:58 <Samu> not like i have any say on what the others do with it
17:49:13 <Alberth> Samu: but it's easily solved, just say with every post that the content has a the WTPL license
17:50:18 <Samu> i don't get why do I need a license of stuff I post
17:51:14 <andythenorth> you don’t need to
17:51:27 <Alberth> you don't, but then everything you post is still yours, others may not use it as they see fit
17:51:59 <Alberth> just ass it to your signature :)
17:52:53 * andythenorth removed the post
17:53:02 <andythenorth> spending Sunday arguing on the internet might have been fun
17:53:08 <andythenorth> but Monday is a work day :P
17:58:05 <andythenorth> he must be about 15?
17:58:07 <Alberth> stuff seems mostly settled
18:02:23 <andythenorth> pretty serious business
18:08:30 <Alberth> WTPL is an official open source license. It even has a real use, some countries do not recognize public domain, That license is equivalent to it, but it does get recognized as being legal in those countries
18:11:01 <Wolf01> andythenorth, I think I fixed one of the asserts
18:11:45 <Wolf01> I need to understand the Pack() stuff now
18:19:33 <Samu> did you read logs? i typed stuff when you were gone
18:20:04 <Wolf01> Samu, did you read that I fixed it way before you wrote that?
18:22:16 <Samu> for unpack i did this this->basetype = (RoadType)GB(data, 0, 1);
18:22:27 <Samu> this->subtype = (RoadType)GB(data, 1, 4);
18:23:08 <Samu> for pack i did this return this->basetype | (this->subtype << 1);
18:24:29 <Samu> it worked, but there's more crashes
18:25:41 <Samu> there's 2 is 1 and 1 is 0 issues somewhere when constructing a list of items for the road dropdown menu
18:26:49 <Wolf01> That's because I hardcoded the showinf of tram
18:27:18 <Wolf01> I need to change the macro FOR_ALL_SORTED_ROADTYPES
18:31:01 <Samu> you have said you did: this->subtype = (RoadType)GB(data, 2, 4);
18:31:20 <Samu> i suppose it should be: this->subtype = (RoadType)GB(data, 1, 4);
18:32:02 *** ChanServ sets mode: +v tokai
18:34:26 <Wolf01> andythenorth, could you provide a roadtype with a different menu text? Dropdowns don't seem to work really well with same text
18:37:13 <Wolf01> It's not related to a tram set
18:46:05 <Samu> let me see what happens when i use it
18:47:33 <Samu> yay nice job, i can build trams and roads now
18:48:52 <Wolf01> Nice error I'm getting now "96,030 bags of sweet"
18:50:08 <Alberth> enough to fill a house :)
18:50:56 <Samu> I'm getting: Road Construction, Road Construction, Tramway Construction
18:51:18 <Wolf01> Yes, the second road should be the new one
18:51:21 <Samu> the two Road Constructions are pegged into each other, not separate
18:56:26 <Samu> a quick fast forward test shows RoadRunner v10 doing much much better than v9
19:02:53 *** sla_ro|master has joined #openttd
19:03:15 <Samu> hehe, RoadRunner was the cheating AI with 80 year preview vehicles :)
19:03:32 <Samu> but that was fixed in 1.6.1
19:03:54 <Samu> would have to test in 1.5.0 or something to see if it really was fixed, i'm not in the mood for it
19:05:48 <Wolf01> Mmmh, I need to get rid of all those RoadTypeToRoadTypes()
19:06:27 <Wolf01> Also I fixed even that double selected dropdown item
19:06:42 <Wolf01> Too bad the second roadtype is unbuildable right now
19:13:03 <Samu> horizontal scrolling will be needed
19:13:16 <Samu> not sure if i post these results like that
19:25:55 <andythenorth> Wolf01: I’ll make a new grf shortly
19:26:14 <Samu> i'm not sure how terron managed a 101% with ships
19:26:25 <Samu> i think he uses transfer orders
19:26:51 <Samu> buses transfer passangers to ships
19:27:51 <Samu> not sure about the whole math involved in transfers, but... ship profit averaged higher than the best last year ship profit
19:28:32 <Samu> in better english: the average is higher than the best
19:34:51 <Samu> or he sold quite some many ships right before entering 2051
19:35:02 <Samu> and that would inflate the average
19:35:19 <Samu> terron likes to renew vehicles for no reason
19:35:31 <Samu> way before their max age
19:39:33 <Samu> maybe he cheats like rondje
19:42:29 <Samu> @calc (((1131295-273205)/10)/85249)*100
19:45:48 <DorpsGek> Commit by translators :: r27659 trunk/src/lang/portuguese.txt (2016-10-09 19:45:39 +0200 )
19:45:50 <DorpsGek> portuguese: 25 changes by Samu
19:46:19 <Samu> is that my name there? it should be Xarick
19:46:24 <Samu> whatever, doesn't matter
19:56:21 <andythenorth> Wolf01: is the menu fetching the correct strings? o_O
19:57:08 <Samu> andythenorth: your grf crashes on original 1.6.1
19:57:16 <Samu> it's not supposed to use it, right?
19:57:31 <andythenorth> Samu: no support for roadtype ;)
19:57:37 <andythenorth> crashing is ‘correct’
19:58:14 <andythenorth> ‘default’ ROAD, and WOLF road
19:58:30 <andythenorth> the strings don’t work for me though
19:59:16 <Wolf01> The second type has something different
19:59:24 <Wolf01> But still not using the right strings
20:00:37 <andythenorth> it misses one way roads, I noticed
20:01:15 <Wolf01> But I think it's because some hardcoded check on roadtype "1"
20:01:44 <Wolf01> Since it should be using road subtype 1 now it might be that...
20:02:53 <Wolf01> There are many things to change
20:03:10 <Wolf01> It's checked everywhere that the roadtype must be road or tram
20:03:58 <andythenorth> but we now have it not crashing
20:04:01 <andythenorth> which is a big deal )
20:04:14 <Wolf01> And it's even loading another dropdown item!
20:05:44 <andythenorth> construction menu thinks it’s a tramway :)
20:06:13 <Wolf01> I can't decide if RoadTypeInfo is wrong
20:06:28 <andythenorth> also nothing builds on the new type :D
20:06:49 <Wolf01> No, that's because the hardcoded checks in tram and road
20:07:07 * andythenorth has seen those checks before and changed them in an old patch ;)
20:07:13 <Wolf01> If you build a roadstop it even asserts
20:10:01 <Samu> pt_PT and pt_BR are copied over each other? or are they just suggestions?
20:10:18 <Samu> the translation website is smart!
20:20:53 <Samu> the portuguese translators have a tough town versus city issue
20:21:09 <Samu> i guess we initially translated town to city
20:21:28 <Samu> then city became part of openttd
20:21:45 <Samu> and we still kept translating city to city
20:24:45 <Samu> is there a way to send notes to other portuguese translators? or put notes about certain words?
20:25:20 <Samu> we're not in agreement about this town vs city issue
20:26:34 <Samu> i'd like a note saying: DO NOT TRANSLATE CITY TO CITY, BUT TO METRÓPOLE
20:30:14 <Samu> the root of the problem was at the beginning, whoever was at it, translated town to city, instead of village
20:44:18 <Samu> town to city is also correct, but not when openttd also has city
20:50:34 *** Myhorta has joined #openttd
21:03:35 <Wolf01> Samu, feel free to change all town occurrencies
21:14:54 *** Supercheese has joined #openttd
21:18:34 *** Wormnest has joined #openttd
21:32:52 <Wolf01> andythenorth, I found why there were no strings in the errors of the second roadtype
21:33:20 <Wolf01> Also why is the item title "road" and toolbar title "tramway"
21:34:17 <Wolf01> The funny thing is that now you can build both roads
21:36:46 <Wolf01> The last one is because I'm stupid
21:40:43 <Wolf01> Uhm, it seem to work anyway
21:43:36 <Wolf01> Ok, it seem I can add an arbitrary number of roadtypes and tramtypes now
21:43:57 <andythenorth> Wolf01: let me know if there’s something to pull :)
21:44:13 <Wolf01> I committed some fixes and changes
21:48:03 <andythenorth> Wolf01: nicely played
21:48:13 <andythenorth> both types now show
21:48:24 <Samu> Wolf01: well i could do that, but then the next translator would find town and translate it to city, it's natural translation, and then another one finds city and then translates to city :(
21:48:47 <andythenorth> be useful if the land inspector gained the newgrf debug tools for NRT
21:49:09 <andythenorth> maybe Samu would do that? o_O
21:49:31 <Samu> ? i was answering to Wolf01 [20:03] <Wolf01> Samu, feel free to change all town occurrencies
21:49:42 <Wolf01> I added a second tramtype with label "etrm" and menu string from elrail and it works
21:50:03 <andythenorth> in newgrf, or hard-coded? o_O
21:50:24 <andythenorth> hard-coded ftw when it’s a complex patch
21:50:46 *** Supercheese has joined #openttd
21:50:49 <Wolf01> You could do that by copying the tram definition in roadtypes.h
21:50:53 <Samu> it's natural for us to translate town to city
21:51:18 <Wolf01> I just added another "original roadtype"
21:51:32 <Samu> bah whatever, doesn't matter
21:51:38 <Wolf01> It's like it's done by a newgrf but it's hardcoded instead
21:52:24 <Samu> everything is a cidade.... and it can't be
21:52:25 *** sim-al2 has joined #openttd
21:53:57 <Wolf01> So you in portuguese call a town city?
21:54:16 <Samu> but it could also be village
21:54:39 <andythenorth> USA often does same
21:54:53 <andythenorth> ‘city’ is a legal incorporation, but might be 500 people
21:58:48 <Wolf01> It would be cool if while I'm doing the gui part somebody tries to fix the grf loading part... if that need a fix
21:59:26 <Wolf01> I can't understand why it doesn't load a different string for the dropdown
21:59:47 <Wolf01> Maybe because it isn't handled?
22:01:07 <Samu> A vila is a town in Portugal.
22:02:00 <Samu> i blame the first ever translator that made town to cidade
22:02:04 <Wolf01> Then change it, cidade for town is wrong
22:02:22 <Samu> there's towns all over it, gah... :(
22:02:30 <Samu> not in the mood for it now :(
22:02:55 <andythenorth> Wolf01: the strings are at least in the encoded grf, I have confirmed that much
22:05:43 <Wolf01> Oooooooh, I found how to pass the correct roadtype
22:06:18 <Wolf01> I just need some help with flags
22:07:27 <Wolf01> DoCommandP(start_tile, end_tile, _place_road_flag | (_cur_roadtype << 3) | (_one_way_button_clicked << 5), .....
22:07:44 <Wolf01> I need to pass the _cur_roadtype_id there
22:08:26 <Samu> _cur_road_type is 1+4 bits?
22:08:29 <Wolf01> I used uint32 because I didn't know the exact length
22:08:44 <Wolf01> But I think I could reduce to uint8
22:10:00 <Samu> 000x xxxx - _cur_road_type
22:10:59 <Samu> _cur_roadtype << 3 means ....
22:13:34 <Wolf01> So the _one_way_button_clicked must be moved by 8 instead of 5?
22:14:35 <Wolf01> I really have problems to follow bit shifting
22:15:15 <Samu> me too, kinda, i used the windows calculator for that
22:15:36 <Samu> change calculator mode to programmer
22:15:51 <Samu> then it has all the nice bit math stuff
22:16:08 <Samu> left shift right shihft, word, dwords etc... crap like that
22:17:43 <Samu> _one_way_button_clicked is this 1 bit too?
22:17:47 <Eddi|zuHause> <Wolf01> DoCommandP(start_tile, end_tile, _place_road_flag | (_cur_roadtype << 3) | (_one_way_button_clicked << 5), ..... <-- that sounds like a place where you should use pack/unpack
22:18:28 <Wolf01> Yes Eddi, I'm trying to put there the packed identifier to unpack on the other side
22:18:37 <Samu> in calculator i did 1 Lsh 8 = 256 in decimal
22:19:21 <Samu> so ya, i thnk that's where u want it
22:19:55 <Samu> but a byte is only 8 bits
22:20:31 <Wolf01> The param is uint32, so I don't think it's a problem
22:21:25 <Wolf01> The problem is: id is uint8 but only 5 bits are used, what kind of errors will this bring in future?
22:23:29 <Samu> you only want to read those 5 bits
22:24:02 <Samu> I don't really know, honestly
22:24:33 <Samu> as long as you only use 5 bits and read only those 5 bits, there is no problem, but i'm not an expert
22:26:12 <Wolf01> Maybe it's not even a problem
22:26:35 <Samu> you have asserts all over the place for that part you showed me
22:26:57 <Eddi|zuHause> it's not a problem, just you need to document the limitation so someone who extends it stumbles over it
22:27:37 <Samu> you limited it already to 5 bits
22:28:02 <Wolf01> Asserts can be changed
22:28:31 <Wolf01> I'll do as Eddi suggested, a comment in the right place could only be a good thing
22:46:00 <andythenorth> Wolf01: progress is good :) \o/
22:46:29 <Wolf01> Also needs a lot of cleanup
22:51:47 <Wolf01> Samu, is there a window which shows all the set breakpoints?
22:58:07 <Samu> Debug > Windows > Breakpoints
22:58:33 <Wolf01> Bah.. to many places for "windows"
22:58:35 *** Ethereal_Whisper has joined #openttd
22:58:41 <Wolf01> I didn't even notice that
23:00:46 *** Supercheese has joined #openttd
23:06:36 *** andythenorth has left #openttd
23:36:11 *** sim-al2 has joined #openttd
continue to next day ⏵