⏴ go to previous day
00:56:20 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
00:57:08 *** WormnestAndroid has joined #openttd
01:46:44 *** MinchinWeb[m] has quit IRC (Read error: Connection reset by peer)
01:47:00 *** MinchinWeb[m] has joined #openttd
02:18:55 *** Wormnest has quit IRC (Quit: Leaving)
03:19:30 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #15752: Codechange: make VehicleListType scoped https://github.com/OpenTTD/OpenTTD/pull/15752#pullrequestreview-4539138119
03:23:07 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #15746: Codechange: use Currency over uint8_t https://github.com/OpenTTD/OpenTTD/pull/15746#pullrequestreview-4539139896
03:41:24 *** Philemon has joined #openttd
03:44:45 *** Phileman has quit IRC (Ping timeout: 480 seconds)
05:45:54 *** WormnestAndroid has quit IRC (Remote host closed the connection)
05:45:55 *** WormnestAndroid has joined #openttd
05:46:03 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
05:46:04 *** WormnestAndroid has joined #openttd
05:46:07 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
05:46:09 *** WormnestAndroid has joined #openttd
06:14:51 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/720d10536dd22198ccd272dd0d30a5db3fcd4db5
06:14:52 <DorpsGek> - Update: Translations from eints (by translators)
06:28:12 *** Wolf01 has joined #openttd
06:33:45 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #15747: Codechange: make Currency a scoped enumeration https://github.com/OpenTTD/OpenTTD/pull/15747
06:33:48 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #15746: Codechange: use Currency over uint8_t https://github.com/OpenTTD/OpenTTD/pull/15746
06:33:51 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 dismissed a review for pull request #15752: Codechange: make VehicleListType scoped https://github.com/OpenTTD/OpenTTD/pull/15752#pullrequestreview-4539138119
06:33:54 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #15752: Codechange: make VehicleListType scoped https://github.com/OpenTTD/OpenTTD/pull/15752
06:43:48 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #15752: Codechange: make VehicleListType scoped https://github.com/OpenTTD/OpenTTD/pull/15752#pullrequestreview-4539302687
06:45:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #15754: Codechange: make GroundVehicleFlag(s) a scoped enum/EnumBitSet https://github.com/OpenTTD/OpenTTD/pull/15754
06:47:15 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #15754: Codechange: make GroundVehicleFlag(s) a scoped enum/EnumBitSet https://github.com/OpenTTD/OpenTTD/pull/15754#pullrequestreview-4539305857
07:10:33 <peter1138> Hmm, shame you can't compare two std::any
07:26:37 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #15755: Codechange: make EngineImageType a scoped enum https://github.com/OpenTTD/OpenTTD/pull/15755
07:31:46 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #15752: Codechange: make VehicleListType scoped https://github.com/OpenTTD/OpenTTD/pull/15752
07:33:55 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #15755: Codechange: make EngineImageType a scoped enum https://github.com/OpenTTD/OpenTTD/pull/15755#pullrequestreview-4539346033
07:50:49 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #15754: Codechange: make GroundVehicleFlag(s) a scoped enum/EnumBitSet https://github.com/OpenTTD/OpenTTD/pull/15754
08:02:58 <DorpsGek> [OpenTTD/OpenTTD] Borosnyai opened pull request #15756: Fix train depot not charging infrastructure maintenance cost https://github.com/OpenTTD/OpenTTD/pull/15756
08:03:17 *** MinchinWeb[m] has quit IRC (Remote host closed the connection)
08:03:30 *** MinchinWeb[m] has joined #openttd
08:05:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #15755: Codechange: make EngineImageType a scoped enum https://github.com/OpenTTD/OpenTTD/pull/15755
08:09:40 <DorpsGek> [OpenTTD/OpenTTD] mmtunligit commented on pull request #15756: Fix train depot not charging infrastructure maintenance cost https://github.com/OpenTTD/OpenTTD/pull/15756#issuecomment-4761342835
08:11:05 <peter1138> Wasn't there another PR for that already?
08:11:32 <peter1138> Might've been similar.
08:11:41 <mmtunligit> 15527 yeah
08:12:22 <mmtunligit> and 14674
08:13:50 <mmtunligit> 7851 can probably be closed, another version of that PR has since been merged
08:15:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #15757: Codechange: make AccelerationModel a scoped enum https://github.com/OpenTTD/OpenTTD/pull/15757
08:16:29 <peter1138> Heh, Rito reviewing it 6 years later...
08:16:40 <peter1138> Or possibly 3.
08:29:11 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #15757: Codechange: make AccelerationModel a scoped enum https://github.com/OpenTTD/OpenTTD/pull/15757#pullrequestreview-4539407416
08:40:45 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #15746: Codechange: use Currency over uint8_t https://github.com/OpenTTD/OpenTTD/pull/15746#issuecomment-4761415783
08:44:51 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #15746: Codechange: use Currency over uint8_t https://github.com/OpenTTD/OpenTTD/pull/15746#issuecomment-4761425532
08:47:53 <DorpsGek> [OpenTTD/OpenTTD] Borosnyai updated pull request #15756: Fix train depot not charging infrastructure maintenance cost https://github.com/OpenTTD/OpenTTD/pull/15756
08:48:59 <DorpsGek> [OpenTTD/OpenTTD] Borosnyai commented on pull request #15756: Fix train depot not charging infrastructure maintenance cost https://github.com/OpenTTD/OpenTTD/pull/15756#issuecomment-4761434692
08:49:12 <DorpsGek> [OpenTTD/OpenTTD] Borosnyai closed pull request #15756: Fix train depot not charging infrastructure maintenance cost https://github.com/OpenTTD/OpenTTD/pull/15756
08:51:38 <will_marshall_> Borosyn AI you say?
08:51:45 <will_marshall_> Writes like an LLM, quacks like an LLM?
08:59:56 *** Flygon has quit IRC (Read error: Connection reset by peer)
09:01:16 <peter1138> Yeah
09:01:37 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #15757: Codechange: make AccelerationModel a scoped enum https://github.com/OpenTTD/OpenTTD/pull/15757
09:02:56 *** rito12_13 has joined #openttd
09:02:56 <rito12_13> They have their own sandbox https://github.com/EmaToplek/zoo-manager
09:42:20 *** gelignite has joined #openttd
10:05:09 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #15758: Codechange: make PlaylistChoice a scoped enum https://github.com/OpenTTD/OpenTTD/pull/15758
10:35:40 <DorpsGek> [OpenTTD/OpenTTD] HyperJeanJean opened issue #15759: [Bug]: Inconsistency for electric locomotives when electric rails are re-enabled https://github.com/OpenTTD/OpenTTD/issues/15759
10:50:49 <peter1138> Just leave the thing on or off :o
11:18:28 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #15759: [Bug]: Electric locomotives do not always run on standard railways when electric rails are re-enabled https://github.com/OpenTTD/OpenTTD/issues/15759
11:36:36 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #15746: Codechange: use Currency over uint8_t https://github.com/OpenTTD/OpenTTD/pull/15746#pullrequestreview-4539601086
11:45:36 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
11:46:00 *** WormnestAndroid has joined #openttd
11:52:55 * peter1138 ponders trying to tackle fonts again.
12:07:06 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #15760: Codechange: extract function to look up fontsize by name https://github.com/OpenTTD/OpenTTD/pull/15760
12:27:34 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #15760: Codechange: extract function to look up fontsize by name https://github.com/OpenTTD/OpenTTD/pull/15760#pullrequestreview-4539685073
12:50:48 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #15760: Codechange: extract function to look up fontsize by name https://github.com/OpenTTD/OpenTTD/pull/15760
13:17:36 * peter1138 tries to remember where the problem was.
13:30:45 *** Tirili has joined #openttd
14:06:20 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #15746: Codechange: use Currency over uint8_t https://github.com/OpenTTD/OpenTTD/pull/15746
14:09:34 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #15758: Codechange: make PlaylistChoice a scoped enum https://github.com/OpenTTD/OpenTTD/pull/15758#pullrequestreview-4539814373
14:14:08 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #15747: Codechange: make Currency a scoped enumeration https://github.com/OpenTTD/OpenTTD/pull/15747
14:14:41 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #15758: Codechange: make PlaylistChoice a scoped enum https://github.com/OpenTTD/OpenTTD/pull/15758
14:15:09 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #15750: Codechange: use proper names for SLV_1 - SLV_19 https://github.com/OpenTTD/OpenTTD/pull/15750
14:15:14 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #15747: Codechange: make Currency a scoped enumeration https://github.com/OpenTTD/OpenTTD/pull/15747#pullrequestreview-4539822829
14:32:17 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
14:32:25 *** WormnestAndroid has joined #openttd
14:36:46 *** gelignite has quit IRC (Ping timeout: 480 seconds)
14:41:03 *** Wormnest has joined #openttd
14:51:11 <DorpsGek> [OpenTTD/OpenTTD] Brickblock1 updated pull request #15485: Change: [NewGRF] xor reversed and driving backwards flags for modflags bit 8 https://github.com/OpenTTD/OpenTTD/pull/15485
14:53:17 *** MinchinWeb[m] has quit IRC (Ping timeout: 480 seconds)
14:54:15 <DorpsGek> [OpenTTD/OpenTTD] Brickblock1 updated pull request #15485: Change: [NewGRF] xor reversed and driving backwards flags for modflags bit 8 https://github.com/OpenTTD/OpenTTD/pull/15485
14:55:28 *** MinchinWeb[m] has joined #openttd
15:14:57 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #15747: Codechange: make Currency a scoped enumeration https://github.com/OpenTTD/OpenTTD/pull/15747
15:45:40 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #15741: Codechange: make ViewportScrollTarget scoped https://github.com/OpenTTD/OpenTTD/pull/15741#pullrequestreview-4539926193
15:49:16 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #15749: Change: prevent oversized purchase list windows https://github.com/OpenTTD/OpenTTD/pull/15749#issuecomment-4762488127
15:57:15 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #15485: Change: [NewGRF] xor reversed and driving backwards flags for modflags bit 8 https://github.com/OpenTTD/OpenTTD/pull/15485#pullrequestreview-4539940704
15:57:53 *** brickblock19280 has joined #openttd
15:57:53 <brickblock19280> will change if I can get it to compile
15:58:36 <brickblock19280> currently not allowed by line 42 in signal.cpp despite not having touched that
16:05:54 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #15750: Codechange: use proper names for SLV_1 - SLV_19 https://github.com/OpenTTD/OpenTTD/pull/15750#pullrequestreview-4539942666
16:10:31 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #15741: Codechange: make ViewportScrollTarget scoped https://github.com/OpenTTD/OpenTTD/pull/15741
16:17:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #15750: Codechange: use proper names for SLV_1 - SLV_19 https://github.com/OpenTTD/OpenTTD/pull/15750#pullrequestreview-4539957679
16:24:48 <brickblock19280> ```FAILED: CMakeFiles/openttd_lib.dir/src/signal.cpp.obj
16:24:48 <brickblock19280> C:\Users\\Documents\GitHub\OpenTTD2tt\src\signal.cpp(42): error C2131: expression did not evaluate to a constant
16:24:48 <brickblock19280> C:\Users\\Documents\GitHub\OpenTTD2tt\src\core\base_bitset_type.hpp(57): note: failure was caused by cast of object of dynamic type 'BaseBitSet<EnumBitSet<Trackdir,uint16_t,Trackdir::End>,Tenum,Tstorage,65535> *' to type 'Timpl *'
16:24:48 <brickblock19280> with
16:24:48 <brickblock19280> [
16:24:49 <brickblock19280> Tenum=Trackdir,
16:24:49 <brickblock19280> Tstorage=uint16_t
16:24:51 <brickblock19280> ]
16:24:51 <brickblock19280> and
16:24:53 <brickblock19280> [
16:24:53 <brickblock19280> Timpl=EnumBitSet<Trackdir,uint16_t,Trackdir::End>
16:24:55 <brickblock19280> ]
16:24:55 <brickblock19280> C:\Users\\Documents\GitHub\OpenTTD2tt\src\signal.cpp(42): note: the call stack of the evaluation (the oldest call first) is
16:24:57 <brickblock19280> C:\Users\\Documents\GitHub\OpenTTD2tt\src\signal.cpp(44): note: while evaluating function 'EnumBitSet<Trackdir,uint16_t,Trackdir::End>::EnumBitSet(std::initializer_list<const Tenum>)'
16:24:57 <brickblock19280> with
16:24:59 <brickblock19280> [
16:24:59 <brickblock19280> Tenum=Trackdir
16:25:01 <brickblock19280> ]
16:25:01 <brickblock19280> C:\Users\\Documents\GitHub\OpenTTD2tt\src\core\enum_type.hpp(317): note: while evaluating function 'Timpl &BaseBitSet<Timpl,Tenum,Tstorage,65535>::Set(Tvalue_type)'
16:25:03 <brickblock19280> with
16:25:03 <brickblock19280> [
16:25:05 <brickblock19280> Timpl=EnumBitSet<Trackdir,uint16_t,Trackdir::End>,
16:25:05 <brickblock19280> Tenum=Trackdir,
16:25:07 <brickblock19280> Tstorage=uint16_t,
16:25:07 <brickblock19280> Tvalue_type=Trackdir
16:25:09 <brickblock19280> ]```
16:28:45 <will_marshall_> VS22 was doing something similar for me, I moved to VS26.
16:30:08 <brickblock19280> might have to do that then
16:32:32 <will_marshall_> I am fairly sure it's a compiler bug that needs reporting but good luck making an actual file to reproduce it.
16:32:56 <brickblock19280> there was an update to 2022 so i'll try that first
16:48:10 <brickblock19280> it didn't help :((
16:53:17 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #15750: Codechange: use proper names for SLV_1 - SLV_19 https://github.com/OpenTTD/OpenTTD/pull/15750#pullrequestreview-4540003756
16:55:42 <peter1138> Replace constexpr with const on line 42.
16:56:50 <peter1138> Some versions of MVSC don't consider the initializer_list constructor of EnumBitSet to be constexpr, though it tends to work with the CI.
16:57:23 <peter1138> Or rather, don't when the EnumBitSet ends up in an array.
16:58:47 <brickblock19280> seems wrong for me to change it in an unrelated PR
16:58:59 *** gelignite has joined #openttd
16:59:55 <peter1138> Just offering a way for you to get it to compile, not to include it in a PR.
17:01:16 <brickblock19280> fair
17:23:46 *** Flygon has joined #openttd
17:27:56 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #15750: Codechange: use proper names for SLV_1 - SLV_19 https://github.com/OpenTTD/OpenTTD/pull/15750
18:10:01 <DorpsGek> [OpenTTD/OpenTTD] Brickblock1 updated pull request #15485: Change: [NewGRF] xor reversed and driving backwards flags for modflags bit 8 https://github.com/OpenTTD/OpenTTD/pull/15485
18:13:14 <DorpsGek> [OpenTTD/OpenTTD] Brickblock1 commented on pull request #15485: Change: [NewGRF] xor reversed and driving backwards flags for modflags bit 8 https://github.com/OpenTTD/OpenTTD/pull/15485#issuecomment-4762859197
18:24:50 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #15485: Change: [NewGRF] xor reversed and driving backwards flags for modflags bit 8 https://github.com/OpenTTD/OpenTTD/pull/15485#issuecomment-4762888218
18:27:49 <brickblock19280> talltyler: I felt it wasn't really neccesarry after all the other bits didn't have any
18:28:26 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #15761: Codechange: make gamelog enums scoped https://github.com/OpenTTD/OpenTTD/pull/15761
18:29:32 <brickblock19280> and I couldn't come up with anything but I might add your comment
18:31:22 <DorpsGek> [OpenTTD/OpenTTD] Brickblock1 updated pull request #15485: Change: [NewGRF] xor reversed and driving backwards flags for modflags bit 8 https://github.com/OpenTTD/OpenTTD/pull/15485
18:35:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #15762: Codechange: use proper names for SLV_20 - SLV_39 https://github.com/OpenTTD/OpenTTD/pull/15762
18:36:09 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #15485: Change: [NewGRF] xor reversed and driving backwards flags for modflags bit 8 https://github.com/OpenTTD/OpenTTD/pull/15485#pullrequestreview-4540111929
18:38:26 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #15761: Codechange: make gamelog enums scoped https://github.com/OpenTTD/OpenTTD/pull/15761#pullrequestreview-4540115125
19:46:17 *** gelignite has quit IRC ()
19:46:41 *** MinchinWeb[m] has quit IRC (Read error: Connection reset by peer)
19:47:06 *** MinchinWeb[m] has joined #openttd
19:48:37 *** dollarcoinguy has joined #openttd
19:48:37 <dollarcoinguy> Low urgency, macOS-specific does anyone have experience with building an app bundle for macOS containing the dedicated server binary? I can compile the dedicated server okay and it runs without being packaged as long as the libraries are present but once packaged into `OpenTTD.app` throws code-signing errors about the dynamic libraries (even when running only the `./openttd` server binary
19:48:37 <dollarcoinguy> contained within, not the full `OpenTTD.app`). How do regular release app bundles run without being signed? I know they have to be allowed through Gatekeeper, macOS' security watcher
19:48:37 <dollarcoinguy> Is the Notarize task in https://github.com/JGRennison/OpenTTD-patches/blob/jgrpp/.github/workflows/release-macos.yml how it's done? Are the lipo and cpack commands required from the "Create bundles" task? (I have only run cmake, then make and zipped the game files)
20:18:39 <peter1138> https://github.com/OpenTTD/OpenTTD/blob/master/.github/workflows/ci-macos.yml is how we do it, but of course that's for our CI workflow.
20:22:35 *** _glx_ has joined #openttd
20:22:35 <_glx_> IIRC `lipo` is to combine x64 and arm64 builds
20:23:00 <_glx_> `cpack` creates the bundle
20:24:56 <_glx_> peter1138: yeah that's not the release workflow ;à
20:25:45 <peter1138> Silly me, s/ci-/release-/g
20:26:36 <_glx_> anyway JGRPP skips the signing
20:29:18 <_glx_> and "dedicated" builds are mostly a linux thing, since windows or macOS without desktop are not common
20:42:25 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
21:32:31 *** bobby has joined #openttd
21:33:15 *** bobby has quit IRC ()
22:15:10 <DorpsGek> [OpenTTD/OpenTTD] HyperJeanJean updated pull request #14481: Change: Disable electric railway when loading very old save https://github.com/OpenTTD/OpenTTD/pull/14481
22:17:59 <DorpsGek> [OpenTTD/OpenTTD] HyperJeanJean commented on pull request #14481: Change: Disable electric railway when loading very old save https://github.com/OpenTTD/OpenTTD/pull/14481#issuecomment-4763457895
continue to next day ⏵