IRC logs for #openttd on OFTC at 2026-02-17
            
00:20:08 <xarick> can't load save on 15.1 :
00:23:05 <peter1138> There's been savegame bumps, yes.
01:05:50 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
01:06:12 *** WormnestAndroid has joined #openttd
01:29:48 *** thinkweregonnagobyph has joined #openttd
01:29:48 <thinkweregonnagobyph> https://cdn.discordapp.com/attachments/1008473233844097104/1473129266840469545/image.png?ex=6995160a&is=6993c48a&hm=f9e6462c4a6701607aac95653a21efb166e3a4c9859635583904392e71b2c991&
01:29:48 <thinkweregonnagobyph> ok, so I just got this, and am confused... what data should I send where?
02:01:04 <peter1138> So the second line is a URL, which is where to send it.
02:02:11 <peter1138> Then lines 3 to 6 are paths to files which contain the data to send.
02:05:00 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
02:07:17 *** WormnestAndroid has joined #openttd
02:11:35 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
02:13:56 *** WormnestAndroid has joined #openttd
02:48:33 *** Wormnest has joined #openttd
02:53:30 *** Wormnest has quit IRC (Quit: Leaving)
04:10:15 *** Tirili has quit IRC (Quit: Leaving)
04:18:33 *** Zathras_1 has joined #openttd
04:18:43 *** Zathras_7 has joined #openttd
04:21:58 *** Zathras_4 has quit IRC (Ping timeout: 480 seconds)
04:22:03 *** Zathras_11 has quit IRC (Ping timeout: 480 seconds)
04:31:45 *** toktik has quit IRC (Remote host closed the connection)
04:49:05 <DorpsGek> [OpenTTD/nml] SpaceManiac opened pull request #417: Change: Include .nml, .lng, and custom_tags.txt files in -M output https://github.com/OpenTTD/nml/pull/417
04:49:35 *** toktik has joined #openttd
04:50:16 <DorpsGek> [OpenTTD/nml] SpaceManiac commented on pull request #417: Change: Include .nml, .lng, and custom_tags.txt files in -M output https://github.com/OpenTTD/nml/pull/417#pullrequestreview-3811674466
04:57:59 *** pickpacket3 has joined #openttd
04:57:59 *** pickpacket has quit IRC (Read error: Connection reset by peer)
04:57:59 *** pickpacket3 is now known as pickpacket
05:03:10 *** guru3 has quit IRC (Read error: Connection reset by peer)
05:06:59 *** guru3 has joined #openttd
05:08:23 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/e33d53e37e7b4ce1f98648ffc7d54cb0dd8cf5a9
05:08:24 <DorpsGek> - Update: Translations from eints (by translators)
06:11:01 *** cu-kai has quit IRC (Quit: Leaving for a bit.)
06:11:12 *** cu-kai has joined #openttd
07:00:21 *** Smedles has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
07:00:37 *** Smedles has joined #openttd
07:29:28 *** Flygon has quit IRC (Remote host closed the connection)
08:05:12 <Zathras_7> besides server_name is there another way to provide info about the server to clients? maybe something like a welcome message on joining?
08:10:22 *** coobies has joined #openttd
08:10:22 <coobies> Zathras_7: Yes, a join message is demoed in one of the scripts https://wiki.openttd.org/en/Manual/Running%20Startup%20Scripts
08:12:39 <Zathras_7> coobies: thanks! will have a look at that
08:24:02 <Zathras_7> uhm, where do I find these scripts? I am on Devuan/Debian and compile myself. then run ottd from within the build directory. cannot find any of the mentioned scripts there
08:25:56 <Zathras_7> since I probably need the "echo" command for this purpose, where would I put a script to be executed? it is a headless server so no GUI.
08:27:08 <coobies> I think this page has the information https://wiki.openttd.org/en/Archive/Manual/Scripts
08:27:50 <Zathras_7> oh, sorry, totally missed that. thanks!
08:28:00 <coobies> It looks like you would use one of those filenames and put it in the scripts folder, and use the echo command like you said
08:29:00 <Zathras_7> ok, probably the on_server_connect.scr ipt
08:31:31 <coobies> There is also the "storybook" feature in-game that some servers use for information. I think there's a way to make a pop-up with information or instructions about the server but I don't know how it works. I think it probably requires a custom gamescript
08:38:42 <Zathras_7> hmm
08:42:34 <Zathras_7> I'll have a look at that if the other option is not sufficient :D
09:20:09 *** SigHunter has quit IRC (Remote host closed the connection)
09:22:14 *** SigHunter has joined #openttd
09:50:10 <pickpacket> Why is a part of the game manual on the wiki under the "Archive" path? It makes it more or less impossible to navigate to without using a search engine. E.g. https://wiki.openttd.org/en/Archive/Manual/Headquarters
09:52:06 <LordAro> because no one ever updated it
09:52:08 <LordAro> it's a wiki
10:01:11 <pickpacket> yeah, but why placed under "archive"?
10:01:29 <LordAro> everything was archived when the wiki was migrated from the old mediawiki instance
10:01:40 <pickpacket> ah! That explains it
10:09:04 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #15295: Codechange: remove GetAcceptanceAroundTiles always_accepted out parameter https://github.com/OpenTTD/OpenTTD/pull/15295
10:43:15 <xarick> it's taking longer and longer to build master
10:43:27 <xarick> i suspect documenting everything slows it down
10:46:25 <xarick> okay, now testing Smooth economy instead of Frozen, game starts with 20,283 industries
10:49:01 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1473270003368329331/image.png?ex=6995991c&is=6994479c&hm=6c592616576798043e5b3ddc9ac76d914386ccb2a05f5a424dc8200dda7b7572&
10:49:01 <xarick> eh, strange to see the "Income Graph" to display the negative scale
10:59:31 <Zathras_7> you should can your manager then :D
11:16:56 <LordAro> xarick: not perceptably
11:35:11 <peter1138> It's all the nasty templates we use ;)
11:35:50 <LordAro> peter1138: so my commuter/winter bike is knackered
11:36:02 <LordAro> fork corrosion has gotten bad enough that it probably should be replaced
11:36:35 <peter1138> Oh dear.
11:36:48 <LordAro> https://quellabicycle.com/products/nero-black-courier-fixed-gear-bike?variant=44358835699927 please tell me that this is a terrible idea
11:38:30 <peter1138> Yes. Brake levers are in an awful position.
11:38:37 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1473282486858547312/2026-02-17_11-35-311.mp4?ex=6995a4bd&is=6994533d&hm=34038227d99970517be0116d0ce2f97ebdfadfef0073f86cc27bfc7b3f76ddbf&
11:38:37 <xarick> too slow for my liking
11:39:22 <xarick> kdtree for scripts when?
11:39:56 <_jgr_> You could write one of those in squirrel if you wanted
11:40:28 <xarick> hmm sounds like a plan
11:55:01 <xarick> oh, maybe it's not quite kdtree what i need
11:55:20 <xarick> <https://gist.github.com/SamuXarick/5fccafd8453aeaed32ca2d3c37149f24#file-main-nut-L53-L65>
11:56:01 <xarick> i dont want just the closest
11:56:13 <xarick> i want multiple closests
12:04:15 <_jgr_> It is not surprising that this is slow when there are many pointless uses of Valuate and the number of evaluations of the highlighted loop is the number of industries x the number of airports
12:04:51 <_jgr_> Doing everything using Valuate and bulk list operations is likely to far slower and more inefficient than just writing normal style code
12:05:28 <xarick> gonna add a break there
12:06:05 <xarick> AILists only have unique items and im trying to add heliport_location multiple times
12:06:14 <xarick> dang, im a bit slow
12:07:31 <andythenorth_> I have a 2004 ish steel framed Marin Muir Woods I should sell for restoration πŸ˜›
12:08:01 <andythenorth_> Was a phenomenal commute bike
12:08:45 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1473290067861835950/2026-02-17_12-08-15.mp4?ex=6995abcc&is=69945a4c&hm=e7233e58a85ac14415be8c8d0c4af00834bc16bc93fd9c8e780958464b2da469&
12:08:45 <xarick> lol, problem solved! It was me after all
12:10:41 <xarick> it's not quite what I wanted, but all things considered, I prefer it this way
13:33:57 <andythenorth_> Lunch?
14:40:56 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1473328368350134303/Unnamed_1978-01-01.png?ex=6995cf78&is=69947df8&hm=387878323728f162acec6484eb574cf5efac6a3cdede75b278d6e83bf0b7e8b1&
14:40:56 <xarick> game started in 1928, with 20,283 industries, 50 years later, with Smooth Economy, it's at 16,345
14:42:22 <xarick> industry density with Frozen Economy would put this at 28k
14:42:30 <xarick> got to investigate
14:53:57 <andythenorth_> Such 🫠
14:54:24 <andythenorth_> What is there to investigate? :)
14:55:21 <xarick> it doesn't stop rising
14:55:39 <xarick> and since they're frozen, they never poof
14:56:30 <xarick> i was expecting a hard cap at around 20k
14:58:35 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1473332809547649085/image.png?ex=6995d39a&is=6994821a&hm=a860fe4b77c6926b9953c365be406ee4eca8abd5de8be51e9298ec11fd01ef04&
14:58:35 <xarick> 256x256 map, started with 80 industries
14:58:56 <xarick> ends with 283
15:01:21 <andythenorth_> Yes the game just keeps building them
15:01:45 <_glx_> frozen economy just affects production changes, if you don't want the game to build industries switch them to fund only
15:02:18 <andythenorth_> The settings for industries are a bit like the honer simpson spiders gif
15:02:27 <andythenorth_> Homer *
15:03:07 <andythenorth_> It would be nice to rework them one day, but then….flaming torches :)
15:04:36 *** Wormnest has joined #openttd
15:07:31 <andythenorth_> 3 types of economy, plus density, plus funding only
15:07:42 <andythenorth_> Plus whatever silly FIRS does
15:14:20 <rito12_51026> How long is "period"?
15:16:25 <talltyler> 12 minutes
15:16:48 <talltyler> 12 economy minutes, specifically. In calendar timekeeping mode you'd call it a year.
15:18:47 <DorpsGek> [OpenTTD/OpenGFX2] LordAro approved pull request #247: Fix: Incorrect toyland house coding https://github.com/OpenTTD/OpenGFX2/pull/247#pullrequestreview-3814585955
15:19:45 <DorpsGek> [OpenTTD/OpenGFX2] LordAro approved pull request #246: Fix: Stray almost blue pixels in 4x tropical foundations https://github.com/OpenTTD/OpenGFX2/pull/246#pullrequestreview-3814592139
15:23:08 <DorpsGek> [OpenTTD/OpenGFX2] LordAro approved pull request #234: Feature: 4x zoom factory https://github.com/OpenTTD/OpenGFX2/pull/234#pullrequestreview-3814615303
15:23:59 <DorpsGek> [OpenTTD/OpenGFX2] LordAro approved pull request #232: Feature: 4x zoom coal mine https://github.com/OpenTTD/OpenGFX2/pull/232#pullrequestreview-3814620419
15:25:10 <DorpsGek> [OpenTTD/OpenGFX2] LordAro commented on pull request #238: Fix: Make sea level locks aware of neighbouring canals https://github.com/OpenTTD/OpenGFX2/pull/238#issuecomment-3915362323
15:43:11 <xarick> industry density isn't respected anymore?
15:44:23 <xarick> how does timer_game_economy work, who set it up to trigger?
16:04:25 <xarick> wanted_inds keeps increasing
16:04:38 <xarick> 80, 81, 82, 83... why
16:06:54 *** MinchinWeb[m] has quit IRC (Ping timeout: 480 seconds)
16:09:09 *** MinchinWeb[m] has joined #openttd
16:12:03 <xarick> oh, found it
16:12:05 <xarick> <https://github.com/OpenTTD/OpenTTD/blob/master/src/industry_cmd.cpp#L2451-L2463>
16:14:13 <xarick> weird magic going on
16:19:19 <xarick> if (81 + 4 >= 83) { weird number += another weird number } but it's still 83
16:22:13 <xarick> <https://github.com/OpenTTD/OpenTTD/blob/master/src/industry_cmd.cpp#L3112-L3115>
16:23:41 <xarick> min(9, 3 + 83 - 81)
16:24:35 <_glx_> that's 5% chance to create a new industry
16:24:52 <xarick> there's the change_loop still
16:26:44 <xarick> i think the math isn't mathing correctly, if it just keeps increasing
16:26:55 <xarick> it should stop at some point
16:27:18 <_glx_> change_loop increases then overflows
16:29:36 <_glx_> ah no it's reset every time at line 3102
16:31:13 <_glx_> so I think change_loop is only 0 or 1, maybe 2 but probably not
16:34:52 <_glx_> and increment is (1 << map_size) / 31
16:36:35 <xarick> gonna add an assert here, and wait
16:37:38 <DorpsGek> [OpenTTD/OpenGFX2] zephyris commented on pull request #238: Fix: Make sea level locks aware of neighbouring canals https://github.com/OpenTTD/OpenGFX2/pull/238#issuecomment-3915788571
16:38:26 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1473357938776211627/image.png?ex=6995eb02&is=69949982&hm=ec261dab86a375bd6b602c2400608a744dff3dfb7cd03753f35d54d7f802208e&
16:38:26 <xarick> let's see when it asserts, what numbers it will give, if it really asserts
16:38:56 *** Flygon has joined #openttd
16:39:38 <DorpsGek> [OpenTTD/OpenGFX2] mmtunligit commented on pull request #238: Fix: Make sea level locks aware of neighbouring canals https://github.com/OpenTTD/OpenGFX2/pull/238#issuecomment-3915799470
16:41:44 <_glx_> ok one a 4x*4k map, change_loop is always at least 8
16:43:36 <_glx_> because `_economy.industry_daily_increment = (1 << map_size) / 31;` is `(1<<24) / 31 = 0x84210`
16:49:28 <_glx_> for 4kx2k it's at least 4, for 2kx2k at least 2, 1 for 2kx1k, and under 1kx1k it needs more than one day to go to at least 1
16:50:42 <_glx_> so huge maps can get a lot of new industries, even with a 3% chance
17:08:21 <xarick> it asserted at when there was 207 industries in map
17:08:28 <xarick> on a 256x256 map
17:08:34 <xarick> density high
17:11:06 <xarick> the daily loop is still running though, i wonder if more than 207 spawn
17:13:00 <xarick> wow, 208
17:25:05 *** Pricilla[m] has joined #openttd
17:25:28 <Pricilla[m]> Hello πŸ‘‹ everyone
17:25:53 <jfkuayue> *left the IRC channel*
17:26:04 <jfkuayue> lunch?
17:34:03 <xarick> which industry is industry type 12?
17:35:36 <Rubidium> ENOTENOUGHCONTEXT
17:36:15 <xarick> :)
17:36:28 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1473372541233139735/image.png?ex=6995f89b&is=6994a71b&hm=63b2f22f22b1718c3c2c6ce900e997134a66edbbafb4fe5c32832939745ebd6c&
17:36:28 <xarick> this looks strange though
17:37:34 <xarick> or whatever, maybe not
17:40:17 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #15295: Codechange: remove GetAcceptanceAroundTiles always_accepted out parameter https://github.com/OpenTTD/OpenTTD/pull/15295#pullrequestreview-3815360225
17:49:12 *** Wolf01 has joined #openttd
18:13:36 <xarick> strange how all this works
18:29:15 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1473385825206272229/image.png?ex=699604fa&is=6994b37a&hm=15b4dbf14044f9ba7743a6a2c8a5c911281f7364c2e04309eef3850ea780d14b&
18:29:15 <xarick> tried to reduce the max_behind by 1.. not much of a gain
18:34:07 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1473387051004198945/image.png?ex=6996061f&is=6994b49f&hm=6d52c343e3be622de3640f2bef144c7a3217bded8d264bdd501bdbb7e5f01e5b&
18:34:07 <xarick> reduced max_behind by 2:
18:34:07 <xarick> much better i guess
18:34:39 <xarick> the aim was 80 but still...
18:35:20 <andythenorth_> Wonder when these improvements forcthe uncommon case impair the common case? :)
18:35:32 <andythenorth_> For the *
18:36:05 <xarick> there's still some daily checks going on which can still generate a new industry
18:36:10 <andythenorth_> like when providing more threads increases cache misses
18:36:25 <xarick> this is some elaborate algorithm
18:39:12 <xarick> then each industry type has a random generated `target_count` and compares against the real number of industries of that type already on the map. If it falls short, it's going to spawn it
18:40:42 <xarick> until all target_counts are met, it's still going to generate new industries... way past the expected density amount i guess
18:45:09 <xarick> well, this ain't working
18:46:04 <xarick> it's chasing a moving goal
18:46:15 <xarick> just keeps spawning new industries no matter
18:48:40 <xarick> alright, it stopped at 253
18:50:21 <xarick> oh crap, 254
19:09:27 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #15296: Codechange: add missing parameter/return documentation to NewGRF code https://github.com/OpenTTD/OpenTTD/pull/15296
19:14:59 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #15295: Codechange: remove GetAcceptanceAroundTiles always_accepted out parameter https://github.com/OpenTTD/OpenTTD/pull/15295
19:20:13 *** Extrems has quit IRC (Quit: ZNC 1.7.5 - https://znc.in)
19:20:17 *** Extrems has joined #openttd
19:27:56 <DorpsGek> [OpenTTD/OpenTTD] macbook-girl opened issue #15297: request: macOS version https://github.com/OpenTTD/OpenTTD/issues/15297
19:30:13 <DorpsGek> [OpenTTD/OpenTTD] mmtunligit commented on issue #15297: request: macOS version https://github.com/OpenTTD/OpenTTD/issues/15297
19:30:49 <xarick> gonna give up on this
19:31:03 <xarick> frozen economy eludes me
19:39:49 <peter1138> Wut
19:52:25 *** MinchinWeb[m] has quit IRC (Remote host closed the connection)
19:53:20 *** MinchinWeb[m] has joined #openttd
19:58:48 <andythenorth_> Me too
19:59:53 <DorpsGek> [OpenTTD/OpenTTD] zephyris closed issue #15297: request: macOS version https://github.com/OpenTTD/OpenTTD/issues/15297
19:59:53 <andythenorth_> I don’t mind the mutual support group adpect of the project, but it would be nice to have an actual development channel separate from the rabbit holes :p
19:59:56 <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on issue #15297: request: macOS version https://github.com/OpenTTD/OpenTTD/issues/15297
20:00:08 <andythenorth_> I mostly moved grf chat to other channels
20:00:38 <andythenorth_> Although I quit discord for a bit so apologies for grf chat in advance :|
20:08:28 <talltyler> Discord has a development-forum where GRF developers can post their own threads, like a regular forum πŸ™‚
20:17:55 <peter1138> tt-forums has a forum for, uh... well, it's a forum, so.
20:26:15 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #15298: Codechange: document parameters and return types https://github.com/OpenTTD/OpenTTD/pull/15298
20:36:07 <xarick> how do i get the industry id of an industry when i only have the location of its station
20:36:30 <xarick> ScriptIndustry::GetIndustryID not that smart :(
20:37:16 <rito12_51026> Is `if constexpr` a selection or iteration statements?
20:37:18 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #15298: Codechange: document parameters and return types https://github.com/OpenTTD/OpenTTD/pull/15298#pullrequestreview-3816170171
20:40:07 <LordAro> https://en.cppreference.com/w/cpp/language/if.html
20:44:51 <rito12_51026> So debug_inline can't be used with it
20:44:54 <rito12_51026> Can template specialization be used with debug_inline? The comment before debug_inline does not say anything about templates
20:46:22 <Rubidium> question #1 regarding debug_inline is: have you proven, by profile, that debug performance is attrocious because of that function you want to add debug_inline to?
20:47:35 <DorpsGek> [OpenTTD/OpenTTD] aligator commented on discussion #14351: Ability to join a new company without authorized users online https://github.com/OpenTTD/OpenTTD/discussions/14351
20:48:36 <rito12_51026> No, but it will be called by multiple functions that currently have debug_inline
20:52:01 <Rubidium> sounds like that'd make the functions maybe not that trivial anymore. Nevertheless, you can try if it works. And remember it's only an attempt to not create atrociously slow debug binaries without exploding build time
21:00:41 <DorpsGek> [OpenTTD/OpenTTD] aligator commented on discussion #14351: Ability to join a new company without authorized users online https://github.com/OpenTTD/OpenTTD/discussions/14351
21:05:21 *** gelignite has joined #openttd
21:10:36 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #15299: Codechange: document a few parameter and return types https://github.com/OpenTTD/OpenTTD/pull/15299
21:11:25 <mmtunligit> what even was the impetus for removing company passwords? i remeber hearing something about people potentially using their one password they used for everything, but if thats the only real issue, why not just have a password generated on company founding that cant be changed? have it be like 8 characters long so its not (trivially) brute forceable but also easy to type in. you could even combine
21:11:25 <mmtunligit> that with user auth stuff so it doesnt need to be typed in on every join
21:21:06 <Rubidium> 1) our refusal to store passwords in savegames, as that'd mean anybody can do offline password attacks. 2) server reload/restarts where all companys become fully open because of #1
21:22:32 <Rubidium> also https://github.com/OpenTTD/OpenTTD/discussions/8420
21:23:42 <Rubidium> what is basically 'needed' from that is the 'friends list'. Then I think there aren't many problems. But that requires someone to want to put the effort into creating an usable UI for that
21:24:22 <mmtunligit> ah gotcha
21:33:10 *** gelignite is now known as Guest3005
21:33:14 *** gelignite has joined #openttd
21:38:20 *** Guest3005 has quit IRC (Ping timeout: 480 seconds)
21:39:24 <peter1138> Well.
21:40:05 <rito12_51026> Rubidium: I thought about it and I got to the conclusion that same or maybe faster result I can get from utilizing class inheritance and implicit constructors, although it might be less clear code
21:41:38 <peter1138> What needs tob be faster?
21:42:31 <Rubidium> rito12_51026: I'm not quite sure what the exact context is you're thinking about. I toiled with class inheritance for TileTypeProcs and whatever I tried, I had two pointer dereferences compared to only one for the table-based lookup.
21:49:04 <rito12_51026> I was thinking about Tile class and accessing multiple storages https://github.com/Rito13/OpenTTD/commit/a45d68dbececd49e6d4f276a66dc41d54a697812
21:56:35 <xarick> <`local list = AIVehicleList_Station(AIStation.GetStationID(industry_list.GetValue(i)), AIVehicle.VT_AIR);`>
21:56:35 <xarick> this is spiky :(
21:58:09 <xarick> ok, it's just the AIVehicleList_Station part
22:01:26 <rito12_51026> Besically https://github.com/michicc/OpenTTD/commit/6a17c37c660e09ba32ccb4e2a9b01f46e4f05a2e#diff-6343dc379195882c780886f331b31f53e3bb113a25bafd10550c410904117eac and the previous commit but with handling of using the corect tile within the _map.h files
22:01:29 <rito12_51026> Uh, It is getting late, good night πŸ™‚
22:01:33 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1473439251155648664/image.png?ex=699636bc&is=6994e53c&hm=37a6d93ad5f3098dda27978101a7fd8af8226ee4edddf9d72a6247aca42aa28e&
22:01:33 <xarick> the darned vehicle list
22:01:52 <xarick> those valuates spike at 5 ms
22:01:55 <xarick> combined
22:02:12 <xarick> AIVehicleList_Station puts it at 130 ms
22:04:57 *** gelignite is now known as Guest3009
22:05:01 *** gelignite has joined #openttd
22:06:23 <Rubidium> rito12_51026: looks like a lot more pointer dereferences, but ofcourse it's hard to predict what the impact of that is going to be
22:07:02 <Rubidium> in any case, debug_inline doesn't matter for now as it doesn't impact the compiler with optimisations turned on, and that's the way you need to check the actual performance impact
22:11:05 <Rubidium> also https://github.com/OpenTTD/OpenTTD/compare/master...Rito13:OpenTTD:new_map_2#diff-6343dc379195882c780886f331b31f53e3bb113a25bafd10550c410904117eacR61 looks suspect (I'd suspect a | instead of &). Consider using EnumBitSet there, as then you can use the initializer_list constructor.
22:11:31 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #15298: Codechange: document parameters and return types https://github.com/OpenTTD/OpenTTD/pull/15298
22:11:41 *** Guest3009 has quit IRC (Ping timeout: 480 seconds)
22:14:03 *** locosage has joined #openttd
22:14:03 <locosage> is there some way to allow player into company automatically?
22:14:07 <locosage> like command or gs api?
22:15:13 <locosage> other than move command
22:23:19 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
22:23:42 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #15300: Codechange: use enum class for DriverType and DistributionType enums https://github.com/OpenTTD/OpenTTD/pull/15300
22:27:41 *** gelignite has quit IRC ()
22:31:24 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #15184: Add: Record history of cargo delivered to towns https://github.com/OpenTTD/OpenTTD/pull/15184
22:36:03 <_glx_> xarick: and this constructor uses FindVehiclesWithOrder which is already better than what it used to be
22:37:03 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #15299: Codechange: document a few parameter and return types https://github.com/OpenTTD/OpenTTD/pull/15299#pullrequestreview-3816640985
22:38:33 <_glx_> that's what happens when there's too many objects in game
22:42:44 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #15300: Codechange: use enum class for DriverType and DistributionType enums https://github.com/OpenTTD/OpenTTD/pull/15300#pullrequestreview-3816674086
22:45:57 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #15300: Codechange: use enum class for DriverType and DistributionType enums https://github.com/OpenTTD/OpenTTD/pull/15300#pullrequestreview-3816686706
22:51:06 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1473451722121678940/image.png?ex=69964259&is=6994f0d9&hm=b9d2ec6cc6e1b516d866f652534440121076d428c58e775c6b00a75e73ea8246&
22:51:06 <xarick> eh, i missed something
22:51:46 <xarick> ah, i see, it's a recent commit
22:53:45 <xarick> will stringIds be enum class'ed?
22:53:49 <xarick> StringID
23:07:21 *** lobster has quit IRC (Read error: Connection reset by peer)
23:07:34 *** lobster has joined #openttd
23:22:22 <peter1138> StringID isn't an enum.
23:24:10 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1473460042895462415/image.png?ex=69964a19&is=6994f899&hm=d6df07dda1d86b2b3064dd883ead15fbb22b89779593b09a78b963d8646bd221&
23:24:10 <xarick> _glx_: <https://github.com/OpenTTD/OpenTTD/compare/master...SamuXarick:OpenTTD:group-vehicle-list> will you even consider this as a PR? None of the aircraft have shared orders, and yet there's still a gain with those changes.
23:25:15 <xarick> or could you cook something up from that branch...
23:25:18 <xarick> do some magic
23:26:59 <xarick> oh btw the build is release at top vs relwithdebinfo at bot
23:27:17 <xarick> would be even better is both were release
23:30:26 <xarick> those peaks are from AIVehicleList_Station, just to clarify
23:33:27 <_glx_> yes there are too many vehicles in game
23:34:15 <xarick> only 1 company, around 4900 aircraft t.t
23:34:56 <xarick> 8700 airports
23:35:21 <xarick> that includes the heliports too
23:40:54 <_glx_> means you're creating vehicle lists 8700 times so huge cpu impact on successive ticks
23:44:49 <_glx_> it's equivalent of a human clicking on "show vehicles using this station" on all stations at the same time