IRC logs for #openttd on OFTC at 2026-01-29
#openttd / 2026 / 01 
            

00:29:20  <DorpsGek> [OpenTTD/OpenTTD] Eilon commented on pull request #15158: Add: Show additional vehicle details based on sort criteria https://github.com/OpenTTD/OpenTTD/pull/15158#issuecomment-3814653184



00:29:40  <DorpsGek> [OpenTTD/OpenTTD] Eilon updated pull request #15158: Add: Show additional vehicle details based on sort criteria https://github.com/OpenTTD/OpenTTD/pull/15158



00:32:53  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened pull request #15189: Change: Allow subsidies with CargoDist https://github.com/OpenTTD/OpenTTD/pull/15189



01:31:16  *** toktik is now known as Guest736



01:31:23  *** toktik has joined #openttd



01:37:40  *** Guest736 has quit IRC (Ping timeout: 480 seconds)



01:45:49  <talltyler> I'm also working on a PR to scale subsidy distance. The current max of 70 tiles (Manhattan distance) doesn't play well with lower town/industry densities, or with industry sets with lots of cargos and less likelihood that two nearby industries will have a valid cargo to transport. 🙂



01:46:20  <talltyler> Still need to scale based on the number of cargos, but WIP: https://github.com/2TallTyler/OpenTTD/tree/subsidy-scale-density



02:44:39  *** Wormnest has quit IRC (Quit: Leaving)



03:33:33  <DorpsGek> [OpenTTD/OpenTTD] James103 commented on issue #15188: [Bug]: Desync on save+collision https://github.com/OpenTTD/OpenTTD/issues/15188



03:57:48  *** gnu_jj_ has joined #openttd



04:01:06  *** gnu_jj has quit IRC (Ping timeout: 480 seconds)



04:39:47  *** Zathras_7 has joined #openttd



04:43:08  *** Zathras_11 has quit IRC (Ping timeout: 480 seconds)



04:48:28  *** Flygon has quit IRC (Read error: Connection reset by peer)



04:50:56  *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)



04:50:57  *** WormnestAndroid has joined #openttd



04:51:03  *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)



04:51:04  *** WormnestAndroid has joined #openttd



04:51:07  *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)



04:51:08  *** WormnestAndroid has joined #openttd



04:58:53  <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/2bb01bd0e442e45d7d6cd35e18657ee7fc4fe53f



04:58:54  <DorpsGek>   - Update: Translations from eints (by translators)



06:11:51  *** toktik has quit IRC (Remote host closed the connection)



06:12:11  *** toktik has joined #openttd



06:33:35  *** wallabra has quit IRC ()



06:39:34  *** MinchinWeb[m] has quit IRC (Read error: Connection reset by peer)



06:39:50  *** MinchinWeb[m] has joined #openttd



06:49:07  *** wallabra has joined #openttd



06:51:38  <rito12_51026> xarick: It will succeed when either #15182 or #15174 is merged.



07:44:30  <DorpsGek> [OpenTTD/OpenTTD] zephyris merged pull request #15180: Change: Removing river tiles reduce local authority rating https://github.com/OpenTTD/OpenTTD/pull/15180



07:46:48  <peter1138> _zephyris, may I remind you to push to your own fork instead of upstream?



07:58:09  <LordAro> git remote set-url --push origin not-a-url



08:04:27  <_zephyris> OK, sorry about that



08:05:51  <_zephyris> Hmm, I think the github UI did something 'clever' when I was added to the openttd org



08:07:20  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #15184: Add: Record history of cargo delivered to towns https://github.com/OpenTTD/OpenTTD/pull/15184



08:15:09  *** SigHunter has quit IRC (Remote host closed the connection)



08:17:15  *** SigHunter has joined #openttd



08:19:05  <peter1138> Doxygen is not really working well with templated-inheritance, asking me to document functions that don't exist.



08:22:03  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #15184: Add: Record history of cargo delivered to towns https://github.com/OpenTTD/OpenTTD/pull/15184



08:23:04  <LordAro> :(



08:29:42  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #15184: Add: Record history of cargo delivered to towns https://github.com/OpenTTD/OpenTTD/pull/15184



08:30:49  <peter1138> Well, they exist in the binary due to being a template 'instance', but don't exist in the source.



08:31:33  <LordAro> well it's not like doxygen operates on the binary...



08:32:13  <peter1138> No.



08:33:02  <LordAro> depending how much time you want to spend on it, maybe worth looking for a config option or appropriate doxygen issues?



08:34:17  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #15182: Codechange: [CI] Sort doxygen warnings in docs checker. https://github.com/OpenTTD/OpenTTD/pull/15182#issuecomment-3816248488



08:51:59  <Rubidium> I think we shouldn't be too pedantic with the doxygen warnings, as long as we don't make it objectively worse



08:56:04  <peter1138> Well, I cannot document the things it is asking for in #15184. Documenting constructors with one parameter is pretty pedantic but is at least doable.



08:56:48  <peter1138> Hmm, maybe I can.



08:58:12  <peter1138> Hmm, no I can't.



09:22:56  *** lobstarooo has quit IRC (Read error: Connection reset by peer)



09:23:33  *** lobster has joined #openttd



09:33:05  <Rubidium> it's a bit like CodeQL starting to complain about things that you didn't actively touch; we can just ignore those doxygen warnings for that PR. Unless someone decides to make it a requirement for that check to pass



09:35:20  <DorpsGek> [OpenTTD/OpenTTD] zephyris updated pull request #15176: Change: Protect rivers from removal when terraforming https://github.com/OpenTTD/OpenTTD/pull/15176



09:36:05  <_zephyris> (not moved to my fork, but future branches will be!)



09:51:51  <peter1138> TBF I didn't check if it was required or not :)



10:05:27  <peter1138> I installed doxygen, so I do at least get local warnings now, after a rebuild with docs.



10:09:17  <LordAro> i'm not keen on keeping CI jobs that are "expected fail"



10:09:37  <LordAro> _zephyris: just as well as you can't move PR source branches :p



10:10:15  <_zephyris> Yeah, I guessed that would break things



10:37:24  *** lobstarooo has joined #openttd



10:44:31  *** lobster has quit IRC (Ping timeout: 480 seconds)



10:48:01  <peter1138> Yeah, merging stuff with a red mark on it is not ideal.



10:48:18  <LordAro> perhaps rito12_51026 can come up with a solution :)



10:48:35  <LordAro> but otherwise might need binning off, unfortunately



11:17:13  <xarick> https://avatars.githubusercontent.com/u/55058389?v=4 the captain of my heart



11:21:38  <DorpsGek> [OpenTTD/OpenTTD] abi9ail commented on issue #12891: [Bug]: Timetable speed is set to input-1 (not for all values) https://github.com/OpenTTD/OpenTTD/issues/12891



11:31:10  <Rubidium> LordAro: it's not that the doxygen CI job is expected to fail; it should really be the goal to have that not fail. But there are certain cases where the missing documentation somewhere tangentially related causes some flack. rito12_51026 has been fairly responsive to the clear false red flags, so most of them seem to be teething problems



11:42:31  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #15122: Codechange: use scoped enums for timer enumerations, rename one enum https://github.com/OpenTTD/OpenTTD/pull/15122



11:46:55  <rito12_51026> We could use never version, it might help with something.  At least I have never on debian



11:50:28  <peter1138> I don't mind having to retrospectively add missing documentation. But currently it's complaining about things that can't be documented.



11:57:30  <Rubidium> it might be a doxygen bug specific to the version in the CI job as docs.openttd.org seems to be able to document all their sibblings just fine



11:58:40  <LordAro> worth a try



11:59:03  <LordAro> (ideally the checker and the generation would match versions)



11:59:53  <_glx_> They don't use the same image?



12:09:28  <Rubidium> oh... on docs.openttd.org, if you click on DefaultSaveLoadHandler<SlCompanyEconomy, CompanyProperties> on https://docs.openttd.org/source/d0/de2/classSaveLoadHandler it'll redirect to DefaultSaveLoadHandler<TImpl, TObject> and there it's shown all fine. In the nightly doxygen logs the same sort of errors are shown



12:16:15  <DorpsGek> [OpenTTD/OpenTTD] abi9ail opened pull request #15190: Fix #15137: Roads built on steep slopes at the minimum snow level height have inconsistent snowiness https://github.com/OpenTTD/OpenTTD/pull/15190



12:16:18  <Rubidium> it looks a bit like https://github.com/doxygen/doxygen/issues/11095, which is said the be fixed in 1.13. The nightly docs and CI docs check runners are Ubuntu noble / doxygen 1.9.8, so a newer doxygen might help there.



12:26:49  <rito12_51026> rito12_51026: But I have downloaded it from https://www.doxygen.nl/download.html instead of using apt



12:27:14  <rito12_51026> There is 1.16 now



12:29:52  <peter1138> No backports for Debian :(



12:30:13  <Rubidium> rito12_51026: does that have warnings like "warning: Member GetDescription() const override (function) of class DefaultSaveLoadHandler< SlCompanyEconomy, CompanyProperties > is not documented."?



12:36:34  <rito12_51026> No idea I'm currently skiing and have no access to PC



12:39:02  <rito12_51026> Sorry



12:44:40  <rito12_51026> But I have 1.16.1 on mobile and I see things like /data/data/com.termux/files/home/OpenTTD/src/dropdo



12:44:40  <rito12_51026> wn_common_type.h:132: warning: Member Height() cons



12:44:40  <rito12_51026> t override (function) of class DropDownIcon< DropDo



12:44:40  <rito12_51026> wnIcon< DropDownString< DropDownListItem >, true >



12:44:40  <rito12_51026> > is not documented.



12:45:58  <peter1138> That one is possibly due to CRTP, and is different situation because it can be documented.



12:46:28  <peter1138> The SaveLoadHandler situationne is different



12:46:32  <peter1138> -ne



12:52:48  <peter1138> Hmm, may have a workaround.



13:12:26  <DorpsGek> [OpenTTD/OpenTTD] zephyris opened pull request #15191: Add [NewGRF]: Nearby tile and improved cargo history variables for towns https://github.com/OpenTTD/OpenTTD/pull/15191



13:15:21  <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on pull request #15191: Add [NewGRF]: Nearby tile and improved cargo history variables for towns https://github.com/OpenTTD/OpenTTD/pull/15191#issuecomment-3817633648



13:15:38  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #15191: Add [NewGRF]: Nearby tile and improved cargo history variables for towns https://github.com/OpenTTD/OpenTTD/pull/15191#issuecomment-3817635503



13:18:29  <xarick> hi



13:24:42  <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on pull request #15191: Add [NewGRF]: Nearby tile and improved cargo history variables for towns https://github.com/OpenTTD/OpenTTD/pull/15191#issuecomment-3817679569



13:24:54  <DorpsGek> [OpenTTD/OpenTTD] Ryrn0475 opened issue #15192: [Bug]: Cloning changes "end of orders" to "End of shared orders" https://github.com/OpenTTD/OpenTTD/issues/15192



13:29:14  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #15192: [Bug]: Cloning changes "end of orders" to "End of shared orders" https://github.com/OpenTTD/OpenTTD/issues/15192



13:31:34  <DorpsGek> [OpenTTD/OpenTTD] EmperorJake commented on issue #15192: [Bug]: Cloning changes "end of orders" to "End of shared orders" https://github.com/OpenTTD/OpenTTD/issues/15192



13:31:44  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #15192: [Bug]: Cloning changes "end of orders" to "End of shared orders" https://github.com/OpenTTD/OpenTTD/issues/15192



13:31:47  <peter1138> Heh



13:36:29  <_zephyris> Isn't the real issue that there is no way to clone _without_ shared orders, when the clone with shared orders setting is enabled?



13:37:43  <peter1138> No?



13:37:55  <peter1138> It only depends on whether Ctrl is pressed, not whether it's previous shared or not.



13:37:59  <peter1138> +ly



13:38:37  <emperorjake> There's a setting for cloning with shared orders? I can't see anything like that



13:39:27  <peter1138> There's no setting for it.



13:42:01  <_zephyris> Oh, I thought there was, must be imagining things



13:44:31  <DorpsGek> [OpenTTD/OpenTTD] mmtunligit opened pull request #15193: Feature: Placing random houses from collections https://github.com/OpenTTD/OpenTTD/pull/15193



13:46:20  *** Wormnest has joined #openttd



13:52:16  <DorpsGek> [OpenTTD/OpenTTD] mmtunligit updated pull request #15193: Feature: Placing random houses from collections https://github.com/OpenTTD/OpenTTD/pull/15193



13:52:44  <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #15191: Add [NewGRF]: Nearby tile and improved cargo history variables for towns https://github.com/OpenTTD/OpenTTD/pull/15191#pullrequestreview-3722871762



13:53:25  <DorpsGek> [OpenTTD/OpenTTD] Ryrn0475 commented on issue #15192: [Bug]: Cloning changes "end of orders" to "End of shared orders" https://github.com/OpenTTD/OpenTTD/issues/15192



13:58:20  <DorpsGek> [OpenTTD/OpenTTD] zephyris closed pull request #15191: Add [NewGRF]: Nearby tile and improved cargo history variables for towns https://github.com/OpenTTD/OpenTTD/pull/15191



14:05:40  <DorpsGek> [OpenTTD/OpenTTD] zephyris opened pull request #15194: Add: [NewGRF] Nearby tile info for towns https://github.com/OpenTTD/OpenTTD/pull/15194



14:07:37  <DorpsGek> [OpenTTD/OpenTTD] zephyris opened pull request #15195: Add: [NewGRF] Town production and transport by cargo ID https://github.com/OpenTTD/OpenTTD/pull/15195



14:09:27  <_zephyris> Hopefully I split that up right



14:11:55  *** mika007007 has joined #openttd



14:12:52  *** mika007007 has quit IRC ()



14:32:00  <peter1138> Well, you didn't need to close the original, just move bits out, but okay :)



14:48:17  <jfkuayue> https://cdn.discordapp.com/attachments/1008473233844097104/1466444847647953060/image.png?ex=697cc4b0&is=697b7330&hm=ff3fb9c338e44cdf0904626534d964e5f57fb08f5570df4acd85d61172504b60&



14:48:17  <jfkuayue> ohno 🙁



15:25:27  *** Flygon has joined #openttd



15:39:33  <Rubidium> not that I pretend to understand the British education system, but... it seems convoluted. Or I'm reading it too literally... like: getting First-Class honours implies you cannot join, right? Likewise I'm assuming the school year ends early summer, you must respond with some evidence about your final grade but the deadline to respond to that offer is end of February. Like... are you supposed to have a 



15:39:39  <Rubidium> gap year?



15:43:34  <_zephyris> It says 2.1 or above, and universities often issue predicted grades



15:43:45  <_zephyris> Worth talking to academic advisors etc.



15:44:30  <_zephyris> Get past the robot email, try to find a person to talk to



16:38:58  <peter1138> Hm.



16:41:39  *** MinchinWeb[m] has quit IRC (Ping timeout: 480 seconds)



16:42:37  *** MinchinWeb[m] has joined #openttd



16:54:41  <rito12_51026> Rubidium: When I checkout to  #15184 no warnings with "DefaultSaveLoadHandler"  appear, so it seems to be fixed in latest doxygen



17:28:53  <andythenorth[d]> 65% or above is nearly a first



17:29:09  <jfkuayue> Rubidium: The "respond" in "deadline to respond" is just "accept" or "decline",



17:29:09  <jfkuayue> ```if accept; if avarage >= 65; admitted; done```



17:29:10  <andythenorth[d]> this is irrelevant, I'm just talking



17:30:53  <jfkuayue> Wait IRC cannot see edited messages



17:31:00  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #15184: Add: Record history of cargo delivered to towns https://github.com/OpenTTD/OpenTTD/pull/15184



17:35:19  *** Wormnest has quit IRC (Ping timeout: 480 seconds)



17:41:30  <andythenorth[d]> lunch though?



17:46:19  *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)



17:47:52  *** WormnestAndroid has joined #openttd



17:50:25  <jfkuayue> I started to think tesco ready meals "delicious"



17:52:03  <LordAro> sounds like you're a proper student now



18:11:16  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #15181: Codechange: Add sorter for doxygen warnings. https://github.com/OpenTTD/OpenTTD/pull/15181#pullrequestreview-3724290252



18:12:55  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #15182: Codechange: [CI] Sort doxygen warnings in docs checker. https://github.com/OpenTTD/OpenTTD/pull/15182#issuecomment-3819371347



18:14:21  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #15187: Fix: Station view window fold/unfold not refreshing scrollbar https://github.com/OpenTTD/OpenTTD/pull/15187



18:17:33  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #15036: Codechange: move 'out' parameters of GetVehicleFromDepotWndPt to the returned value https://github.com/OpenTTD/OpenTTD/pull/15036



18:20:31  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #15036: Codechange: move 'out' parameters of GetVehicleFromDepotWndPt to the returned value https://github.com/OpenTTD/OpenTTD/pull/15036



18:22:16  <peter1138> Yeah, that hack worked for #15184.



18:33:10  <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #15036: Codechange: move 'out' parameters of GetVehicleFromDepotWndPt to the returned value https://github.com/OpenTTD/OpenTTD/pull/15036#pullrequestreview-3724374770



18:44:45  *** Zathras_7 has quit IRC (Quit: Initiating getting-the-hell-out-of-here maneuver!)



18:47:05  *** Zathras_4 has joined #openttd



19:03:58  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #15036: Codechange: move 'out' parameters of GetVehicleFromDepotWndPt to the returned value https://github.com/OpenTTD/OpenTTD/pull/15036



19:18:02  <DorpsGek> [OpenTTD/OpenTTD] zephyris approved pull request #15190: Fix #15137: Roads built on steep slopes at the minimum snow level height have inconsistent snowiness https://github.com/OpenTTD/OpenTTD/pull/15190#pullrequestreview-3724540950



19:24:45  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #15196: Codefix: remove implicit LaTeX dependency https://github.com/OpenTTD/OpenTTD/pull/15196



19:31:21  <_zephyris> Which hack do you mean? `if (accepted_total - accepted_ind > 0)`?



19:36:56  *** Wolf01 has joined #openttd



19:39:21  <LordAro> Rubidium: hilarious



19:47:35  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1466520171832283228/image.png?ex=697d0ad7&is=697bb957&hm=bd4d9682fe80f23a42a4b03976b7ec3ca98c25275c9af940819f865f78431d31&



19:48:10  <xarick> can "we" blacklist some AIs?



19:48:45  <DorpsGek> [OpenTTD/OpenTTD] BabylonAS commented on issue #14035: [Bug]: OpenTTD does not consider FluidSynth config https://github.com/OpenTTD/OpenTTD/issues/14035



19:49:04  <xarick> controversial topic



19:50:45  <peter1138> _zephyris, no, the doxygen stuff :)



19:50:48  <_zephyris> Better to add info about date of last update and/or number of users and/or similar



19:51:32  <_zephyris> Manual blocking requires curation time and would make mistakes which would (understandly) annoy people



19:51:59  <xarick> MacroEcon doesn't even compile, it's not listed once downloaded



19:52:43  <xarick> but bananas happily accepted it



19:55:19  <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #15196: Codefix: remove implicit LaTeX dependency https://github.com/OpenTTD/OpenTTD/pull/15196#pullrequestreview-3724717050



19:58:36  *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)



19:59:31  *** WormnestAndroid has joined #openttd



20:04:41  *** Wormnest has joined #openttd



20:40:10  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #15196: Codefix: remove implicit LaTeX dependency https://github.com/OpenTTD/OpenTTD/pull/15196



20:44:15  *** soylent_cow[m] has quit IRC (Ping timeout: 480 seconds)



20:44:30  *** Heiki has quit IRC (Ping timeout: 480 seconds)



20:44:30  *** Binette[m] has quit IRC (Ping timeout: 480 seconds)



20:55:21  *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)



20:55:23  *** WormnestAndroid has joined #openttd



21:04:33  <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on discussion #12281: NewGRF House Spec Improvements https://github.com/OpenTTD/OpenTTD/discussions/12281



21:05:16  <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on discussion #12281: NewGRF House Spec Improvements https://github.com/OpenTTD/OpenTTD/discussions/12281



21:49:20  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #15197: Codefix: improve Command docs https://github.com/OpenTTD/OpenTTD/pull/15197



22:01:03  <DorpsGek> [OpenTTD/OpenTTD] zephyris opened pull request #15198: Add: [NewGRF] Town road layout https://github.com/OpenTTD/OpenTTD/pull/15198



22:02:54  <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on pull request #15198: Add: [NewGRF] Town road layout https://github.com/OpenTTD/OpenTTD/pull/15198#issuecomment-3820663145



22:11:45  <_zephyris> I think I'm done... except for maybe number of stations near a town? Not sure how expensive `town->stations_near` would be...



22:13:15  *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)



22:15:06  <peter1138> Cheap.



22:15:23  <peter1138> std::size(town->stations_near)



22:21:51  <_zephyris> OK, tempting



22:28:46  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #15197: Codefix: improve Command docs https://github.com/OpenTTD/OpenTTD/pull/15197#pullrequestreview-3725351367



22:33:45  <andythenorth[d]> naptime?



22:34:18  *** reldred has quit IRC (Quit: User went offline on Discord a while ago)



22:37:41  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened pull request #15199: Change: Scale subsidy distance by town/industry density and cargo amount https://github.com/OpenTTD/OpenTTD/pull/15199



22:37:48  <andythenorth[d]> naptime



22:38:00  <talltyler> Why does Enter create the PR, I was still typing...



22:38:33  <mmtunligit> shift enter by accident? ive hit the enter key while writign PRs plenty



22:38:36  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #15197: Codefix: improve Command docs https://github.com/OpenTTD/OpenTTD/pull/15197



22:39:38  <mmtunligit> trying to understand the endian buffer stuff, why do some things write with `*this << data` while others call `this->write(data)`? or am i just completely misunderstanding things



22:42:06  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #15199: Change: Scale subsidy distance by town/industry density and cargo amount https://github.com/OpenTTD/OpenTTD/pull/15199



22:42:58  <DorpsGek> [OpenTTD/OpenTTD] zephyris opened pull request #15200: Add: [NewGRF] Town number of nearby stations https://github.com/OpenTTD/OpenTTD/pull/15200



22:47:06  <Rubidium> mmtunligit: bear in mind none are doing `*this << data`, but always `*this << data.something`. Though the choice is mostly personal preference I'd say.



22:47:43  <Rubidium> don't try to read too much into it



22:47:46  <mmtunligit> yeah i probably shouldve used foo instead of data



22:48:42  <mmtunligit> so it doesnt matter which one i use then?



22:48:42  <Rubidium> then I still would've said foo.something :D



22:48:55  <mmtunligit> fair enough lol



22:49:40  <Rubidium> not really, but what are you trying to achieve?



22:51:24  <mmtunligit> making a std::vector<T> endian buffer pair so i dont have to deal with the insane compiler weirdness i was getting during my first attempt at roadstop/waypoint randomization



22:52:33  <mmtunligit> i want to do this myself because its a small enough piece of code and i know the outline of what i need to do, but i still need to understand exactly how this all works



22:53:33  <DorpsGek> [OpenTTD/OpenTTD] LordAro reopened issue #14035: [Bug]: OpenTTD does not consider FluidSynth config https://github.com/OpenTTD/OpenTTD/issues/14035



22:53:36  <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on issue #14035: [Bug]: OpenTTD does not consider FluidSynth config https://github.com/OpenTTD/OpenTTD/issues/14035



22:54:46  <Rubidium> mmtunligit: I'd internally use << for that, so you get the benefits of the operator overloads



22:55:33  <mmtunligit> my current understanding is that if the type being written to the buffer written with << it sort of loops through the class until it ends up at something that uses write() because thars where the buffer is actually iterated



22:55:44  <mmtunligit> and i was using << yeah



22:57:49  <Rubidium> (and especially the free function << operator)



22:58:16  <mmtunligit> ```EndianBufferWriter &operator <<(const std::string &data) { return *this << std::string_view{ data }; }



22:58:16  <mmtunligit> EndianBufferWriter &operator <<(const EncodedString &data) { return *this << data.string; }



22:58:16  <mmtunligit> EndianBufferWriter &operator <<(std::string_view data) { this->Write(data); return *this; }```



22:58:16  <mmtunligit> is where i get that from, basically if an encoded string is passed to the buffer writer, it then takes the std::string and passes that to the buffer writer instead, which then gets passed to it again as a string_view which then gets actually written



22:58:42  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #15181: Codechange: Add sorter for doxygen warnings. https://github.com/OpenTTD/OpenTTD/pull/15181



23:00:57  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #15028: Change: Prev/next/first/last railtype hotkeys. https://github.com/OpenTTD/OpenTTD/pull/15028



23:17:16  <DorpsGek> [OpenTTD/OpenTTD] Rito13 updated pull request #15182: Codechange: [CI] Sort doxygen warnings in docs checker. https://github.com/OpenTTD/OpenTTD/pull/15182



23:20:11  <DorpsGek> [OpenTTD/OpenTTD] mmtunligit opened pull request #15201: Codechange: Endian buffer reader/writer for std::vector https://github.com/OpenTTD/OpenTTD/pull/15201



23:21:11  <mmtunligit> there goes nothing



23:24:06  <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #15201: Codechange: Endian buffer reader/writer for std::vector https://github.com/OpenTTD/OpenTTD/pull/15201#pullrequestreview-3725498703



23:26:38  <DorpsGek> [OpenTTD/OpenTTD] mmtunligit updated pull request #15201: Codechange: Endian buffer reader/writer for std::vector https://github.com/OpenTTD/OpenTTD/pull/15201



23:27:09  <mmtunligit> shoulda caught that myself damn



23:31:58  <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on pull request #15201: Codechange: Endian buffer reader/writer for std::vector https://github.com/OpenTTD/OpenTTD/pull/15201#pullrequestreview-3725524571



23:37:28  <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #15201: Codechange: Endian buffer reader/writer for std::vector https://github.com/OpenTTD/OpenTTD/pull/15201#issuecomment-3820942786



23:40:42  <DorpsGek> [OpenTTD/OpenTTD] mmtunligit commented on pull request #15201: Codechange: Endian buffer reader/writer for std::vector https://github.com/OpenTTD/OpenTTD/pull/15201#issuecomment-3820956795



23:42:24  <DorpsGek> [OpenTTD/OpenTTD] mmtunligit commented on pull request #15201: Codechange: Endian buffer reader/writer for std::vector https://github.com/OpenTTD/OpenTTD/pull/15201#pullrequestreview-3725547484



23:48:02  <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #15201: Codechange: Endian buffer reader/writer for std::vector https://github.com/OpenTTD/OpenTTD/pull/15201#pullrequestreview-3725555718



23:49:26  <michi_cc[d]> For the record, I'd slightly prefer not reserving and just checking for buffer end after each element.



23:51:26  <mmtunligit> would that involve changing the writer too? like how the overload for string characters writes an \0 at the end



23:52:13  <michi_cc[d]> Why? I'm not saying to remove the count, just to additionally check for end-of-buffer, too.



23:52:21  <mmtunligit> ahh ok



23:53:33  <michi_cc[d]> And if the count is untrusted data, reserving 2^64 elements is bad, but then most STL libs are quite clever about resize vectors, so it will probably not provide that much benefit anyway.



23:55:21  <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on pull request #15201: Codechange: Endian buffer reader/writer for std::vector https://github.com/OpenTTD/OpenTTD/pull/15201#issuecomment-3821015515



23:56:12  <michi_cc[d]> Yeah, that, too 🙂



23:58:00  <michi_cc[d]> mmtunligit: And FYI, EndianBufferReader::Read probably needs to be modified to increment read_pos even on the buffer-too-short code path, as otherwise any end-of-buffer check for stuff bigger than 1 byte will never trigger.