⏴ go to previous day
00:06:55 <onfirenfs> _jgr_: Maybe I'll have to give this a try. I'll have to look into how to install it on a immutable Linux distro like Bazzite
00:09:19 <onfirenfs> talltyler: I agree. I'm sure I could come up with some other scenarios where a no entry signal would be useful. I don't think it feels that out of place in vanilla either? But that's just my opinion
00:36:29 <DorpsGek> [OpenTTD/OpenTTD] Nusioos opened pull request #14961: (Begginer Fix)Fix aircraft with only depot orders being treated as having valid orders https://github.com/OpenTTD/OpenTTD/pull/14961
00:39:02 <reldred> onfirenfs: You can just extract the generic zip to a folder and run the bin
00:39:03 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
00:39:17 *** WormnestAndroid has joined #openttd
00:39:35 <reldred> I keep it in a folder that’s synchronised with nextcloud client
01:01:38 *** tokai|noir has joined #openttd
01:01:38 *** ChanServ sets mode: +v tokai|noir
01:08:44 *** tokai has quit IRC (Ping timeout: 480 seconds)
01:12:04 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
01:14:12 *** WormnestAndroid has joined #openttd
02:35:47 *** Wormnest has quit IRC (Quit: Leaving)
02:50:44 <DorpsGek> [OpenTTD/OpenTTD] JGRennison opened pull request #14962: Fix #14951: Init and save/load TimerGameEconomy::days_since_last_month https://github.com/OpenTTD/OpenTTD/pull/14962
02:58:57 <DorpsGek> [OpenTTD/OpenTTD] JGRennison opened pull request #14963: Fix #12465: Click/tooltip alignment of industry chain cargo lines https://github.com/OpenTTD/OpenTTD/pull/14963
04:22:07 *** MinchinWeb[m] has quit IRC (Ping timeout: 480 seconds)
04:22:15 *** MinchinWeb[m] has joined #openttd
04:45:25 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/07353973a1ea4fd980ddea45746de0f433fad23f
04:45:26 <DorpsGek> - Update: Translations from eints (by translators)
06:42:13 <rito12_51026> Hi
09:18:51 <DorpsGek> [OpenTTD/OpenTTD] Rito13 updated pull request #14637: Feature: [Script] Allow GS to implement custom engine preview behavior. https://github.com/OpenTTD/OpenTTD/pull/14637
09:20:48 <DorpsGek> [OpenTTD/OpenTTD] Rito13 commented on pull request #14637: Feature: [Script] Allow GS to implement custom engine preview behavior. https://github.com/OpenTTD/OpenTTD/pull/14637#issuecomment-3685880382
09:41:22 *** Borg has joined #openttd
09:54:32 <xarick> hi
09:56:09 *** toktik1 has joined #openttd
09:56:16 *** toktik is now known as Guest34267
09:56:16 *** toktik1 is now known as toktik
09:56:32 *** Guest34267 has quit IRC ()
10:08:37 <peter1138> Well.
11:07:05 <xarick> hmm `Codechange: [Script] Use std::any over std::optional`
11:07:05 <xarick> I was told "No!"
11:07:17 <xarick> but it works
11:09:28 <xarick> Me: "PR?" Everyone else: "No!"
11:09:56 <mmtunligit> "works" and "is the right tool for the job" are not the same thing, iirc no one was denying that it would work, just that it would be horribly messy or something like that
11:10:27 <xarick> what's the right tool?
11:10:37 <xarick> std::optional<void *>?
11:11:20 <xarick> how many variants can std::variant hold?
11:11:27 <xarick> I need 3
11:12:56 <mmtunligit> _glx_: seems to have to do with it making data validation more difficult, and you were suggested/requested to try std::variant first
11:13:40 <mmtunligit> xarick: im sure c++ reference can tell you
11:15:38 <xarick> ok, going to re-do as std::variant, apparently the limit isn't 2
11:19:03 <DorpsGek> [OpenTTD/OpenTTD] Nusioos updated pull request #14961: (Begginer Fix)Fix aircraft with only depot orders being treated as having valid orders https://github.com/OpenTTD/OpenTTD/pull/14961
11:29:43 <rito12_51026> xarick: As many as you need
11:40:21 *** Flygon has quit IRC (Remote host closed the connection)
11:43:12 <xarick> absolutely mouthful expression:
11:43:12 <xarick> `if (disabler.GetOriginalValue() && (!std::holds_alternative<ScriptListMap::iterator>(this->resume_item) || iter != std::get<ScriptListMap::iterator>(this->resume_item)) && ScriptController::GetOpsTillSuspend() < 0) {`
11:49:00 <xarick> so many mistakes :(
12:00:29 <xarick> AddRectangle / RemoveRectangle is a bit different than the other counterparts in ScriptList
12:00:54 <xarick> why it compates iter != begin, and not the resume item?
12:02:26 <_glx_> Because it's an equivalent test
12:03:13 <_glx_> What is the value of begin ?
12:03:28 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
12:03:30 *** WormnestAndroid has joined #openttd
12:03:42 <xarick> begin = this->resume_iter.value();
12:03:48 <xarick> or
12:04:01 <xarick> begin = ta.begin()
12:05:52 <xarick> i shouldn'thave deleted my Add Rectangle tests :(
12:07:33 <_glx_> The iter test is to not suspend in the first iteration
12:08:22 <_glx_> So it always handle at least one item per call
12:11:16 <xarick> GSTile.IsBuildableRectangle is also heavyweight I think
12:16:49 <DorpsGek> [OpenTTD/OpenTTD] Nusioos updated pull request #14961: (Begginer Fix)Fix aircraft with only depot orders being treated as having valid orders https://github.com/OpenTTD/OpenTTD/pull/14961
12:30:51 <andythenorth> well
12:30:53 <andythenorth> lunch?
12:31:19 <peter1138> Yes.
12:35:19 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #14951: [Bug]: TimerGameEconomy::days_since_last_month is not initialised/reset on new game/load/date change https://github.com/OpenTTD/OpenTTD/issues/14951
12:38:18 <Rubidium> xarick: std::optional vs std::any is like fly swatter vs nuclear bomb. A nuclear bomb will kill the fly, but what about the after effects of using it?
12:45:56 <andythenorth> no flies though
12:46:02 <andythenorth> very lots of no flies
12:46:46 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1453005914176229567/image.png?ex=694be0b5&is=694a8f35&hm=85ac70d1dabbb8bf67f876c4bd694a3f2a74e51b34e25976db5ef2523d9e16fd&
12:46:46 <andythenorth> oh
12:47:02 <andythenorth> pff, doesn't even kill the flies, unless they're in immediate blast / heat zone
13:39:58 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1453019302843256953/image.png?ex=694bed2d&is=694a9bad&hm=a1398fe5205682c3ca1da778bb297093ce79a5ad12bf2f22a3fd57b80c06d958&
13:39:58 <xarick> I'm confused
13:40:40 <xarick> `item.first != begin->first` would be the same as `item.first != this->resume_item`?
13:45:21 <_glx_> Should be equivalent yes
13:45:43 <xarick> nice! that clears things up
13:45:46 <DorpsGek> [OpenTTD/OpenTTD] metablaster opened issue #14964: [Bug]: Rail track under some depots missing in transparency view https://github.com/OpenTTD/OpenTTD/issues/14964
13:46:08 <xarick> less verbosity
13:51:01 <DorpsGek> [OpenTTD/OpenTTD] mmtunligit commented on issue #14964: [Bug]: Rail track under some depots missing in transparency view https://github.com/OpenTTD/OpenTTD/issues/14964
13:57:47 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1453023788936462356/image.png?ex=694bf15b&is=694a9fdb&hm=0a41cb54b26df145c0482ab20122c60562a65e3410eb33a1cae70feacfaac749&
13:57:53 <xarick> 4
14:02:08 <talltyler> I thought we had a closed issue for the depot track drawing, but I can’t find it
14:03:28 <DorpsGek> [OpenTTD/OpenTTD] metablaster commented on issue #14964: [Bug]: Rail track under some depots missing in transparency view https://github.com/OpenTTD/OpenTTD/issues/14964
14:05:06 <_glx_> talltyler: yup tried to find it too
14:06:52 <mmtunligit> im not wrong in thinking you have never been able to see the track on rear facing depots in traanspareency though
14:06:58 <mmtunligit> right?
14:10:14 <_glx_> yes it's intended
14:11:40 <xarick> this->resume_item = {}; or this->resume_item = std::monostate{} ?
14:13:48 <_glx_> {} will use the first type
14:17:40 <xarick> first type is monostate
14:17:49 <xarick> unless someone in the future ruins it
14:18:09 <DorpsGek> [OpenTTD/OpenTTD] Rito13 commented on issue #14964: [Bug]: Rail track under some depots missing in transparency view https://github.com/OpenTTD/OpenTTD/issues/14964
14:27:25 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1453031247474589897/image.png?ex=694bf84d&is=694aa6cd&hm=ae597f8d116c6dbaa86c9a20ea002e985c16caeb2fbf6924f5fe83dde89a8773&
14:27:25 <xarick> not entirely apples to apples
14:29:08 <xarick> std map set has value_iter tracking, safe btree has std::variant resume_item, bplustree has nothing extra bundled with it, and master is master
14:30:03 <xarick> gonna begin benchmarks
15:00:38 <DorpsGek> [OpenTTD/OpenTTD] metablaster commented on issue #14964: [Bug]: Rail track under some depots missing in transparency view https://github.com/OpenTTD/OpenTTD/issues/14964
15:31:39 <LordAro> Rubidium: relevant xkcd: https://xkcd.com/1217/
15:40:18 <Rubidium> indeed
16:54:54 *** iSoSyS has joined #openttd
16:58:41 <DorpsGek> [OpenTTD/game-coordinator] MiguelHorta commented on issue #251: STUN server can become unresponsive https://github.com/OpenTTD/game-coordinator/issues/251
17:05:00 <LordAro> iirc there's a password manager with some important passwords somewhere that should allow us to restart this service... did anyone other than TB & frosch have access to that?
17:06:49 *** Wormnest has joined #openttd
17:10:14 <_glx_> the 1password I have only has social accounts
17:47:27 *** gelignite has joined #openttd
17:56:37 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #14963: Fix #12465: Click/tooltip alignment of industry chain cargo lines https://github.com/OpenTTD/OpenTTD/pull/14963#pullrequestreview-3608869699
18:00:53 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14960: Codefix: Speed up window functions which use window number. https://github.com/OpenTTD/OpenTTD/pull/14960#pullrequestreview-3608878237
18:04:07 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14962: Fix #14951: Init and save/load TimerGameEconomy::days_since_last_month https://github.com/OpenTTD/OpenTTD/pull/14962#pullrequestreview-3608885649
18:06:28 <LordAro> _glx_: :/
18:13:54 <xarick> benchmarks finished
18:13:57 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1453088255003201669/image.png?ex=694c2d65&is=694adbe5&hm=02cbd0c1315083bb5bf206d226d09300707d1e3b2762bfddb024ad137bef00de&
18:26:46 <_zephyris> A service restart would be useful for the graphics bootstrap PR too
18:27:50 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #14961: (Begginer Fix)Fix aircraft with only depot orders being treated as having valid orders https://github.com/OpenTTD/OpenTTD/pull/14961#pullrequestreview-3608922782
18:32:05 *** Borg has quit IRC (Quit: leaving)
18:40:07 <onfirenfs> _jgr_: Just wanted to say thanks! I was able to get JGRPP working and this was exactly what I was looking for!
18:53:30 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1453098206215798814/image.png?ex=694c36a9&is=694ae529&hm=7cd2d91d14c5dbab4da3985fef44c6ed5520a1be5695467c5ffa9233aa613cdd&
18:53:30 <xarick> why do I get map/set iterators incompatible here?
18:54:44 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1453098514564386836/image.png?ex=694c36f3&is=694ae573&hm=f577d8b9bf1a729b40e22fbad0a385ca9a60677eee5ea26c06c46f0c114da66b&
18:54:47 <andythenorth> do we need to address bus factors?
18:54:58 <andythenorth> much as I hate having creds for things, I could hold them
18:55:09 <andythenorth> as should a few more maybe
18:57:55 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1453099316267974727/image.png?ex=694c37b2&is=694ae632&hm=3f212bc1f274f35a46ea95a9d1afd4e7417e2ade12ef4ea481d60f6c6924cec4&
19:02:16 <_jgr_> xarick: Using a hint in this way is pointless. It's only to avoid doing a lower_bound which you're now doing manually anyway.
19:02:50 <_jgr_> Doing a construction over the node value is also strange and unnecessary. Just use an ordinary assignment.
19:03:53 *** iSoSyS has quit IRC (Remote host closed the connection)
19:37:32 *** MinchinWeb[m] has quit IRC (Ping timeout: 480 seconds)
19:38:17 <xarick> that was copilot'ed
19:40:09 <xarick> i asked him to make it as efficient, fast, c++20 modern as possible
19:44:15 <andythenorth> the robot eh
19:44:32 <peter1138> Look.
19:44:39 <peter1138> Is it lunch?
19:44:42 <peter1138> Is it dinner?
19:44:45 <peter1138> It is teatime?
19:44:49 <andythenorth> is chocolate lunch?
19:44:54 <peter1138> Chocolate rain?
19:45:01 <andythenorth> chocolate is very expensive
19:45:06 <andythenorth> especially chocolate teapots
19:45:09 <andythenorth> single use teapot
19:45:16 <andythenorth> but biodegradable
19:45:22 <andythenorth> gives with one hand, takes with the other
19:47:10 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1453111714110247042/image.png?ex=694c433e&is=694af1be&hm=790cc9fe436cbbe80f1a4ded396d1a948c59cf281a28f6a1b991794d1ca21ce3&
19:47:10 <xarick> something like this, jgr?
19:48:35 <xarick> nop, failed
19:49:17 <xarick> oh of course it failed, I didn't erase
19:51:09 <xarick> ah, I remember why copilot did this with the handle
19:53:01 <xarick> something about reusing memory location or whatever
19:53:23 <xarick> less allocations
19:54:50 *** MinchinWeb[m] has joined #openttd
19:58:13 <xarick> can't remember if I benchmarked it
20:19:42 <xarick> just benchmarked:
20:19:42 <xarick> erase/emplace: 123 seconds
20:19:42 <xarick> extract/construct_at/insert: 109 seconds
20:19:57 <xarick> mr copilot is good!
20:23:03 <andythenorth> "sometimes"
20:44:08 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14954: Change: [Script] Include ScriptList, PriorityQueue and Array contents in script memory allocation total https://github.com/OpenTTD/OpenTTD/pull/14954#pullrequestreview-3609285582
20:47:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #14948: Fix #12937: Allow the computer to go to sleep while the game is paused https://github.com/OpenTTD/OpenTTD/pull/14948
20:47:38 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #14927: Codechange: Make doxygen warn about lack of description for function parameters. https://github.com/OpenTTD/OpenTTD/pull/14927
20:52:29 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14954: Change: [Script] Include ScriptList, PriorityQueue and Array contents in script memory allocation total https://github.com/OpenTTD/OpenTTD/pull/14954
20:53:11 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed pull request #14939: Include ScriptList contents in script memory allocation total https://github.com/OpenTTD/OpenTTD/pull/14939
20:53:14 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14939: Include ScriptList contents in script memory allocation total https://github.com/OpenTTD/OpenTTD/pull/14939#issuecomment-3687935395
20:57:22 <xarick> oh noes
20:57:43 <xarick> can my performance tests still run
20:58:53 <Rubidium> sure they can run
20:59:59 <xarick> i have array, priority queue and lists
21:00:03 <xarick> let's see
21:04:52 *** Flygon has joined #openttd
21:08:32 <xarick> test 1: peaks at 1.42 GiB
21:10:06 <peter1138> Nice, interim font fallback system which doesn't require reloading the entire font system for each tested font... is starting to take shape.
21:10:52 <andythenorth> lunch.ttd
21:11:00 <andythenorth> obiwan
21:11:03 <andythenorth> lunch.ttf
21:14:29 <xarick> test 2: peaks at 3.58 GiB
21:20:45 <LordAro> peter1138: yay
21:20:53 <LordAro> andythenorth: was it though
21:21:17 <andythenorth> too early to tell
21:21:41 <peter1138> The default memory limit for scripts is actually very high. High enough that doing silly things with massive lists is not really prevented even when accounting for it.
21:22:20 <xarick> test 3: peaks at 7.40 GiB
21:25:59 <xarick> happy to know they all still run
21:27:38 <xarick> meanwhile, i wanna see if i can use construct_at in master when updating the value of an item
21:27:47 <xarick> it pays off
21:38:42 *** Mouse_ has joined #openttd
21:39:26 <_glx_> hmm could use extract+insert in SetValue
21:39:30 <peter1138> If the item already exists, then the value is... simply a value type.
21:42:04 <_glx_> for the set the key is a (value, item) pair
21:42:33 <_glx_> so we need currently remove then emplace
21:43:00 <_glx_> extract, edit, insert will save dealloc/alloc
21:47:32 *** Mouse_ has quit IRC (Quit: Page closed)
21:49:46 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1453142566924058696/image.png?ex=694c5ffa&is=694b0e7a&hm=8dac7b85c8032dbacd0c1bce17750161599540e36f30869fea7571bb25c74bdb&
21:49:46 <_glx_> but I'm not sure it will have a noticeable effect
21:50:20 <xarick> just tested
21:50:26 <xarick> 155 seconds down to 130
21:50:35 <xarick> in the ValuateTests
21:52:00 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1453143126129770567/image.png?ex=694c607f&is=694b0eff&hm=3032ca57f0e2669eddd85aa0d45e1e87c9381d42818f136b87c76ecd67e35bbe&
21:52:28 <xarick> not quite similar code, let me test yours
21:53:08 <xarick> may be faster
22:06:33 <xarick> 129 secs
22:09:28 <xarick> make PR
22:12:38 <peter1138> Hmm, font loading works but it still stalls the game :/
22:12:59 <peter1138> Tempted to try freetype + fontconfig on Windows...
22:16:14 <DorpsGek> [OpenTTD/OpenTTD] Ojself opened issue #14965: [Bug]: Joining some multiplayer servers results in connection timeout https://github.com/OpenTTD/OpenTTD/issues/14965
22:55:39 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #14965: [Bug]: Joining some multiplayer servers results in connection timeout https://github.com/OpenTTD/OpenTTD/issues/14965
23:05:53 <xarick> safe btree accepts ScriptStdAllocator apparently
23:07:02 <xarick> my bplustree doesn't support that :(
23:07:13 <xarick> not even the std::less<>
23:16:42 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #14966: Codechange: [Script] Reuse memory when changing values of ScriptList items https://github.com/OpenTTD/OpenTTD/pull/14966
23:23:18 <xarick> :)
23:23:51 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #14966: Codechange: [Script] Reuse memory when changing values of ScriptList items https://github.com/OpenTTD/OpenTTD/pull/14966#pullrequestreview-3609542716
23:24:44 <xarick> copilot was good for something
23:25:30 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick approved pull request #14966: Codechange: [Script] Reuse memory when changing values of ScriptList items https://github.com/OpenTTD/OpenTTD/pull/14966#pullrequestreview-3609543973
23:27:18 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
23:28:04 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #14966: Codechange: [Script] Reuse memory when changing values of ScriptList items https://github.com/OpenTTD/OpenTTD/pull/14966#issuecomment-3688203995
23:31:52 <xarick> `using ScriptListMap = std::map<SQInteger, ItemRecord, std::less<>, ScriptStdAllocator<std::pair<const SQInteger, ItemRecord>>>; ///< List per item`
23:31:52 <xarick> owow! my ItemRecord struct can be allocatored?
23:34:03 <DorpsGek> [OpenTTD/OpenTTD] Nusioos commented on pull request #14961: (Begginer Fix)Fix aircraft with only depot orders being treated as having valid orders https://github.com/OpenTTD/OpenTTD/pull/14961#pullrequestreview-3609552951
23:34:37 <xarick> Don't I have to do something in my struct to properly support ScriptStdAllocator?
23:35:42 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1453169226813538324/image.png?ex=694c78ce&is=694b274e&hm=7c67ddbfbe7b60e786734dde78bfb8b278e6894cf7cd38a0d5cb8b379259a40b&
23:40:13 <_auxilian> I accidentally used the anonymous email and now my github didn't get credited :(
23:40:14 <_glx_> ScriptStdAllocator is just the default allocator (with a litle bonus)
23:41:37 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1453170713916604609/image.png?ex=694c7a30&is=694b28b0&hm=4fca4bb9fd64ea279cde668aa7fbe9e58e4b6b6ad558ebf5dd7a86e74ab29e90&
23:41:37 <xarick> eww my stuff is bad
23:41:49 <xarick> ItemRecord at the right side
23:42:33 <xarick> safe btree at the center
23:43:58 <xarick> funny how safe btree works
23:44:41 <xarick> memory keeps moving during valuate, even though no items are being added
23:44:47 <xarick> up and down
23:44:53 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
23:48:19 *** WormnestAndroid has joined #openttd
continue to next day ⏵
