IRC logs for #openttd on OFTC at 2025-05-17
            
00:59:20 *** Flygon has joined #openttd
01:39:55 *** tokai|noir has joined #openttd
01:39:55 *** ChanServ sets mode: +v tokai|noir
01:46:55 *** tokai has quit IRC (Ping timeout: 480 seconds)
02:35:57 *** Wormnest has quit IRC (Quit: Leaving)
02:59:24 *** gnu_jj has joined #openttd
03:02:55 *** gnu_jj_ has quit IRC (Ping timeout: 480 seconds)
04:05:41 *** keikoz has joined #openttd
04:30:11 *** greeter has quit IRC (Ping timeout: 480 seconds)
04:44:38 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/617169c1c9cb7097fdbbebd1e9c90ffd800f8920
04:44:39 <DorpsGek> - Update: Translations from eints (by translators)
05:20:27 *** keikoz has quit IRC ()
05:31:42 *** keikoz has joined #openttd
06:52:06 <andythenorth> I'm in bed, how do I get coffee?
06:54:13 <peter1138[d]> Deliveroo.
06:55:07 <andythenorth> I'd have to answer the door
06:57:37 *** Flygon has quit IRC (Read error: Connection reset by peer)
06:59:39 <kuhnovic> I was in a hotel once that had a nespresso machine right next to the bed. It was great.
07:06:41 *** Wolf01 has joined #openttd
07:16:17 <peter1138[d]> Hmm, am I cycling?
07:17:28 <andythenorth> I got up and made coffee
07:17:52 <peter1138[d]> Small steps.
07:17:54 <andythenorth> cycling is good
07:18:01 <andythenorth> better than discording, probably
07:19:36 <peter1138[d]> But what I *want* to sit here doing nothing all day?
07:19:44 <andythenorth> I often do that
08:20:29 *** foodliker has joined #openttd
08:20:29 <foodliker> andythenorth: https://www.youtube.com/watch?v=UALN1ZoN6bA
08:21:00 <foodliker> just get one of these
08:21:04 *** greeter has joined #openttd
08:25:36 *** nielsm has joined #openttd
09:08:34 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1373225676647305346/image.png?ex=6829a392&is=68285212&hm=5786f9d5107bdccc82b12ce9fc34d542efbb59c5e72829a45dc53c5cb5981834&
09:08:34 <xarick> hi, I just woke up and was greeted with
09:24:48 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1373229760292982862/message.txt?ex=6829a760&is=682855e0&hm=60333eb5ae14dfce1e7cd93c3993b4ed4c15df3a902aae36d4b5354717cc3059&
09:27:38 <xarick> custom openttd build
09:34:44 <xarick> can't debug tt
10:25:32 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1373245045129351309/crash20250517090112.png?ex=6829b59c&is=6828641c&hm=f0fda43d155643053ac3a1152eea9974d5a5a5c75dbe069b6e7ee9cc1633ad04&
10:25:32 <xarick> where can a divide by 0 can occur in this screenshot?
10:25:54 <xarick> this is the crash20250517090112.png
10:26:17 <xarick> framerate graph?
10:53:58 <_glx_> And the trace just shows an infinite loop
10:55:37 <_glx_> You should be able to debug your own builds
11:00:54 <xarick> system woke up from hibernation and openttd crashed
11:01:23 <xarick> not the first time it occurs, but one day I will find out the cause
11:14:50 <andythenorth> where do bananas removal request PRs go?
11:15:40 <andythenorth> found thme
11:17:41 <andythenorth> oh, no issue tracker 😄 https://github.com/OpenTTD/BaNaNaS
11:19:03 <andythenorth> this is a junk grf that perceptually squats the "Iron Horse" name in search (many players won't make any distinction between 'grf' and 'addon') https://bananas.openttd.org/package/newgrf/47385204
11:19:53 <andythenorth> it doesn't violate ToS, but it's useless, causes confusion, and is primarily the work of someone who has been banned from parts of the community
11:20:14 <kuhnovic> Is it _that_ person?
11:20:44 <reldred> Yes
11:20:49 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1373258958541815851/image.png?ex=6829c291&is=68287111&hm=a0131a6719de132a1aa77b911463bf9777d6387e154f561e62c738cb48a48e86&
11:20:49 <andythenorth> it's also 0 B
11:20:54 <andythenorth> so presumably it's somehow empty
11:21:13 <kuhnovic> Yeet
11:21:43 <reldred> *that* person has a tonne of garbage broken grf’s on bananas all pointing their website link to a reddit thread under a deleted/banned account.
11:21:58 <andythenorth> "tonne" would be a countable number
11:22:50 <reldred> Given they’ve been banned from just about every OpenTTD community for their behaviour, and the grf’s are all pretty much broken, they should at least be hidden from public listing
11:23:03 <LordAro> andythenorth: an email to abuse@ would seem appropriate
11:23:27 <andythenorth> can do, it doesn't violate ToS though
11:23:39 <andythenorth> it's just bad community practice
11:23:51 <andythenorth> we're into "are we curating or not?"
11:24:15 <kuhnovic> Is there any way to label broken grfs as archived or hidden or something. That could be helpful in general. And then don't show them in the online content list, at least not by default.
11:24:31 <LordAro> kuhnovic: "savegame only"
11:24:59 <kuhnovic> That would be curating, but only at a functional level. We wouldn't be throwing anything away.
11:25:25 <LordAro> we almost never actually delete anything
11:25:40 <LordAro> because that would break existing saves, etc
11:26:13 <LordAro> if it actually is 0B, then it should be removed anyway
11:26:25 <LordAro> (and the bug that allowed that to be uploaded fixed)
11:26:30 <kuhnovic> Makes sense. But some mechanism to keep things available but hidden could help keep things clean(er)
11:26:39 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1373260423532515478/image.png?ex=6829c3ee&is=6828726e&hm=22d14e90b69e19b786303bf5f80932d5facbc4bb09ac926798850164f236863d&
11:26:39 <xarick> it's 11.2 KiB for me
11:27:02 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1373260522040070264/image.png?ex=6829c406&is=68287286&hm=1af1885389d2cbd46be52244a95423847b3beceaf5438b05a09310f3b8edafe3&
11:27:02 <andythenorth> 0 B for me
11:27:12 <xarick> oh you didn't click
11:27:14 <kuhnovic> You got the special Xarick edition
11:27:16 <reldred> blame Andy’s mac
11:27:42 <andythenorth> wait, what?
11:27:48 <andythenorth> so what's broken there?
11:27:56 <andythenorth> is it the client?
11:28:06 <kuhnovic> Definitely the user
11:28:06 <xarick> Download size: 11.2 KiB
11:28:29 <andythenorth> I never use Bananas
11:28:33 <andythenorth> what am I supposed to do?
11:28:36 <xarick> Total download size: 0 B because you haven't selected it
11:28:41 <andythenorth> wat?
11:28:50 <xarick> misleading gui
11:28:58 <andythenorth> lolz
11:29:05 <andythenorth> yeah I never use this
11:29:22 <andythenorth> all grfs are local, or when I join a server, they magically get added
11:30:28 <xarick> Total download size could be a separate widget
11:30:33 <xarick> or rectangle
11:31:09 <andythenorth> I can see how selecting everything with one click per content
11:31:13 <andythenorth> and then clicking download
11:31:16 <andythenorth> is fewer clicks overall
11:31:26 <andythenorth> compared to having 'download' on each piece of content
11:31:30 <andythenorth> because 100 < 99
11:32:12 <_jgr_> The actual size value is towards the end of text, it's not the "total download size" line at the bottom
11:32:44 <andythenorth> I value knowing that all 3 of the grfs I've selected are 37.8 KiB
11:34:42 <andythenorth> ok so maybe "Iron Horse 2 Addon" isn't broken
11:35:37 <reldred> Most of the other grfs are broken. All the GRC stuff is absolutely rooted
11:35:54 <reldred> the road fixes grf is fucked
11:36:17 <andythenorth> the amount of support requests this stuff generates
11:36:18 <reldred> the only one I know that definitely does what it says on the tin is the OpenGFX Mars late start .grf
11:36:50 <andythenorth> does Iron Horse 2 Addon even have any vehicles in it?
11:37:06 <andythenorth> I still need to answer that dude's question about the grf parameters too
11:37:45 <_jgr_> It has 1, which looks reasonable enough
11:37:57 <_jgr_> If he'd named the GRF something else it probably wouldn't be any issue
11:38:00 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1373263280046473226/image.png?ex=6829c697&is=68287517&hm=1e012295873996652ba7bc9a74959451f0a491718ed6bbbf510ace7704a4ac83&
11:38:00 <andythenorth> I can't get this to do anything
11:39:22 <andythenorth> does it have sources?
11:39:53 <andythenorth> I hate that this is my obligation just because someone can take the same name on Bananas
11:41:39 <andythenorth> _jgr_: ++
11:43:43 <reldred> andythenorth: I mean is it? You can just reply saying 'no some other knobhead made that'
11:44:48 <reldred> like, that is a thing you're allowed to do
11:45:19 <reldred> not saying the situation on bananas doesn't need a little bit of attention with a mop and bucket
11:46:05 <yiffgirl> who runs bananas?
11:46:19 <reldred> the mysterious people of the Yellow Username
11:46:37 <reldred> it is not actively curated though
11:46:59 <yiffgirl> andy is a yellow username, it's just hidden behind the blue username
11:47:21 <reldred> https://cdn.discordapp.com/attachments/1008473233844097104/1373265633042501682/image.png?ex=6829c8c8&is=68287748&hm=737d7287a5a76ab8e8dfeb7dceddd5f0d45e1a3422887c7ccad946f52aa29808&
11:47:21 <reldred> profile says no
11:47:34 <yiffgirl> o
11:48:09 <reldred> livestream participant is some sort of minor openttd royalty however
11:48:34 <yiffgirl> whoops. i saw developer and must have assumed the other one was for newgrf development. how embarrassing!
11:48:42 <brickblock19280> Would it be possible to add an deprecated status to bananas content and have it require a button is pressed for it to show up?
11:49:49 <yiffgirl> very surprised to learn that andy isn't considered a full developer though
11:53:17 <reldred> writing and comitting sea plus plus code is pretty much the requisite for that
11:53:41 <reldred> you don't get it for making newgrfs and being around 5ever 😛
11:55:18 <yiffgirl> i could have sworn i've seen c++ patches get merged in the past
11:58:01 <reldred> not since mid 2023 according to github
11:58:09 <andythenorth> yiffgirl: I relinquished some rights I had
11:58:15 <reldred> but the yellow dudes also do other stuff, infrastructure, prep releases, etc.
11:58:50 <reldred> oh no, andy the north, fallen from grace, lost the mandate of heaven
11:58:53 <andythenorth> I have too much spiky mental profile to have github rights
11:59:00 <andythenorth> poor choices get made
11:59:37 <reldred> having responsibility is bad and yucky
11:59:50 <reldred> I have too much of that IRL
11:59:54 <talltyler> There’s no automatic qualification, it’s mostly “we’re merging a lot of your stuff, would you like to push the button yourself and save us the trouble” 🙂
12:00:37 <andythenorth> reldred: yair, I have a high compliance, high profile, work environment, it's hard to regulate my behaviour appropriately when it's just drama over pixel trains
12:00:58 <andythenorth> appropriate behaviour is a limited resource
12:01:09 <reldred> andythenorth: god if I get this new job I'm interviewing for next week I'm going to be in the same boat
12:01:19 <reldred> I will have no choice but to get more unhinged online
12:01:21 <talltyler> Zephyris is the latest yellow name as our baseset wizard, which is not C++ but much more important than anything I do 😛
12:01:23 <peter1138[d]> Hi
12:01:37 <reldred> morning peter
12:01:39 <andythenorth> speaking of high compliance high profile, here's peter1138[d] 😛
12:01:50 <peter1138[d]> Whowhat?
12:01:55 <talltyler> reldred: Can’t wait 😄
12:02:00 <talltyler> Always a fun time
12:02:18 <reldred> talltyler: at least I've mostly stopped picking fights with people
12:02:19 <foodliker> reldred: the reason i'm so chilled out is because i have no responsibility, most people at even work don't know who i am and if i mess anything up by accident or inattention it can easily be fixed
12:02:29 <foodliker> there is something to be said for a true bullshit job
12:03:20 <talltyler> reldred: I am not criticizing, I enjoy your posts around here, often entertaining 🙂
12:03:38 <talltyler> Wrong thread but I am very excited to see what you do with your house set someday
12:03:50 <reldred> someday (tm)
12:04:02 <reldred> need badge detection in houses
12:04:13 <reldred> which means I need to actually test that PR of peters
12:04:27 <talltyler> I stepped back from helping moderate this Discord as it was wearing me out, luckily GitHub has less silliness 🙂
12:21:26 *** truebrain has joined #openttd
12:21:26 <truebrain> andythenorth: As it has been for the, owh, I dunno, last 18 years or so, that value shows how much bytes you will download when pressing download. It does -not- show the size of a content you just clicked on. You need to select it for download first.
12:21:26 <truebrain> I am not saying it is a good interface, just saying it has been like that for a very very long time 😛
12:21:51 <truebrain> LordAro: It isn't 0B. You cannot upload empty content. This is a PEBKAC issue, not a BaNaNaS 😉
12:22:03 <andythenorth> I am a noob 🙂
12:22:32 <truebrain> and spreading lies because of it! 😛 😛
12:23:07 <truebrain> I think mostly that text is just in a weird place on the UI, making it seem like it is the size of the item you clicked
12:23:13 <andythenorth> “Alternative Facts”
12:24:05 <truebrain> If it wouldn't be in the "CONTENT INFO" panel, it would be more clear. But the "download size" is mentioned in that panel as well
12:24:29 <truebrain> I guess moving it just above "Close" / "Download" button, outside ot eh "CONTENT INTO" panel, would already help out
12:24:33 <truebrain> but okay .. still PEBKAC 😛
12:26:04 <truebrain> https://cdn.discordapp.com/attachments/1008473233844097104/1373275376519872663/image.png?ex=6829d1db&is=6828805b&hm=4f70479f2d59686464f41d138ed523351be3c09067ea3854959d75d9935a1a51&
12:26:04 <truebrain> for your viewing pleasure 🙂
12:41:43 <peter1138[d]> I was fiddling with that UI the other week and wondered about moving that out.
12:42:06 <peter1138[d]> And the info buttons should be moved in, but that gets inconsistent with those buttons elsewhere.
12:42:23 <peter1138[d]> Is it beer o'clock?
12:42:38 <_zephyris> The yard arm says yea
12:42:39 <reldred> it's after five oclock somewhere
12:43:52 <_zephyris> I think it might be gin o'clock, got to be primed for eurovision.
12:53:34 <andythenorth> peter1138[d]: I am supervising a chlidren’s party, so no
12:53:45 <andythenorth> Also…driving
12:53:48 <andythenorth> So no
12:53:56 <andythenorth> You could 😛
12:54:19 <peter1138[d]> I could go out on a bike ride
12:59:09 <andythenorth> Beer compatible
13:03:26 <xarick> should I hibernate and resume to try catch a bug?
13:04:03 <xarick> what if it requires ~12 hours of hibernation
13:10:10 <_glx_> you could use the dmp
13:10:32 <_glx_> or attach the debugger when it crashed
13:11:16 <xarick> I made changes to the branch
13:12:08 <xarick> how to proceed
13:12:25 <_glx_> impossible to debug if you made changes
13:12:42 <xarick> changed the 12 hash bits to 11
13:13:06 <_glx_> even just rebuilding from the same source will prevent debugging
13:13:39 <_glx_> unless exe and pdb are stored outside build dir
13:14:46 <xarick> how do I generate the pdb
13:15:06 <_glx_> RelWithDebInfo
13:20:30 <LordAro> truebrain: i said 'if' !
13:21:17 <truebrain> And I answered your "if"! 😛
13:36:33 <peter1138[d]> else?
13:36:46 <peter1138[d]> I was trying to garden but it's hot and I got a headache 😒
13:40:57 <xarick> can't get a crash
13:41:10 <xarick> just hibernated 6 times
13:41:22 <xarick> openttd resumed fine
13:44:30 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1373295117540261988/image.png?ex=6829e43e&is=682892be&hm=a8f77a4a7f4a13c1ceac9b70b490af674672aaf9d453bd2c268b534c5594e69c&
13:44:30 <xarick> my suspicion is overflow, underflow due to a sudden 12 hours sleep
13:45:22 <xarick> something is dividing by 0, i suspect in framerate, but i could be wrong, could be somewhere else entirely
13:47:27 <xarick> how much time is 12 hours in milliseconds as an average of 512 measure points
13:51:22 <xarick> about 84,000 ms
13:51:59 <xarick> 82,432 means... it was slightly less than 12 hours
13:56:04 <xarick> ~11 hours 43 minutes
14:07:55 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1373301008075329586/image.png?ex=6829e9bb&is=6828983b&hm=b2af16f0828a1c839ff796df81c404e19bc7283bbf089db330cc98d56b42246a&
14:07:55 <xarick> I'm looking at the dump file in notepad++
14:08:05 <xarick> that looks like a string
14:14:06 <LordAro> hilarious
14:17:19 <_glx_> peter1138[d]: nah it's windy and the wind is cold
14:30:58 <xarick> `Scinterlate` this is sometimes doing math on int64_t - int
14:31:04 <xarick> is that ok?
14:49:13 <_glx_> trying to guess is just wasting time
14:55:34 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1373312998764052652/image.png?ex=6829f4e5&is=6828a365&hm=45a1e20d6392c26ebe8d78ece033aadabffaa7c5fb16d98a9e9083d557a0dba1&
14:55:34 <xarick> diff can be negative...
14:55:48 <xarick> 20 - 120 = -100
14:57:41 <jfkuayue> So... Andy had a misunderstanding typical for redditors?
15:08:59 *** Wormnest has joined #openttd
15:37:27 <andythenorth> redditors are people too
15:43:13 <xarick> is it even possible for src_max - src_min = 0
15:43:25 <xarick> that's where a division by 0 can occur
15:43:53 <xarick> need to understand the code
15:47:55 *** alpapilus has joined #openttd
15:47:55 <alpapilus> andythenorth: Never seen one while walking outside, I cannot prove or disprove this statement.
16:12:11 <foodliker> andythenorth: never been more wrong
16:13:30 *** notluke2578 has joined #openttd
16:13:30 <notluke2578> andythenorth: first ive heard of this
16:14:39 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1373332903827734680/image.png?ex=682a076f&is=6828b5ef&hm=db3ee1794592bdbde42af8be3d5576617887ef2401a33e088f27dc76c0e482f6&
16:14:39 <xarick> is this a valid warning?
16:18:43 *** Tirili has joined #openttd
16:18:52 *** Flygon has joined #openttd
16:32:11 <_glx_> warning is correct but it's generic and depends on real numbers
16:35:58 <_glx_> what it's saying is `this->horizontal_scale + 2` (an int) may overflow before being converted to uint64_t for next step
16:36:05 <_glx_> will it happen ???
16:36:47 <xarick> I was considering changing horizontal_scale and vertical_scale to int64_t
16:37:00 <_glx_> useless
16:37:06 <xarick> but without a crash, im unsure
16:37:12 <xarick> a debuggable crash
16:37:43 <_glx_> I'm quite sure xxx_scale will never reach 32bit limit
16:37:59 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
16:38:12 <xarick> `GetString(STR_FRAMERATE_GRAPH_MILLISECONDS, this->vertical_scale * division / 10 * 1000 / TIMESTAMP_PRECISION),` this one is very very close
16:38:54 <xarick> 999999 * 10 / 10 * 1000 / 1000000
16:39:34 <_glx_> but it's already converted to uint64_t because TIMESTAMP_PRECISION
16:40:23 <xarick> i get a sub-expression may overflow etc... warning
16:43:02 <peter1138[d]> it might be second beer o'clock.
16:44:46 <truebrain> You know what, if you finished that: take a third
16:44:47 <truebrain> you deserve it
16:45:16 <peter1138[d]> Basically, partner is away, and is back tomorrow.
16:45:23 <peter1138[d]> But tomorrow is... BUS REPLACEMENT SERVICE.
16:45:29 <peter1138[d]> So I may well need to drive.
16:45:57 <truebrain> So you have to drink tonight, as tomorrow you can't? 😛
16:47:34 <andythenorth> wine
16:56:29 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1373343430389792878/image.png?ex=682a113d&is=6828bfbd&hm=0e562409bbdb259172a8f6c67ae704ac4415105a0f2f0b8fe9deab357389769e&
16:56:29 <xarick> I suspect something here
16:57:10 <xarick> durations[point] of 12 hours in milliseconds
16:57:37 <xarick> Scinterlate does math, but Point.y is forced int
17:10:31 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
17:11:21 *** WormnestAndroid has joined #openttd
17:14:27 <_glx_> and? the value will be betweed y_zero and y_max anyway
17:18:07 <xarick> does GetString {COMMA} take uint64_t ?
17:19:53 <_glx_> all string parameters are 64bit
17:19:59 <andythenorth> could we hide this somehow? Or rename it? https://bananas.openttd.org/package/newgrf/47385204
17:20:08 <andythenorth> it name squats actual Iron Horse
17:28:08 <peter1138[d]> Well.
17:28:34 <xarick> wondering if these changes are worth it: <https://gist.github.com/SamuXarick/187340a5d52413ec1a20d7a15c2651ee>
17:29:12 <xarick> or TimingMeasurement instead of uint64_t
17:56:03 <peter1138[d]> 100 AIs, eh?
18:00:22 *** WormnestAndroid has quit IRC (Remote host closed the connection)
18:00:55 *** WormnestAndroid has joined #openttd
18:03:39 *** Tirili has quit IRC (Remote host closed the connection)
18:05:10 *** Tirili has joined #openttd
18:10:46 <kuhnovic> More beer
18:37:23 <xarick> i found 2 instances of Ludi in that video
18:37:53 <xarick> but openttd 13 hmm maybe version 20?
18:37:57 <xarick> or 19
18:37:59 <xarick> unsure
18:38:35 <xarick> easy/medium/hard profiles and random still existed
18:40:20 <xarick> yeah, version 20, for openttd 13
18:40:25 <xarick> no trains
18:41:03 <xarick> default profile: easy
18:41:30 <xarick> if master hellish used defaults, then I was competing as a benevolent easy going ai 😐
18:42:00 <xarick> excuses...
18:43:08 <xarick> probably wouldn't make it to the top anyway
19:22:55 *** Tirili has quit IRC (Quit: Leaving)
20:03:13 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1373390421371129987/image.png?ex=682a3d00&is=6828eb80&hm=49278949add87bd0e82316d778f897ad9c05db33948478df32e07b3d1a5986b6&
20:03:13 <xarick> hmm...
20:05:07 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1373390901128335482/image.png?ex=682a3d73&is=6828ebf3&hm=ffaea59d8cb577204915fc97dc2f9a9b89afdb30d1b6ff1730df67ea271bfb52&
20:09:11 <xarick> not sure what's wrong here
20:10:38 <xarick> Company conversion?
20:10:38 <_glx_> possible side effect of https://github.com/OpenTTD/OpenTTD/commit/b2c57123199d96179d105aec3ee14e5ac4a602ac#diff-b5552c980c2b076b8c1c53cbb1624254f190bb32ba03cdea4346d3b4f081bff4
20:45:23 <_glx_> ok I modified regression test and it confirms the failure
20:47:00 <andythenorth> naptime?
20:47:10 <xarick> :/
20:56:53 <_glx_> event code is weird
20:58:06 <_glx_> but I now have a way to easily debug and test
21:03:05 *** Tirili has joined #openttd
21:06:52 <_glx_> oh I see what happens, squirrel only receives "plain" ScriptEvent objects without all the inheritance info
21:08:12 *** akimoto has joined #openttd
21:14:48 <xarick> I gotta go sleep
21:19:10 *** nielsm has quit IRC (Ping timeout: 480 seconds)
21:28:38 <xarick> can't seem to get bribe going on
21:28:52 <xarick> trying to make exclusive transport right wars
21:29:50 *** keikoz has quit IRC (Ping timeout: 480 seconds)
21:45:22 *** Tirili has quit IRC (Quit: Leaving)
21:57:54 <peter1138[d]> Hmm, EncodedString decoding is still broken 😦
21:58:09 <peter1138[d]> When decoding`GetEncodedString(part2, std::monostate{}, engine)`, engine is put at parameter 0, not parameter 1.
22:03:38 <_glx_> hmm I though an empty param was pushed in this case
22:04:08 <peter1138[d]> I think strings.cpp:1007 needs to be `PeekUtf8If`, not `ReadUtf8If`
22:04:25 <peter1138[d]> It reads it.
22:04:38 <peter1138[d]> And then if the next character is another separator, that is skipped.
22:05:35 <_glx_> ha looks like the empty param at the end issue
22:05:55 <peter1138[d]> Yeah, we fixed that, but moved it to the empty parameter at beginning instead.
22:11:17 <_glx_> yup Peek makes more sense
22:11:55 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14273: Fix f8bdc1e612: Empty first parameter of EncodedString was skipped. https://github.com/OpenTTD/OpenTTD/pull/14273
22:12:01 <_glx_> since we skip separator anyway in the while
22:12:37 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #14273: Fix f8bdc1e612: Empty first parameter of EncodedString was skipped. https://github.com/OpenTTD/OpenTTD/pull/14273#pullrequestreview-2848413930
22:12:40 <peter1138[d]> Hmm, can unit tests use language strings?
22:13:08 <peter1138[d]> I think none of that stuff is loaded, and loading it is probably quite a bit of effort.
22:16:55 *** goddess_ishtar has joined #openttd
22:16:55 <goddess_ishtar> hrm, if we're messing with the main menu UI I might dig up my old plans for fixing the NewGRF menu
22:17:17 <goddess_ishtar> I think Online Content especially needs some extra attention
22:18:55 <_glx_> hmm ScriptEvent issue will be painful to fix
22:21:03 <_glx_> the easiest way is to change the 2 affected `Convert()`
22:28:09 *** akimoto has quit IRC (Remote host closed the connection)
22:28:30 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
22:55:52 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14273: Fix f8bdc1e612: Empty first parameter of EncodedString was skipped. https://github.com/OpenTTD/OpenTTD/pull/14273
23:11:09 <talltyler> goddess_ishtar: Agreed! Would love to see your ideas. 🙂
23:18:10 <goddess_ishtar> for now I'm just fixing something very minor (the sort function for the online content window uses the same order as the enum used for holding the selection state, which is exceptionally annoying because it puts selected content *between* already here and unselected content)
23:18:25 <goddess_ishtar> just to familiarise myself with the code around there
23:32:43 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
23:34:36 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #14274: Fix b2c57123: [Script] Conversion from ScriptEvent to ScriptEventCompanyTown subclasses https://github.com/OpenTTD/OpenTTD/pull/14274
23:41:17 <_glx_> so actually it was "wrong" from the beginning, but hidden until proper validation was added
23:41:49 *** WormnestAndroid has joined #openttd
23:43:38 <_glx_> "wrong" but safe to use
23:58:36 *** WormnestAndroid has quit IRC (Remote host closed the connection)