⏴ go to previous day
01:15:48 *** Wormnest has quit IRC (Quit: Leaving)
01:56:59 *** gelignite is now known as Guest13884
01:57:02 *** gelignite has joined #openttd
02:04:22 *** Guest13884 has quit IRC (Ping timeout: 480 seconds)
02:09:32 *** gnu_jj has joined #openttd
02:13:05 *** gnu_jj_ has quit IRC (Ping timeout: 480 seconds)
02:20:28 *** WormnestAndroid has quit IRC (Remote host closed the connection)
02:20:33 *** WormnestAndroid has joined #openttd
02:35:31 *** WormnestAndroid has quit IRC (Remote host closed the connection)
02:35:32 *** WormnestAndroid has joined #openttd
02:35:36 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
02:39:23 *** WormnestAndroid has joined #openttd
02:54:02 <DorpsGek> [OpenTTD/OpenTTD] Moth-Tolias commented on pull request #14015: Feature: Add options to disable vehicle introduction randomisation and exclusive previews https://github.com/OpenTTD/OpenTTD/pull/14015#issuecomment-2814401626
03:49:59 *** WormnestAndroid has quit IRC (Remote host closed the connection)
03:50:03 *** WormnestAndroid has joined #openttd
03:55:48 *** k-man has quit IRC (Ping timeout: 480 seconds)
04:01:10 *** k-man has joined #openttd
04:09:47 *** keikoz has joined #openttd
06:17:26 *** cu-kai has quit IRC (Quit: Leaving for a bit.)
06:22:02 *** cu-kai has joined #openttd
06:38:40 *** gelignite has quit IRC (Quit: Stay safe!)
06:47:23 *** nielsm has joined #openttd
06:48:16 *** Flygon has joined #openttd
07:09:28 <DorpsGek> [OpenTTD/OpenTTD] zephyris updated pull request #13918: Change: Package OpenGFX2 for Windows Store and GOG https://github.com/OpenTTD/OpenTTD/pull/13918
07:09:56 <_zephyris> Sooo, I've done a bad
07:10:34 <_zephyris> Gained a merge branch somehow when rebasing
07:11:13 <_zephyris> How does one fix that? (And why does it happen?)
07:23:31 <Rubidium> I guess you tried to push it, then git told you... there's another version where you want to push to. Want to merge before push? Yes => the result you got now
07:23:59 <Rubidium> when you have rebased you need to force push (i.e. overwrite what is in github)
07:27:53 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13918: Change: Package OpenGFX2 for Windows Store and GOG https://github.com/OpenTTD/OpenTTD/pull/13918
07:28:52 <Rubidium> I think I've fixed it for you. You might need to pull locally if you need to make any other changes though
07:29:40 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14016: Remove some macros https://github.com/OpenTTD/OpenTTD/pull/14016#issuecomment-2814795714
07:31:05 <andythenorth> was it time for coffee?
07:31:16 <peter1138[d]> Yes.
07:32:56 <andythenorth> "this is fine" https://github.com/andythenorth/iron-horse/blob/badgers/src/templates/alt_vars_41_badge_predicates.pynml
07:32:59 <andythenorth> only 70 lines eh
07:33:48 <andythenorth> expands to 1500 lines of nml
07:34:28 <andythenorth> 257 switches 🙂
07:43:12 <_zephyris> Thanks @Rubidium
07:43:52 <_zephyris> I'm foolishly using the Github GUI app for general usage, and command line for more complex things
07:44:03 <_zephyris> I think the pull button tries to be clever
07:51:27 <_zephyris> (I should find a proper course)
07:59:06 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1362698945716813844/image.png?ex=680357ca&is=6802064a&hm=38c7e79a69b10d4a77ecc4d036a1f75f45844dceb4767dfeba69d356eefea0a3&
07:59:06 <andythenorth> all the temp storages badges have eliminated 😛
08:04:13 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #14015: Feature: Add options to disable vehicle introduction randomisation and exclusive previews https://github.com/OpenTTD/OpenTTD/pull/14015#pullrequestreview-2777936179
08:17:48 <andythenorth> hmm if do `const foo = LOAD_TEMP(1)`
08:18:02 <andythenorth> will that evaluate when the const is defined, or when it is used 😛
08:31:15 <peter1138[d]> Uh, this level has 40,001 enemies :S
08:32:17 <andythenorth> is the per-level limit 65k?
08:32:38 <andythenorth> ever played coop Doom on null modem?
08:33:12 <peter1138[d]> Yes.
08:34:34 <andythenorth> such ` nmlc ERROR: "generated/iron-horse.nml", line 62219: Expected a compile-time integer constant`
08:35:29 <peter1138[d]> Funny that.
08:38:07 <andythenorth> indeed
08:45:41 *** mindlesstux has quit IRC (Quit: The Lounge - https://thelounge.chat)
08:46:10 *** mindlesstux has joined #openttd
08:51:09 *** mindlesstux has quit IRC (Quit: The Lounge - https://thelounge.chat)
08:51:57 <DorpsGek> [OpenTTD/OpenTTD] tabytac closed pull request #14015: Feature: Add options to disable vehicle introduction randomisation and exclusive previews https://github.com/OpenTTD/OpenTTD/pull/14015
08:52:02 *** mindlesstux has joined #openttd
09:10:37 <peter1138[d]> Uh
09:12:13 <peter1138[d]> tabytac: hopefully you are just rebase and splitting.
09:12:44 <peter1138[d]> Working directly on master does make that harder, which is why I usually mention that if I notice it.
09:17:52 <_zephyris> I'd offer to help, except I've just proven my low level of git competence...
09:25:15 <andythenorth> 'probably fine' https://github.com/andythenorth/iron-horse/blob/badgers/src/utils.py#L89
09:25:37 <andythenorth> `${load_av41('position_in_badge_predicate_chain_with_base_offset_applied')}` such templating
09:30:35 <peter1138[d]> Christ.
09:32:50 <peter1138[d]> Hmm, this PR is strange, the same somehow managed to have the same commits duplicates.
09:37:23 <peter1138[d]> This merge workflow that is meant to be the normal way is definitely messy.
09:41:46 <Rubidium> I reckon you're looking at rebase and merge workflows combined badly, i.e. rebase and pull-merge-push
09:42:03 <michi_cc[d]> _zephyris: It's probably not really trying to be clever, it just assumes you use the "normal" git workflow with merges. Our fully rebase-based workflow is a bit svn-like, and, while fully supported by git, definitely less common when looking at all the projects on e.g. GitHub.
09:43:21 <andythenorth> "yolo merge"
09:43:28 <andythenorth> nobody knows what the base is
09:43:51 <peter1138[d]> The workflow I use for $work is rebase to clean it up, but merging a branch into main is a merge commit.
09:44:11 <peter1138[d]> Because otherwise I'd be committing all my intermediate non-working changes, and that's not useful.
09:44:54 <peter1138[d]> Especially when you have files that make changes to database schemas -- there would be revisions that not only don't work, but shouldn't ever be run because it will impact a database.
09:46:26 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14015: Feature: Add options to disable vehicle introduction randomisation and exclusive previews https://github.com/OpenTTD/OpenTTD/pull/14015#issuecomment-2815096630
10:01:28 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14018: Feature: Add setting to disable vehicle intro date randomisation https://github.com/OpenTTD/OpenTTD/pull/14018
10:01:43 <peter1138[d]> 🤷
10:05:18 <andythenorth> "oh dear" `NameError: global_consants`
10:07:34 <peter1138[d]> Hmm, should I split newgrf_badge into two files, one for badge definition/access, and the other for GUI bits, drawing bits, drop down lists, etc...?
10:08:00 <peter1138[d]> Adding badge configuration and then badge filtering is adding more UI stuff in various places.
10:08:11 <andythenorth> yes
10:08:34 <andythenorth> GPT version "that's an amazing choice, you should definitely do that"
10:08:56 <andythenorth> GenerativeParentingTransformer
10:16:07 <andythenorth> register (storage) is accessed via an 'address'?
10:16:09 <andythenorth> or a num?
10:16:12 <andythenorth> I need to alias something
10:27:55 <andythenorth> `const` is useful
10:28:21 <andythenorth> `LOAD_TEMP(k_addr_wagon_recolour_livery_num_${livery_num})`
10:28:21 <andythenorth> is better than
10:28:21 <andythenorth> `LOAD_TEMP(${temp_storage_map.get("wagon_recolour_livery_num_" + str(livery_num))})`
10:42:31 <andythenorth> and this is better than before `LOAD_TEMP(k_addr_position_in_badge_predicate_chain_from_end)`
10:42:48 <andythenorth> `${weird workarounds}`
10:56:40 <_glx_> Are you abusing `const`?
11:00:30 <andythenorth> no, using it as intended I think
11:00:44 <andythenorth> creating constants
11:01:07 <andythenorth> it cleans up templates so much, compared to the templater doing constant substitution
11:11:25 <peter1138[d]> Alright, does this build now, and is it cleaner...
11:12:19 <andythenorth> everything is cleaner
11:15:47 * andythenorth probably doesn't understand what a predicate is
11:16:00 <andythenorth> `badge_predicate_for_alt_var_41` but it's actually just a badge
11:16:22 <peter1138[d]> Answer: no.
11:25:19 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13993: Add: Player configuration of badge display. https://github.com/OpenTTD/OpenTTD/pull/13993
11:25:49 <andythenorth> no to your own questions? 😛
11:26:25 <andythenorth> `badge_for_alt_var_41_predicate` answers mine 😛
11:29:00 <peter1138[d]> Hm.
11:29:46 <peter1138[d]> Whoops, bus.
11:29:49 <peter1138[d]> No.
11:29:51 <peter1138[d]> BUGS.
11:32:12 *** kuka_lie has joined #openttd
11:33:32 <andythenorth> NO BUGS
11:34:26 <reldred> The only good bug is a dead bug.
11:34:35 <reldred> https://tenor.com/view/starship-troopers-neil-patrick-harris-know-more-gif-5017155
11:36:25 *** nielsm has quit IRC (Ping timeout: 480 seconds)
11:54:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13993: Add: Player configuration of badge display. https://github.com/OpenTTD/OpenTTD/pull/13993
11:56:18 <DorpsGek> [OpenTTD/OpenTTD] reldred commented on pull request #13993: Add: Player configuration of badge display. https://github.com/OpenTTD/OpenTTD/pull/13993#issuecomment-2815313198
11:57:01 <reldred> This is awesome Peter
12:09:31 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14019: Codechange: Turn bit-stuffed FiosType enum into a struct. https://github.com/OpenTTD/OpenTTD/pull/14019
12:15:34 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14020: Codechange: Change StationNameInformation to not use macros. https://github.com/OpenTTD/OpenTTD/pull/14020
12:16:45 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14020: Codechange: Change StationNameInformation to not use macros. https://github.com/OpenTTD/OpenTTD/pull/14020#pullrequestreview-2778425017
12:17:40 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14021: Add: Filtering over badges by dropdown list selection. https://github.com/OpenTTD/OpenTTD/pull/14021
12:19:46 <reldred> Oooh I like that too
12:20:01 <reldred> badge configuration + badge filtering is basically everything I could ever want for a badge system
12:20:22 <reldred> Outside of the backend .grf stuff for doing stuff based on badges.
12:20:30 <reldred> but for the user interface, that's great,
12:22:58 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14020: Codechange: Change StationNameInformation to not use macros. https://github.com/OpenTTD/OpenTTD/pull/14020#pullrequestreview-2778433398
12:23:44 <peter1138[d]> There's a PR for a varaction variable that isn't merged yet.
12:23:53 <peter1138[d]> The nearby-badge test.
12:24:24 <reldred> consider my own contribution to that PR to be 'yes, I want this blz'
12:24:29 <peter1138[d]> Other than all the back-end stuff is "done", unless there's new things people need.
12:24:31 *** gelignite has joined #openttd
12:24:39 <peter1138[d]> I nearly wrote badge-end.
12:24:50 <reldred> UI wise I think with those two PR's cover all the user facing stuff.
12:26:40 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14022: Codechange: Turn custom vehicle spritenums into enum, and use them consistently. https://github.com/OpenTTD/OpenTTD/pull/14022
12:26:45 <peter1138[d]> There may be the possibility to sort badges in the filters better, but currently it's just name.
12:27:24 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14022: Codechange: Turn custom vehicle spritenums into enum, and use them consistently. https://github.com/OpenTTD/OpenTTD/pull/14022#pullrequestreview-2778441302
12:27:40 <reldred> Yeah, maybe, kinda got wait and see what people do with the feature to see if more guardrails need to be put on it
12:28:09 <peter1138[d]> Oh ffs, tabs and spaces. I get that wrong on new files 😦
12:28:29 <reldred> fifty lashings
12:28:30 <peter1138[d]> <https://newgrf-specs.tt-wiki.net/wiki/Action0/Badges>
12:28:46 <peter1138[d]> This suggests a scheme that allows "sub badges" to be grouped and displayed appropriately.
12:28:53 <__abigail> I just alternate each line between tabs and spaces to keep everyone happy
12:29:06 <reldred> that sounds more like keep everyone upset
12:29:12 <peter1138[d]> VS Code gets it right when the file already exists.
12:29:15 <__abigail> https://tenor.com/view/trollface-troll-face-troll-face-phonk-troll-face-terror-dark-gif-3039755119636354997
12:30:07 <peter1138[d]> Oh!
12:30:08 <peter1138[d]> Wait.
12:30:11 <peter1138[d]> it is correct.
12:30:25 <peter1138[d]> But the commit check does not like the .clang-format's version of events.
12:30:38 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1362767279510651031/image.png?ex=6803976e&is=680245ee&hm=5b096e639698606443d62f0004e911e9c96668747fbb935163939a001413a611&
12:30:48 <peter1138[d]> Those are spaces, by clang-format's rules.
12:30:55 <peter1138[d]> commit-checker says no 😮
12:32:35 <reldred> Hmmm, I have many tasks to do
12:32:40 <reldred> I should do some of them
12:34:05 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #14022: Codechange: Turn custom vehicle spritenums into enum, and use them consistently. https://github.com/OpenTTD/OpenTTD/pull/14022#pullrequestreview-2778459835
12:34:19 <peter1138[d]> reldred: houses?
12:35:22 <peter1138[d]> Dear VS Code, don't get me search results for files that have been deleted.
12:36:31 <reldred> peter1138[d]: no, I've got prepare some stuff for 3d printing so more time in blender for me
12:36:32 <frosch123> peter1138[d]: Yes noticed that already, will fix it
12:36:40 <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #13993: Add: Player configuration of badge display. https://github.com/OpenTTD/OpenTTD/pull/13993#pullrequestreview-2778473158
12:36:41 <reldred> need to make up a rig for sizing things correctly
12:37:24 <peter1138[d]> I'm doing the "use the thing for a bit with new code" test 🙂
12:37:42 <peter1138[d]> Blender... is hard.
12:37:55 <peter1138[d]> One of those "you probably really want to learn the keybindings" tools.
12:38:00 <reldred> eh, haven't found it too bad
12:38:02 <peter1138[d]> Except if you don't know what you are a doing...
12:38:16 <frosch123> Vehicle flipping is such a missfeature... there are now two different bits to flip a vehicle, and they randomly interact with each other
12:38:25 <reldred> eh, I didn't know what I was doing with blender 6mo ago
12:38:39 <reldred> but I did have a vague notion of how 3d modelling software works
12:38:48 <reldred> what a vertex, a polygon, a face and an edge is
12:38:48 <frosch123> I think I just open a bug, and let someone fix it who actually likes that feature
12:42:12 <peter1138[d]> One of them is "automatically flipped" the other is "manually flipped"
12:42:17 <peter1138[d]> Unless there's even more 🙂
12:42:51 <peter1138[d]> reldred: I'm okay with 2D editing... Doom maps 🙂
12:44:09 <reldred> heh
12:45:34 <peter1138[d]> Hmm, so should this alignment be tabs or spaces...
12:45:50 <peter1138[d]> Like, tabs is wrong here.
12:47:06 <peter1138[d]> Might just remove the line-wrapping for now.
12:47:43 <_glx_> rare case of no tab prefix?
12:48:18 <_glx_> hmm not so rare actually, only declarations in classes have tabs
12:49:01 <_glx_> yeah commit checker is strict about at least one tab before spaces
12:49:36 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14023: Codechange: Move GUI parts of badges to a separate file. https://github.com/OpenTTD/OpenTTD/pull/14023
12:49:55 <peter1138[d]> Hmm, why is that an extra 60 lines...
12:50:32 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened issue #14024: [Bug]: VRF_REVERSE_DIRECTION behaves inconsistent and erratic https://github.com/OpenTTD/OpenTTD/issues/14024
12:51:49 <peter1138[d]> Includes add a bit, but.
12:52:29 <andythenorth> GPT now pretends to write nml
12:52:41 <andythenorth> it used to write lua or java
12:52:46 <andythenorth> it does it wrong, but eh
12:54:58 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14020: Codechange: Change StationNameInformation to not use macros. https://github.com/OpenTTD/OpenTTD/pull/14020#pullrequestreview-2778519515
12:55:36 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #14024: [Bug]: VRF_REVERSE_DIRECTION behaves inconsistent and erratic https://github.com/OpenTTD/OpenTTD/issues/14024
12:56:05 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #14020: Codechange: Change StationNameInformation to not use macros. https://github.com/OpenTTD/OpenTTD/pull/14020#pullrequestreview-2778520850
13:01:10 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #14023: Codechange: Move GUI parts of badges to a separate file. https://github.com/OpenTTD/OpenTTD/pull/14023
13:04:34 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14025: Codechange: Replace function-like macros with actual functions. https://github.com/OpenTTD/OpenTTD/pull/14025
13:06:49 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14020: Codechange: Change StationNameInformation to not use macros. https://github.com/OpenTTD/OpenTTD/pull/14020
13:07:41 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #14019: Codechange: Turn bit-stuffed FiosType enum into a struct. https://github.com/OpenTTD/OpenTTD/pull/14019#pullrequestreview-2778541557
13:08:00 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14017: Codechange: (re)set multiple bitset flags in one call. https://github.com/OpenTTD/OpenTTD/pull/14017
13:08:09 <_zephyris> Do badges appear in standard (not dev/debug mode) tile info?
13:08:32 <peter1138[d]> No. Should they?
13:19:01 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14026: Codechange: Remove useless macros https://github.com/OpenTTD/OpenTTD/pull/14026
13:19:32 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14022: Codechange: Turn custom vehicle spritenums into enum, and use them consistently. https://github.com/OpenTTD/OpenTTD/pull/14022
13:20:58 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14019: Codechange: Turn bit-stuffed FiosType enum into a struct. https://github.com/OpenTTD/OpenTTD/pull/14019
13:21:53 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14027: Codechange: Replace bitstuffed VehicleEnterTileStatus. https://github.com/OpenTTD/OpenTTD/pull/14027
13:28:08 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14026: Codechange: Remove useless macros https://github.com/OpenTTD/OpenTTD/pull/14026#pullrequestreview-2778583601
13:28:47 <peter1138[d]> lengthof shouldn't be used. We just haven't mass-removed it yet.
13:30:31 <peter1138[d]> I think there was an attempt even :p
13:34:14 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14026: Codechange: Remove useless macros https://github.com/OpenTTD/OpenTTD/pull/14026#pullrequestreview-2778595084
13:37:11 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14026: Codechange: Remove useless macros https://github.com/OpenTTD/OpenTTD/pull/14026#pullrequestreview-2778598884
13:39:43 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14016: Remove some macros https://github.com/OpenTTD/OpenTTD/pull/14016
13:40:37 <andythenorth> 4 random bits is a range 0-16?
13:41:05 <andythenorth> oh this isn't GPT 😛
13:41:32 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #14016: Codechange: Unify naming of "SnowOrDesert" functions https://github.com/OpenTTD/OpenTTD/pull/14016#pullrequestreview-2778608298
13:45:26 <_zephyris> peter1138[d]: They possibly should - tile info is the normal user-facing info about houses, so makes sense to find badges there IMO.
13:54:35 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14027: Codechange: Replace bitstuffed VehicleEnterTileStatus. https://github.com/OpenTTD/OpenTTD/pull/14027#pullrequestreview-2778622698
13:56:59 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14028: Change: Don't replace stripped control codes with '?' for scripts. https://github.com/OpenTTD/OpenTTD/pull/14028
13:58:38 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14026: Codechange: Remove useless macros https://github.com/OpenTTD/OpenTTD/pull/14026
14:01:59 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #14026: Codechange: Remove useless macros https://github.com/OpenTTD/OpenTTD/pull/14026#pullrequestreview-2778653137
14:13:22 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14028: Change: Don't replace stripped control codes with '?' for scripts. https://github.com/OpenTTD/OpenTTD/pull/14028#pullrequestreview-2778681415
14:27:21 *** nielsm has joined #openttd
14:33:30 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14016: Codechange: Unify naming of "SnowOrDesert" functions https://github.com/OpenTTD/OpenTTD/pull/14016
14:37:20 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14029: Codechange: Ini(Load|Save)WindowSettings expect a WindowDesc*, no void*. https://github.com/OpenTTD/OpenTTD/pull/14029
14:38:22 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
14:38:39 *** WormnestAndroid has joined #openttd
14:39:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #14029: Codechange: Ini(Load|Save)WindowSettings expect a WindowDesc*, no void*. https://github.com/OpenTTD/OpenTTD/pull/14029#pullrequestreview-2778731903
14:47:45 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242
14:49:22 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242#issuecomment-2815586253
15:13:53 *** jinks has quit IRC (Remote host closed the connection)
15:15:20 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242#issuecomment-2815625550
15:15:54 *** jinks has joined #openttd
15:16:52 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14026: Codechange: Remove useless macros https://github.com/OpenTTD/OpenTTD/pull/14026
15:29:21 <xarick> suggestion for "show vehicles on map" - ability to disable vehicle per type
15:32:06 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #14023: Codechange: Move GUI parts of badges to a separate file. https://github.com/OpenTTD/OpenTTD/pull/14023#pullrequestreview-2778832536
15:34:29 <reldred> ugh, i've done a lot of blendering tonight and I still have considerable amounts more
15:34:35 <reldred> time for slep
15:36:28 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #14018: Feature: Add setting to disable vehicle intro date randomisation https://github.com/OpenTTD/OpenTTD/pull/14018#pullrequestreview-2778840240
15:37:35 <andythenorth> pff 6 hours arsing around trying to randomise mail cars nicely
15:37:43 <andythenorth> "it will be a quick change"
15:38:08 <andythenorth> I already know I should just pre-generate deterministic random maps 😛
15:39:25 *** nielsm has quit IRC (Ping timeout: 480 seconds)
15:43:52 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
15:45:29 *** WormnestAndroid has joined #openttd
15:46:23 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14030: Fix e49150f9ca: House picker crashes if selection is not available. https://github.com/OpenTTD/OpenTTD/pull/14030
15:52:09 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #14030: Fix e49150f9ca: House picker crashes if selection is not available. https://github.com/OpenTTD/OpenTTD/pull/14030#pullrequestreview-2778866010
15:57:37 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
16:00:04 *** WormnestAndroid has joined #openttd
16:02:13 *** k-man has quit IRC (Ping timeout: 480 seconds)
16:04:07 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
16:04:49 *** WormnestAndroid has joined #openttd
16:06:23 *** SigHunter has quit IRC ()
16:06:53 <peter1138[d]> LordAro, is that emoji like an approval but without actually committing to approving it? :p
16:09:37 *** SigHunter has joined #openttd
16:10:18 *** k-man has joined #openttd
16:10:26 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14031: Codechange: Add filename and line number to errors/warnings of the squirrel-exporters. https://github.com/OpenTTD/OpenTTD/pull/14031
16:17:07 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242#pullrequestreview-2778925952
16:18:16 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14031: Codechange: Add filename and line number to errors/warnings of the squirrel-exporters. https://github.com/OpenTTD/OpenTTD/pull/14031#pullrequestreview-2778929899
16:20:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14028: Change: Don't replace stripped control codes with '?' for scripts. https://github.com/OpenTTD/OpenTTD/pull/14028
16:20:34 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14023: Codechange: Move GUI parts of badges to a separate file. https://github.com/OpenTTD/OpenTTD/pull/14023
16:20:47 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14032: Codechange: Manage script event queue using smart pointers. https://github.com/OpenTTD/OpenTTD/pull/14032
16:25:11 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
16:25:35 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242#issuecomment-2815792636
16:25:57 *** WormnestAndroid has joined #openttd
16:35:18 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242#pullrequestreview-2778974638
16:38:11 *** Wolf01 has joined #openttd
16:38:57 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242#issuecomment-2815820307
16:39:28 <DorpsGek> [OpenTTD/OpenTTD] tabytac commented on pull request #14018: Feature: Add setting to disable vehicle intro date randomisation https://github.com/OpenTTD/OpenTTD/pull/14018#issuecomment-2815820928
16:41:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242#issuecomment-2815823817
16:42:00 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242#issuecomment-2815824978
16:43:55 <LordAro> peter1138[d]: yes
16:44:06 <frosch123> Sorry for bringing up the shed colours, I hope zorg does not get started
16:45:02 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14029: Codechange: Ini(Load|Save)WindowSettings expect a WindowDesc*, no void*. https://github.com/OpenTTD/OpenTTD/pull/14029
16:46:18 <peter1138[d]> Hmm, in fact, maybe I can put those colour constants somewhere to allow reusing for the other settings windows.
16:50:06 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13993: Add: Player configuration of badge display. https://github.com/OpenTTD/OpenTTD/pull/13993
16:56:15 <peter1138[d]> CI again 😄
17:00:36 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13993: Add: Player configuration of badge display. https://github.com/OpenTTD/OpenTTD/pull/13993
17:07:24 <peter1138[d]> Also updated it to use StringConsumer instead of... not.
17:21:00 <DorpsGek> [OpenTTD/website] rubidium42 closed pull request #346: Add: 'Release or not' news item https://github.com/OpenTTD/website/pull/346
17:22:39 <DorpsGek> [OpenTTD/website] rubidium42 closed pull request #319: Add: message to GRFCodec download pages that those pages are effectively deprecated https://github.com/OpenTTD/website/pull/319
17:28:58 *** nielsm has joined #openttd
17:28:59 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14032: Codechange: Manage script event queue using smart pointers. https://github.com/OpenTTD/OpenTTD/pull/14032#pullrequestreview-2779074471
17:34:36 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
17:34:56 <peter1138[d]> Type-erasure in extreme.
17:38:02 *** WormnestAndroid has joined #openttd
17:42:44 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14033: Codechange: Turn AyStar into an actual class with virtual methods instead of function pointers. https://github.com/OpenTTD/OpenTTD/pull/14033
17:43:35 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14031: Codechange: Add filename and line number to errors/warnings of the squirrel-exporters. https://github.com/OpenTTD/OpenTTD/pull/14031
17:47:33 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14032: Codechange: Manage script event queue using smart pointers. https://github.com/OpenTTD/OpenTTD/pull/14032
17:48:07 <talltyler> andythenorth: Look at all these random wagon consists! (on a very nice layout)
17:48:07 <talltyler> https://www.youtube.com/watch?v=NJ0mrbojo6s
17:55:17 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1362848981184680007/image.png?ex=6803e385&is=68029205&hm=5344dfc96b8131551cf93796629d78a40a6eca7bedb49ed513c83c6401f176ee&
17:55:17 <peter1138[d]> Oops, broken it :S
17:56:25 <peter1138[d]> Ah, string_view was valid until I refactored it.
18:12:24 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14034: Codechange: Change SetDateCallback into a std::function, so there is no need for void* user data. https://github.com/OpenTTD/OpenTTD/pull/14034
18:20:21 <andythenorth> lol @ GPT and nml
18:20:53 <andythenorth> it can now do the syntax, but it generates code that ought to work, but assumes things about nml having more capability than it does 🙂
18:24:51 <_zephyris> With prompting it can generate correct code... Unfortunately you need to know what is correct to nudge it in the right direction.
18:25:06 <andythenorth> _glx_: is const a single global table, or can I redefine the const values for different blocks in the file?
18:37:44 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14034: Codechange: Change SetDateCallback into a std::function, so there is no need for void* user data. https://github.com/OpenTTD/OpenTTD/pull/14034
18:40:51 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
18:40:52 *** WormnestAndroid has joined #openttd
18:43:02 *** tokai has joined #openttd
18:43:02 *** ChanServ sets mode: +v tokai
18:46:32 *** Tirili has joined #openttd
18:50:10 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
18:56:16 *** Tirili has quit IRC (Quit: Leaving)
18:58:17 <_glx_> andythenorth: It's global, it's the same table as NML provided constants
18:59:03 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #14033: Codechange: Turn AyStar into an actual class with virtual methods instead of function pointers. https://github.com/OpenTTD/OpenTTD/pull/14033#pullrequestreview-2779228384
19:02:38 <andythenorth> thanks
19:02:45 <andythenorth> no redefining per switch then 🙂
19:04:42 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
19:06:35 *** WormnestAndroid has joined #openttd
19:11:54 <andythenorth> `Or expose a debugging switch in NML to overlay the map index or sprite type in-game.` lol GPT how little accuracy your training data has on this 😛
19:12:28 <andythenorth> I mean...I could bitmap all possible values of a var with a sprite font and show it in a spritelayer
19:12:38 <andythenorth> or I could learn to use lldb 😛
19:17:43 <peter1138[d]> Vs Code integrates with it, I dunno what environment you use.
19:19:00 <peter1138[d]> Turns out I can't code when I've got to the pub instead.
19:20:21 <_zephyris> Isn't that a feature for sprite layouts?
19:20:48 <_zephyris> Stumbled across it by accident, setting a literal value rather than sprite set and index
19:20:55 <_zephyris> (might be misremembering those terms)
19:25:25 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14034: Codechange: Change function pointer callbacks into std::function, so there is no need for void* user data. https://github.com/OpenTTD/OpenTTD/pull/14034#pullrequestreview-2779277468
19:29:30 <peter1138[d]> I was told/saw once that there are overheads to std::function
19:29:52 <peter1138[d]> I know JGRPP replaced some.
19:33:31 <_jgr_> I think that was pool iteration, preferring template functors over std::function. The ones in #14034 are not called especially often, it shouldn't be a problem.
20:10:37 <andythenorth> GPT doesn't like nml default 'return' in switches for unhandled value ranges
20:10:46 <andythenorth> doesn't fit the pattern 😛
20:37:20 <andythenorth> hmm
20:37:30 <andythenorth> can I have some random bits from the shared order group? 😛
20:42:32 <frosch123> peter1138[d]: Yes, std::function involves a heap allocation and two indirect calls instead of one.
20:42:32 <frosch123> Lambdas by reference can live on the stack, but require templates and moving everything to the header. In the dateselector callback using the stack is not possible though, the callback outlives the stack frame.
20:43:45 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14034: Codechange: Change function pointer callbacks into std::function, so there is no need for void* user data. https://github.com/OpenTTD/OpenTTD/pull/14034
20:47:15 *** aha has joined #openttd
20:47:15 <aha> Reposting here the question in https://discord.com/channels/142724111502802944/142725338831519744/1362889363117314309 as I feel like that's an important design issue with the current version
20:49:03 <_jgr_> If the functor (including captures, etc) is below a certain size, a heap allocation isn't needed for std::function, it uses the small object optimisation like std::string
20:50:07 <andythenorth> deterministic pseudo-random is my new favourite thing (again)
20:52:07 <peter1138[d]> aha: If you're going to repost you need to actually repost.
20:54:14 <aha> peter1138[d]: I thought a direct link to the message would suffice.
20:54:14 <aha> Here is the original report of a confused player: https://discord.com/channels/142724111502802944/142725338831519744/1362857501619519631
20:54:14 <aha> And my reply to it:
20:54:14 <aha> If ~16 tiles as seen in the screenshot is too far to find a depot, shouldn't the search radius be a customizable setting or at least communicated to the player in some way? This is a very important mechanic that can ruin the network's efficiency which the players won't really learn unless somebody tells them or they find a niche tutorial about it – sounds like a significant UX issue
20:54:14 <aha> Especially as train lengths can be increased way beyond that length up to 64, so I think it would be logical to assume longer trains would be fine with pathfinding to depots with sufficiently long tracks as not to slow down the line they are servicing by slowing down to go into a depot while their rears are still on the main line
20:56:49 <_glx_> best is to use "service at" orders
20:57:30 <_glx_> pathfinder can't even find depots next to the reserved track
21:01:32 <aha> There may be workarounds, but there is no way for new players to learn that a train has a limited search radius for depots that are not on the direct line to its destination (even though it's common knowledge that you shouldn't build depots directly on the line for efficiency reasons!). Even experienced players have only a rough idea that it is the case, but they usually don't have an exact number
21:01:32 <aha> as it is not communicated anywhere. Also, if their train fails to service for this reason, they are not told in any way why it did not service despite having depots along the path. This may not be solvable on a new player's side without external help and cause them to drop the game entirely, which I would assume is one of the worst results an issue can have
21:02:36 <_glx_> most players disable breakdowns anyway
21:06:03 *** coobies has joined #openttd
21:06:03 <coobies> Maybe they do in part because they can't figure out this behavior and it makes breakdowns seem unplayable
21:06:31 <aha> _glx_: Is that actually tracked with statistics data or an educated guess? Breakdowns default to reduced and it is not that easy to stumble upon that setting without going much in-depth into the game. I'd be glad to be proven wrong, but I would assume a typical player runs default settings in the beginning and only customizes them once they learn more
21:06:44 <coobies> It is tracked now
21:07:43 <_jgr_> <https://survey.openttd.org/summaries/2025/q1/14#game.settings.difficulty.vehicle_breakdowns>
21:08:09 <_jgr_> 1 is reduced, the default
21:08:39 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14033: Codechange: Turn AyStar into an actual class with virtual methods instead of function pointers. https://github.com/OpenTTD/OpenTTD/pull/14033
21:08:51 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
21:10:17 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14033: Codechange: Turn AyStar into an actual class with virtual methods instead of function pointers. https://github.com/OpenTTD/OpenTTD/pull/14033#pullrequestreview-2779437534
21:10:59 *** WormnestAndroid has joined #openttd
21:11:44 <aha> So statistically around 2/3 of the players are possibly affected by an important mechanic they are not told about at any point and only possibly know about from their own experiments or vague ideas shared by more experienced players. That *realy* doesn't sound good UX-wise.
21:12:54 <_jgr_> It's done this way because that is how it is done in the original TTD, not because it makes for good UX or gameplay
21:15:47 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14033: Codechange: Turn AyStar into an actual class with virtual methods instead of function pointers. https://github.com/OpenTTD/OpenTTD/pull/14033#pullrequestreview-2779443552
21:16:40 <frosch123> I turned CircularTileSearch into an iterator, so it can be used in a loop instead of with a callback.
21:16:40 <frosch123> Now I wonder whether I can create a mock map in the unit tests
21:20:51 <Rubidium> allocating a 64x64 map should be possible. You only need to populate it with something other than water, but that shouldn't be that hard I think (e.g. grassy tiles)
21:23:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14025: Codechange: Replace function-like macros with actual functions. https://github.com/OpenTTD/OpenTTD/pull/14025#pullrequestreview-2779454354
21:41:41 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14025: Codechange: Replace function-like macros with actual functions. https://github.com/OpenTTD/OpenTTD/pull/14025
21:43:02 <andythenorth> naptime?
21:47:22 *** nielsm has quit IRC (Ping timeout: 480 seconds)
21:50:53 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
22:00:50 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:17:16 *** gelignite has quit IRC (Quit: Stay safe!)
22:24:18 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14033: Codechange: Turn AyStar into an actual class with virtual methods instead of function pointers. https://github.com/OpenTTD/OpenTTD/pull/14033
22:35:54 <DorpsGek> [OpenTTD/OpenTTD] meganukebmp opened issue #14035: [Bug]: OpenTTD does not consider FluidSynth config https://github.com/OpenTTD/OpenTTD/issues/14035
22:37:53 <DorpsGek> [OpenTTD/OpenTTD] meganukebmp commented on issue #14035: [Bug]: OpenTTD does not consider FluidSynth config https://github.com/OpenTTD/OpenTTD/issues/14035
22:39:42 *** kuka_lie has quit IRC (Quit: Lost terminal)
22:42:14 <DorpsGek> [OpenTTD/OpenTTD] meganukebmp commented on issue #14035: [Bug]: OpenTTD does not consider FluidSynth config https://github.com/OpenTTD/OpenTTD/issues/14035
22:49:55 *** Jekai has joined #openttd
22:53:38 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242#issuecomment-2816319576
22:56:18 *** Jekai has quit IRC (Quit: Page closed)
23:58:23 <peter1138[d]> Right. I made it back.
continue to next day ⏵
