IRC logs for #openttd on OFTC at 2025-04-13
            
00:18:51 <belajalilija> andythenorth: Nah
00:19:20 <belajalilija> I think that goes against the spirit of your set
00:39:52 <talltyler> Iโ€™ll take the opposite opinion and agree with Andy, that might be nice. Horse already has some opinionated wagon colours in the farm product wagons and red mail wagons.
01:21:02 *** jfkuayue has quit IRC (Read error: Connection reset by peer)
01:21:02 *** coobies has quit IRC (Write error: connection closed)
01:21:02 *** eratonysiad has quit IRC (Write error: connection closed)
01:21:02 *** _jgr_ has quit IRC (Write error: connection closed)
01:21:02 *** brickblock19280 has quit IRC (Write error: connection closed)
01:21:02 *** belajalilija has quit IRC (Write error: connection closed)
01:21:02 *** truebrain has quit IRC (Write error: connection closed)
01:21:02 *** andythenorth has quit IRC (Write error: connection closed)
01:21:02 *** _rei4122 has quit IRC (Write error: connection closed)
01:21:02 *** kuhnovic has quit IRC (Write error: connection closed)
01:21:02 *** DorpsGek_vi has quit IRC (Write error: connection closed)
01:21:02 *** merni has quit IRC (Read error: Connection reset by peer)
01:21:02 *** tabytac has quit IRC (Read error: Connection reset by peer)
01:21:02 *** fairyflossy has quit IRC (Write error: connection closed)
01:21:02 *** frosch123 has quit IRC (Write error: connection closed)
01:21:02 *** enveeed has quit IRC (Read error: Connection reset by peer)
01:21:02 *** zanooda2000 has quit IRC (Read error: Connection reset by peer)
01:21:02 *** exceptik has quit IRC (Write error: connection closed)
01:21:02 *** peter1138[d] has quit IRC (Write error: connection closed)
01:21:02 *** emperorjake has quit IRC (Read error: Connection reset by peer)
01:21:02 *** talltyler has quit IRC (Write error: connection closed)
01:21:02 *** _zephyris has quit IRC (Read error: Connection reset by peer)
01:21:02 *** _glx_ has quit IRC (Read error: Connection reset by peer)
01:21:02 *** grass_550 has quit IRC (Write error: connection closed)
01:21:02 *** notluke2578 has quit IRC (Write error: connection closed)
01:21:02 *** xarick has quit IRC (Write error: connection closed)
01:21:02 *** __abigail has quit IRC (Write error: connection closed)
01:21:02 *** locosage has quit IRC (Write error: connection closed)
01:21:02 *** yiffgirl has quit IRC (Write error: connection closed)
01:21:02 *** florafex has quit IRC (Read error: Connection reset by peer)
01:21:02 *** alphalink06 has quit IRC (Read error: Connection reset by peer)
01:21:23 *** DorpsGek_vi has joined #openttd
01:25:56 *** gelignite has quit IRC (Quit: Stay safe!)
02:14:37 *** gnu_jj_ has joined #openttd
02:18:07 *** gnu_jj has quit IRC (Ping timeout: 480 seconds)
02:32:24 *** Flygon has joined #openttd
02:37:40 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
02:37:42 *** WormnestAndroid has joined #openttd
02:37:58 *** WormnestAndroid has quit IRC (Remote host closed the connection)
02:37:59 *** WormnestAndroid has joined #openttd
02:38:19 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
02:38:20 *** WormnestAndroid has joined #openttd
03:02:00 *** Tirili has joined #openttd
03:05:29 *** Tirili has quit IRC ()
03:05:36 *** Tirili has joined #openttd
03:14:10 *** Tirili has quit IRC (Quit: Leaving)
03:50:20 *** D-HUND has joined #openttd
03:53:45 *** debdog has quit IRC (Ping timeout: 480 seconds)
04:07:11 *** D-HUND is now known as debdog
04:09:36 *** keikoz has joined #openttd
05:04:59 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/04c41bf731ebeeafc00edb4b5aa7acfe655b81d3
05:05:00 <DorpsGek> - Update: Translations from eints (by translators)
06:57:32 *** gelignite has joined #openttd
06:59:09 <DorpsGek> [OpenTTD/OpenTTD] dominicblade commented on issue #13756: [Bug]: online content is not displayed in the game https://github.com/OpenTTD/OpenTTD/issues/13756
07:05:51 *** nielsm has joined #openttd
07:06:41 *** andythenorth has joined #openttd
07:06:41 <andythenorth> are they 'colour mixes' or 'liveries'?
07:07:23 <andythenorth> I didn't call them 'livery' because possibly nobody knows what that means
07:13:50 <Rubidium> a livery is just the way the vehicle is painted/stickered, right?
07:15:23 <DorpsGek> [OpenTTD/OpenGFX2] zephyris updated pull request #174: Fix: Avoid string concatenation for baseset description https://github.com/OpenTTD/OpenGFX2/pull/174
07:17:10 <andythenorth> yes
07:17:25 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1360876515004252291/image.png?ex=67fcb685&is=67fb6505&hm=9e1d1c81ff5f3705295e6c6165304a5bff28e4c9e2917d4e2239aee541c94b1d&
07:17:25 <andythenorth> the game uses it
07:17:52 *** Wolf01 has joined #openttd
07:20:38 <DorpsGek> [OpenTTD/nml] andythenorth commented on pull request #359: Add: Support for NewGRF badges. https://github.com/OpenTTD/nml/pull/359#issuecomment-2799837785
07:48:51 <DorpsGek> [OpenTTD/OpenGFX2] zephyris commented on pull request #174: Fix: Avoid string concatenation for baseset description https://github.com/OpenTTD/OpenGFX2/pull/174#issuecomment-2799845821
07:49:36 <andythenorth> is there a way to get the windows nmlc.exe for 359?
07:49:54 *** akimoto has quit IRC (Ping timeout: 480 seconds)
07:57:37 <peter1138> Yes, build it?
08:02:00 <andythenorth> my build / dist artefacts are all macos
08:03:27 <andythenorth> google suggests I could cross-compile to Windows with clang
08:23:30 *** nielsm has quit IRC (Ping timeout: 480 seconds)
08:29:23 <peter1138> Hmm, phantom breakpoints.
08:29:59 <andythenorth> phantom tuples here
08:30:17 <andythenorth> copy params to a method, forget to remove a trailing comma
08:33:53 <peter1138> Can articulated road vehicles carry different cargo types? I think they can...
08:34:31 <andythenorth> doesn't work so great mixed with pax ๐Ÿ™‚
08:34:38 <andythenorth> unroutable
08:34:42 <peter1138> Heh, true.
08:34:46 <andythenorth> tried it ๐Ÿ˜›
08:35:03 <peter1138> WhoCanServiceIndustry() seems to assume they can't.
08:43:05 <andythenorth> wouldn't account for articulated ships either ๐Ÿ˜›
08:43:48 <andythenorth> hmm aircraft, but with an industry where the cargos are pax and mail
08:53:38 <peter1138> Articulated cargo.
08:54:00 <peter1138> If ships could transport other vehicles...
08:54:20 <andythenorth> double side quest
08:54:35 <andythenorth> but everything's just pointers, right?
08:54:38 <peter1138> Ships are vehicles.
08:54:49 <peter1138> Therefore if vehicles could transport other vehicles...
08:55:15 <peter1138> How many nested levels could you achieve?
08:57:22 <andythenorth> "yes"
08:57:31 <andythenorth> imagine the conditional orders though
08:57:35 <peter1138> Airbus Beluga -> Train -> Vans -> Log rafts -> Paper aeroplanes.
08:57:37 <andythenorth> would need a loop unroll
08:58:07 <peter1138> Barrel unroll.
08:58:46 <andythenorth> double helix
09:00:27 *** michi_cc[d] has joined #openttd
09:00:27 <michi_cc[d]> Is there any point in trying for a release today, or is there still too much half-done stuff in master?
09:02:47 *** _glx_ has joined #openttd
09:02:47 <_glx_> Would be a good way to find all hidden bugs
09:13:17 *** xarick has joined #openttd
09:13:17 <xarick> hi
09:14:06 *** Heiki has joined #openttd
09:14:07 <Heiki> I think there is a slight inconsistency in the OpenGFX2 strings: STR_GRF_DESCRIPTION says โ€œGPL v2+โ€, but STR_GENERAL_DESC and STR_OBG_DESCRIPTION_EXTRA state โ€œFreely available under the terms of the GNU General Public License version 2โ€ rather than โ€œversion 2 or laterโ€
09:24:24 <xarick> licenses are boring
09:28:09 <peter1138> Is there anything in the Action 3 spec that says whether remapping an item will be ignored or not?
09:28:25 <peter1138> It seems somewhat inconsistent.
09:41:37 <xarick> in the spirit of infinite money, should my AI buy exclusive transport rights on every town?
09:41:55 <xarick> or is that too much cheating
09:48:33 <xarick> woah, I forgot NoCAB does really impressive rail networks
09:50:55 <andythenorth> badges are better flat-ish?
09:50:57 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1360915153696063528/image.png?ex=67fcda81&is=67fb8901&hm=15a1bd7662beccf3bc93df8344db935096d0b6c10733e894c2d24aa22cfd0d1e&
09:50:57 <xarick> okay, not so impressive after all
09:51:24 <andythenorth> I should arse around with "ih/vehicle_metadata/gen/4" or "ih/vehicle_metadata/behaviour/random_wagon"
09:51:43 <andythenorth> it's not a taxonomy of properties eh
09:54:16 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1360915990237548644/image.png?ex=67fcdb48&is=67fb89c8&hm=044dad15ac08f02f8ed0e37e9ce2bf94e4357f368fcdf3dfd9c3dd87c209e05f&
09:54:20 <peter1138> Think I'll just remove the bit that skips it.
10:08:33 *** _zephyris has joined #openttd
10:08:33 <_zephyris> @Heiki it should match ogfx, can't remember what that is, pop a note on the PR
10:10:52 <Heiki> https://github.com/OpenTTD/OpenGFX/blob/master/lang/english.lng oh, OpenGFX already had the same inconsistency
10:20:36 <andythenorth> ok so `ih_gen/4`, `ih_gen/5` as badges
10:20:46 <andythenorth> filter on gen?
10:20:48 <DorpsGek> [OpenTTD/OpenGFX2] hpiirai commented on pull request #174: Fix: Avoid string concatenation for baseset description https://github.com/OpenTTD/OpenGFX2/pull/174#issuecomment-2799894131
10:20:52 <andythenorth> for autoreplace?
10:22:02 <andythenorth> unrelated, can we use `f"{}"` format strings in nmlc?
10:22:48 <andythenorth> introduced in python 3.6 afaict
10:25:15 <andythenorth> nvm, I see we already have an idiom for printing line number, that will do
10:26:43 <DorpsGek> [OpenTTD/nml] andythenorth commented on pull request #359: Add: Support for NewGRF badges. https://github.com/OpenTTD/nml/pull/359#issuecomment-2799895878
10:43:57 <DorpsGek> [OpenTTD/nml] PeterN updated pull request #359: Add: Support for NewGRF badges. https://github.com/OpenTTD/nml/pull/359
10:47:32 <andythenorth> ๐Ÿ‘
10:49:07 *** zanooda2000 has joined #openttd
10:49:07 <zanooda2000> andythenorth: Maybe "double" will fit?
10:50:24 *** SigHunter has quit IRC ()
10:50:49 <zanooda2000> Or just "special", can also be used for Torpedo wagon and that super-small but capacious slav wagons
10:51:13 <andythenorth> considering other options
10:51:19 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1360930346283307179/image.png?ex=67fce8a7&is=67fb9727&hm=b941928081228cc1310e733176044570b3f3736acd1939af03761701bf2cf45a&
10:51:49 <andythenorth> although..Gen could be a separate badge
10:52:00 <andythenorth> or it's just visual noise
10:52:38 <zanooda2000> Hmm... "tags" instead of taxonomy?
10:52:41 <DorpsGek> [OpenTTD/OpenGFX2] hpiirai commented on pull request #174: Fix: Avoid string concatenation for baseset description https://github.com/OpenTTD/OpenGFX2/pull/174#issuecomment-2799903733
10:52:44 <andythenorth> maybe
10:53:10 *** SigHunter has joined #openttd
10:54:20 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1360931105406058686/image.png?ex=67fce95c&is=67fb97dc&hm=dbf981ab26c6d72285bb663d26e06cc3ff1f6cd3f89d811741b4df5605b69e59&
10:55:09 <andythenorth> the "Gen 4" is only really there because OpenTTD doesn't show wagon intro dates
10:55:28 <andythenorth> players shouldn't need to see it really
10:55:55 <andythenorth> and repeating "Product Tanker" is just needless duplication of the vehicle name
10:56:04 <peter1138> As badges is merged, the NML PR is probably not experimental any more...
10:56:22 <andythenorth> approve it IMHO
10:56:23 *** __abigail has joined #openttd
10:56:23 <__abigail> andythenorth: Please add a scientific name for them ๐Ÿฅบ
10:56:28 <andythenorth> I'm using it for weeks
10:56:40 <andythenorth> __abigail: in Latin?
10:56:45 <__abigail> Yeah
10:56:47 <peter1138> Watching a video of someone making a track using a single synth... that I also have.
10:57:02 <peter1138> All I do is just make it make a noise :S
10:58:06 <andythenorth> how are badges ordered in the purchase text?
10:58:09 <andythenorth> declaration order?
10:58:58 <peter1138> Basically, consider the classes unordered. Each name is added in the order it appears in the badge property, though.
10:59:18 <andythenorth> the classes are declaration order
10:59:31 <andythenorth> obvs you wrote it, you'd know that ๐Ÿ˜›
10:59:36 <andythenorth> just telling myself by testing in grf
10:59:46 <peter1138> Yes, but considered it unordered, i.e. don't rely on that.
11:01:07 <andythenorth> can I consider it 'ordered, with no warranty"? ๐Ÿ˜›
11:05:46 <andythenorth> ok I've dropped the 'Length' badge, bit weird, but seems to be preferable
11:08:52 <zanooda2000> andythenorth: it is extremely useful when "no vehicle expire" is enabled
11:09:19 <zanooda2000> hmm, btw, why iron horse not supports inflation?
11:09:33 <peter1138> Hehehe
11:11:26 <peter1138> andythenorth believes inflation is a bug and wants nothing to do with it.
11:12:01 <peter1138> See also "why is money pointless?"
11:12:11 *** fairyflossy has joined #openttd
11:12:11 <fairyflossy> andythenorth: oh is this a JGR-only feature? I could've sworn I had wagon intro dates in my game but I wouldn't be surprised if that's a JGR thing
11:13:41 <zanooda2000> peter1138: for many players, moneymaking is just another play style
11:13:41 <zanooda2000> especiallyin **tycoon** game
11:13:41 <zanooda2000> it's like "Minecraft is easy enough let's remove survival game mode"
11:15:07 <zanooda2000> fairyflossy: also shown in xussr, but as another description line
11:15:46 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1360936499582992474/image.png?ex=67fcee62&is=67fb9ce2&hm=d4348f6b02c67a26359832fa57d86ae7bc80107c6d175d6f92f368ecdef51020&
11:15:46 <andythenorth> this was a terrible idea
11:15:59 <andythenorth> (depot vertical gridlines)
11:16:28 <peter1138> Contrary to "popular"(?) belief, there is no magical fairy that transfers changes in JGRPP back to vanilla.
11:17:23 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1360936906010923008/image.png?ex=67fceec3&is=67fb9d43&hm=05298577554a18cc95d2c8500d4a23aa19a514d6c5ea8b0565af68fa9c74fc31&
11:17:23 <andythenorth> so 'gen' would be useful in cases like this
11:17:32 <andythenorth> there's not much I can do there to vary the sprites
11:17:54 <andythenorth> sprite with the generation number ๐Ÿ˜›
11:18:48 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1360937263269154886/image.png?ex=67fcef18&is=67fb9d98&hm=3902cf92edb5943ce46e6589174e0eb675f8ed6a7fa1c5571d641aa14f27b2ea&
11:18:48 <andythenorth> dunno, I feel it's imperative to reduce the amount of text shown
11:20:03 <zanooda2000> ... stop using that oversized first 5 steeltown?
11:20:23 <peter1138> And people want the game to have more cargo types.
11:21:09 <zanooda2000> There is a point when adding more cargo just adds more frustration.
11:21:09 <zanooda2000> Especially if it is just 28 types of steel
11:21:23 <peter1138> That's okay, you don't have to use it.
11:21:31 <andythenorth> no they do
11:21:33 <andythenorth> everyone must
11:22:11 * andythenorth andythenorth: "I can't use JGRPP it's overwhelmingly confusing"
11:22:24 <andythenorth> also _"andythenorth: FIRS 5 Steeltown"_
11:23:14 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #13934: Add #12939: [NewGRF] Add road-/tram-/rail-type variable 0x45 to get mutual road-/tram-/rail-type on same tile https://github.com/OpenTTD/OpenTTD/pull/13934
11:25:14 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1360938882371293355/image.png?ex=67fcf09a&is=67fb9f1a&hm=ed8bd8857f0e2234b1e942f70a56fd89d90476edb44b900d1e787e53ea1a34c9&
11:25:14 <andythenorth> what else would we want to know about the wagon?
11:25:48 <andythenorth> I've dropped "Length", I'm sentimentally attached to it, Horse has used it for a long time, but it's not needed
11:26:04 <andythenorth> I do think "Gen" might be useful, but does anyone know what that means?
11:26:27 <andythenorth> bearing in mind part of the audience don't understand version numbers
11:26:27 *** reldred has joined #openttd
11:26:27 <reldred> I wouldn't mind it
11:26:43 <reldred> part of the audience would probably eat tide pods
11:26:59 *** peter1138[d] has joined #openttd
11:26:59 <peter1138[d]> andythenorth: What if the game does this?
11:27:23 <peter1138> Nothing would line up, so it would be very fun.
11:27:50 <reldred> also lol at telling the author of firs5 steeltown to stop using firs5 steeltown
11:29:20 <zanooda2000> andythenorth: Well, it was just useful.
11:29:20 <zanooda2000> Is there another way to find the exact length except sorting by capacity or visually searching through menu?
11:30:08 <andythenorth> Visually
11:31:00 <andythenorth> Possibly OpenTTD should handle it, but thatโ€™s a lot more complex than adding a badge
11:31:29 <peter1138> Oh I see, Black.
11:31:41 <zanooda2000> reldred: Well, he wanted to decrease the amount of text on the screen. There was a way to do it. At least for badge testing purposes, vanilla will be fine
11:33:02 <DorpsGek> [OpenTTD/nml] PeterN updated pull request #359: Add: Support for NewGRF badges. https://github.com/OpenTTD/nml/pull/359
11:33:20 <andythenorth> ok so if I want to give players a grf parameter to hide / show badges
11:33:27 <andythenorth> I need to action 7 my action 0
11:33:41 <andythenorth> or I could maybe action 7 the badge instead and drop the string?
11:33:52 <peter1138> No.
11:33:58 <andythenorth> I want to keep the badges on the vehicles as they aid debug
11:34:00 <peter1138> Players can hide / show badges themselves.
11:34:10 <peter1138> I just haven't PRed that change yet.
11:34:16 <andythenorth> ๐Ÿ‘€
11:34:30 <andythenorth> and if they hide the badge, the text string will also hide?
11:34:38 <peter1138> Not currently.
11:34:52 <peter1138> They can just not look at it.
11:35:18 <peter1138> Either way, don't do this in your GRF.
11:35:36 <peter1138> Doing it in game means players can turn it on and off as they like.
11:35:45 <peter1138> Works especially better in multiplayer.
11:36:09 <zanooda2000> andythenorth: a lot of debug things are helpful for actually playing the game, no need to hide it from the general audience
11:36:18 <peter1138> And means it can still filter for it, even if it's not shown.
11:37:27 <andythenorth> Thereโ€™s going to be 1 cohort of โ€œeven more metadata please, and another of โ€œwhy so much text?โ€
11:37:56 <andythenorth> I am somewhere in the middle ๐Ÿ™‚
11:38:09 *** frosch123 has joined #openttd
11:38:09 <frosch123> Can you use emoji instead of badges?
11:39:36 <peter1138> andythenorth, you should see the things people stuff in the extra text callback.
11:42:45 <andythenorth> I have somewhat
11:44:15 <peter1138> Okay, did we decide to not have togglable dropdown lists for filtering badges?
11:53:44 <andythenorth> I think I tried a branch for that and crashed the client
11:54:42 <reldred> peter1138: awww that would have been nice
11:54:59 <reldred> not a deal breaker though
11:56:30 <peter1138> Hmm?
11:59:33 <peter1138> Rephrase: Should we or should we not?
11:59:43 <reldred> I mean it would be nice
12:00:13 <reldred> would be good to be able to filter by the power type badge or the region badge
12:00:43 <peter1138> So I should rebase my branch.
12:03:56 <reldred> hmm, I need a better way of storing all these miniatures i've printed
12:04:06 <andythenorth> peter1138: Think we should
12:04:17 <andythenorth> Fancy filters
12:06:20 <peter1138> Ok.
12:09:22 <peter1138> michi_cc[d], probably worth doing a release before I add some more bugs ;-)
12:13:41 <peter1138> Where do I put the "configure badges" button?
12:16:16 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1360951723589636116/image.png?ex=67fcfc90&is=67fbab10&hm=cb2a117c9db8f99539fb1fb0438eee41895c234cab52144fc59c29ca72a0a6a9&
12:16:16 <peter1138[d]> Well.
12:17:20 <peter1138[d]> "Unnamed class"?
12:17:20 <peter1138[d]> Hmm
12:19:57 <andythenorth> Such Horse
12:20:04 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #13943: Remove C-style string parsing https://github.com/OpenTTD/OpenTTD/pull/13943
12:23:01 <peter1138[d]> andythenorth: Make badges 4x extra zoom ๐Ÿ™‚
12:24:39 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #13943: Remove C-style string parsing https://github.com/OpenTTD/OpenTTD/pull/13943#pullrequestreview-2762749930
12:24:40 *** talltyler has joined #openttd
12:24:40 <talltyler> Looks like badges needs a badge (er, a button icon) ๐Ÿ™‚
12:25:01 <peter1138[d]> Yes, or a different design for configuration.
12:25:24 <peter1138[d]> This design doesn't work for railtypes and roadtypes, because they are toolbar dropdown menus.
12:26:48 <talltyler> I might personally put the button to the left of the search bar so it doesnโ€™t get visually lost in the scrollbar or backspace button.
12:28:16 <talltyler> It might be time to give road and railtypes their own toolbar dropdown to select type and maybe a search bar. It might help when people define 64 types and the existing dropdown starts scrolling (or it might encourage people to do this nonsense more often) ๐Ÿซฃ
12:29:09 <talltyler> Anyway, out of scope unless it unifies the UI to create a spot for the badge button
12:29:40 <peter1138[d]> I was wondering about putting the badge config button alongside the window caption.
12:30:57 <peter1138[d]> But yeah, do I need an icon for this? If so what? Or a text label that isn't too long (but longer than "B" :))
12:36:40 <frosch123> I would add a โ‹ฎ button right of the cargo filter
12:42:53 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1360958423365062696/image.png?ex=67fd02cd&is=67fbb14d&hm=6383865889235b28b9e4cb09e9d0950d8a70540eea4390d343fc38442230ef92&
12:43:25 <peter1138[d]> (POC using a unicode glyph, so not actually usable.)
12:43:30 <_zephyris> Didn't know we had the `โ‹ฎ` icon... Do we need a burger menu icon?
12:43:45 <_zephyris> Ah, what peter said.
12:44:06 <peter1138[d]> At least it scales ๐Ÿ˜‰
12:45:28 <peter1138[d]> Generated grf size 1.02 MiB, build time 4.21 sec
12:45:34 <peter1138[d]> 4x badges.
12:49:16 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #13943: Remove C-style string parsing https://github.com/OpenTTD/OpenTTD/pull/13943
12:49:37 <talltyler> How often do people use sort order? I wonder if itโ€™s worth hiding it behind an icon button (maybe two arrows pointing up and down?) instead of giving it an entire row.
12:50:06 <talltyler> I leave it on EngineID 99% of the time
12:50:31 <peter1138[d]> Well, I use it.
12:50:51 <reldred> peter1138[d]: That looks great
12:51:31 <reldred> talltyler: Same, or I use date.
12:52:16 *** tabytac has joined #openttd
12:52:16 <tabytac> i think for newer players sort order is also good for people who just want big power or big speed trains
12:52:29 <talltyler> Hereโ€™s an interesting feature request ๐Ÿ˜›
12:52:29 <talltyler> https://www.tt-forums.net/viewtopic.php?p=1273814#p1273814
12:54:25 *** _jgr_ has joined #openttd
12:54:25 <_jgr_> talltyler: EngineID is not all that useful when you're using vehicle GRFs with more than a vanilla quantity of engines
12:54:47 <_jgr_> I would not be keen to hide it away
12:55:37 <peter1138[d]> Well, this code is a bit better now, it avoids misusing Point ๐Ÿ™‚
12:56:14 <tabytac> https://cdn.discordapp.com/attachments/1008473233844097104/1360961780234326047/image.png?ex=67fd05ed&is=67fbb46d&hm=eb07ed463ab955c9972ce05ba3ff90b340b5f99722b781e744370f320ecbc490&
12:56:14 <tabytac> i find engineID depends heavily on the newGRF. the JP+ stuff seems to order trains really well.
12:56:14 <tabytac> Also if you have more than 1 newGRF set, then you can easily see each group of trains from one another
12:56:27 <DorpsGek> [OpenTTD/OpenGFX2] zephyris commented on pull request #174: Fix: Avoid string concatenation for baseset description https://github.com/OpenTTD/OpenGFX2/pull/174#issuecomment-2799943141
12:59:03 <DorpsGek> [OpenTTD/OpenGFX2] zephyris updated pull request #174: Fix: Avoid string concatenation for baseset description https://github.com/OpenTTD/OpenGFX2/pull/174
13:07:59 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #13992: Remove: Drop support for UCS2/UTF-16 encoded scripts. https://github.com/OpenTTD/OpenTTD/pull/13992
13:08:55 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #13943: Remove C-style string parsing https://github.com/OpenTTD/OpenTTD/pull/13943#pullrequestreview-2762758008
13:11:03 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13992: Remove: Drop support for UCS2/UTF-16 encoded scripts. https://github.com/OpenTTD/OpenTTD/pull/13992#pullrequestreview-2762758378
13:11:26 <peter1138[d]> Often I type in the review box, and then as I go to click on the button, the box disappears :S
13:17:08 <frosch123> talltyler: Oh dear, there wasn't even someone voting in 4 days.
13:19:05 <andythenorth> talltyler: I use it only by accident ๐Ÿ˜›
13:19:50 <michi_cc[d]> Hmm, is #13949 a user-visible fix?
13:21:12 <xarick> dang, arrays are "complicated to manipulate"
13:21:20 <xarick> to pass around
13:24:51 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1360968983905439804/image.png?ex=67fd0ca3&is=67fbbb23&hm=68b65bd8454ba025fafbbbf7250f705f22f4427d77c4c3d977973959d5f2cff6&
13:24:51 <peter1138[d]> See...
13:27:01 <_zephyris> Oof... I see 1x, 2x, 4x and 1x overlayed on 4x pixels.
13:27:25 <peter1138[d]> You need to look really hard for that last bit, it's very subtle.
13:28:02 <xarick> can't use array.clear(), must use array = [] to reset the builder
13:28:24 <peter1138[d]> I'm using OpenGFX 2 High Def so anything that's 2x is "your fault" ๐Ÿ™‚
13:28:51 <_zephyris> Indeed
13:29:35 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1360970176115507291/image.png?ex=67fd0dbf&is=67fbbc3f&hm=d6798fd345756b338f51f95a23c8dc4326c6851b6ebda2a7456032136ee66d8c&
13:29:35 <peter1138[d]> And, of course, the reldred mode:
13:30:49 <reldred> Actually, I do like the badges
13:31:04 <reldred> I might hide some but Iโ€™ll definitely be using at least some of them
13:32:00 <reldred> I love that it standardises them, aligns them properly,
13:32:10 <reldred> And gives them a function
13:33:31 <frosch123> michi_cc[d]: At least visible to scripts
13:36:52 <michi_cc[d]> Okay, that is not very clear from the PR title, but I've got no good other idea what to put into the changelog for that.
13:37:00 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13993: Add: Player configuration of badge display. https://github.com/OpenTTD/OpenTTD/pull/13993
13:40:09 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1360972834909720749/image.png?ex=67fd1039&is=67fbbeb9&hm=50da2d0f2e2abd0a2a6b45889bc9f626b48ff88447c316548394f243ec7e99df&
13:40:09 <xarick> is AIAccounting accounting for test mode estimated costs?
13:40:16 <xarick> that's lame
13:40:42 <xarick> the whole pathfinder tests costs
13:40:55 <xarick> tests whether it can build roads, I mean
13:46:23 <peter1138[d]> Right, that's the icon config. Now for the dynamic filtgers.
13:47:43 <DorpsGek> [OpenTTD/nml] frosch123 opened pull request #373: Add: Road/tram/railtype variable 0x45. https://github.com/OpenTTD/nml/pull/373
13:49:08 <michi_cc[d]> Okay, got an updated changelog draft, depending on Rubidium I can either post the diff or push over the current PR.
13:51:07 <Rubidium> just push
13:52:05 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #13992: Remove: Drop support for UCS2/UTF-16 encoded scripts. https://github.com/OpenTTD/OpenTTD/pull/13992
13:55:24 <DorpsGek> [OpenTTD/OpenTTD] michicc dismissed a review for pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738#pullrequestreview-2726401988
13:55:27 <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738
14:00:26 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #13943: Remove C-style string parsing https://github.com/OpenTTD/OpenTTD/pull/13943
14:06:31 <peter1138[d]> Hm.
14:06:54 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1360979563617980426/image.png?ex=67fd167d&is=67fbc4fd&hm=e12affc7185f05185a6075fa8de56864980ac08f2692cea49d9d55743d9a838c&
14:06:54 <peter1138[d]> At least it gets tested now.
14:07:55 <DorpsGek> [OpenTTD/website] michicc updated pull request #344: Add: OpenTTD 15.0-beta2 announcement https://github.com/OpenTTD/website/pull/344
14:09:27 <michi_cc[d]> If someone wants to have a looksie over the changelog PR, we could start the fun and exciting process of figuring out in how many ways the CI can break ๐Ÿคฃ
14:09:50 *** michi_cc has quit IRC (Ping timeout: 480 seconds)
14:10:40 <xarick> how should I load data from an array, I'm a bit confused how to handle these structures
14:10:55 *** michi_cc has joined #openttd
14:10:55 *** ChanServ sets mode: +v michi_cc
14:11:41 <xarick> seems i'm loading references/pointers instead of the contents
14:11:58 <xarick> how do I test this
14:15:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738#pullrequestreview-2762769715
14:15:40 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738#pullrequestreview-2762769347
14:16:47 <frosch123> It's a mystery to me, when I can add a diff suggestion in reviews, and when I can't
14:16:59 <andythenorth> Hmm autoreplace badge filters
14:17:44 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738#pullrequestreview-2762770174
14:17:57 <andythenorth> Hmm GS that unlocks tech tree lines/levels?
14:18:24 <peter1138> Oh, of course, badge filters don't work too well if there are no named badges.
14:20:44 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738#pullrequestreview-2762770679
14:22:46 <andythenorth> peter1138: It was a factor in me adding more of them
14:22:49 <andythenorth> Aids search
14:23:38 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738#pullrequestreview-2762771136
14:24:49 <michi_cc[d]> frosch123: You have to be in the "Files changed" view, you can't add suggestion when reviewing individual commits.
14:26:08 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1360984404268421342/image.png?ex=67fd1aff&is=67fbc97f&hm=0cc00f557a95bc82df372e1a7e3142ec7748cf3d846df056c1aa35c640036f4e&
14:26:08 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1360984404570407242/image.png?ex=67fd1aff&is=67fbc97f&hm=88be7bd885659799a7b566c19b4664e5c70ad37423894799ede6a8c49aebe836&
14:26:08 <xarick> `this.m_bridge_tiles` is an array
14:26:08 <xarick> ```class RoadBuildManager {
14:26:08 <xarick> m_bridge_tiles = [];
14:26:09 <xarick> };```
14:26:09 <xarick> What happens when I load `data[5]` back into `this.m_bridge_tiles`?
14:26:11 <xarick> `LuDiAIAfterFix::Start()` has a `loadData` table calling `LoadBuildManager()`, but at the end, I set `loadData = null;` - what happens to `this.m_bridge_tiles` once that happens?
14:27:10 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738#pullrequestreview-2762771680
14:27:36 <frosch123> Indeed
14:29:21 <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738
14:30:20 <michi_cc[d]> Applied everything expect the possible Change -> Fix thing.
14:33:47 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1360986329776783580/image.png?ex=67fd1cca&is=67fbcb4a&hm=9066424db61e1656803928544372fddedeb7fcb6d1e2f18e09959469f3ba057a&
14:33:47 <peter1138[d]> Oh
14:34:38 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1360986545716199646/image.png?ex=67fd1cfe&is=67fbcb7e&hm=c6426ea04d756f4170c624a2ebd75706542f4a5ee0c83f0068fd24aeaa3176b0&
14:34:38 <peter1138[d]> Nice offsets.
14:37:06 <peter1138[d]> I think I'll stick with "If it doesn't have a name, it won't be shown".
14:38:39 <andythenorth> Seems best ๐Ÿ™‚
14:39:35 <andythenorth> Unless we want explicit flag for that? Iโ€™m currently relying on non-display badges for behaviour.
14:42:51 <peter1138[d]> Non-display was a deliberate design, I was just messing to see your incomplete Horse changes.
14:45:07 <peter1138[d]> I should make it so that you need a name for the class for any icons to be shown.
14:45:13 *** gwyd4016 has joined #openttd
14:45:13 <gwyd4016> Yoo NSE logos
14:48:02 <DorpsGek> [OpenTTD/nml] frosch123 commented on pull request #304: Change: always assume non-track station ground tile https://github.com/OpenTTD/nml/pull/304#pullrequestreview-2762775406
15:06:47 <peter1138> So, given that we renamed CargoID to CargoType.
15:07:05 <peter1138> And did all the PoolID stuff.
15:07:16 <peter1138> Are badges IDs or Types?
15:19:04 <Rubidium> aren't cargo types cargo types because the spec calls them cargo types?
15:20:33 <peter1138> They're CargoTypes because you renamed them, 3 months ago :)
15:20:51 <peter1138> EngineIDs as still that, though.
15:21:00 <peter1138> (But then they are in a pool as well.
15:21:01 <peter1138> )
15:22:51 <peter1138> I'm just renaming some things to avoid ambiguity. I'm not doing any id to type though :)
15:34:17 <michi_cc[d]> Approval on the changelog? (I know, it's Rb's PR and I could technically approve it myself...)
15:34:49 <michi_cc[d]> And if yes, beta release now? (Or at least exciting CI failures? ๐Ÿ™‚ )
15:40:07 *** Wormnest has joined #openttd
15:42:16 * Rubidium isn't allowed to review
15:42:49 <michi_cc[d]> Well, if you are happy, I'll approve you and myself ๐Ÿ™‚
15:44:43 * Rubidium is happy
15:45:10 <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738#pullrequestreview-2762785509
15:45:45 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738
15:46:08 <peter1138> I was too slow, looking at it again and it changed underneath me :)
15:46:30 <_zephyris> Is beta happening?
15:46:33 <michi_cc[d]> Shall we try tagging?
15:47:56 <michi_cc[d]> _zephyris: You got rights in Discord channel #announcements ? Baby dev usually posts the news ๐Ÿ˜›
15:49:59 <michi_cc[d]> peter1138: Well, not too late yet to air your grievances ๐Ÿ™‚
15:50:34 <_zephyris> I'm afraid baby dev is on the road from Edinburgh to London!
15:51:45 *** michi_cc has quit IRC (Ping timeout: 480 seconds)
15:55:02 *** michi_cc has joined #openttd
15:55:02 *** ChanServ sets mode: +v michi_cc
15:58:04 *** nielsm has joined #openttd
15:59:34 <_zephyris> Hmm, seems I don't announcements permission anyway ๐Ÿ™‚
15:59:35 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13994: Fix: Don't display badges if the class has no name. https://github.com/OpenTTD/OpenTTD/pull/13994
16:00:12 <michi_cc[d]> _zephyris: It's fine, we'll (well, me I guess) do it for you ๐Ÿ™‚
16:02:27 <michi_cc[d]> Okay, nobody is screaming yet, so let's find out if our CI likes us today.
16:03:09 <DorpsGek> [OpenTTD/OpenTTD] michicc created new tag: 15.0-beta2 https://github.com/OpenTTD/OpenTTD/releases/tag/15.0-beta2
16:03:40 <michi_cc[d]> Anybody wanting do look over https://github.com/OpenTTD/website/pull/344 while we wait?
16:12:20 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13995: Codechange: Rename badge_class to class_index and badge_classes to gui_classes. https://github.com/OpenTTD/OpenTTD/pull/13995
16:13:17 <DorpsGek> [OpenTTD/website] rubidium42 approved pull request #344: Add: OpenTTD 15.0-beta2 announcement https://github.com/OpenTTD/website/pull/344#pullrequestreview-2762790191
16:14:17 <michi_cc[d]> MacOS used to often be the slowest part of a release, and now it's the first to be done with the new fancy ARM runners.
16:20:59 <michi_cc[d]> Okay, GOG failed ๐Ÿ˜ฆ
16:21:24 <michi_cc[d]> Will the rest continue, or was does that mean try #1 is over?
16:23:07 <DorpsGek> [OpenTTD/OpenTTD] Release workflow was not successful https://github.com/OpenTTD/OpenTTD/actions/runs/14431081293
16:23:31 *** truebrain has joined #openttd
16:23:31 <truebrain> Rest will finish just fine
16:24:26 <DorpsGek> [OpenTTD/OpenTTD] Release workflow was not successful https://github.com/OpenTTD/OpenTTD/actions/runs/14431081293
16:24:57 <michi_cc[d]> Okay, might be a real problem with the action.
16:25:14 <michi_cc[d]> Yeah, I see the website publish job.
16:26:01 <michi_cc[d]> I guess there's no GOG for beta2. Otherwise, it is done.
16:26:04 <michi_cc[d]> ใ€ฝ๏ธ
16:27:01 <DorpsGek> [OpenTTD/website] michicc merged pull request #344: Add: OpenTTD 15.0-beta2 announcement https://github.com/OpenTTD/website/pull/344
16:27:15 <michi_cc[d]> truebrain: I guess Steam needs a news post ๐Ÿ™‚
16:27:26 <truebrain> Tyler was going to learn that!
16:27:43 <michi_cc[d]> Works for me, too ๐Ÿ™‚
16:29:25 <truebrain> michi_cc[d]: GOG would still need fixing. The Build Creator 1.4.0 is still latest. So very weird it errors out like this.
16:30:37 <michi_cc[d]> No reason to not go ahead with announcing it though, I guess?
16:30:57 <truebrain> As long as it doesn't mean: nobody is going to look at it ๐Ÿ™‚
16:32:09 <DorpsGek> [OpenTTD/website] michicc opened pull request #347: Fix: Changelog is Markdown now (take 5465) https://github.com/OpenTTD/website/pull/347
16:33:08 <DorpsGek> [OpenTTD/website] PeterN approved pull request #347: Fix: Changelog is Markdown now (take 5465) https://github.com/OpenTTD/website/pull/347#pullrequestreview-2762793520
16:33:10 <andythenorth> is it too late to rename grf "Parameters as "Settings" before a release? ๐Ÿ˜›
16:33:24 <peter1138[d]> There's a whole PR that merges two windows...
16:33:28 <peter1138[d]> I should probably update i.t
16:33:42 <DorpsGek> [OpenTTD/website] michicc merged pull request #347: Fix: Changelog is Markdown now (take 5465) https://github.com/OpenTTD/website/pull/347
16:34:44 <truebrain> and #347 is why I always click all links in all posts before I merge ๐Ÿ˜› Always scared one of them is broken ๐Ÿ˜„
16:35:09 <truebrain> michi_cc[d]: https://store.steampowered.com/news/app/1536610/view/500570289903502303
16:35:15 <michi_cc[d]> Usually I do that, too, but for some reason I didn't ๐Ÿ™‚
16:35:24 <truebrain> never break good habbits! ๐Ÿ˜›
16:37:22 <truebrain> GOG's Build Creator is 6 years old .. hasn't seen a new version since
16:37:48 <andythenorth> thanks all for the release ๐Ÿ™‚
16:37:54 <truebrain> seems it is being replaced by "GOG Galaxy Pipeline Builder" .. but not that it is very clear or that there is any communication about that ๐Ÿ˜›
16:39:08 <truebrain> docs for that tool point to DLC releases
16:39:15 <truebrain> GOG documentation has always been ... "creative"
16:39:53 <truebrain> it uses a JSON to work, but nowhere it says whether it is the same JSON as the Build Creator is using
16:40:19 <michi_cc[d]> Discord/X/Reddit done
16:40:22 <truebrain> all their docs still state Build Creator should work
16:40:24 <truebrain> but clearly, it is not
16:40:29 <andythenorth> peter1138[d]: got a link? ๐Ÿ™‚
16:40:43 <truebrain> I lost any energy to spend on GOG ... so I hope someone else wants to jump in ๐Ÿ™‚
16:41:25 <peter1138[d]> No, I was thinking game settings, not GRF settings.
16:42:04 <andythenorth> nvm ๐Ÿ™‚
16:50:59 * andythenorth side quests
16:51:05 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13994: Fix: Don't display badges if the class has no name. https://github.com/OpenTTD/OpenTTD/pull/13994#pullrequestreview-2762797941
17:00:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13994: Fix: Don't display badges if the class has no name. https://github.com/OpenTTD/OpenTTD/pull/13994
17:04:34 <andythenorth> peter1138[d]: bool for 'shown by default' for player toggle-able badges?
17:05:06 <peter1138> Badges aren't toggleable?
17:06:10 <andythenorth> did I misunderstand players can hide / show?
17:06:18 <andythenorth> misunderstanding does happen ๐Ÿ˜›
17:07:28 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242
17:08:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242#issuecomment-2800035990
17:10:45 <frosch123> Bad reviewers, 6 of 11 newgrf changes were missing from the api tracker :(
17:11:16 <xarick> gonna install beta2
17:12:04 <xarick> could the "Check Online Content" auto update openttd one day?
17:17:07 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13995: Codechange: Rename badge_class to class_index and badge_classes to gui_classes. https://github.com/OpenTTD/OpenTTD/pull/13995#issuecomment-2800039187
17:19:43 <Rubidium> sounds like a first day of second quarter feature
17:21:53 <peter1138> Right, now I need to update my copy Iron Horse.
17:22:01 <peter1138> Hopefully it's been updated.
17:22:20 <andythenorth> I have some local changes, am about to push
17:22:33 <andythenorth> I switched back to the badgers branch, for correctness ๐Ÿ˜›
17:24:48 <andythenorth> peter1138[d]: just pushed
17:25:20 <andythenorth> the combination of badges AND not having a 1 min grf compile is so nice
17:25:25 <andythenorth> they're really fun to work with
17:29:46 <peter1138[d]> I was imagining a `dump_info badges` for a second.
17:30:45 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #13996: Add StringConsumer to replace Utf8Decode, Utf8Consume, and parsing of binary data. https://github.com/OpenTTD/OpenTTD/pull/13996
17:37:10 <peter1138[d]> Seems weird to base a ByteReader off of a string reader.
17:38:44 <peter1138[d]> Probably just a naming thing, as StringConsumer has lots of byte-reading stuff.
17:40:44 <peter1138[d]> andythenorth: doesn't build ๐Ÿ˜ญ
17:41:08 <peter1138[d]> Or something. It built on the second go.
17:41:27 <andythenorth> missing graphics by any chance?
17:42:12 <andythenorth> the makefile isn't 100% accurate on deps (far from it), but I encounter failures very rarely
17:42:42 <andythenorth> if the graphics aren't run with the multiprocessing flag, nmlc might try to build before the graphics are done
17:42:53 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1361033921407484086/image.png?ex=67fd491d&is=67fbf79d&hm=cfe4ad4707a1cd46038bdd55d068551278fded3e56d2299910e67b9298529b3d&
17:43:01 <peter1138[d]> Dunno.
17:43:14 <andythenorth> oh that's unexpected
17:43:26 <peter1138[d]> But as I said, I did it again and it worked.
17:43:59 <andythenorth> intrigued
17:44:05 <andythenorth> trying to repro
17:44:08 <frosch123> You can replace every std::vector with a std::basic_string to get small vector optimisation
17:44:15 <andythenorth> yeah reproed
17:44:31 <andythenorth> you ran plain `make` no flags?
17:44:44 <peter1138[d]> other than -j something
17:45:04 <andythenorth> yup without -j it fails every time
17:45:31 <peter1138[d]> My computer's too slow to compile Iron Horse ๐Ÿ™‚
17:46:03 <peter1138[d]> frosch123: Oh don't tempt me...
17:47:02 <peter1138[d]> (Not really, I'm not going to measure all the vectors we use and store everywhere to test if they are small enough...)
17:54:30 <peter1138[d]> Hmm, something is not right.
18:01:12 <andythenorth> uh oh
18:01:38 *** jfkuayue has joined #openttd
18:01:38 <jfkuayue> Something is not right.
18:05:35 *** gelignite has quit IRC (Remote host closed the connection)
18:07:24 *** gelignite has joined #openttd
18:09:01 <peter1138[d]> Sorted.
18:09:17 <peter1138[d]> I dropped a commit too many in a rebase.
18:12:54 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1361041475525152788/image.png?ex=67fd5026&is=67fbfea6&hm=3021af3595a70f5fde7930b188f5ca912d28c10ee96ec1f5d863cb437334e7db&
18:12:54 <peter1138[d]> Dupes?
18:13:13 <andythenorth> hmm
18:13:45 <andythenorth> yes, there are versions with random weathering, and versions without
18:13:50 <andythenorth> not sure what to do about that
18:13:56 <andythenorth> "something"
18:14:20 <andythenorth> hmm I _could_ split the badge for random weathering though
18:14:20 <peter1138[d]> "Use the same badge"
18:14:23 <andythenorth> it's a bool in the compile
18:19:09 <andythenorth> I'll change it
18:19:16 <andythenorth> one more island in BadNorth first ๐Ÿ˜›
18:29:27 *** kuka_lie has joined #openttd
18:32:03 <andythenorth> hmm more thought needed, that changes how a few things need to work
18:35:34 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
18:42:35 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13996: Add StringConsumer to replace Utf8Decode, Utf8Consume, and parsing of binary data. https://github.com/OpenTTD/OpenTTD/pull/13996#pullrequestreview-2762817598
18:43:39 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
18:45:22 *** WormnestAndroid has joined #openttd
18:53:48 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #13996: Add StringConsumer to replace Utf8Decode, Utf8Consume, and parsing of binary data. https://github.com/OpenTTD/OpenTTD/pull/13996#pullrequestreview-2762820087
18:56:08 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1361052352462721194/image.png?ex=67fd5a47&is=67fc08c7&hm=3b6d048070aff0108ee84412eab9a44dd56c6e738d6e7c9234d674a139426f5a&
18:56:08 <peter1138[d]> Hmm
18:56:38 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13995: Codechange: Rename badge_class to class_index and badge_classes to gui_classes. https://github.com/OpenTTD/OpenTTD/pull/13995#pullrequestreview-2762820554
18:57:16 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #13996: Add StringConsumer to replace Utf8Decode, Utf8Consume, and parsing of binary data. https://github.com/OpenTTD/OpenTTD/pull/13996
18:58:48 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1361053026172928232/image.png?ex=67fd5ae8&is=67fc0968&hm=e79ba631de91cac9ffb10b0dc8d4c54768f8aca974d3af5255c473109418162b&
18:58:48 <peter1138[d]> Should filtering do something to discard the variant hierarchy...
18:59:49 <frosch123> No, same as the settings tree
19:03:51 *** Wolf01 is now known as Guest13594
19:03:53 *** Wolf01 has joined #openttd
19:06:01 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13996: Add StringConsumer to replace Utf8Decode, Utf8Consume, and parsing of binary data. https://github.com/OpenTTD/OpenTTD/pull/13996#pullrequestreview-2762822088
19:09:20 *** Guest13594 has quit IRC (Ping timeout: 480 seconds)
19:09:57 <andythenorth> peter1138[d]: no it's fine
19:10:08 <andythenorth> it's a bit weird, but there's no way around it
19:10:22 <andythenorth> file browser searches do similar with folders ๐Ÿ˜›
19:12:44 <andythenorth> `ih_livery_flags/use_weathering/false` and `ih_livery_flags/use_weathering/true` are a terrible idea?
19:12:52 <andythenorth> just set ``ih_livery_flags/use_weathering`?
19:13:52 <andythenorth> explicit bool it helps me know I didn't just miss a method call somewhere
19:16:02 <andythenorth> might do it anyway, see what happens, means I can match to a python struct better
19:19:26 <frosch123> "use_weathering"? Why not just "weathered"?
19:21:29 <andythenorth> no particular reason
19:21:53 <andythenorth> there's a set of constants LIVERY_FOO_NO_WEATHERING used on vehicles, I'd have to change those
19:21:59 <andythenorth> UNWEATHERED?
19:24:08 <andythenorth> I really like that I can do this `param_wagon_colour_randomisation && has_badge("ih_livery_flags/use_weathering/true")`
19:24:24 <andythenorth> instead of arsing around passing temp storage IDs and values around the compile
19:27:41 <andythenorth> hmm purchase menu has no random bits?
19:27:51 <andythenorth> I might be accidentally relying on that to not weather purchase sprites
19:30:17 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
19:30:31 *** WormnestAndroid has joined #openttd
19:30:34 <andythenorth> peter1138[d]: pushed a Horse
19:31:00 <andythenorth> going to change a bit more, but duplicate liveries should be gone
19:31:13 <peter1138> And CABBAGE?
19:33:21 <andythenorth> that needs me to set a lot of name strings ๐Ÿ˜›
19:33:32 <andythenorth> I could do them as CABBAGE1...CABBAGE99 ๐Ÿ˜›
19:42:44 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
19:43:06 *** WormnestAndroid has joined #openttd
19:45:12 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
19:57:15 *** nielsm has quit IRC (Ping timeout: 480 seconds)
19:59:14 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #13996: Add StringConsumer to replace Utf8Decode, Utf8Consume, and parsing of binary data. https://github.com/OpenTTD/OpenTTD/pull/13996
19:59:21 <andythenorth> TOML for Horse badge configs?
19:59:23 <andythenorth> perhaps not
19:59:27 <andythenorth> "overkill"
20:06:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13995: Codechange: Rename badge_class to class_index and badge_classes to gui_classes. https://github.com/OpenTTD/OpenTTD/pull/13995
20:08:43 *** kuka_lie has quit IRC (Quit: Lost terminal)
20:09:59 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #13997: Codefix #13872: Use StringConsumer for range-checked string formatting. https://github.com/OpenTTD/OpenTTD/pull/13997
20:10:01 <andythenorth> all badges
20:10:04 <andythenorth> all day
20:10:11 <andythenorth> I forgot to drink wine
20:10:12 <andythenorth> oops
20:13:04 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #13998: Use StringConsumer for parsing translation files https://github.com/OpenTTD/OpenTTD/pull/13998
20:17:43 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #13999: Use StringConsumer for string validation in StrMakeValid and StrValid. https://github.com/OpenTTD/OpenTTD/pull/13999
20:37:15 *** gelignite has quit IRC (Quit: Stay safe!)
20:38:10 <peter1138[d]> Oops.
20:48:55 <xarick> ```if ((AIRoad.AreRoadTilesConnected(tile, adjacent_tile) && !AIRoad.IsRoadDepotTile(adjacent_tile))
20:48:55 <xarick> || (AITile.IsBuildable(adjacent_tile)
20:48:55 <xarick> && (AITile.GetSlope(adjacent_tile) == AITile.SLOPE_FLAT || !AITile.IsCoastTile(adjacent_tile) || !AITile.HasTransportType(adjacent_tile, AITile.TRANSPORT_WATER) || AICompany.GetLoanAmount() == 0))
20:48:55 <xarick> && AIRoad.CanBuildConnectedRoadPartsHere(tile, adjacent_road, adjacent_tile) == 1) {
20:48:55 <xarick> return adjacent_tile;```
20:48:57 <xarick> Can this condition become more readable? I tried asking CoPilot, but it still came out complex
20:51:09 <andythenorth> so many ways
20:51:10 <_glx_> try multiple `if (...) continue;`
20:51:12 <andythenorth> early returns?
20:51:19 <andythenorth> delegate to methods?
20:51:48 *** exceptik has joined #openttd
20:51:48 <exceptik> I wonder if that could be handled with a bitmask
20:55:59 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13993: Add: Player configuration of badge display. https://github.com/OpenTTD/OpenTTD/pull/13993
21:08:45 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1361085725805903913/image.png?ex=67fd795c&is=67fc27dc&hm=dd9870e777f0aefb3ac9d7925e2f3af81fd04a85e19ffc37b17f795b3e4d609b&
21:08:45 <xarick> does this look more readable?
21:09:01 <andythenorth> yes
21:09:16 <LordAro> the missing closing brace might be a problem
21:09:40 <xarick> but is it correct?
21:09:41 <andythenorth> "oops" this is not a valid nml switch name `ih_tech_tree_subrole_child_branch_num_-1`
21:09:50 <andythenorth> but I have negative branch numbers ๐Ÿ˜›
21:09:58 <andythenorth> and autogenerated code
21:10:20 <xarick> oh i see, missing bracket
21:10:24 <andythenorth> -1 > "minus1"
21:10:28 <andythenorth> was GPT's solution
21:11:49 <andythenorth> I could have just autogenerated all the switch IDs on UUIDs probably
21:11:56 <andythenorth> "nobody cares about those"
21:18:32 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
21:18:47 <peter1138[d]> Right, icon.
21:35:37 *** keikoz has quit IRC (Ping timeout: 480 seconds)
21:43:52 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
21:43:58 *** WormnestAndroid has joined #openttd
21:58:19 <peter1138[d]> What icon?
22:00:40 <andythenorth> yes
22:01:17 <andythenorth> ok so if I badge the railtype, that badge will be copied to vehicles using the railtype?
22:01:52 <peter1138[d]> If you set the flag
22:07:48 <andythenorth> might be doing it wrong ๐Ÿ™‚
22:08:14 <peter1138[d]> It has no knowledge of compatible types.
22:08:26 <andythenorth> badge looks ok?
22:08:26 <andythenorth> item (FEAT_BADGES, ih_railtype_IHAA) {
22:08:26 <andythenorth> property {
22:08:26 <andythenorth> label: "ih_railtype/IHAA";
22:08:26 <andythenorth> flags: bitmask(BADGE_FLAG_COPY_TO_RELATED_ENTITY);
22:08:27 <andythenorth> }
22:08:27 <andythenorth> }
22:08:49 <andythenorth> not sure how to test that in game
22:09:42 <andythenorth> hmm might be naptime anyway ๐Ÿ™‚
22:12:27 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
22:13:11 *** WormnestAndroid has joined #openttd
22:42:05 *** Wormnest has joined #openttd