⏴ go to previous day
00:01:45 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13946: Fix: Reference to the correct section of the README if a graphics or … https://github.com/OpenTTD/OpenTTD/pull/13946#pullrequestreview-2734265738
00:06:23 <_glx_> try some re-run but it still picks the wrong image
00:19:56 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on issue #13931: [Crash]: https://github.com/OpenTTD/OpenTTD/issues/13931
00:30:00 *** bigyihsuan has joined #openttd
00:30:00 <bigyihsuan> xarick: checks if the two arrays have exactly the same elements?
00:52:20 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #13931: [Crash]: https://github.com/OpenTTD/OpenTTD/issues/13931
00:54:18 *** WormnestAndroid has quit IRC (Remote host closed the connection)
00:54:27 *** WormnestAndroid has joined #openttd
01:11:40 *** WormnestAndroid has quit IRC (Remote host closed the connection)
01:11:54 *** WormnestAndroid has joined #openttd
01:33:42 <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on issue #13931: [Crash]: https://github.com/OpenTTD/OpenTTD/issues/13931
01:37:43 *** Wormnest has quit IRC (Quit: Leaving)
02:01:41 *** herms has quit IRC (Quit: bye)
02:02:23 *** herms has joined #openttd
02:48:46 *** gnu_jj has joined #openttd
02:51:55 *** geizeskrank has quit IRC (Ping timeout: 480 seconds)
02:52:06 *** gnu_jj_ has quit IRC (Ping timeout: 480 seconds)
02:55:30 *** geizeskrank has joined #openttd
03:00:05 *** herms has quit IRC (Quit: bye)
03:03:46 *** herms has joined #openttd
03:12:25 <andythenorth> peter1138: Has caused me to make Horse compile much faster….
03:50:30 *** D-HUND has joined #openttd
03:53:59 *** debdog has quit IRC (Ping timeout: 480 seconds)
04:07:38 *** keikoz has joined #openttd
04:20:53 *** WormnestAndroid has quit IRC (Remote host closed the connection)
04:20:56 *** WormnestAndroid has joined #openttd
04:25:32 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
04:25:34 *** WormnestAndroid has joined #openttd
04:25:36 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
04:25:55 *** WormnestAndroid has joined #openttd
05:02:53 *** WormnestAndroid has quit IRC (Remote host closed the connection)
05:02:55 *** WormnestAndroid has joined #openttd
05:18:30 *** Flygon has quit IRC (Read error: Connection reset by peer)
05:28:40 *** keikoz has quit IRC (Ping timeout: 480 seconds)
05:33:42 *** D-HUND is now known as debdog
05:38:46 <DorpsGek> [OpenTTD/OpenTTD] Release workflow was not successful https://github.com/OpenTTD/OpenTTD/actions/runs/14212167577
06:46:28 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #13931: [Crash]: https://github.com/OpenTTD/OpenTTD/issues/13931
07:20:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13948: Codechange: Move ownership of Orders to OrderList. https://github.com/OpenTTD/OpenTTD/pull/13948
07:25:57 <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on issue #13747: Switch default base graphics to OpenGFX2 https://github.com/OpenTTD/OpenTTD/issues/13747
07:27:51 *** reldred has quit IRC (Quit: User went offline on Discord a while ago)
07:38:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13948: Codechange: Move ownership of Orders to OrderList. https://github.com/OpenTTD/OpenTTD/pull/13948
07:38:21 *** Speedy` has quit IRC (Read error: Connection reset by peer)
07:42:08 *** Speedy` has joined #openttd
07:58:16 *** debdog has quit IRC (Quit: Initiating getting-the-hell-out-of-here maneuver!)
07:59:43 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13948: Codechange: Move ownership of Orders to OrderList. https://github.com/OpenTTD/OpenTTD/pull/13948
07:59:56 <peter1138> A few comments :o
08:00:05 *** debdog has joined #openttd
08:10:13 *** debdog has quit IRC (Quit: Initiating getting-the-hell-out-of-here maneuver!)
08:20:00 <truebrain> More build failures? The nightly is not having a good year 🙂
08:21:27 <peter1138> Begins to feel like we shouldn't be relying on vcpkg, but I don't have a better idea.
08:40:16 <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #13948: Codechange: Move ownership of Orders to OrderList. https://github.com/OpenTTD/OpenTTD/pull/13948#pullrequestreview-2735287394
09:12:39 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #13940: Codechange: Store loaded GRFFiles in vector directly. https://github.com/OpenTTD/OpenTTD/pull/13940#pullrequestreview-2735547785
09:14:05 <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #13944: Codechange: Use default operator<=> to compare Linkgraph Hop. https://github.com/OpenTTD/OpenTTD/pull/13944#pullrequestreview-2735557257
09:21:52 <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #13947: Fix: [Script] Prevent cloning of API instances https://github.com/OpenTTD/OpenTTD/pull/13947#pullrequestreview-2735608180
09:44:55 <xarick> can't clone AILists?
09:45:05 <xarick> must consult with my pathfinder
09:45:20 <xarick> I remember cloning something there
09:49:08 <xarick> [this._closed = {};](https://github.com/SamuXarick/LuDiAI-AfterFix/blob/master/DoubleRailAyStar.nut#L118)
09:54:57 <xarick> oh, I think I'm fine
09:55:18 <xarick> https://github.com/SamuXarick/LuDiAI-AfterFix/blob/master/DoubleRailAyStar.nut#L185
10:01:33 <truebrain> peter1138: Well, first there were Cloudflare issues, then GitHub Actions issues, then Steam, then CMake issues .. not sure we can blame it all on vcpkg 😄
10:01:44 <truebrain> We just aren't lucky 😛
10:08:06 *** reldred has joined #openttd
10:08:06 <reldred> It’s probably a Skill Issue but every time I come back after not having compiled OpenTTD in a bit it’s always vcpkg that beats me up behind the bike shed and steals my lunch money
10:15:13 <_zephyris> ... there's a reason I do builds with WSL.
10:17:24 <peter1138> Hmm, so, if you have a road vehicle that can refit between passengers and cargo...
10:18:03 <_zephyris> That way madness lies
10:18:04 <peter1138> Which road stop type should it use? :D
10:18:53 <peter1138> It can have orders that are valid or invalid depending on the current cargo type. Hmm.
10:19:20 <xarick> i don't think such refit is possible
10:19:38 <xarick> unless newgrfs do evil stuff
10:20:03 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #13934: Add #12939: [NewGRF] Add road-/tram-/rail-type variable 0x45 to get mutual road-/tram-/rail-type on same tile https://github.com/OpenTTD/OpenTTD/pull/13934
10:21:47 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #13934: Add #12939: [NewGRF] Add road-/tram-/rail-type variable 0x45 to get mutual road-/tram-/rail-type on same tile https://github.com/OpenTTD/OpenTTD/pull/13934#issuecomment-2772116847
10:31:01 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #13947: Fix: [Script] Prevent cloning of API instances https://github.com/OpenTTD/OpenTTD/pull/13947
10:38:14 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #13949: Fix: MayHaveRoad claimed rail station tiles had road, so the custom stationspec index would be read as roadtype https://github.com/OpenTTD/OpenTTD/pull/13949
10:43:27 <xarick> are level crossings MP_ROAD or MP_RAIL?
10:46:12 <_glx_> Road
10:49:58 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #13950: Codefix: Conversion from char to char32_t requires cast to unsigned first https://github.com/OpenTTD/OpenTTD/pull/13950
10:55:13 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #13951: Codefix dccc6185: Incorrect encoding of empty parameters in ScriptText. https://github.com/OpenTTD/OpenTTD/pull/13951
10:56:52 <xarick> frosch123 is the text master
10:58:41 <xarick> so i made a cache which is slower than actual checking stuff
10:58:50 <xarick> good job!
11:01:57 <xarick> I blame iron horse
11:02:01 <xarick> hehehe
11:03:50 <xarick> how many engineIDs can there be?
11:03:57 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13951: Codefix dccc6185: Incorrect encoding of empty parameters in ScriptText. https://github.com/OpenTTD/OpenTTD/pull/13951#pullrequestreview-2735877307
11:04:20 <xarick> 65536, hopefully
11:04:27 <_glx_> 65k yes
11:04:34 <xarick> cool, then i think i can do something
11:04:45 *** keikoz has joined #openttd
11:05:16 <xarick> engine << 16 | wagon
11:05:30 <xarick> or 32? i dunno, something
11:05:53 <xarick> as for the railtypes, how many are there
11:07:01 <xarick> if AILists are now saveable, i can perhaps store this information in them
11:07:16 <xarick> i just have to pack, unpack the variables
11:08:04 <xarick> its still gonna be a biiiig list, because of how many combinations there can be
11:09:16 <xarick> there really should be an easy way to tell whether an engine can be attached
11:09:19 <xarick> to a wagon
11:21:13 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #13951: Codefix dccc6185: Incorrect encoding of empty parameters in ScriptText. https://github.com/OpenTTD/OpenTTD/pull/13951#issuecomment-2772248220
11:31:36 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #13952: Simplfy czech townname generation https://github.com/OpenTTD/OpenTTD/pull/13952
11:34:45 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #13952: Simplify Czech townname generation https://github.com/OpenTTD/OpenTTD/pull/13952
11:36:42 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #13952: Simplify Czech townname generation https://github.com/OpenTTD/OpenTTD/pull/13952
11:45:58 <DorpsGek> [OpenTTD/OpenTTD] frosch123 closed pull request #13858: Fix #13075: Reversed Industry Production Graph x-axis labels for wallclock mode https://github.com/OpenTTD/OpenTTD/pull/13858
11:46:01 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #13858: Fix #13075: Reversed Industry Production Graph x-axis labels for wallclock mode https://github.com/OpenTTD/OpenTTD/pull/13858#issuecomment-2772305433
11:56:12 <_glx_> xarick: I still think it's not the best thing to do
11:58:22 <_glx_> For me it would be best to choose the best engine (according to conditions), then the best wagon (matching conditions), then test if it's a valid combo
11:58:41 <_glx_> If not valid try next best wagon
11:59:25 <_glx_> And restart with next best engine if still not good
11:59:47 <_glx_> No need to try all possible combos
12:00:32 <_glx_> Also everything can change as time progress, new engines/wagon introduced, some removed
12:01:45 <_glx_> Maintaining the list will be painful
12:17:48 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1356965842608328987/image.png?ex=67ee7c6c&is=67ed2aec&hm=7ff7c1d0e612b9cea73410fba2deb234137c243d7736d74c34254cfc5735d0bb&
12:18:03 <xarick> seriously?
12:19:18 <xarick> didn't verify data, maybe i should
12:23:48 <peter1138> Hmm, function pointers or function types... we have a mix.
12:44:46 <_zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1356972626899243008/image.png?ex=67ee82bd&is=67ed313d&hm=29099ba05ae0e02647b5dbf42400cbdf1598635752bfebdfe29b96ef0c638faa&
12:44:46 <_zephyris> Hmm, fun keyboard shortcut clash.
12:45:36 <_glx_> ah there is <https://github.com/microsoft/vcpkg/pull/44712>
12:50:08 <belajalilija> _zephyris: Me!
13:01:12 <_zephyris> Indeed, but `shift`+`\`` opens the console instead of opening the overlay...
13:01:42 <_zephyris> Hmm, how do you format "`" as code...
13:10:46 <peter1138> _glx_, it is safe to use the word 'debacle' yet?
13:11:31 <_glx_> it's a combination of multiple causes
13:13:00 <_glx_> runner images upgrading major version too early (don't upgrade to cmake 4 just because it's released, always wait to let others tools to adapt)
13:14:56 <xarick> why am i on that screenshot?
13:15:39 <xarick> didn't receive any message
13:15:46 <__abigail> You have your game activity set to public
13:16:35 <xarick> where? how?
13:16:55 <xarick> i thought i didn't have discord in openttd
13:17:55 <truebrain> _glx_: GitHub updated their image to Cmake 4? Evil ......
13:18:13 <_glx_> that's why we have failure everywhere
13:18:49 <__abigail> truebrain: Found out why that is a bad thing the hard way 😔
13:19:39 <_glx_> usually it's know any new cmake version can break compatibility
13:19:44 <truebrain> At least nice vcpkg is now setting the min to 3.5, means we can revert my change 🙂
13:20:00 <_glx_> your change doesn't work anyway 😉
13:20:06 <truebrain> It did!
13:20:12 <truebrain> Yesterday build fine
13:20:19 <_glx_> no it used old image
13:20:22 <_glx_> just luck
13:20:56 <_glx_> 20250324 builds fine, 20250330 doesn't (because cmake 4)
13:21:22 <__abigail> _glx_: It is known by people who weren't trying to compile C++ code outside of uni projects for the first time :p
13:21:44 <truebrain> _glx_: Not really, as our Linux uses a Docker, which I tested
13:21:55 <truebrain> Nothing "luck" related
13:21:58 <peter1138> Well.
13:22:20 <_glx_> I tested your changes on CI and it didn't work
13:22:31 <truebrain> For Linux there is no way 🙂
13:22:37 <truebrain> It even worked this night 😄
13:22:53 <truebrain> But that can be reverted now vcpkg picks that up
13:23:27 <_glx_> but I guess docker doesn't use cmake 4
13:24:47 <truebrain> It does, which was the problem
13:24:58 <truebrain> Why else would I have fixed that? 😄
13:25:09 <_glx_> I tried different things on <https://github.com/OpenTTD/OpenTTD/pull/13942>, and none worked
13:25:41 <_glx_> using your way, then the `-D` way, then env vars
13:25:46 <_glx_> nothing works
13:25:56 <truebrain> I somewhat doubt the current build failure is solved by that vcpkg change .. did you happen to test it?
13:26:07 <_glx_> vcpkg just ignores CMAKE_POLICY_VERSION_MINIMUM
13:26:19 <_glx_> or discards it
13:26:24 <truebrain> For Linux it clearly didnt
13:26:31 <truebrain> Not sure what you want me to say here 😄
13:26:52 <truebrain> Start the docker image yourself, see it has cmake 4.0, and notice that the build last night worked fine
13:32:56 <truebrain> Okay, this vcpkg change should indeed fix all these issues .. so that is good. Possibly it does require a baseline bump. Never sure how that works 😄
13:36:15 <truebrain> If I would be to guess why my change doesn't work for Windows, is because we use a bash shell to start a Windows binary .. not sure how that interaction actually works
13:39:03 <_glx_> but I would assume global env vars work (CTEST_OUTPUT_ON_FAILURE does)
13:39:12 <truebrain> `-D` btw doesn't work as that never ends up in vcpkg, I found out
13:39:49 <truebrain> True; Windows being a special snowflake
13:40:04 <truebrain> But, good hopes for this vcpkg
13:40:28 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1356986645974482974/image.png?ex=67ee8fcb&is=67ed3e4b&hm=49a631c24149ab60d2abae6907de3f5654427bcc1eaae523c463d5925250831d&
13:40:31 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1356986658372718702/image.png?ex=67ee8fce&is=67ed3e4e&hm=b2720cd933e7d38f9766104987b5b5d942e6219482e89ea3b9589c29ae8f6f01&
13:40:31 <_glx_> but
13:42:48 <_glx_> windows vcpkg has to do things differently
13:45:13 <_glx_> my guess is vcpkg runs cmake without transferring env
13:46:23 <truebrain> But not on Linux, so what is that about?
13:47:05 <truebrain> (Not asking for an answer from you; just pointing out how weird it is)
13:51:03 <_glx_> https://github.com/microsoft/vcpkg-tool/blob/9c604254140797833b6f76908435c9fcbf09920e/src/vcpkg/base/system.process.cpp#L525
13:51:21 <_glx_> maybe this function, it's suspicious 🙂
13:54:42 <_glx_> anyway it handles env in a different way for WIN32
14:25:42 <jfkuayue> https://cdn.discordapp.com/attachments/1008473233844097104/1356998027461787770/IMG_7989.jpg?ex=67ee9a65&is=67ed48e5&hm=237e3636b08edd9904f9e4444c7300e72eb615659b223529de3d6937dd071a44&
14:25:42 <jfkuayue> https://cdn.discordapp.com/attachments/1008473233844097104/1356998028237471774/IMG_8005.jpg?ex=67ee9a65&is=67ed48e5&hm=b41c7c94afdc6f467fc5c5c4530bb45019c44a22c0aa8e016036ef453d0b8b2b&
14:25:42 <jfkuayue> https://cdn.discordapp.com/attachments/1008473233844097104/1356998028996903095/IMG_8025.jpg?ex=67ee9a65&is=67ed48e5&hm=11846985855b0484560f5a123a5815ab71797afea1885622d3bb09608ae45b64&
14:25:42 <jfkuayue> https://cdn.discordapp.com/attachments/1008473233844097104/1356998029370064996/IMG_8023.png?ex=67ee9a66&is=67ed48e6&hm=88437b1b23610d2775047cfe0e2e0625826c79d28341d5d4ebfec6be38bab8c5&
14:25:42 <jfkuayue> Here is an off topic news: I made it in 24 hours from Penzance to Wick by National Rail!
14:32:19 <_glx_> haha 15h and the vcpkg pr is still running CI
14:32:49 *** Wormnest has joined #openttd
14:33:09 <xarick> glx, you busy? squirrel tables can be iterated, but it's unordered, can you make it so the order is the same?
14:33:29 <_glx_> no, it's how squirrel stores them
14:35:01 <_glx_> it uses hash for key
14:40:52 *** nielsm has joined #openttd
14:41:10 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #13953: Add Utf8View to simplify iterating over UTF-8 data with bounds checking https://github.com/OpenTTD/OpenTTD/pull/13953
14:43:08 <peter1138> std::Hmm.
14:43:11 <peter1138> What?
14:45:06 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #13953: Add Utf8View to simplify iterating over UTF-8 data with bounds checking https://github.com/OpenTTD/OpenTTD/pull/13953
14:47:02 <peter1138> Somewhat large functions marked inline.
15:09:45 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #13953: Add Utf8View to simplify iterating over UTF-8 data with bounds checking https://github.com/OpenTTD/OpenTTD/pull/13953
15:10:10 <frosch123> Added a cpp
15:12:47 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #13953: Add Utf8View to simplify iterating over UTF-8 data with bounds checking https://github.com/OpenTTD/OpenTTD/pull/13953
15:24:03 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #13953: Add Utf8View to simplify iterating over UTF-8 data with bounds checking https://github.com/OpenTTD/OpenTTD/pull/13953
15:24:10 <xarick> how do I iterate a bitset in squirrel
15:25:21 <xarick> got a railtypes variable where each bit defines a railtype
15:51:25 *** Flygon has joined #openttd
15:51:33 <_glx_> like in C++, shift and &1
15:51:40 <_glx_> in a loop
15:51:44 <frosch123> Is allocating 1 kiB on the stack okay, or is that too much?
15:52:36 <frosch123> Looks like windows uses 1 MiB stack, so should be fine
15:53:31 <_glx_> depending on why you need 1k, it's always possible to use smart objects
15:53:49 <_glx_> but 1k is not that much 🙂
15:55:53 *** gelignite has joined #openttd
15:56:19 <_glx_> <https://dev.azure.com/vcpkg/public/_build/results?buildId=114079&view=logs&j=f79cfdd7-47a8-597f-8f57-dc3e21a8f2ad&t=73c5513e-c47c-57a4-379a-581f7e429f13> at least lzo builds for lnux
15:57:42 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1357021184021237870/image.png?ex=67eeaff6&is=67ed5e76&hm=34eb646e8c5cb41aed0295b5ee7dd75bb7ed1c7fa5a6bee0318a3792a8641c7c&
15:57:42 <_glx_> not bad, guess the 2 fails were already broken
15:59:23 <_glx_> but 15h37 of build time to get failure report, that's wild
16:00:15 *** kuka_lie has joined #openttd
16:44:34 <xarick> ``` for (local railtype = 0; railtype < 64; railtype++) {
16:44:34 <xarick> if (((railtypes & (1 << railtype)) == 0) continue;```
16:44:38 <xarick> is this it?
16:51:09 <xarick> wow, just... wow
16:51:45 <xarick> 83 ticks down from 280k ticks
16:53:19 <xarick> https://discord.com/channels/142724111502802944/1008473233844097104/1356965842532700323 oh, I had already tested it
16:54:13 <xarick> 602 ticks for mail
16:58:22 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened issue #13954: [Bug]: Company plots with limited data are not right-aligned https://github.com/OpenTTD/OpenTTD/issues/13954
17:01:15 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened issue #13955: [Bug]: Plots do not respect right-to-left text direction https://github.com/OpenTTD/OpenTTD/issues/13955
17:02:50 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #13894: Fix #13893, #13075: Reversed all x-axis labels for Company related and Industry Production graphs in wallclock mode https://github.com/OpenTTD/OpenTTD/pull/13894#issuecomment-2773199136
17:02:57 <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #13894: Fix #13893, #13075: Reversed all x-axis labels for Company related and Industry Production graphs in wallclock mode https://github.com/OpenTTD/OpenTTD/pull/13894#pullrequestreview-2736997377
17:04:19 <xarick> oops
17:04:49 <xarick> what's the maximum size of a train engine?
17:04:53 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #13894: Fix #13893, #13075: Reversed all x-axis labels for Company related and Industry Production graphs in wallclock mode https://github.com/OpenTTD/OpenTTD/pull/13894
17:04:54 <xarick> 16?
17:04:56 <DorpsGek> [OpenTTD/OpenTTD] frosch123 closed issue #13893: [Bug]: Company graph labels should be in reverse order when using wallclock mode https://github.com/OpenTTD/OpenTTD/issues/13893
17:04:59 <DorpsGek> [OpenTTD/OpenTTD] frosch123 closed issue #13075: [Bug]: Industry production graph x-axis doesn't correlate with graph's data in wallclock mode https://github.com/OpenTTD/OpenTTD/issues/13075
17:05:02 <DorpsGek> [OpenTTD/OpenTTD] frosch123 closed issue #13075: [Bug]: Industry production graph x-axis doesn't correlate with graph's data in wallclock mode https://github.com/OpenTTD/OpenTTD/issues/13075
17:15:36 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13942: Codefix f719fa678f: [CI] Also apply CMake fix to normal CI https://github.com/OpenTTD/OpenTTD/pull/13942
17:18:02 <_glx_> ah found a useful env var
17:21:30 <_glx_> <https://learn.microsoft.com/en-us/vcpkg/users/triplets#vcpkg_env_passthrough> the doc contains useful info, but very local
17:26:32 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13942: Codefix f719fa678f: [CI] Also apply CMake fix to normal CI https://github.com/OpenTTD/OpenTTD/pull/13942
17:30:03 <_glx_> of course now they are in cache so I can't really check the new change
17:31:06 <DorpsGek> [OpenTTD/OpenTTD] Yozora3 commented on discussion #12939: Level crossing extensions in NewGRF https://github.com/OpenTTD/OpenTTD/discussions/12939
17:32:41 <DorpsGek> [OpenTTD/OpenTTD] xJayMorex commented on pull request #13894: Fix #13893, #13075: Reversed all x-axis labels for Company related and Industry Production graphs in wallclock mode https://github.com/OpenTTD/OpenTTD/pull/13894#issuecomment-2773260662
17:34:55 <DorpsGek> [OpenTTD/OpenTTD] xJayMorex commented on issue #13954: [Bug]: Company plots with limited data are not right-aligned https://github.com/OpenTTD/OpenTTD/issues/13954
17:47:44 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13942: Codefix f719fa678f: [CI] Also apply CMake fix to normal CI https://github.com/OpenTTD/OpenTTD/pull/13942
17:49:17 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13942: Codefix f719fa678f: [CI] Also apply CMake fix to normal CI https://github.com/OpenTTD/OpenTTD/pull/13942
17:54:34 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on issue #13954: [Bug]: Company plots with limited data are not right-aligned https://github.com/OpenTTD/OpenTTD/issues/13954
17:54:58 <_glx_> ok if I disable the cache I can see the new version fails
17:55:23 <truebrain> Isn't it better to wait for vcpkg to merge that PR? 🙂
17:58:23 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13942: Codefix f719fa678f: [CI] Also apply CMake fix to normal CI https://github.com/OpenTTD/OpenTTD/pull/13942
17:58:33 <_glx_> maybe, but vcpkg pr is still building
17:59:22 <_glx_> started almost 18h30 ago
18:00:20 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
18:00:23 *** WormnestAndroid has joined #openttd
18:00:26 <DorpsGek> [OpenTTD/OpenGFX2] zephyris opened pull request #158: Zoom out optimisations https://github.com/OpenTTD/OpenGFX2/pull/158
18:01:47 <DorpsGek> [OpenTTD/OpenTTD] xJayMorex commented on issue #13954: [Bug]: Company plots with limited data are not right-aligned https://github.com/OpenTTD/OpenTTD/issues/13954
18:04:47 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on issue #13954: [Bug]: Company plots with limited data are not right-aligned https://github.com/OpenTTD/OpenTTD/issues/13954
18:07:29 <DorpsGek> [OpenTTD/OpenTTD] xJayMorex commented on issue #13954: [Bug]: Company plots with limited data are not right-aligned https://github.com/OpenTTD/OpenTTD/issues/13954
18:11:33 <Rubidium> frosch123: I think the old string builder used to allocate 8 kiB on the stack
18:12:56 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13950: Codefix: Conversion from char to char32_t requires cast to unsigned first https://github.com/OpenTTD/OpenTTD/pull/13950#pullrequestreview-2737166346
18:13:18 *** Wolf01 has joined #openttd
18:13:49 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13951: Codefix dccc6185: Incorrect encoding of empty parameters in ScriptText. https://github.com/OpenTTD/OpenTTD/pull/13951#pullrequestreview-2737168151
18:17:10 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13949: Fix: MayHaveRoad claimed rail station tiles had road, so the custom stationspec index would be read as roadtype https://github.com/OpenTTD/OpenTTD/pull/13949#pullrequestreview-2737175397
18:42:38 *** tokai|noir has joined #openttd
18:42:38 *** ChanServ sets mode: +v tokai|noir
18:45:39 <_zephyris> Can make rules depend on a directory? And they'll check for any change to that dir and its content?
18:49:31 *** tokai has quit IRC (Ping timeout: 480 seconds)
19:04:27 <frosch123> No. But you can depend on `dir/*`
19:09:42 <frosch123> Also, nmlc has options to write dependency files, which you can -include in the Makefile
19:10:43 <frosch123> That allows making the grf depend on all spritesheets
19:14:46 <_zephyris> Ooh, ok, interesting.
19:19:39 <_glx_> yeah -M, -MF and -MT (similar to cpp)
19:21:06 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13942: Codefix f719fa678f: [CI] Also apply CMake fix to normal CI https://github.com/OpenTTD/OpenTTD/pull/13942
19:26:10 <DorpsGek> [OpenTTD/OpenTTD] xJayMorex opened pull request #13956: Fix #13954: Plotting graphs with limited data to the right in case of wallclock mode https://github.com/OpenTTD/OpenTTD/pull/13956
19:29:37 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13942: Codefix f719fa678f: [CI] Also apply CMake fix to normal CI https://github.com/OpenTTD/OpenTTD/pull/13942
19:33:23 <_zephyris> Well, I knew it'd be a lot of images, but wasn't expecting 737 for the base grf... and >1.2k images for the extra newgrf.
19:55:36 <_glx_> at least now it works, we can wait for the proper vcpkg fix, but the workaround is valid
19:55:36 *** Speedy` has quit IRC (Read error: Connection reset by peer)
19:56:15 *** kuka_lie has quit IRC (Quit: Lost terminal)
19:56:25 <xarick> VCPKG decided to download a bunch of stuff
19:57:31 <_glx_> ah vcpkg fix is merged
19:58:25 *** Speedy` has joined #openttd
19:58:41 *** gelignite has quit IRC (Quit: Stay safe!)
20:00:37 <_glx_> and judging <https://github.com/OpenTTD/OpenTTD/actions/runs/14227896129/job/39871682341?pr=13956> it works without needing to touch baseline
20:02:32 <xarick> Elapsed time to handle lzo:x64-windows-static: 54 s
20:02:39 <xarick> why is lzo always slow?
20:28:30 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1357089333051523235/image.png?ex=67eeef6e&is=67ed9dee&hm=e7ff049b78adce1b7ec1b4ba02aab765851da467a9db8c0039a636e3fe3100ed&
20:28:30 <xarick> that's a very big newgrf
20:29:19 <xarick> let's see my AI not building
20:30:08 <_glx_> huge because extra zoom
20:30:16 <_glx_> and 32bpp
20:36:54 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13952: Simplify Czech townname generation https://github.com/OpenTTD/OpenTTD/pull/13952#pullrequestreview-2737517401
20:37:28 <xarick> okay, it's not building because it's caching
20:39:12 <Rubidium> _glx_: does that mean your PR and the previous attempt are not needed anymore?
20:39:37 <_glx_> yeah, I'm reusing my PR to just revert 🙂
20:40:14 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13942: Revert f719fa678f: [CI] The fix is now implemented at vcpkg level https://github.com/OpenTTD/OpenTTD/pull/13942
20:41:56 <_glx_> hmm need to test without the cache
20:42:48 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13942: Revert f719fa678f: [CI] The fix is now implemented at vcpkg level https://github.com/OpenTTD/OpenTTD/pull/13942
20:49:24 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13942: Revert f719fa678f: [CI] The fix is now implemented at vcpkg level https://github.com/OpenTTD/OpenTTD/pull/13942
20:49:43 <_glx_> ok without cache it works
20:50:30 <_glx_> and no need to update baseline because the fix is not at port level but inside vcpkg toolchain
20:51:17 <_glx_> and we always clone latest
20:54:17 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1357095821841141832/image.png?ex=67eef579&is=67eda3f9&hm=9ce151e0838ecb2a0c3ae2a93c1898d10b9fa341d2b351ad323f2b795e5a3b0b&
20:54:17 <xarick> GETS
20:54:38 <xarick> my strategy sucks
20:56:19 <xarick> at least the pairs list is built fast now
20:56:40 <xarick> but then... i go and try attach every combination possible before deciding what train to build
20:57:22 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13942: Revert f719fa678f: [CI] The fix is now implemented at vcpkg level https://github.com/OpenTTD/OpenTTD/pull/13942
20:57:50 <xarick> if i pick top 10, i may end up getting clones
20:57:59 <xarick> these variants
20:58:03 <xarick> ruin AIs
20:58:50 <xarick> more likely a me problem
21:00:04 <_glx_> yeah it's more likely your method
21:00:38 <xarick> pick the best of top 10 in regards to capacity, then they're all 40 passengers
21:01:10 <xarick> pick the best top 10 max speed, then they're all the same engine with a different color
21:03:09 <_zephyris> Tangent: For NML, should redefinition of alternative sprites (eg. defining 32bpp alternate sprites twice) be errors rather than warnings? Is there any instance it would be useful intended behaviour?
21:03:12 <_glx_> might need a Engine::IsVariant()
21:04:10 <_glx_> but then you have grf authors abusing the variant system for something else
21:04:56 <_glx_> so you'd end up with no engines at all because base variant is non buildable
21:05:28 <xarick> i actually test build the engines
21:05:47 <xarick> this for 50k pairs is just ... time consuming
21:05:47 <_glx_> I mean if the IsVariant() filter existed
21:06:21 <xarick> gotta decide on something
21:06:45 <xarick> for the first routes, I need to guess whatever pair works
21:06:48 <_glx_> in some grf the base is used as category name and non buildable, so all buildable engines are variant
21:07:15 <_glx_> but if you filter to remove variants you're left with nothing
21:07:49 <xarick> I see what you mean
21:08:01 <_glx_> ideally for newgrf you want hardcoded valid consist
21:09:08 <_glx_> but when multiple newgrf are loaded it will be hard to find the correct ID
21:09:42 <pickpacket> London, I am in you!
21:09:56 <_glx_> gross 🙂
21:10:07 <pickpacket> 🤪
21:10:14 <xarick> thinking of something like: if number of train depots is less than 10, don't test engine wagon attachments
21:10:24 <xarick> each route i build has 2 depots
21:11:33 <_glx_> other option could be to build the list incrementally
21:11:52 <_glx_> instead of all in one go
21:12:31 <_glx_> like start to build the list, then do something else, then add more to the list, do something else
21:14:20 *** akimoto has joined #openttd
21:15:47 <frosch123> _zephyris: Never saw that, but I would assume "error"
21:17:05 <_zephyris> It's been catching me out - I've been hiding warnings using `--quiet` (white pixels and animated pixels are not problems), which has hidden accidental re-definition of alternative_sprites.
21:17:48 <DorpsGek> [OpenTTD/OpenGFX2] zephyris opened pull request #159: Fix: Correct accidental re-definition of alternative sprites https://github.com/OpenTTD/OpenGFX2/pull/159
21:18:45 <_glx_> when white pixels and animated are not a problem use the proper flags to silence the warnings 😉
21:19:20 <_zephyris> Gets hard to template...
21:19:22 <_zephyris> Or I'm lazy
21:19:24 <_zephyris> Or both
21:20:17 <_glx_> yeah only some sprites are expected to be animated, and it's not simple to template
21:25:56 *** keikoz has quit IRC (Ping timeout: 480 seconds)
21:28:33 <_zephyris> There's kinda valid reasons to not worry about the anim and white flags/warnings, ie. laziness.
21:28:58 <_zephyris> But is it ever useful to redefine an alternative sprite set?
21:30:41 <_glx_> only valid case I could imagine is generic definition and you overwrite it conditionally
21:30:51 <_glx_> but should be super rare
21:31:40 <_zephyris> alternative_sprites aren't allowed in if/else blocks, IIRC
21:31:41 <xarick> I'm surprised iron horse isn't the worst offender
21:32:24 <_glx_> if it's not allowed in if/else an error seems more appropriate than a warning
21:38:45 <_zephyris> [testing... slow to test on a big baseset...]
21:39:14 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13940: Codechange: Store loaded GRFFiles in vector directly. https://github.com/OpenTTD/OpenTTD/pull/13940
21:44:16 <_zephyris> I'll get back to you, I need to rebuild the images which will take a while!
21:50:30 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13949: Fix: MayHaveRoad claimed rail station tiles had road, so the custom stationspec index would be read as roadtype https://github.com/OpenTTD/OpenTTD/pull/13949#issuecomment-2773815990
21:54:46 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
22:00:10 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13944: Codechange: Use default operator<=> to compare Linkgraph Hop. https://github.com/OpenTTD/OpenTTD/pull/13944
22:00:45 <DorpsGek> [OpenTTD/OpenTTD] xJayMorex opened pull request #13957: Fix #13955: Fixed graphs to respect RTL https://github.com/OpenTTD/OpenTTD/pull/13957
22:00:51 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13948: Codechange: Move ownership of Orders to OrderList. https://github.com/OpenTTD/OpenTTD/pull/13948
22:06:36 <DorpsGek> [OpenTTD/OpenTTD] xJayMorex commented on pull request #13894: Fix #13893, #13075: Reversed all x-axis labels for Company related and Industry Production graphs in wallclock mode https://github.com/OpenTTD/OpenTTD/pull/13894#issuecomment-2773839643
22:09:01 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1357114628534042765/image.png?ex=67ef06fd&is=67edb57d&hm=4a2dd72dff88c83b81f480e24a5be747e194b77ceb8a8f56c50d993810f2ed4b&
22:09:01 <xarick> just checking something
22:09:17 <xarick> fantastic
22:09:28 <xarick> fabulous
22:15:00 <xarick> make OpenTTD AI-able again
22:18:04 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1357116905286275284/image.png?ex=67ef091c&is=67edb79c&hm=3c2286b72549ea6e6b280102932b9723425acbd0e5c0d511ebc9cd511a28b7de&
22:18:04 <xarick> after an eternity, it decided on an engine that can't move
22:18:33 <xarick> max speed is a lie
22:19:30 *** nielsm has quit IRC (Ping timeout: 480 seconds)
22:20:12 <_zephyris> _glx_: Simple answer from the nfo spec, I think, alternative sprites are always defined with and can't be separated from the 'parent' https://newgrf-specs.tt-wiki.net/wiki/RealSprites#Info_version_32
22:21:18 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13958: Codechange: Manage window viewport with std::unique_ptr. https://github.com/OpenTTD/OpenTTD/pull/13958
22:22:00 <xarick> it's simply not enough to check attachment
22:22:09 <peter1138> Simple answer to watch question though?
22:22:12 <peter1138> *what
22:22:51 <xarick> good night, gotta think wether I really want to support NewGRFs shennanigans
22:23:27 <xarick> It's really demotivational
22:48:03 *** akimoto has quit IRC (Remote host closed the connection)
23:25:22 <reldred> why the hell do you have ECS and firs active at the same time, and why do you have multiple firs versions
23:37:05 <peter1138> If in doubt, load them all.
continue to next day ⏵
