⏴ go to previous day
00:53:30 *** akimoto has quit IRC (Remote host closed the connection)
01:10:39 *** Flygon has joined #openttd
01:22:32 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
02:47:49 *** Wormnest has joined #openttd
03:22:01 *** Wormnest_ has joined #openttd
03:24:46 *** D-HUND has joined #openttd
03:26:53 *** Wormnest has quit IRC (Read error: Connection reset by peer)
03:28:04 *** debdog has quit IRC (Ping timeout: 480 seconds)
03:30:57 *** Wormnest_ has quit IRC (Ping timeout: 480 seconds)
04:04:48 <DorpsGek> [OpenTTD/OpenTTD] WenSimEHRP commented on pull request #13655: Add: Include some default badges. https://github.com/OpenTTD/OpenTTD/pull/13655#issuecomment-2686803129
04:45:18 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/566a5196f254224983453ceeceeaf5d20db486cd
04:45:19 <DorpsGek> - Update: Translations from eints (by translators)
05:01:02 *** keikoz has joined #openttd
05:13:44 *** urdh has quit IRC (Quit: Boom!)
05:15:46 *** urdh has joined #openttd
07:49:17 *** tokai|noir has quit IRC (Quit: c('~' )o)
08:12:21 *** SigHunter has quit IRC ()
08:15:05 *** SigHunter has joined #openttd
08:43:54 <andythenorth> was it lunch yet?
08:46:02 <LordAro> barely finished breakfast
08:46:35 <andythenorth> ah
08:46:39 <andythenorth> I didn't breakfast
08:46:44 <andythenorth> good point
08:46:53 <andythenorth> [basic errors]
08:48:41 <LordAro> what a noob
09:00:20 *** reldred has joined #openttd
09:00:20 <reldred> Dinner time
09:00:57 <peter1138> Well
09:02:03 <peter1138> Might take today off.
09:03:25 <LordAro> :o
09:26:52 <DorpsGek> [OpenTTD/OpenTTD] SosMakaroni commented on pull request #13655: Add: Include some default badges. https://github.com/OpenTTD/OpenTTD/pull/13655#issuecomment-2687375129
09:28:02 <andythenorth> pff
09:29:59 *** mindlesstux has quit IRC (Quit: The Lounge - https://thelounge.chat)
09:30:21 *** mindlesstux has joined #openttd
09:35:19 *** mindlesstux has quit IRC ()
09:36:03 *** mindlesstux has joined #openttd
10:28:00 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13664: Cleanup: Remove unused member in ScriptDebugWindow https://github.com/OpenTTD/OpenTTD/pull/13664#pullrequestreview-2647317449
10:32:29 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13649: Codechange: explicitly initialise member variables of Windows (2 of 5) https://github.com/OpenTTD/OpenTTD/pull/13649#pullrequestreview-2647328811
11:13:46 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1344628541106688100/image.png?ex=67c19a6a&is=67c048ea&hm=4b031a26645e9daeeccca3b2041f187eb54bacbaa7969932a5c28738a8bb81fd&
11:13:46 <xarick> nice map size, doesn't even fit
11:21:00 <xarick> oh crap, can't use async in 15.0-beta
11:21:03 <xarick> i forgot
11:21:09 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13649: Codechange: explicitly initialise member variables of Windows (2 of 5) https://github.com/OpenTTD/OpenTTD/pull/13649
11:22:21 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1344630702431404072/image.png?ex=67c19c6d&is=67c04aed&hm=dcc014cda10e577e2aaaa34f1c7ab87ceb968b8a22ffcaf440e2c99b353a061d&
11:22:21 <peter1138[d]> Better?
11:35:24 <xarick> aha
11:35:30 <xarick> i guess
11:42:04 *** peter1139 has joined #openttd
11:43:47 *** peter1138 has quit IRC (Ping timeout: 480 seconds)
11:44:38 *** D-HUND is now known as debdog
11:44:48 *** peter1139 is now known as peter1138
11:44:52 <peter1138> Beep.
11:58:40 <Rubidium_> boop.
12:01:06 <xarick> interesting level of smartness by HogeAI
12:07:37 <xarick> it starts a small route
12:07:46 <xarick> then as it gets richer
12:08:20 <xarick> picks another destination while reusing the infrastructure
12:08:37 <xarick> eases pathfinding bit by bit
12:10:37 <xarick> how does it keep track of its current routes, how does it know where to connect
12:11:10 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1344642986734125087/image.png?ex=67c1a7de&is=67c0565e&hm=af79c5ff13674280162d2368009ab342799fb609888ad97a65855d8c5da621d2&
12:11:28 <xarick> the way splits
12:13:57 <xarick> he's really not afraid of terraforming
12:18:02 <xarick> i still don't understand how his rail pathfinder is so fast, efficient
12:20:56 <xarick> where I see obstacles, he sees underground tunnels
12:21:01 <xarick> really smart
12:25:48 <frosch123> andythenorth: new language for you: https://github.com/SirusCodes/AntiLang
12:25:48 <frosch123> Maybe you prefer it over squirrel
12:27:11 <peter1138> Looks like Rust.
12:27:27 <peter1138> (It doesn't, I'm just shit-posting)
13:15:43 <xarick> is beta 2 coming out at all?
13:17:35 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #13664: Cleanup: Remove unused member in ScriptDebugWindow https://github.com/OpenTTD/OpenTTD/pull/13664
13:22:36 <Rubidium_> I guess it's probably going to be just after the refactorings slated for 15 have completed
13:32:25 *** kuka_lie has joined #openttd
13:43:02 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13457: Change: [Script] Remove IsValidBaseStation https://github.com/OpenTTD/OpenTTD/pull/13457#issuecomment-2688005268
13:45:12 <xarick> oh, i guess i forgot
13:57:11 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13457: Change: [Script] Remove IsValidBaseStation https://github.com/OpenTTD/OpenTTD/pull/13457
14:03:24 *** tokai has joined #openttd
14:03:24 *** ChanServ sets mode: +v tokai
14:22:49 *** kuka_lie has quit IRC (Quit: Lost terminal)
14:39:46 <xarick> i wish station orders were smarter
14:40:14 <xarick> go to Station A, stay until 25% cargo load, go to Station B
14:41:02 <xarick> or until "condition" is met
15:21:14 *** nielsm has joined #openttd
15:21:27 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13639: Codechange: remove C-style memory management https://github.com/OpenTTD/OpenTTD/pull/13639
15:21:30 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13652: Codechange: explicitly initialise member variables of Windows (4 of 5) https://github.com/OpenTTD/OpenTTD/pull/13652
15:21:33 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13644: Codechange: remove ZeroedMemoryAllocator https://github.com/OpenTTD/OpenTTD/pull/13644
15:24:55 <andythenorth> frosch123: 'oof'
15:29:10 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13644: Codechange: remove ZeroedMemoryAllocator https://github.com/OpenTTD/OpenTTD/pull/13644
15:31:24 *** Smedles has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
15:31:40 *** Smedles has joined #openttd
15:38:05 *** HerzogDeXtEr has joined #openttd
15:50:01 *** Wormnest has joined #openttd
15:57:37 *** yiffgirl has quit IRC (Quit: User went offline on Discord a while ago)
16:10:58 *** ahyangyi has quit IRC (Quit: User went offline on Discord a while ago)
16:16:35 * peter1138 tries again.
17:12:20 <andythenorth> https://www.tt-forums.net/viewtopic.php?t=92137
17:12:35 <andythenorth> ^ I can donate for this, if enough others do
17:17:52 <xarick> I can't donate
17:18:15 <xarick> I still visit the forum to check for AI developments
17:18:59 <xarick> my answer is thus: No
17:19:40 <xarick> isn't github discussions good for a forum replacement?
17:23:56 <xarick> or even discord?
17:24:55 <xarick> or discord/github also needs donations?
17:25:39 <peter1138> One of the options is "Yes (but I can't donate)", so...
17:27:04 <xarick> I'd like AI/GS development shifting towards github
17:27:05 <cu-kai> discord is a terrible platform for discussions, things there get lost
17:28:05 <xarick> NewGRF also I suppose
17:28:22 <peter1138> Github is good for storing the development work, but isn't useful for general discussions about it.
17:30:16 <cu-kai> yeah
17:30:48 <peter1138> Right, have actually donated now. Stupid free-loading developer...
17:44:20 <peter1138> Hmm, I wonder if I can make the flags 14x10 and shift it over 1/3rd of a pixel...
17:44:57 <peter1138> At 3x interface scale it will then be perfect ;-)
18:02:49 *** kuka_lie has joined #openttd
18:07:52 *** Flygon has quit IRC (Read error: Connection reset by peer)
18:09:08 <_zephyris> Except for, you know, no 3x zoom sprites...
18:15:39 <peter1138> _zephyris, details.
18:15:50 <peter1138> I have a patch for it, but I'm not happy with it.
18:19:41 <_zephyris> It would be nice for gui
18:20:08 <_zephyris> Well, svg, and variable, but you know.
18:22:39 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1344736474012323962/image.png?ex=67c1feef&is=67c0ad6f&hm=7134d61f11c2d03cdfdd649d45aaa263c479a6af4f61145d04b329720480e5e4&
18:22:52 <peter1138[d]> No longer stretched.
18:23:58 <_zephyris> Looks good
18:26:49 <_zephyris> (except for the 1x zoom flag overlay shading)
18:31:41 <peter1138> It's kinda by design, so that the mix between 2x flag and 1x vehicle sprite isn't so jarring.
18:32:43 <peter1138> And your 2x version makes it look too much like some glossy overlay which isn't the look I was going for.
18:33:25 <peter1138> (I derived the overlay from existing shading applied to flags, probably from the 2CC set.)
18:40:26 <_zephyris> Fair enough, a stricter dither would work then.
18:42:20 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13666: Codechange: Always pass raw strings to TextFilter's AddLine(). https://github.com/OpenTTD/OpenTTD/pull/13666
18:44:27 <peter1138> I tried a 32bpp high resolution smooth gradient overlay from the start. It just didn't look and feel right.
18:45:17 <_zephyris> No gradients, no mismatched pixel scales, two classic fails 😉
18:45:35 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13666: Codechange: Always pass raw strings to TextFilter's AddLine(). https://github.com/OpenTTD/OpenTTD/pull/13666#pullrequestreview-2648750695
18:52:06 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #13651: Codechange: explicitly initialise member variables of Windows (3 of 5) https://github.com/OpenTTD/OpenTTD/pull/13651#pullrequestreview-2648765201
18:58:34 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13651: Codechange: explicitly initialise member variables of Windows (3 of 5) https://github.com/OpenTTD/OpenTTD/pull/13651
18:58:45 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #13652: Codechange: explicitly initialise member variables of Windows (4 of 5) https://github.com/OpenTTD/OpenTTD/pull/13652#pullrequestreview-2648781182
19:06:10 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13652: Codechange: explicitly initialise member variables of Windows (4 of 5) https://github.com/OpenTTD/OpenTTD/pull/13652
19:21:47 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13666: Codechange: Always pass raw strings to TextFilter's AddLine(). https://github.com/OpenTTD/OpenTTD/pull/13666
19:35:40 *** tokai|noir has joined #openttd
19:35:40 *** ChanServ sets mode: +v tokai|noir
19:36:51 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13667: Codechange: Use only raw strings in drop down lists. https://github.com/OpenTTD/OpenTTD/pull/13667
19:39:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13627: Add: Snow-covered rocks are now visible. https://github.com/OpenTTD/OpenTTD/pull/13627
19:42:54 *** tokai has quit IRC (Ping timeout: 480 seconds)
19:48:10 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13667: Codechange: Use only raw strings in drop down lists. https://github.com/OpenTTD/OpenTTD/pull/13667#pullrequestreview-2648930318
19:52:28 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13665: Codechange: Code style changes to AI/GS GUI files https://github.com/OpenTTD/OpenTTD/pull/13665
19:57:55 *** Wolf01 has joined #openttd
20:12:46 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #13653: Codechange: explicitly initialise member variables of Windows (5 of 5) https://github.com/OpenTTD/OpenTTD/pull/13653#pullrequestreview-2648980677
20:19:31 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13653: Codechange: explicitly initialise member variables of Windows (5 of 5) https://github.com/OpenTTD/OpenTTD/pull/13653
20:21:04 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13644: Codechange: remove ZeroedMemoryAllocator https://github.com/OpenTTD/OpenTTD/pull/13644
20:21:58 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1344766500342464592/image.png?ex=67c21ae6&is=67c0c966&hm=8e1d533a1e7cf964b8a208bd2f13d42dccd31c854dc00ab447d9c7d416c3ff89&
20:21:58 <xarick> wow, hog commiting suicide
20:22:11 <xarick> infrastructure maintenance costs evil
20:30:03 <xarick> oh wow
20:30:15 <xarick> 2 companies started at the same time...
20:30:51 <xarick> i thought the bug was fixed, that bug where multiple AI companies start
20:31:34 <xarick> let me find the issue
20:32:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #13667: Codechange: Use only raw strings in drop down lists. https://github.com/OpenTTD/OpenTTD/pull/13667#pullrequestreview-2648930318
20:32:24 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13667: Codechange: Use only raw strings in drop down lists. https://github.com/OpenTTD/OpenTTD/pull/13667
20:33:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13667: Codechange: Use only raw strings in drop down lists. https://github.com/OpenTTD/OpenTTD/pull/13667#issuecomment-2689051850
20:34:04 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13667: Codechange: Use only raw strings in drop down lists. https://github.com/OpenTTD/OpenTTD/pull/13667#pullrequestreview-2649023402
20:35:20 <xarick> should I reopen? <https://github.com/OpenTTD/OpenTTD/issues/10379>
20:35:29 <xarick> I just witnessed it happening again
20:40:18 *** Wolf01 is now known as Guest10288
20:40:20 *** Wolf01 has joined #openttd
20:42:01 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1344771546564268144/image.png?ex=67c21f99&is=67c0ce19&hm=276a51a0f6092df7bd8632422bf5271b777195dd2edb9c4abad6f971be81fb35&
20:42:01 <xarick> AdmiralAI shouldn't have started
20:45:02 <peter1138> Right, Firefox account deleted. Dumbarses.
20:45:54 *** Guest10288 has quit IRC (Ping timeout: 480 seconds)
20:57:59 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
21:05:35 *** SigHunter has quit IRC ()
21:08:12 <_glx_> xarick: looking at the code it should not happen
21:08:55 <xarick> i deleted the branch with a possible fix 😦
21:09:04 <xarick> how would I recover?
21:09:37 <peter1138> Rewrite it.
21:11:01 *** SigHunter has joined #openttd
21:11:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13667: Codechange: Use only raw strings in drop down lists. https://github.com/OpenTTD/OpenTTD/pull/13667
21:11:28 *** geertop has quit IRC (Quit: User went offline on Discord a while ago)
21:11:51 <_glx_> the 10 minute timer starts one, then OnTick_Companies() starts the remaining, and the total number is checked everytime
21:13:49 <_glx_> oh I see what may happen, 10 minute timer starts one, it's delayed, then OnTick_Companies() starts the remaining starts one too many
21:16:09 <_glx_> kinda impossible to prevent
21:17:09 <xarick> found a remnant https://github.com/SamuXarick/OpenTTD/commit/a0d5a31349471c877560c670bb830d7711de8402
21:17:14 *** kuka_lie has quit IRC (Quit: Lost terminal)
21:18:25 <_glx_> unapplicable, most of the code you modified doesn't exist anymore
21:19:44 <peter1138> What does "it's delayed" mean where?
21:19:47 <peter1138> -w
21:19:59 <_glx_> command sent, but processed later
21:20:08 <_glx_> 1 tick delay usually
21:21:07 <_glx_> anyway I see the idea behind this old PR, instead of 1 command per ai it's multiple ai per command
21:21:34 <xarick> yeh
21:23:15 <peter1138> Hmm, if we're expecting an AI in a specific slot, pass the expected slot in the command. Then let the command fail if that slot is already occupied?
21:24:42 <peter1138> Might have difficulties if the start interval is low. Hmm.
21:26:58 <_glx_> interval is in minute, should be fine
21:27:17 <_glx_> then only "problematic" case is the special 0 minute
21:28:22 <_glx_> OnTick_Companies() doesn't start anything except of the special 0 minute, all other cases are started by timer
21:29:19 <peter1138> So passing expected slot might work.
21:29:23 <_glx_> oh easier, don't send command in _new_competitor_timeout if _settings_game.difficulty.competitors_interval is 0
21:29:52 <_glx_> since OnTick_Companies() will mass start anyway
21:33:07 <peter1138> Hmm.
21:35:02 <peter1138> Reading a Japanese changelog is awkward. Pom te pom.
21:35:31 <_glx_> xarick: try https://github.com/OpenTTD/OpenTTD/compare/master...glx22:OpenTTD:ai_start_too_many
21:36:40 <xarick> oh, just that?
21:37:18 <xarick> seems rather simple
21:42:05 <xarick> that timer isn't reached at start up
21:43:09 <_glx_> timer has "fired" when created
21:43:38 <xarick> placed some breakpoints there...
21:44:05 <_glx_> but it first real fire event is after 10 minutes
21:44:33 <xarick> oh, ok let me bankrupt some ai
21:44:42 <xarick> then wait 10 minutes
21:44:47 *** nielsm has quit IRC (Ping timeout: 480 seconds)
21:45:17 <xarick> erm... AIs slowing down lel
21:46:52 <_glx_> anyway the issue could not happen in single player
21:48:22 <DorpsGek> [OpenTTD/OpenTTD] absay opened issue #13668: [Bug]: Attempting to rename most vehicle infrastructure with strings with length >=32 characters causes game to crash https://github.com/OpenTTD/OpenTTD/issues/13668
21:48:38 <_glx_> oh seems bad
21:49:46 <truebrain> more textbuf? 😄
21:49:48 <peter1138> Hmm, is that different to before?
21:50:22 <peter1138> Oh it is.
21:50:43 <peter1138> Triggered on an assert, not iterators failing.
21:55:54 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #13668: [Bug]: Attempting to rename most vehicle infrastructure with strings with length >=32 characters causes game to crash https://github.com/OpenTTD/OpenTTD/issues/13668
21:56:01 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1344790167289860105/image.png?ex=67c230f0&is=67c0df70&hm=6c837a5ed7cae133f546cb1a4ee4a64adbe756aa90aad298f3c75b909387a2bc&
21:56:01 <xarick> how long are those 10 minutes?
21:59:09 <xarick> anyway, I have a breakpoint ready
21:59:21 <xarick> probably gonna take 30 minutes
22:05:23 <peter1138> Yeah, at 0.32x, about 3 times longer...
22:10:25 <DorpsGek> [OpenTTD/OpenTTD] absay commented on issue #13668: [Bug]: Attempting to rename most vehicle infrastructure with strings with length >=32 characters causes game to crash https://github.com/OpenTTD/OpenTTD/issues/13668
22:10:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13669: Codechange: Use EnumBitSet for ScriptConfigFlags. https://github.com/OpenTTD/OpenTTD/pull/13669
22:11:39 <_glx_> oh it's 10 minutes in game ticks, so if game is paused it doesn't advance
22:13:30 <_glx_> and you can fast forward so it triggers faster
22:14:09 <peter1138> Not at 0.3x :D
22:14:12 <xarick> just triggered
22:14:22 <xarick> well, it returned
22:14:29 <xarick> seems to do the trick
22:15:00 <xarick> only 1 company was created, didn't surpass the limit
22:16:54 <xarick> where is this 10 minutes set? I could try lowering that to 1 minute
22:17:03 <xarick> faster tests
22:21:14 <xarick> found it
22:23:31 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #13670: Fix: More AI than max_no_competitors could start with competitors_interval=0 https://github.com/OpenTTD/OpenTTD/pull/13670
22:29:14 <xarick> i'm worried about line 765 though
22:29:42 <_glx_> why?
22:29:57 <_glx_> it's the mass start for all missing AIs
22:30:35 <_glx_> that's the one sending a duplicate of the timeout one
22:30:39 <xarick> wondering if it's safe
22:30:50 <_glx_> but now timeout doesn't send anything
22:31:46 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
22:31:50 <xarick> Company::GetNumItems()... could be delayed
22:32:44 <xarick> at line 763
22:32:47 <_glx_> but this code runs only every 10 minutes
22:34:11 <_glx_> if you're unlucky it may run exactly when a player creates a company on the server
22:35:22 <xarick> what I mean, it shouldn't rely on Company::GetNumItems(). should be checked outside the loop which executes new company
22:35:35 <xarick> let me try coding something
22:35:58 <peter1138> Line 762 doesn't need to be in the loop, but being in the loop doesn't prevent it from working.
22:37:14 <peter1138> Hmm, unless I'm misremembering what Post does ;D
22:37:37 <xarick> ``` uint num_companies = Company::GetNumItems();
22:37:37 <xarick> for (auto i = 0; i < _settings_game.difficulty.max_no_competitors; i++) {
22:37:37 <xarick> if (_networking && num_companies >= _settings_client.network.max_companies) break;
22:37:37 <xarick> if (n++ >= _settings_game.difficulty.max_no_competitors) break;
22:37:37 <xarick> Command<CMD_COMPANY_CTRL>::Post(CCA_NEW_AI, CompanyID::Invalid(), CRR_NONE, INVALID_CLIENT_ID);
22:37:38 <xarick> num_companies++;
22:37:38 <xarick> }```
22:38:39 <xarick> we manually count the number of companies
22:38:44 <peter1138> Probably the loop could be tidied up.
22:38:49 <_glx_> oh you can increment in the test
22:38:54 <peter1138> But `n` already handles that test.
22:39:29 <_glx_> `n` checks the AI limit, not the server limit
22:39:47 <xarick> n is for _settings_game.difficulty.max_no_competitors
22:39:47 <xarick> num_companies would be for _settings_client.network.max_companies
22:39:51 <peter1138> Oh fair.
22:40:06 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:43:58 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13670: Fix: More AI than max_no_competitors could start with competitors_interval=0 https://github.com/OpenTTD/OpenTTD/pull/13670
22:45:24 <xarick> looks good
22:47:00 <xarick> now if a human company happens in the meantime 😦
22:48:06 <_glx_> should be fine
22:48:34 <xarick> yes, but there's still that chance
22:48:43 <xarick> 0.00000001%
22:48:47 <_glx_> impossible to prevent
22:49:22 <xarick> would the bitmask approach solve it?
22:49:27 <_glx_> no
22:50:19 <xarick> if any of the companies in the mask is already up... fail the entire start up of companies
22:51:40 <xarick> it would be tried next time
22:51:45 <xarick> with a new mask
22:52:58 <_glx_> most servers don't use AI anyway
22:53:19 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
22:56:36 <_glx_> and the chance for a player creating a company at the exact moment seems very low, GUI events are processed outside the game loop
22:57:17 <peter1138> 'initializing': conversion from 'size_t' to 'uint8_t', possible loss of data
22:57:26 <peter1138> That old chestnut :)
22:57:40 <_glx_> ah indeed, it's in the error tab 🙂
22:58:40 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13670: Fix: More AI than max_no_competitors could start with competitors_interval=0 https://github.com/OpenTTD/OpenTTD/pull/13670
22:58:49 <_glx_> well let it be size_t then
23:09:28 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1344808654066683944/image.png?ex=67c24228&is=67c0f0a8&hm=b3dfb6c43af3008504daf0eece7d9ec57d5c4882b711a39e837c0f61b97dfc43&
23:09:28 <xarick> AAAHogEx struggling again...
23:10:30 <xarick> 150k loan and high costs
23:10:39 <xarick> and it has a bad start
23:10:48 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13671: Codechange: Use parameterised GetString() for script-related windows. https://github.com/OpenTTD/OpenTTD/pull/13671
23:12:58 <xarick> oh, it built an airport again
23:14:09 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1344809830757568594/image.png?ex=67c24341&is=67c0f1c1&hm=1c6294e96737c94bfd31d777514310f5bfd6037193e78319e2a695902173aa45&
23:14:09 <xarick> kek
23:14:23 <xarick> not even that human company is profiting
23:14:40 <xarick> but he has many trains to balance it out in the end
23:17:49 <xarick> question
23:17:55 <peter1138> answer
23:18:12 <xarick> are infrastructures disabled for AIs when i disable a type of vehicle they're allowed to build?
23:18:56 <peter1138> No. I have a patch for that.
23:18:58 <xarick> like i disable airports, are they still able to place airports?
23:19:08 <xarick> ok, patch it
23:19:14 <peter1138> Hmm, Jan 2024 :p
23:24:26 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #13671: Codechange: Use parameterised GetString() for script-related windows. https://github.com/OpenTTD/OpenTTD/pull/13671#pullrequestreview-2649315607
23:37:19 <xarick> something that could be tried
23:37:30 <xarick> remove roads when a company bankrupts
23:37:47 <xarick> but only those roads which have no vehicles
23:37:58 <xarick> a scan would take place
23:38:44 <xarick> check the entire road network to find for a vehicle
23:38:58 <xarick> if none is found, delete the road network
23:39:33 <xarick> road network could be every road, owned by towns or competitors
23:39:46 <xarick> if no vehicle found at all... remove
23:41:01 <xarick> maybe also consider road depots and road stations... i guess
23:41:10 <peter1138> Here's one I wrote earlier... https://github.com/OpenTTD/OpenTTD/compare/master...PeterN:OpenTTD:infrastructure-deny
23:41:45 <peter1138> IIRC it causes AIs to lose the plot. But they already lose the plot anyway.
23:41:56 <peter1138> They just fail earlier.
23:52:41 <peter1138> There might be commands added since then that need checks adding.
23:53:08 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13671: Codechange: Use parameterised GetString() for script-related windows. https://github.com/OpenTTD/OpenTTD/pull/13671
23:55:49 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13669: Codechange: Use EnumBitSet for ScriptConfigFlags. https://github.com/OpenTTD/OpenTTD/pull/13669
23:57:54 <peter1138> Breaking that stuff out into functions somewhat helped. I previously just stuffed those parameters into an array instead of dealing with it.
continue to next day ⏵
