⏴ go to previous day
01:45:58 *** Flygon has quit IRC (Remote host closed the connection)
02:43:08 *** tokai has joined #openttd
02:43:08 *** ChanServ sets mode: +v tokai
03:10:13 *** Wormnest has quit IRC (Quit: Leaving)
03:46:04 *** D-HUND has joined #openttd
03:49:39 *** debdog has quit IRC (Ping timeout: 480 seconds)
04:42:12 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/6283631155322059b73ab32317573552ab5e8d6b
04:42:13 <DorpsGek> - Update: Translations from eints (by translators)
05:14:43 *** keikoz has joined #openttd
06:35:55 *** HerzogDeXtEr has joined #openttd
07:32:22 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13569: Codechange: Use EncodedString for error messages. https://github.com/OpenTTD/OpenTTD/pull/13569#pullrequestreview-2619556789
07:48:21 <DorpsGek> [OpenTTD/OpenTTD] merni-ns commented on issue #13562: [Bug]: Shift clicking arrow buttons for "Increase money by" in Sandbox Options shows cost estimation message https://github.com/OpenTTD/OpenTTD/issues/13562
07:48:40 <DorpsGek> [OpenTTD/OpenTTD] James103 opened issue #13570: [Bug]: Confirmation messages no longer show their titles https://github.com/OpenTTD/OpenTTD/issues/13570
07:48:56 *** Speedy` has quit IRC (Read error: Connection reset by peer)
07:49:48 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on issue #13570: [Bug]: Confirmation messages no longer show their titles https://github.com/OpenTTD/OpenTTD/issues/13570
07:51:16 *** merni has joined #openttd
07:51:16 <merni> https://cdn.discordapp.com/attachments/1008473233844097104/1340591312059109408/image.png?ex=67b2ea73&is=67b198f3&hm=038bbe9bb93074881be0a558e27d8961c6172cccbcfbb5ed5cd7f058f23dae21&
07:51:16 <merni> Lol what a broken diff
07:53:55 *** Speedy` has joined #openttd
07:55:55 <merni> might be nice if someone reviewed https://github.com/OpenTTD/nml/pull/346 :P
07:58:25 <DorpsGek> [OpenTTD/nml] LordAro approved pull request #346: Update: changelog for 0.7.6 https://github.com/OpenTTD/nml/pull/346#pullrequestreview-2619560971
08:01:05 <wensimehrp> merni: heh _Caocao_
08:55:50 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13571: Codechange: manage the ParagraphLayouter's buffer with std::unique_ptr https://github.com/OpenTTD/OpenTTD/pull/13571
09:13:09 *** Wolf01 has joined #openttd
09:23:41 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13572: Fix #13570: Query window's caption was no longer visible. https://github.com/OpenTTD/OpenTTD/pull/13572
09:37:00 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13572: Fix #13570: Query window's caption was no longer visible. https://github.com/OpenTTD/OpenTTD/pull/13572#pullrequestreview-2619581290
09:38:42 <peter1138> #13562 could be fixed by adding NoEst to the CMD_MONEY_CHEAT trait, I think?
09:39:00 <peter1138> Did it again...
09:39:37 <andythenorth> oof accidentally read a reddit 'programmers should never use AI' thread
09:39:41 <andythenorth> so much wrong
09:39:49 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #13562: [Bug]: Shift clicking arrow buttons for "Increase money by" in Sandbox Options shows cost estimation message https://github.com/OpenTTD/OpenTTD/issues/13562
09:39:59 <andythenorth> not had enough coffee for this kind of thing
09:40:13 <peter1138> Based on your summary, it sounds correct.
09:43:51 <andythenorth> "yo bro, I just made a million dollar app in 3 hours with AI" is obviously nonsense, and shouldn't need dismissed
09:44:49 <andythenorth> I guess reddit doesn't get views that way though
09:46:49 <andythenorth> hmm can I pretend to be American today? I keep mistyping `catalogue`
09:46:55 <andythenorth> which could just be `catalog`
09:47:03 <andythenorth> pff...or `brochure` 😛
09:59:58 <peter1138> Have you catalogued your programmes?
10:00:10 <andythenorth> ooh
10:00:14 <andythenorth> I could
10:00:40 <andythenorth> seems like we could play buffalo buffalo, but with programmes
10:00:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13572: Fix #13570: Query window's caption was no longer visible. https://github.com/OpenTTD/OpenTTD/pull/13572
10:00:57 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #13570: [Bug]: Confirmation messages no longer show their titles https://github.com/OpenTTD/OpenTTD/issues/13570
10:02:03 <andythenorth> hmm, if an English word is both noun and verb, good chance it could recurse indefinitely?
10:04:37 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13569: Codechange: Use EncodedString for error messages. https://github.com/OpenTTD/OpenTTD/pull/13569
10:04:37 <peter1138> Yolo.
10:08:03 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13555: Codechange: use span size over terminator object https://github.com/OpenTTD/OpenTTD/pull/13555#pullrequestreview-2619587837
10:10:00 <truebrain> haha, to yolo or not to yolo 😄
10:13:43 <andythenorth> always yolo 😛
10:13:52 <andythenorth> otherwise you never find out why it was a poor choice
10:18:06 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13285: Codechange: Remove global string parameters. https://github.com/OpenTTD/OpenTTD/pull/13285
10:18:27 <peter1138> Getting closer.
10:19:16 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13555: Codechange: use span size over terminator object https://github.com/OpenTTD/OpenTTD/pull/13555
10:21:45 <peter1138> Hmm, I think tree planting doesn't need to know about land-mass proportion, as it doesn't retry.
10:21:53 <Rubidium> still some ways to go given the ~5k line (context-less) diff
10:22:54 <peter1138> Yeah, but we're well into the middle of the original set.
10:30:24 <peter1138> Hmm, should I fix all the languages... it's just one STRING → COMPANY and one 1:STRING → STRING.
10:33:32 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13573: Codechange: use std::vector over MallocT for NewGRFSpriteLayout registers https://github.com/OpenTTD/OpenTTD/pull/13573
10:37:27 <peter1138> Hmm.
10:38:47 <Rubidium> if the translator tool doesn't fix the warnings in the next cycle, I reckon you should. Otherwise I wouldn't bother too much about it
10:41:41 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13363: Codechange: do not use MallocT for newgrf commons https://github.com/OpenTTD/OpenTTD/pull/13363
10:45:33 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13574: Codechange: pass oldloader LoadgameState by reference instead of pointer https://github.com/OpenTTD/OpenTTD/pull/13574
10:46:09 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13573: Codechange: use std::vector over MallocT for NewGRFSpriteLayout registers https://github.com/OpenTTD/OpenTTD/pull/13573#pullrequestreview-2619595348
10:46:58 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13574: Codechange: pass oldloader LoadgameState by reference instead of pointer https://github.com/OpenTTD/OpenTTD/pull/13574#pullrequestreview-2619595538
10:48:27 <peter1138> In the GRF translations proposal, frosch123 mentioned doing the textref stack stuff before the NewGRF string hits the string system. I wonder if there is any existing code for that, or if I should side-quest...
10:51:10 <frosch123> I started with grf2txt. No ottd code yet.
10:51:22 <peter1138> Ok.
10:52:16 <frosch123> There are some challenges with STRING subparameters, which I habe not yet quite figured out
10:52:34 <peter1138> With decoding them, or with handling them in translations?
10:52:54 <peter1138> "Both" probably :D
10:54:22 <frosch123> Once the substring is known, we can recursive assign parameters indices. But normally that is already encoded in the translation
10:55:12 <frosch123> Ideas so far are either: add a STRINGx command which has a parameter for number of subdparam
10:56:32 <frosch123> Or add a new dparam type "dparam array" to the rawstr/uint64 variant
10:57:43 <xarick> I'm getting warnings while building <https://gist.github.com/SamuXarick/b63b90a37ff689cfae945772a585e57b#file-gistfile1-txt-L300-L608>
10:59:09 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 closed pull request #13363: Codechange: do not use MallocT for newgrf commons https://github.com/OpenTTD/OpenTTD/pull/13363
10:59:12 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13363: Codechange: do not use MallocT for newgrf commons https://github.com/OpenTTD/OpenTTD/pull/13363#issuecomment-2661376745
11:00:06 <DorpsGek> [OpenTTD/BaNaNaS] TrueBrain opened pull request #156: Change: Remove newgrf/4b520002 https://github.com/OpenTTD/BaNaNaS/pull/156
11:00:06 <peter1138> Trying to work out which branches I can delete due to Rubidium doing them better.
11:02:21 <peter1138> (And some of them were split and merged already...)
11:03:25 <peter1138> What usually happens is I side-quest in a branch and the scope goes all over the place, and I end up unhappy with the changes.
11:04:11 <peter1138> 75 files changed, 1139 insertions(+), 1444 deletions(-)
11:04:15 <peter1138> This is a big patch :(
11:08:16 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1340640890456375336/image.png?ex=67b318a0&is=67b1c720&hm=62e1ad19b4315e70464d1338afd98d3ffe710fe2d6ac4ba0a28d86a312d1d7c3&
11:08:16 <xarick> how do I solve this conflict for the road waypoint?
11:08:27 <xarick> it's a combo of 2 facil's
11:09:29 <peter1138> Hmm, I think I did that bit badly.
11:14:29 <xarick> `WAYPOINT_ROAD = (1U << to_underlying(::StationFacility::TruckStop)) | (1U << to_underlying(::StationFacility::BusStop)), ///< Road waypoint`
11:14:29 <xarick> like this? looks ugly big
11:14:56 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13575: Codefix 75387b9e2b: Prefer using EnumBitSet.base() instead of shifting StationFacility. https://github.com/OpenTTD/OpenTTD/pull/13575
11:15:02 <xarick> oh
11:16:00 <peter1138> You can do `::StationFacilities{::StationFacility::TruckStop, ::StationFacility::Waypoint}.base()`
11:16:13 <peter1138> It's still verbose, but less ugly.,
11:16:44 <xarick> ok, gonna wait for merge first
11:18:27 <xarick> StationFacility::Waypoint exists?
11:18:57 <peter1138> Sure.
11:19:29 <DorpsGek> [OpenTTD/nml] glx22 merged pull request #346: Update: changelog for 0.7.6 https://github.com/OpenTTD/nml/pull/346
11:19:32 *** Flygon has joined #openttd
11:19:37 <peter1138> (I don't know if what you are trying to do here is correct, only that this is the better way to set the thing.)
11:20:42 <xarick> I am wondering why the others don't use ::StationFacility::Waypoint
11:24:57 <peter1138> They test for waypoint with IsValidWaypoint.
11:25:04 <peter1138> So it doesn't need to have Waypoint on it.
11:26:55 <DorpsGek> [OpenTTD/nml] glx22 created new tag: 0.7.6 https://github.com/OpenTTD/nml/releases/tag/0.7.6
11:28:49 <peter1138> Yeah, I miswrote, ::Waypoint should be ::BusStop :-)
11:29:16 <peter1138> `::StationFacilities{::StationFacility::TruckStop, ::StationFacility::BusStop}.base()`
11:29:24 <peter1138> Right, patch splitting?
11:29:25 <peter1138> Or...
11:30:37 <DorpsGek> [OpenTTD/team] ImMorrow opened issue #619: [ar_EG] Translator access request https://github.com/OpenTTD/team/issues/619
11:31:18 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13574: Codechange: pass oldloader LoadgameState by reference instead of pointer https://github.com/OpenTTD/OpenTTD/pull/13574
11:31:30 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13573: Codechange: use std::vector over MallocT for NewGRFSpriteLayout registers https://github.com/OpenTTD/OpenTTD/pull/13573
11:33:34 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13575: Codefix 75387b9e2b: Prefer using EnumBitSet.base() instead of shifting StationFacility. https://github.com/OpenTTD/OpenTTD/pull/13575#pullrequestreview-2619604434
11:35:20 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13576: Codechange: do not use ZeroedMemoryAllocator for NewGRFSpriteLayout https://github.com/OpenTTD/OpenTTD/pull/13576
11:37:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13576: Codechange: do not use ZeroedMemoryAllocator for NewGRFSpriteLayout https://github.com/OpenTTD/OpenTTD/pull/13576#pullrequestreview-2619605125
11:37:40 <peter1138> Eh, silly scrolling.
11:38:42 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13576: Codechange: do not use ZeroedMemoryAllocator for NewGRFSpriteLayout https://github.com/OpenTTD/OpenTTD/pull/13576#pullrequestreview-2619605378
11:40:54 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13577: Codechange: move vehicle name to LoadgameState and change to std::vector https://github.com/OpenTTD/OpenTTD/pull/13577
11:41:01 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13563: Codefix: 'Declaration hides variable' https://github.com/OpenTTD/OpenTTD/pull/13563#pullrequestreview-2619605854
11:42:10 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13538: Codechange: add support for std::variant in EndianBuffer https://github.com/OpenTTD/OpenTTD/pull/13538#pullrequestreview-2619606055
11:42:40 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13563: Codefix: 'Declaration hides variable' https://github.com/OpenTTD/OpenTTD/pull/13563
11:44:14 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13538: Codechange: add support for std::variant in EndianBuffer https://github.com/OpenTTD/OpenTTD/pull/13538
11:44:25 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13563: Codefix: 'Declaration hides variable' https://github.com/OpenTTD/OpenTTD/pull/13563#pullrequestreview-2619606453
11:46:07 <_glx_> Oups little mistake in release workflow, but only affecting the assets in GitHub release
11:47:21 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13576: Codechange: do not use ZeroedMemoryAllocator for NewGRFSpriteLayout https://github.com/OpenTTD/OpenTTD/pull/13576
11:49:58 <DorpsGek> [OpenTTD/BaNaNaS] frosch123 approved pull request #156: Change: Remove newgrf/4b520002 https://github.com/OpenTTD/BaNaNaS/pull/156#pullrequestreview-2619607558
11:50:58 <DorpsGek> [OpenTTD/team] frosch123 commented on issue #619: [ar_EG] Translator access request https://github.com/OpenTTD/team/issues/619
11:51:15 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13576: Codechange: do not use ZeroedMemoryAllocator for NewGRFSpriteLayout https://github.com/OpenTTD/OpenTTD/pull/13576#pullrequestreview-2619607793
11:51:48 *** peter1138[d] has joined #openttd
11:51:48 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1340651843562373150/image.png?ex=67b322d3&is=67b1d153&hm=5dbdaf397e6331024252f8fa3df0f77d9e052853478788bdc5266aec556d7d8a&
11:51:53 <peter1138> Probably need to refactor this bit :-)
11:52:43 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13575: Codefix 75387b9e2b: Prefer using EnumBitSet.base() instead of shifting StationFacility. https://github.com/OpenTTD/OpenTTD/pull/13575
11:59:33 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13497: Codechange: make all pool item indices strongly typed https://github.com/OpenTTD/OpenTTD/pull/13497
11:59:36 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13510: Codechange: use std::variant for NewsReference https://github.com/OpenTTD/OpenTTD/pull/13510
12:02:09 <Rubidium> those fun times when there's no code conflict, but it doesn't compile anymore after rebasing... potentially breaking master with all checks being green
12:02:22 <peter1138> Yeah.
12:14:53 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1340657657014648905/image.png?ex=67b3283d&is=67b1d6bd&hm=29b5e1dec8513a7a0775a8c7d638925b36648ddf285a116a081386ca7ae1d157&
12:15:58 <peter1138> Better approach perhaps? Splitting it into separate formatting stages may affect translations.
12:18:18 <peter1138> Ah crap, I need to force the preview window to pop up...
12:21:24 <DorpsGek> [OpenTTD/BaNaNaS] TrueBrain merged pull request #156: Change: Remove newgrf/4b520002 https://github.com/OpenTTD/BaNaNaS/pull/156
12:27:55 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13398: Add: [Script] Multiple road waypoints API functions https://github.com/OpenTTD/OpenTTD/pull/13398
12:28:10 <peter1138> Ah yes, clang-15 no longer works, forgot :D
12:35:23 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #13577: Codechange: move vehicle name to LoadgameState and change to std::vector https://github.com/OpenTTD/OpenTTD/pull/13577#pullrequestreview-2619616875
12:38:08 <truebrain> so it is NAND and NOR, but not NXOR? Pffff
12:38:54 <peter1138> :S
12:39:21 <truebrain> Exclusive NOT-OR, is the reasoning for it
12:39:22 <truebrain> pfff
12:39:22 <peter1138> I think that PR is dead because you can just combine different operations already.
12:39:41 <peter1138> I dunno.
12:39:51 <truebrain> I can't judge that, I have to admit. But my OCD triggered. Your PR is correct, naming wise, but it still annoys me 😛
12:42:18 *** ahyangyi has joined #openttd
12:42:19 <ahyangyi> truebrain: I guess people prefer XNOR to NXOR because "nor" is an English word?
12:42:29 <truebrain> so linguistics won from OCD?
12:42:33 <truebrain> How DARE they 😛
12:44:40 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13563: Codefix: 'Declaration hides variable' https://github.com/OpenTTD/OpenTTD/pull/13563
12:44:50 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13576: Codechange: do not use ZeroedMemoryAllocator for NewGRFSpriteLayout https://github.com/OpenTTD/OpenTTD/pull/13576
12:45:10 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13577: Codechange: move vehicle name to LoadgameState and change to std::vector https://github.com/OpenTTD/OpenTTD/pull/13577
12:49:46 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #13547: Fix #13307: Return non-zero value when there is a mistake in command-line arguments https://github.com/OpenTTD/OpenTTD/pull/13547#pullrequestreview-2619618185
12:49:55 <truebrain> `ret = 1; return ret;` .. for some reasons that felt odd
12:49:58 <truebrain> why did I approve? Weird
12:50:12 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #13547: Fix #13307: Return non-zero value when there is a mistake in command-line arguments https://github.com/OpenTTD/OpenTTD/pull/13547#pullrequestreview-2619618185
12:51:06 <truebrain> Rubidium: gratz on writing good PR descriptions; I actually want to read them 🙂
12:52:27 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13497: Codechange: make all pool item indices strongly typed https://github.com/OpenTTD/OpenTTD/pull/13497
12:52:30 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13510: Codechange: use std::variant for NewsReference https://github.com/OpenTTD/OpenTTD/pull/13510
12:56:55 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #13521: Codechange: make CompanyID a PoolID https://github.com/OpenTTD/OpenTTD/pull/13521#pullrequestreview-2619621697
12:57:44 <truebrain> I do not know btw why CompanyID isn't an enum like the other pools, but I am sure you had your reasons 😄
13:00:29 <truebrain> owh, you change that later in that PR to constexpr too
13:00:29 <Rubidium> interesting statement :D
13:00:38 <truebrain> I should read further in PRs before wondering about stuff
13:00:59 <truebrain> Basically: less brain, more reading
13:01:06 <Rubidium> oh, you're reading the NewsReference PR
13:01:11 <truebrain> yeah
13:01:57 <truebrain> minus the comment from peter, PR looks fine. But I will wait for 13521 to be merged, and th enews PR to be rebased, before approving 😛
13:02:22 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13521: Codechange: make CompanyID a PoolID https://github.com/OpenTTD/OpenTTD/pull/13521
13:05:27 <Rubidium> thanks!
13:07:56 <Rubidium> that open comment had been resolved already
13:08:45 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13497: Codechange: make all pool item indices strongly typed https://github.com/OpenTTD/OpenTTD/pull/13497
13:08:48 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13510: Codechange: use std::variant for NewsReference https://github.com/OpenTTD/OpenTTD/pull/13510
13:08:51 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #13467: Codechange: Null video driver: End on game exit https://github.com/OpenTTD/OpenTTD/pull/13467#issuecomment-2661425046
13:09:13 *** kuka_lie has joined #openttd
13:10:11 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #13510: Codechange: use std::variant for NewsReference https://github.com/OpenTTD/OpenTTD/pull/13510#pullrequestreview-2619624612
13:10:22 <truebrain> I am sure there is a typo somewhere in one of these PRs, but I am also sure we will tackle that when it is being reported 🙂
13:14:40 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1340672699982151681/image.png?ex=67b33640&is=67b1e4c0&hm=1d78ee0ad855e373faf09267db841cbb5b8bc9b4b3a796f0f20bd82b70e92ccf&
13:14:40 <xarick> got a crash - I was writting into the console as it hapens
13:16:35 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed pull request #12671: Doc: Mention Release type https://github.com/OpenTTD/OpenTTD/pull/12671
13:16:38 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #12671: Doc: Mention Release type https://github.com/OpenTTD/OpenTTD/pull/12671#issuecomment-2661428408
13:16:40 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1340673203952943174/message.txt?ex=67b336b8&is=67b1e538&hm=921a6288be7ff7a557c5dc5167210aa489639ee0964258ec4d771b89640a434d&
13:17:17 <_glx_> indeed related to the console
13:23:14 <DorpsGek> [OpenTTD/OpenTTD] James103 opened issue #13578: [Crash]: when typing in the in-game console https://github.com/OpenTTD/OpenTTD/issues/13578
13:23:34 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #12039: Change: Restore original width of spacers in main toolbars. https://github.com/OpenTTD/OpenTTD/pull/12039#issuecomment-2661431560
13:24:07 <truebrain> lol @ that bug, that is a funny report 🙂
13:25:04 <_glx_> hey we have a spy in this channel 🙂
13:25:42 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12097: Change: [Script] Improve some ScriptAirport return values for AT_OILRIG airport type https://github.com/OpenTTD/OpenTTD/pull/12097
13:25:45 <DorpsGek> [OpenTTD/nml] glx22 opened pull request #364: Fix 530e325f: 'gh' requires a git repository https://github.com/OpenTTD/nml/pull/364
13:26:50 <_glx_> and I tested and restested the release workflow before opening #363, missed the issue because pypi upload always fails on fork
13:27:46 <xarick> thx @James103
13:28:03 <xarick> spares me the trouble of submitting a bug report
13:28:16 <peter1138> Does not crash for me on Linux.
13:28:38 <truebrain> ghehe, I checked the same thing 🙂
13:28:57 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #13578: [Crash]: when typing in the in-game console https://github.com/OpenTTD/OpenTTD/issues/13578
13:29:11 <Rubidium> close are unreproducible by a committee of three
13:29:42 <truebrain> one took the effort to write it in the right place 😛 😛 😛 😄
13:29:43 <DorpsGek> [OpenTTD/nml] glx22 updated pull request #364: Fix 530e325f: 'gh' requires a git repository https://github.com/OpenTTD/nml/pull/364
13:32:45 <truebrain> awh, also works fine on Windows
13:32:47 <truebrain> that's sad
13:33:33 <truebrain> owh, just MSVC not understanding what "git pull" means
13:33:34 <truebrain> lolz
13:41:25 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #13578: [Crash]: when typing in the in-game console https://github.com/OpenTTD/OpenTTD/issues/13578
13:41:35 <_glx_> caller is nasty
13:43:02 <truebrain> `warning C4346: 'BaseBitSet<EnumBitSet<Tenum,Tstorage,Tend_value>,Tenum,Tstorage,EnumBitSetMask<Tstorage,Tenum,Tend_value>::value>::ValueType': dependent name is not a type` lol @ that error 🙂
13:44:10 <truebrain> I still don't understand how the MSVC git window actually works
13:44:17 <truebrain> I just hit buttons long enough for it to sync up with upstream again
13:44:28 <_glx_> I do all git stuff on terminal
13:45:17 <truebrain> I guess the error above is because my MSVC hasn't updated in a while ...
13:50:02 <andythenorth> hmm black
13:50:14 <peter1138> You can't go back?
13:50:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13510: Codechange: use std::variant for NewsReference https://github.com/OpenTTD/OpenTTD/pull/13510
13:50:25 <andythenorth> forcing black on pre-commit would produce sometimes large diffs
13:50:31 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #12039: Change: Restore original width of spacers in main toolbars. https://github.com/OpenTTD/OpenTTD/pull/12039#issuecomment-2661441569
13:50:33 <andythenorth> guess I keep using it manually
13:51:35 <_glx_> use the correct version first 🙂
13:51:45 <truebrain> _glx_: I can't blame you. I don't understand why they made it so utterly complex ....
13:52:30 <_glx_> hehe, but I use github desktop for commits 🙂
13:53:02 <_glx_> and initial push of branch
13:53:17 <truebrain> okay, after updating MSVC (it was only a year old!), I can compile OpenTTD again 🙂
13:53:28 <truebrain> funny how that works 😛
13:53:44 <peter1138> We should revert everything modern.
13:53:47 <peter1138> Switch back to C.
13:53:49 <truebrain> no
13:54:30 <truebrain> or at least: please create a fork and do it there 😛
13:55:16 <_glx_> yeah language warnings everywhere
13:55:43 <_glx_> I remember when they used to halt MSVC build
13:55:58 <truebrain> hmm .. so on Linux I can attach GDB and get a breakpoint on assert
13:56:00 <truebrain> on MSVC it does not 😛
13:56:34 <_glx_> that should work with MSVC too
13:57:37 <_glx_> if source matches the exe
13:57:52 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #13578: [Crash]: when typing in the in-game console https://github.com/OpenTTD/OpenTTD/issues/13578
13:58:26 <truebrain> I guess I am starting OpenTTD wrong
13:58:32 <truebrain> I guess the green arrow is the wrong button to press
13:58:51 <truebrain> ah, yes, it needs to be the green with a lighter green in it
13:58:52 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13579: Codechange: Build engine preview strings from separate strings. https://github.com/OpenTTD/OpenTTD/pull/13579
13:58:54 <truebrain> makes sense, etc 😛
13:59:13 <truebrain> hmm, no, neither work
13:59:19 <truebrain> Did I ever mention I don't like MSVC? 😄
13:59:50 <_glx_> 2 green arrow means you are in solution mode
13:59:55 <truebrain> so I have `RelWithDebInfo` selected, and I hit `Debug` -> `Start Debugger` .. I trigger 13578, and it does not throw me back to the editor
13:59:58 <_glx_> I use folder mode
14:00:50 <truebrain> I have no clue what I am doing wrong ... does it really throw you back to your editor _glx_ ?
14:01:14 <truebrain> breakpoints do work
14:01:17 <truebrain> so that is something
14:01:23 <_glx_> I wait for the assert, it shows me the crash window, I press retry
14:01:37 <_glx_> no breakpoint needed 🙂
14:01:41 <truebrain> https://cdn.discordapp.com/attachments/1008473233844097104/1340684530335350845/image.png?ex=67b34144&is=67b1efc4&hm=a85fa42088d503855902630b419371667a5dd70e0c0e4e566b6768385eea1a9d&
14:01:44 <truebrain> is as far as I get
14:02:08 <_glx_> oh it crashes before the assert in debug build
14:02:20 <truebrain> full debug, not RelWithDebInfo?
14:02:41 <_glx_> ```File: C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\include\xstring
14:02:41 <_glx_> Line: 50
14:02:41 <_glx_> Expression: cannot dereference string iterator because the iterator was invalidated (e.g. reallocation occurred, or the string was destroyed)```
14:03:05 <_glx_> something fishy
14:03:25 <_glx_> inside Utf8Encode()
14:03:26 <truebrain> oowwhhh, I had `x64-Release` selected
14:03:29 <truebrain> I guess that is the reason?
14:04:00 <_glx_> if release is without debug info maybe
14:04:09 <peter1138> 16 characters smells of "std::string switching from internal storage to allocated storage"
14:04:24 <truebrain> there we go, that was it 😄 Sorry for being MSVC noob 😛
14:05:02 * peter1138 is a bad reviewer :(
14:05:29 <_glx_> yup it doesn't like `return Utf8Encode(&*s, c)`
14:06:15 <truebrain> the `&*s` seems to be the issue
14:06:59 <_glx_> NOT REACHED() is just a side effect of release builds not doing iterator checks
14:07:37 <truebrain> and peter1138 is the winner 😛
14:07:54 <truebrain> so after `this->buf.insert(...)`, the iterator is no longer valid
14:08:12 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #13578: [Crash]: when typing in the in-game console https://github.com/OpenTTD/OpenTTD/issues/13578
14:08:28 <truebrain> `pos` is invalid after `this->buf.insert(..)`
14:09:03 <_glx_> pos = ...; should be enough
14:09:12 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #13578: [Crash]: when typing in the in-game console https://github.com/OpenTTD/OpenTTD/issues/13578
14:09:42 <truebrain> the weirdness of std::strings, and the difference between platforms 😄
14:10:32 <_glx_> ah I crashed using delete key
14:12:02 <_glx_> ```File: C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\include\xstring
14:12:02 <_glx_> Line: 54
14:12:02 <_glx_> Expression: cannot dereference string iterator because it is out of range (e.g. an end iterator)```
14:13:07 <_glx_> hmm why is the string empty ???
14:13:26 <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #12039: Change: Restore original width of spacers in main toolbars. https://github.com/OpenTTD/OpenTTD/pull/12039#pullrequestreview-1871526645
14:13:29 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #12039: Change: Restore original width of spacers in main toolbars. https://github.com/OpenTTD/OpenTTD/pull/12039
14:14:14 <_glx_> ah no it's not empty, it's the result of <https://github.com/OpenTTD/OpenTTD/blob/master/src/textbuf.cpp#L62>
14:15:01 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #12039: Change: Restore original width of spacers in main toolbars. https://github.com/OpenTTD/OpenTTD/pull/12039#issuecomment-2661452220
14:15:23 <_glx_> `buf` contains "list ", and `caret_pos` is 5
14:15:55 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #13580: Fix fd2949d: std::string can reallocate on insert() https://github.com/OpenTTD/OpenTTD/pull/13580
14:16:06 <truebrain> that for me fixes all problems I could find
14:16:09 <truebrain> deleting, inserting, etc
14:17:01 <_glx_> I triggered delete crash with that
14:17:16 <truebrain> "delete crash", as in, pressing the delete key on your keyboard?
14:17:19 <truebrain> as that works fine for me
14:17:29 <peter1138> Probably depends where you are in the string.
14:17:34 <peter1138> (And how long it is.)
14:17:42 <truebrain> and whether it has non-ASCII 😄
14:17:52 <_glx_> yes I typed "list " then delete to remove the space
14:18:00 <truebrain> backspace?
14:18:14 <truebrain> or delete?
14:18:22 <_glx_> backspace
14:18:24 <_glx_> my bad
14:18:25 <truebrain> ah
14:18:36 <truebrain> yeah, crashes here too 😄
14:18:43 <_glx_> this->buf.begin() + this->caretpos returns end()
14:19:44 <_glx_> a quick look tells me `Textbuf::DeleteChar` is full of potential problems
14:20:00 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on pull request #13580: Fix fd2949d: std::string can reallocate on insert() https://github.com/OpenTTD/OpenTTD/pull/13580#issuecomment-2661454088
14:20:02 <peter1138> Balls. Can I unapprove a merged PR? :)
14:20:19 <truebrain> we call that a revert 😛
14:20:50 <peter1138> I approve... of the principle.
14:22:01 <truebrain> funny how Linux is just fine with it 🙂
14:22:13 <peter1138> Yeah, it shouldn't be.
14:22:25 <_glx_> I'd assume `s` is `end()` too on linux
14:22:37 <peter1138> The built-in buffer is longer, but even going way past that I didn't get it to fail.
14:23:08 <peter1138> Just your usual undefined behaviour of accessing invalid iterators.
14:23:50 <truebrain> okay, so this issue only happens when deleting the end of the string
14:25:08 <truebrain> and it used to work, as it was just C-string access .. ghehe, funny
14:25:27 <_glx_> yes makes sense since the end is `end()`
14:25:47 <_glx_> carret is after last char
14:26:24 <truebrain> and Linux allows you to get a pointer out of `end()` , where MSVC just crashes?
14:26:48 <_glx_> in debug MSVC validates accesses
14:27:36 <_glx_> let's see what happens with release
14:30:09 <_glx_> works fine in release
14:30:14 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #12039: Change: Restore original width of spacers in main toolbars. https://github.com/OpenTTD/OpenTTD/pull/12039#pullrequestreview-2619642821
14:30:43 <truebrain> okay, so we should just use `std::prev`, and then it works fine
14:30:48 <_glx_> but the extra validation is correct, we should not dereference `end()`
14:31:11 <xarick> will clang crash?
14:31:56 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #13580: Fix fd2949d: std::string can reallocate on insert() https://github.com/OpenTTD/OpenTTD/pull/13580
14:32:02 <truebrain> not sure there is a better way to do it, but that PR now has 2 commits 🙂
14:34:13 <truebrain> I am sure there is some `for()` construct here, but I didn't see it 😛
14:38:29 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12084: Add: [Script] GetAirportNumHangars, simplify GetNumHangars https://github.com/OpenTTD/OpenTTD/pull/12084
14:40:01 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13580: Fix fd2949d: std::string can reallocate on insert() https://github.com/OpenTTD/OpenTTD/pull/13580#pullrequestreview-2619644949
14:40:17 <_glx_> at least the return 😉
14:40:53 <truebrain> that makes more sense 😄
14:41:48 <_glx_> need to test the word mode, to be sure
14:42:04 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #13580: Fix fd2949d: std::string can reallocate on insert() https://github.com/OpenTTD/OpenTTD/pull/13580
14:42:11 <_glx_> something I never used
14:42:55 <_glx_> ok word mode works
14:45:44 <_glx_> hmm need to test more, comment says `Delete whitespace and word in front of the caret.` but whitespace not removed
14:46:36 <_glx_> ok beta does the same
14:46:43 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13455: Change: [Script] ScriptVehicleList_Station no longer works for waypoints https://github.com/OpenTTD/OpenTTD/pull/13455
14:46:56 <xarick> ugh... so many conflicts
14:48:21 <_glx_> oh I misunderstood, it removes the word and whitespaces between the word and the caret
14:48:29 <_glx_> makes sense
14:51:09 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #13580: Fix fd2949d: std::string can reallocate on insert() https://github.com/OpenTTD/OpenTTD/pull/13580#pullrequestreview-2619647553
14:51:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #12039: Change: Restore original width of spacers in main toolbars. https://github.com/OpenTTD/OpenTTD/pull/12039
14:56:42 <truebrain> yeah, a second review might be good here 🙂
14:57:26 <_glx_> code itself should be fine, but maybe we missed some corner case somewhere else
14:57:37 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13580: Fix fd2949d: std::string can reallocate on insert() https://github.com/OpenTTD/OpenTTD/pull/13580#pullrequestreview-2619648884
14:58:02 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #13580: Fix fd2949d: std::string can reallocate on insert() https://github.com/OpenTTD/OpenTTD/pull/13580#issuecomment-2661468968
14:58:55 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13456: Add: [Script] ScriptVehicleList_Waypoint https://github.com/OpenTTD/OpenTTD/pull/13456
15:36:28 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #13580: Fix fd2949d: std::string can reallocate on insert() https://github.com/OpenTTD/OpenTTD/pull/13580
15:36:31 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed issue #13578: [Crash]: when typing in the in-game console https://github.com/OpenTTD/OpenTTD/issues/13578
15:36:32 <truebrain> if we find more cases, we can always address those too 🙂
15:37:04 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #13578: [Crash]: when typing in the in-game console https://github.com/OpenTTD/OpenTTD/issues/13578
15:38:13 *** Smedles has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
15:38:28 *** Smedles has joined #openttd
15:50:09 <peter1138> So, timing coincidence, or is James reading this channel...
15:51:38 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13497: Codechange: make all pool item indices strongly typed https://github.com/OpenTTD/OpenTTD/pull/13497
15:53:04 *** virtualrandomnumber has joined #openttd
15:59:43 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13581: Codechange: strongly type StationID https://github.com/OpenTTD/OpenTTD/pull/13581
16:00:52 *** virtualrandomnumber has quit IRC (Quit: virtualrandomnumber)
16:04:10 <xarick> rubidium42viaGitHub: i foresee more conflicts
16:04:58 <peter1138> Hmm, time for a one-step-at-a-time rebase.
16:05:22 <peter1138> Full build each step.
16:06:37 *** virtualrandomnumber has joined #openttd
16:11:48 <Rubidium> I hope you don't have too many commits to rebase through
16:12:34 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13582: Codechange: let the ReusableBuffer use std::vector as storage https://github.com/OpenTTD/OpenTTD/pull/13582
16:13:02 <xarick> strange, it doesn't seem to be loading the correct AIs anymore
16:15:28 <xarick> probably a me problem
16:19:54 <xarick> nevermind, false alarm, the savegame had DummyAI's
16:21:12 *** Wormnest has joined #openttd
16:26:14 <xarick> i got airport, unbunch and waypoints, stations... I foresee at least 10+ rebases
16:30:16 <peter1138> Rubidium, about 10 or so.
16:30:37 <peter1138> At least, in this PR :)
16:30:37 *** virtualrandomnumber has quit IRC (Quit: virtualrandomnumber)
16:41:44 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12093: Add: [Script] GetTileOfAirport https://github.com/OpenTTD/OpenTTD/pull/12093
16:49:37 <peter1138> > error: no viable conversion from 'TownID' (aka 'PoolID<unsigned short, TownIDTag, 64000, 65535>') to 'uint32_t' (aka 'unsigned int')
16:49:40 <peter1138> Hmmmmmm
16:50:12 <peter1138> That's a bit weird.
16:50:37 <peter1138> I changed `void SetObjectAtStringParameters(StringID string, uint32_t index, TileIndex tile) const` to `std::string GetObjectAtString(StringID string, uint32_t index, TileIndex tile) const`
16:51:27 <peter1138> So in both the old and new code it passes `GetTownIndex(index)` as `uint32_t`.
16:55:42 <Rubidium> I made a ConvertibleThroughBase variant of that function, maybe that got lost in the rebase?
16:57:04 *** nielsm has joined #openttd
17:03:22 <xarick> hmm, i'm having trouble rebasing
17:03:31 <xarick> #12088
17:04:25 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1340730519431938078/image.png?ex=67b36c19&is=67b21a99&hm=9495e92ddd1dcd104b0558d545c5e71db19dbc9074399c43c25e378778b745da&
17:04:43 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #13582: Codechange: let the ReusableBuffer use std::vector as storage https://github.com/OpenTTD/OpenTTD/pull/13582#pullrequestreview-2619675452
17:04:44 <peter1138> Ah.
17:04:48 <xarick> AirPortPlaneCompatibility is an enum
17:05:04 <peter1138> Yes, just below it, and I'm too blind :-)
17:07:03 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #13581: Codechange: strongly type StationID https://github.com/OpenTTD/OpenTTD/pull/13581#pullrequestreview-2619675931
17:08:51 <xarick> `if (HasFlag(flags, ::AirportFTAClass::HELICOPTERS)) return APC_COMPATIBLE;` this went the Test treatment?
17:10:13 <xarick> flags.Test(::AirportFTAClass::Flag::Helicopters) right?
17:10:35 <_glx_> something like that yes
17:12:51 <peter1138> Now I just need to figure out how to do my changes for news again :)
17:13:21 <peter1138> This one has a few conflicts :D
17:18:06 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12088: Add: [Script] GetAirportPlaneCompatibility https://github.com/OpenTTD/OpenTTD/pull/12088
17:21:15 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13582: Codechange: let the ReusableBuffer use std::vector as storage https://github.com/OpenTTD/OpenTTD/pull/13582
17:21:36 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13582: Codechange: let the ReusableBuffer use std::vector as storage https://github.com/OpenTTD/OpenTTD/pull/13582#pullrequestreview-2619678728
17:22:54 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #13582: Codechange: let the ReusableBuffer use std::vector as storage https://github.com/OpenTTD/OpenTTD/pull/13582#pullrequestreview-2619678933
17:23:15 <truebrain> patch-killers, that is what they are peter1138 😛
17:24:39 <Rubidium> once peter1138's ready, there can't be that many patches that still apply and compile cleanly
17:25:54 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13581: Codechange: strongly type StationID https://github.com/OpenTTD/OpenTTD/pull/13581
17:36:03 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13583: Codechange: remove transitional supports from the pool https://github.com/OpenTTD/OpenTTD/pull/13583
17:36:56 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 closed pull request #13497: Codechange: make all pool item indices strongly typed https://github.com/OpenTTD/OpenTTD/pull/13497
17:36:59 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13497: Codechange: make all pool item indices strongly typed https://github.com/OpenTTD/OpenTTD/pull/13497#issuecomment-2661539601
17:41:42 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #13583: Codechange: remove transitional supports from the pool https://github.com/OpenTTD/OpenTTD/pull/13583#pullrequestreview-2619682234
17:41:58 <truebrain> took a bit of effort, but here we are 😄
17:51:22 <peter1138> Hmm, should I rebase again...
18:00:53 <peter1138> (Joking, I've been sat here not finishing the first rebase...)
18:02:34 <truebrain> awh 😦
18:11:48 <xarick> it only triggered 1 needs rebase.
18:11:52 <xarick> very suspicious
18:13:27 <xarick> how fast is the needs rebase checker?
18:14:13 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13457: Change: [Script] Remove IsValidBaseStation https://github.com/OpenTTD/OpenTTD/pull/13457
18:15:27 <DorpsGek> [OpenTTD/OpenGFX] glx22 updated pull request #90: Feature: Road waypoints https://github.com/OpenTTD/OpenGFX/pull/90
18:20:20 <xarick> why does it always trigger 826 files rebuilding when i rebase
18:20:44 <_glx_> depends which files are touched
18:31:16 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13582: Codechange: let the ReusableBuffer use std::vector as storage https://github.com/OpenTTD/OpenTTD/pull/13582
18:31:41 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13583: Codechange: remove transitional supports from the pool https://github.com/OpenTTD/OpenTTD/pull/13583
18:35:07 <xarick> it's been a very busy day with rebasings
18:36:07 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13584: Codechange: replace INVALID_X with XID::Invalid() for PoolIDs https://github.com/OpenTTD/OpenTTD/pull/13584
18:36:27 <truebrain> finally the PR it was all about, right?
18:36:31 <truebrain> the rest was just a side-quest? 😄
18:37:21 *** gelignite has joined #openttd
18:37:27 <xarick> thx rubidium
18:37:51 <truebrain> 157 changed files, dammmnnnnnn
18:40:04 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13579: Codechange: Build engine preview strings from separate strings. https://github.com/OpenTTD/OpenTTD/pull/13579#pullrequestreview-2619691572
18:41:47 <Rubidium> truebrain: no, the news reference one was the PR that it was all about. The whole PoolID was a side-quest
18:42:03 <truebrain> 😄
18:49:07 *** tokai|noir has joined #openttd
18:49:07 *** ChanServ sets mode: +v tokai|noir
18:49:59 <truebrain> Rubidium: you used search&replace for this PR?
18:51:07 <Rubidium> truebrain: mostly, just to distinguish e.g. STR_INVALID_ENGINE from INVALID_ENGINE
18:51:17 <truebrain> fair
18:51:37 <truebrain> but that means I don't have to check whether INVALID_NNN is replaced with NNN::End() 😛
18:51:44 <truebrain> that it isn't MMM::End()
18:52:21 <truebrain> basically, I only have to check that you aren't added a binary test to introduce a backdoor you want to abuse in 5 years 😛
18:54:03 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #13584: Codechange: replace INVALID_X with XID::Invalid() for PoolIDs https://github.com/OpenTTD/OpenTTD/pull/13584#pullrequestreview-2619693914
18:54:24 <truebrain> btw Rubidium, the authentication changes, with keys etc, was that done now? Or was there still work to be done? I can't remember really 🙂
18:54:44 <Rubidium> as far as I'm concerned it's done
18:55:56 *** tokai has quit IRC (Ping timeout: 480 seconds)
18:56:03 <truebrain> good!
18:56:23 <truebrain> companies no longer need password, and you can select who has access to your company, or where did you left it?
18:56:28 <truebrain> (I can also start the game etc, but this is easier)
18:56:40 <peter1138> Oops, I messed up that rebase. Managed to merge two commits, without using fixup/squash.
18:57:59 <Rubidium> in the UI you can add clients to your company, and they can then play as your company without password
18:59:41 <peter1138> Hmm.
19:00:24 <Rubidium> the allowed clients are saved in the company, so it should recover after a reload
19:00:30 <peter1138> Okay, fixed it, I had, fortunately, made an extra branch with the initial unmerged commit. Rebasing the broken commit on top of that split it out again.
19:00:39 <peter1138> git --magic.
19:01:36 <peter1138> Dunno about Rubidium's tools, but VS Code can do full match only replaces, so STR_INVALID_ENGINE and INVALID_ENGINE are distinct.
19:02:05 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13579: Codechange: Build engine preview strings from separate strings. https://github.com/OpenTTD/OpenTTD/pull/13579
19:02:44 <truebrain> Rubidium: perfect, tnx 🙂
19:05:15 <peter1138> Yeah, this has been merged and complete for quite a while :)
19:06:34 <truebrain> how do I lock my company?
19:06:34 *** APTX has quit IRC (Read error: Connection reset by peer)
19:06:38 <truebrain> I must be going blind 😄
19:06:40 *** APTX has joined #openttd
19:06:40 <peter1138> It's always locked.
19:07:12 <truebrain> I started a GUI server, I started a client, I joined the game, I could join the first company just fine?
19:07:15 <truebrain> what am I missing 🙂
19:07:54 <Rubidium> that the server and client have the same configuration and therefor the same key pair
19:08:00 <truebrain> ah!
19:08:02 <truebrain> good point 🙂
19:08:07 <truebrain> okay, let's fix that .... 😄
19:10:06 <truebrain> ah, right, yes, green person
19:10:15 <truebrain> it only has been, what, a year ago, and I just can't remember 😄
19:10:36 <truebrain> good; and cool 🙂
19:12:07 <peter1138> Okay, the second rebase had no conflicts \o/
19:23:05 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13584: Codechange: replace INVALID_X with XID::Invalid() for PoolIDs https://github.com/OpenTTD/OpenTTD/pull/13584
19:24:42 <Rubidium> I'll try to make less conflicting PRs from now on until the branch!
19:24:50 <truebrain> Awh 😦
19:31:32 * peter1138 tests again.
19:35:41 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13285: Codechange: Remove global string parameters. https://github.com/OpenTTD/OpenTTD/pull/13285
19:37:39 <xarick> pfff...
19:40:51 <xarick> I can't keep up
19:42:08 <peter1138> Maybe you should just give up.
19:43:12 <xarick> no, I'm fine, it's just that I wanted to do something after all these rebases
19:43:27 <xarick> and still not done with them
19:45:16 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13073: Add: NewGRF Badges feature https://github.com/OpenTTD/OpenTTD/pull/13073
19:47:14 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13073: Add: NewGRF Badges feature https://github.com/OpenTTD/OpenTTD/pull/13073#issuecomment-2661587783
19:48:33 <xarick> are StationID still used for waypoints?
19:50:11 <xarick> okay, they are
19:52:40 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13457: Change: [Script] Remove IsValidBaseStation https://github.com/OpenTTD/OpenTTD/pull/13457
20:08:08 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13409: Change: [Script] GetStationID can no longer return the StationID of waypoints https://github.com/OpenTTD/OpenTTD/pull/13409
20:11:34 *** virtualrandomnumber has joined #openttd
20:13:16 *** virtualrandomnumber has quit IRC ()
20:13:36 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13408: Add: [Script] GetBaseStationID https://github.com/OpenTTD/OpenTTD/pull/13408
20:22:47 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13398: Add: [Script] Multiple road waypoints API functions https://github.com/OpenTTD/OpenTTD/pull/13398
20:23:31 <DorpsGek> [OpenTTD/nml] PeterN updated pull request #359: Add: Support for NewGRF badges. https://github.com/OpenTTD/nml/pull/359
20:25:45 <DorpsGek> [OpenTTD/nml] PeterN updated pull request #359: Add: Support for NewGRF badges. https://github.com/OpenTTD/nml/pull/359
20:26:29 <peter1138> Hmm.
20:36:18 <peter1138> Well.
20:40:36 <peter1138> Back to splitting?
20:40:45 <andythenorth> badges eh? 😛
20:40:52 <andythenorth> how's Horse badges going?
20:40:58 <peter1138> I don't know.
20:41:41 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1340785193870430331/image.png?ex=67b39f04&is=67b24d84&hm=7ffbf89ee06e415f141ab69fd376343a60bc59f33b186e84b006a30729523e64&
20:41:41 <andythenorth> oh dear
20:42:51 <truebrain> light mode?! What kind of person are you?!
20:43:05 <wensimehrp> 🦡
20:43:18 <andythenorth> seems github doesn't change with time of day
20:43:35 <wensimehrp> I always have light mode on
20:43:44 <wensimehrp> even when using my code editor
20:43:53 <andythenorth> I used to prefer light mode, but my screen has outrageous NITS
20:43:53 <wensimehrp> i.e. visual studio code
20:44:01 <andythenorth> full white hurts 😛
20:44:12 <andythenorth> or my eyes got old 🙂
20:44:28 <wensimehrp> andythenorth: pro display xdr?
20:45:41 <truebrain> They should just ban light mode
20:46:32 <truebrain> I mean, you do you, but when ever I open a website that is only available in light mode, I go AAAGGGGHHHHHH, and go back in my cofin to rest
20:46:58 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1340786524043870218/image.png?ex=67b3a041&is=67b24ec1&hm=fd0160308b73178173b704db3fd665253dc3b6483c91f698896ee615af9f8d78&
20:46:58 <andythenorth> I don't know what a good screen is these days, but this hurts on full bright
20:47:11 <andythenorth> the older one didn't
20:47:12 <truebrain> stop posting lightmode screenshots
20:47:17 <truebrain> 😛
20:47:25 <andythenorth> remember when we could link things on the internet? 🙂
20:47:28 <andythenorth> instead of screenshots
20:47:47 <wensimehrp> never heard of. I'm too young
20:47:54 <truebrain> Like this?
20:48:59 <andythenorth> that's in light mode 😛
20:49:01 <andythenorth> oof
20:49:09 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13585: Codechange: Use GetString() with local parameters in script functions. https://github.com/OpenTTD/OpenTTD/pull/13585
20:49:28 <andythenorth> truebrain: are you between jobs? 🙂
20:49:33 <andythenorth> I have missed you being here
20:49:46 <andythenorth> 🧸
20:49:49 <truebrain> nah; I found a healthier job instead 🙂
20:50:00 <peter1138> When you get old enough your eyes might prefer light mode...
20:50:01 * Rubidium hopes truebrain doesn't go to openttd.org at night then ;)
20:50:12 <andythenorth> $someone should fix the css
20:50:18 <andythenorth> can Claude do it?
20:51:11 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12249: Add: [Script] Unbunch order flag https://github.com/OpenTTD/OpenTTD/pull/12249
20:52:41 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13585: Codechange: Use GetString() with local parameters in script functions. https://github.com/OpenTTD/OpenTTD/pull/13585#pullrequestreview-2619715022
20:54:11 <Rubidium> peter1138: did you put any effort into: +1234 -56? Or are you just lucky with #13073
20:54:39 <truebrain> wait, what? Lol
20:54:48 <peter1138> Heh
20:55:17 <peter1138> I could claim credit for it... and I will!
20:55:23 <peter1138> (But just luck.)
20:56:06 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12206: Fix #12193: Don't use the entire docking area when computing closest station tile https://github.com/OpenTTD/OpenTTD/pull/12206
21:14:32 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13073: Add: NewGRF Badges feature https://github.com/OpenTTD/OpenTTD/pull/13073#pullrequestreview-2619717149
21:21:37 <xarick> seriously, a huge block of conflict because of neighbor -> neighbour
21:21:47 <xarick> not even code
21:22:38 <xarick> took me 5 minutes to figure out what this was all about
21:26:59 *** gelignite has quit IRC (Quit: Stay safe!)
21:27:29 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13585: Codechange: Use GetString() with local parameters in script functions. https://github.com/OpenTTD/OpenTTD/pull/13585
21:29:58 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #10544: Fix #5713: Use pathfinder to find closest ship depot https://github.com/OpenTTD/OpenTTD/pull/10544
21:40:28 <xarick> great! now it's strings
21:40:33 <xarick> kek
21:40:44 <xarick> very unproductive day for me
21:41:41 <xarick> also commands
21:45:36 <xarick> note to self: be happy the game is getting support
21:55:25 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #10411: Expose more functions to game scripts https://github.com/OpenTTD/OpenTTD/pull/10411
21:55:39 *** nielsm has quit IRC (Ping timeout: 480 seconds)
21:58:27 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13073: Add: NewGRF Badges feature https://github.com/OpenTTD/OpenTTD/pull/13073#pullrequestreview-2619727502
22:04:17 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13073: Add: NewGRF Badges feature https://github.com/OpenTTD/OpenTTD/pull/13073#pullrequestreview-2619728628
22:04:21 <truebrain> 😮
22:04:33 <truebrain> is the world ready for that? 😛
22:04:44 <Rubidium> stop badgering him ;)
22:04:51 <truebrain> badger
22:05:30 <truebrain> https://cdn.discordapp.com/attachments/1008473233844097104/1340806289802133598/d8f-764037585.jpg?ex=67b3b2aa&is=67b2612a&hm=0ea5530716793b4ad0461866220ac8dd5c4dd8fab82a51c16ff77c1ed2ed2834&
22:06:03 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1340806428180480083/image.png?ex=67b3b2cb&is=67b2614b&hm=b72bb68db040e92af999259db2899b5f71081f63714ca3e1544e21b041757a03&
22:06:03 <xarick> btw...
22:06:03 <xarick> is that intended?
22:13:12 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1340808226790182983/image.png?ex=67b3b478&is=67b262f8&hm=42822f9fd591dbabfab34c864c7290c290a194fa492b70acde16db20c72f5141&
22:13:12 <xarick> I think it's swaped
22:18:58 <peter1138> Swapped?
22:21:18 <xarick> the blue colours
22:21:34 <wensimehrp> {BLACK}
22:22:07 <xarick> the blue in the newspaper should be in the manufacturer message
22:22:09 <andythenorth> https://tenor.com/view/badger-badger-badger-mushroom-mushroom-mushroom-iggydr-gif-18197905
22:22:37 <xarick> the black in the manufacturer message should be in the newspaper
22:22:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13586: Fix d13b0e0813: "New vehicle now available!" message is wrong colour. https://github.com/OpenTTD/OpenTTD/pull/13586
22:22:58 <peter1138> No, it's always meant to be black.
22:23:17 <xarick> 🙂
22:23:40 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #13586: Fix d13b0e0813: "New vehicle now available!" message is wrong colour. https://github.com/OpenTTD/OpenTTD/pull/13586#pullrequestreview-2619732497
22:23:50 <xarick> thx
22:23:54 *** belajalilija has joined #openttd
22:23:54 <belajalilija> https://tenor.com/view/badger-badger-badger-mushroom-mushroom-mushroom-iggydr-gif-18197905
22:24:08 <truebrain> Don't make me call a moderator!
22:24:28 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13073: Add: NewGRF Badges feature https://github.com/OpenTTD/OpenTTD/pull/13073
22:24:39 <xarothbrook> https://tenor.com/bVHxI.gif
22:26:09 <peter1138> Now I can add the rest in stages and.
22:26:12 <peter1138> And.
22:27:08 <xarick> d13b0e08134bd6aaca8d663614c55653b84e9b98 is a commit in your repository
22:27:29 <wensimehrp> 🦡
22:28:16 <xarick> nevermind, github is doing weird stuff
22:29:10 <xarick> it's not linking this to master
22:29:10 <wensimehrp> wensimehrp: hmm
22:50:01 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
22:50:42 <DorpsGek> [OpenTTD/eints] absay opened issue #206: Translations with warnings are showing with "Correct" status https://github.com/OpenTTD/eints/issues/206
22:50:43 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:52:18 <DorpsGek> [OpenTTD/OpenTTD] WenSimEHRP opened issue #13587: [Crash]: When generating map https://github.com/OpenTTD/OpenTTD/issues/13587
22:57:40 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
23:00:28 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13586: Fix d13b0e0813: "New vehicle now available!" message is wrong colour. https://github.com/OpenTTD/OpenTTD/pull/13586
23:03:19 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1340820839775469620/image.png?ex=67b3c037&is=67b26eb7&hm=6e58a806eb21ea0a7cd380af8e29683fdb193862166683316835d6dbcc87d2c8&
23:03:19 <xarick> that's unusual
23:03:47 <xarick> string related?
23:03:54 <xarick> gonna investigate
23:08:10 <xarick> `AISign.BuildSign(i_tile,tile_list.GetValue(i_tile));`
23:08:31 <xarick> the value is SQInteger
23:08:43 <xarick> expected Text? ...
23:08:51 <xarick> should just convert to text instead
23:09:40 <xarick> wondering if this is new
23:09:53 <xarick> but I don't recall ever seeing that error on chopper
23:10:28 *** kuka_lie has quit IRC (Quit: leaving)
23:11:10 <xarick> SQInteger ScriptList::GetValue(SQInteger item)
23:11:21 <xarick> anyway, I'm off to bed
23:26:33 <_glx_> xarick: used to build empty sign most likely, because SQInteger were just convert to nullptr
23:27:03 <_glx_> guess I need to add compatibility layer
23:42:16 <peter1138> Hmm.
23:46:06 <_glx_> indeed that was just doing nothing because `EnforcePrecondition(INVALID_SIGN, name != nullptr);`
23:54:43 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13588: Add: Filter purchase lists by badge text. https://github.com/OpenTTD/OpenTTD/pull/13588
continue to next day ⏵
