⏴ go to previous day
00:19:28 *** Flygon has joined #openttd
00:23:52 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #13289: Feature: Draw infinite water when all borders are water https://github.com/OpenTTD/OpenTTD/pull/13289
00:24:11 <talltyler> Build before push, etc
00:27:26 <peter1138> Overrated.
00:33:59 <peter1138> Unpack OpenGFX End-of-central-directory signature not found. Either this file is not a zipfile, or it constitutes one disk of a multi-part archive. In the latter case the central directory and zipfile comment will be found on the last disk(s) of this archive.
00:34:03 <peter1138> Nice.
00:34:41 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13481: Getstring querywindow https://github.com/OpenTTD/OpenTTD/pull/13481
00:43:16 <peter1138> Oops, PR title...
00:51:21 <talltyler> Heheh
01:15:52 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13482: Codechange: Disentangle news window style from news flags. https://github.com/OpenTTD/OpenTTD/pull/13482
01:22:52 <peter1138> Probably sleep time.
03:06:25 *** Wormnest has joined #openttd
03:41:46 *** Wormnest has quit IRC (Quit: Leaving)
03:55:43 *** D-HUND has joined #openttd
03:59:04 *** debdog has quit IRC (Ping timeout: 480 seconds)
04:44:28 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/9d451d6350c64c530969d08aba4942605116d3f1
04:44:29 <DorpsGek> - Update: Translations from eints (by translators)
05:06:08 *** keikoz has joined #openttd
05:10:20 <ahyangyi> peter1138: Hmm, does that mean decoupling "map" and "playable area" 😛
05:11:10 <ahyangyi> So you can have, say, a map of Europe and only Belgium is the playable area.
05:11:58 <ahyangyi> ( I don't remember the shape of Belgium but pretty sure it's not rectangular )
06:09:13 *** keikoz has quit IRC (Ping timeout: 480 seconds)
06:33:52 *** D-HUND is now known as debdog
06:41:31 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13479: Codechange: Add GetString() method that accepts parameters directly instead of via SetDParam(). https://github.com/OpenTTD/OpenTTD/pull/13479#pullrequestreview-2600920100
06:43:16 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13480: Codechange: Pass preformatted string when updating sign positions. https://github.com/OpenTTD/OpenTTD/pull/13480#pullrequestreview-2600922326
06:54:31 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13481: Codechange: Pass preformatted raw string to editable query window. https://github.com/OpenTTD/OpenTTD/pull/13481#pullrequestreview-2600933505
06:56:42 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13482: Codechange: Disentangle news window style from news flags. https://github.com/OpenTTD/OpenTTD/pull/13482#pullrequestreview-2600939731
07:02:16 *** keikoz has joined #openttd
07:14:46 <LordAro> busy morning
07:18:42 *** HerzogDeXtEr has joined #openttd
07:30:26 <andythenorth> ok
07:30:58 <andythenorth> ModelDef (base model type + variant config) -> ModelVariantFactory -> ModelVariant(s)
07:31:08 <LordAro> andythenorth: have you rewritten Horse in Rust yet?
07:31:17 <andythenorth> no but....
07:31:36 <andythenorth> last weekend, GPT rewrote a 10k LOC python module for me
07:31:41 <andythenorth> using AST and stuff
07:32:01 <andythenorth> "for me" -> I did most of the work
07:32:26 <LordAro> ofc
07:32:44 <andythenorth> suspect a python -> rust port could be automated
07:33:14 <andythenorth> hmm wonder if nml -> rust could be automated
07:48:50 <ahyangyi> grf-py -> rust might be more straightforward?
07:50:04 <ahyangyi> Perhaps I should adopt it to make building faster
07:50:37 <ahyangyi> and gorender -> rustrender
08:14:03 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13482: Codechange: Disentangle news window style from news flags. https://github.com/OpenTTD/OpenTTD/pull/13482#pullrequestreview-2601071118
09:02:02 <peter1138> Pom te pom.
09:02:26 <pickpacket> I don't know if you've all noticed, but just in case: it's FRIDAY!
09:17:08 <peter1138> Yes, that means I have another Teams call in a moment.
09:55:40 <johnfranklin> The proportion of UK people that can recite and fluently read “llanfairpwllgwyngyll…”?
09:56:52 <reldred> welsh isn't real, it's a myth made up to scare tourists
10:13:43 <peter1138> johnfranklin, about 0%.
10:23:43 <belajalilija> Barely anyone in Wales speaks welsh
10:24:19 <belajalilija> Nevermind the UK as a whole
10:24:40 <peter1138> Doubling down on bridge-burning, whoops.
10:25:21 <belajalilija> Most people say Llandudno as if the Ll is said like English L and not like C or whatever
10:26:33 <peter1138> Nah, everyone knows how that is pronounced, they'll just assume it's spelled Clandudno.
10:26:51 <belajalilija> Different experiences i guess
10:28:15 <belajalilija> Even within England there’s place names idk how to pronounce
10:28:32 <belajalilija> But I’m convinced that’s just the locals being dickheads
10:28:38 <peter1138> Maybe. I think Ll is mostly known, but we definitely get stuck on w-vowel, and then the later ll combos, no idea.
10:29:19 <peter1138> Cholmondeley.
10:29:54 <belajalilija> Like how in NYC there’s a street called like Housten Street and they don’t say it like Housten Texas
10:30:34 <peter1138> Because that's Houston.
10:31:19 <belajalilija> My spelling was wrong but my point still stands
10:33:24 <belajalilija> I maintain that English is an awful language when it comes to spelling and we need a major reform
10:33:41 <reldred> skill issue
10:33:48 <belajalilija> Indeed
11:02:22 <LordAro> helps us distinguish the Americans
11:05:18 *** audunm has joined #openttd
11:05:18 <audunm> Anyone know how the max cargo limit for a station is calculated? I've been told one exists.
11:07:29 <LordAro> peter1138: also https://www.youtube.com/watch?v=uYNzqgU7na4
11:09:09 <belajalilija> LordAro: The Americans should have their own spelling tbh and aligns better with their pronunciation
11:10:34 <belajalilija> I’m for all languages being phonetic
11:24:59 <ahyangyi> peter1138: Cwm is pronunceable though. I guess the problem with Llanfairpwllgwyngyllgogerychwyrndrobwllllantysiliogogogoch is: nothing is pronunceable at this length.
11:25:42 <ahyangyi> The other famously long location name, Taumatawhakatangihangakoauauotamateaturipukakapikimaungahoronukupokaiwhenuakitanatahu, contains no "difficult sounds" but I don't try to pronounce it either 😛
11:28:14 <_jgr_> Locals don't actually use the full name, Llanfair PG or just Llanfair is not hard to pronounce
11:30:21 <ahyangyi> ^
11:46:24 <gwyd4016> Godmanchester
11:46:36 <gwyd4016> Loughborough
11:46:46 <gwyd4016> Worcestershire
11:47:16 <gwyd4016> Billericay - not hard just fun to say tbh
11:52:32 <belajalilija> Scunthorpe
11:53:23 <belajalilija> That one is mostly hard because it reminds you it exists
12:00:56 <xarick> it looks like it's going to rain this weekend
12:18:04 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1337396965520048128/image.png?ex=67a74b7c&is=67a5f9fc&hm=89b13f2faaf7669c7e07a7c63257083f2da28f9c2bc8a130a1dec536e00b45f3&
12:18:04 <xarick> dear probably peter1138[d] shaded vehicle list windows are costing performance
12:18:16 <xarick> fix ploz
12:26:40 <peter1138> I've got more than enough side quests.
12:27:00 <xarick> okay
12:27:32 <xarick> AAAHogEx is commiting suicide of some kind... why
12:27:57 <xarick> would it be related to frozen time
12:28:00 <xarick> i dunno
12:29:38 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13482: Codechange: Disentangle news window style from news flags. https://github.com/OpenTTD/OpenTTD/pull/13482
12:29:41 <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #13482: Codechange: Disentangle news window style from news flags. https://github.com/OpenTTD/OpenTTD/pull/13482#pullrequestreview-2600939731
12:30:10 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13478: Codechange: Use EnumBitSet for industry-related enum masks. https://github.com/OpenTTD/OpenTTD/pull/13478
12:30:38 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13479: Codechange: Add GetString() method that accepts parameters directly instead of via SetDParam(). https://github.com/OpenTTD/OpenTTD/pull/13479
12:30:52 <xarick> transporting valuables by air
12:30:59 <xarick> interesting choice
12:31:22 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13480: Codechange: Pass preformatted string when updating sign positions. https://github.com/OpenTTD/OpenTTD/pull/13480
12:32:03 <xarick> the "recent" changes to the profit formula doesn't hit well with some AIs, I just noticed
12:34:05 <peter1138> Stop doing everything with 4k x 4k maps.
12:40:23 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13482: Codechange: Disentangle news window style from news flags. https://github.com/OpenTTD/OpenTTD/pull/13482#pullrequestreview-2601633114
12:42:00 *** Markk has joined #openttd
12:43:17 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13481: Codechange: Pass preformatted raw string to editable query window. https://github.com/OpenTTD/OpenTTD/pull/13481#pullrequestreview-2601638767
12:43:51 <peter1138> Ah yes, if it's a string from NewGRF it must go past STR_JUST_RAW_SRTING to get properly formatted.
12:44:43 *** Markk has quit IRC ()
12:45:13 <peter1138> EncodedStrings already have protection from being directly used as strings (although strings set via GS don't have this protection). Maybe strings from NewGRF should be wrapped to prevent accidents.
12:45:30 <peter1138> E_TOO_MANY_SIDEQUESTS
12:48:55 <_glx_> xarick: My guess is it's doing useless stuff
12:50:52 *** kuka_lie has joined #openttd
12:51:38 <peter1138> It builds and sorts the vehicle list OnPaint.
12:51:47 <peter1138> This was meant be a lazy way to defer updates.
12:53:12 <_glx_> Yeah useless when shaded
12:55:35 <peter1138> I reckon xarick coukd figure this one out.
12:56:09 <peter1138> They'd ve best placed to confirm if it improves it.
13:10:43 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13482: Codechange: Disentangle news window style from news flags. https://github.com/OpenTTD/OpenTTD/pull/13482
13:13:35 *** nielsm has joined #openttd
13:19:05 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13480: Codechange: Pass preformatted string when updating sign positions. https://github.com/OpenTTD/OpenTTD/pull/13480
13:33:08 *** nielsm has quit IRC (Ping timeout: 480 seconds)
13:36:35 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13481: Codechange: Pass preformatted raw string to editable query window. https://github.com/OpenTTD/OpenTTD/pull/13481
13:59:55 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13481: Codechange: Pass preformatted raw string to editable query window. https://github.com/OpenTTD/OpenTTD/pull/13481#pullrequestreview-2601809710
14:04:44 <andythenorth> peter1138: do a few more, you might get an overflow, then it self limits
14:11:52 *** Artea has quit IRC ()
14:23:44 <peter1138> Hmm, the CmdTownSetAText and CmdIndustrySetText commands...
14:25:35 <peter1138> -A
14:25:45 <peter1138> Ah, yes, there are loads of other commands that accept std::string.
14:25:52 <xarick> framerate_gui was changed again
14:26:00 *** Artea has joined #openttd
14:27:02 <peter1138> I wonder if it makes sense to have the commands that are intended to store a GS-encoded string use a signature that isn't std::string.
14:28:16 <peter1138> Goals etc.
14:29:21 <_glx_> any raw string can be transformed into encoded
14:30:22 <peter1138> Yes, but I'm wondering if it should be stronger. Like `company->name` should not ever be an encoded string.
14:30:24 <_glx_> but FormatString happily accepts encoded and non encoded strings anyway
14:31:15 <peter1138> My "issue" is that with introducing `EncodedString`, it is obvious when things are storing that.
14:31:16 <_glx_> should not be too hard to validate it doesn't start with SCC_ENCODED
14:31:27 <peter1138> But there are also encoded strings from GS that are stored in std::string, and this is not obvious.
14:33:18 <_glx_> a command flag to allow encoded string, and a check for SCC_ENCODED
14:33:35 <_glx_> then it can return an error
14:33:45 <peter1138> That's all very run-timey.
14:33:50 <peter1138> I'm thinking compile-timey.
14:34:00 <peter1138> Or code-time either.
14:34:21 <peter1138> So you can look at the signature of a function, or a member, and know that it is an encoded string.
14:37:18 <_glx_> at least scripts use GetDecodedText() and GetEncodedText(), so a non std::string type for encoded should be possible
14:38:11 <_glx_> a simple wrapper around std::string
14:52:17 <_glx_> anyway since it's received from network the only safe way is runtime validation
14:55:03 <peter1138> I'm not looking at removing that validation.
15:04:15 <xarick> too noob for NWidgets
15:07:07 <xarick> it's probably simple, just copy paste <https://github.com/OpenTTD/OpenTTD/commit/8b00661b2292ace4b34ae807f6bc6aa80b678636>
15:09:07 <peter1138> What are you trying to do?
15:09:26 <xarick> show a column of Max OpCodes
15:09:37 <xarick> depending on scripts being available
15:09:43 <xarick> present*
15:10:32 <xarick> scripts already use memory
15:13:50 <xarick> i'd like ALLOCSIZE to be the rightmost column while at it
15:14:22 <peter1138> My change there just removes the optional-ness of that widget. But you can just add it back for just your widget if you need to.
15:14:49 <peter1138> Seems fairly trivial tbh.
15:21:53 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1337443225644040212/image.png?ex=67a77691&is=67a62511&hm=057623e23295cb4283d3e866029e06e07e252837fd88992d62f114ae717a4c7a&
15:21:53 <xarick> almost
15:24:16 *** merni has quit IRC (Quit: User went offline on Discord a while ago)
15:47:22 <xarick> oh, because of this: size = GetStringBoundingBox(STR_FRAMERATE_CURRENT + (widget - WID_FRW_TIMES_CURRENT));
15:48:27 <xarick> or maybe not, I'm unsure
15:49:03 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1337450061768036372/image.png?ex=67a77cef&is=67a62b6f&hm=ca527d656c1dd971733bb083bbedca007896f505d158916b14490d8ada401c24&
15:50:39 <_glx_> it's the columns' SetFill() and SetResize() most likely
15:51:46 <xarick> picking a string based on widget position, such evil
15:52:07 <xarick> so i need to see what string is this actually calling
15:54:36 <xarick> STR_FRAMERATE_DATA_POINTS
15:55:48 <xarick> > {BLACK}Data based on {COMMA} measurements
15:55:53 <xarick> of course it's large
15:56:45 <_glx_> is your string inserted in the correct place ?
15:57:29 <xarick> it's running UpdateWidgetSize but getting the size of the wrong string
15:57:58 <xarick> because I placed the widgets inbetween ALLOCSIZE and TIMES_AVERAGE
15:59:03 <_glx_> place the strings between STR_FRAMERATE_AVERAGE and STR_FRAMERATE_MEMORYUSE
16:00:25 <xarick> I only have 1 string STR_FRAMERATE_OPCODES :{WHITE}Max Ops
16:00:34 <xarick> but 2 widgets
16:00:43 <xarick> because it's a NWID_SELECTION
16:01:28 <xarick> it might work´~
16:01:31 <xarick> let's test
16:01:32 <peter1138> Put WID_FRW_SEL_OPCODES outside that list.
16:02:08 <peter1138> If you look at the original list, SEL_MEMORY was after ALLOCSIZE, even though in the tree it's before it.
16:04:16 <_glx_> making it non optional works too 🙂
16:05:32 <_glx_> but WidgetID order must match StringID order
16:06:45 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1337454514092900384/image.png?ex=67a78114&is=67a62f94&hm=6c187cc0b5f1cdd96fcd2a95d59c69bb43a77e1afadb5518343076b5e5d9d644&
16:06:45 <xarick> nice, i did it
16:07:45 <peter1138> What's the relevance of 500 ops though.
16:07:48 <xarick> let me try no strings
16:07:52 <xarick> oops, no scripts
16:07:58 <andythenorth> 👀
16:07:59 <andythenorth> https://github.com/chriskiehl/Gooey
16:08:03 <andythenorth> Horse maker?
16:08:32 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1337454964875726960/image.png?ex=67a78180&is=67a63000&hm=4b569da59e29eb95ace3c8545dc930c28e89fb6b12fc6fc7b7beb6a16fa18a5f&
16:08:39 <xarick> nice, everything works
16:09:20 <xarick> in debug mode, max ops is usually low
16:09:52 <peter1138> Like why are most AIs using 500 ops, some more, but none less?
16:10:11 <xarick> 500 is the lowest possible value for opcodes
16:10:49 <xarick> max is 250000
16:11:03 <peter1138> I understand max opcodes, but not min opcodes.
16:11:32 *** toktik has quit IRC (Remote host closed the connection)
16:11:56 *** toktik has joined #openttd
16:12:23 <xarick> I'll make a video
16:12:31 <xarick> let me build a release build
16:12:33 <peter1138> No thank you.
16:12:47 <xarick> :^-
16:13:02 <_glx_> yeah minimal limit is weird
16:13:49 <_glx_> a script doing only sleep will be at less than 10 always
16:17:42 <_glx_> or the window will just tell a script reached the limit once, even if it usually uses less than that
16:18:29 <peter1138> Overheads of setting up the VM each tick...? No idea :)
16:18:48 <_glx_> doesn't feel like a useful stat in current screenshots 🙂
16:22:47 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1337458549005225994/2025-02-07_16-19-20.mp4?ex=67a784d6&is=67a63356&hm=3b49e75012ae246149bfd034d6e63873685b39337eb6500a9357332f97ad16c5&
16:24:23 <xarick> it's not a perfect system 😦 spiking tends to ruin it
16:24:48 <_glx_> as said, it just tells a script reached max limit at some point, while the average usage will be more useful
16:26:52 *** Wormnest has joined #openttd
16:26:53 <peter1138> Oh I see, so it's literally the max ops of all time.
16:27:00 <peter1138> Yeah, that's not very useful.
16:27:03 <_glx_> yeah
16:27:45 <xarick> tries to guess the impact in performance and lowers the max ops allowed each frame
16:27:55 <xarick> if it's impactful
16:28:11 <xarick> or raises the max ops if it hasn't been impacting
16:29:10 <xarick> makes uses of the 512 frame time points collected by the framerate
16:29:55 <_glx_> though the only useful info from it is which script it's better to not run 🙂
16:32:17 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13483: Codechange: add and use GetDepotDestinationIndex map accessor https://github.com/OpenTTD/OpenTTD/pull/13483
16:33:07 <_glx_> we can see wormAI reached max opcode, but in reality it almost never use any opcodes
16:35:32 <_glx_> while ludi after fix never reach max, but actually consumes more cpu than others 🙂
16:37:51 <peter1138> Yeah, max ops isn't all that useful really. You already have the time.
16:39:27 <peter1138> I think I should get the rest of the EncodedString stuff done before looking at changing command signatures.
16:39:35 <peter1138> Leave that side-quest for later :-)
16:39:52 <_glx_> makes sense to wait indeed 🙂
16:40:09 <peter1138> If the rest of my changes are implemented then it becomes a lot easier to pass the correct things around.
16:48:08 <xarick> it means my maths suck
16:48:31 <xarick> an ideal system would make it fair to all
16:49:32 <xarick> wormai is allowed 250k ops because it has been "performing well", aka doing nothing
16:50:07 <peter1138> You can't force scripts to use ops if they don't want to :)
16:57:51 <DorpsGek> [OpenTTD/OpenGFX] jayaddison commented on issue #94: gimpscript: GIMP3 compatibility problem(s) https://github.com/OpenTTD/OpenGFX/issues/94
17:02:50 <peter1138> o/~ Are you waiting for the street car?
17:02:52 <xarick> how does savegame conversion works for settings now? I remember I need not do anything for old savegames
17:03:10 <xarick> but forgot the details
17:03:57 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13481: Codechange: Pass preformatted raw string to editable query window. https://github.com/OpenTTD/OpenTTD/pull/13481
17:06:28 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1337469543349620777/image.png?ex=67a78f14&is=67a63d94&hm=71acc75f091ea7796df5e5756f613a93e6657c4c58684fa21d8b204154a80e9e&
17:06:55 <peter1138> Gotta love repetitions :D
17:11:01 <DorpsGek> [OpenTTD/OpenGFX] Wormnest commented on issue #94: gimpscript: GIMP3 compatibility problem(s) https://github.com/OpenTTD/OpenGFX/issues/94
17:14:26 <Wormnest> IIRC WormAI (without changing settings) does indeed try to not do too much all at once.
17:26:09 <peter1138> Hmm.
17:33:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13484: Codechange: Use preformatted strings for slider marks. https://github.com/OpenTTD/OpenTTD/pull/13484
17:34:36 *** Flygon has quit IRC (Read error: Connection reset by peer)
17:39:26 <DorpsGek> [OpenTTD/OpenGFX] jayaddison opened pull request #95: Makefile: update to GIMP3-compatible command-line https://github.com/OpenTTD/OpenGFX/pull/95
17:40:51 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13484: Codechange: Use preformatted strings for slider marks. https://github.com/OpenTTD/OpenTTD/pull/13484#pullrequestreview-2602407963
17:45:51 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13485: Codechange: use IndustryID instead of int https://github.com/OpenTTD/OpenTTD/pull/13485
17:49:59 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13485: Codechange: use IndustryID instead of int https://github.com/OpenTTD/OpenTTD/pull/13485#pullrequestreview-2602428864
17:59:58 *** D-HUND has joined #openttd
18:01:09 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13486: Codechange: use TownID instead of uint https://github.com/OpenTTD/OpenTTD/pull/13486
18:01:41 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13486: Codechange: use TownID instead of uint https://github.com/OpenTTD/OpenTTD/pull/13486#pullrequestreview-2602453071
18:04:15 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13487: Codechange: Use local parameters for formatting settings values. https://github.com/OpenTTD/OpenTTD/pull/13487
18:14:01 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13488: Codechange: Detemplatise uint64_t version of GetNextParameters(). https://github.com/OpenTTD/OpenTTD/pull/13488
18:14:57 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13484: Codechange: Use preformatted strings for slider marks. https://github.com/OpenTTD/OpenTTD/pull/13484
18:17:13 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13488: Codechange: Detemplatise uint64_t version of GetNextParameters(). https://github.com/OpenTTD/OpenTTD/pull/13488#pullrequestreview-2602489086
18:22:27 <xarick> boolean logic
18:25:46 <DorpsGek> [OpenTTD/OpenGFX] jayaddison updated pull request #95: Makefile: update to GIMP3-compatible command-line https://github.com/OpenTTD/OpenGFX/pull/95
18:26:18 * andythenorth reading OO things
18:26:38 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13485: Codechange: use IndustryID instead of int https://github.com/OpenTTD/OpenTTD/pull/13485
18:26:52 <xarick> i'm trying to rebase something, but there used to be 3 planes
18:26:57 <andythenorth> glad I only use scripting languages where I don’t have to know about OO
18:27:00 <xarick> now there's only two
18:27:46 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1337490003986743376/image.png?ex=67a7a222&is=67a650a2&hm=7e3a00e86ca6fed35ef6b7f3074e8bc5ff164042385f749c17f1b57a1290b227&
18:28:12 <xarick> i want to show the "join" button in single player if I am a spectator
18:28:35 <xarick> it's a branch where i allow spectator mode in single player
18:29:10 <xarick> only show the join button for human companies
18:29:17 <xarick> don't show for ais
18:41:23 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13486: Codechange: use TownID instead of uint https://github.com/OpenTTD/OpenTTD/pull/13486
18:44:46 <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #13487: Codechange: Use local parameters for formatting settings values. https://github.com/OpenTTD/OpenTTD/pull/13487#pullrequestreview-2602540656
18:44:57 <peter1138> Hrmm.
18:45:10 <peter1138> Oh.
18:45:14 <peter1138> Well, that's
18:45:17 <peter1138> the point :)
18:48:44 *** tokai has joined #openttd
18:48:44 *** ChanServ sets mode: +v tokai
18:53:22 <andythenorth> is it lunch?
18:53:43 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13489: News flags https://github.com/OpenTTD/OpenTTD/pull/13489
18:54:45 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13488: Codechange: Detemplatise uint64_t version of GetNextParameters(). https://github.com/OpenTTD/OpenTTD/pull/13488
18:55:44 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
18:59:03 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13489: Codechange: Use EnumBitSet and enum class for news related enums. https://github.com/OpenTTD/OpenTTD/pull/13489#pullrequestreview-2602567129
19:01:16 *** gelignite has joined #openttd
19:03:32 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13489: Codechange: Use EnumBitSet and enum class for news related enums. https://github.com/OpenTTD/OpenTTD/pull/13489#pullrequestreview-2602581423
19:22:35 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13489: Codechange: Use EnumBitSet and enum class for news related enums. https://github.com/OpenTTD/OpenTTD/pull/13489#pullrequestreview-2602631737
19:23:32 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13489: Codechange: Use EnumBitSet and enum class for news related enums. https://github.com/OpenTTD/OpenTTD/pull/13489#pullrequestreview-2602634091
19:35:07 *** Wolf01 has joined #openttd
19:36:56 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13489: Codechange: Use EnumBitSet and enum class for news related enums. https://github.com/OpenTTD/OpenTTD/pull/13489
19:40:15 <xarick> so much changes
19:40:56 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13402: Codechange: make pool item indices strongly typed https://github.com/OpenTTD/OpenTTD/pull/13402
19:49:47 <Rubidium> dozens of conflicts, conflicts for me... ;(
19:50:15 <xarick> CoPilot died
19:52:22 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1337511295422959672/image.png?ex=67a7b5f6&is=67a66476&hm=c7ec13aa3b17f99ae11914fc0c47dd3575f570dc92962e733636b60ad6eae28c&
20:08:09 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1337515266980188190/image.png?ex=67a7b9a9&is=67a66829&hm=8f19482df00dede9ddf3b1bcd452e0521e390d4b991f404f4695d1b2e6ffb808&
20:08:09 <andythenorth> lol reading about a specific neurodiversity
20:08:15 <andythenorth> (the one I have)
20:08:48 <belajalilija> andythenorth: asd and aspd into one
20:09:35 <andythenorth> it's not those 😛
20:10:58 <belajalilija> what is it?
20:11:11 <belajalilija> i didnt imagine that it was one of them, just that it is like both combined
20:13:19 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1337516567688384574/image.png?ex=67a7badf&is=67a6695f&hm=2841a4c3037c47951a02819da7cf63d1766dbf7ef156c57e76dd751e6fa0cdf4&
20:13:20 <andythenorth> it's the red one
20:13:38 <andythenorth> relates to prefrontal cortex development
20:14:21 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1337516826619412571/image.png?ex=67a7bb1d&is=67a6699d&hm=5ce8e3f8cacd664d9b1f8257a90abc1cd6f27b901fe14618689e788123272d56&
20:14:21 <andythenorth> this overlap is why I have an unusual number of autistic friends
20:14:43 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1337516919301083217/image.png?ex=67a7bb33&is=67a669b3&hm=9a26492d09a8102c8a14113f5e1625e4fa8bed4da3a3f258cccb470dc17e7659&
20:14:43 <andythenorth> 'skip thinking' is why I'm fucking terrible company for them sometimes
20:15:14 <peter1138> Rubidium, oops
20:15:55 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13487: Codechange: Use local parameters for formatting settings values. https://github.com/OpenTTD/OpenTTD/pull/13487#pullrequestreview-2602744870
20:16:38 <peter1138> I find VS Code's conflict tools are pretty amazing, although they occasionally go doolally.
20:18:08 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13487: Codechange: Use local parameters for formatting settings values. https://github.com/OpenTTD/OpenTTD/pull/13487
20:18:40 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13402: Codechange: make pool item indices strongly typed https://github.com/OpenTTD/OpenTTD/pull/13402
20:20:23 <belajalilija> https://cdn.discordapp.com/attachments/1008473233844097104/1337518345372831795/image.png?ex=67a7bc87&is=67a66b07&hm=5d0b4279c8681865abea84376a7d14ddb10c55de84a770f082eb269d735643d8&
20:20:25 <belajalilija> me
20:22:05 <belajalilija> im diagnosed with aspergers, i am told i am diagnosed with adhd and ocd but the nhs seems unaware of that so idk what to believe
20:25:18 <andythenorth> I've got friends involved in diagnostics, the symptom overlaps are significant
20:25:32 <andythenorth> sometimes it's more important to use exclusion factors, because of overlaps
20:25:50 <andythenorth> but the neat label boundaries don't map onto lots of real people
20:25:56 <belajalilija> i would try and see if i can get diagnosed with more stuff but the waiting lists are insane
20:25:57 <andythenorth> [telling you things you're living, sorry]
20:26:03 <belajalilija> it would help my PIP application though
20:26:23 <andythenorth> 2 years waiting list, of £2500 for assessment?
20:26:36 <belajalilija> something like that
20:26:45 <belajalilija> i think my friend said 40 weeks
20:26:50 <belajalilija> for ADHD
20:27:05 <andythenorth> my brother waited about a year for ADHD
20:27:35 <belajalilija> i am 95% sure i have a paper somewhere saying i have ADHD and OCD but it is in storage somewhere because i had to move out suddenly a few years ago and have never intended to settle here but i seem to have
20:28:06 <belajalilija> i applied for pip in like sep 2024
20:28:16 <andythenorth> "I have lost my ADHD diagnosis -> ADHD proof" 😛
20:28:34 <belajalilija> they've rejected it many times and we're at the court state, which is where many appeals are meant to succeed
20:28:47 <belajalilija> andythenorth: pretty much lmao
20:28:57 <belajalilija> job centre people are doing this audit thing recently
20:29:30 <belajalilija> they told me on the 14th that i needed to get them both 1 proof of ID and 2 4 months of bank statements by the 28th
20:29:51 <belajalilija> i got the ID to them by around the turn of the month
20:30:05 <belajalilija> and i got the bank statements to them on the 5th
20:30:30 <belajalilija> because i went to the bank in whitby because i dont understand online banking, i was hoping they'd print me off statements so i could mail them to the UC people
20:30:45 <belajalilija> but instead they explained online banking to me, which works i gues
20:31:15 <belajalilija> it turns out ive been doing online banking this whole time, i just didnt know how to do anything other than check my balance
20:31:36 <andythenorth> think we derailed the channel sorry 🙂
20:31:44 <belajalilija> oopsie poopsie
20:32:00 <belajalilija> ill use this as proofwhen i go and get diagnosed :kek:
20:41:07 <peter1138> Hmm.
20:42:54 <andythenorth> refactoring then
20:43:23 <peter1138> Rubidium, is there a relationship between 13402 and 13416?
20:43:45 <peter1138> (e.g. dependencies or exclusiveness)
20:45:45 <Rubidium> yes. 13416 is needed to reasonably do 13402 on the remaining PoolIDs
20:47:33 <Rubidium> though with 13483 I don't need to put DepotID in 13416, and DepotID could be added to 13402 (or a follow-up PR)
20:50:21 <xarick> dang, I got distracted by youtube again
20:52:03 <andythenorth> naptime?
21:03:08 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13472: Codechange: put SourceType and SourceID into Source struct https://github.com/OpenTTD/OpenTTD/pull/13472
21:05:25 <Rubidium> peter1138: https://github.com/rubidium42/OpenTTD/tree/enum-ids-on-top-of does 13402, then 13416, then a few others to finally undo the work of 13416 to make everything PoolID (except CompanyID which I haven't touched yet)
21:08:53 <Rubidium> that starts to get messy later on, and definitely needs to be cleaned up... but some of that cleaning will be done by some of the other open PRs; I saw some issue, sort-of-fixed it, ported it to master, cleaned it up and made a PR. But alas, not going to clean them up completely until the other bits start to land.
21:17:08 <xarick> have you seen j0anjosep 's #10691 about airports separation of depot and station
21:20:56 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13472: Codechange: put SourceType and SourceID into Source struct https://github.com/OpenTTD/OpenTTD/pull/13472#pullrequestreview-2602871976
21:21:29 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13416: Codechange: make some types used as ID in pools enums https://github.com/OpenTTD/OpenTTD/pull/13416
21:26:34 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13472: Codechange: put SourceType and SourceID into Source struct https://github.com/OpenTTD/OpenTTD/pull/13472#pullrequestreview-2602886074
21:26:55 <peter1138> Well.
21:27:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13472: Codechange: put SourceType and SourceID into Source struct https://github.com/OpenTTD/OpenTTD/pull/13472
21:27:28 <peter1138> Somebody filled up the PRs again.
21:29:27 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13308: Codechange: use C++ constructs over MallocT/free https://github.com/OpenTTD/OpenTTD/pull/13308#pullrequestreview-2602891491
21:29:54 <peter1138> Doesn't look like LordAro found a solution there.
21:32:40 <andythenorth> pff, I want to do Horse compile, but much asleep 😛 woke up at 4am
21:32:45 <andythenorth> 'skill issue'
21:33:49 <LordAro> peter1138: alas.
21:34:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13317: Codechange: remove manual memory management in old string loading https://github.com/OpenTTD/OpenTTD/pull/13317#pullrequestreview-2602899100
21:34:52 <xarick> so much code has changed in 2 years
21:35:08 <xarick> im having trouble rebasing my old trash
21:35:35 <peter1138> Sometimes it's better to manually rewrite it.
21:36:33 <LordAro> sometimes
21:36:54 <peter1138> NewGRF stations had so many rewrites :-)
21:38:08 <andythenorth> would 1 more hurt? 😛
21:38:21 <peter1138> It doesn't need one.
21:38:31 <andythenorth> neither does Horse
21:38:38 <andythenorth> I'm doing it for entertainment
21:38:40 <peter1138> Well then.
21:38:51 <LordAro> that's a relief
21:46:24 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1337539990909091982/image.png?ex=67a7d0b0&is=67a67f30&hm=158ec1e110de871c2f61037bdd6af32d674985528cb8ed7c28c2773fd5c91dc3&
21:46:24 <xarick> the old AdmiralAI has a golden opportunity to overtake AAAHogEx
21:47:09 <xarick> AdmiralAI purple with 3651 aircraft vs AAAHogEx with 4982 aircraft
21:47:58 <xarick> better profit average per aircraft for Admiral, so with enough time, he can overtake the big AAA
21:49:07 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13308: Codechange: use C++ constructs over MallocT/free https://github.com/OpenTTD/OpenTTD/pull/13308
21:49:21 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13317: Codechange: remove manual memory management in old string loading https://github.com/OpenTTD/OpenTTD/pull/13317
21:55:51 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13477: Codechange: Use EnumBitSet for IndustryControlFlags. https://github.com/OpenTTD/OpenTTD/pull/13477#pullrequestreview-2602931795
22:02:02 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13477: Codechange: Use EnumBitSet for IndustryControlFlags. https://github.com/OpenTTD/OpenTTD/pull/13477
22:23:28 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
22:35:11 <xarick> nice to see SuperSimpleAI getting strong
22:35:49 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13490: Codechange: Use EnumBitSet for EndSegmentReasons. https://github.com/OpenTTD/OpenTTD/pull/13490
22:39:58 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13285: Codechange: Remove global string parameters. https://github.com/OpenTTD/OpenTTD/pull/13285
22:40:29 <peter1138> Getting shorter :D
22:40:52 <peter1138> Still more to split off of course.
22:48:47 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1337555689966538772/image.png?ex=67a7df4f&is=67a68dcf&hm=210951133cf3d51314c4d662ef996e9495e8af3baf801ed5acb0f987697ef8e0&
22:48:47 <xarick> AdmiralAI was able to overtake AAAHogEx for 6 "minutes"
22:54:37 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13490: Codechange: Use EnumBitSet for EndSegmentReasons. https://github.com/OpenTTD/OpenTTD/pull/13490#pullrequestreview-2603014681
22:56:19 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:56:24 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13491: Codechange: Use EnumBitSet for CargoClasses. https://github.com/OpenTTD/OpenTTD/pull/13491
22:58:29 *** kuka_lie has quit IRC (Quit: Lost terminal)
23:19:05 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13491: Codechange: Use EnumBitSet for CargoClasses. https://github.com/OpenTTD/OpenTTD/pull/13491#pullrequestreview-2603052000
23:24:17 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13491: Codechange: Use EnumBitSet for CargoClasses. https://github.com/OpenTTD/OpenTTD/pull/13491
23:32:41 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13492: Codechange: remove synthesized operators https://github.com/OpenTTD/OpenTTD/pull/13492
23:39:13 <LordAro> nice
23:39:37 <peter1138> Hmm, most things I read say that free functions are a better design pattern.
23:39:53 <peter1138> (Rather than class methods)
23:42:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13492: Codechange: remove synthesized operators https://github.com/OpenTTD/OpenTTD/pull/13492#pullrequestreview-2603085342
23:43:22 <peter1138> Hmm,
23:43:37 <Rubidium> you mean like std::begin(x) over x.begin(), right?
23:44:15 <peter1138> Kinda, but in this case...
23:44:18 <peter1138> `bool operator==(const MultiMapIterator<Tmap_iter1, Tlist_iter1, Tkey, Tvalue1, Tcompare> &iter1, const MultiMapIterator<Tmap_iter2, Tlist_iter2, Tkey, Tvalue2, Tcompare> &iter2)`
23:44:26 <peter1138> vs
23:44:27 <peter1138> `bool operator==(const MultiMapIterator<Tmap_iter_other, Tlist_iter_other, Tkey, Tvalue_other, Tcompare> &other) const`
23:44:42 <peter1138> I dunno.
23:45:29 <peter1138> But.
23:45:38 <peter1138> It's kinda weird that there are multiple ways to do it.
23:46:06 <peter1138> `operator <=>` was a nice addition thougH :)
23:46:13 <Rubidium> don't forget `bool operator==(const A&, const B&)` and `bool operator==(const B&, const A&)` are required, over `struct A { bool operator==(const B&) const }`.
23:51:05 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13492: Codechange: remove synthesized operators https://github.com/OpenTTD/OpenTTD/pull/13492#pullrequestreview-2603091304
23:53:01 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13492: Codechange: remove synthesized operators https://github.com/OpenTTD/OpenTTD/pull/13492#pullrequestreview-2603092354
23:53:26 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13490: Codechange: Use EnumBitSet for EndSegmentReasons. https://github.com/OpenTTD/OpenTTD/pull/13490
continue to next day ⏵
