IRC Logs | #openttd | 2025-02-02

00:04:51 <_glx_> (ah and it was actually explicitely mentioned in limitations)

00:05:07 <_glx_> well with my PR it's used 🙂

00:07:26 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13432: Fix #13431: Press Ctrl to build diagonal canals in game mode https://github.com/OpenTTD/OpenTTD/pull/13432#pullrequestreview-2588432984

00:36:31 *** kuka_lie has quit IRC (Remote host closed the connection)

00:38:48 <DorpsGek> [OpenTTD/OpenTTD] chris3k updated pull request #13432: Fix #13431: Press Ctrl to build diagonal canals in game mode https://github.com/OpenTTD/OpenTTD/pull/13432

00:39:38 <DorpsGek> [OpenTTD/OpenTTD] chris3k commented on pull request #13432: Fix #13431: Press Ctrl to build diagonal canals in game mode https://github.com/OpenTTD/OpenTTD/pull/13432#pullrequestreview-2588437005

00:41:10 <DorpsGek> [OpenTTD/OpenTTD] chris3k commented on pull request #13432: Fix #13431: Press Ctrl to build diagonal canals in game mode https://github.com/OpenTTD/OpenTTD/pull/13432#issuecomment-2629181313

00:55:28 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13432: Fix #13431: Press Ctrl to build diagonal canals in game mode https://github.com/OpenTTD/OpenTTD/pull/13432#pullrequestreview-2588438356

00:58:11 <DorpsGek> [OpenTTD/OpenTTD] chris3k updated pull request #13432: Fix #13431: Press Ctrl to build diagonal canals in game mode https://github.com/OpenTTD/OpenTTD/pull/13432

02:03:50 *** Artea has quit IRC (Ping timeout: 480 seconds)

03:18:29 *** Wormnest has quit IRC (Quit: Leaving)

03:24:36 *** gnu_jj_ has quit IRC (Ping timeout: 480 seconds)

04:04:50 *** debdog has quit IRC (Ping timeout: 480 seconds)

04:15:52 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #13438: Fix 3e747397f0: Also upgrade preview workflow https://github.com/OpenTTD/OpenTTD/pull/13438

04:40:53 <DorpsGek> - Update: Translations from eints (by translators)

04:59:44 *** mindlesstux has quit IRC (Quit: The Lounge - https://thelounge.chat)

05:46:22 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13437: Cleanup: [Script] Remove unneeded squirrel exports since #13389 https://github.com/OpenTTD/OpenTTD/pull/13437#pullrequestreview-2588472107

05:48:57 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13438: Fix 3e747397f0: Also upgrade preview workflow https://github.com/OpenTTD/OpenTTD/pull/13438#pullrequestreview-2588472371

06:03:42 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13439: Doc: cross-reference Emscripten version number locations https://github.com/OpenTTD/OpenTTD/pull/13439

08:09:43 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13440: Codechange: add conversion helpers to VehicleListIdentifier https://github.com/OpenTTD/OpenTTD/pull/13440

08:16:49 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #13439: Doc: cross-reference Emscripten version number locations https://github.com/OpenTTD/OpenTTD/pull/13439#pullrequestreview-2588492368

08:25:44 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13440: Codechange: add conversion helpers to VehicleListIdentifier https://github.com/OpenTTD/OpenTTD/pull/13440

08:26:16 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13439: Doc: cross-reference Emscripten version number locations https://github.com/OpenTTD/OpenTTD/pull/13439

08:53:23 <peter1138> I'm going with some breakfast first.

09:03:28 <peter1138> Hmm, surprising, only a few conflicts, and one extra SetDParam, to get the string parameters branch up to date.

09:12:34 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13285: Codechange: Remove global string parameters. https://github.com/OpenTTD/OpenTTD/pull/13285#pullrequestreview-2588502953

09:16:21 *** gnu_jj has quit IRC (Ping timeout: 480 seconds)

09:22:37 <peter1138> When I push the current version :)

09:23:47 *** Flygon has quit IRC (Read error: Connection reset by peer)

09:31:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13285: Codechange: Remove global string parameters. https://github.com/OpenTTD/OpenTTD/pull/13285

09:42:58 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13285: Codechange: Remove global string parameters. https://github.com/OpenTTD/OpenTTD/pull/13285#pullrequestreview-2588509325

09:44:32 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13285: Codechange: Remove global string parameters. https://github.com/OpenTTD/OpenTTD/pull/13285#pullrequestreview-2588509638

09:51:30 <andythenorth> so consist_factory makes consists

09:52:00 <andythenorth> consist_factory also makes the units, via indirection to unit_factory instances

09:52:20 <andythenorth> this leads to consist_factory.unit_factory

09:52:40 <andythenorth> factory in factory is weird?

09:56:30 <peter1138> Hmm, the `& ~` operation is a little bit awkward with EnumBitSet.

09:56:45 <peter1138> `&= ~` is easy, that's `Reset()`

09:58:54 <peter1138> `Flags{flags}.Reset(flag)` is... perhaps workable.

10:08:18 <andythenorth> (factory in factory is fine)

10:08:33 <andythenorth> so we don't make new things any more, we just refactor? 🙂

10:09:54 *** jlx__ has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)

10:13:48 <peter1138> Some times you just get frustrated with how something is done, so you come up with a better way. And that better way can also apply to other code. So you apply it.

10:17:36 <andythenorth> if you have 5 grf projects....the compiles are always leap-frogging each other

10:17:50 <andythenorth> then it's possible to spend all the time saving time by making them match

10:18:07 <peter1138> "2CC" is problematic for enum-class nmaing.

10:18:32 <andythenorth> oh EDIASD `@description.setter` I always wonder how I could set things that have `@property` decorator

10:21:04 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13441: Codechange: Use EnumBitSet for ObjectFlags. https://github.com/OpenTTD/OpenTTD/pull/13441

10:26:00 <peter1138> `Uses2CC` is consist with engine flags, so that made that choice easier.

10:28:26 <xarick> spec->flags.Test()... "Test" is a weird name

10:28:59 <peter1138> It's modelled on std::bitset.

10:29:07 <peter1138> And has been approved that way.

10:48:39 <xarick> dangerous change, cus it's not conflicting

10:49:00 <xarick> but I know for sure it won't compile

10:49:49 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13434: Codechange: Use EnumBitSet for GRFConfig-related enums. https://github.com/OpenTTD/OpenTTD/pull/13434

10:56:52 <xarick> the problem with not imediately converting ground tiles with water after terraform:

10:57:13 <xarick> a river could start at one of those tiles

10:58:31 <xarick> or continue through those tiles

10:59:42 <andythenorth> MapShard.RiverManager.init()

11:00:38 <andythenorth> yair ok so what if the game could modify terrain during gameplay, outwith an AI or GS

11:00:53 <andythenorth> and had a limited number of opcodes or something every n ticks

11:03:22 <andythenorth> we already handle flooding, trees and restoring bulldozed tiles

11:04:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13442: Codechange: Pass rect to DrawStationCoverageAreaText. https://github.com/OpenTTD/OpenTTD/pull/13442

11:07:07 <xarick> why was my sub-tropical pr closed.. it's so painful to debug sub-tropical. Takes a year to generate map

11:08:06 <xarick> it's only 5 seconds on a release build, but 250 seconds on a debug build, just for that step

11:14:18 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13374: Fix: Remove unwanted river artifacts after generation https://github.com/OpenTTD/OpenTTD/pull/13374

11:51:11 <peter1138> You're generating a 4096x4096 map in a debug build.

11:54:33 <xarick> but they're behind a 5 minutes paywall

11:55:47 <xarick> and it's exactly subtropical that I am targetting

11:55:56 <xarick> to check the desert around river stuff

11:56:15 <peter1138> I feel like reverting 4cbab4f744e531d17d7e523d80092f54b4e4659d

12:00:09 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13435: Codechange: allow passing extra parameters through AllocateWindowDescFront https://github.com/OpenTTD/OpenTTD/pull/13435#pullrequestreview-2588535927

12:10:14 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #13398: Add: [Script] Multiple road waypoints API functions https://github.com/OpenTTD/OpenTTD/pull/13398#issuecomment-2629369703

12:18:58 <LordAro> xarick: there is very little advantage to debugging 4k maps

12:19:44 <LordAro> debug something smaller, then any improvements you make will scale accordingly, and it will be faster for you to test changes generally

12:27:07 <xarick> I understand, but sometimes I aim for those exceptional rare bugs, very large maps are handy as they produce more situations where it can occur.

12:30:11 <xarick> guess I'm mad for the PR being rejected :/ 250 to 16 seconds

12:30:48 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #13437: Cleanup: [Script] Remove unneeded squirrel exports since #13389 https://github.com/OpenTTD/OpenTTD/pull/13437

12:32:48 <LordAro> xarick: sure, but then you can identify the necessary parts to reproduce the issue, and replicate it in a smaller map

12:34:13 <LordAro> i've wondered before how feasible it'd be as a debug feature to extract a slice of a larger map

12:35:11 <LordAro> in theory it's just saving a section of the map array and throwing away anything that is outside it. i suspect much much harder in practice

12:39:37 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #13438: Fix 3e747397f0: Also upgrade preview workflow https://github.com/OpenTTD/OpenTTD/pull/13438

13:09:31 *** kuka_lie has quit IRC (Quit: leaving)

13:24:11 *** grilled_cheese0933 has joined #openttd

13:42:32 <xarick> do you have this folder in your system?

13:42:42 <xarick> C:\Users\Ricardo Soares\AppData\Local\Temp\SymbolCache

13:42:48 <xarick> but your user name of course

14:15:06 <_glx_> of course I have it, MS stores debug symbol here so it doesn't need to download them continuously

14:16:45 <_glx_> oh it's actually only openttd symbols here, and it has all builds you ever done

14:19:58 <xarick> gonna test NTFS compression, see how much it helps

14:48:05 <_glx_> you can safely clear the folder, just rebuild before running debug

14:53:39 <_zephyris> Better to test river gen on a challenging heightmap?

14:55:33 <_glx_> hmm weird it's unexpectedly using temp dir on my system

14:57:23 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13435: Codechange: allow passing extra parameters through AllocateWindowDescFront https://github.com/OpenTTD/OpenTTD/pull/13435

14:59:51 <_glx_> hmm but it's also using what I set in _NT_SYMBOL_PATH (as it should)

15:13:20 <DorpsGek> [OpenTTD/OpenTTD] mrslate420 opened issue #13443: [Bug]: "content downloading" never clears on NewGRF download box https://github.com/OpenTTD/OpenTTD/issues/13443

15:14:53 <DorpsGek> [OpenTTD/OpenTTD] mrslate420 commented on issue #12654: [Bug]: Catchment area gets deselected when expanding a station https://github.com/OpenTTD/OpenTTD/issues/12654

15:15:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #13443: [Bug]: "content downloading" never clears on NewGRF download box https://github.com/OpenTTD/OpenTTD/issues/13443

15:17:00 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened pull request #13444: Change: Rainforest is one word https://github.com/OpenTTD/OpenTTD/pull/13444

15:19:42 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13285: Codechange: Remove global string parameters. https://github.com/OpenTTD/OpenTTD/pull/13285#pullrequestreview-2588573957

15:19:50 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13444: Change: Rainforest is one word https://github.com/OpenTTD/OpenTTD/pull/13444#pullrequestreview-2588577141

15:23:15 <peter1138> Better off just deleting it.

15:23:24 <peter1138> You don't need all the information from builds you made months ago.

15:26:05 <peter1138> Hmm, EncodedString::GetParam() and EncodedString::SetParam() perhaps.

15:36:31 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13445: Fix: [Script] Wrong return value for failed preconditions Vehicle::CloneVehicle https://github.com/OpenTTD/OpenTTD/pull/13445

15:41:47 <_glx_> oh actually it uses cache specified in _NT_SYMBOL_PATH, but also the cache folder in VS settings

15:53:40 *** benjaminv has quit IRC (Ping timeout: 480 seconds)

15:58:27 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler merged pull request #13444: Change: Rainforest is one word https://github.com/OpenTTD/OpenTTD/pull/13444

16:12:59 <andythenorth> uuf Horse compile is so slow

16:15:08 <LordAro> andythenorth: what qualifies as "so slow"?

16:16:16 <andythenorth> I am refactoring things that require running the full compile frequently 😛

16:24:45 <peter1138> > 100% tests passed, 0 tests failed out of 71

16:26:22 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13432: Fix #13431: Press Ctrl to build diagonal canals in game mode https://github.com/OpenTTD/OpenTTD/pull/13432#pullrequestreview-2588589403

16:35:54 <DorpsGek> [OpenTTD/OpenTTD] maksalees opened pull request #13446: Change: [MacOS] Put the icon in a rounded rectangle https://github.com/OpenTTD/OpenTTD/pull/13446

16:40:39 <xarick> diagonal canals not in a game?

16:42:50 <ahyangyi> 756x slower than iron horse 😢

16:42:53 <xarick> ah nevermind, I failed at reading

16:45:57 <peter1138> Good job I don't use Mac OS I guess.

16:49:41 <Rubidium> in how many months will the design guideline for MacOS change again?!?

16:54:27 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13445: Fix: [Script] Wrong return value for failed preconditions Vehicle::CloneVehicle https://github.com/OpenTTD/OpenTTD/pull/13445#pullrequestreview-2588594338

16:57:07 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13442: Codechange: Pass rect to DrawStationCoverageAreaText. https://github.com/OpenTTD/OpenTTD/pull/13442#pullrequestreview-2588594760

16:58:40 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13446: Change: [MacOS] Put the icon in a rounded rectangle https://github.com/OpenTTD/OpenTTD/pull/13446#issuecomment-2629472093

17:01:12 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13445: Fix: [Script] Wrong return value for failed preconditions Vehicle::CloneVehicle https://github.com/OpenTTD/OpenTTD/pull/13445

17:15:50 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13442: Codechange: Pass rect to DrawStationCoverageAreaText. https://github.com/OpenTTD/OpenTTD/pull/13442

17:20:54 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13447: Codechange: make WindowNumber a very converty object https://github.com/OpenTTD/OpenTTD/pull/13447

17:21:45 *** twpol has quit IRC (Ping timeout: 480 seconds)

17:45:23 <peter1138> Ah, just Mac OS is faster.

17:46:30 <_glx_> not unexpected to have weird errors here

17:49:03 <Rubidium> though StringID is just uint32_t

17:49:11 <_glx_> but compiler could be smart enough to use `int32_t` auto cast

17:50:56 <_glx_> does WindowNumber really need to be signed ?

17:51:44 <Rubidium> probably not, but that's not for this PR to figure out ;)

17:52:09 <_glx_> anyway I would assume the compiler can convert WindowNumber to anything

17:55:10 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13447: Codechange: make WindowNumber a very converty object https://github.com/OpenTTD/OpenTTD/pull/13447

17:55:21 <Rubidium> it probably got stressed by too many choices

18:00:43 <_glx_> clang-cl failed with old, works with new

18:01:52 <_glx_> clearly too many choices 🙂

18:31:22 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13441: Codechange: Use EnumBitSet for ObjectFlags. https://github.com/OpenTTD/OpenTTD/pull/13441#pullrequestreview-2588610328

18:41:22 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #13447: Codechange: make WindowNumber a very converty object https://github.com/OpenTTD/OpenTTD/pull/13447#pullrequestreview-2588611883

18:45:20 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13447: Codechange: make WindowNumber a very converty object https://github.com/OpenTTD/OpenTTD/pull/13447

18:48:23 *** ChanServ sets mode: +v tokai|noir

18:54:46 <DorpsGek> [OpenTTD/OpenTTD] JGRennison opened pull request #13448: Fix #12912: CompanyProperties::inaugurated_year_calendar not saved https://github.com/OpenTTD/OpenTTD/pull/13448

18:55:11 *** tokai has quit IRC (Ping timeout: 480 seconds)

18:58:30 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13402: Codechange: make pool item indices strongly typed https://github.com/OpenTTD/OpenTTD/pull/13402

19:56:54 <xarick> I'm sorting PR's by least recently updated

19:58:51 <xarick> generally speaking, the main issue with changing construction behaviour for an AI is about the existing pathfinders

19:59:28 <xarick> they're coded to expect certain behaviours

19:59:44 <xarick> there's a risk of breaking stuff

20:00:07 <xarick> but i dunno, may be worth trying

20:06:48 <xarick> it compiled in only 1 minute

20:22:25 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13416: Codechange: make some types used as ID in pools enums https://github.com/OpenTTD/OpenTTD/pull/13416

20:46:28 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13073: Add: NewGRF Badges feature https://github.com/OpenTTD/OpenTTD/pull/13073

20:48:56 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13448: Fix #12912: CompanyProperties::inaugurated_year_calendar not saved https://github.com/OpenTTD/OpenTTD/pull/13448#pullrequestreview-2588634576

20:53:16 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13440: Codechange: add conversion helpers to VehicleListIdentifier https://github.com/OpenTTD/OpenTTD/pull/13440

20:53:29 *** gelignite has quit IRC (Quit: Stay safe!)

21:15:07 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13441: Codechange: Use EnumBitSet for ObjectFlags. https://github.com/OpenTTD/OpenTTD/pull/13441

21:42:55 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)

22:01:21 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)

22:04:36 *** kuka_lie has quit IRC (Remote host closed the connection)

22:07:09 <peter1138> You can always continue worrying about a 35 second compilation time.

22:09:49 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13449: Codechange: Make OverflowSafeInt ConvertibleThroughBase. https://github.com/OpenTTD/OpenTTD/pull/13449

22:17:06 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13449: Codechange: Make OverflowSafeInt ConvertibleThroughBase. https://github.com/OpenTTD/OpenTTD/pull/13449#pullrequestreview-2588652805

22:23:39 *** keikoz has quit IRC (Ping timeout: 480 seconds)

22:24:00 <xarick> I see many tree related PR's

22:28:04 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13450: Codechange: add automation for (re)setting the 'work: needs rebase' label on PRs https://github.com/OpenTTD/OpenTTD/pull/13450

22:29:06 *** nielsm has quit IRC (Ping timeout: 480 seconds)

22:34:17 <xarick> I had a PR today that would not compile after rebasing, without showing any file conflicts

22:34:40 <xarick> how is that needs rebase going to work correctly?

22:35:24 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #13450: Codechange: add automation for (re)setting the 'work: needs rebase' label on PRs https://github.com/OpenTTD/OpenTTD/pull/13450#issuecomment-2629590452

22:35:38 <truebrain> Rubidium: https://github.com/eps1lon/actions-label-merge-conflict/issues/86 for context, but I didn't want to link your PR to that issue directly 🙂

22:38:20 <truebrain> (and in the world of GitHub, you can't add a comment to a PR that has a link to another issue, without instantly telling the other issue that has been done ... I so hate that 😛 )

22:38:31 <truebrain> anyway, I like the idea of that PR 🙂