IRC logs for #openttd on OFTC at 2024-12-15
            
00:00:23 *** nielsm has quit IRC (Ping timeout: 480 seconds)
00:31:24 *** bryjen has quit IRC (Quit: Leaving)
00:44:21 <DorpsGek> [OpenTTD/team] tinygrox opened issue #604: [zh_CN] Translator access request https://github.com/OpenTTD/team/issues/604
01:39:08 *** Flygon has quit IRC (Read error: Connection reset by peer)
01:58:17 <DorpsGek> [OpenTTD/team] glx22 commented on issue #604: [zh_CN] Translator access request https://github.com/OpenTTD/team/issues/604
02:21:55 *** gelignite is now known as Guest3128
02:22:00 *** gelignite has joined #openttd
02:29:08 *** Guest3128 has quit IRC (Ping timeout: 480 seconds)
03:21:31 *** gnu_jj has joined #openttd
03:25:01 *** gnu_jj_ has quit IRC (Ping timeout: 480 seconds)
03:43:07 *** D-HUND has joined #openttd
03:46:31 *** debdog has quit IRC (Ping timeout: 480 seconds)
04:19:25 *** gelignite has quit IRC (Quit: Stay safe!)
04:43:14 <DorpsGek> [OpenTTD/team] Wumffan opened issue #605: [zh_CN] Translator access request https://github.com/OpenTTD/team/issues/605
04:44:04 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/8bf2ab62d9f2c3ad2a70d62693c57f98763ffe45
04:44:05 <DorpsGek> - Update: Translations from eints (by translators)
05:20:03 *** keikoz has joined #openttd
05:58:52 *** tokai|noir has joined #openttd
05:58:52 *** ChanServ sets mode: +v tokai|noir
06:05:43 *** tokai has quit IRC (Ping timeout: 480 seconds)
06:20:52 *** ialokin has joined #openttd
08:13:02 <kuhnovic> xarick: That's great news. Last time you found path issues pretty much right away. Thanks for having a look!
08:47:39 *** nielsm has joined #openttd
09:30:01 <DorpsGek> [OpenTTD/steam-social] mxmeinhold opened issue #5: Failed to initialise https://github.com/OpenTTD/steam-social/issues/5
09:43:21 <DorpsGek> [OpenTTD/steam-social] PeterN commented on issue #5: Failed to initialise https://github.com/OpenTTD/steam-social/issues/5
09:59:53 *** Wolf01 has joined #openttd
10:40:19 <andythenorth> pff
10:40:30 <andythenorth> such lunch
10:43:36 *** kuka_lie has joined #openttd
11:08:08 *** Flygon has joined #openttd
11:19:15 <truebrain> lol, that moment you find out that the spaces alone are 20% of your filesize
11:19:22 <truebrain> maybe this JSON file doesn't have to be -that- human readable ๐Ÿ˜„
11:25:40 <Rubidium> though what's the difference in compressed file size?
11:25:53 <truebrain> these files aren't compressed, so not relevant to my use-case to answer that ๐Ÿ™‚
11:30:25 <peter1138> `s/ //g`
11:30:25 <peter1138> Do it.
11:30:39 <truebrain> the "human readable" part in that story isn't unimportant ๐Ÿ˜›
11:30:39 <peter1138> Nothing will possibly go wrong.
11:31:37 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1317816331181101066/image.png?ex=67600f99&is=675ebe19&hm=467778f4673b2ace3da442eae6f14759f3bfd852adebb687fbd53497a4296fe4&
11:31:37 <peter1138> Great.
11:31:50 <truebrain> sounds legit
11:32:43 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1317816606298210345/image.png?ex=67600fda&is=675ebe5a&hm=2d3434a8ceeb4a62df2786a194555b07600e86e14d1eb9d61e16d5f66d74c5a8&
11:32:43 <peter1138> Aw yes.
11:36:50 <truebrain> grrr, I rerun a summary report, and it gives me different results ..
11:36:52 <truebrain> where did I mess up ....
11:37:09 <peter1138> Sorting?
11:38:03 <DorpsGek> [OpenTTD/survey-web] TrueBrain opened pull request #54: Fix: restore wk39 summary report https://github.com/OpenTTD/survey-web/pull/54
11:38:06 <truebrain> at least found one bug I can understand
11:40:22 <truebrain> ah, I found why the results are different ... I was typing the wrong characters in my CLI command ๐Ÿ˜›
11:40:42 <truebrain> you would think I should be capable by now of typing the right letters
11:40:43 <truebrain> I am not ๐Ÿ˜›
11:41:27 <DorpsGek> [OpenTTD/survey-web] TrueBrain merged pull request #54: Fix: restore wk39 summary report https://github.com/OpenTTD/survey-web/pull/54
11:41:28 <Rubidium> you are capable... most of the time ;) I've got the same issue :(
11:42:24 <truebrain> https://cdn.discordapp.com/attachments/1008473233844097104/1317819043385966643/image.png?ex=6760121f&is=675ec09f&hm=98d2a1ee851d8a616fb98adbc8c77aecb57aab89edb3383b6d2e08f8839d32b0&
11:42:24 <truebrain> now to find out how to report that in a slightly nicer way ๐Ÿ˜›
12:04:52 <truebrain> https://cdn.discordapp.com/attachments/1008473233844097104/1317824699647922236/image.png?ex=67601764&is=675ec5e4&hm=41d9a3041045000a08618d42cdcb142b275e5b9ce08eda870688ede233396d55&
12:04:52 <truebrain> based on snippet of a few weeks ago
12:12:47 <andythenorth> ๐Ÿ‘€
12:16:21 <peter1138> Fancy.
12:18:29 <peter1138> The more I look at it, the more this is just weird...
12:19:02 <truebrain> https://cdn.discordapp.com/attachments/1008473233844097104/1317828264609447956/image.png?ex=67601ab6&is=675ec936&hm=659ae559cef5bfb250c4b4aa06d0d34823cac9659a096a01a4e49f9ea2e07a6d&
12:19:02 <truebrain> another data-set. I have much more data, but I am having trouble getting that in the poorly-constructed HTML+CSS we call OpenTTD's design ๐Ÿ˜„
12:19:29 <truebrain> for example, which exact version was used, and the authors of the NewGRF, that kinda stuff
12:19:35 <truebrain> but it is annoying to fiddle that in .. hmm
12:19:46 <peter1138> Percentage based on NewGRF feature set...
12:20:30 <peter1138> Is that 21% of game-hours use ISR?
12:21:06 <truebrain> it is the exact same as any other statistic in the survey ๐Ÿ™‚
12:21:26 <truebrain> so yes, ISR, in this week for this OpenTTD version, was used in 21% of the playtime we recorded
12:22:04 <truebrain> also means no GRF will ever be above the "100 - (no-grf-games)" percentage
12:22:57 <truebrain> I think this is the most fair way to present this data, and in line with all other information we show. But I am totally open for other ideas ๐Ÿ™‚
12:26:02 <andythenorth> Free tier of Retool? ๐Ÿ˜› https://retool.com/en-GB/pricing
12:26:09 <andythenorth> or Looker Studio? ๐Ÿ˜›
12:26:34 <andythenorth> do we have an OpenTTD Google account? ๐Ÿ˜›
12:45:12 <truebrain> owh joy, the contentID for AIs is not reported, but the actual name. This will be "fun" ...
12:57:45 <truebrain> owh, even better ... we get reported the numeric AI version number, but BaNaNaS indexes the human readable version number
12:57:49 <truebrain> those two don't always match, ofc ๐Ÿ˜›
12:58:10 <truebrain> why do we report it like this? ๐Ÿ˜„
12:58:21 <peter1138> Well.
12:58:42 <truebrain> because the crashlog did that already, and I didn't give it any real thought
13:00:32 <truebrain> but it also means I have no way to check popularity of AIs in the same way as I can do NewGRFs .. I can only do a bit of fuzzy matching, which in 99% of the cases will be correct
13:00:36 <truebrain> and someone will bitch about that 1% ๐Ÿ˜›
13:08:54 <truebrain> anyway, peter1138, am I right to assume that your silence means you also don't know anything better to use to represent "popularity" of NewGRFs? ๐Ÿ˜„
13:11:58 <peter1138> I didn't realise there was a question.
13:12:20 <truebrain> you said it looked weird! So I said I was open for other ideas ๐Ÿ˜„
13:12:20 <peter1138> Game-hours is fine, it's not subjective.
13:12:32 <peter1138> Oh
13:12:36 <peter1138> No, that was some code.
13:12:42 <truebrain> lol, context is everything ๐Ÿ™‚
13:13:04 <peter1138> smallmap_gui.cpp:1647 if you want to know.
13:13:13 <peter1138> This is "definitely" how switches should be used.
13:13:55 <truebrain> wth
13:14:01 <truebrain> okay
13:14:02 <truebrain> so
13:14:03 <truebrain> yeah
13:14:34 <peter1138> hehe
13:14:45 <truebrain> oof, uploading to BaNaNaS doesn't even check if your AI version is unique
13:14:57 <truebrain> we made a bit of a mess with all this AI/GS stuff you know ๐Ÿ˜„
13:16:47 <peter1138> "It works, ship it!"
13:17:14 <truebrain> I was clearly a lot younger ๐Ÿ˜›
13:20:26 *** Wolf01 is now known as Guest3168
13:20:28 *** Wolf01 has joined #openttd
13:23:52 <truebrain> https://cdn.discordapp.com/attachments/1008473233844097104/1317844581106323587/image.png?ex=676029e8&is=675ed868&hm=6309cae460b83495121a049255512a483d6254f3d3ba8bc578f6eba18585a90d&
13:23:52 <truebrain> well, at least some basic information I can extract from the surveys
13:23:58 <truebrain> (again, random week, random version)
13:25:53 *** Guest3168 has quit IRC (Ping timeout: 480 seconds)
13:27:53 *** tokai|noir has quit IRC (Quit: c('~' )o)
13:29:03 <truebrain> https://cdn.discordapp.com/attachments/1008473233844097104/1317845883085394050/image.png?ex=67602b1e&is=675ed99e&hm=f066d1d1abb4b500c05a0dcd23e2d9880178c528ffee19b6e8b174ffb3ffc3e8&
13:29:03 <truebrain> and GS!
13:29:10 <truebrain> okay ... "good enough" for now, I guess
13:30:31 <kuhnovic> Is this based on existing data that previously wasn't shown in the surveys?
13:30:46 <truebrain> yes
13:31:53 <truebrain> I added in there, as I believe it is vastly more valuable to see how much a GRF is actually used, versus what people wanted: download counters, etc
13:32:02 <truebrain> as those download counters are pointless numbers ๐Ÿ˜›
13:32:28 <truebrain> but processing this survey information has been .. tricky ๐Ÿ˜›
13:32:40 <truebrain> but I think I have something that works now ๐Ÿ™‚
13:33:08 <truebrain> let's see how a quarter-report looks like
13:36:11 <kuhnovic> It looks nice. Actual time played is a much better number than download count.
13:37:01 <truebrain> I do wonder if I should mention all GRFs, or put a treshold on it, like I do with settings
13:37:12 <truebrain> just if less than 0.1% of the games are played with the GRF, it is not reported?
13:37:18 <truebrain> meh, takes effort, and solves little
13:37:23 <truebrain> btw, only GRFs that are on BaNaNaS show up
13:37:34 <truebrain> to avoid leaking information about private GRFs etc
13:38:23 <kuhnovic> How many GRFs show up in the quality report? It might become quite a long list if there's no threshold
13:38:42 <truebrain> running a quarter report now, but .. it takes a bit of time ๐Ÿ˜„
13:38:52 <truebrain> been running for 10 minutes already ๐Ÿ˜›
13:39:00 <truebrain> ah, there we go
13:39:23 <truebrain> it is a long list, but not unreasonably long
13:39:39 <kuhnovic> truebrain: You could create a "other / unknown" entry. Gives us some idea of how many people are using non-bananas content.
13:39:42 <truebrain> ISR was by far the most popular for Q3 ๐Ÿ™‚
13:40:36 <peter1138> Are you sure the NewGRF stats are right? I've been told before that most players are using either AXIS or XIS industry sets.
13:41:01 <peter1138> Maybe it was some ... extrapolation.
13:41:20 <truebrain> I am like 80% sure the stats are correct ๐Ÿ˜›
13:41:44 <truebrain> JGRPP listing is totally different from vanilla
13:41:45 <peter1138> Must be wrong, everyone uses JGRPP ๐Ÿ˜‰
13:41:47 <truebrain> but that is no real surprise ๐Ÿ™‚
13:42:04 <truebrain> but even in JGRPP, 60% of the playtime used ISR ๐Ÿ™‚
13:42:07 <truebrain> (in Q3 2024)
13:42:24 <peter1138> So basically I should avoid breaking ISR.
13:42:24 <_jgr_> ISR is a rail station set, I'm not to surprised that its popular
13:42:38 <truebrain> good; those are the things I like to hear _jgr_ ๐Ÿ™‚
13:42:50 <truebrain> https://cdn.discordapp.com/attachments/1008473233844097104/1317849354970595428/image.png?ex=67602e5a&is=675edcda&hm=e426f86fb315470ad34df9c9fd0600ed57067febac1381e936488fa6a704f68b&
13:42:50 <truebrain> JGRPP 2024 Q3 report
13:43:23 <truebrain> it feels reasonable, but .. what do I know ๐Ÿ˜›
13:43:36 <truebrain> ` Road Stops & Waypoints (JGRPP)` is at 34.5% for that same report
13:43:58 <truebrain> so at least the split between vanilla and jgrpp seems to work as expected ๐Ÿ™‚
13:47:26 <_jgr_> truebrain: That looks pretty plausible to me
13:47:34 <truebrain> good; tnx ๐Ÿ™‚
13:47:48 <truebrain> ugh, more issues with AI/GS ... the name as used on BaNaNaS often doesn't match the name used in the script
13:48:09 <truebrain> so I can't resolve one to the other ...
13:48:36 <peter1138> Hmm, fix the system to use content ID and ignore the existing stats?
13:48:50 <truebrain> yeah ... it is a bit silly, we send the AI name, instead of the AI shortname
13:48:57 <truebrain> the shortname is the contentID (4 characters)
13:49:06 <truebrain> so not sure what went on here, but it is all a bit meh ๐Ÿ˜›
13:49:11 <peter1138> (Or fix the system to use content ID and try to mangle the existing results)
13:49:43 <truebrain> `Town and Industry Control` vs `Town & Industry Control`
13:49:44 <truebrain> stuff like that
13:50:13 <peter1138> Urgh, STRING1 etc are now bugging me more and more.
13:50:29 <peter1138> I need STRINGmightbe1butcouldbe0.
13:50:34 <truebrain> lolz
13:51:12 <peter1138> Or I have to include a dummy parameter, and remember to include those wherever it might be needed.
13:51:46 <peter1138> Or perhaps treat the parameter count is... flexible, and ignore the problem.
13:52:32 <truebrain> ah, right, BaNaNaS has issues analyzing the AI bundles, as you can do nasty things in Squirrel
13:52:40 <truebrain> so BaNaNaS can't really analyze the content of an AI that well
13:53:54 <truebrain> okay ... and now the main question: should I be publishing these popularity data in the first place? ๐Ÿ˜„
13:54:21 <talltyler> Yes!
13:55:54 <peter1138> Does it help? Does it change anything?
13:56:29 <talltyler> I agree that this fulfills the โ€œshow download countโ€ request from authors, and also tells us what we shouldnโ€™t break with changes to cargo handling, etc. saves Peter from trawling bananas trying to figure out whatโ€™s popular ๐Ÿ™‚
13:57:15 <peter1138> Okay, maybe if trying to read past the end of the parameters just treats it an invalid parameter, instead of asserting.
13:58:16 <peter1138> Can Bananas tell us how many Chinese forums there are?
13:59:24 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1317853522242572348/image.png?ex=6760323c&is=675ee0bc&hm=1a148743a53031e515f4721e5facf8088c5e5955d77242fa20af279401f10746&
13:59:24 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1317853522489905213/image.png?ex=6760323c&is=675ee0bc&hm=0d575771ca78ea67fa27ada62d1503d2af7f4c997839ba61928439784de53096&
13:59:24 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1317853522716266526/image.png?ex=6760323c&is=675ee0bc&hm=14ff59d20375db3dc35ebd816609257cef2f15a8fba4e6b301bb2facd1a64dcd&
14:03:29 <peter1138> Hmm, lenient seems to work, but kinda feels wrong.
14:04:04 <peter1138> Well, onto figuring out news messages
14:04:17 <truebrain> good luck!
14:04:28 <truebrain> my fuzzy matching of AI scripts seem to somewhat work
14:04:43 <peter1138> Did you use AI to...
14:04:52 <truebrain> not even!
14:04:57 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1317854917376999464/image.png?ex=67603388&is=675ee208&hm=fe8a7d88bc91266547b7b1751a69ba53011434a3eeba916ca344600c0211a1c2&
14:04:57 <peter1138> Ok this is not right.
14:05:33 <peter1138> Supposed to be cargo type.
14:05:34 <truebrain> `Peaks and Troughs v2`
14:05:34 <truebrain> There are some I simply can't match without getting too fuzzy .. on BaNaNaS, this is called `Peaks and Troughs`, but marked as version 2 ..
14:09:07 <talltyler> Probably not relevant to matching version numbers, but Peaks and Troughs is JGRPP-only
14:10:01 <truebrain> yup
14:11:01 <_glx_> peter1138: for GS if there's a mismatch between STRINGX and the number of given parameters, it fills with 0 if needed
14:11:20 <peter1138> On the encoding side, yeah.
14:11:26 <peter1138> I'm not encoding here thoughj.
14:12:36 <_glx_> yeah openttd can be more strict, as "we" are supposed to properly use strings
14:14:38 <peter1138> My 'issue' is that something like
14:14:38 <peter1138> ```c++
14:14:38 <peter1138> GetString(STR_NEWGRF_SETTINGS_PARAMETER, STR_JUST_RAW_STRING, GRFBuildParamList(c));
14:14:38 <peter1138> GetString(STR_NEWGRF_SETTINGS_PARAMETER, STR_NEWGRF_SETTINGS_PARAMETER_NONE);
14:14:38 <peter1138> does not work.
14:15:04 <truebrain> https://cdn.discordapp.com/attachments/1008473233844097104/1317857464598794280/image.png?ex=676035e8&is=675ee468&hm=a38f2fdc5578f3359218f183f132fcc3072e7066b866185c16b2b0c6d5feaa69&
14:15:04 <truebrain> kuhnovic:
14:15:28 <peter1138> With strict consumption, the second one needs to be ```c++
14:15:28 <peter1138> GetString(STR_NEWGRF_SETTINGS_PARAMETER, STR_NEWGRF_SETTINGS_PARAMETER_NONE, 0 /* dummy parameter */);
14:16:23 <peter1138> There are alternative ways that could work here, though.
14:16:27 <_glx_> I guess it should check it has at least the required number
14:16:56 <peter1138> I can't make GetString check (at compile time) that there are enough parameters for a string ID.
14:18:29 <peter1138> One such alternative is to make this particular one always use raw strings...
14:18:29 <peter1138> ```c++
14:18:29 <peter1138> GetString(STR_NEWGRF_SETTINGS_PARAMETER, GRFBuildParamList(c));
14:18:29 <peter1138> GetString(STR_NEWGRF_SETTINGS_PARAMETER, GetString(STR_NEWGRF_SETTINGS_PARAMETER_NONE));
14:18:33 <_glx_> yeah compile time check is hard
14:19:19 <peter1138> What I've actually done is made parameter consumption not care if the number of supplied parameters is correct.
14:19:55 <peter1138> It will give a run-time error only if the string tries to use the missing parameters.
14:21:12 <peter1138> To do compile-time sets, strgen could probably output a header of each string and the number of parameters it requires. And then some magic templating could pull that in and change.
14:21:35 <peter1138> Does not work if the first parameter is a variable.
14:21:42 <peter1138> And I'm not going to do this ๐Ÿ™‚
14:21:46 <truebrain> https://cdn.discordapp.com/attachments/1008473233844097104/1317859149119225866/image.png?ex=67603779&is=675ee5f9&hm=556ceefd5ee65b973443482d5a40ef256a906f3c43db3da2552a949f970f9521&
14:21:46 <truebrain> lol .. if many entries in the same savegame can't be resolved via BaNaNaS, the stats get a bit weird ๐Ÿ˜›
14:22:09 <peter1138> Ah
14:22:55 <_glx_> the typical case to catch is "not enough args", too many is less an issue
14:23:26 <_glx_> depends on context for too many of course
14:23:37 <peter1138> In this case STR_NEWGRF_SETTINGS_PARAMETER has a STRING1
14:23:45 <peter1138> So providing only 1 argument is "an error"
14:24:08 <_glx_> it's an error if the arg is actually accessed
14:24:11 <peter1138> But it's actually the first argument that needs (or not needs) the additional parameter, not the initial string.
14:24:14 <peter1138> Exactly.
14:24:43 *** Compu has joined #openttd
14:25:10 <peter1138> Except before my changes it's an assert before it gets to even using the parameter.
14:25:22 <peter1138> (It works with global parameters because there's always 20 of them)
14:25:35 <_glx_> you are using per substring params ?
14:25:37 <peter1138> So leniency.
14:27:13 <peter1138> No, That would effectively be my "alternative" above.
14:27:25 *** Compu has quit IRC ()
14:27:48 <peter1138> That requires changing lots of strings from STRINGx to RAW_STRING.
14:27:52 <peter1138> Doable but a big task.
14:30:48 <_jgr_> Changing STRING parameters to RAW_STRING could also break the gender/case stuff for non-English languages
14:31:00 <peter1138> Good point.
14:41:47 <_glx_> oh and some translations use indirect substring params for gender/plural like `{P 0:2 ...}`
14:42:15 <peter1138> Okay, so the way I've gone is better, \oi/
14:46:54 <truebrain> https://cdn.discordapp.com/attachments/1008473233844097104/1317865474419069070/image.png?ex=67603d5d&is=675eebdd&hm=38452966e78bf8888f57f9cbd097b690e3da550b012f90cc7ac52a45bd5bce1c&
14:46:54 <truebrain> I splitted the NewGRFs per set
14:46:58 <truebrain> that looks a lot more useful ๐Ÿ™‚
14:47:20 <michi_cc> Hmm, so strgen should produce something like this in the header?
14:47:20 <michi_cc> ยดยดยดc++
14:47:20 <michi_cc> template<>
14:47:20 <michi_cc> struct String<STR_NEWGRF_SETTINGS_PARAMETER> {
14:47:20 <michi_cc> const ID = 12465;
14:47:21 <michi_cc> using Params = std::tuple<StringID, int>;
14:47:21 <michi_cc> };
14:47:21 <peter1138> Ooh, you have that information easily available? Nice.
14:47:23 <michi_cc> ยดยดยด
14:47:35 <_glx_> ah yes we know the types from the bananas filtering
14:47:39 <truebrain> You can do it michi_cc , just a few more edits to go ๐Ÿ˜„
14:47:49 <truebrain> tripple ` ๐Ÿ˜„
14:48:07 <truebrain> \o/
14:48:20 <truebrain> (IRC is now: wtf is going on; no worries, it wasn't for you ๐Ÿ˜› )
14:48:27 <michi_cc> I had those at first, but it didn't show the formatting preview... ๐Ÿคฃ
14:49:18 <truebrain> If you use triple ` followed by cpp, you get:
14:49:18 <truebrain> ```cpp
14:49:18 <truebrain> template<>
14:49:18 <truebrain> struct String<STR_NEWGRF_SETTINGS_PARAMETER> {
14:49:18 <truebrain> const ID = 12465;
14:49:19 <truebrain> using Params = std::tuple<StringID, int>;
14:49:19 <truebrain> };
14:49:21 <truebrain> ๐Ÿ˜„
14:50:31 <peter1138> Something like that. And then Xarick can complain about the compile time a bit more ๐Ÿ˜‰
14:50:56 <_glx_> only if you touch english.txt ๐Ÿ™‚
14:51:19 <michi_cc> You need to use `GetString<STR_NEWGRF>()` then though. Not really usable for runtime string decisions.
14:51:31 <peter1138> Indeed.
14:52:04 <peter1138> ```c++
14:52:04 <peter1138> EncodedString headline;
14:52:04 <peter1138> if (str > STR_LAST_STRINGID) {
14:52:04 <peter1138> headline = GetEncodedString(str, STR_TOWN_NAME, i->town->index, indspec->name);
14:52:04 <peter1138> } else if (closeit) {
14:52:05 <peter1138> headline = GetEncodedString(str, STR_FORMAT_INDUSTRY_NAME, i->town->index, indspec->name);
14:52:06 <peter1138> } else {
14:52:08 <peter1138> headline = GetEncodedString(str, i->index);
14:52:08 <peter1138> }
14:52:10 <peter1138> This is particularly gnarly.
14:52:35 <peter1138> I don't like that I don't actually know what str is here.
14:53:25 <peter1138> And str comes from the industry spec anyway, so knowing doesn't help.
14:55:31 <_glx_> ha yes `> STR_LAST_STRINGID` can be anything from newgrf to GS
14:56:56 <_glx_> good luck to validate it has a {STRING1} and an {STRING}
14:59:18 <_glx_> second case needs a {STRING2}, and last one is {INDUSTRY}
15:01:21 <peter1138> Oh no, SurveyRecentNews() needs the string id. :S
15:01:28 <truebrain> oh-oh
15:01:37 <truebrain> but does it actually? ๐Ÿ˜›
15:02:01 <peter1138> Might just be that that was easier than setting up the parameters...
15:09:20 <peter1138> Cool, my news messages work again.
15:13:10 <truebrain> and cool, my `(other)` also works, to somewhat limit the output of NewGRF sets with a lot of 0.0% ๐Ÿ˜›
15:14:50 <_glx_> 0.0% still means used ๐Ÿ™‚
15:15:01 <truebrain> yeah, hence the `(other)` ๐Ÿ™‚
15:15:06 <truebrain> (as we already do with all settings)
15:15:17 <truebrain> okay, like 95% of the content is on BaNaNaS
15:15:18 <truebrain> so that is nice
15:15:48 <_glx_> do we have baseset stats ?
15:16:05 <truebrain> they are in there, I don't index them yet
15:16:13 <truebrain> good that you mention it ... let's see if I can add them easily too ..
15:16:26 <truebrain> this "owh, let's take 2 hours to fix this" is taking a lot longer ๐Ÿ˜›
15:17:38 <_glx_> I hope they are mostly original/opengfx[2] but...
15:19:03 <peter1138> Loads of zbase from the tutorial followers
15:19:13 <truebrain> yup, lot of zbase ....
15:26:07 <andythenorth> deprecate zbase ๐Ÿ˜›
15:28:40 <_glx_> hey andythenorth you saw #348 ?
15:29:06 <andythenorth> oh nice
15:29:27 <andythenorth> will test later
15:30:59 <talltyler> andythenorth: Nah, ship OGFX2 with OpenTTD and depreciate tutorials that tell you to install a base set to โ€œfixโ€ the โ€œbad graphicsโ€ of OpenTTD
15:32:13 <talltyler> I would like to have an in-game tutorial someday, but man is that a lot of work. Thereโ€™s a tutorial GS thatโ€™s pretty good, but it only covers road vehicles, ships, and aircraft. Trains are the hardest part for people.
15:33:05 *** kuka_lie has quit IRC (Quit: leaving)
15:33:10 <_glx_> tutorial GS needs update every time GUI changes
15:33:20 *** kuka_lie has joined #openttd
15:33:35 <truebrain> https://cdn.discordapp.com/attachments/1008473233844097104/1317877225948975176/image.png?ex=6760484f&is=675ef6cf&hm=694326a33f03e3f5a7e148814cbfb77bbdc5bf31c35a11fc1b50b633fe810995&
15:33:35 <truebrain> (random week in 2024)
15:33:48 <_glx_> not too bad actually
15:35:13 <truebrain> sadly, linking to BaNaNaS is hard for these too, as here too we give the name ๐Ÿ˜›
15:35:21 <truebrain> which is okay-ish for graphics
15:35:25 <truebrain> but for music is it .... yeah, it is
15:36:04 <truebrain> I also have the version information, but I grown to actually hate Jekyll very much
15:36:08 <truebrain> so I am going to leave it at this ๐Ÿ˜›
15:36:17 <truebrain> but know that there are still some people using rather old OpenGFX versions ๐Ÿ˜„
15:37:34 <truebrain> this creates a lot more HTML than I expected it would ๐Ÿ˜„ Lolz
15:39:45 <_glx_> oh reminds me of the confusion caused by the difference between non manager (<https://github.com/OpenTTD/bananas-frontend-web/blob/main/webclient/templates/version_info.html#L73-L81>) and manager (<https://github.com/OpenTTD/bananas-frontend-web/blob/main/webclient/templates/manager_version_info.html#L43-L50>)
15:40:01 <_glx_> regarding "Download"
15:40:46 <truebrain> the manager-version is only seen for those that update the content; but feel free to make a PR to adjust the confusion ๐Ÿ˜„
15:40:57 <truebrain> download-url is never anything except `None` btw ๐Ÿ˜›
15:41:46 <_glx_> for reference https://discordapp.com/channels/142724111502802944/337701432230805505/1316105072689676288
15:42:22 <truebrain> so PR it already, instead of complaining about it ๐Ÿ˜› ๐Ÿ˜›
15:42:44 <_glx_> should we just remove download-url handling ?
15:42:53 <_glx_> I don't see it coming back
15:43:28 <truebrain> As Cloudflare is now sponsoring us, on a technical level I have no issues reinstating it. But honestly, it has been pretty nice to not have it
15:43:43 <truebrain> lot less question about: I extracted the tar file, and now nothing works!
15:43:45 <truebrain> and stuff like that
15:44:08 <truebrain> but for a PR to fix the above, I would just focus on the thing at hand, and make the manager html look more like the non-manager
15:44:19 <truebrain> in other words: I would just leave it for now; it doesn't do anything, but doesn't hurt anyone either
15:44:53 <truebrain> There is also https://github.com/OpenTTD/bananas-frontend-web/blob/main/webclient/templates/package_info.html#L97 btw. Here it is also the same as the non-manager
15:45:11 <truebrain> a clear case of too little copy/paste ๐Ÿ™‚
15:55:03 <andythenorth> Hmm we could redo our html and css
15:55:58 <truebrain> sadly the "the site should also work without Javascript" wish makes it hard to pick a modern framework ๐Ÿ˜›
15:59:06 <truebrain> Bit of NextJS, React and Mantine would make it quick to build something new and pretty .. but getting pure HTML out of that is tricky ๐Ÿ™‚ SSR? ๐Ÿ˜„
16:01:41 <andythenorth> the 2 winning JS-independent frameworks are Bootstrap and the other one
16:02:03 <andythenorth> Tailwind
16:03:01 <peter1138> And Boostrap is annoying
16:03:10 *** virtualrandomnumber has joined #openttd
16:03:48 <peter1138> Um, okay, I've done something that puts OpenTTD into a hard spin.
16:10:39 *** Wormnest has joined #openttd
16:12:16 <truebrain> oof, generating the survey website now takes a bit longer .. "a bit" ๐Ÿ˜›
16:12:52 <truebrain> I think I have pushed Jekyll too much ๐Ÿ˜›
16:14:15 <peter1138> Does it take longer than the reporting interval?
16:14:46 <truebrain> 129s to render the site, lol
16:15:42 <peter1138> Hmm
16:16:00 <DorpsGek> [OpenTTD/survey-web] TrueBrain opened pull request #55: feat: show the popularity of 3rd-party content like Base Sets, AIs, GSes, and NewGRFs https://github.com/OpenTTD/survey-web/pull/55
16:16:22 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1317887991901065246/image.png?ex=67605256&is=675f00d6&hm=6ba388c92279daea6b034db9032e7d581bfed2b7ea7d2abe39d1596742a764fa&
16:16:22 <peter1138> This type of news is not quite working correctly.
16:16:52 <DorpsGek> [OpenTTD/survey-web] TrueBrain updated pull request #55: feat: show the popularity of 3rd-party content like Base Sets, AIs, GSes, and NewGRFs https://github.com/OpenTTD/survey-web/pull/55
16:17:07 <truebrain> right .. I tihnk that should be it. It takes a few minutes to generate a preview, so dinner first ๐Ÿ™‚
16:17:38 <peter1138> Dunno what this was doing a minute ago but recompiling seems to have fixed it.
16:18:44 <DorpsGek> [OpenTTD/survey-web] github-advanced-security[bot] commented on pull request #55: feat: show the popularity of 3rd-party content like Base Sets, AIs, GSes, and NewGRFs https://github.com/OpenTTD/survey-web/pull/55#pullrequestreview-2504595676
16:22:04 <DorpsGek> [OpenTTD/nml] andythenorth commented on pull request #348: Add: --list-unused-strings to list the unused strings https://github.com/OpenTTD/nml/pull/348#issuecomment-2543936112
16:28:01 <peter1138> Detangling SetupSubsidyDecodeParam now.
16:34:02 <andythenorth> approve and merge 348? ๐Ÿ™‚
16:35:19 <DorpsGek> [OpenTTD/nml] PeterN approved pull request #348: Add: --list-unused-strings to list the unused strings https://github.com/OpenTTD/nml/pull/348#pullrequestreview-2504600036
16:35:56 <truebrain> Preview for #55 is ready; if any of you wouldn't mind giving it a look, to see if it all looks correct and well. Not the code perse, more the resulting HTML ๐Ÿ™‚
16:36:43 <_glx_> needs #347 first ๐Ÿ™‚
16:40:40 <DorpsGek> [OpenTTD/nml] PeterN approved pull request #347: Update: Python version for testing https://github.com/OpenTTD/nml/pull/347#pullrequestreview-2504603482
16:46:10 <DorpsGek> [OpenTTD/bananas-frontend-web] glx22 opened pull request #256: Change: Improve consistency between manager and non-manager views https://github.com/OpenTTD/bananas-frontend-web/pull/256
16:46:19 <_glx_> completly untested
16:47:58 <DorpsGek> [OpenTTD/nml] glx22 merged pull request #347: Update: Python version for testing https://github.com/OpenTTD/nml/pull/347
16:48:52 <DorpsGek> [OpenTTD/nml] glx22 updated pull request #348: Add: --list-unused-strings to list the unused strings https://github.com/OpenTTD/nml/pull/348
16:49:55 <_glx_> oh of course Dockerfile for bananas are "wrong"
16:53:35 <DorpsGek> [OpenTTD/steam-social] mxmeinhold commented on issue #5: Failed to initialise https://github.com/OpenTTD/steam-social/issues/5
16:53:45 <DorpsGek> [OpenTTD/steam-social] mxmeinhold closed issue #5: Failed to initialise https://github.com/OpenTTD/steam-social/issues/5
16:56:13 <peter1138> Hmm.
16:56:19 <peter1138> The subsidy strings are a bit odd.
16:57:59 <peter1138> Parameters 3 and 6 are never assigned, which suggests that the STRING2s should be STRING1.
16:58:42 *** virtualrandomnumber has quit IRC (Quit: virtualrandomnumber)
17:00:23 <_glx_> maybe they were at some point
17:13:47 <DorpsGek> [OpenTTD/nml] glx22 merged pull request #348: Add: --list-unused-strings to list the unused strings https://github.com/OpenTTD/nml/pull/348
17:22:02 <DorpsGek> [OpenTTD/nml] glx22 updated pull request #346: Update: changelog for 0.7.6 https://github.com/OpenTTD/nml/pull/346
17:23:50 <_glx_> #344 needs a rebase andythenorth
17:28:51 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1317906230483746816/image.png?ex=67606352&is=675f11d2&hm=5283dd98ec1e63a39b18d60a0d8137b8c414745df45fee5f5bbfcbdcbc52782b&
17:28:51 <peter1138> Well
17:29:01 <peter1138> That was a faff.
17:29:43 <peter1138> (Never mind that normally you'd say "12 minute subsidy")
17:30:50 <peter1138> I'm not sure this entire function is necessary any more, mind you.
17:39:21 <DorpsGek> [OpenTTD/nml] glx22 updated pull request #304: Change: always assume non-track station ground tile https://github.com/OpenTTD/nml/pull/304
17:42:26 *** thurus0909 has joined #openttd
17:42:26 <thurus0909> steam gift 50$ - [steamcommunity.com/gift-card/pay/50](https://u.to/MDgRIQ )
17:42:26 <thurus0909> all
17:46:01 <peter1138> Ok, it's better without, imho.
17:49:23 <peter1138> Still some SetDParam left :S
17:49:39 <peter1138> Crap I gotta fix new company news.
17:55:14 <truebrain> any feedback on https://a6eaf751.openttd-survey-web.pages.dev/ ? Specifically, click through to any survey, to any version, and click on the 3rd-party content stats
17:56:56 <DorpsGek> [OpenTTD/survey-web] TrueBrain updated pull request #55: feat: show the popularity of 3rd-party content like Base Sets, AIs, GSes, and NewGRFs https://github.com/OpenTTD/survey-web/pull/55
18:01:30 <andythenorth> good to have info
18:01:36 <andythenorth> too many people using FIRS 1 ๐Ÿ˜›
18:04:52 <peter1138> Very few original graphics users ๐Ÿ˜ฎ
18:06:02 <DorpsGek> [OpenTTD/bananas-frontend-web] TrueBrain commented on pull request #256: Change: Improve consistency between manager and non-manager views https://github.com/OpenTTD/bananas-frontend-web/pull/256#pullrequestreview-2504631053
18:06:51 <andythenorth> mostly zbase eh
18:07:30 <truebrain> also any feedback on the text and layout? Or is it good as it is? ๐Ÿ˜›
18:07:35 <andythenorth> it's all good
18:07:36 <truebrain> "good enough", I guess ๐Ÿ™‚
18:07:41 <andythenorth> happy to see it
18:08:57 <truebrain> code-wise it is messy, but .. Jekyll is just being shit
18:08:58 <DorpsGek> [OpenTTD/survey-web] TrueBrain updated pull request #55: feat: show the popularity of 3rd-party content like Base Sets, AIs, GSes, and NewGRFs https://github.com/OpenTTD/survey-web/pull/55
18:09:11 <truebrain> issue on my side btw, for not actually understanding Jekyll ๐Ÿ™‚
18:11:00 <DorpsGek> [OpenTTD/bananas-frontend-web] glx22 updated pull request #256: Change: Improve consistency between manager and non-manager views https://github.com/OpenTTD/bananas-frontend-web/pull/256
18:11:38 <pickpacket> truebrain: what are the numbers in the town names options? https://a6eaf751.openttd-survey-web.pages.dev/summaries/2024/wk49/14.1#game.settings.game_creation.town_name
18:11:53 <_glx_> menu index
18:12:13 <_glx_> ah newgrf townnames
18:12:27 <pickpacket> And I forgot: what does "(other)" mean in the percentage count?
18:13:01 <truebrain> please use https://survey.openttd.org/ for such URLs. The above URL was purely for preview of the 3rd-party content stuff ๐Ÿ™‚
18:13:28 <_glx_> "(other)" merges all 0.0%
18:13:34 <truebrain> pickpacket: there is a header on that page; you could read that ๐Ÿ™‚
18:15:38 <pickpacket> truebrain: You assume I can read? ๐Ÿคช How very bold of you
18:15:48 <truebrain> I know right! Such a novel concept ๐Ÿ˜›
18:17:12 <DorpsGek> [OpenTTD/survey-web] TrueBrain updated pull request #55: feat: show the popularity of 3rd-party content like Base Sets, AIs, GSes, and NewGRFs https://github.com/OpenTTD/survey-web/pull/55
18:17:18 <truebrain> now with tested github workflows ๐Ÿ™‚
18:17:35 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
18:21:39 <DorpsGek> [OpenTTD/survey-web] TrueBrain closed pull request #37: Add: Survey pubkey for CityMania client https://github.com/OpenTTD/survey-web/pull/37
18:21:42 <DorpsGek> [OpenTTD/survey-web] TrueBrain commented on pull request #37: Add: Survey pubkey for CityMania client https://github.com/OpenTTD/survey-web/pull/37#issuecomment-2543989516
18:22:39 <_glx_> maybe it's possible to add a `title` attribute for (other)
18:22:49 <truebrain> with what?
18:23:04 <truebrain> as in, adding the attribute is easy ๐Ÿ˜›
18:23:05 <_glx_> so it shows a tooltip
18:23:13 <truebrain> owh, it is mentioned in the header
18:23:18 <truebrain> if people don't read that, will they read a tooltip? ๐Ÿ˜„
18:23:24 <peter1138> title="It means everything else, why is that even a question?"
18:23:25 <_glx_> header can be very far
18:23:52 <truebrain> it is a lot of extra bytes (like a lot a lot) for that once-in-a-year question ๐Ÿ™‚
18:24:18 <truebrain> as you have to repeat it for every `(other)` entry ๐Ÿ˜ฆ
18:24:22 <truebrain> stupid HTML, and lack of pointers
18:25:39 <truebrain> Jekyll 4.3.3 can use Ruby 3.0 .. Jekyll 44.3.4 cannot
18:25:52 <truebrain> You got to love "patches" that require total bump of everything in existence ๐Ÿ™‚
18:26:17 <_glx_> ah yes worse than the multiple blocks of ~400 lines with only leading spaces ๐Ÿ™‚
18:26:23 <pickpacket> truebrain: besides, that once-in-a-year question is always gonna be me anyway
18:26:48 <truebrain> pickpacket: Nah; most likely next year it is me, asking myself that same question ๐Ÿ˜„
18:26:55 <_glx_> (I blame the tool for these lines)
18:27:27 <truebrain> (it is why I wrote it in the header, as I keep forgetting what rule it follows ๐Ÿ˜› )
18:27:43 <pickpacket> truebrain: I LOVE the NewGRF stats!
18:28:07 <truebrain> in that case, time to merge it to production ๐Ÿ˜›
18:28:08 <pickpacket> Also: holy cow, people are actually USING one of my NewGRFs???
18:28:18 <DorpsGek> [OpenTTD/survey-web] TrueBrain merged pull request #55: feat: show the popularity of 3rd-party content like Base Sets, AIs, GSes, and NewGRFs https://github.com/OpenTTD/survey-web/pull/55
18:28:26 *** gelignite has joined #openttd
18:28:48 <pickpacket> truebrain: yes, it was my permission you awaited all along
18:29:10 <truebrain> I do appreciate confirmation of work, so kinda ๐Ÿ˜„
18:29:17 <truebrain> The threshold was 3, and it was reached ๐Ÿ˜›
18:30:11 <truebrain> did I just use `feat:` as prefix? I clearly haven't done enough OpenTTD in a long while
18:30:48 <DorpsGek> [OpenTTD/survey-web] TrueBrain opened pull request #56: Update: bump Ruby to 3.3 https://github.com/OpenTTD/survey-web/pull/56
18:30:58 <truebrain> let's hope this "just works"?
18:33:11 <truebrain> https://survey.openttd.org/summaries/2024/q3/14/content
18:33:11 <truebrain> That at least works ๐Ÿ™‚
18:35:59 <truebrain> _glx_: let me bump bananas-frontend-web to Python 3.11, and fix the build issues while doing so
18:36:18 <_glx_> yeah I noticed the annoying Dockerfile
18:38:05 <DorpsGek> [OpenTTD/survey-web] TrueBrain merged pull request #56: Update: bump Ruby to 3.3 https://github.com/OpenTTD/survey-web/pull/56
18:39:21 <DorpsGek> [OpenTTD/bananas-frontend-web] TrueBrain opened pull request #257: Upgrade: Bump Python to 3.11 https://github.com/OpenTTD/bananas-frontend-web/pull/257
18:40:23 <_glx_> lol conflicts
18:41:00 <DorpsGek> [OpenTTD/bananas-frontend-web] TrueBrain updated pull request #257: Upgrade: Bump Python to 3.11 https://github.com/OpenTTD/bananas-frontend-web/pull/257
18:42:17 <truebrain> does GitHub already have public arm runners?
18:42:18 <truebrain> no ๐Ÿ˜ฆ
18:43:37 <DorpsGek> [OpenTTD/bananas-frontend-web] TrueBrain merged pull request #257: Upgrade: Bump Python to 3.11 https://github.com/OpenTTD/bananas-frontend-web/pull/257
18:44:44 <truebrain> If you now rebase and address the other comments (one way or the other), you can attach the "preview" label to the PR to see on https://bananas-preview.openttd.org how that looks
18:44:50 <truebrain> but running this locally is also easy btw
18:44:57 <DorpsGek> [OpenTTD/bananas-frontend-web] glx22 updated pull request #256: Change: Improve consistency between manager and non-manager views https://github.com/OpenTTD/bananas-frontend-web/pull/256
18:48:37 <_glx_> ah yes "new-game" is not configurable by manager anyway IIRC
18:48:48 <truebrain> that once was planned
18:48:50 <truebrain> but here we are
18:48:51 <truebrain> years later ๐Ÿ˜›
18:49:02 <peter1138> If Andy's MBP runs our infrastructure, that can also be our ARM runner ๐Ÿ˜„
18:49:09 <_glx_> I think there's an open issue to remind it ๐Ÿ™‚
18:59:15 <pickpacket> truebrain: 3 is roughly 2 more than I expected :D
18:59:50 <DorpsGek> [OpenTTD/bananas-frontend-web] glx22 updated pull request #256: Change: Improve consistency between manager and non-manager views https://github.com/OpenTTD/bananas-frontend-web/pull/256
19:36:48 <xarick> 32% no sound, 35% no music, that is wild
19:47:52 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1317941215047454830/image.png?ex=676083e7&is=675f3267&hm=64886bbe096b31f703112856b7be8ad02f9ab0345c0e59de381a30ff3e55d72d&
19:47:52 <peter1138> Nice. Finally. No hacky GetParams...
19:48:51 <wensimehrp> xarick: No planes, no trains...
19:52:28 *** xarothbrook has joined #openttd
19:52:28 <xarothbrook> xarick: OpenTTD has sound?
19:52:39 <_jgr_> xarick: I'd expect that a large chunk of the OpenSFX/OpenMSX users have the volume sliders turned to 0 even if they haven't removed the actual sound/music
19:54:00 <truebrain> we should add volume to the survey results, you say?
20:00:46 <pickpacket> I used to have music now and then, but for some reason it stopped working for me ๐Ÿคท
20:01:01 <pickpacket> I just have it turned off now
20:01:17 <pickpacket> but no sound effects
20:06:31 <peter1138> My sound baseset is not on Bananas.
20:06:58 <peter1138> Opus version of original sounds ๐Ÿ˜‰
20:07:00 *** kuka_lie has quit IRC (Quit: Lost terminal)
20:17:30 <peter1138> Ok, settings dparams, deep in the depths of ini files ๐Ÿ˜’
20:21:33 <andythenorth> peter1138: got ยฃ400 for my i9 from music magpie
20:22:09 <andythenorth> "could buy a pi"
20:22:11 <andythenorth> mm pi
20:22:34 <peter1138> pi 500, then it can do double duty as CI infrastrcture AND a desktop workhorse.
20:25:55 <andythenorth> "the keyboard is the computer"
20:36:52 *** gelignite has quit IRC (Quit: Stay safe!)
20:44:30 <peter1138> Hmm.
20:44:47 <peter1138> Well.
20:45:36 <peter1138> I can make settings work with std::string instead of dparam, but that point about genders/cases...
20:48:10 *** Wormnest has joined #openttd
20:49:08 <truebrain> _glx_: I added the preview label; takes a bit of time, but then you can check if it actually works etc ๐Ÿ™‚
20:49:23 <_glx_> ah yes
20:49:57 <_glx_> I pushed, then dinner, and forgot about the label
20:50:12 <truebrain> no worries
20:51:25 <_glx_> I can only check non manager pages as I don't have any content ๐Ÿ™‚
20:51:41 <truebrain> I just uploaded random content to check out these things ๐Ÿ˜›
20:52:11 <DorpsGek> [OpenTTD/bananas-frontend-web] TrueBrain approved pull request #256: Fix: Improve consistency between manager and non-manager views https://github.com/OpenTTD/bananas-frontend-web/pull/256#pullrequestreview-2504702883
20:52:30 <truebrain> I changed the title slightly
20:52:37 <truebrain> as I consider these things a bug to be fixed ๐Ÿ˜›
20:52:45 <truebrain> do with that what-ever you want ๐Ÿ™‚ Preview looks good ๐Ÿ™‚
20:59:46 <DorpsGek> [OpenTTD/bananas-frontend-web] glx22 merged pull request #256: Fix: Improve consistency between manager and non-manager views https://github.com/OpenTTD/bananas-frontend-web/pull/256
21:07:58 <peter1138> Hmm, EncodedString.Add?
21:08:09 <peter1138> Controversial.
21:08:26 <peter1138> std::vector<StringParameter> would probably be fine.
21:45:50 <peter1138> Yeah
21:56:30 <peter1138> Commit early, commit often... horrible mess to clean up.
22:00:18 <johnfranklin> https://cdn.discordapp.com/attachments/1008473233844097104/1317974546632147064/image.png?ex=6760a2f2&is=675f5172&hm=d22301979bdbfb94e4e376641a873b16a44261609dcb03004cab215edf7bd052&
22:00:18 <johnfranklin> or commit drunk
22:09:41 <peter1138> > 170 files changed, 3142 insertions(+), 3621 deletions(-)
22:09:42 <peter1138> Hmm
22:11:43 *** nielsm has quit IRC (Remote host closed the connection)
22:15:26 <peter1138> That's with all global parameters removed.
22:15:56 <peter1138> But I know for sure this series of commits won't work serially.
22:50:33 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:53:49 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)