IRC logs for #openttd on OFTC at 2024-12-15
โด go to previous day
00:00:23 *** nielsm has quit IRC (Ping timeout: 480 seconds)
00:31:24 *** bryjen has quit IRC (Quit: Leaving)
01:39:08 *** Flygon has quit IRC (Read error: Connection reset by peer)
02:21:55 *** gelignite is now known as Guest3128
02:22:00 *** gelignite has joined #openttd
02:29:08 *** Guest3128 has quit IRC (Ping timeout: 480 seconds)
03:25:01 *** gnu_jj_ has quit IRC (Ping timeout: 480 seconds)
03:46:31 *** debdog has quit IRC (Ping timeout: 480 seconds)
04:19:25 *** gelignite has quit IRC (Quit: Stay safe!)
04:44:05 <DorpsGek> - Update: Translations from eints (by translators)
05:58:52 *** tokai|noir has joined #openttd
05:58:52 *** ChanServ sets mode: +v tokai|noir
06:05:43 *** tokai has quit IRC (Ping timeout: 480 seconds)
06:20:52 *** ialokin has joined #openttd
08:13:02 <kuhnovic> xarick: That's great news. Last time you found path issues pretty much right away. Thanks for having a look!
10:43:36 *** kuka_lie has joined #openttd
11:19:15 <truebrain> lol, that moment you find out that the spaces alone are 20% of your filesize
11:19:22 <truebrain> maybe this JSON file doesn't have to be -that- human readable ๐
11:25:40 <Rubidium> though what's the difference in compressed file size?
11:25:53 <truebrain> these files aren't compressed, so not relevant to my use-case to answer that ๐
11:30:39 <truebrain> the "human readable" part in that story isn't unimportant ๐
11:30:39 <peter1138> Nothing will possibly go wrong.
11:36:50 <truebrain> grrr, I rerun a summary report, and it gives me different results ..
11:36:52 <truebrain> where did I mess up ....
11:38:06 <truebrain> at least found one bug I can understand
11:40:22 <truebrain> ah, I found why the results are different ... I was typing the wrong characters in my CLI command ๐
11:40:42 <truebrain> you would think I should be capable by now of typing the right letters
11:41:28 <Rubidium> you are capable... most of the time ;) I've got the same issue :(
11:42:24 <truebrain> now to find out how to report that in a slightly nicer way ๐
12:04:52 <truebrain> based on snippet of a few weeks ago
12:18:29 <peter1138> The more I look at it, the more this is just weird...
12:19:02 <truebrain> another data-set. I have much more data, but I am having trouble getting that in the poorly-constructed HTML+CSS we call OpenTTD's design ๐
12:19:29 <truebrain> for example, which exact version was used, and the authors of the NewGRF, that kinda stuff
12:19:35 <truebrain> but it is annoying to fiddle that in .. hmm
12:19:46 <peter1138> Percentage based on NewGRF feature set...
12:20:30 <peter1138> Is that 21% of game-hours use ISR?
12:21:06 <truebrain> it is the exact same as any other statistic in the survey ๐
12:21:26 <truebrain> so yes, ISR, in this week for this OpenTTD version, was used in 21% of the playtime we recorded
12:22:04 <truebrain> also means no GRF will ever be above the "100 - (no-grf-games)" percentage
12:22:57 <truebrain> I think this is the most fair way to present this data, and in line with all other information we show. But I am totally open for other ideas ๐
12:26:09 <andythenorth> or Looker Studio? ๐
12:26:34 <andythenorth> do we have an OpenTTD Google account? ๐
12:45:12 <truebrain> owh joy, the contentID for AIs is not reported, but the actual name. This will be "fun" ...
12:57:45 <truebrain> owh, even better ... we get reported the numeric AI version number, but BaNaNaS indexes the human readable version number
12:57:49 <truebrain> those two don't always match, ofc ๐
12:58:10 <truebrain> why do we report it like this? ๐
12:58:42 <truebrain> because the crashlog did that already, and I didn't give it any real thought
13:00:32 <truebrain> but it also means I have no way to check popularity of AIs in the same way as I can do NewGRFs .. I can only do a bit of fuzzy matching, which in 99% of the cases will be correct
13:00:36 <truebrain> and someone will bitch about that 1% ๐
13:08:54 <truebrain> anyway, peter1138, am I right to assume that your silence means you also don't know anything better to use to represent "popularity" of NewGRFs? ๐
13:11:58 <peter1138> I didn't realise there was a question.
13:12:20 <truebrain> you said it looked weird! So I said I was open for other ideas ๐
13:12:20 <peter1138> Game-hours is fine, it's not subjective.
13:12:36 <peter1138> No, that was some code.
13:12:42 <truebrain> lol, context is everything ๐
13:13:04 <peter1138> smallmap_gui.cpp:1647 if you want to know.
13:13:13 <peter1138> This is "definitely" how switches should be used.
13:14:45 <truebrain> oof, uploading to BaNaNaS doesn't even check if your AI version is unique
13:14:57 <truebrain> we made a bit of a mess with all this AI/GS stuff you know ๐
13:16:47 <peter1138> "It works, ship it!"
13:17:14 <truebrain> I was clearly a lot younger ๐
13:20:26 *** Wolf01 is now known as Guest3168
13:23:52 <truebrain> well, at least some basic information I can extract from the surveys
13:23:58 <truebrain> (again, random week, random version)
13:25:53 *** Guest3168 has quit IRC (Ping timeout: 480 seconds)
13:27:53 *** tokai|noir has quit IRC (Quit: c('~' )o)
13:29:10 <truebrain> okay ... "good enough" for now, I guess
13:30:31 <kuhnovic> Is this based on existing data that previously wasn't shown in the surveys?
13:31:53 <truebrain> I added in there, as I believe it is vastly more valuable to see how much a GRF is actually used, versus what people wanted: download counters, etc
13:32:02 <truebrain> as those download counters are pointless numbers ๐
13:32:28 <truebrain> but processing this survey information has been .. tricky ๐
13:32:40 <truebrain> but I think I have something that works now ๐
13:33:08 <truebrain> let's see how a quarter-report looks like
13:36:11 <kuhnovic> It looks nice. Actual time played is a much better number than download count.
13:37:01 <truebrain> I do wonder if I should mention all GRFs, or put a treshold on it, like I do with settings
13:37:12 <truebrain> just if less than 0.1% of the games are played with the GRF, it is not reported?
13:37:18 <truebrain> meh, takes effort, and solves little
13:37:23 <truebrain> btw, only GRFs that are on BaNaNaS show up
13:37:34 <truebrain> to avoid leaking information about private GRFs etc
13:38:23 <kuhnovic> How many GRFs show up in the quality report? It might become quite a long list if there's no threshold
13:38:42 <truebrain> running a quarter report now, but .. it takes a bit of time ๐
13:38:52 <truebrain> been running for 10 minutes already ๐
13:39:23 <truebrain> it is a long list, but not unreasonably long
13:39:39 <kuhnovic> truebrain: You could create a "other / unknown" entry. Gives us some idea of how many people are using non-bananas content.
13:39:42 <truebrain> ISR was by far the most popular for Q3 ๐
13:40:36 <peter1138> Are you sure the NewGRF stats are right? I've been told before that most players are using either AXIS or XIS industry sets.
13:41:01 <peter1138> Maybe it was some ... extrapolation.
13:41:20 <truebrain> I am like 80% sure the stats are correct ๐
13:41:44 <truebrain> JGRPP listing is totally different from vanilla
13:41:45 <peter1138> Must be wrong, everyone uses JGRPP ๐
13:41:47 <truebrain> but that is no real surprise ๐
13:42:04 <truebrain> but even in JGRPP, 60% of the playtime used ISR ๐
13:42:24 <peter1138> So basically I should avoid breaking ISR.
13:42:24 <_jgr_> ISR is a rail station set, I'm not to surprised that its popular
13:42:38 <truebrain> good; those are the things I like to hear _jgr_ ๐
13:42:50 <truebrain> JGRPP 2024 Q3 report
13:43:23 <truebrain> it feels reasonable, but .. what do I know ๐
13:43:36 <truebrain> ` Road Stops & Waypoints (JGRPP)` is at 34.5% for that same report
13:43:58 <truebrain> so at least the split between vanilla and jgrpp seems to work as expected ๐
13:47:26 <_jgr_> truebrain: That looks pretty plausible to me
13:47:48 <truebrain> ugh, more issues with AI/GS ... the name as used on BaNaNaS often doesn't match the name used in the script
13:48:09 <truebrain> so I can't resolve one to the other ...
13:48:36 <peter1138> Hmm, fix the system to use content ID and ignore the existing stats?
13:48:50 <truebrain> yeah ... it is a bit silly, we send the AI name, instead of the AI shortname
13:48:57 <truebrain> the shortname is the contentID (4 characters)
13:49:06 <truebrain> so not sure what went on here, but it is all a bit meh ๐
13:49:11 <peter1138> (Or fix the system to use content ID and try to mangle the existing results)
13:49:43 <truebrain> `Town and Industry Control` vs `Town & Industry Control`
13:50:13 <peter1138> Urgh, STRING1 etc are now bugging me more and more.
13:50:29 <peter1138> I need STRINGmightbe1butcouldbe0.
13:51:12 <peter1138> Or I have to include a dummy parameter, and remember to include those wherever it might be needed.
13:51:46 <peter1138> Or perhaps treat the parameter count is... flexible, and ignore the problem.
13:52:32 <truebrain> ah, right, BaNaNaS has issues analyzing the AI bundles, as you can do nasty things in Squirrel
13:52:40 <truebrain> so BaNaNaS can't really analyze the content of an AI that well
13:53:54 <truebrain> okay ... and now the main question: should I be publishing these popularity data in the first place? ๐
13:55:54 <peter1138> Does it help? Does it change anything?
13:56:29 <talltyler> I agree that this fulfills the โshow download countโ request from authors, and also tells us what we shouldnโt break with changes to cargo handling, etc. saves Peter from trawling bananas trying to figure out whatโs popular ๐
13:57:15 <peter1138> Okay, maybe if trying to read past the end of the parameters just treats it an invalid parameter, instead of asserting.
13:58:16 <peter1138> Can Bananas tell us how many Chinese forums there are?
14:03:29 <peter1138> Hmm, lenient seems to work, but kinda feels wrong.
14:04:04 <peter1138> Well, onto figuring out news messages
14:04:28 <truebrain> my fuzzy matching of AI scripts seem to somewhat work
14:04:43 <peter1138> Did you use AI to...
14:04:57 <peter1138> Ok this is not right.
14:05:33 <peter1138> Supposed to be cargo type.
14:05:34 <truebrain> `Peaks and Troughs v2`
14:05:34 <truebrain> There are some I simply can't match without getting too fuzzy .. on BaNaNaS, this is called `Peaks and Troughs`, but marked as version 2 ..
14:09:07 <talltyler> Probably not relevant to matching version numbers, but Peaks and Troughs is JGRPP-only
14:11:01 <_glx_> peter1138: for GS if there's a mismatch between STRINGX and the number of given parameters, it fills with 0 if needed
14:11:20 <peter1138> On the encoding side, yeah.
14:11:26 <peter1138> I'm not encoding here thoughj.
14:12:36 <_glx_> yeah openttd can be more strict, as "we" are supposed to properly use strings
14:14:38 <peter1138> My 'issue' is that something like
14:14:38 <peter1138> GetString(STR_NEWGRF_SETTINGS_PARAMETER, STR_JUST_RAW_STRING, GRFBuildParamList(c));
14:14:38 <peter1138> GetString(STR_NEWGRF_SETTINGS_PARAMETER, STR_NEWGRF_SETTINGS_PARAMETER_NONE);
14:15:28 <peter1138> With strict consumption, the second one needs to be ```c++
14:15:28 <peter1138> GetString(STR_NEWGRF_SETTINGS_PARAMETER, STR_NEWGRF_SETTINGS_PARAMETER_NONE, 0 /* dummy parameter */);
14:16:23 <peter1138> There are alternative ways that could work here, though.
14:16:27 <_glx_> I guess it should check it has at least the required number
14:16:56 <peter1138> I can't make GetString check (at compile time) that there are enough parameters for a string ID.
14:18:29 <peter1138> One such alternative is to make this particular one always use raw strings...
14:18:29 <peter1138> GetString(STR_NEWGRF_SETTINGS_PARAMETER, GRFBuildParamList(c));
14:18:29 <peter1138> GetString(STR_NEWGRF_SETTINGS_PARAMETER, GetString(STR_NEWGRF_SETTINGS_PARAMETER_NONE));
14:18:33 <_glx_> yeah compile time check is hard
14:19:19 <peter1138> What I've actually done is made parameter consumption not care if the number of supplied parameters is correct.
14:19:55 <peter1138> It will give a run-time error only if the string tries to use the missing parameters.
14:21:12 <peter1138> To do compile-time sets, strgen could probably output a header of each string and the number of parameters it requires. And then some magic templating could pull that in and change.
14:21:35 <peter1138> Does not work if the first parameter is a variable.
14:21:42 <peter1138> And I'm not going to do this ๐
14:21:46 <truebrain> lol .. if many entries in the same savegame can't be resolved via BaNaNaS, the stats get a bit weird ๐
14:22:55 <_glx_> the typical case to catch is "not enough args", too many is less an issue
14:23:26 <_glx_> depends on context for too many of course
14:23:37 <peter1138> In this case STR_NEWGRF_SETTINGS_PARAMETER has a STRING1
14:23:45 <peter1138> So providing only 1 argument is "an error"
14:24:08 <_glx_> it's an error if the arg is actually accessed
14:24:11 <peter1138> But it's actually the first argument that needs (or not needs) the additional parameter, not the initial string.
14:25:10 <peter1138> Except before my changes it's an assert before it gets to even using the parameter.
14:25:22 <peter1138> (It works with global parameters because there's always 20 of them)
14:25:35 <_glx_> you are using per substring params ?
14:27:13 <peter1138> No, That would effectively be my "alternative" above.
14:27:48 <peter1138> That requires changing lots of strings from STRINGx to RAW_STRING.
14:27:52 <peter1138> Doable but a big task.
14:30:48 <_jgr_> Changing STRING parameters to RAW_STRING could also break the gender/case stuff for non-English languages
14:41:47 <_glx_> oh and some translations use indirect substring params for gender/plural like `{P 0:2 ...}`
14:42:15 <peter1138> Okay, so the way I've gone is better, \oi/
14:46:54 <truebrain> I splitted the NewGRFs per set
14:46:58 <truebrain> that looks a lot more useful ๐
14:47:20 <michi_cc> Hmm, so strgen should produce something like this in the header?
14:47:20 <michi_cc> struct String<STR_NEWGRF_SETTINGS_PARAMETER> {
14:47:21 <michi_cc> using Params = std::tuple<StringID, int>;
14:47:21 <peter1138> Ooh, you have that information easily available? Nice.
14:47:35 <_glx_> ah yes we know the types from the bananas filtering
14:47:39 <truebrain> You can do it michi_cc , just a few more edits to go ๐
14:48:20 <truebrain> (IRC is now: wtf is going on; no worries, it wasn't for you ๐ )
14:48:27 <michi_cc> I had those at first, but it didn't show the formatting preview... ๐คฃ
14:49:18 <truebrain> If you use triple ` followed by cpp, you get:
14:49:18 <truebrain> struct String<STR_NEWGRF_SETTINGS_PARAMETER> {
14:49:19 <truebrain> using Params = std::tuple<StringID, int>;
14:50:31 <peter1138> Something like that. And then Xarick can complain about the compile time a bit more ๐
14:50:56 <_glx_> only if you touch english.txt ๐
14:51:19 <michi_cc> You need to use `GetString<STR_NEWGRF>()` then though. Not really usable for runtime string decisions.
14:52:04 <peter1138> EncodedString headline;
14:52:04 <peter1138> if (str > STR_LAST_STRINGID) {
14:52:04 <peter1138> headline = GetEncodedString(str, STR_TOWN_NAME, i->town->index, indspec->name);
14:52:04 <peter1138> } else if (closeit) {
14:52:05 <peter1138> headline = GetEncodedString(str, STR_FORMAT_INDUSTRY_NAME, i->town->index, indspec->name);
14:52:08 <peter1138> headline = GetEncodedString(str, i->index);
14:52:10 <peter1138> This is particularly gnarly.
14:52:35 <peter1138> I don't like that I don't actually know what str is here.
14:53:25 <peter1138> And str comes from the industry spec anyway, so knowing doesn't help.
14:55:31 <_glx_> ha yes `> STR_LAST_STRINGID` can be anything from newgrf to GS
14:56:56 <_glx_> good luck to validate it has a {STRING1} and an {STRING}
14:59:18 <_glx_> second case needs a {STRING2}, and last one is {INDUSTRY}
15:01:21 <peter1138> Oh no, SurveyRecentNews() needs the string id. :S
15:01:37 <truebrain> but does it actually? ๐
15:02:01 <peter1138> Might just be that that was easier than setting up the parameters...
15:09:20 <peter1138> Cool, my news messages work again.
15:13:10 <truebrain> and cool, my `(other)` also works, to somewhat limit the output of NewGRF sets with a lot of 0.0% ๐
15:14:50 <_glx_> 0.0% still means used ๐
15:15:01 <truebrain> yeah, hence the `(other)` ๐
15:15:06 <truebrain> (as we already do with all settings)
15:15:17 <truebrain> okay, like 95% of the content is on BaNaNaS
15:15:48 <_glx_> do we have baseset stats ?
15:16:05 <truebrain> they are in there, I don't index them yet
15:16:13 <truebrain> good that you mention it ... let's see if I can add them easily too ..
15:16:26 <truebrain> this "owh, let's take 2 hours to fix this" is taking a lot longer ๐
15:17:38 <_glx_> I hope they are mostly original/opengfx[2] but...
15:19:03 <peter1138> Loads of zbase from the tutorial followers
15:19:13 <truebrain> yup, lot of zbase ....
15:26:07 <andythenorth> deprecate zbase ๐
15:28:40 <_glx_> hey andythenorth you saw #348 ?
15:30:59 <talltyler> andythenorth: Nah, ship OGFX2 with OpenTTD and depreciate tutorials that tell you to install a base set to โfixโ the โbad graphicsโ of OpenTTD
15:32:13 <talltyler> I would like to have an in-game tutorial someday, but man is that a lot of work. Thereโs a tutorial GS thatโs pretty good, but it only covers road vehicles, ships, and aircraft. Trains are the hardest part for people.
15:33:05 *** kuka_lie has quit IRC (Quit: leaving)
15:33:10 <_glx_> tutorial GS needs update every time GUI changes
15:33:20 *** kuka_lie has joined #openttd
15:33:35 <truebrain> (random week in 2024)
15:35:13 <truebrain> sadly, linking to BaNaNaS is hard for these too, as here too we give the name ๐
15:35:21 <truebrain> which is okay-ish for graphics
15:35:25 <truebrain> but for music is it .... yeah, it is
15:36:04 <truebrain> I also have the version information, but I grown to actually hate Jekyll very much
15:36:08 <truebrain> so I am going to leave it at this ๐
15:36:17 <truebrain> but know that there are still some people using rather old OpenGFX versions ๐
15:37:34 <truebrain> this creates a lot more HTML than I expected it would ๐ Lolz
15:40:46 <truebrain> the manager-version is only seen for those that update the content; but feel free to make a PR to adjust the confusion ๐
15:40:57 <truebrain> download-url is never anything except `None` btw ๐
15:42:22 <truebrain> so PR it already, instead of complaining about it ๐ ๐
15:42:44 <_glx_> should we just remove download-url handling ?
15:42:53 <_glx_> I don't see it coming back
15:43:28 <truebrain> As Cloudflare is now sponsoring us, on a technical level I have no issues reinstating it. But honestly, it has been pretty nice to not have it
15:43:43 <truebrain> lot less question about: I extracted the tar file, and now nothing works!
15:43:45 <truebrain> and stuff like that
15:44:08 <truebrain> but for a PR to fix the above, I would just focus on the thing at hand, and make the manager html look more like the non-manager
15:44:19 <truebrain> in other words: I would just leave it for now; it doesn't do anything, but doesn't hurt anyone either
15:45:11 <truebrain> a clear case of too little copy/paste ๐
15:55:03 <andythenorth> Hmm we could redo our html and css
15:55:58 <truebrain> sadly the "the site should also work without Javascript" wish makes it hard to pick a modern framework ๐
15:59:06 <truebrain> Bit of NextJS, React and Mantine would make it quick to build something new and pretty .. but getting pure HTML out of that is tricky ๐ SSR? ๐
16:01:41 <andythenorth> the 2 winning JS-independent frameworks are Bootstrap and the other one
16:03:01 <peter1138> And Boostrap is annoying
16:03:10 *** virtualrandomnumber has joined #openttd
16:03:48 <peter1138> Um, okay, I've done something that puts OpenTTD into a hard spin.
16:10:39 *** Wormnest has joined #openttd
16:12:16 <truebrain> oof, generating the survey website now takes a bit longer .. "a bit" ๐
16:12:52 <truebrain> I think I have pushed Jekyll too much ๐
16:14:15 <peter1138> Does it take longer than the reporting interval?
16:14:46 <truebrain> 129s to render the site, lol
16:16:22 <peter1138> This type of news is not quite working correctly.
16:17:07 <truebrain> right .. I tihnk that should be it. It takes a few minutes to generate a preview, so dinner first ๐
16:17:38 <peter1138> Dunno what this was doing a minute ago but recompiling seems to have fixed it.
16:28:01 <peter1138> Detangling SetupSubsidyDecodeParam now.
16:34:02 <andythenorth> approve and merge 348? ๐
16:35:56 <truebrain> Preview for #55 is ready; if any of you wouldn't mind giving it a look, to see if it all looks correct and well. Not the code perse, more the resulting HTML ๐
16:49:55 <_glx_> oh of course Dockerfile for bananas are "wrong"
16:56:19 <peter1138> The subsidy strings are a bit odd.
16:57:59 <peter1138> Parameters 3 and 6 are never assigned, which suggests that the STRING2s should be STRING1.
16:58:42 *** virtualrandomnumber has quit IRC (Quit: virtualrandomnumber)
17:00:23 <_glx_> maybe they were at some point
17:23:50 <_glx_> #344 needs a rebase andythenorth
17:29:43 <peter1138> (Never mind that normally you'd say "12 minute subsidy")
17:30:50 <peter1138> I'm not sure this entire function is necessary any more, mind you.
17:42:26 *** thurus0909 has joined #openttd
17:46:01 <peter1138> Ok, it's better without, imho.
17:49:23 <peter1138> Still some SetDParam left :S
17:49:39 <peter1138> Crap I gotta fix new company news.
18:01:30 <andythenorth> good to have info
18:01:36 <andythenorth> too many people using FIRS 1 ๐
18:04:52 <peter1138> Very few original graphics users ๐ฎ
18:07:30 <truebrain> also any feedback on the text and layout? Or is it good as it is? ๐
18:07:36 <truebrain> "good enough", I guess ๐
18:08:57 <truebrain> code-wise it is messy, but .. Jekyll is just being shit
18:09:11 <truebrain> issue on my side btw, for not actually understanding Jekyll ๐
18:12:27 <pickpacket> And I forgot: what does "(other)" mean in the percentage count?
18:13:28 <_glx_> "(other)" merges all 0.0%
18:13:34 <truebrain> pickpacket: there is a header on that page; you could read that ๐
18:15:38 <pickpacket> truebrain: You assume I can read? ๐คช How very bold of you
18:15:48 <truebrain> I know right! Such a novel concept ๐
18:17:18 <truebrain> now with tested github workflows ๐
18:17:35 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
18:22:39 <_glx_> maybe it's possible to add a `title` attribute for (other)
18:23:04 <truebrain> as in, adding the attribute is easy ๐
18:23:13 <truebrain> owh, it is mentioned in the header
18:23:18 <truebrain> if people don't read that, will they read a tooltip? ๐
18:23:24 <peter1138> title="It means everything else, why is that even a question?"
18:23:52 <truebrain> it is a lot of extra bytes (like a lot a lot) for that once-in-a-year question ๐
18:24:18 <truebrain> as you have to repeat it for every `(other)` entry ๐ฆ
18:24:22 <truebrain> stupid HTML, and lack of pointers
18:25:39 <truebrain> Jekyll 4.3.3 can use Ruby 3.0 .. Jekyll 44.3.4 cannot
18:25:52 <truebrain> You got to love "patches" that require total bump of everything in existence ๐
18:26:17 <_glx_> ah yes worse than the multiple blocks of ~400 lines with only leading spaces ๐
18:26:23 <pickpacket> truebrain: besides, that once-in-a-year question is always gonna be me anyway
18:26:48 <truebrain> pickpacket: Nah; most likely next year it is me, asking myself that same question ๐
18:26:55 <_glx_> (I blame the tool for these lines)
18:27:27 <truebrain> (it is why I wrote it in the header, as I keep forgetting what rule it follows ๐ )
18:27:43 <pickpacket> truebrain: I LOVE the NewGRF stats!
18:28:07 <truebrain> in that case, time to merge it to production ๐
18:28:08 <pickpacket> Also: holy cow, people are actually USING one of my NewGRFs???
18:28:26 *** gelignite has joined #openttd
18:28:48 <pickpacket> truebrain: yes, it was my permission you awaited all along
18:29:10 <truebrain> I do appreciate confirmation of work, so kinda ๐
18:29:17 <truebrain> The threshold was 3, and it was reached ๐
18:30:11 <truebrain> did I just use `feat:` as prefix? I clearly haven't done enough OpenTTD in a long while
18:30:58 <truebrain> let's hope this "just works"?
18:33:11 <truebrain> That at least works ๐
18:35:59 <truebrain> _glx_: let me bump bananas-frontend-web to Python 3.11, and fix the build issues while doing so
18:36:18 <_glx_> yeah I noticed the annoying Dockerfile
18:42:17 <truebrain> does GitHub already have public arm runners?
18:44:50 <truebrain> but running this locally is also easy btw
18:48:37 <_glx_> ah yes "new-game" is not configurable by manager anyway IIRC
18:48:48 <truebrain> that once was planned
18:49:02 <peter1138> If Andy's MBP runs our infrastructure, that can also be our ARM runner ๐
18:49:09 <_glx_> I think there's an open issue to remind it ๐
18:59:15 <pickpacket> truebrain: 3 is roughly 2 more than I expected :D
19:36:48 <xarick> 32% no sound, 35% no music, that is wild
19:47:52 <peter1138> Nice. Finally. No hacky GetParams...
19:48:51 <wensimehrp> xarick: No planes, no trains...
19:52:28 *** xarothbrook has joined #openttd
19:52:28 <xarothbrook> xarick: OpenTTD has sound?
19:52:39 <_jgr_> xarick: I'd expect that a large chunk of the OpenSFX/OpenMSX users have the volume sliders turned to 0 even if they haven't removed the actual sound/music
19:54:00 <truebrain> we should add volume to the survey results, you say?
20:00:46 <pickpacket> I used to have music now and then, but for some reason it stopped working for me ๐คท
20:01:01 <pickpacket> I just have it turned off now
20:01:17 <pickpacket> but no sound effects
20:06:31 <peter1138> My sound baseset is not on Bananas.
20:06:58 <peter1138> Opus version of original sounds ๐
20:07:00 *** kuka_lie has quit IRC (Quit: Lost terminal)
20:17:30 <peter1138> Ok, settings dparams, deep in the depths of ini files ๐
20:21:33 <andythenorth> peter1138: got ยฃ400 for my i9 from music magpie
20:22:09 <andythenorth> "could buy a pi"
20:22:34 <peter1138> pi 500, then it can do double duty as CI infrastrcture AND a desktop workhorse.
20:25:55 <andythenorth> "the keyboard is the computer"
20:36:52 *** gelignite has quit IRC (Quit: Stay safe!)
20:45:36 <peter1138> I can make settings work with std::string instead of dparam, but that point about genders/cases...
20:48:10 *** Wormnest has joined #openttd
20:49:08 <truebrain> _glx_: I added the preview label; takes a bit of time, but then you can check if it actually works etc ๐
20:49:57 <_glx_> I pushed, then dinner, and forgot about the label
20:51:25 <_glx_> I can only check non manager pages as I don't have any content ๐
20:51:41 <truebrain> I just uploaded random content to check out these things ๐
20:52:30 <truebrain> I changed the title slightly
20:52:37 <truebrain> as I consider these things a bug to be fixed ๐
20:52:45 <truebrain> do with that what-ever you want ๐ Preview looks good ๐
21:07:58 <peter1138> Hmm, EncodedString.Add?
21:08:26 <peter1138> std::vector<StringParameter> would probably be fine.
21:56:30 <peter1138> Commit early, commit often... horrible mess to clean up.
22:09:41 <peter1138> > 170 files changed, 3142 insertions(+), 3621 deletions(-)
22:11:43 *** nielsm has quit IRC (Remote host closed the connection)
22:15:26 <peter1138> That's with all global parameters removed.
22:15:56 <peter1138> But I know for sure this series of commits won't work serially.
22:50:33 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:53:49 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
continue to next day โต