IRC logs for #openttd on OFTC at 2024-11-24
⏴ go to previous day
02:32:15 *** ChanServ sets mode: +v tokai
02:39:09 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
03:08:24 *** godbed_ has joined #openttd
03:11:21 *** D-HUND has quit IRC (Ping timeout: 480 seconds)
03:11:46 *** debdog has quit IRC (Ping timeout: 480 seconds)
04:46:39 <DorpsGek> - Update: Translations from eints (by translators)
06:05:42 <peter1138> xarick: Don't forget to reserve
07:31:46 <peter1138> How many strings does Iron Horse have... Hmm.
07:36:55 <peter1138> How many languages...
07:53:34 <peter1138> Hmm, how do you get 10k strings from 630?
07:53:41 <peter1138> Some composition going on?
07:57:53 <peter1138> Well anyway, 10k strings is the total number of base language strings, the translations are ... sideways on that.
07:58:20 <peter1138> So 18*630 being in the ballpark is just coincidence.
08:13:34 <peter1138> Extract all your extra text compoents into badges.
08:17:56 <michi_cc[d]> Text stack is probably an area where NML really could be more "meta", but I don't have any idea how that could work 😦
08:59:29 <peter1138> Have you confused your git tree?
09:00:30 <peter1138> Have you got confused by your git tree?
09:05:24 *** nielsm has quit IRC (Ping timeout: 480 seconds)
09:38:14 <peter1138> Oh, Iron Horse doesn't even use regular language files...
09:40:21 <peter1138> [STR_POWER_SOURCE_METRO]
09:42:04 <peter1138> Train is powered by...
10:42:45 <xarick> i'm being spammed by cancelled workflows... what is that?
10:54:04 <Rubidium> for OpenTTD's github the configuration is to cancel a build when it's already superseded by another commit. So if two merges happen in quick succession, we don't run two complete builds; we just cancel the first build
11:20:20 <peter1138> I'm always confused when you ask questions about changes but also approve...
11:21:45 <peter1138> Hmm, maybe not confused, more conflicted.
11:29:01 <LordAro> peter1138: "should only block the merge if you think it's relevant" is usually how i apply it
11:31:45 <xarick> crap, river generation still disconnected
11:34:37 <xarick> How am I going to fix this
11:37:56 <xarick> I don't have the required experience to deal with "what would they look like after terraform"
11:38:16 <xarick> "and if it looks bad, don't do it"
11:42:20 <peter1138> Why is it disconnected? Was it created and then raised, or not created?
11:43:57 <xarick> interesting question, i changed terraform to bail out if it's gonna destroy water, so in theory this shouldn't happen
11:44:07 <xarick> need to investigate better
11:53:25 <xarick> let me check what happens if I skip the entire makewider proc
11:56:46 <Rubidium> peter1138: exactly as LordAro interprets it. It's like: "have you considered this approach/idea, but doing it this way is fine by me too; it's your call". If something really concerns me, I wouldn't have approved it.
12:00:17 <xarick> this thing is widening after the path is found
12:00:34 <xarick> or i dunno, this is complicated
12:01:48 <peter1138> Not sure if 13112 closes any issue.
12:03:54 <xarick> it's imbued in River_FoundEndNode
12:04:38 <xarick> yeah, it finds the path, then starts building the river tiles and at the same time, for each river tile it places, it widens the river
12:05:54 <xarick> i suspect terraform is ruining the path->parent that is yet to be iterated
12:06:26 <xarick> terraform passes because it can't know if a future tile is part of the path
12:09:02 <xarick> then again, this river gen stuff just builds rivers for each height plane
12:09:33 <xarick> it doesn't have the path for the entire river from spring to sea
12:10:04 <xarick> only from this height layer to the next height layer
12:20:26 <xarick> interesting build order
12:20:54 <xarick> places rivers starting from sea, up to spring
12:24:59 <peter1138> So widening terraformed a tile that would result in water being removed.
12:34:46 <xarick> im absolutely confused in the ordering of river building
12:35:40 <peter1138> Pfft, scrap the lot and create an flow and erosion-based system...
13:08:42 *** bigyihsuan has joined #openttd
13:08:42 <bigyihsuan> peter1138: If this would lead to rivers actually following valleys closely I'm all for it
13:55:41 <xarick> I almost forgot FlowRiver is recursive
14:00:20 <xarick> River_FoundEndNode is messy
14:00:25 <xarick> someone should clean up
14:02:21 <xarick> I wonder why cur_pos was forgotten
14:17:03 <peter1138> Hmm, minor performance regression with #13058, presumably due to the "does the data exist" checks.
14:50:12 <peter1138> 15 days slower after 16 months of Wentbourne
15:17:56 <xarick> but the comment is misleading
15:18:09 <xarick> maybe it's not this one, let me check
15:18:38 <xarick> ah, right, desired slope is not flat, it's not here
15:19:16 <xarick> desired_slope is inclined
15:21:05 <xarick> can't be fixed without knowing future river tiles in advance
15:21:35 <xarick> all these checks for making sure it's not destroying river tiles are pointless
15:21:58 <xarick> well, not entirely pointless, but...
15:32:25 <xarick> lowers the corner indicated in the image, which will affect a future begin
15:33:37 <xarick> even with terraform set to DC_NO_WATER, it will execute the command because there is currently no water at "future begin"
15:38:53 <xarick> hmm I have a weird solution
15:40:13 <xarick> collect all "begin" and "ends" from each height change
15:41:31 <xarick> prebuild water on them, have the rivermakewider now know that there are untouchable river tiles
15:42:06 <xarick> river remains connected, though thinner in some parts
15:58:21 *** godbed is now known as debdog
16:31:23 <peter1138> Okay, how do I say this code is bad and I don't like it... in a professional way?
16:39:19 <LordAro> peter1138: you give reasons why :p
16:39:42 <xarick> eh... im in need of not adding duplicate tiles
16:43:02 <peter1138> `if (decimal.Compare(amount, decimal.Zero) == 0)`
16:46:30 <peter1138> Personally I'd use `if (amount == 0)`
16:47:06 <LordAro> at least it's not something like `!= 1`
17:06:55 <mnhebi> Reminds me of A-Train..
17:43:00 <locosage> peter1138: more map zoom?
17:59:56 <xarick> uh... it worked? Looks ugly though
18:03:03 <xarick> side by side comparison
18:06:56 <xarick> I'd like to pass the vector as a reference, but i'm too dumb for that
18:18:07 <peter1138> xarick: Does it need to modify the contents?
18:19:14 <xarick> I'd like 1 river, 1 vector, and by river, i mean starting from spring, ending at sea (or at another river)
18:19:47 <xarick> currently I got it 1 river, whatever number of vectors per FlowDown
18:20:11 <xarick> if it flows down twice, I get 2 vectors
18:23:31 <xarick> I guess it's okay the way I got it to work, but ideally I would be cleaning the vector once it is starting to build the river tiles
18:24:19 <xarick> but since it's not a unique vector, what happens is that it will attempt to rebuild the river tiles from the previous height level
18:25:48 <xarick> static void BuildRiver(TileIndex begin, TileIndex end, TileIndex spring, bool main_river, std::vector<TileIndex> &begin_end_points) hmm maybe this is what I need
18:26:29 <xarick> static std::tuple<bool, bool> FlowRiver(TileIndex spring, TileIndex begin, uint min_river_length, std::vector<TileIndex> &begin_end_points = { }) but I can't do reference here
18:28:17 <xarick> ``` /* Flow further down hill. */
18:28:17 <xarick> if (begin_end_points.empty()) begin_end_points.push_back(begin);
18:28:17 <xarick> begin_end_points.push_back(end);
18:28:17 <xarick> std::tie(found, main_river) = FlowRiver(spring, end, min_river_length, begin_end_points);```
18:37:31 <xarick> copilot actually understands my gibberish
18:43:04 <_glx_> maybe one day you'll understand the code you write 🙂
18:43:36 *** gelignite has joined #openttd
18:59:08 <johnfranklin> Why are some Japanese webpages unreadable on Microsoft Edge Mobile, but readable on Edge Desktop?
18:59:44 <johnfranklin> Or it is because my phone doesn’t support SHIFT-JIS or something similar? Weird…
19:01:33 <xarick> `std::deque<TileIndex> &begin_end_points; ///< Collection of all begin and end points for each flow for the entire river.`
19:09:46 <peter1138> Woah, someone actually uses Edge on Desktop... and also uses Edge on Mobile?
19:18:31 <dwfreed> post-chromium Edge is not the worst thing in the world
20:08:57 <wensimehrp> johnfranklin: Fonts probably
20:09:34 <wensimehrp> Android uses noto, idk what apple uses
20:55:02 <xarick> reinterpret_cast<void *> why does copilot change things...
21:08:54 <xarick> I wanna... still make rivers wide when entering sea
21:09:22 <xarick> an idea is to not have sea while generating rivers
21:09:58 <xarick> let the terraform be free to do what it needs at that point, but requires even more adaptation of the code 😦
21:14:38 <xarick> there are 3 places calling ConvertGroundTilesIntoWaterTiles
21:29:03 *** toktik has quit IRC (Remote host closed the connection)
22:00:27 *** gelignite has quit IRC (Quit: Stay safe!)
22:16:29 *** nielsm has quit IRC (Ping timeout: 480 seconds)
22:23:23 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:24:02 *** digitalsoma has joined #openttd
22:24:02 <digitalsoma> Sorry if this is the wrong place to ask, but I am trying to get things set up for the first time. I have CMake and vcpkg. I have installed the 5 dependent libraries into my vcpkg\installed\x64-windows-static\lib directory. Yet, when I open the openttd directory with VS Code, CMake throws warnings saying that the dependent libraries are not provided. How do I point CMake to the libraries?
22:35:24 <_glx_> you need to set VCPKG_TARGET_TRIPLET else cmake will look for x64-windows
22:37:29 <_glx_> but you should not need to install any vckpg libs, cmake handles the installation
22:38:46 <_glx_> I think you also need to set CMAKE_TOOLCHAIN_FILE to <vcpkg_dir>/scripts/buildsystems/vcpkg.cmake
22:48:35 <digitalsoma> _glx_: Hm, that's not what the compiling.md says. And is the CMAKE_TOOLCHAIN_FILE in the CMake directory or the openttd directoy?
22:48:47 <xarick> im crashing on world gen
22:49:23 <digitalsoma> I'm using Windows 10 64-bit
22:51:54 <xarick> a world gen crash and it's not any helpful
22:52:08 <xarick> don't know what crashed
22:55:13 <peter1138> Formatting a string.
22:58:34 <xarick> how do i generate world singlethreaded?
22:58:45 <xarick> or is that no longer possible?
23:06:27 <peter1138> Means you have passed something invalid.
23:06:44 <peter1138> Could be you've got a reference wrong and are corrupting memory.
23:08:33 <xarick> well, I crashed, but then fmt also crashed when trying to do something related with chrono
23:10:08 <xarick> trying to get subsecs?
23:13:42 <peter1138> Follow the back trace.
23:16:39 <xarick> (not) working as intended!
23:22:04 <xarick> there is no meaningfull call stack
23:24:45 <xarick> openttd.exe!fmt::v10::detail::tm_writer<std::back_insert_iterator<fmt::v10::basic_memory_buffer<char,500,std::allocator<char>>>,char,std::chrono::duration<__int64,std::ratio<1,1>>>::on_second(fmt::v10::detail::numeric_system ns, fmt::v10::detail::pad_type pad) Line 1563
23:24:45 <xarick> at E:\OpenTTD Visual Studio\SamuXarick\OpenTTD\src\3rdparty\fmt\chrono.h(1563)
23:26:40 <xarick> "crash encountered, generating crash log" in the debug window then it crashed at generating the log
23:29:07 <xarick> i found where this text is printed
23:30:30 <xarick> if (ep->ExceptionRecord->ExceptionCode == EXCEPTION_STACK_OVERFLOW) {
23:34:06 <xarick> i think my deque is broken
23:34:39 <xarick> or something else, cus im experimenting dumb stuff such as no sea during river gen
23:34:51 <xarick> I'll check this tomorrow
continue to next day ⏵