IRC logs for #openttd on OFTC at 2024-11-22
#openttd / 2024 / 11 
            

00:02:36  <peter1138> Is the address a memory pointer address? Because outputing that seems not ideal.



00:28:55  <_glx_> it's the default tostring() result



00:29:49  <_glx_> but I don't thing many will use other than strings or numbers as possible key



00:29:58  <_glx_> my test was a weird one



00:30:32  <peter1138> e.g. fmt::to_string requires you do cast a pointer to `void *`, which also means you know you've cast to `void  *` and don't accidentally do it.



00:31:00  <_glx_> it does `str = fmt::format("({} : 0x{:08X})",GetTypeName(o),(size_t)(void*)_rawval(o));`



00:32:32  <_glx_> https://github.com/OpenTTD/OpenTTD/blob/master/src/3rdparty/squirrel/squirrel/sqvm.cpp#L265-L297



00:32:56  <_glx_> it's really a fallback for uncommon



00:33:13  <_glx_> still better than a crash 🙂



00:37:20  <masterhellish> talltyler: Getting my current save. Changing it to scn. And then loading it as play scenario, seams to have fixed the issue



02:29:00  <talltyler> Glad to hear it! Yes, the periods won’t match the years since you got them out of sync while playing. Ordinarily they’ll start at 1 in wallclock mode.



02:32:38  *** tokai|noir has joined #openttd



02:32:38  *** ChanServ sets mode: +v tokai|noir



02:39:19  *** tokai has quit IRC (Ping timeout: 480 seconds)



03:10:15  *** D-HUND has joined #openttd



03:10:33  *** godbed_ has joined #openttd



03:13:45  *** debdog has quit IRC (Ping timeout: 480 seconds)



03:13:54  *** godbed has quit IRC (Ping timeout: 480 seconds)



05:08:40  *** keikoz has joined #openttd



06:10:49  *** Flygon has joined #openttd



07:41:06  *** XYZ has quit IRC (Ping timeout: 480 seconds)



08:43:58  *** godbed_ has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)



08:48:09  <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13115: Codechange: Shuffle Engine members around to reduce size. https://github.com/OpenTTD/OpenTTD/pull/13115



08:52:07  *** Smedles has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)



08:53:23  *** Smedles has joined #openttd



09:03:19  *** D-HUND is now known as debdog



09:06:18  <LordAro> i wonder if there's a tool out there to reduce padding automatically



09:06:51  <LordAro> obviously wouldn't be able to do enum resizing, etc



09:10:06  <peter1138> Not that I know of.



09:10:38  <peter1138> Even my tools to show the padding are either not built into my IDE, or are not very usable.



09:11:02  <peter1138> clangd gives me member size, position and padding, but only when hovering over each member.



09:11:52  <peter1138> On the other hand pahole gives me an analysis, but works on the compiled output so any need to wait for a compile to see the change.



09:44:23  <xarick> playing tetris?



09:44:35  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1309454472761577532/image.png?ex=6741a402&is=67405282&hm=1b4f8af8751757753ed07f3613d547e7a6cfb4ca120cc86f8d730d60f62464c5&



09:44:35  <xarick> I found holes



09:47:36  <LordAro> nice



09:48:25  <LordAro> requiring a compiled output isn't exactly surprising given the padding is completely compiler dependent



09:48:38  <LordAro> not that it varies all that much on the same architecture



09:56:26  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1309457456262418463/image.png?ex=6741a6ca&is=6740554a&hm=45f80b6f0667d39da9076cf10e253f588cd82f920c1bd7b70d931f44551f2a25&



09:56:26  <xarick> wow, my megastructure is big



09:57:41  <LordAro> an array of fixed size is big, yeah



09:57:57  <LordAro> @calc 21120/240



09:57:57  <DorpsGek> LordAro: 88



09:58:14  <xarick> 88



09:59:19  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1309458180379643934/image.png?ex=6741a776&is=674055f6&hm=11b2fffdc4b3fcef4eb01d894a381eaec5afeb779b3892b5f209e336c64bda60&



10:00:35  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1309458502451855420/image.png?ex=6741a7c3&is=67405643&hm=5b480753c76e0f80783bbe100c2de4674a41ce17e9224698ead195c247efe484&



10:00:35  <xarick> very neat stuff



10:14:03  *** debdog has quit IRC (Quit: Initiating getting-the-hell-out-of-here maneuver!)



10:16:13  <DorpsGek> [OpenTTD/team] KevinHeijsteeg2 opened issue #600: [nl_NL] Translator access request https://github.com/OpenTTD/team/issues/600



10:30:57  <xarick> oops, something's broken



10:31:09  <xarick> getting mismatch in the number of generated industries



10:39:45  <peter1138> fast path mismatch?



10:46:21  <peter1138> xarick: I want this tool :S



10:48:05  <xarick> Microsoft Visual Studio



10:49:30  <peter1138> Yeah that's not happening.



11:03:24  <xarick> i failed somewhere and I know not where



11:03:33  <xarick> time to duplicate code



11:50:50  <xarick> mystery solved



11:51:06  <xarick> wrong parameter being fed to a function 🙂



11:52:57  <xarick> wrong: ```std::vector<IndustryID> nearby_industries = Industry::FindContained(tile, type, dmax);```



11:52:57  <xarick> correct: ```std::vector<IndustryID> nearby_industries = Industry::FindContained(tile, conflicting_type, dmax);```



11:57:46  <xarick> new record!



11:57:48  <xarick> [2024-11-22 11:56:39] dbg: [misc:0] [GenerateIndustries] 70302603 us [avg: 70302603.0 us]



11:57:51  <xarick> 70 seconds



11:57:59  <xarick> old record was 75



11:59:13  <DorpsGek> [OpenTTD/team] glx22 commented on issue #600: [nl_NL] Translator access request https://github.com/OpenTTD/team/issues/600



12:02:08  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13115: Codechange: Shuffle Engine members around to reduce size. https://github.com/OpenTTD/OpenTTD/pull/13115#pullrequestreview-2454264465



12:03:21  <xarick> wow, another new record



12:03:23  <xarick> [GenerateIndustries] 69341151 us



12:11:02  <peter1138> Marginal gains.



12:11:16  <peter1138> Ultegra vs Dura-ace.



12:29:23  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1309495948115836928/image.png?ex=6741caa3&is=67407923&hm=2ae8dd94ec3beb4ba1e6b4b895717c4f9d71b75d30724e7e1fcd7856e8df8993&



12:30:07  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1309496132702830602/image.png?ex=6741cacf&is=6740794f&hm=fe20d398e974530cdc128120842fbe58764b0e86a2ecaf7952fa5b5401387340&



12:30:26  <xarick> can I PR?



12:32:50  <xarick> against #13094



12:50:04  <peter1138> PRs need to be against master.



13:02:21  *** debdog has joined #openttd



13:06:22  <peter1138> Yes, we need to review the changes.



13:43:35  <xarick> feels like cheating when I ask copilot to generate the commit messages for me



13:44:06  <kuhnovic> The cafetaria at work offered hamburger with fries. I couldn't resist.



13:44:44  <kuhnovic> xarick: Half of your code is written by copilot, but the commit message is the part that makes it feel like cheating 😛 ?



14:20:55  *** kuka_lie has joined #openttd



14:24:02  *** Compu has joined #openttd



14:24:59  *** Compu has quit IRC ()



14:32:02  <xarick> copilot got stuck



14:32:05  <xarick> 😦



14:33:30  <kuhnovic> You broke it



14:40:29  <xarick> Not sure I wanna merge all 4 commts



14:41:09  <xarick> I do one thing then undo it to do a melding



14:44:07  <xarick> what I have done first: added new kdtree functionality, second, added town industry pairs to enhance 2 industry function checkups, third: added kdtree to enhance 2 other functions, fourth: kinda of undo second and third to meld into a single structure.



14:45:40  <xarick> I don't know what's the correct flow for this...



15:03:39  <LordAro> we generally squash-merge anyway, so as long as each commit is suitably named it doesn't really matter



15:18:25  *** Compu has joined #openttd



15:22:09  *** nielsm has joined #openttd



15:37:06  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13112: Change: Show company finances column if it has any values in it. https://github.com/OpenTTD/OpenTTD/pull/13112#issuecomment-2494043420



15:41:34  *** merni has quit IRC (Quit: User went offline on Discord a while ago)



15:48:38  <peter1138> Wrong ping.



15:58:41  *** HerzogDeXtEr has joined #openttd



16:09:58  *** tokai has joined #openttd



16:09:58  *** ChanServ sets mode: +v tokai



16:16:31  *** tokai|noir has quit IRC (Ping timeout: 480 seconds)



16:58:11  *** CompuDesktop has joined #openttd



16:58:41  *** CompuDesktop has quit IRC ()



16:59:55  *** Compu has quit IRC (Ping timeout: 480 seconds)



17:05:15  <xarick> not sure I go with Player facing change



17:05:42  <xarick> you can definitely feel it being faster at generating industries



17:08:59  <LordAro> generally we don't changelog performance improvements



17:09:02  <LordAro> arguably we should



17:09:25  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on issue #13044: [Crash]: when playing TTO savegame from #5965 due to a regression https://github.com/OpenTTD/OpenTTD/issues/13044



17:11:53  <talltyler> peter1138: Is [#13022](https://github.com/OpenTTD/OpenTTD/issues/13022) actually a scaling bug, or intended behavior for the scrollbar? I am triaging the issue tracker. 🙂



17:13:45  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler closed issue #12926: [Crash]: It crashes immediately upon launch. https://github.com/OpenTTD/OpenTTD/issues/12926



17:13:48  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on issue #12926: [Crash]: It crashes immediately upon launch. https://github.com/OpenTTD/OpenTTD/issues/12926



17:14:47  <peter1138> It's a "when scrollbars were designed it wasn't anticipated they could ever handle so many rows"



17:15:02  <peter1138> It's on my list of things to look into some day.



17:15:22  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on issue #13000: [Crash]: Unhandled exception in ottd:game thread: [json.exception.type_erro.316] invaild UTF-8 byte at index 41: 0xB4 https://github.com/OpenTTD/OpenTTD/issues/13000



17:15:36  <peter1138> (It's absoluetely nothing to do with interface scaling)



17:16:07  <peter1138> ((Even spelling correctly))



17:18:11  <talltyler> "Doctor, it hurts when I buy 5,000 road vehicles"



17:18:49  <DorpsGek> [OpenTTD/OpenTTD] telk5093 commented on issue #13000: [Crash]: Unhandled exception in ottd:game thread: [json.exception.type_erro.316] invaild UTF-8 byte at index 41: 0xB4 https://github.com/OpenTTD/OpenTTD/issues/13000



17:20:21  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler closed issue #13000: [Crash]: Unhandled exception in ottd:game thread: [json.exception.type_erro.316] invaild UTF-8 byte at index 41: 0xB4 https://github.com/OpenTTD/OpenTTD/issues/13000



17:20:24  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on issue #13000: [Crash]: Unhandled exception in ottd:game thread: [json.exception.type_erro.316] invaild UTF-8 byte at index 41: 0xB4 https://github.com/OpenTTD/OpenTTD/issues/13000



17:26:07  *** Wolf01 has joined #openttd



17:28:58  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler closed issue #13080: [Bug]: Train does not find way into "Zugdepot" https://github.com/OpenTTD/OpenTTD/issues/13080



17:29:01  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on issue #13080: [Bug]: Train does not find way into "Zugdepot" https://github.com/OpenTTD/OpenTTD/issues/13080



17:43:36  <DorpsGek> [OpenTTD/OpenTTD] James103 closed issue #13044: [Crash]: when playing TTO savegame from #5965 due to a regression https://github.com/OpenTTD/OpenTTD/issues/13044



17:43:39  <DorpsGek> [OpenTTD/OpenTTD] James103 commented on issue #13044: [Crash]: when playing TTO savegame from #5965 due to a regression https://github.com/OpenTTD/OpenTTD/issues/13044



17:50:19  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13083: Industry transported graph https://github.com/OpenTTD/OpenTTD/pull/13083#pullrequestreview-2455193814



17:54:40  *** Compu has joined #openttd



17:56:38  *** Compu has quit IRC ()



17:59:06  <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #13116: Codechange: Enhance industry count management and add KD-Trees https://github.com/OpenTTD/OpenTTD/pull/13116



17:59:17  <xarick> yyay



17:59:43  <xarick> commit checker already



18:02:15  <xarick> it can see what I don't



18:04:30  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13094: Codechange: Speed up industry generation using industry-type checks. https://github.com/OpenTTD/OpenTTD/pull/13094#pullrequestreview-2455282662



18:10:43  <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13116: Codechange: Enhance industry count management and add KD-Trees https://github.com/OpenTTD/OpenTTD/pull/13116



18:37:08  *** gelignite has joined #openttd



18:52:14  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13094: Codechange: Speed up industry generation using industry-type checks. https://github.com/OpenTTD/OpenTTD/pull/13094#pullrequestreview-2455390220



18:56:08  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13094: Codechange: Speed up industry generation using industry-type checks. https://github.com/OpenTTD/OpenTTD/pull/13094#pullrequestreview-2455398630



18:57:50  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13094: Codechange: Speed up industry generation using industry-type checks. https://github.com/OpenTTD/OpenTTD/pull/13094#pullrequestreview-2455404728



19:00:40  <xarick> 😐



19:36:02  <xarick> I failed successfully?



19:47:09  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13083: Add: Transported data to Industry production graph https://github.com/OpenTTD/OpenTTD/pull/13083



19:51:52  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1309607303577866291/image.png?ex=67423258&is=6740e0d8&hm=09beb67ee9acbdf6afc8d83fe07ea5d3a414c0e874cc1d4aa106830ed5c25fb4&



19:51:52  <xarick> I didn't change cargo distribution settings



19:51:59  <xarick> something else is changing them



19:52:37  <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13113: Fix #13110: [Script] convert table keys to string when generating JSON https://github.com/OpenTTD/OpenTTD/pull/13113#pullrequestreview-2455516704



19:58:21  *** gelignite has quit IRC (Remote host closed the connection)



20:04:23  *** gelignite has joined #openttd



20:21:53  <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #13083: Add: Transported data to Industry production graph https://github.com/OpenTTD/OpenTTD/pull/13083#pullrequestreview-2455566627



20:27:20  *** kuka_lie has quit IRC (Quit: quiting for this day see you tomorrow)



20:39:41  <xarick> deleting branches, I got too many



20:42:11  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13083: Add: Transported data to Industry production graph https://github.com/OpenTTD/OpenTTD/pull/13083#pullrequestreview-2455606192



20:46:12  <peter1138> Switch has at least one case that is too long: .



20:46:13  <peter1138> D'OH!



20:47:55  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13083: Add: Transported data to Industry production graph https://github.com/OpenTTD/OpenTTD/pull/13083



20:48:32  <LordAro> lol



20:50:08  <talltyler> https://cdn.discordapp.com/attachments/1008473233844097104/1309621967573225553/produced.png?ex=67424000&is=6740ee80&hm=f73504d08c02a7588b4a0737a8467e7accf664321ab414257b27e60db8c517f3&



20:50:08  <talltyler> Useful graph, need more trains



20:51:42  <talltyler> I love the emscription preview 😄



20:52:26  <talltyler> https://cdn.discordapp.com/attachments/1008473233844097104/1309622544193818684/ai.png?ex=6742408a&is=6740ef0a&hm=79d9a36a21cf3979df44942edda6588f036985c6744c1193c6801ec9b5b22c74&



20:52:26  <talltyler> Just AI things



21:14:17  <xarick> an elusive conflict <https://github.com/OpenTTD/OpenTTD/pull/13038>



21:18:42  <_glx_> the switch has been moved and replaced by a function



21:19:43  <_glx_> it's now in ConvertRailTypes()



21:25:52  <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13038: Codechange: Use Map::Iterate() to iterate tiles https://github.com/OpenTTD/OpenTTD/pull/13038



21:30:38  *** Flygon has quit IRC (Read error: Connection reset by peer)



21:35:57  <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12097: Change: [Script] Improve some ScriptAirport return values for AT_OILRIG airport type https://github.com/OpenTTD/OpenTTD/pull/12097



21:38:14  <xarick> no more conflicts



21:38:21  *** debdog has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)



21:38:25  <xarick> just 2



21:38:35  *** debdog has joined #openttd



22:00:39  *** nielsm has quit IRC (Ping timeout: 480 seconds)



22:06:31  <xarick> deleted about 30 branches



22:16:23  <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1309643671569698917/image.png?ex=67425437&is=674102b7&hm=051c175ae046cd9120bd4258ec5c8d1b52e121744f9c272ba33d56b5667a1a14&



22:16:23  <peter1138> Ploop



22:18:46  <talltyler> Valuables are counted in town stats?



22:19:40  <talltyler> Graphing population and houses is a nice feature 🙂



22:21:21  <peter1138> Swedish Houess has a Bank that is a house instead of an industry.



22:21:55  <peter1138> So it accepts and produces valuables that way.



22:23:43  <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1309645517122179083/image.png?ex=674255ef&is=6741046f&hm=b1bb236ea231db97e5f03917e141cdad2af4ab01b6ff75c0325aa068b051ac1a&



22:23:43  <peter1138> Population needs a different scale though, tbh.



22:24:23  <peter1138> Probably works better as a different graph entirely.



22:31:03  <peter1138> Hmm, it's not really that interesting, tbh.



22:31:19  <peter1138> At least not over monthly periods.



22:33:25  <belajalilija> I’m not at my PC right now so idk if this is already a feature



22:33:39  <belajalilija> But it would be nice to be able to change the scale of graphs



22:34:14  <belajalilija> So we could see them update monthly rather than quarterly or see more than 2 years in the past



22:37:44  <belajalilija> It’s not like “i think we need this” like how i feel about fully customisable company colours or functional steering wagons but more “that’d be neat”, idk



22:37:58  <peter1138> We don't have rrdtool, sadly.



22:38:10  <belajalilija> Rrdtool?



22:38:47  *** gelignite has quit IRC (Quit: Stay safe!)



22:38:54  <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1309649337659428936/image.png?ex=6742597e&is=674107fe&hm=ff9d7f267901d698a460b9905a32240612f7329cabf7b7281aa5b3ad6be1987b&



22:38:54  <peter1138> One of these AIs is not like the others.



22:39:46  <LordAro> odd



22:40:13  <belajalilija> peter1138: 🤔 maybe



22:40:19  <peter1138> Well, many AIs get rather upset if mail is missing.



22:40:29  <xarick> that's the ... hmm forgot about



22:40:53  <xarick> the time issue can't recall



22:41:00  <xarick> AIs dont handle that too well



22:41:51  <peter1138> belajalilija: A graphing tool perfect for storing data over different periods. Traditionally used for networking graphing at 5 minute sampling for years of data. As the data gets older is stores hourly, daily, monthly, etc.



22:43:17  <xarick> ah, Timekeeping issue for AIs



22:43:27  <xarick> use Calendar time mode



22:43:39  <_glx_> it's not an issue if they don't mix oranges with apples



22:44:44  <peter1138> JGRPP uses 2-day sampling for station cargo waiting, IIRC.



22:44:52  <peter1138> Which is a lot of data.



22:45:01  <peter1138> Or rather, doesn't go back very far.



22:45:01  <_glx_> documentation now mentions if a function returns calendar or econmy



22:45:35  <belajalilija> peter1138: I don’t fully understand this but i assume that the gist is “it’s not reasonably feasible”



22:45:43  <peter1138> Anyway, stats uses memory. Adding more stats uses more memory.



22:45:56  <peter1138> For normal size maps it's fine.



22:46:39  <peter1138> Although for company data it's probably fine, there's only ever 15 of them.



22:47:52  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1309651595427844156/image.png?ex=67425b98&is=67410a18&hm=de11a01f628eee2c71c153fc3839264ff11d3fe5e30fda54bf9ae3cd0701be76&



22:47:52  <xarick> found some strange desert blocks during map generation



22:53:12  <peter1138> Probably feasible for companies to store more data, but not really for towns, stations and industries.



22:58:41  *** keikoz has quit IRC (Ping timeout: 480 seconds)



23:05:41  <peter1138> Shall I dish out some conflicts?



23:17:28  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13094: Codechange: Speed up industry generation using industry-type checks. https://github.com/OpenTTD/OpenTTD/pull/13094



23:20:26  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13115: Codechange: Shuffle Engine members around to reduce size. https://github.com/OpenTTD/OpenTTD/pull/13115



23:37:35  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13082: Codechange: Store animated tile state in map to improve performance. https://github.com/OpenTTD/OpenTTD/pull/13082



23:48:47  <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13115: Codechange: Shuffle Engine members around to reduce size. https://github.com/OpenTTD/OpenTTD/pull/13115#pullrequestreview-2456025219



23:58:16  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13115: Codechange: Shuffle Engine members around to reduce size. https://github.com/OpenTTD/OpenTTD/pull/13115