⏴ go to previous day
02:09:36  *** gnu_jj has joined #openttd

02:12:46  *** gnu_jj_ has quit IRC (Ping timeout: 480 seconds)

02:16:49  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13030: Codechange: Simplify storage of WaterTileType in map. https://github.com/OpenTTD/OpenTTD/pull/13030#pullrequestreview-2397022026

02:39:05  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13023: Codefix: Correct handling of GetDepotOrderType() comparison https://github.com/OpenTTD/OpenTTD/pull/13023#pullrequestreview-2397024915

02:52:30  *** D-HUND has joined #openttd

02:52:35  *** Zathras has joined #openttd

02:55:53  *** godbed has quit IRC (Ping timeout: 480 seconds)

02:55:58  *** debdog has quit IRC (Ping timeout: 480 seconds)

03:42:40  *** debdog has joined #openttd

03:42:44  *** godbed has joined #openttd

03:46:03  *** D-HUND has quit IRC (Ping timeout: 480 seconds)

03:46:08  *** Zathras has quit IRC (Ping timeout: 480 seconds)

04:03:47  *** gnu_jj_ has joined #openttd

04:07:09  *** gnu_jj has quit IRC (Ping timeout: 480 seconds)

04:21:08  *** keikoz has joined #openttd

05:23:57  *** keikoz has quit IRC ()

05:24:40  *** Flygon has joined #openttd

05:27:15  *** keikoz has joined #openttd

06:20:55  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #12918: Fix #12914: Fix use of invalidated pointer in viewport drawer. https://github.com/OpenTTD/OpenTTD/pull/12918#pullrequestreview-2397060948

06:22:08  *** Wolf01 has joined #openttd

06:28:50  *** debdog has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)

06:35:06  *** nielsm has joined #openttd

07:44:49  *** TinoDid|znc has joined #openttd

07:45:06  *** TinoDidriksen has quit IRC (Ping timeout: 480 seconds)

07:46:22  *** TinoDid|znc is now known as TinoDidriksen

08:21:50  <peter1138> Hmm, now I'm questioning what I wrote there, which is the correct response.

08:22:59  <peter1138> Ah, precisely because it's `>= 0` instead of `!= LAST_CHILD_PARENT`

08:24:36  <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #12918: Fix #12914: Fix use of invalidated pointer in viewport drawer. https://github.com/OpenTTD/OpenTTD/pull/12918#pullrequestreview-2397060948

08:24:39  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #12918: Fix #12914: Fix use of invalidated pointer in viewport drawer. https://github.com/OpenTTD/OpenTTD/pull/12918

08:33:26  *** gelignite has joined #openttd

08:38:36  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #12918: Fix #12914: Fix use of invalidated pointer in viewport drawer. https://github.com/OpenTTD/OpenTTD/pull/12918#pullrequestreview-2397077761

08:51:40  *** reldred has quit IRC (Quit: User went offline on Discord a while ago)

08:57:11  *** SigHunter has quit IRC ()

08:57:32  *** HerzogDeXtEr has joined #openttd

08:59:52  *** SigHunter has joined #openttd

09:17:33  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13030: Codechange: Simplify storage of WaterTileType in map. https://github.com/OpenTTD/OpenTTD/pull/13030#issuecomment-2439444294

09:17:47  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13030: Codechange: Simplify storage of WaterTileType in map. https://github.com/OpenTTD/OpenTTD/pull/13030

09:42:37  *** gelignite has quit IRC (Quit: Stay safe!)

09:48:15  <xarick> oh noes water tile type is merged and i missed it

09:50:16  <peter1138> "Oh no"

09:53:52  <peter1138> Compilation-wise, `IsCoast()`  is basically the same, before it optimised down to `m5 & 0xF1 == 0x01`, now it is just `m5 & 0xF0 == 0x10`.  `GetWaterTileType()` is a bit different though.

09:54:18  <peter1138> (With clang anyway)

09:54:35  <peter1138> gcc was a bit worse before.

09:55:12  <peter1138> GetWaterTileType is now just a shift right by 4 🙂

09:56:07  <peter1138> Not having a NOT_REACHED() in there probably helps.

09:58:54  <xarick> a futuristic new depot flag

10:00:38  <peter1138> Oof, yeah, with the NOT_REACHED() in place, the before and after for IsCoast is not similar at all.

10:01:31  <peter1138> With the NOT_REACHED() there the high bits of m5 always mattered.

10:02:01  <xarick> there are 4 lock orientations

10:02:07  <xarick> and 2 ship depot

10:02:51  <peter1138> And?

10:03:13  <xarick> i dunno, need to look at my notes

10:03:18  <xarick> from years ago

10:03:28  <peter1138> I have not touched those bits, only changed the documentation to match how its read.

10:06:03  <xarick> okay found it

10:07:49  <xarick> i'll try to write down this into a .txt file

10:09:02  <xarick> the first 4 bits determine the type, depot, lock or clear, the other 4 bits meaning depends on what type was set in the first 4

10:13:19  <peter1138> No need to write it down, it's in landscape.html.

10:37:38  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1299683352521084938/image.png?ex=671e17f2&is=671cc672&hm=858c2cd06b17f74223686c98cc66bc705def6d58a8c529faab783f7352b69cf9&

10:37:38  <xarick> think this is it

10:37:48  *** herms61 has quit IRC (Ping timeout: 480 seconds)

10:38:35  <peter1138> Not any more.

10:39:05  <xarick> 😦

10:39:43  <xarick> oh it's missing one entry in the lock

10:43:22  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1299684794208223343/image.png?ex=671e1949&is=671cc7c9&hm=ed818ac02276c00f0d72f4ec802c239c7768e84c086fa347f1a92078c7a0beb9&

10:43:39  <peter1138> No need to post it again, it's still wrong.

10:43:58  <xarick> what happened

10:44:18  <xarick> 6 5 were recovered?

10:44:26  <peter1138> #13030 happened.

10:50:03  <peter1138> Good old write-only-Xarick...

10:51:30  <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13023: Codefix: Correct handling of GetDepotOrderType() comparison https://github.com/OpenTTD/OpenTTD/pull/13023

10:52:45  <xarick> gonna see what it is now

10:53:31  <_glx_> It's almost the same as before, only some bits in M5 have changed

10:53:55  <_glx_> No effect on usage

10:55:16  <_glx_> And html doc is easier to read

10:55:16  *** herms61 has joined #openttd

11:07:57  <xarick> ah I see

11:08:14  <xarick> uses 2 bits for the type

11:08:33  <xarick> and the coast is now a type 😮

11:09:19  <xarick> bits 7 and 6 are freed

11:10:07  <xarick> or not?

11:10:16  <peter1138> Technically although I left it as 4 bits.

11:23:07  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1299694799888060497/image.png?ex=671e229b&is=671cd11b&hm=601b3453c0bbe87b3b0910695372dd9039f7b93adfb6fbc8faed4b45236cc009&

11:23:07  <xarick> kinda like this?

11:23:29  <xarick> but 4 bits

11:23:33  <xarick> for thetype

11:24:34  <xarick> just anticipated 2 bits

11:27:15  <peter1138> No.

11:27:36  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1299695928344842240/image.png?ex=671e23a8&is=671cd228&hm=0d4ab67f46476635afd9bc1d5202189ec37f2ee8c83b4eeca5983d144ec55202&

11:27:36  <xarick> oh, they're O's, not zero's

11:27:47  <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1299695973395861585/image.png?ex=671e23b3&is=671cd233&hm=5e8d3dfef4f12d48417e70d4f068c9b7ff4d853a94df82720ad76a4089a8e65c&

11:27:47  <peter1138> Like this.

11:28:58  <peter1138> It really isn't complicated, it's really very minor, and it doesn't particularly need any analysis.

11:32:53  <xarick> I would free those 2 bits

11:32:57  <xarick> more bits, more fun

11:33:21  <xarick> unless something future future

11:36:12  *** godbed is now known as debdog

11:43:35  *** gelignite has joined #openttd

12:01:30  *** nielsm has quit IRC (Remote host closed the connection)

12:04:58  *** wallabra has quit IRC (Ping timeout: 480 seconds)

12:19:55  *** wallabra has joined #openttd

12:51:27  *** Flygon has quit IRC (Read error: Connection reset by peer)

12:57:50  <xarick> you typed a 0 instead of an O

12:58:42  <xarick> https://github.com/OpenTTD/OpenTTD/commit/4f9c10d35f46b5c2592a85ab1eff6c4f17d0f17f#diff-1867e5088e3a019c5fc79ca3bfc60f784154ac4cd0f61809dcba4162a0db060cR249

13:02:45  <xarick> btw in the conversion, aren't you clearing the coast bit?

13:02:52  <xarick> the old one

13:07:02  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1299720951835136010/image.png?ex=671e3af6&is=671ce976&hm=e03bd89f11b22aa762d6bf28096dd53a39fc95f7ddd0eb4683034b1324a4afa5&

13:07:02  <xarick> yep, you didn't clear it

13:07:54  <xarick> should be 0001 0000

13:18:59  <_glx_> doesn't really matter

13:19:26  <_glx_> last bit has no meaning

13:44:16  <peter1138> Stupid mouse. Put a different battery in it and all 4 power LEDs lit up.

13:44:18  <peter1138> But very dim.

13:44:33  <peter1138> Because the battery was not charged.

13:56:37  <peter1138> LLM-generated replies spreading on them there forums...

13:58:42  <peter1138> Such time... <https://www.youtube.com/watch?v=-N-CjHJEX9c>

13:59:03  <peter1138> (How the London skyline has changed in 30 years, by train)

14:05:22  <peter1138> I think I last used Waterloo in 2000 so I guess more like 1994 than 2024.

14:15:30  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #12918: Fix #12914: Fix use of invalidated pointer in viewport drawer. https://github.com/OpenTTD/OpenTTD/pull/12918#pullrequestreview-2397261738

14:24:45  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #12918: Fix #12914: Fix use of invalidated pointer in viewport drawer. https://github.com/OpenTTD/OpenTTD/pull/12918

14:24:48  <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #12914: [Bug]: AddChildSpriteToFoundation can cause a use after free via ViewportDrawer::last_child https://github.com/OpenTTD/OpenTTD/issues/12914

14:24:49  <peter1138> "yolo"

14:28:03  <xarick> I wanna find asserts

14:30:56  <Rubidium> `grep -R 'assert' src` ;)

14:31:39  <xarick> i expect the new rubidium code to assert in... coal mine subsidence, let's test

14:32:42  <xarick> there's other cases I found

14:34:25  <xarick> oh wow, got one already on map generation

14:34:31  <xarick> that was fast

14:35:01  <xarick> setupfarmfieldfence

14:35:41  <xarick> mind if I post asserts I've found on your PR?

14:36:52  <xarick> the solution I went with was to use AddTileIndexDiffCWrap, but in your version I guess that's TileAddWrap if it exists

14:37:20  <xarick> not sure if it accounts for void tiles

14:38:00  <Rubidium> xarick: no, please add them

14:52:26  <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13031: Codechange: Don't use enums for non-enumerated values. https://github.com/OpenTTD/OpenTTD/pull/13031

14:55:03  <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #12996: Codechange: use different structure for TileIndexDiff in debug https://github.com/OpenTTD/OpenTTD/pull/12996#issuecomment-2439609203

14:55:58  <peter1138> Yeah, this is a result of thinking about "What can we easily make `enum class`?" and did, indeed, also lead to my WaterTileType change.

14:58:01  <xarick> there may be more asserts that are yet uncovered

14:58:25  <peter1138> Posting them with the PR is the correct thing to do.

15:31:39  *** TinoDid|znc has joined #openttd

15:32:00  *** TinoDidriksen has quit IRC (Read error: Connection reset by peer)

15:33:31  *** TinoDid|znc is now known as TinoDidriksen

15:34:58  <xarick> Can't use TileAddWrap

15:36:48  <xarick> it's slightly different than the result of TileIndexDiffCWrap 😦

15:37:28  <xarick> how's it gonna be solved?

15:39:59  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #12996: Codechange: use different structure for TileIndexDiff in debug https://github.com/OpenTTD/OpenTTD/pull/12996#issuecomment-2439625087

15:43:48  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #12996: Codechange: use different structure for TileIndexDiff in debug https://github.com/OpenTTD/OpenTTD/pull/12996#pullrequestreview-2397280978

15:53:32  <ian01223> for those of you keeping count at home, factorio is now up to 101k concurrent players on steam...

15:54:01  <_glx_> I tried something https://github.com/OpenTTD/nml/compare/master...glx22:nml:include, works better than I expected

15:58:03  *** TinoDidriksen has quit IRC (Ping timeout: 480 seconds)

15:59:50  <xarick> pfff 😦

16:01:14  <xarick> what do I post? the stack trace for everyone of them?

16:01:28  <xarick> call stack

16:02:31  <xarick> some of my findings were me really trying hard to see if it would assert

16:02:51  <_glx_> the call location should be enough

16:04:03  <xarick> ok

16:08:52  <_glx_> maybe with the values if needed

16:09:15  *** TinoDidriksen has joined #openttd

16:09:36  <xarick> wondering if there's a way to show/hide text with the markdown syntax

16:09:46  *** TinoDidriksen is now known as Guest7521

16:09:48  <xarick> otherwise it's gonna be a really long reply

16:14:15  *** Guest7521 is now known as TinoDidriksen

16:16:50  <peter1138> If there are that many asserts you could just say what settings you used to produce them.

16:18:07  <xarick> the assert is always in the same place

16:18:24  <xarick> because boundaries are now properly checked

16:39:22  <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #12996: Codechange: use different structure for TileIndexDiff in debug https://github.com/OpenTTD/OpenTTD/pull/12996#issuecomment-2439647683

16:44:49  <xarick> I can confirm #2 happens, haven't confirmed the others, do I really need test cases?

16:45:45  <xarick> they happened when I was testing on my code 😦

16:46:57  <xarick> it's not all that dissimilar to rubidium's approach, just uglier

16:51:58  *** HerzogDeXtEr1 has joined #openttd

16:53:15  <peter1138> > mind if I post asserts I've found on your PR?

16:53:54  <peter1138> To anyone sane, this means asserts that have triggered when running the PR. Not theoretical asserts that you triggered in a different set of changes.

16:58:54  *** HerzogDeXtEr has quit IRC (Ping timeout: 480 seconds)

17:18:17  <xarick> I need to hunt for them

17:18:25  <xarick> they don't just happen...

17:18:44  <xarick> sometimes they are repeats

17:24:15  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13031: Codechange: Don't use enums for non-enumerated values. https://github.com/OpenTTD/OpenTTD/pull/13031

17:55:29  <xarick> found a 13th

18:00:48  <xarick> dinner, afk

18:09:23  <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic requested changes for pull request #13019: Codechange: Code style issues in water regions https://github.com/OpenTTD/OpenTTD/pull/13019#pullrequestreview-2397314295

18:12:09  <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13032: Fix: SkipGarbage() skipped all multi-byte utf-8 characters. https://github.com/OpenTTD/OpenTTD/pull/13032

18:40:34  <xarick> I really thought it was clearer

18:47:55  <xarick> TWaterRegionPatchLabel NumberOfPatches()

18:47:55  <xarick> or

18:47:55  <xarick> int NumberOfPatches()

18:52:00  <xarick> it's confusing

18:53:16  <peter1138> Focus on the right things.

18:53:20  <peter1138> T is the wrong prefix.

18:53:30  <peter1138> It's nothing to do with template parameters.

18:56:03  <xarick> well the others are also T

18:56:33  <xarick> TWaterRegionTraversabilityBits GetEdgeTraversabilityBits

18:56:47  <xarick> TWaterRegionPatchLabel GetLabel

18:57:13  <peter1138> That's what I said.

18:58:43  <xarick> I don't get it

18:59:30  <xarick> you want me to take the T out of these names?

19:09:51  <peter1138> No, I'm just saying the T is wrong.

19:11:16  <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13019: Codechange: Code style issues in water regions https://github.com/OpenTTD/OpenTTD/pull/13019

19:12:03  <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1299812808564670616/voice-message.ogg?ex=671e9082&is=671d3f02&hm=e7538c8fe6f4c27d2f17d1868ad7ded654ecef35d32cafa6cd31494340716183&

19:14:28  <xarick> i feel i'm doing something wrong

19:16:14  <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13019: Codechange: Code style issues in water regions https://github.com/OpenTTD/OpenTTD/pull/13019

19:16:38  <xarick> I can't make sense of number_of_patches

19:18:22  <xarick> not sure I turn it into a int

19:19:15  <xarick> there's mixed usage of int and TWaterRegionPatchLabel

19:19:40  <xarick> I turned all into TWaterRegionPatchLabel

19:19:48  <xarick> but now I reverted, and now I'm confused again 🙂

19:21:57  <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #13032: Fix: SkipGarbage() skipped all multi-byte utf-8 characters. https://github.com/OpenTTD/OpenTTD/pull/13032#pullrequestreview-2397334260

19:22:18  <_glx_> the filtering is weird, but it should work

19:23:22  <peter1138> It's specific characters to limit things like "!!! BEST SERVER FIRST"

19:24:11  <_glx_> yeah and `;` could be used to abuse database

19:26:32  <peter1138> I don't think that affects sorting 🙂

19:26:51  <peter1138> SkipGarbage isn't used for anything else.

19:30:29  <_jgr_> _glx_: I have a hard time imagining   that the server side implementation would fall for basic stuff like that

19:34:42  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13032: Fix: SkipGarbage() skipped all multi-byte utf-8 characters. https://github.com/OpenTTD/OpenTTD/pull/13032#issuecomment-2439713721

19:36:14  <_glx_> I mean it removes all punctuation except ':', and it also keeps 0x7F which is a control char

19:38:46  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13032: Fix: SkipGarbage() skipped all multi-byte utf-8 characters. https://github.com/OpenTTD/OpenTTD/pull/13032#issuecomment-2439714846

19:43:22  <xarick> `this->data.number_of_patches = static_cast<decltype(this->data.number_of_patches)>(highest_assigned_label);` am I being dumb?

19:52:36  <xarick> ```TWaterRegionPatchLabel number_of_patches = 0; // 0 = no water, 1 = one single patch of water, etc...

19:52:36  <xarick> int NumberOfPatches() const { return static_cast<int>(this->data.number_of_patches); }

19:52:36  <xarick> this->data.number_of_patches = highest_assigned_label;```

19:52:36  <xarick> versus

19:52:36  <xarick> ```int number_of_patches = 0; // 0 = no water, 1 = one single patch of water, etc...

19:52:38  <xarick> int NumberOfPatches() const { return this->data.number_of_patches; }

19:52:38  <xarick> this->data.number_of_patches = static_cast<int>(highest_assigned_label);```

19:54:13  <xarick> TWaterRegionPatchLabel is a uint8_t btw

19:58:51  <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13019: Codechange: Code style issues in water regions https://github.com/OpenTTD/OpenTTD/pull/13019

19:59:15  *** nielsm has joined #openttd

20:01:36  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13032: Fix: SkipGarbage() skipped all multi-byte utf-8 characters. https://github.com/OpenTTD/OpenTTD/pull/13032

20:11:05  <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic requested changes for pull request #13019: Codechange: Code style issues in water regions https://github.com/OpenTTD/OpenTTD/pull/13019#pullrequestreview-2397350753

20:11:51  <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #13019: Codechange: Code style issues in water regions https://github.com/OpenTTD/OpenTTD/pull/13019#pullrequestreview-2397350841

20:13:19  <johnfranklin> I ate some salad vegetables 12 days after its “best before” date limit.

20:13:26  <peter1138> RIP

20:14:09  <_glx_> the rule is look, smell, taste

20:14:18  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #12996: Codechange: use different structure for TileIndexDiff in debug https://github.com/OpenTTD/OpenTTD/pull/12996

20:14:28  <johnfranklin> It has not any strange smells

20:14:32  <johnfranklin> In fridge

20:14:39  <_glx_> and best before is not a hard limit

20:17:58  <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13019: Codechange: Code style issues in water regions https://github.com/OpenTTD/OpenTTD/pull/13019

20:24:14  <xarick> 14

20:24:45  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #12996: Codechange: use different structure for TileIndexDiff in debug https://github.com/OpenTTD/OpenTTD/pull/12996

20:53:18  <DorpsGek> [OpenTTD/OpenTTD] James103 started discussion #13033: Changing map height limit sandbox option reloads NewGRF data – is that still necessary? https://github.com/OpenTTD/OpenTTD/discussions/13033

20:54:01  <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic approved pull request #13019: Codechange: Code style issues in water regions https://github.com/OpenTTD/OpenTTD/pull/13019#pullrequestreview-2397354695

21:00:28  <peter1138> Hmm, such weirdness.

21:02:49  <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on discussion #13033: Changing map height limit sandbox option reloads NewGRF data – is that still necessary? https://github.com/OpenTTD/OpenTTD/discussions/13033

21:06:04  *** nielsm has quit IRC (Ping timeout: 480 seconds)

21:16:50  <xarick> tree generation became "slow"

21:17:08  <peter1138> When?

21:17:22  <xarick> now

21:17:43  <xarick> 12996 i mean

21:18:01  <peter1138> With 12996? That's entirely to be expected.

21:20:58  <xarick> I can't get the lighthouse to crash...

21:49:18  *** keikoz has quit IRC (Ping timeout: 480 seconds)

21:49:53  <xarick> how did I get it to crash the other time

21:49:58  <xarick> I can't reproduce

21:51:39  *** tokai|noir has joined #openttd

21:51:39  *** ChanServ sets mode: +v tokai|noir

21:53:34  <xarick> well, time for bed

21:54:40  <xarick> I was able to reproduce a few of my previous findings, they're marked with a checkmark <https://github.com/OpenTTD/OpenTTD/pull/12996#issuecomment-2439647683>

21:58:40  <peter1138> Hmm, templates where a type could be void. Problematic :S

21:58:41  *** tokai has quit IRC (Ping timeout: 480 seconds)

22:15:36  *** Flygon has joined #openttd

22:55:43  *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)

22:59:00  <wensimehrp> https://cdn.discordapp.com/attachments/1008473233844097104/1299869924964958241/image.png?ex=671ec5b4&is=671d7434&hm=73a1cfa7bc7f4d1527ac28e027afe4906be1ccbc6817188858582d426a92f16d&

22:59:00  <wensimehrp> peter1138: I think the fix was incorrect

22:59:00  <wensimehrp> it seems like the game is ignoring colour code

23:09:54  <peter1138> It's not ignoring it.

23:10:10  <peter1138> Fun. it was previously ignoring it, because it's a multi-byte utf-8 character.

23:11:31  <peter1138> "Never mind, serves them right for abusing colour codes."

23:16:44  <peter1138> Yeah, I don't use those pointless things so didn't notice them all snuck down at the bottom.

23:30:06  *** reldred has joined #openttd

23:30:06  <reldred> They’re useful on a suitably large grf list

23:30:25  <reldred> JGRPP sized ones

23:35:14  <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1299879040978649149/image.png?ex=671ece31&is=671d7cb1&hm=ec5a50df147ec70e8bffb49a6a708ed81dc9073b22829f3d6e0e5b468515b723&

23:35:14  <peter1138> Properly sorted now...

23:42:28  <_glx_> seems better to have them grouped in the list

23:44:11  <peter1138> Maybe we can do this another way.

23:45:16  <_glx_> skipping colour codes makes sense though

23:47:25  <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1299882107249758248/image.png?ex=671ed10d&is=671d7f8d&hm=442be25bca1d145356e16c4ecf143aebf24fbc066653cea839e634dacc941194&

23:47:25  <peter1138> Pom-te-pom

23:49:56  <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1299882742825091122/image.png?ex=671ed1a4&is=671d8024&hm=626b55b7a26acb29fb330732e4076a1dc75addbb5c8d2532f58c106eca7fcee6&

23:49:56  <peter1138> Something something something.

23:50:27  <peter1138> This does not properly ignore colours though, it only skips them at the start. Hmm.

23:50:59  <_glx_> yeah garbage handling is at start only

23:51:12  <peter1138> StrNaturalCompare deals with string_views to avoid making copies.

23:51:19  <peter1138> Stripping colours would need to make copies.

23:51:36  <peter1138> So the strings passed into it need to be stripped.

23:51:52  *** HerzogDeXtEr1 has quit IRC (Read error: Connection reset by peer)

23:52:48  <_glx_> anyway colours in grf names are rare (mostly used for separators)

23:54:20  <wensimehrp> Greenscreen 🙂

23:55:19  <peter1138> Are server names already stripped of codes?

23:55:58  <peter1138> Bananas content seems to be too. Or just nobody has tried it.

continue to next day ⏵