IRC logs for #openttd on OFTC at 2024-10-24
            
00:15:29 * debdog 'd laugh – if it were funny
00:15:34 *** gnu_jj_ has joined #openttd
00:17:10 *** TinoDidriksen has quit IRC (Read error: Connection reset by peer)
00:17:26 *** TinoDidriksen has joined #openttd
00:18:06 *** TinoDidriksen is now known as Guest7271
00:19:04 *** gnu_jj has quit IRC (Ping timeout: 480 seconds)
00:41:22 <DorpsGek> [OpenTTD/OpenTTD] Da-W1nn3r updated pull request #12999: Fix #12973: Don't exclude high score after using sandbox options https://github.com/OpenTTD/OpenTTD/pull/12999
00:44:23 <DorpsGek> [OpenTTD/OpenTTD] Da-W1nn3r updated pull request #12999: Fix #12973: Don't exclude high score after using sandbox options https://github.com/OpenTTD/OpenTTD/pull/12999
00:48:36 <DorpsGek> [OpenTTD/OpenTTD] Da-W1nn3r updated pull request #12999: Fix #12973: Don't exclude high score after using sandbox options https://github.com/OpenTTD/OpenTTD/pull/12999
00:54:58 <DorpsGek> [OpenTTD/OpenTTD] Da-W1nn3r updated pull request #12999: Fix #12973: Don't exclude high score after using sandbox options https://github.com/OpenTTD/OpenTTD/pull/12999
00:55:34 <DorpsGek> [OpenTTD/OpenTTD] Da-W1nn3r updated pull request #12999: Fix #12973: Don't exclude high score after using sandbox options https://github.com/OpenTTD/OpenTTD/pull/12999
00:56:50 <DorpsGek> [OpenTTD/OpenTTD] Da-W1nn3r updated pull request #12999: Fix #12973: Don't exclude high score after using sandbox options https://github.com/OpenTTD/OpenTTD/pull/12999
00:57:19 <DorpsGek> [OpenTTD/OpenTTD] Da-W1nn3r updated pull request #12999: Fix #12973: Don't exclude high score after using sandbox options https://github.com/OpenTTD/OpenTTD/pull/12999
01:38:55 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #12999: Fix #12973: Don't exclude high score after using sandbox options https://github.com/OpenTTD/OpenTTD/pull/12999#pullrequestreview-2391013772
01:58:07 *** Wormnest has quit IRC (Quit: Leaving)
02:11:45 *** gnu_jj has joined #openttd
02:14:54 *** gnu_jj_ has quit IRC (Ping timeout: 480 seconds)
02:20:00 <DorpsGek> [OpenTTD/OpenTTD] Da-W1nn3r updated pull request #12999: Fix #12973: Don't exclude high score after using sandbox options https://github.com/OpenTTD/OpenTTD/pull/12999
02:21:41 <DorpsGek> [OpenTTD/OpenTTD] Da-W1nn3r commented on pull request #12999: Fix #12973: Don't exclude high score after using sandbox options https://github.com/OpenTTD/OpenTTD/pull/12999#pullrequestreview-2391073191
02:54:46 *** D-HUND has joined #openttd
02:58:08 *** debdog has quit IRC (Ping timeout: 480 seconds)
04:11:47 *** keikoz has joined #openttd
04:30:41 *** D-HUND is now known as debdog
05:14:41 <kuhnovic> peter1138: Styropyro?
05:30:13 *** HerzogDeXtEr has joined #openttd
05:35:11 *** D-HUND has joined #openttd
06:00:18 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #12999: Fix #12973: Don't exclude high score after using sandbox options https://github.com/OpenTTD/OpenTTD/pull/12999#pullrequestreview-2391373081
06:15:19 *** Guest7271 is now known as TinoDidriksen
06:38:19 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic merged pull request #12999: Fix #12973: Don't exclude high score after using sandbox options https://github.com/OpenTTD/OpenTTD/pull/12999
06:38:22 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic closed issue #12973: [Bug]: Score excluded from highscore when using sandbox https://github.com/OpenTTD/OpenTTD/issues/12973
06:38:25 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic closed issue #12973: [Bug]: Score excluded from highscore when using sandbox https://github.com/OpenTTD/OpenTTD/issues/12973
06:53:48 <truebrain> Someone was being passive aggressive 😛
07:03:06 <peter1138> Wibble?
07:03:57 <andythenorth> is that a bike shop?
07:13:59 <kuhnovic> Holy shit that 20000 W microwave is no joke...
07:34:29 <peter1138> The thermite was quick.
07:52:18 <andythenorth> oof my hand was wet, so I licked it to see what it was
07:54:46 *** reldred has joined #openttd
07:54:46 <reldred> woo, got my 4g module for my gpd winmax 2 😄
07:54:53 <reldred> this is such an awesome little portable
07:55:06 <reldred> need better antennas though, the big patch antennas I got were the wrong connector
07:55:26 <reldred> i hate ipx connectors
07:55:40 <reldred> and I hate theres so many of them
08:07:28 <peter1138> Compactness or flexibility?
08:08:11 <reldred> there's a bunch of them and they're all ever so slightly different and far too smal for my eyes to tell the difference visually and they're incompatible with eachother 😄
08:13:26 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13027: Codechange: split GetRoadDir as bays have DiagDir and drive throughs have Axis https://github.com/OpenTTD/OpenTTD/pull/13027#pullrequestreview-2391670347
08:14:49 <reldred> god I might need to get my calipers out and measure this 😫
08:15:10 <reldred> 1.5mm, 2mm, all too bloody small thats what
08:17:07 *** mindlesstux has quit IRC (Quit: The Lounge - https://thelounge.chat)
08:18:18 *** mindlesstux has joined #openttd
08:47:20 <LordAro> reldred: i like how it's website uses comic sans
08:47:24 <LordAro> and an expired certificate
08:48:20 <kuhnovic> Hopefully there's no metric-vs-imperial stuff going on. Those threads seem to mesh well, until you turn them a bit and then they lock up... and you end up ruining the threads
08:48:55 <kuhnovic> M8 vs 5/16 thread is such a fun combo
08:49:00 <reldred> LordAro: the internet is a serious place
08:49:20 <reldred> but this device is great
08:50:02 <LordAro> srs bsns
08:50:43 <peter1138> Serious pricing.
08:51:15 <reldred> Gutsy units though. 8core, 16threads, 32gig of ram in something smaller than a surface go?
08:51:34 <reldred> I picked up an older 2022 unit off ebay for like half the price.
08:51:40 <reldred> And it's great.
08:56:35 *** merni has quit IRC (Quit: User went offline on Discord a while ago)
10:14:22 <peter1138> kamnet: needs a better "AI"/LLM detector 🙂
11:27:45 *** Flygon has quit IRC (Read error: Connection reset by peer)
12:17:53 <peter1138> Lunch?
12:25:08 <LordAro> too late
12:32:10 <xarick> hi
13:14:35 <kuhnovic> Spotify has found my soft spot for glamrock again
13:22:28 *** alfagamma0007 has joined #openttd
13:22:28 <alfagamma0007> 80s pop rock then?
13:23:39 <kuhnovic> Exactly
13:24:16 <kuhnovic> Although that genre has really seen a revival in the last 5 years, mainly in Sweden it seems. And I love it.
13:25:25 <alfagamma0007> I am all in for songs from an era I didn't exist in
13:27:55 <peter1138> My Naxos collection is growing...
13:37:28 *** gelignite has joined #openttd
13:56:03 *** nielsm has joined #openttd
14:30:32 <peter1138> <https://www.tt-forums.net/viewtopic.php?p=1260912#p1260912>
14:31:00 <peter1138> Oof, that's... an old post, but also a bit problematic that it happens.
14:52:37 <xarick> oh no Ryzen 7 5800x3D no longer being produced
14:54:49 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #12999: Fix #12973: Don't exclude high score after using sandbox options https://github.com/OpenTTD/OpenTTD/pull/12999#issuecomment-2435528396
14:58:22 <DorpsGek> [OpenTTD/OpenTTD] junalmeida opened issue #13028: [Bug]: Flatpak, Snap and debian app ids seems to differ https://github.com/OpenTTD/OpenTTD/issues/13028
15:02:05 <LordAro> xarick: didn't they announce a new one the other day?
15:02:32 <xarick> yes, for the AM5
15:02:36 <xarick> I'm on AM4
15:03:00 <LordAro> feel like there was some for AM4 not that long ago as well
15:03:30 <xarick> they were, but disappointing
15:03:47 <LordAro> https://www.anandtech.com/show/21420/amd-launching-new-cpus-for-am4-ryzen-5000xt-series-coming-in-july thought it was more recent than July, but can't find anything newer
15:04:26 <xarick> yeah, those XT series and the only one I was could be interested in was the 16-core one which is worse than the existing 5950X
15:04:30 <LordAro> https://www.tomshardware.com/pc-components/cpus/amd-allegedly-readying-new-ryzen-5-5600t-and-5600xt-cpus-am4-still-stands-strong-after-eight-years ah, these
15:04:35 <LordAro> not top end though
15:06:05 <xarick> now i must contend(?) with either 5700X3D or 5950X as an upgrade
15:06:23 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 dismissed a review for pull request #13027: Codechange: split GetRoadDir as bays have DiagDir and drive throughs have Axis https://github.com/OpenTTD/OpenTTD/pull/13027#pullrequestreview-2391670347
15:06:26 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13027: Codechange: split GetRoadDir as bays have DiagDir and drive throughs have Axis https://github.com/OpenTTD/OpenTTD/pull/13027
15:06:47 <xarick> Im afraid that 5950X will be discontinued soon now that there's the 5900XT replacing it
15:08:01 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13027: Codechange: split GetRoadDir as bays have DiagDir and drive throughs have Axis https://github.com/OpenTTD/OpenTTD/pull/13027#issuecomment-2435561364
15:08:07 <xarick> they promised AM4 support till 2025...
15:08:38 <xarick> just not the kind of replacing good skus with similar but worse performing skus
15:09:34 <Rubidium> and what does 'till' mean? Up to, not necessarily up to and including. So...
15:10:40 <LordAro> seems unlikely they'd release new processors only to immediately stop supporting them
15:10:43 <LordAro> well, i say that
15:13:03 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #13028: [Bug]: Flatpak, Snap and debian app ids seems to differ https://github.com/OpenTTD/OpenTTD/issues/13028
15:14:38 <kuhnovic> Or you just don't upgrade and accept that 70K ship maps are just slow, even on modern hardware 😄
15:14:52 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1299028345824215224/image.png?ex=671bb5ec&is=671a646c&hm=52c89130d545bae8476087fc50b67aead0461722f1dc01dd2574b8d307b4cd1e&
15:15:01 <xarick> 5800x3d out of stock
15:15:03 <xarick> rip
15:15:05 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13027: Codechange: split GetRoadDir as bays have DiagDir and drive throughs have Axis https://github.com/OpenTTD/OpenTTD/pull/13027#pullrequestreview-2393014950
15:16:52 *** tabytac has joined #openttd
15:16:52 <tabytac> I have often bought used CPUs and not had an issue with them aslong as the pins arent bent on the photos, running a 5800X3D that i got used a few months ago
15:18:01 <xarick> 5900XT more expensive than 5950X and it's not even better...
15:18:06 <xarick> just why?
15:20:26 <Rubidium> LordAro: to be honest the 5800X3D is already based on something two generations old and was released in 2022, so I'd not call it immediately dropping
15:20:48 <LordAro> sure, but if they're releasing a few new AM4 processors in the next month or so...
15:21:36 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed issue #13028: [Bug]: Flatpak, Snap and debian app ids seems to differ https://github.com/OpenTTD/OpenTTD/issues/13028
15:21:39 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #13028: [Bug]: Flatpak, Snap and debian app ids seems to differ https://github.com/OpenTTD/OpenTTD/issues/13028
15:26:04 <Rubidium> xarick: it has an extra T... that must be worth more than 50 ;)
15:27:15 <peter1138> Imagine polluting your system with 3 different package managers.
15:28:02 <LordAro> not a lot of choice on Ubuntu these days
15:31:55 <truebrain> peter1138: It made me giggle a bit 😛
15:35:11 <xarick> merge 13020 plz 🙂
15:35:35 <xarick> so that I can remove `TileOffsByDiagDir` from my own stuff
15:40:44 <xarick> it does weird underflowing stuff going from int to uint, but it works
15:40:55 <xarick> i tested
15:41:15 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13020: Codechange: replace magic numbers with enumeration https://github.com/OpenTTD/OpenTTD/pull/13020#pullrequestreview-2393081095
15:42:26 <peter1138> Bah, hungry. Which would be a bad time to visit the shop...
15:51:48 <peter1138> I assume making these things `enum class` would 1) actually be useful, but 2) be a huge task...
15:54:35 <Rubidium> definitely #2, #1 maybe in the long run so people try to avoid bitmagic on the enumerations
15:56:09 <Rubidium> though it'd be some massive atomic commits
16:00:38 *** gelignite has quit IRC (Remote host closed the connection)
16:02:07 *** gelignite has joined #openttd
16:04:01 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13027: Codechange: split GetRoadDir as bays have DiagDir and drive throughs have Axis https://github.com/OpenTTD/OpenTTD/pull/13027
16:06:51 <peter1138> This could be another way to get my commit count up 😉
16:23:00 <xarick> -2 -1 1 2
16:23:07 <xarick> magic numbers indeed
16:23:15 <xarick> rotating magic
16:34:36 <xarick> auto is bad
16:36:19 <xarick> for (const TileIndex &t : existing) {
16:37:23 <xarick> I saw a good video about someone explaining with auto has downsides
16:37:43 <peter1138> std::span<Til
16:37:55 <xarick> for maintainers or something
16:38:21 <peter1138> There are tradeoffs.
16:43:34 <_glx_> IDE are smart enough to show you the actual type
16:44:03 <xarick> <https://github.com/OpenTTD/OpenTTD/pull/13020/files#diff-1a74255a1a46e58ad1859ac698007f64d6fbe42d3e69905b7475b7fa3b153043R226-R227>
16:44:03 <xarick> these lines are swaped if I'm reading this properly...
16:44:15 <_glx_> but with templates and stuff like that it's easier to use auto
16:44:53 <xarick> 3rd case before is the 4th case after, 4th case before is the 3rd case after
16:45:30 <xarick> but it doesn't matter
16:46:25 <_glx_> it's more logical now
16:46:41 <xarick> seems so, I see
16:49:19 <xarick> <https://github.com/OpenTTD/OpenTTD/pull/13020/files#diff-1a74255a1a46e58ad1859ac698007f64d6fbe42d3e69905b7475b7fa3b153043R392-R395>
16:49:19 <xarick> reorder to 1432
16:51:17 <xarick> <https://github.com/OpenTTD/OpenTTD/pull/13020/files#diff-1a74255a1a46e58ad1859ac698007f64d6fbe42d3e69905b7475b7fa3b153043R431-R434>
16:51:17 <xarick> am I nitpicking too much? 1432 here too :p
16:51:47 <LordAro> you're not nitpicking in the right place, that's for sure
16:54:27 <xarick> <https://github.com/OpenTTD/OpenTTD/pull/13020/files#diff-1a74255a1a46e58ad1859ac698007f64d6fbe42d3e69905b7475b7fa3b153043R159-R160>
16:54:27 <xarick> swap these 2 lines
16:54:55 <xarick> i mean... it works already
16:59:07 <Rubidium> I sincerely hope the order in switches does not matter for the compiler, and that for these simple enumerations the compiler does the right/optimal thing.
17:02:52 <Rubidium> having said that, GCC seems to have more difficulties with it than clang
17:03:29 <Rubidium> https://godbolt.org/z/ocsqnY8T4 <- much shorter codegen for clang than gcc
17:04:25 <xarick> "will be build" feels like bad english, but what do I know about english
17:04:50 <LordAro> Rubidium: :o
17:08:42 <Rubidium> but alas... I'm not going to look at the codegen for each bit of code, then pick the best codegen and make code so other compilers deliver the same assembly
17:09:12 <LordAro> just write it in assembly
17:10:48 <Rubidium> but that must be MIPS assembly so it runs on a 4004 ;)
17:11:00 <LordAro> of course
17:23:17 *** bigyihsuan has joined #openttd
17:23:17 <bigyihsuan> suggestion: the ability to change where the OpenTTD configs, content_downloads, etc directory is
17:23:17 <bigyihsuan> i am getting nagged and nagged by onedrive about running out of storage, and it's due to openttd putting *everything* in the user Documents folder, and it's taking up most of the space that's getting force-synced.
17:23:17 <bigyihsuan> i accidentally just nuked my Documents OpenTTD folder trying to get rid of the onedrive notifications.
17:24:52 <LordAro> -c to specify config file location
17:25:02 <LordAro> then it'll look next to that, iirc
17:25:30 <LordAro> i'm pretty sure onedrive can handle folder exclusions thoug
17:25:31 <LordAro> h
17:26:18 <LordAro> hmm, apparently not
17:26:21 <LordAro> silly.
17:38:50 <xarick> I just invented TileIndexDiffCByAxis
17:38:53 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13027: Codechange: split GetRoadDir as bays have DiagDir and drive throughs have Axis https://github.com/OpenTTD/OpenTTD/pull/13027#pullrequestreview-2393325426
17:45:50 <bigyihsuan> LordAro: can this be an in-game setting, because i'm sure some less-techy people will want this an an in-game setting
17:47:29 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13027: Codechange: split GetRoadDir as bays have DiagDir and drive throughs have Axis https://github.com/OpenTTD/OpenTTD/pull/13027#pullrequestreview-2393361446
17:51:40 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13027: Codechange: split GetRoadDir as bays have DiagDir and drive throughs have Axis https://github.com/OpenTTD/OpenTTD/pull/13027#pullrequestreview-2393368861
17:51:45 <_glx_> bigyihsuan: and how the game would know where to find config file ?
17:55:14 <bigyihsuan> _glx_: that is on you to decide. or keep the config file in OpenTTD, and allow changing where downloads go, since the config files are usually much smaller than the total size of content downloads
17:56:10 <_glx_> https://github.com/OpenTTD/OpenTTD/blob/master/docs/directory_structure.md
17:56:15 <peter1138> You want us to decide where to find the config file on your computer? Job done, you've got a default...
17:56:48 <LordAro> _glx_: it occurred to me that we can probably get rid of the 95-XP stuff
17:57:18 <_glx_> there's also the "portable" option
17:57:38 <_glx_> (not very compatible with steam though)
17:58:40 <_glx_> LordAro: yeah, and IIRC README still mention installer able to copy original TTD files
18:01:54 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13027: Codechange: split GetRoadDir as bays have DiagDir and drive throughs have Axis https://github.com/OpenTTD/OpenTTD/pull/13027
18:12:17 <bigyihsuan> some interesting behavior i just discovered:
18:12:17 <bigyihsuan> if you quit onedrive, the location of the the documents folder changes from `C:\Users\{{user}}\OneDrive\Documents` to `C:\Users\{{user}}\Documents`, and this changes the config openttd reads from
18:12:17 <bigyihsuan> (or at least, the onedrive folder stops syncing to the documents folder, leading to 2 different configs available)
18:13:34 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13027: Codechange: split GetRoadDir as bays have DiagDir and drive throughs have Axis https://github.com/OpenTTD/OpenTTD/pull/13027#pullrequestreview-2393406273
18:14:51 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13027: Codechange: split GetRoadDir as bays have DiagDir and drive throughs have Axis https://github.com/OpenTTD/OpenTTD/pull/13027
18:23:08 *** Wolf01 has joined #openttd
18:23:45 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13027: Codechange: split GetRoadDir as bays have DiagDir and drive throughs have Axis https://github.com/OpenTTD/OpenTTD/pull/13027#pullrequestreview-2393429127
18:40:36 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13027: Codechange: split GetRoadDir as bays have DiagDir and drive throughs have Axis https://github.com/OpenTTD/OpenTTD/pull/13027
18:45:53 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13029: Codechange: remove parameter which value can always be deduced https://github.com/OpenTTD/OpenTTD/pull/13029
18:47:38 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13020: Codechange: replace magic numbers with enumeration https://github.com/OpenTTD/OpenTTD/pull/13020#pullrequestreview-2393473006
19:02:48 *** Extrems` has joined #openttd
19:08:10 *** Extrems has quit IRC (Ping timeout: 480 seconds)
19:08:10 *** Extrems` is now known as Extrems
19:14:25 <xarick> 4 conflicts!
19:18:56 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13026: Codechange: Use TileOffsByAxis(...) in more places https://github.com/OpenTTD/OpenTTD/pull/13026
19:20:08 <xarick> [Should this be](https://github.com/OpenTTD/OpenTTD/commit/38c9eb76a0311ad69d6aadb62166414fd8b0c801#diff-6343dc379195882c780886f331b31f53e3bb113a25bafd10550c410904117eacR554): `extern const TileIndexDiffC _tileoffs_by_axis[AXIS_END];`
19:39:39 <Rubidium> no, for the other variants of TileOffs* I'd argue that the size should be omitted as well, as the definitions are unbounded themselves
19:55:08 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13026: Codechange: Use TileOffsByAxis(...) in more places https://github.com/OpenTTD/OpenTTD/pull/13026#pullrequestreview-2393591454
19:56:31 *** Extrems has quit IRC (Quit: ZNC 1.7.5 - https://znc.in)
19:57:07 *** Extrems has joined #openttd
19:57:10 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13029: Codechange: remove parameter which value can always be deduced https://github.com/OpenTTD/OpenTTD/pull/13029#pullrequestreview-2393594760
19:58:19 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler merged pull request #13026: Codechange: Use TileOffsByAxis(...) in more places https://github.com/OpenTTD/OpenTTD/pull/13026
20:02:54 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13029: Codechange: remove parameter which value can always be deduced https://github.com/OpenTTD/OpenTTD/pull/13029
20:04:57 *** Extrems has quit IRC (Quit: ZNC 1.7.5 - https://znc.in)
20:05:00 *** Extrems has joined #openttd
20:07:57 *** Flygon has joined #openttd
20:11:16 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13020: Codechange: replace magic numbers with enumeration https://github.com/OpenTTD/OpenTTD/pull/13020#pullrequestreview-2393603991
20:18:35 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick requested changes for pull request #13020: Codechange: replace magic numbers with enumeration https://github.com/OpenTTD/OpenTTD/pull/13020#pullrequestreview-2393248598
20:19:55 <xarick> sorry, I wanted to cancel the reviewing but I don't know where
20:31:24 *** nielsm has quit IRC (Ping timeout: 480 seconds)
20:34:35 <LordAro> it's not by pressing "request changes", that's for sure
20:41:20 <xarick> I work against myself...
20:41:31 <xarick> just resolved conflicts, and now there's more
20:43:40 *** gelignite has quit IRC (Quit: Stay safe!)
21:19:48 *** keikoz has quit IRC (Ping timeout: 480 seconds)
21:23:56 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1299121222780457091/image.png?ex=671c0c6c&is=671abaec&hm=5bee1ed28aeacb2ad9f5d5cbaaf781c3edf62fb1f2dba72fae3b0a3803498ec2&
21:23:56 <xarick> am I being too smart?
21:25:31 <xarick> the other alternative is: `AddTileIndexDiffC(tile, -TileIndexDiffCByDiagDir(dir))`
21:27:17 *** SigHunter has quit IRC ()
21:29:57 *** SigHunter has joined #openttd
21:35:49 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
21:37:37 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13020: Codechange: replace magic numbers with enumeration https://github.com/OpenTTD/OpenTTD/pull/13020#pullrequestreview-2393748386
21:40:47 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13020: Codechange: replace magic numbers with enumeration https://github.com/OpenTTD/OpenTTD/pull/13020
21:54:07 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
22:02:37 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13020: Codechange: replace magic numbers with enumeration https://github.com/OpenTTD/OpenTTD/pull/13020#pullrequestreview-2393778750
22:02:55 <xarick> dang it, I can't remove `ToTileIndexDiff` because I can't remove `TileOffsByDiagDir` because 13020 is not merged yet. ^_^
22:12:43 <xarick> On second thought, the ordering, if changed might affect road pathfinder neighbouring search order...
22:13:32 <xarick> AIs may not exactly reproduce the same roads
22:13:44 <xarick> didn't test that
22:16:30 <xarick> I'll check it tomorrow, got no time today, sorry
23:02:26 *** toktik has quit IRC (Remote host closed the connection)
23:02:54 *** toktik has joined #openttd