IRC logs for #openttd on OFTC at 2024-06-30
⏴ go to previous day
00:42:40 <k-man> is there a way to show keyboard shortcuts in the tooltips?
01:02:59 <talltyler> No, unfortunately. It’s been attempted but is surprisingly difficult to do properly.
01:05:15 <goddess_ishtar> > I'm giving up on this one, it's becoming a huge hassle for something that I initially thought would be relatively simple to do. I don't want to spend so much time that's going to a relatively small contribution to the overall gameplay.
01:31:56 <k-man> is it worth trying abase for higher resolution graphics?
01:44:02 <k-man> anything for high res graphics or don't bother?
01:50:34 <talltyler> (32ez at that link)
01:54:19 <goddess_ishtar> k-man: zbase and abase are just very ugly imo
01:54:46 <goddess_ishtar> like I know it's an opinion thing but zbase was a quick proof-of-concept with 3D renders and it shows
01:57:57 <goddess_ishtar> shading is flat, colours are bright, scale is wonky
01:58:18 <goddess_ishtar> it makes all 32bpp extrazoom sets look worse
02:05:24 <k-man> if i put depots near each other and they are numbered #1 #2 and #3, does that mean the orders will consider them equivalent?
02:18:28 <emperorjake> No, if there is a specific depot in the orders it will only use that depot
02:18:37 <emperorjake> You can set the orders to "go to nearest depot" though
02:24:18 *** reldred has quit IRC (Quit: User went offline on Discord a while ago)
02:45:59 *** gnu_jj_ has quit IRC (Ping timeout: 480 seconds)
02:56:27 *** D-HUND has quit IRC (Ping timeout: 480 seconds)
04:09:34 *** amal[m] has quit IRC (Quit: Client limit exceeded: 20000)
04:34:00 *** gnu_jj_ has joined #openttd
04:37:39 *** gnu_jj has quit IRC (Ping timeout: 480 seconds)
04:41:35 <DorpsGek> - Update: Translations from eints (by translators)
06:27:02 <merni> peter1139: Looks much more fun than the real one
07:14:48 <pickpacket> PSA: whatever goes wrong today will not be my fault. And there won't be any witnesses anyhow
07:18:25 <truebrain> lies; I will make it your fault. MWHAHAHAHAHAHA
07:32:42 <andriydohniak> talltyler: I know you are busy, but if you get some free time, could you respond to my comments on my PR? Thanks :)
07:40:42 <pickpacket> truebrain: Nooooo! <Insert darth vader meme here>
07:41:24 <pickpacket> andythenorth: jeebus crabst... Let people wake up first
07:42:27 *** reldred has joined #openttd
08:12:27 <LordAro> reldred: look at you, living in the future
09:09:07 <andythenorth> can't see any reason why this train is sitting waiting for load
09:09:39 <andythenorth> cdist was on `asymmetric`, but I changed it to `manual` 2 hours ago (IRL)
09:12:31 <emperorjake> If you skip the order it should work next time around
09:12:51 <andythenorth> it does eventually load anyway
09:13:00 <andythenorth> but only as new cargo is produced
09:27:03 <andythenorth> delete the station I guess
10:10:22 *** gelignite has joined #openttd
10:49:06 *** Flygon has quit IRC (Read error: Connection reset by peer)
13:06:54 <talltyler> Interesting choice of username for someone requesting macOS features
13:24:09 <johnfranklin[d]> andriydohniak: jet lag: when you sent this message, it was 3:32 am for 2TallTyler.
13:24:42 <andriydohniak> johnfranklin[d]: I always forget about america :)
13:25:49 <talltyler> I did not have free time at 3:32 am, but I do now 🙂
13:32:01 <andriydohniak> When I wrote that It was 9:32 am for me, and I still haven't woken up :)
13:42:47 <johnfranklin[d]> So Spain is also UTC+2 in summer?
14:03:18 *** SigHunter has joined #openttd
14:36:40 <andriydohniak> I think I confsed my commits when diffing for added /deleted newlines, so I didn't make it better I made it worse 🤣
14:52:15 *** felix has quit IRC (Ping timeout: 480 seconds)
14:58:25 <andriydohniak> talltyler: I think I fixed it, but I am not fully sure, pls check:
14:58:25 <andriydohniak> - The NWidget spacing
14:58:25 <andriydohniak> - How I implemented auto closing
14:58:25 <andriydohniak> - If I actually stopped adding / deleting newlines
14:59:31 <andriydohniak> Also nits are necessary, and I really appreciate your patience with me! You probably did more useful work by reviewing my commits then me making them, thanks
15:07:56 <andriydohniak> *Fixed some comments
15:53:15 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
16:09:48 *** Wormnest has joined #openttd
17:10:02 <andriydohniak> pickpacket: Too early 😅
17:13:20 <andriydohniak> Also don't mind the weird formatting in the start of the test code, it's not an obfuscated backdoor script 👍
17:14:10 <goddess_ishtar> Not a disguised crypto miner?
17:15:01 <andriydohniak> goddess_ishtar: Well the command & control server can install a crypto mine.... Khm Khmm, No, what are you talking about?
17:17:06 <talltyler> Waiting to test the preview, but I'm pretty sure your nullptr test are backwards
17:17:22 <talltyler> If all windows are `nullptr`, they don't exist
17:18:48 *** HerzogDeXtEr1 has joined #openttd
17:19:24 <andriydohniak> Yep, just rebuilt, it works now
17:19:46 <andriydohniak> 1 time I thought I don't need to build, and I invert my logic 😅
17:20:31 <talltyler> It happens to the best of us
17:20:41 <andriydohniak> talltyler: but not nearly as often :)
17:25:38 *** HerzogDeXtEr has quit IRC (Ping timeout: 480 seconds)
17:27:33 <andythenorth> hmm natural dock location eh
17:43:37 <truebrain> Why are you playing with Dutch names?
17:43:41 <truebrain> looks weird on you 😛
17:44:00 <andythenorth> I try a new town name grf every game or so 😛
17:44:14 <andythenorth> generative AI names anyone? 😛
17:51:07 <peter1139> Can we just ban any mention of non-Squirrel AI here?
17:52:31 <andythenorth> you could write a bot to kick me if I match certain patterns?
17:52:52 <andythenorth> or it could just confabulate
17:54:25 <andriydohniak> CI just finished!
17:54:38 <audigex> andythenorth: I’m starting to think Andy has been infiltrated by ChatGPT
17:55:57 <andriydohniak> I AM SOO HAPPY!!! 🥳 🎉
17:56:17 <peter1139> Shall I review it now?
17:56:25 <peter1139> Last time I was reviewing it was outdated.
17:56:30 <andriydohniak> peter1139: It's too late now :)
17:56:50 <talltyler> No, it needs someone else to take a look 🙂
17:57:11 <talltyler> Two-key system for approve and merge, and the second person should pay attention too 😉
17:57:16 <pickpacket> andriydohniak: I AM TOTALLY ROOTING FOR YOU! Am continually impressed 🥳🥳🥳
17:57:45 <andriydohniak> pickpacket: THANK YOU! I AM IMPRESSED BY YOU TOO! although your pfp makes me confuse you with peter all the time :)
17:58:15 <pickpacket> What do I do that's impressive? 🤪
17:59:10 <andriydohniak> You are important, and you always do fun stuff
17:59:18 <andriydohniak> like the 4.6 gig map screenshot
17:59:34 <andriydohniak> And you do a lot of PRs
18:00:53 <truebrain> wait, pickpacket does what? 😛
18:01:17 <truebrain> I thought he was just our resident "DorpsGek" 😛
18:01:31 <andriydohniak> Idk he put me on the spot and diskord can't filter messages from IRC with the from: tag :)
18:06:17 <andriydohniak> I finally found the message I was looking for!
18:06:17 <andriydohniak> You are the guy using and compiling on an old netbook! I just had to be sure:
18:06:17 <andriydohniak> > @andriidokhniak I'm the who voluntarily uses a budget netbook from 2015 with a dual core Atom cpu and 2gb ram 🙂
18:06:25 <andriydohniak> That is the most impressive thing over here
18:07:12 <andriydohniak> I remember there were a bunch of ppl using old laptops, but I always forget the names, and if the pfp is just a cat? what can I do about it
18:08:44 <andriydohniak> There was another person using a 32 bit pc, not sure if that is you or not
18:11:59 <andythenorth> audigex: not just GPT, I'm not brand loyal, but I haven't explored Claude or the others much yet
18:12:30 <andythenorth> prompt driven generative AI is how I *thought* computers worked when I first saw a Windows PC
18:12:46 <andythenorth> I had to learn Excel and wondered where the box was to type in what I wanted it to do
18:12:54 <andythenorth> prior to that I had only used Acorn Archimedes
18:13:38 <andythenorth> people had told me I should try a real computer, and that there was an assistant in Windows that helped you do what wanted to do
18:33:47 <andythenorth> BBC Micro Emulator port?
18:33:56 <andythenorth> Can we run OpenTTD in Doom yet?
18:34:05 <andythenorth> replace grf with wad?
18:34:23 <peter1139> Map size would have to limited.
18:34:28 <andythenorth> the backface culling will save me drawing the rear of factory buildings
19:30:59 <goddess_ishtar> who's responsible for aggregating the results of the survey?
19:31:44 <goddess_ishtar> I feel like it'd be more useful if some settings were handled differently
19:31:53 <andriydohniak> peter1139: I fixed almost everything, but check my comments on the remaining ones (not resolved)
19:32:35 <goddess_ishtar> like grf count - we're almost never interested in exactly how many grfs someone is using, which is what it reports currently, we want to know how many people use tons of grfs versus how many use only a few or none
19:33:36 <goddess_ishtar> so it'd be better to group those into ranges
19:58:27 <andriydohniak> For now I didn't:
19:58:27 <andriydohniak> - Make the selector a reference
19:58:27 <andriydohniak> - Moved anything from graph_gui.h
19:58:27 <andriydohniak> - Changed the logic of how SelectorWidget::shown works
20:00:33 <andriydohniak> I also found a bug that I fixed (clicking outside the range when the list is filtered)
20:24:37 *** nielsm has quit IRC (Ping timeout: 480 seconds)
20:43:34 <talltyler> andythenorth: The new Steeltown preview is very nice, cheers. Do you have a version of CHIPS with loading sheds or is that still WIP? (the Basic Oxygen Furnace would look even better with trains in sheds) 🙂
20:45:59 <andythenorth> this is what I have
20:46:28 <andythenorth> that's a very pleasing model railroad
20:52:17 *** gelignite has quit IRC (Quit: Stay safe!)
21:06:43 <truebrain> silent_tempest: please don't DM me with questions you can ask here, especially if you plan to be rude about it ("Were you ever going to look at" for context). Plenty of people here that can help you with what-ever you curious about.
21:08:35 <silent_tempest> I've posted at least twice with no responce
21:09:46 <truebrain> doesn't give you a free card to be rude about it; you don't pay me, etc etc. I do this in my free tim
21:10:05 <truebrain> plenty of other devs in here that can help you with what-ever
21:10:10 <truebrain> no need to pick me out specifically for anything
21:10:45 <silent_tempest> I feel you're putting me in a no-win sceranio here. Other then saying nothing in giving up what is the "nice" way to get a review on something you asked me to write?
21:11:13 <truebrain> I never asked you to write anything. I aksed you to think about what we could do to improve. Doesn't mean I need to process your PR. Plenty of other people in here that can help you with that
21:11:30 <truebrain> and being rude always puts you in a no-win scenario. You caused that. Not me.
21:11:44 <silent_tempest> So what should I have done?
21:11:55 <silent_tempest> What should I be *doing* right now?
21:12:24 <truebrain> ask in here if someone wants to review your PR 🙂
21:12:58 <silent_tempest> I've done that.
21:13:01 <truebrain> by asking me specifically, it is very likely the others are: owh, that is something TB is dealing with
21:14:07 <silent_tempest> I noticed but as far as who else to ask is ??? which is why it hasn't moved and isn't going to move. At this point I am trying to decide if I should close my PR's without merging or just them open forever
21:14:10 <locosage> welcome to openttd contribution
21:14:29 <locosage> you spend shitton of time on pr and then in rots in reviews for years :/
21:14:32 <silent_tempest> This isn't welcome. That is a good bye
21:14:37 <truebrain> silent_tempest: I am very much not involved in OpenTTD dev atm, so I cannot help you. Being rude to me for sure doesn't contribute to anything 🙂
21:15:08 <goddess_ishtar> locosage: welcome to FOSS contribution :p
21:15:21 <locosage> well, can't say for all the foss...
21:15:43 <truebrain> silent_tempest: don't get me wrong, I do appreciate you looking into it
21:15:52 <truebrain> but I don't appreciate the tone in the DM. You could have asked: can you help me what to do next
21:16:03 <truebrain> but I too do this in me free time, so please take that into account 🙂
21:16:22 <truebrain> which goes two way; talking normal to each other is part of that "contract" 🙂
21:16:31 <silent_tempest> Typing "No" whould have been shorter and honestly what I what have preffered
21:17:09 <truebrain> you expect me to type "no" to someone that is being rude like that? You could also just say: sorry, that was uncalled for, and I could help you
21:17:15 <truebrain> but now you are just dipping down on it
21:17:32 *** xarothbrook has joined #openttd
21:18:08 <silent_tempest> You really confuse me
21:18:33 <truebrain> Okay, let's try this again: please don't be rude to me. If you have a question, and I see it and have time, I will reply. I have not have either. No need to be rude about it 🙂
21:19:21 <silent_tempest> I don't understand you. TBH. But I'm out of energy at this point. Have a good day.
21:20:57 <goddess_ishtar> I could go for a nap
21:24:41 <andriydohniak> This was fun while it lasted, going to nap
21:34:48 *** HerzogDeXtEr1 has quit IRC (Read error: Connection reset by peer)
21:36:49 <xarothbrook> locosage: Some people lack self-reflection.
21:43:24 *** tokai|noir has joined #openttd
21:43:24 *** ChanServ sets mode: +v tokai|noir
21:44:32 *** keikoz has quit IRC (Ping timeout: 480 seconds)
21:50:22 *** tokai has quit IRC (Ping timeout: 480 seconds)
21:51:02 *** izhirahider has quit IRC (Read error: Network is unreachable)
21:51:13 *** izhirahider has joined #openttd
21:53:56 <andriydohniak> silent_tempest: I have a perfect idea for you. I thought on how to make sure I don't sound biased, but what you can do is go to chat gpt and make a prompt like this one:
21:53:56 <andriydohniak> Hi, 2 people had a conversation,
21:53:56 <andriydohniak> person A, open source maintainer, etc
21:53:56 <andriydohniak> person B, a new contributor,
21:53:56 <andriydohniak> <put your dm history here without specifiyng who you are>
21:53:57 <andriydohniak> Who do you think of these 2 people was wrong, and why. Who is to blame more?
21:55:05 <silent_tempest> andriydohniak: There's a 0 percent chance I'm doing that. I don't have any accounts on any of the AI systems.
21:55:12 <silent_tempest> Nore do I understand the value of doing that
21:55:17 <truebrain> andriydohniak: Never sure if that is a /s or not 🙂
21:56:07 <andriydohniak> silent_tempest: To see that you are wrong and by how much, from an opinion that can't be targeted against you
21:56:44 <truebrain> and while I am here: talltyler, still needed input on the town JSON thingy?
21:56:46 <silent_tempest> Well thanks for your opinion.
21:57:59 <silent_tempest> I meant what I said when I said there's a 0 percent chance I'm doing that.
21:58:30 <andriydohniak> I gathered that much, but now your only excuse is "I don't wana"
22:03:04 <wensimehrp> truebrain: Would you mind reviewing/merging #12717?
22:03:12 <audigex> andriydohniak: Let’s not make “ask a robot if I’m right” a thing after disagreements, please…
22:03:52 <truebrain> wensimehrp: haha, sadly, LordAro was hoping I would know. I have zero clue what eints is going to do when we merge that 😛
22:03:57 <truebrain> the other name actually knows, I think
22:04:05 <truebrain> and yes, that is terrible, that we all don't know
22:04:19 <peter1139> wensimehrp, well, it needs updating now anyway.
22:04:20 <truebrain> it might be eints just reverts this the night after
22:04:26 <truebrain> but .... worst case, it does exactly that
22:07:06 <silent_tempest> So the github actions are triggered by labels?
22:07:27 <silent_tempest> The "Preview" label would trigger a "preview" build action on github?
22:09:10 <locosage> iirc preview is the only one that triggers anything
22:09:42 <silent_tempest> Although looking through the list of preview runs I haven't been able to find any artifacts from the action
22:10:36 <_glx_> previews just build and publish on cloudfare IIRC, no artifact stored
22:11:10 <silent_tempest> What does publish mean?
22:11:11 <dwfreed> previews are wasm builds of the game, hosted on a webpage
22:11:45 <silent_tempest> So not binary executables for Windows, Linux, etc...
22:11:53 <_glx_> oh no, looks like we have another node.js upgrade to try to do
22:12:21 <silent_tempest> How would I get a windows executable from a PR then?
22:13:05 <dwfreed> you'd have to build it yourself
22:13:11 <truebrain> _glx_: owh no ...... where this time?
22:13:23 <dwfreed> truebrain: preview CI
22:13:26 <silent_tempest> Fuck. I haven't been able to...
22:13:30 <truebrain> /me removes preview CI
22:13:49 <xarothbrook> truebrain: How many story points will that be?
22:13:50 <truebrain> btw dwfreed, I did not forget your request. Just zero time. Maybe soon 😄
22:14:01 <dwfreed> truebrain: no worries
22:14:05 <dwfreed> "Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: cloudflare/pages-action@v1"
22:14:10 <locosage> you can make github actions do a windows build in your own fork
22:14:20 <locosage> but may need to change some yml for that
22:14:40 <_glx_> anyway it's in openttd repo, so if there's an updated version we will get a nice PR from the bot
22:15:13 <truebrain> seems it is a bit more involved 😦
22:15:56 <truebrain> I am sure GitHub will postpone the disabling-of-node-16 yet-again with a few months 😛
22:16:20 <_glx_> we have dependabot for when it's updated
22:17:02 <truebrain> _glx_: yeah, but one suggestion is to switch to wrangler-action, which is node20
22:17:09 <silent_tempest> locosage: Hmn okay, My fork does seem to have a copied a small subset of the actions the OpenTTD repo has. Hopefully I can figure out how to make it do a windows build
22:17:21 <truebrain> so let's see when node16 is actually going to be deprecated 😛
22:17:26 <_glx_> your fork has all the actions
22:17:32 <silent_tempest> Anyways thanks
22:17:48 <_glx_> some can't fully run because they need some credentials
22:18:09 <_glx_> (the upload or signing for instance)
22:18:33 <talltyler> truebrain: I'm not aware of others having tested it. I can trigger a build for people to download and ask for feedback. It could definitely use some user-testing to see what happens if you input silly data 🙂
22:18:59 <truebrain> more wondering if maybe something was logical for you, but totally weird for actual users 😛
22:19:18 <truebrain> but we can also do that with the nightly, tbh 🙂
22:19:24 <truebrain> so I am not worried either way; was just wondering 🙂
22:19:39 <truebrain> but yeah, if you like, trigger a build, and ask around. Works too.
22:19:45 <_glx_> and discover issues once the release is published 🙂
22:19:53 <truebrain> that is how we rollllll
22:20:21 <locosage> fair warning though, I didn't really bother learning github actions and just winged it xD
22:20:27 <truebrain> 134 comments on one PR? Holy crap 😛
22:20:50 <truebrain> I see you are spreading your knowledge already talltyler ; nice 🙂
22:22:34 <truebrain> `I made the points on the graph clickable` <- wait, what? Now that is just unacceptable, being all modern and shit 😛
22:23:04 <talltyler> I will trigger a build and odds are, only a few people will test and I'll end up fixing issues after people play the nightly or JGRPP. But that's fine too, at least I can say I tried to get feedback. 😛
22:23:23 <_glx_> the release workflow will "fail" but the artifacts are available
22:23:42 <peter1139> wensimehrp, you managed to do an update that didn't fix the conflict.
22:23:56 <locosage> _glx_: hah, I guess I never found the button xD
22:25:14 <locosage> though it'll probably try to upload it to openttd places anyway if not modified
22:25:39 <goddess_ishtar> andriydohniak: Andy is taking over the other OpenTTD devs now :p
22:25:42 <_glx_> yeah that's why it "fails"
22:27:12 <_glx_> but the artifacts are created
22:27:56 <silent_tempest> Is this a permissions problem? I don't any way to trigger an action on the github web UI
22:28:33 <wensimehrp> peter1139: I forget to fetch my master branch
22:28:54 <silent_tempest> Okay even looking at my own fork doesn't show any new buttons
22:29:11 <_glx_> you should have a "run workflow" button on your "release" workflow action page
22:29:14 <silent_tempest> Seems like Github really wants you to setup some kind of trigger responding to a git commit
22:30:19 <_glx_> release, not the per platform ones
22:31:31 <truebrain> owh, I crashed 12793 😦
22:31:33 <wensimehrp> that should fix the problem
22:31:44 <silent_tempest> I don't see that on the OpenTTD actions tab and I don't have the generic "Release" action on my own fork
22:32:01 <truebrain> `src/widget_type.h: static_cast<size_t>(this->GetCount()) == container.size()`
22:32:04 <locosage> weird, I do have it in my fork...
22:32:06 <truebrain> poor container size
22:33:38 <silent_tempest> locosage: Presumably because you have the release.yml file in your repo? And it has text/code?
22:34:01 <_glx_> it's inside openttd repo
22:34:15 <silent_tempest> I have the file.
22:34:29 <silent_tempest> But the Github actions page doesn't list that workflow for whatever reason
22:35:50 <truebrain> talltyler: You should do it on OpenTTD 🙂
22:36:02 <truebrain> this is why we granted you powers 😛
22:36:21 <_glx_> that's what I see by default, but I just click "Show more workflows..." and I can see "Release"
22:37:08 <_glx_> yeah PR builds are triggered from OpenTTD, not your fork
22:38:32 <_glx_> but if you need to test an updated of release workflow you can only do it from your fork, as OpenTTD only allows master branch
22:42:57 <goddess_ishtar> > In other words: YOLO!
22:43:02 <goddess_ishtar> Move fast and break things
22:43:20 <truebrain> Or rather: merge, and it might get reverted! 😛
22:43:28 <truebrain> really curious what this will do
22:43:49 <goddess_ishtar> is eints just dark magic
22:44:09 <truebrain> I started on a replacement
22:44:13 <truebrain> then my job got in the way 😛
22:44:48 <truebrain> now finally some days off; long overdue, I tell you 🙂
22:45:16 <truebrain> wensimehrp: I cannot believe how many changes you made to Simplified Chinese
22:45:21 <truebrain> is your head still on straight?
22:45:38 <_glx_> users sill on win10, so many symbols to download
22:47:39 <wensimehrp> truebrain: do you mean the PR or the sum?
22:49:29 <truebrain> btw, eints will revert any string that is a revert of an older string. So if someone before you changed it from what you made it into what it was before your PR, eints will revert these back. So please keep an eye on next eints commit, to see if that was true for any string
22:49:46 <truebrain> (eints simply assumes it must have read an older file)
22:49:48 <wensimehrp> I'll manually fix the errors
22:52:10 <goddess_ishtar> truebrain: hell I use KDE and I never noticed that
22:52:31 <_glx_> BTW I see a need for an "import translations from file" in the new translator system if possible
22:52:32 *** Wolf01 has quit IRC (Ping timeout: 480 seconds)
22:53:00 <truebrain> _glx_: that kinda never ended well, tbh
22:53:29 <truebrain> as how do you clearly report back any mistakes being made, and do you commit them or not, and and and
22:53:43 <truebrain> I rather focus on having a way to input translations that works easier, also for bulk edits
22:54:14 <truebrain> there is a reason it is disabled in eints (as eints actually supports it; we just disabled it)
22:57:02 <talltyler> truebrain: I wanted Rocky Mountains, because that’s where I used to live, and it is beautiful. But I got stuck before I even got to the rocks 😦
22:57:15 <truebrain> lolz 🙂 Good reason to add stuff 😄
23:05:37 <truebrain> sometimes I am just pleasently surprised by the quality of PRs 🙂
23:11:41 <truebrain> Maybe `Change: improve when to stops following vehicle (#12808)`?
23:15:08 <truebrain> right, why was I doing OpenTTD stuff again? Ah, yes, rude DM about things I wasn't even aware of. Weird way to get dragged into checking out some PRs 😄 Owh well, sleepy time.
23:18:04 <locosage> Whine-driven development 🤭
23:21:36 <locosage> Tbh it's quite sad that endless complaining seems to be the best way to get things moving in openttd
23:21:55 <talltyler> It's really not though
23:22:08 <talltyler> Being nice and making PRs that are easy to understand is a much more reliable approach
23:22:22 <talltyler> At least in my experience
23:22:52 <locosage> You're a core dev, your experience is different
23:26:29 <xarothbrook> So if I've had the same experience as Tyler, I'm also a core dev?
23:26:35 <xarothbrook> sweet, promotion.
23:27:23 <locosage> Logic doesn't work that way :p
23:28:30 <xarothbrook> Perhaps your logic is flawed then?
23:29:18 <locosage> After I got "too hard to review" on like 100 line change I gave up on making any sense of it
23:29:50 <locosage> With only like 3 of those 100 lines doing anything actually new
23:32:33 <xarothbrook> If I had a penny I was told to rewrite a seemingly simple PR because it was to complicated. I'd be rich.
23:32:33 <xarothbrook> If I had a dollar every time the reviewer was right about that call, I'd also be rich.
23:32:53 <talltyler> My experience is "what makes me review a PR," which is a different experience but I'd argue equally valid 😛
23:35:23 <locosage> xarothbrook: That hardly an indicator considering you didn't even know c++ when you started doing those prs :p
23:35:55 <locosage> I'm not even sure you do now :p
23:38:35 <locosage> Wait, unless I'm confusing you with someone else...
23:38:37 <xarothbrook> 1. Don't stoop to trying to insult people, it _really_ doesn't make your case
23:38:37 <xarothbrook> 2. The language the PR is made in is completely and utterly irrelevant to the situation.
23:38:37 <xarothbrook> 3. I'm pretty sure you don't know what I do for a living, and you know what they say about assuming.
23:40:41 <locosage> Yeah, I probably do then.. You aren't Samu are you?
23:43:12 <xarothbrook> Never have been, never will be.
23:44:22 *** ladysadie has joined #openttd
23:46:10 <locosage> Yeah, nevermind then, I just confused you with a different person, they have a similar name on discord, sorry.
23:47:28 <locosage> I've no idea what your contributions to openttd are so can't say anything about your experience
continue to next day ⏵
