IRC logs for #openttd on OFTC at 2024-05-17
⏴ go to previous day
02:14:11 *** Wormnest has quit IRC (Quit: Leaving)
02:47:10 *** D-HUND has quit IRC (Ping timeout: 480 seconds)
03:15:36 <silent_tempest> So I have noticed that my PR's now auto-run precommit checks.
03:16:04 <silent_tempest> I got that privilege from? Getting something merged earlier?
05:15:11 *** keikoz has quit IRC (Ping timeout: 480 seconds)
06:17:02 <LordAro> it's a github thing to prevent people replacing CI with coin miners
06:36:15 <silent_tempest> I mean that all makes sense
07:44:24 <johnfranklin> Is milk hazardous?
07:44:45 <peter1138> It is if you're lactose interolant.
08:00:42 <peter1138> Heh, ICU documentation doubles down on UTF-16 being the best :p
08:04:49 *** XYZ has quit IRC (Ping timeout: 480 seconds)
08:10:36 <andythenorth> peter1138: could be oat
08:10:41 <andythenorth> milk subclasses?
08:20:58 <LordAro> peter1138: all of these libraries and things (ICU, Java, Windows) all suffer from the same thing - they were created before UTF8
08:21:45 <LordAro> well, before UTF16 too, technically
08:22:51 <peter1138> Hmm, very few things seem to use icu::ScriptRun.
08:23:00 <peter1138> Most of the 14 hits on Github are OpenTTD forks ;D
08:25:56 <peter1138> Makes it difficult to verify if we do things the best/simplest way,..
08:26:13 <peter1138> TB wrote it so it probably is 😄
08:47:58 *** mindlesstux has joined #openttd
08:55:45 *** mindlesstux has joined #openttd
10:19:13 <ahyangyi> andythenorth: Ah, I should make soy industries...?
11:07:59 <peter1138> Okay, so switching default string colour from TC_FROMSTRING to TC_BLACK had a side effect I hadn't thought of.
11:08:34 <peter1138> GetStringBoundingBox layouts the string, with TC_FROMSTRING still.
11:08:43 <peter1138> DrawString layouts the string TC_BLACK.
11:08:52 <peter1138> TC_BLACK != TC_FROMSTRING, so the string is layouted twice.
11:11:09 <peter1138> So... revert and use TC_FROMSTRING all the time again, or make GetStringBoundingBox assume TC_BLACK, or give GetStringBoundingBox a TextColour parameter...
11:11:40 <peter1138> In theory the text colour is not going to affect the colour of the string at all.
11:11:51 <peter1138> But it's cached, so it does.
12:26:18 <peter1138> Or just make it all default to TC_BLACK, on the basis that that is more likely true.
12:31:37 <LordAro> why does GetStringBoundingBox care what the colour is at all?
12:31:47 <LordAro> or the cached form, anyway
12:31:56 <LordAro> caching feels like it should strip all colour codes out
12:33:16 <peter1138> Colour changes need to happen at the right place, regardless of LTR or RTL, so they are recorded as part of the layout.
12:39:39 <peter1138> When you add push/pop into the mix as well, which also needs to happen in the correct order and correct place...
12:41:17 <LordAro> sure, but when does the colour of the text have any affect on the layout?
12:41:32 <LordAro> colour isn't defining things like word/line breaks, surely?
12:43:54 <peter1138> Layouting doesn't define those either.
12:49:13 <peter1138> e.g. `{BLACK}label1: {WHITE}value. {BLACK}label2: {WHITE}value.` in RTL becomes something like `{WHITE}value. {BLACK}:label2 {WHITE}value. {BLACK}:label1`
12:49:48 <peter1138> Obviously a fake example so not all details are correct.
12:50:22 <peter1138> So colour does not actually affect the positions. But the positions affect the colour.
12:55:54 <peter1138> We should probably also have a way of manually overriding the language direction.
12:56:26 <peter1138> The console is not translated so everything is in english, but it still obeys the language RTL setting, and is therefore pretty broken.
13:13:14 <peter1138> Wayland brings all the bugs to the yard.
13:32:40 <peter1138> Hmm, even with LTR override, spaces at the end of the line get pushed to the front.
14:21:20 *** quantom2 has quit IRC (Quit: User went offline on Discord a while ago)
16:20:37 <merni> Hmm, why can't the help texts at least be made translatable
16:21:13 <peter1138> Because nobody has a patch for that.
16:22:18 <merni> would there be any reason against doing it
16:22:50 <merni> also, I suggest few people other than you really have patches for anything anymore, it's all branches :P
16:26:44 *** Wormnest has joined #openttd
16:29:36 <silent_tempest> merni: Hey hey, I have patches... 😛
16:42:49 *** HerzogDeXtEr has joined #openttd
16:43:30 <wensimehrp> merni: I found the localized error message of powershell is really annoying.
16:43:30 <wensimehrp> Say, there is a file io error, powershell will give me an error in Chinese. However, at most of the time when I search for the solution, inputting the Chinese error message won't help at all. I have to go over a translation table and find the English message, and then I could find the solution to that error.
16:43:30 <wensimehrp> But that powershell example might be quite extreme. I mean, there's no need for running an external program in the OpenTTD console...
16:43:30 <wensimehrp> So maybe this is reasonable? Adding localization to the console?
16:46:35 <peter1138> And until someone does that...
17:11:40 *** amal[m] has quit IRC (Quit: Client limit exceeded: 20000)
17:11:48 *** virtualrandomnumber has joined #openttd
17:12:47 *** virtualrandomnumber has quit IRC ()
18:04:29 *** SigHunter has joined #openttd
20:53:13 <peter1138> Any mac OS user able ot test #12662?
21:46:12 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
22:12:54 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:32:06 *** Wormnest has joined #openttd
22:39:42 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
22:39:48 *** APTX has quit IRC (Remote host closed the connection)
22:49:02 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
23:23:05 <silent_tempest> Did that change that was supposed to fix the mousegrab while debugging not get merged?
23:24:23 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
23:30:58 <silent_tempest> Ah okay it's default off
23:33:50 <silent_tempest> And now it works. Cool
23:55:20 *** Wormnest has joined #openttd
continue to next day ⏵
