IRC logs for #openttd on OFTC at 2024-04-09
            
00:21:28 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #12461: Codechange: Pass NewGRF strings as std::string_view instead of char *. https://github.com/OpenTTD/OpenTTD/pull/12461
00:21:54 <peter1138> ^ GRFComment (a fairly useless feature) now works properly...
00:24:11 *** Wormnest_ has joined #openttd
00:49:22 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #12461: Codechange: Pass NewGRF strings as std::string_view instead of char *. https://github.com/OpenTTD/OpenTTD/pull/12461#pullrequestreview-1987900664
00:54:38 *** bertvvvs has joined #openttd
01:05:05 *** bertvvvs has quit IRC (Quit: You have a nice day.)
01:19:51 *** Wormnest_ has quit IRC (Ping timeout: 480 seconds)
01:24:25 *** Wormnest_ has joined #openttd
02:04:34 *** Wormnest_ has quit IRC (Quit: Leaving)
02:46:33 *** gnu_jj_ has joined #openttd
02:49:43 *** gnu_jj has quit IRC (Ping timeout: 480 seconds)
02:51:31 *** debdog has joined #openttd
02:55:15 *** D-HUND has quit IRC (Ping timeout: 480 seconds)
03:28:23 <DorpsGek> [OpenTTD/OpenTTD] CI - Nightly workflow was not successful https://github.com/OpenTTD/OpenTTD/actions/runs/8609718137
04:08:39 *** keikoz has joined #openttd
04:24:12 *** felix has quit IRC ()
04:24:59 *** felix has joined #openttd
04:34:51 *** keoz has joined #openttd
04:36:40 *** keikoz has quit IRC (Ping timeout: 480 seconds)
04:40:38 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/b5ad28022d71e4e9ed80d5dd161d375557f59982
04:40:39 <DorpsGek> - Update: Translations from eints (by translators)
04:49:35 *** Ox7C5 has joined #openttd
04:59:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #12457: Codechange: Pass by reference to UpdateWidgetSize. https://github.com/OpenTTD/OpenTTD/pull/12457#pullrequestreview-1988107163
05:09:06 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #12460: Fix #12459, f6a88e4: Crashes when deleting news messages. https://github.com/OpenTTD/OpenTTD/pull/12460#pullrequestreview-1988114836
05:26:18 <DorpsGek> [OpenTTD/OpenTTD] Release workflow was not successful https://github.com/OpenTTD/OpenTTD/actions/runs/8610616132
05:41:51 *** keoz has quit IRC (Remote host closed the connection)
05:42:02 *** keikoz has joined #openttd
06:27:32 <truebrain> so much rain clouds
06:39:22 *** imlostlmao[m]1 has quit IRC ()
06:49:00 *** Flygon has quit IRC (Read error: Connection reset by peer)
07:18:46 <peter1138> Such
07:34:49 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #12457: Codechange: Pass by reference to UpdateWidgetSize. https://github.com/OpenTTD/OpenTTD/pull/12457
07:35:16 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #12434: Fix: Draw continuation lines for engine variant hierarchy tree. https://github.com/OpenTTD/OpenTTD/pull/12434
07:37:37 <andythenorth> so much wind
07:40:31 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #12461: Codechange: Pass NewGRF strings as std::string_view instead of char *. https://github.com/OpenTTD/OpenTTD/pull/12461
07:41:15 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #12456: Codechange: use std::span instead of pointer + length https://github.com/OpenTTD/OpenTTD/pull/12456#pullrequestreview-1988338271
07:49:33 *** praxoid has joined #openttd
07:49:33 <praxoid> dunno if this was ever addressed, but I remember that on older versions of OpenTTD (before 14) in the scenario editor if you disable the "cities are allowed to build road" option while expanding the city it only build houses and not roads. Now cities build roads regardless of the option when being expanded.
07:50:24 <praxoid> another thing is that loading older scenario with same setting preexisting cities still follow no roads option while the new founded ones don't.
07:50:50 <merni> praxoid: https://github.com/OpenTTD/OpenTTD/issues/12312
07:50:50 <merni> https://github.com/OpenTTD/OpenTTD/pull/11377
07:50:50 <merni> It's a deliberate change though a debatable one
07:51:20 <praxoid> oh, thanks
07:53:13 <praxoid> yeah it is a strange approach, since you don add anything but remove a feature
08:11:54 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #12456: Codechange: use std::span instead of pointer + length https://github.com/OpenTTD/OpenTTD/pull/12456
08:13:48 <peter1138> So I started looking at LordAro's complaint in #12451, and... got sidetracked by removing lastof() as well, oops.
08:13:55 <LordAro> haha
08:18:31 <LordAro> in other news, msftconnecttest.com/connecttest.txt now returns the expected result
08:18:35 <LordAro> stupid ISPs
08:20:56 <Rubidium> peter1138: removing lastof is definitely a huge detour
08:21:19 <peter1138> It is a detour, it's not actually huge though.
08:21:49 <peter1138> I saw `lastof(_saveload_formats)` and went down that rabbit hole briefly...
08:22:38 <Rubidium> oh, that's not that rabbit holey then. I thought you meant lastof in general ;)
08:23:37 <Rubidium> what remains are two bits of Windows specific code, which would be probably quite easy, and... the binary language file format
08:24:03 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #12420: Add: support for admin to change company allow lists https://github.com/OpenTTD/OpenTTD/pull/12420
08:24:06 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #12337: Change: replace company passwords with allowlist https://github.com/OpenTTD/OpenTTD/pull/12337
08:25:15 <peter1138> strecpy is easy, just make it take std::end() and adjust the algorithm (or do --last at the start)
08:25:38 <peter1138> Arguable you are 'hiding the problem', but...
08:43:23 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #12440: Codechange: replace most uses of lengthof with std::size https://github.com/OpenTTD/OpenTTD/pull/12440
08:44:30 *** thelonelyellipsis[m] has quit IRC (Quit: Bridge terminating on SIGTERM)
08:44:30 *** JamesRoss[m] has quit IRC (Quit: Bridge terminating on SIGTERM)
08:44:31 *** tuxayo has quit IRC ()
08:44:32 *** hamstonkid[m] has quit IRC (Quit: Bridge terminating on SIGTERM)
08:44:32 *** grag[m] has quit IRC ()
08:44:32 *** karoline[m] has quit IRC (Quit: Bridge terminating on SIGTERM)
08:44:32 *** thomas[m]1234 has quit IRC (Quit: Bridge terminating on SIGTERM)
08:44:32 *** philip[m] has quit IRC (Quit: Bridge terminating on SIGTERM)
08:44:33 *** fiddeldibu[m] has quit IRC (Quit: Bridge terminating on SIGTERM)
08:44:36 *** shedidthedog[m] has quit IRC (Quit: Bridge terminating on SIGTERM)
08:44:37 *** soylent_cow[m] has quit IRC (Quit: Bridge terminating on SIGTERM)
08:44:37 *** FelixActually[m] has quit IRC (Quit: Bridge terminating on SIGTERM)
08:44:43 *** osvaldo[m] has quit IRC (Quit: Bridge terminating on SIGTERM)
08:44:44 *** leward[m] has quit IRC (Quit: Bridge terminating on SIGTERM)
08:44:46 *** joey[m] has quit IRC (Quit: Bridge terminating on SIGTERM)
08:44:48 *** pikaHeiki has quit IRC (Quit: Bridge terminating on SIGTERM)
08:44:54 *** Heiki[m] has quit IRC (Quit: Bridge terminating on SIGTERM)
08:45:14 *** paulus[m] has quit IRC ()
08:45:14 *** SergioMassa[m] has quit IRC ()
08:45:14 *** xyii[m] has quit IRC (Quit: Bridge terminating on SIGTERM)
08:45:19 *** jeremy[m]12 has quit IRC (Quit: Bridge terminating on SIGTERM)
08:45:21 *** patrick[m]1 has quit IRC (Quit: Bridge terminating on SIGTERM)
08:45:26 *** Rdolfs[m] has quit IRC (Quit: Bridge terminating on SIGTERM)
08:45:27 *** Bilb[m] has quit IRC (Quit: Bridge terminating on SIGTERM)
08:45:28 *** luk3Z[m] has quit IRC (Quit: Bridge terminating on SIGTERM)
08:45:29 *** gdown has quit IRC (Quit: Bridge terminating on SIGTERM)
08:45:32 *** royills[m] has quit IRC (Quit: Bridge terminating on SIGTERM)
08:45:37 *** throwawayaccount[m] has quit IRC (Quit: Bridge terminating on SIGTERM)
08:45:42 *** freu[m] has quit IRC ()
08:45:42 *** enick_974 has quit IRC (Quit: Bridge terminating on SIGTERM)
08:45:50 *** VincentKadar[m]12345 has quit IRC ()
08:45:59 *** karl[m]12 has quit IRC (Remote host closed the connection)
08:45:59 *** temeo[m] has quit IRC (Remote host closed the connection)
08:45:59 *** audunm[m] has quit IRC (Remote host closed the connection)
08:46:00 *** cjmonagle[m] has quit IRC (Remote host closed the connection)
08:46:00 *** wormnest[m] has quit IRC (Write error: connection closed)
08:46:01 *** yubvin[m] has quit IRC (Remote host closed the connection)
08:46:01 *** Farrokh[m] has quit IRC (Remote host closed the connection)
08:46:01 *** giords[m] has quit IRC (Remote host closed the connection)
08:46:02 *** jeeg[m] has quit IRC (Remote host closed the connection)
08:46:02 *** rain[m]1 has quit IRC (Remote host closed the connection)
08:46:04 *** calbasi[m]1 has quit IRC (Remote host closed the connection)
08:46:05 *** einar[m] has quit IRC (Remote host closed the connection)
08:51:58 *** emilyd[m] has quit IRC (Ping timeout: 480 seconds)
08:52:06 *** patricia[m]1 has quit IRC (Ping timeout: 480 seconds)
08:52:21 *** playback2396[m] has quit IRC (Ping timeout: 480 seconds)
09:24:33 <truebrain> LordAro: if I would be to guess, your ISP caches the DNS longer than the TTL allows, and the IP were rotated out for that domain. Happens, sadly enough, a lot more often than one would think
09:38:38 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1227190931820642416/image.png?ex=6627819e&is=66150c9e&hm=d90de1752e228f0562f3411966c37dff0eabb92c4aaa332cdc62ce1c642d6d51&
09:38:38 <xarick> I'm getting question marks in the vehicle window
09:38:48 <xarick> what changed
09:39:56 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1227191257671929906/image.png?ex=662781eb&is=66150ceb&hm=414f7a0f81cb04adc31226b7e2a2586fc32f81e5c11fdd4c5aea8e37d60b1cfa&
09:39:59 <peter1138> What version does it say?
09:40:24 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1227191374013665350/image.png?ex=66278207&is=66150d07&hm=3f1e9a7adbb48eb3d0d9417e3972c9226b207b91cce212192a59e5580c57ba74&
09:41:13 <peter1138> Any NewGRFs loaded?
09:41:17 <xarick> nop
09:47:29 <peter1138> Hmm, guess I broke ReadString :/
09:53:53 <peter1138> Will fix at lunch time.
10:01:29 <LordAro> truebrain: i don't think so, i saw the same result with several different IP addresses
10:01:38 <LordAro> several of which matched other people's
10:01:42 <LordAro> results
10:01:56 <LordAro> and again, switching curl to https made the issue go away
10:04:26 <LordAro> (and the rest of the domain behaved as expected)
10:04:36 <truebrain> yeah, that especially made me say what I said 😄 As https is commonly handled differently than http (SNI handling etc)
10:05:01 <truebrain> but it might also been a misconfiguration on Microsoft's side, ofc 😉
10:05:35 <LordAro> i suppose so
10:05:56 <truebrain> but I see this a lot when we rotate our VMs for OpenTTD
10:06:05 <truebrain> then new IPs are assigned to our boxes
10:06:10 <LordAro> it was only connecttest.txt that was redirecting to bosch.com though, / or other domains were fine
10:06:16 <truebrain> and sometimes you get traffic for a while from another domain
10:06:20 <truebrain> as they rotated their VMs out 😛
10:07:21 <truebrain> LordAro: lolz, okay, that is just odd. In that case, could be a http caching proxy on the route
10:07:30 <truebrain> in "the old days" that was common, but with https impossible 😛
10:07:35 <truebrain> (as the certificate would fail)
10:08:03 <LordAro> exactly
10:08:21 <truebrain> some companies still do https caching proxy btw; they force their certificate on your working pc, so they can do a MitM
10:08:24 <truebrain> very "trust worthy"
10:08:37 <LordAro> ah well, don't suppose i'm ever going to find out - i emailed them this morning saying "hey it's fixed now", and they responding "cool, ticket closed"
10:08:52 <truebrain> the misteries of the Internet
10:09:07 <peter1138> > Your package will be picked up by the carrier soon.
10:09:18 <peter1138> Awww come on, I ordered yesterday, why isn't it here yet!?
10:09:21 <LordAro> https://www.reddit.com/r/techsupport/comments/hted03/msftconnecttest_redirects_to_a_website_of_a/ i did find this from 4 years ago too
10:09:24 <LordAro> which is odd.
10:09:38 <peter1138> Amazon same-day delivery has ruined us.
10:11:41 <truebrain> LordAro: haha, for some reason I have the suspecion that bosch.com is the first defined host on that webserver, so: "I don't know this domain" results in "go to this default host" 😛 I really hope that is not the case 😄
10:12:02 <truebrain> maybe it is just a mad engineer that left the company 5 years ago
10:12:05 <truebrain> and left this "easter egg"
10:13:01 <truebrain> I once had a server that was compromised, and all they did was "when you come from mobile, and visit this website, you are redirected to a phishing site". The problem, the conditions were so specific, that when we validated the claim of the customer, everything worked fine. It was only for a small subset of devices it was not. Took a bit of time to figure that one out 😄
10:13:24 <LordAro> i've seen that sort of things before
10:46:58 *** bertvvvs has joined #openttd
11:01:55 <peter1138> Lunch?
11:03:54 <LordAro> i think so
11:04:52 <johnfranklin> Dinner for East Asia
11:05:04 <johnfranklin> But I ate something western
11:05:40 <truebrain> I had too much lunch
11:05:50 <truebrain> now I can't work; have to digest the food first
11:06:11 <merni> time for zzzzzzz
11:06:21 <merni> adults should have naptime
11:06:54 <johnfranklin> Never nap
11:10:05 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #12462: Fix 54be756: Terminating NUL byte was not skipped in ReadString(). https://github.com/OpenTTD/OpenTTD/pull/12462
11:10:30 <peter1138> Fixes Xarick's issue.
11:15:08 <peter1138> Many fail
11:15:25 <truebrain> poor CI
11:15:34 <truebrain> I did not expect this liblzma stuff to take this long, I have to admit
11:19:58 <peter1138> Can you be sure than anyone is actually looking at it... 🙂
11:22:42 <_jgr_> I'm not sure why vcpkg are sitting on their hands. Pointing vcpkg somewhere else for the source seems doable though oddly convoluted.
11:23:36 <truebrain> especially now the repo is no longer blocked. I guess the original author needs more time to review all the work done by person X, but .. yeah, I would have expected some resolution by now from microsoft
11:30:55 *** amal[m] has joined #openttd
11:33:40 *** bertvvvs has quit IRC (Quit: You have a nice day.)
11:46:28 *** keikoz has quit IRC (Ping timeout: 480 seconds)
11:46:52 *** bertvvvs has joined #openttd
11:51:18 *** bertvvvs has quit IRC ()
12:06:04 *** bertvvvs has joined #openttd
12:16:23 *** bertvvvs has quit IRC (Quit: You have a nice day.)
12:23:44 <peter1138> I guess that's "good", the NewGRF I thought I might be breaking is just broken already with no fix.
12:25:10 <truebrain> pfew 😛
12:38:18 <peter1138> Not like the one I merged this morning which breaks everything ;D
12:39:21 <truebrain> there are no nightlies anyway, nobody is going to notice 😛
12:39:58 <peter1138> Reloading the tracking page makes the parcel arrive quicker, yes?
13:03:34 <andythenorth> truebrain: wonder if they've found a significant zero day without any obvious mitigation? seems unlikely given the known vector
13:04:11 <truebrain> peter1138: keep hitting that refresh!
13:05:54 *** tateisukannanirase has quit IRC (Quit: User went offline on Discord a while ago)
13:07:58 *** keikoz has joined #openttd
13:23:12 <peter1138> <https://www.reddit.com/r/openttd/comments/1bzbwaa/how_do_you_manage_games_on_1024x1024_or_larger/> Such sprite cache default limit.
13:45:41 <Eddi|zuHause> ha, i finally managed to complete xkcd...
13:54:46 <LordAro> peter1138: does the default need bumping up?
13:54:52 <LordAro> or does it need to be dynamic?
13:56:12 <merni> doesn't increasing it icnrease memory usage?
13:56:37 <peter1138> merni: Of course.
13:56:51 <peter1138> LordAro: Not sure.
13:56:57 <merni> in which case just changing the default across the board might not be the best solution
13:57:19 <merni> since this is one of the few games that can be played on rather low spec systems
13:57:37 <LordAro> merni: welcome to the world of being a dev
13:57:42 <LordAro> everything is a trade off :)
13:57:50 <merni> yay I am a dev now
13:58:55 <peter1138> Hmm, a typedef for a vector<T> that is only used once is probably not necessary.
14:02:57 <_jgr_> Caching every possible zoom level, and the cache eviction algorithm being very slow interact badly as soon as you zoom out
14:05:45 <_jgr_> If a single screen's worth of sprites doesn't fit in the cache, performance completely falls off a cliff, so automatically increasing it in that case would sense
14:06:45 <peter1138> Quite.
14:07:37 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #12462: Fix 54be756: Terminating NUL byte was not skipped in ReadString(). https://github.com/OpenTTD/OpenTTD/pull/12462#pullrequestreview-1989156314
14:10:28 <DorpsGek> [OpenTTD/dibridge] poVoq opened issue #229: Strange error caused the bridge to stop relaying messages https://github.com/OpenTTD/dibridge/issues/229
14:15:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #12462: Fix 54be756: Terminating NUL byte was not skipped in ReadString(). https://github.com/OpenTTD/OpenTTD/pull/12462
14:17:11 *** nielsm has joined #openttd
14:25:24 <truebrain> "You are about to locate an insane amount of memory as you loaded in too many NewGRFs. Continue?" 😛
14:28:47 <DorpsGek> [OpenTTD/dibridge] TrueBrain commented on issue #229: Strange error caused the bridge to stop relaying messages https://github.com/OpenTTD/dibridge/issues/229
14:31:33 <peter1138> I still wonder if we can avoid all the prescaling, like it used to.
14:34:20 <peter1138> But lots of complicate blitteryness.
14:34:43 <peter1138> Good for that hardware scaling capable one that was being worked on but seems to have fallen off.
14:36:04 <DorpsGek> [OpenTTD/dibridge] TrueBrain commented on issue #229: Strange error caused the bridge to stop relaying messages https://github.com/OpenTTD/dibridge/issues/229
14:42:48 <DorpsGek> [OpenTTD/dibridge] poVoq commented on issue #229: Strange error caused the bridge to stop relaying messages https://github.com/OpenTTD/dibridge/issues/229
14:45:18 <DorpsGek> [OpenTTD/dibridge] TrueBrain commented on issue #229: Strange error caused the bridge to stop relaying messages https://github.com/OpenTTD/dibridge/issues/229
14:50:04 <DorpsGek> [OpenTTD/dibridge] TrueBrain commented on issue #229: Strange error caused the bridge to stop relaying messages https://github.com/OpenTTD/dibridge/issues/229
14:50:08 <truebrain> spammiethespam
15:23:22 <DorpsGek> [OpenTTD/dibridge] poVoq commented on issue #229: Strange error caused the bridge to stop relaying messages https://github.com/OpenTTD/dibridge/issues/229
15:25:50 <talltyler> Does #11495 improve sprite cache performance at all? Or is it just cleaner code?
15:26:01 *** keikoz has quit IRC (Ping timeout: 480 seconds)
15:27:31 *** keikoz has joined #openttd
15:27:35 <peter1138> No, it basically just removes legacy memory management stuff with containers.
15:30:12 <_jgr_> It does improve the performance of cache eviction when the limit is reached, that was the original motivation for changing this
15:30:28 <peter1138> Oh okay.
15:34:25 *** keoz has joined #openttd
15:36:31 <DorpsGek> [OpenTTD/dibridge] poVoq commented on issue #229: Strange error caused the bridge to stop relaying messages https://github.com/OpenTTD/dibridge/issues/229
15:37:35 *** keikoz has quit IRC (Ping timeout: 480 seconds)
15:39:03 <DorpsGek> [OpenTTD/dibridge] TrueBrain commented on issue #229: Strange error caused the bridge to stop relaying messages https://github.com/OpenTTD/dibridge/issues/229
15:43:26 *** keikoz has joined #openttd
15:43:38 *** keoz has quit IRC (Read error: Connection reset by peer)
15:52:59 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #12463: Codechange: replace loops with lengthof with more C++-style solutions https://github.com/OpenTTD/OpenTTD/pull/12463
15:56:20 <xarick> I got Otvi in a more acceptable state
15:56:45 <xarick> there's still the occasional CPU Valuator
15:57:02 <xarick> can't handle too many towns
16:22:15 <Eddi|zuHause> how about we go with the times and just release 14.1, because that has less bugs than 14.0?
16:23:12 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #12463: Codechange: replace loops with lengthof with more C++-style solutions https://github.com/OpenTTD/OpenTTD/pull/12463
16:25:30 *** keikoz has quit IRC (Ping timeout: 480 seconds)
16:25:41 *** matusguy has joined #openttd
16:28:45 *** Flygon has joined #openttd
16:32:17 <truebrain> Eddi|zuHause: Lol, skipping 14.0. Smart 😄
16:32:52 <LordAro> "I hope everyone enjoyed 14.0 as released on April 1st"
16:33:15 <truebrain> Best April fools joke in OpenTTD's history
16:33:22 <LordAro> ikr
16:33:33 <LordAro> the more i think about it, the more i just want to gaslight the entire player base
16:34:44 <truebrain> https://git.tukaani.org/?p=xz.git;a=commit;h=e93e13c8b3bec925c56e0c0b675d8000a0f7f754
16:34:44 <truebrain> He has humour, that is good 🙂
16:35:16 <LordAro> "has disappeared"
16:35:19 *** Wormnest has joined #openttd
16:38:15 <truebrain> Anyway, seems he cleaned up most of the repo, so let's hope the GitHub repo opens soon again too 🙂
16:41:04 <_glx_> https://git.tukaani.org/?p=xz.git;a=blobdiff;f=NEWS;h=3913c252f1139006042ca638c089a8d80b7ad085;hp=e6a965adb9ac8e2675c4b35f22c3cebf83946639;hb=780cbf29d5a88db2b546e9b7b019c4c33ca72685;hpb=bfd0c7c478e93a1911b845459549ff94587b6ea2
16:41:21 <_glx_> this one is funny too
16:45:28 *** HerzogDeXtEr has joined #openttd
16:49:58 <truebrain> The URLs of those crappy gitwebs ... always make me laugh
16:51:27 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #12463: Codechange: replace loops with lengthof with more C++-style solutions https://github.com/OpenTTD/OpenTTD/pull/12463#pullrequestreview-1989608642
16:52:00 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #12463: Codechange: replace loops with lengthof with more C++-style solutions https://github.com/OpenTTD/OpenTTD/pull/12463#pullrequestreview-1989609846
16:54:40 *** keikoz has joined #openttd
16:58:03 *** Ox7C5_ has joined #openttd
16:58:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #12464: Codechange: Use vector and iterators for NewGRF classes instead of array. https://github.com/OpenTTD/OpenTTD/pull/12464
17:01:01 *** keoz has joined #openttd
17:01:41 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #12464: Codechange: Use vector and iterators for NewGRF classes instead of array. https://github.com/OpenTTD/OpenTTD/pull/12464#pullrequestreview-1989637758
17:02:02 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #12464: Codechange: Use vector and iterators for NewGRF classes instead of array. https://github.com/OpenTTD/OpenTTD/pull/12464#pullrequestreview-1989639357
17:02:31 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #12463: Codechange: replace loops with lengthof with more C++-style solutions https://github.com/OpenTTD/OpenTTD/pull/12463
17:02:55 *** keikoz has quit IRC (Ping timeout: 480 seconds)
17:03:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #12464: Codechange: Use vector and iterators for NewGRF classes instead of array. https://github.com/OpenTTD/OpenTTD/pull/12464#pullrequestreview-1989645639
17:09:03 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #12464: Codechange: Use vector and iterators for NewGRF classes instead of array. https://github.com/OpenTTD/OpenTTD/pull/12464
17:09:43 <peter1138> Oh, there was a red X, wonder if that was a bug or just xz 🙂
17:17:24 <Rubidium> if you're talking about 12463, then it's "xz"
17:18:52 <truebrain> still a 404 page? Awh 😛
17:21:15 <Rubidium> trying to win the lottery is getting harder :(
17:22:30 <truebrain> hopefully not much longer 🙂
17:25:25 *** keikoz has joined #openttd
17:27:05 *** keoz has quit IRC (Ping timeout: 480 seconds)
17:37:22 <DorpsGek> [OpenTTD/dibridge] TrueBrain opened pull request #230: fix(discord): don't try to send messages when there is no asyncio loop https://github.com/OpenTTD/dibridge/pull/230
17:37:38 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #12464: Codechange: Use vector and iterators for NewGRF classes instead of array. https://github.com/OpenTTD/OpenTTD/pull/12464
17:37:53 <peter1138> The old size_t comparison warnings...
17:39:37 <DorpsGek> [OpenTTD/dibridge] TrueBrain opened pull request #231: fix(discord): reconnect when websocket connection is unexpectedly lost https://github.com/OpenTTD/dibridge/pull/231
17:40:22 <DorpsGek> [OpenTTD/dibridge] TrueBrain updated pull request #230: fix(discord): don't try to send messages when there is no asyncio loop https://github.com/OpenTTD/dibridge/pull/230
17:45:20 <DorpsGek> [OpenTTD/dibridge] TrueBrain updated pull request #231: fix(discord): reconnect when websocket connection is unexpectedly lost https://github.com/OpenTTD/dibridge/pull/231
17:46:13 <DorpsGek> [OpenTTD/dibridge] TrueBrain merged pull request #230: fix(discord): don't try to send messages when there is no asyncio loop https://github.com/OpenTTD/dibridge/pull/230
17:46:25 *** marchnex has joined #openttd
17:48:36 <DorpsGek> [OpenTTD/dibridge] TrueBrain merged pull request #231: fix(discord): reconnect when websocket connection is unexpectedly lost https://github.com/OpenTTD/dibridge/pull/231
17:48:41 <DorpsGek> [OpenTTD/dibridge] TrueBrain closed issue #229: Strange error caused the bridge to stop relaying messages https://github.com/OpenTTD/dibridge/issues/229
17:55:54 <truebrain> time to roll over the dibridge to a newer version 🙂 There will be a small interruption in service 😄
17:56:35 <DorpsGek> [OpenTTD/dibridge] TrueBrain commented on issue #229: Strange error caused the bridge to stop relaying messages https://github.com/OpenTTD/dibridge/issues/229
17:57:46 *** silent_tempest has quit IRC (Remote host closed the connection)
17:57:46 *** johnfranklin has quit IRC (Remote host closed the connection)
17:57:46 *** xarick has quit IRC (Remote host closed the connection)
17:57:46 *** talltyler has quit IRC (Remote host closed the connection)
17:57:46 *** wensimehrp has quit IRC (Remote host closed the connection)
17:57:46 *** DorpsGek_vi has quit IRC (Remote host closed the connection)
17:57:46 *** isosys has quit IRC (Remote host closed the connection)
17:57:46 *** merni has quit IRC (Remote host closed the connection)
17:57:46 *** ahyangyi has quit IRC (Remote host closed the connection)
17:57:46 *** charlieatlas_ff03k64 has quit IRC (Remote host closed the connection)
17:57:46 *** _zephyris has quit IRC (Remote host closed the connection)
17:57:46 *** emperorjake has quit IRC (Remote host closed the connection)
17:57:46 *** michi_cc has quit IRC (Remote host closed the connection)
17:57:46 *** lemuria0685 has quit IRC (Remote host closed the connection)
17:57:46 *** truebrain has quit IRC (Remote host closed the connection)
17:57:46 *** praxoid has quit IRC (Remote host closed the connection)
17:57:46 *** georgevb has quit IRC (Remote host closed the connection)
17:57:46 *** kuhnovic has quit IRC (Remote host closed the connection)
17:57:46 *** rau117 has quit IRC (Remote host closed the connection)
17:57:46 *** kamnet has quit IRC (Remote host closed the connection)
17:57:46 *** reldred has quit IRC (Remote host closed the connection)
17:57:46 *** _jgr_ has quit IRC (Remote host closed the connection)
17:57:46 *** peter1138 has quit IRC (Remote host closed the connection)
17:57:46 *** frosch123 has quit IRC (Remote host closed the connection)
17:57:46 *** brickblock19280 has quit IRC (Remote host closed the connection)
17:57:46 *** locosage has quit IRC (Remote host closed the connection)
17:57:46 *** _glx_ has quit IRC (Remote host closed the connection)
17:57:46 *** andythenorth has quit IRC (Remote host closed the connection)
17:57:54 *** DorpsGek_vi has joined #openttd
17:58:52 <DorpsGek> [OpenTTD/dibridge] TrueBrain created new tag: v1.4.0 https://github.com/OpenTTD/dibridge/releases/tag/v1.4.0
17:59:07 *** truebrain has joined #openttd
17:59:07 <truebrain> w00p
18:35:12 <DorpsGek> [OpenTTD/OpenTTD] JGRennison opened issue #12465: [Bug]: Click/tooltip vertical misalignment for cargo line (CFT_CARGO) in industry chain window https://github.com/OpenTTD/OpenTTD/issues/12465
18:36:03 *** peter1138 has joined #openttd
18:36:03 <peter1138> Huh, didn't know the lines were even clickable...
18:48:29 <truebrain> never to old to learn!
18:49:23 *** xarick has joined #openttd
18:49:23 <xarick> OtviAI AfterFix?
18:49:28 <xarick> yes or no
18:50:18 <xarick> I better not
18:50:38 <xarick> just wish there was a better way to submit corrections
18:51:31 <xarick> duplicating entries is bad
19:04:17 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
19:11:22 *** _glx_ has joined #openttd
19:11:22 <_glx_> just ignore unmaintained AIs
19:12:08 *** nielsm has quit IRC (Ping timeout: 480 seconds)
19:14:08 <xarick> very difficult when they're just there, staring at me
19:14:12 <xarick> 😐
19:20:50 *** andythenorth has joined #openttd
19:20:50 <andythenorth> well
19:24:04 <Rubidium> xarick: just give the author some time to react to your post from yesterday?
19:24:51 <xarick> ^_^
19:25:42 *** _jgr_ has joined #openttd
19:25:42 <_jgr_> That author hasn't posted for nearly three years
19:30:55 *** marchnex has quit IRC (Ping timeout: 480 seconds)
19:32:48 <Rubidium> that was after being away for almost 8 years and then upgrading their AIs. I hope you'll get a faster response time than pm got (~11 years).
19:37:58 <xarick> trying to figure out ChooChoo's problem
19:38:31 <_glx_> in most cases I think the problem might be map size
19:40:06 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1227342294336802846/image.png?ex=66280e95&is=66159995&hm=0e31db818ff8ddf459e5ec7dd8c5052bd63187dea035da398a7150705658facb&
19:40:20 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #12464: Codechange: Use vector and iterators for NewGRF classes instead of array. https://github.com/OpenTTD/OpenTTD/pull/12464#pullrequestreview-1990018392
19:41:45 <xarick> ExtendCrossing, hmm let's see if there's some crossing around
19:43:24 *** kuhnovic has joined #openttd
19:43:24 <kuhnovic> https://cdn.discordapp.com/attachments/1008473233844097104/1227343124787892348/image.png?ex=66280f5b&is=66159a5b&hm=0c4f5d7319da1b1a8bb64fbf926048eef8d8e6a67d67f51a3e7a52f0c2770bba&
19:43:24 <kuhnovic> peter1138: is this related to the issue you were working on today?
19:44:38 *** Wormnest has joined #openttd
19:45:21 <peter1138> Are you up to date?
19:45:57 <_jgr_> Your fix hasn't been merged yet
19:46:06 <peter1138> Oh.
19:46:10 <peter1138> That would do it 🙂
19:50:38 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #12460: Fix #12459, f6a88e4: Crashes when deleting news messages. https://github.com/OpenTTD/OpenTTD/pull/12460
19:52:04 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #12460: Fix #12459, f6a88e4: Crashes when deleting news messages. https://github.com/OpenTTD/OpenTTD/pull/12460#pullrequestreview-1990035234
20:02:09 *** Ox7C5_ has quit IRC ()
20:04:49 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
20:04:55 *** marchnex has joined #openttd
20:06:04 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic approved pull request #12460: Fix #12459, f6a88e4: Crashes when deleting news messages. https://github.com/OpenTTD/OpenTTD/pull/12460#pullrequestreview-1990056572
20:06:53 <kuhnovic> Admittedly, that's more of a "looks good to me" review than anything else
20:07:14 <kuhnovic> But you tend to be quick with fixing things you introduce yourself 😛
20:11:27 <peter1138> It would be better if I was more careful and didn't break things.
20:11:50 <kuhnovic> We all sin
20:21:51 <Rubidium> it's back baby ;)
20:24:01 <truebrain> the xz repo too 😉
20:24:20 <truebrain> so 14.0 when?
20:24:53 <LordAro> :o
20:26:50 <truebrain> 8 PRs that want backporting ... scary
20:33:29 *** michi_cc has joined #openttd
20:33:29 <michi_cc> Did someboday say 14.1? 😛
20:38:37 <_glx_> oh nice 14 CVE fixed in VS 17.9.6
20:39:34 <_glx_> (13 for RCE in ODBC)
20:43:09 <_glx_> I can do the backports (my personal token should still be valid since last backport run)
20:46:34 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #12460: Fix #12459, f6a88e4: Crashes when deleting news messages. https://github.com/OpenTTD/OpenTTD/pull/12460
20:46:37 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #12459: [Crash]: Selling a vehicle after returning to depot https://github.com/OpenTTD/OpenTTD/issues/12459
20:47:02 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #12464: Codechange: Use vector and iterators for NewGRF classes instead of array. https://github.com/OpenTTD/OpenTTD/pull/12464
20:53:34 <_glx_> of course it fails to build with <https://github.com/OpenTTD/OpenTTD/pull/12432>
20:53:52 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #12466: Backport master into release/14 https://github.com/OpenTTD/OpenTTD/pull/12466
20:54:05 <_glx_> (won't build I know)
20:55:50 <_glx_> but it will build the deps for other runs 🙂
20:59:10 <_glx_> oh ok, backport script failed
20:59:53 <_glx_> it only took the last commit from the PR
21:00:34 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #12467: Codechange: use C++ algorithms to determine the SaveLoadFormat https://github.com/OpenTTD/OpenTTD/pull/12467
21:00:45 <peter1138> Heh
21:00:58 <peter1138> "I have a patch for that" ... too late again 🙂
21:05:15 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #12094: Change: Raise object/station/roadstop class limit. https://github.com/OpenTTD/OpenTTD/pull/12094
21:07:45 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #12467: Codechange: use C++ algorithms to determine the SaveLoadFormat https://github.com/OpenTTD/OpenTTD/pull/12467#pullrequestreview-1990151904
21:07:56 <peter1138> Almost the same but a bit better.
21:08:14 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #12466: Backport master into release/14 https://github.com/OpenTTD/OpenTTD/pull/12466
21:08:22 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #12466: Backport master into release/14 https://github.com/OpenTTD/OpenTTD/pull/12466
21:11:50 *** keoz has joined #openttd
21:12:11 <LordAro> be nice if could get rid of the faintly nasty multichar 'char' literals as well
21:12:39 <LordAro> but there's not really a good alternative
21:13:41 *** keikoz has quit IRC (Ping timeout: 480 seconds)
21:15:41 <peter1138> We have a special compiler option to allow that...
21:16:37 <Rubidium> LordAro: feel free to reimplement it using a string literal ;)
21:17:08 <Rubidium> maybe you can even use the string literal to encode the encoding of the literal?!?
21:20:31 <peter1138> Given some magic, would `"OTTN"` be better than`'OTTN'`?
21:22:12 *** keikoz has joined #openttd
21:22:39 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #12466: Backport master into release/14 https://github.com/OpenTTD/OpenTTD/pull/12466
21:23:53 *** keoz has quit IRC (Ping timeout: 480 seconds)
21:24:06 <_glx_> should be fine now
21:26:18 <_glx_> oh I think backport script "failed" to properly cherry-pick https://github.com/OpenTTD/OpenTTD/pull/12432 because one of the commit message is the same as PR title and it thinks it was squashed
21:27:13 <Rubidium> _glx_: weirdly enough the script worked for me, but maybe I've got an old one or so?
21:27:38 <_glx_> ```Merging #12432: Fix: do not use lengthof() for non C-style arrays
21:27:38 <_glx_> -> was squashed
21:27:38 <_glx_> Commit #0: 97bea563d73ed493ddbe0b72309421f9f1c0aad2 ...```
21:27:56 <_glx_> and 97b... is the second commit from the PR
21:28:05 <_glx_> first one was discarded
21:28:12 *** marchnex has quit IRC (Quit: marchnex)
21:28:48 <truebrain> It does indeed use the commit messages to figure out whether it is squashed
21:29:05 <_glx_> bad luck on this one then
21:29:09 <truebrain> Also fails if the commit message was changed during squashing, I imagine
21:30:29 <_glx_> maybe, on squash commit message is usually changed, compared to title there's `(#PRNUMBER)`
21:31:39 <truebrain> https://github.com/OpenTTD/scripts/blob/e8da454d824a0f842eab6c8d04539f4337f67e37/backport/backport.py#L198
21:31:39 <truebrain> Go nuts 🙂
21:31:43 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #12094: Change: Raise object/station/roadstop class limit. https://github.com/OpenTTD/OpenTTD/pull/12094#pullrequestreview-1990186196
21:33:02 <peter1138> Bah, can't static_assert a string_view's length unless the string_view is contexpr.
21:33:22 <truebrain> Owh, if the message is changed, it is considered squashed .. makes more sense
21:35:24 <_glx_> at least I can confirm <https://github.com/OpenTTD/OpenTTD/pull/12432/commits/464e781bdf49cf48590771ccb930957bc4f53e36> does what it's supposed to do 🙂
21:36:15 <Rubidium> yeah, sorry for making it break 14 in some other places
21:36:43 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #12467: Codechange: use C++ algorithms to determine the SaveLoadFormat https://github.com/OpenTTD/OpenTTD/pull/12467
21:37:17 <_glx_> only 3 locations affected
21:37:36 <peter1138> Oh, but I can make a consteval function fail to compile...
21:37:59 <_glx_> 2 fixed with a commit from #12159 modified to also fix the 3d location
21:39:02 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #12451: Codechange: replace last cases of endof with other (safer) constructs https://github.com/OpenTTD/OpenTTD/pull/12451
21:39:30 <_glx_> come on MinGW, build faster 🙂
21:41:44 <truebrain> Lol
21:42:15 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #12466: Backport master into release/14 https://github.com/OpenTTD/OpenTTD/pull/12466#pullrequestreview-1990199466
21:45:33 <DorpsGek> [OpenTTD/website] rubidium42 closed pull request #313: Add: post about the XZ backdoor and the effect on us https://github.com/OpenTTD/website/pull/313
21:45:36 <DorpsGek> [OpenTTD/website] rubidium42 commented on pull request #313: Add: post about the XZ backdoor and the effect on us https://github.com/OpenTTD/website/pull/313#issuecomment-2046100321
21:46:18 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #12466: Backport master into release/14 https://github.com/OpenTTD/OpenTTD/pull/12466
21:54:25 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #12094: Change: Raise object/station/roadstop class limit. https://github.com/OpenTTD/OpenTTD/pull/12094#issuecomment-2046109863
22:01:13 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:12:30 *** matusguy has quit IRC (Remote host closed the connection)
22:16:23 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #12094: Change: Raise object/station/roadstop class limit. https://github.com/OpenTTD/OpenTTD/pull/12094
22:44:23 <truebrain> Yippie, finally I can run some performance benchmarks again 😄 also found a bug in my scripting for it 😛
23:32:35 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #12468: Codechange: Pass std:;string_view from drivers/blitters instead of char *. https://github.com/OpenTTD/OpenTTD/pull/12468
23:38:58 <truebrain> Sneaking in a backdoor? 😄 `:;` .. I see what you did there 😛
23:42:17 <peter1138> Foiled
23:49:29 *** tokai|noir has joined #openttd
23:49:29 *** ChanServ sets mode: +v tokai|noir
23:56:26 *** tokai has quit IRC (Ping timeout: 480 seconds)