IRC logs for #openttd on OFTC at 2024-03-08
            
00:19:20 <peter1138> Okay, what sets other than an ancient UKRS have running sounds...
00:21:33 *** Flygon has joined #openttd
00:21:51 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
00:25:39 *** emperorjake has joined #openttd
00:25:39 <emperorjake> NARS 2.03
00:28:13 <peter1138> Yup.
00:46:33 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #12229: Fix: Train running sounds should only be produced for engine parts. https://github.com/OpenTTD/OpenTTD/pull/12229
01:45:14 *** wallaby2 has joined #openttd
01:49:19 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #12229: Fix: Train running sounds should only be produced for engine parts. https://github.com/OpenTTD/OpenTTD/pull/12229#pullrequestreview-1923886333
01:49:44 *** wallabra has quit IRC (Read error: No route to host)
01:56:11 <peter1138> `TTDPatch: Not enough free memory!`
01:56:12 <peter1138> Aww
01:56:33 <Eddi|zuHause> is NARS less ancient than UKRS?
01:57:34 <Eddi|zuHause> the germanrv set might have custom tram sounds?
02:01:26 *** D-HUND is now known as debdog
02:06:40 <reldred> Comparatively ancient
02:18:48 <peter1138> Normal sounds are fine, it's running sounds that can have timing issues.
02:28:22 *** Leopold_ has quit IRC (Remote host closed the connection)
02:30:20 *** Leopold has joined #openttd
02:55:28 *** Flygon has quit IRC (Read error: Connection reset by peer)
03:00:05 *** herms has quit IRC (Quit: bye)
03:02:27 *** Wormnest has quit IRC (Quit: Leaving)
03:05:40 *** herms has joined #openttd
03:40:51 *** D-HUND has joined #openttd
03:44:16 *** debdog has quit IRC (Ping timeout: 480 seconds)
03:45:50 *** gnu_jj has joined #openttd
03:49:17 *** gnu_jj_ has quit IRC (Ping timeout: 480 seconds)
03:49:24 *** D-HUND is now known as debdog
03:51:56 *** Leopold has quit IRC (Remote host closed the connection)
03:53:10 *** Leopold_ has joined #openttd
04:40:41 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/216905ce1f98836fa562a0db96b571121c68db17
04:40:42 <DorpsGek> - Update: Translations from eints (by translators)
05:08:56 *** keikoz has joined #openttd
06:08:01 *** keikoz has quit IRC (Ping timeout: 480 seconds)
06:38:36 *** Leopold___ has joined #openttd
06:38:41 *** Leopold_ has quit IRC (Remote host closed the connection)
06:49:03 <kuhnovic> xarick: Curious to see what your fix is, do you have a commit somewhere?
08:30:27 *** Leopold___ has quit IRC (Remote host closed the connection)
08:31:57 *** Leopold has joined #openttd
09:02:49 <rau117> https://cdn.discordapp.com/attachments/1008473233844097104/1215585504603537428/image.png?ex=65fd4938&is=65ead438&hm=9bfb32d5f23bf1838073cee7e395061fc18cef7c98322f5cbc3f4e7bfa8ad7b9&
09:02:49 <rau117> Is the absence of icons in the refit window intended?
09:02:49 <rau117> *There is even a small window where the icon just fits...*
09:11:22 <peter1138> Well they don't get drawn automatically, we need to code it.
09:12:45 <peter1138> Hmm, on X, 1387 followers, 84 likes, 24 retweets. On Fosstodon, 415 followers (now, it's gone up a lot since), 237 likes, 155 boosts.
09:13:50 <LordAro> a lot of dead users on twitter, i imagine
09:13:53 <LordAro> i'm one of them
09:14:02 <truebrain> you seem alive to me?
09:14:18 <LordAro> that's what you think
09:14:26 <ahyangyi> Alive elsewhere but dead on X
09:14:27 <truebrain> just an AI trained on your conversations, I see
09:14:48 <truebrain> explains the lack of PRs πŸ˜› πŸ˜› πŸ˜› πŸ˜› (sorry, I had to, forgive me πŸ˜› )
09:14:57 <LordAro> :c
09:15:29 <truebrain> you know I love you πŸ™‚
09:15:41 <truebrain> reminds me your last PR introduced a bug; we still need to fix that for 14.0 πŸ™‚
09:15:51 <truebrain> you can no longer put tram tracks on a road bridge πŸ˜›
09:16:02 <peter1138> Oops
09:16:47 <LordAro> mm yes
09:16:57 <LordAro> bad feature
09:17:00 <LordAro> intentional removal
09:17:12 <truebrain> not bad feature; unintentional consequences πŸ˜„
09:18:50 <peter1138> Do we need a "patch setting" to hide all those extra cargo icons I spammed?
09:19:01 <truebrain> no
09:19:12 <peter1138> But one (1) player complained!
09:19:25 <truebrain> Just because something is different, doesn't mean it needs toggling
09:20:09 <truebrain> peter1138: yes, and the irony is that the user that agree'd with that player, is now asking to add the icons in more places
09:20:10 <truebrain> just saying πŸ˜›
09:21:02 <peter1138> Finally. Coffee.
09:22:33 <locosage> peter1138: would be nice to have some utility code int the game to add icons easier
09:22:49 <locosage> I tried something in cmclient but it's pretty ugly <https://github.com/citymania-org/cmclient/blob/36001f85d138dd711462bd6075ee184c6b6cd49f/src/citymania/cm_overlays.cpp#L162-L219>
09:23:41 <locosage> ideally it would be a string code I think
09:24:21 <locosage> but I so don't want to get into text layouters πŸ˜΅β€πŸ’«
09:38:05 <peter1138> Cargo icons would want (slightly) separate handling from an add-your-own-custom-icon-in-text feature. anyway.
09:41:46 <locosage> yeah, I'm talking cargo icons here
09:41:47 <locosage> well, own-custom-icon can be added as svg-only
09:43:26 <locosage> though I guess it's not impossible to add cargo icons as svg-only too
09:43:41 <locosage> just don't show them for cargos that don't provide svg
10:21:15 <DorpsGek> [OpenTTD/OpenTTD] 0marduk started discussion #12230: What exactly is "dirty" in the engine? https://github.com/OpenTTD/OpenTTD/discussions/12230
10:24:29 <_zephyris> locosage: We need peter1139's svg sprites πŸ™‚
10:25:16 <_zephyris> But it does seem like there's a separate desire for more icons in the private unicode range
10:27:22 <locosage> more icons for the god of icons! xD
10:27:41 <_zephyris> Where can I find which of the unicode private range is currently used? Where's it safe to add more?
10:27:53 <_zephyris> Icons for the icon god, glyphs for the glyph throne.
10:28:15 <_zephyris> The typography warhammer 40k crossover you didn't know you needed.
10:40:24 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on discussion #12230: What exactly is "dirty" in the engine? https://github.com/OpenTTD/OpenTTD/discussions/12230
10:46:03 <peter1138> Yeah, 95 new followers so far from the 20th Birthday fediverse post.
10:48:33 <michi_cc> _zephyris: U+E200 to U+E2FF is special in so far as that range will fallback to sprite glyphs if nothing is present in the loaded TTF. This is part of the normal PUA from U+E000 to U+F8FF.
10:50:58 <michi_cc> Of course some software uses parts of the PUA as well, e.g. Apple puts some stuff into U+F400 to U+F8FF.
10:54:13 <michi_cc> And if you want to know what we are currently using: https://github.com/OpenTTD/OpenTTD/blob/master/src/table/control_codes.h#L167
10:55:19 <michi_cc> Oh, and from the same file, U+E000 to U+E1FF is potentially used for the encoded string control codes.
11:05:22 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1215616348604989461/image.png?ex=65fd65f2&is=65eaf0f2&hm=3d3d1d79a942cc239fa8bc6545f05c3bbd401765e579a4fefe6e3b1738e96d6a&
11:05:22 <xarick> text overlap
11:05:25 <peter1138> Yes but everything from E220 to E2FF is mapped to the spritefont's 32-255 range.
11:07:15 <peter1138> I guess most of those are not actually needed though.
11:10:41 <peter1138> We could maybe extend the range which would ensure nothing default uses it. But NewGRFs could still conflict.
11:31:34 <xarick> building openttd takes so long nowadays I forget what I was doing by the time it finishes
11:43:25 <LordAro> surely you're not doing full rebuilds every time?
11:43:55 <LordAro> unless you're modifying strings or some other low-level header, the rebuild time should be fairly low
11:45:45 <_zephyris> peter1138: No worse than newgrfs messing with base set sprites...
11:46:38 <peter1138> No, but when implementing a new solution, if we can do something better that avoids conflicts, we should do that.
11:47:18 <peter1138> 32 bit glyph labels? πŸ˜„
11:47:53 <_zephyris> Grfid plus a byte
11:48:07 <andythenorth> what is mullering my CPU?
11:48:10 <andythenorth> lag
11:48:10 <_zephyris> Good point though
11:48:12 <peter1138> "I reserve the range 0xE300 to 0xE33F for my own personal NewGRFs, nobody else should touch them..."
11:48:26 <andythenorth> that's my range
11:48:27 <michi_cc> peter1138: It is only mapped if the TTF does not provide a matching glyph though.
11:48:29 <andythenorth> stop it
11:49:37 <xarick> I blame translators, lol
11:49:43 <xarick> they're the ones modifying strings
11:49:48 <xarick> j/k
11:50:14 <peter1138> No, it's NewGRF authors trying to use the string system to draw images πŸ˜„
11:50:54 <peter1138> I did also wonder if we could just provide a default set of glyphs based on what people are currently doing, and build that in.
11:51:25 <peter1138> If they're standard then they could be put into OpenTTD Sans too.
11:51:47 <peter1138> But "I need this other slightly different icon!" would be a thing.
11:52:20 <_zephyris> Yes, and yes.
11:52:25 <merni> https://cdn.discordapp.com/attachments/1008473233844097104/1215628186495229992/image.png?ex=65fd70f8&is=65eafbf8&hm=c2c3357b41a63bc9f5f80308447d800d8897c10b8a99bf619581cd2dd91934a2&
11:52:25 <merni> Well, they also try to use the image system to draw strings... :p
11:52:36 <peter1138> Yikes
11:52:53 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened issue #12231: [Bug]: https://github.com/OpenTTD/OpenTTD/issues/12231
11:52:57 <peter1138> [Bug]:
11:52:57 <merni> That makes the image column of the whole list needlessly huge
11:53:07 <xarick> oh snap, forgot title
11:53:31 <merni> https://cdn.discordapp.com/attachments/1008473233844097104/1215628465907310612/image.png?ex=65fd713b&is=65eafc3b&hm=60c6eb26461453a10da3dea0629572b637d21e8e339aa7a1c66a0226180f6d73&
11:53:31 <merni> and that is not even the worst part of that set...
11:54:26 <merni> Because someone likes their neat alignment with a massive number of spaces, I cannot see whether something is electric or diesel without making the purchase list cover the whole screen :p
11:54:53 <merni> The trains look nice though so that makes up for everything :p
11:54:58 <peter1138> What set is that? I need to see the horror for myself.
11:55:19 <peter1138> I'm not sure, they look very flat and plain. Not really any shading at all.
11:55:46 <merni> Czech Railways Set 1.0 and Czech Railways Set EXTRA 1.1
11:56:56 <merni> I guess what I like is that they look quite close to the real ones :p
11:57:34 <belajalilija> There’s another Czech set but its much smaller
11:57:44 <belajalilija> It is a bit better though
11:57:55 <belajalilija> Graphically
11:59:31 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1215629972073353286/image.png?ex=65fd72a2&is=65eafda2&hm=81448aa9f374fb9c8ccbd36a1d9973b1d24eb3dd12c5d1868b81373e00a5cd6e&
11:59:31 <peter1138> "Good job" on that alignment...
12:01:07 <merni> It probably works only on OpenGFX sprite font
12:01:17 <merni> At least, that's what I have and it works
12:02:30 <_zephyris> Support tabs characters?
12:02:56 <merni> I think a better idea is not to do such weird things
12:03:00 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1215630849450446928/image.png?ex=65fd7373&is=65eafe73&hm=16db0653b5ab535820ff00ce7d0d59fd95f184dd102639450569f1a4a92cce99&
12:03:00 <peter1138> Perfect with OpenGFX 2.
12:05:14 <peter1138> It's actually not too bad with OpenTTD Sans.
12:05:24 <peter1138> Arial or Verdana or Tahoma is lolrious though.
12:06:00 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #12232: Fix #12228: Don't restrict path when checking ship reverse on first attempt https://github.com/OpenTTD/OpenTTD/pull/12232
12:06:55 <merni> SamuXarickviaGitHub: Is there a useful difference between stuck and lost?
12:07:17 <merni> also, wow, the number of PRs is growing close to the number of issues
12:07:32 <peter1138> So, anyone here know anything about AS2?
12:15:17 <peter1138> And how many CRS326-4C+20G+2Q+RM are appropriate for home use?
12:18:18 <michi_cc> Zero, probably πŸ˜›
12:19:09 <xarick> merni: it would mean ships would go out wandering aimlessly which is "prettier" to look at.
12:20:35 <xarick> ... design philosophy of Kuhnovic
12:21:23 <xarick> ... I'd prefer they'd get closest to the best tile they could get, but that's another story
12:32:23 <peter1138> When there's no path so there's no closest...
12:33:26 *** keikoz has joined #openttd
12:35:42 <reldred> peter1138: meh, crs518's for home use πŸ˜›
12:40:55 <peter1138> Plugged in to andy's MBP.
12:51:56 <LordAro> peter1138: clearly should automatically collapse repeated space characters
12:52:09 <LordAro> peter1138: also, probably zero
12:52:42 <peter1138> PR for that?
12:53:13 <peter1138> They'd just work around it with different types of space πŸ˜„
12:53:47 <peter1138> If you want your NewGRF to look unsightly, go ahead.
13:05:30 <andythenorth> peter1138: but using powerline-etherner
13:11:48 <andythenorth> I have powerline ethernet for the TV stuff, there are about 5 devices in one cabinet, and there's 2 cast iron radiators directly between them and the nearest AP
13:13:06 <andythenorth> the powerline ethernet is **slower** than the highest real rate on wifi, but probably more stable, and getting those devices off the radio seems to cause other nearby devices to have a happier time
13:19:40 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened issue #12233: [Bug]: Text overlap in company vehicle lists https://github.com/OpenTTD/OpenTTD/issues/12233
13:20:44 <truebrain> merni: there is a simple fix for that ...... πŸ˜› Well, two actually.
13:22:26 <DorpsGek> [OpenTTD/OpenTTD] michicc opened pull request #12234: Codechange: Remove pointer parameters in foundation/slope code. https://github.com/OpenTTD/OpenTTD/pull/12234
13:22:54 <michi_cc> Oh no, it's growing even more πŸ™‚
13:23:37 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #12217: Fix: YAPF doesn't check destination for start nodes https://github.com/OpenTTD/OpenTTD/pull/12217
13:23:37 <truebrain> there, made room for you
13:23:51 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #12229: Fix: Train running sounds should only be produced for engine parts. https://github.com/OpenTTD/OpenTTD/pull/12229
13:24:03 <michi_cc> Now there's even more room πŸ˜€
13:25:04 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #12108: Add: Portuguese Escudo currency https://github.com/OpenTTD/OpenTTD/pull/12108
13:26:04 <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #12177: Codefix #12162, 3105d0b: Textbuf::Assign read beyond std::string_view https://github.com/OpenTTD/OpenTTD/pull/12177#pullrequestreview-1924878091
13:26:17 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #12177: Codefix #12162, 3105d0b: Textbuf::Assign read beyond std::string_view https://github.com/OpenTTD/OpenTTD/pull/12177
13:26:20 <DorpsGek> [OpenTTD/OpenTTD] michicc closed issue #12162: [Bug]: Incorrect usage of std::string_view::data in Textbuf::Assign https://github.com/OpenTTD/OpenTTD/issues/12162
13:28:53 <LordAro> so much room for activities!
13:29:08 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #12139: Fix #12134: Use correct error messages if clearing drive-through road stops fails https://github.com/OpenTTD/OpenTTD/pull/12139
13:29:11 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed issue #12134: [Bug]: Incorrect error message trying to demolish through bus station in town with very low company rating https://github.com/OpenTTD/OpenTTD/issues/12134
13:29:14 <truebrain> that PR isn't actually helping .. does things on both sides ...
13:31:38 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #12130: Fix 3947453, ccb4c37: Incorrect bitwise usage https://github.com/OpenTTD/OpenTTD/pull/12130
13:31:48 <truebrain> some PRs are marked as "backport requested", but I am not always sure that is a good idea πŸ™‚
13:34:38 <peter1138> Unflag it then πŸ™‚
13:35:50 <truebrain> I DID! πŸ™‚
13:36:10 <truebrain> I am always so scared of introducing stupid bugs so close to release, because the fix "looked fine" πŸ˜›
13:40:27 <peter1138> I think that particular one was not flagged by me πŸ˜‰
13:40:36 <truebrain> it was not πŸ™‚
13:41:45 <merni> truebrain: whoo
13:41:47 <merni> time for RC2?
13:42:02 <LordAro> only a month to go
13:42:06 <truebrain> dunno .. do we want to? No clue πŸ™‚
13:42:11 <LordAro> any titlegame submissions yet? :p
13:42:59 *** TrueBrain_ii has joined #openttd
13:43:05 <_glx_> #12205 needs reviewing πŸ˜‰
13:43:36 <merni> LordAro: https://www.tt-forums.net/viewtopic.php?t=91448 three so far
13:45:08 <truebrain> _glx_: I assume that review thing is resolved?
13:46:34 <merni> truebrain: well, if all these backport-requested PRs are going to be backported (33 atm), that might improve the playing experience quite a bit
13:46:53 <truebrain> yup; but we have to be careful to not add crashing bugs πŸ˜›
13:46:54 <merni> Especially ones such as 12158
13:47:16 <merni> truebrain: Isn't it better that happens in RC2 than in the final release? :P
13:47:34 <truebrain> merni: bugs we introduced in 14.0 should be fixed, yes πŸ™‚ That is always easy πŸ™‚
13:47:40 <_glx_> it's better to not backport more than necessary πŸ™‚
13:47:41 <truebrain> it is more those fixes that are ... 10+ years old bugs, etc πŸ˜›
13:48:27 <LordAro> depends on the fix
13:48:48 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #12205: Change: [Script] Match FormatString behaviour more closely https://github.com/OpenTTD/OpenTTD/pull/12205#pullrequestreview-1924920167
13:48:59 <merni> Yeah... even fixing 10 year old bugs is a good thing and why deprive 14.0 users of that and make them wait a year?
13:49:05 *** TrueBrain_ii has quit IRC (Quit: Page closed)
13:49:15 <truebrain> that is the always ending argument
13:49:18 <truebrain> "why not add this feature"
13:49:19 <truebrain> etc
13:49:28 <truebrain> but in the end, stability is more important than perfection πŸ™‚
13:49:36 <_glx_> depends on bug severity too
13:50:19 <truebrain> and yes, that makes fixes around March each year always a bit meh, as it takes a year before the end-user sees them
13:50:22 <truebrain> solution: release more often
13:50:26 <truebrain> owh boy, how often we said that πŸ˜›
13:50:47 <_glx_> yeah "nobody" plays nightlies
13:52:06 <LordAro> last time we tried that we had a beta for about 6 months then just released in April anyway
13:52:12 <truebrain> πŸ˜„
13:52:17 <truebrain> we had an early release once!
13:52:30 <truebrain> because I really did not want to wait 6 months to test out the new multiplayer on a big group of people
13:56:34 <truebrain> but the only thing that caused was that the next release took 18 months, not 12 πŸ˜›
14:03:44 <talltyler> I will work on my blog post today, so you can tease it in tomorrow’s post.
14:37:17 <michi_cc> talltyler: There's a teaser for the survey blog in it right now. Can be changed of course, but please "fight" with TB over the spot πŸ™‚
14:40:16 <xarick> wow, yapf changes got merged, that is so scary
14:42:00 <LordAro> it's going to leap out and attack you
14:42:49 <xarick> I should notice an immediate difference in performance
14:42:53 <xarick> on these large savegames
14:44:14 <truebrain> michi_cc: no no, you can pick who is next πŸ˜„ You are the author of the blog πŸ˜› We all picked the next person πŸ˜„
14:44:45 <michi_cc> Well, then it stays as it is. I want to keep my pun πŸ™‚
14:48:18 <kuhnovic> xarick: Why is that?
14:48:54 <truebrain> kuhnovic: more importantly, check your DMs πŸ˜›
14:51:55 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1215673358490931240/image.png?ex=65fd9b0a&is=65eb260a&hm=2b5421d4c8fdc24969f3375aad3d1132b77acb32cdf89e996069883b7ad415ce&
14:51:55 <peter1138> Oh dear.
14:52:47 <LordAro> lol
14:58:30 <belajalilija> peter1138: oh god where is this
14:58:48 <truebrain> looks like Steam
14:59:20 <xarick> I thought he hated OpenTTD existence
14:59:39 <michi_cc> You expect qualified comments on the Steam forums?
15:00:10 <truebrain> verified, yes
15:00:29 <truebrain> they should send CS a letter, asking if he is proud
15:00:33 <truebrain> and publish the answer
15:01:31 <belajalilija> xarick: he does
15:02:19 <LordAro> iirc the phrasing used was less harsh than that
15:03:46 <LordAro> more along the lines of "i don't like it as TTD was 'finished' and any further changes does not fit my vision"
15:04:02 <LordAro> but maybe that was overinterpretation and wishful thinking too
15:04:35 <michi_cc> kuhnovic: Finally paying back your debt from being at the Brussel meeting I see? πŸ˜€
15:05:19 <kuhnovic> All I had to do is show up to a meetup! Oh yeah and build a new ship PF πŸ˜‰
15:05:32 <truebrain> Gratz kuhnovic ; it is well deserved πŸ™‚
15:05:35 <LordAro> \o/
15:05:42 <michi_cc> Now find some button to press.
15:05:56 <kuhnovic> Thank you guys, I feel honored
15:06:27 <LordAro> merge #12209 :p
15:06:42 <truebrain> haha
15:07:03 <xarick> maybe better performance, as detect destination is called less often now, am I right?
15:08:13 <peter1138> CREDITS.md is wrong.
15:08:26 <kuhnovic> xarick: It actually has very little to do with performance, I wonder if it would even be measurable. It's more about pathfinder correctness. Starting nodes can be destination nodes too, and that case was handled poorly
15:08:27 <truebrain> I ordered him to fix that first, yes πŸ˜›
15:09:56 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed pull request #12095: Codechange: use {HEX} instead of custom hex format and {(RAW_)STRING} https://github.com/OpenTTD/OpenTTD/pull/12095
15:09:59 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #12095: Codechange: use {HEX} instead of custom hex format and {(RAW_)STRING} https://github.com/OpenTTD/OpenTTD/pull/12095#issuecomment-1985864301
15:10:02 <peter1138> Also it might not hurt to credit some 'minor' contributors too.
15:10:14 <truebrain> go for it!
15:10:28 <truebrain> as we should πŸ™‚
15:10:54 <xarick> okay, I am wrong
15:11:04 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #10273: Fix #10151: Use otmAscent instead of otmTextMetrics.tmAscent [Windows] https://github.com/OpenTTD/OpenTTD/pull/10273#issuecomment-1985866127
15:11:15 <xarick> first impressions seems to be improved performance
15:12:27 <kuhnovic> That's unforeseen then πŸ˜‰
15:12:49 <xarick> not actually measuring it
15:13:10 <xarick> maybe I should use TicToc
15:13:25 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #12220: Fix #12203: When unbunching at a depot, don't overlook implicit orders https://github.com/OpenTTD/OpenTTD/pull/12220#pullrequestreview-1925095182
15:15:26 <michi_cc> Hmm, <https://wiki.openttd.org/en/Development/NewGRF/Specification%20Status> seems to have broken. I only get a blank page, but other wiki pages work just fine.
15:15:37 <truebrain> that is not you
15:15:38 <truebrain> let me check
15:15:43 <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on pull request #10273: Fix #10151: Use otmAscent instead of otmTextMetrics.tmAscent [Windows] https://github.com/OpenTTD/OpenTTD/pull/10273#issuecomment-1985873655
15:16:07 <truebrain> no errors on the backend .. hmmm
15:16:08 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #10273: Fix #10151: Use otmAscent instead of otmTextMetrics.tmAscent [Windows] https://github.com/OpenTTD/OpenTTD/pull/10273#issuecomment-1985874355
15:16:55 <peter1138> Heh
15:17:05 <truebrain> it does work if you log in
15:17:06 <truebrain> lol
15:17:35 <peter1138> Also Zephyris made some improvements to OpenTTD Sans for Cyrillic, would be nice to get a new release merged πŸ˜‰
15:18:02 <truebrain> better font support!
15:19:07 <peter1138> I think there were some Hebrew characters as well, not sure if they are done yet.
15:19:21 <talltyler> michi_cc: No, that’s perfect. Gives me another week to procrastinate! πŸ˜›
15:19:53 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler merged pull request #12220: Fix #12203: When unbunching at a depot, don't overlook implicit orders https://github.com/OpenTTD/OpenTTD/pull/12220
15:19:56 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler closed issue #12203: [Bug]: Unbunching fails if unbunch-order is preceded by implicit order https://github.com/OpenTTD/OpenTTD/issues/12203
15:20:16 <_glx_> truebrain: 14.0 table looks wrong when logged in
15:20:33 <truebrain> michi_cc: for some reason the caching cached a white page πŸ˜›
15:20:57 <truebrain> now I need to remember how I could remove it from the cache πŸ™‚
15:21:16 <peter1138> Update the page?
15:21:33 <truebrain> or delete the cached page
15:21:34 <truebrain> fixed!
15:21:45 <truebrain> _glx_: that is a "not-me" problem πŸ˜„
15:21:49 <peter1138> Pfft πŸ˜„
15:22:35 <peter1138> `CBID_VEHICLE_BUILD_PROBABILITY` is making it too wide.
15:22:48 <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on pull request #10273: Fix #10151: Use otmAscent instead of otmTextMetrics.tmAscent [Windows] https://github.com/OpenTTD/OpenTTD/pull/10273#issuecomment-1985886195
15:22:51 <peter1138> Probably just remove that text πŸ™‚
15:22:52 <truebrain> right, so I should fix my caching script to not store 0 byte caches πŸ™‚
15:22:55 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #12183: Change: Throw out per-grf industry tile limit. https://github.com/OpenTTD/OpenTTD/pull/12183#issuecomment-1985886439
15:23:39 <truebrain> seems it is a rare bug, as I can't find any other 0 byte cache entry πŸ™‚
15:23:41 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1215681355459985460/image.png?ex=65fda27d&is=65eb2d7d&hm=f7ca00c4e033ba72f90e3c965a0d694c745f68fd1b96ca4ae5fbb0ab14c5903e&
15:23:41 <xarick> hmm, strange to see AAAHogEx not performing. I'm using Time features...
15:23:53 <_zephyris> peter1138: Yup, but I was waiting to see if any new translations introduced any more missing characters.
15:24:20 <_zephyris> peter1138: Some sketches, nothing confirmed as readable by a Hebrew speaker!
15:24:35 <truebrain> almost 27 languages are fully translated; damn
15:25:16 <truebrain> (14 are actually fully translated, but 13 are very close; can't blame them for not staying up-to-date constantly πŸ˜„ )
15:25:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #12183: Change: Throw out per-grf industry tile limit. https://github.com/OpenTTD/OpenTTD/pull/12183#issuecomment-1985890584
15:25:41 <truebrain> still leaves 23 languages that are not complete, some not even close
15:25:42 <peter1138> _zephyris: Is that because it's unreadable, or no response?
15:25:54 <_zephyris> No response πŸ™‚
15:25:57 <xarick> What does Time do to scripts? They're not performing
15:26:35 <_glx_> it doesn't change anything on script side
15:26:46 <peter1138> IIRC it's not as complex and picky about shapes as something like Arabic.
15:27:28 <xarick> AAHog at the bottom of profits is not normal
15:27:29 <peter1138> Maybe we can get some in game comparison screenshots?
15:27:48 <_glx_> except some part of the game go slower
15:27:54 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #12183: Change: Throw out per-grf industry tile limit. https://github.com/OpenTTD/OpenTTD/pull/12183#issuecomment-1985894943
15:28:56 <_zephyris> peter1138: Yup, seems much more flexible. I've broken design convention by having heavier vertical rather than horizontal strokes - that's the TTD style, but I can't find any Hebrew fonts that do that
15:29:52 *** gelignite has joined #openttd
15:30:37 <xarick> I need to check how Time was implemented for scripts, seems that it breaks their flow
15:31:38 <_glx_> nothing special was needed for scripts
15:32:05 <truebrain> They are already special ❀️
15:32:34 <_glx_> the only addition is <https://docs.openttd.org/ai-api/classAITimeMode>
15:34:53 <xarick> ah... hmm, i wonder
15:35:04 <peter1138> Hmm, anyone able to confirm audio on Windows isn't totally broken by #12227 being merged?
15:35:18 <peter1138> I forgot that, uh, it's not actually something I tested, or can test.
15:35:57 <merni> is it in the current nightly?
15:36:33 *** nielsm has joined #openttd
15:36:54 <_glx_> and the mode affects <https://docs.openttd.org/ai-api/classAIDate>
15:37:23 <merni> I can hear music in latest nightly, anyway
15:37:25 <xarick> oh, I have to use AITimeMode for everything that is time related now? 😦
15:37:50 <merni> and also cash registers
15:37:57 <merni> does that help?
15:38:26 <xarick> let me check what my own AI is getting from AIDate
15:38:28 <_glx_> no, default is economy mode, which is fine
15:40:55 <kuhnovic> For CREDITS.md: `- Koen Bussemaker (Kuhnovic) - General / Ship pathfinder (since 14)` ?
15:41:25 <michi_cc> Make a PR with whatever you like πŸ™‚
15:42:35 <xarick> AIDate.GetCurrentDate() returns the date from the bottom left screen or the date from that period thingy?
15:42:46 <talltyler> You could be the Buoy Butcher πŸ˜›
15:46:12 <xarick> ^_^
15:46:34 *** Ox7C5 has joined #openttd
15:46:34 <xarick> let's experiment setting economy mode for the entire script
15:47:11 <_glx_> no need to set anything for economy mode
15:49:07 <xarick> something's not working for my script, and I suspect other scripts as well
15:49:24 <xarick> I use AIDate.GetCurrentDate() massively everywhere
15:51:17 <_glx_> <https://docs.openttd.org/source/d9/d91/classTimerGameEconomy#details>
15:51:46 <_glx_> and <https://docs.openttd.org/source/d1/d85/classTimerGameCalendar#details>
15:53:04 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic opened pull request #12235: Update: Developer credits (#12235) https://github.com/OpenTTD/OpenTTD/pull/12235
15:53:12 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1215688782871789618/image.png?ex=65fda968&is=65eb3468&hm=125e3eadfc952550e39706c3f83f9ca6d627e5fbe1d320e2dabdeea154fb79b2&
15:53:12 <xarick> I'm the bringer of bad news...
15:53:28 <merni> You know where the report goes :p
15:53:35 <peter1138> Come on you know how to properly report πŸ™‚
15:54:16 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #12235: Update: Developer credits (#12235) https://github.com/OpenTTD/OpenTTD/pull/12235#issuecomment-1985941637
15:54:29 <_glx_> if it's a custom build we can't do anything though
15:55:23 <xarick> it's a Release build without debugs... gotta redo with debug
15:55:55 <_glx_> won't help, we can't open dmp without the corresponding exe
15:56:15 <merni> can't it be reproduced on a nightly/RC?
15:56:38 <xarick> it was master, but it was a Release, not even RelWiThDebInfo, no symbols
15:56:51 <_glx_> you can open the dmp yourself
15:57:51 <_glx_> (if you still have the corresponding exe)
15:59:21 <_jgr_> xarick: If you're doing local testing, it's probably a good idea to stick to build types which have symbols in them
16:00:04 <_glx_> symbols are outside of exe with MSVC anyway
16:02:58 *** Wormnest has joined #openttd
16:05:25 <xarick> waiting for the crash to happen again
16:05:45 <xarick> I'm in RelWithDebInfo now
16:11:25 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #12234: Codechange: Remove pointer parameters in foundation/slope code. https://github.com/OpenTTD/OpenTTD/pull/12234#pullrequestreview-1925231013
16:13:52 <DorpsGek> [OpenTTD/team] glx22 commented on issue #527: [nb_NO] Translator access request https://github.com/OpenTTD/team/issues/527
16:16:25 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1215694624278978580/image.png?ex=65fdaed8&is=65eb39d8&hm=0b81edb9d590dc46a74b961e62a408aa6e9bd4490e09087101afb37e9a57e9aa&
16:16:25 <xarick> now that's something
16:19:31 <kuhnovic> That ain't good
16:20:10 <kuhnovic> Do you have a savegame to reproduce it?
16:20:13 <_glx_> source = destination ?
16:22:17 <kuhnovic> That could very well be it *hides under desk*
16:22:31 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened issue #12236: [Crash]: https://github.com/OpenTTD/OpenTTD/issues/12236
16:24:27 <_glx_> dmp is useless in this report, but json has the decoded trace πŸ˜‰
16:25:07 <xarick> oh, my bad
16:25:21 <_glx_> anyway it's an assert so we know where it happens
16:25:52 <xarick> RIP YAPF
16:25:54 <_glx_> and most likely the "why" won't be in the dmp
16:26:06 <xarick> long live NPF
16:26:17 <_glx_> it's just a bug
16:26:22 <xarick> hewhe
16:26:53 <_jgr_> Looks like it is #12181
16:31:23 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic updated pull request #12235: Update: Developer credits (#12235) https://github.com/OpenTTD/OpenTTD/pull/12235
16:31:44 <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #12234: Codechange: Remove pointer parameters in foundation/slope code. https://github.com/OpenTTD/OpenTTD/pull/12234
16:32:01 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic commented on pull request #12235: Update: Developer credits (#12235) https://github.com/OpenTTD/OpenTTD/pull/12235#issuecomment-1986011081
16:32:39 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #12234: Codechange: Remove pointer parameters in foundation/slope code. https://github.com/OpenTTD/OpenTTD/pull/12234#issuecomment-1986011998
16:34:56 <michi_cc> Hmm, interesting. In #12234 I moved some code between two commits without changing the combined diff, and GitHub didn't dismiss the approval.
16:35:30 <_glx_> if global diff is the same it's not a chang πŸ˜‰
16:37:24 <kuhnovic> I will look at that pathfinder issue tonight. Gotta put the little human to bed first.
16:52:47 *** Smedles has quit IRC (Read error: Connection reset by peer)
16:53:07 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #12235: Update: Developer credits (#12235) https://github.com/OpenTTD/OpenTTD/pull/12235#pullrequestreview-1925330501
16:53:28 *** Smedles has joined #openttd
16:58:58 <xarick> Owner 3, that's actually LuDiAIAfterFix
16:59:05 <xarick> what have I done
17:05:17 <kuhnovic> Do you know which specific ship triggered the assert?
17:06:15 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1215707165831069777/image.png?ex=65fdba87&is=65eb4587&hm=203f061a798e80d46496e51e0a2ffc14d956ab430205269cd5f89557a29435be&
17:06:32 <xarick> ship wants to go to where it is
17:07:49 <xarick> order is not LEAVINGSTATION this time
17:08:17 <xarick> it's really looking for a docking tile, which is where the ship is atm
17:08:59 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #12234: Codechange: Remove pointer parameters in foundation/slope code. https://github.com/OpenTTD/OpenTTD/pull/12234
17:10:30 <xarick> let's try... some detached heads
17:12:54 *** Leopold has quit IRC (Remote host closed the connection)
17:15:21 <xarick> it's https://github.com/OpenTTD/OpenTTD/commit/30e1a61c043371b8fcfaecbe80320716ee362014
17:15:36 <xarick> commit prior to this doesn't crash
17:18:58 *** Leopold has joined #openttd
17:19:51 <xarick> meanwhile I forgot what I was doing
17:19:56 <xarick> something about time...
17:24:37 <kuhnovic> Clearly I messed something up hehe
17:27:17 <michi_cc> kuhnovic: Please do your work yourself πŸ™‚ (Hint: there's a PR ready)
17:30:43 *** Leopold has quit IRC (Remote host closed the connection)
17:32:03 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic merged pull request #12235: Update: Developer credits (#12235) https://github.com/OpenTTD/OpenTTD/pull/12235
17:32:42 <DorpsGek> [OpenTTD/website] michicc updated pull request #305: Add: Blog post about sausage making https://github.com/OpenTTD/website/pull/305
17:33:09 <michi_cc> Hmm, also, we have a new dev, wasn't there something about RC2... ? πŸ˜€
17:35:09 *** HerzogDeXtEr has joined #openttd
17:35:26 <DorpsGek> [OpenTTD/website] michicc commented on pull request #305: Add: Blog post about sausage making https://github.com/OpenTTD/website/pull/305#issuecomment-1986125302
17:35:28 <kuhnovic> Backport requested label?
17:35:51 <michi_cc> No, doing the release πŸ™‚
17:36:55 <kuhnovic> I hope you're not expecting me to do that πŸ˜†
17:38:44 <michi_cc> It's actually easier than you think. We made 2TT do it, too.
17:38:55 <talltyler> Yeah, it was my first task. There's a guide here: https://github.com/OpenTTD/OpenTTD/blob/master/docs/releasing_openttd.md
17:39:41 <michi_cc> If you look at the channel pins, there's a message from me that starts some post. Most if should be in the link 2TT posted I think.
17:40:06 <talltyler> I wrote the guide based on your messages here, with additional info I asked about when writing the guide πŸ™‚
17:40:40 <talltyler> Thanks again for that πŸ˜„
17:40:40 <michi_cc> kuhnovic: So yes, maybe not today or tomorrow, but you *will* release RC2 πŸ™‚
17:41:25 <kuhnovic> Haha alright, baptism of fire πŸ”₯
17:41:58 <DorpsGek> [OpenTTD/website] 2TallTyler approved pull request #305: Add: Blog post about sausage making https://github.com/OpenTTD/website/pull/305#pullrequestreview-1925450751
17:42:02 <michi_cc> Backport PR can be updated incrementally, so you may start at any time πŸ™‚
17:42:24 <michi_cc> talltyler: That's dangerous in case someone presses buttons too soon again πŸ™‚
17:42:59 <talltyler> I can un-approve if you want πŸ˜›
17:43:57 <DorpsGek> [OpenTTD/website] 2TallTyler dismissed a review for pull request #305: Add: Blog post about sausage making https://github.com/OpenTTD/website/pull/305#pullrequestreview-1925450751
17:46:53 <xarick> AIDate.GetCurrentDate() = 361
17:47:04 <xarick> it starts at 361? very odd number
17:47:35 <xarick> I expected 0, but hmm...
17:48:12 <talltyler> Economy year 1, day 1
17:49:19 <talltyler> This is the first day of the economy time system, unlike calendar date which is zero-indexed but generally starts at some date that trains exist πŸ˜›
17:49:42 <talltyler> Economy years have 360 days, because economy months all have 30 days
17:52:10 <xarick> ah
17:52:38 <xarick> anyway, I find my AI very shy on adding ships
17:52:43 <xarick> something's strange
17:53:11 <xarick> still figuring out what's wrong
17:59:47 *** nielsm has quit IRC (Ping timeout: 480 seconds)
18:01:32 <xarick> I suspect something with vehicle age...
18:06:49 <xarick> I only amass vehicles after vehicle age is > 730
18:06:53 <xarick> on a route
18:07:10 <xarick> AIVehicle.GetAge returns what now?
18:07:41 <xarick> 2 years?
18:09:30 <xarick> I also use AIVehicle.GetAgeLeft() <= 365
18:09:52 <xarick> to detect old veihcles
18:10:50 <xarick> Is there a function to convert this time to the other time?
18:21:50 <_glx_> 2 years is 720 days
18:24:45 <kuhnovic> https://cdn.discordapp.com/attachments/1008473233844097104/1215726919446958160/image.png?ex=65fdccec&is=65eb57ec&hm=1caf3806a32b7f3243ef1555c693b2aed14ab7dd1a6e9ca345ac67dfb84c6a71&
18:24:45 <kuhnovic> XAARRIIIIIIIICK! πŸ˜›
18:25:45 <xarick> oh πŸ™‚
18:26:03 <xarick> AIVehicle.GetProfitLastYear what does this return in relation to AIVehicle.GetAge?
18:41:29 *** xertov has joined #openttd
18:41:29 <xertov> https://cdn.discordapp.com/attachments/1008473233844097104/1215731124932972624/image.png?ex=65fdd0d7&is=65eb5bd7&hm=495619a04edb643d664c01eeb319e53feb3d7bd82e8fe7596b587faaf64d4634&
18:41:43 <xertov> someone explain wtf means prospect this industry
18:43:10 <belajalilija> xertov: spawn
18:43:39 <xertov> Ξ±Ξ± i see
18:43:42 <brickblock19280> try to build specifically
18:44:03 <brickblock19280> funding is guaranteed prospecting is not
18:48:39 <michi_cc> Literally speaking prospecting is the act of searching for natural resources (like .e.g oil), which you might or might not find in a specific place.
18:50:40 <xertov> ok i see
18:59:48 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1215735739053248522/image.png?ex=65fdd523&is=65eb6023&hm=14e50b70c2d031282662983dda19e1087a9d84f20e5ec6102be88166ac81a59d&
18:59:48 <xarick> this looks wrong...
19:00:01 <xarick> Age is in days, not years
19:00:06 <xarick> GetAge
19:00:41 <talltyler> Be warned that engine age is in calendar time, not economy time, so if you freeze the calendar they won’t get older.
19:02:08 <_glx_> AITimeMode only affects AIDate, all other functions use economy or calendar depending on the function
19:03:51 <talltyler> As for telling if vehicles are too new, there is this PR to fix the GUI that could use some input: https://github.com/OpenTTD/OpenTTD/pull/12142
19:04:03 <talltyler> If needed that could probably be exposed to scripts
19:04:31 <xarick> 10980, this engine has 25 years of life... 10980/25 = 439 days, this looks weir
19:04:33 <xarick> d
19:29:24 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #12142: Fix #12010: Use economy timer for vehicle stats minimum age, not calendar https://github.com/OpenTTD/OpenTTD/pull/12142#pullrequestreview-1925698540
19:30:35 <truebrain> owh, and kuhnovic, you are no longer allowed to play the game. So please stop this nonsense πŸ˜› πŸ˜› πŸ˜›
19:31:11 <truebrain> https://cdn.discordapp.com/attachments/1008473233844097104/1215743639309779075/image.png?ex=65fddc7f&is=65eb677f&hm=3954dec15f4fbc9f8b65a2103e618aaacb9c386b3eba3d6c82dadb526e7d2121&
19:31:11 <truebrain> context for IRC πŸ˜›
19:31:44 <kuhnovic> I'm debugging and comparing against 13.1. Can hardly call that "playing" πŸ˜‰
19:31:53 <LordAro> :D
19:31:58 <truebrain> pfew
19:32:37 * kuhnovic Turns off steam hehe
19:32:45 <truebrain> choo choo
19:33:28 <truebrain> what was I going to do tonight .. hmm .. I had a plan earlier. I kinda forgot.
19:34:08 <truebrain> https://cdn.discordapp.com/attachments/1008473233844097104/1215744381407985734/image.png?ex=65fddd2f&is=65eb682f&hm=cb5f87e14d58219a0ab4cba70d66a0ec4551c50db3aabda433a3f9f9ef9dd1bb&
19:34:08 <truebrain> how on earth did you manage to do that πŸ˜„
19:34:56 <truebrain> ah, your title was self-referencing πŸ™‚ On squashing, GitHub does that for you; no need to do those plebs tasks yourself πŸ™‚
19:36:11 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #12136: Fix #12118: When adding an unbunching order, properly check for unsafe conditions https://github.com/OpenTTD/OpenTTD/pull/12136#pullrequestreview-1925710954
19:37:56 <kuhnovic> I was wondering how people did that haha. I looked at the latest issue / PR and did that number + 1. I was overthinking it πŸ˜›
19:38:09 <truebrain> πŸ™‚
19:40:40 <peter1138> Hmm, I've got (an AI played) savegame where which keeps cycling between slow and fast...
19:41:19 <truebrain> where which?
19:41:46 <truebrain> ah πŸ˜„
19:41:53 <truebrain> slow and fast what?
19:42:11 <peter1138> Hmm, seems to be road vehicle ticks that surge.
19:42:21 <truebrain> owh, fps!
19:42:55 <peter1138> Okay that's annoying, when you pause to look at a chart the chart disappears too because it's paused...
19:43:21 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1215746702535954502/image.png?ex=65fddf59&is=65eb6a59&hm=e1e4e3984441e9cb442b54ba53d3470cdf89abcfa38a0a73066270f347a9fa20&
19:43:21 <peter1138> Doesn't go far back enough to show a pattern.
19:43:34 <truebrain> make a "zoom out" button πŸ˜„
19:44:48 <kuhnovic> Wow. Conditional orders for ships is starting to compete for "bane of my existence" when it comes to working on the ship pathfinder.
19:45:34 <peter1138> Hmm, surprised they have any bearing on the pathfinder.
19:45:43 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #12236: [Crash]: https://github.com/OpenTTD/OpenTTD/issues/12236
19:45:48 <truebrain> ugh, uploading crashdumps of custom binaries .. ugh
19:47:26 <peter1138> Hmm, where is the framerate graph period determined... (the one that likes to jump around a bit.)
19:47:35 <kuhnovic> They seem to trigger annoying edge cases. For example, a ship is at a dock, but the next conditional order says "go back to that dock if 0% loaded".
19:48:00 <xarick> it was master, not custom
19:48:09 <truebrain> kuhnovic: why does a PF care? πŸ™‚
19:48:31 <peter1138> This might be the "special case" I removed...
19:48:36 <peter1138> :/
19:48:54 <truebrain> well, that wouldn't be a terrible thing, at least means we can document it correctly πŸ˜„
19:50:29 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on issue #12236: [Crash]: during pathfinding with ships https://github.com/OpenTTD/OpenTTD/issues/12236
19:52:20 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #12236: [Crash]: during pathfinding with ships https://github.com/OpenTTD/OpenTTD/issues/12236
19:52:26 <kuhnovic> peter1138: I thought so too, so I put that code back, and it doesn't seem to be the case.
19:54:31 <peter1138> Maybe this condition should be detected before calling the pathfinder.
19:54:37 <xarick> oh, because it wasn't built by your servers, it's a custom build...
19:54:40 <xarick> fine
19:55:43 <peter1138> Speculating, no idea.
19:56:02 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1215749891976859668/image.png?ex=65fde251&is=65eb6d51&hm=921845ed83be3847ac77f7d9e185240c251b82abb72693fd5317eb00d94af389&
19:56:04 <kuhnovic> xarick: I have created an isolated savegame in 13.1 that reproduces the problem
19:56:07 <peter1138> Well, not quite the plan...
19:57:32 <kuhnovic> And I'm quite sure that my recent changes deep in yapf_base have something to do with it. Even though I still think those were good changes. But yeah, side effects...
19:58:03 <xarick> it was crashing in 13.1?
20:00:19 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic commented on issue #12236: [Crash]: during pathfinding with ships https://github.com/OpenTTD/OpenTTD/issues/12236
20:00:46 <kuhnovic> No it was not, but I used 13.1 to compare what happens in the same situation.
20:01:44 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #12237: Change: [CI] switch MacOS to the macos-14 runner https://github.com/OpenTTD/OpenTTD/pull/12237
20:01:56 <truebrain> testing runner changes by just making the PR ... let's see how well this goes πŸ˜›
20:02:01 <kuhnovic> 13.1 has the old ship pathfinder, and doesn't have my recent yapf destination check fix. This means the ship never consideres the current tile to be a destination tile, and will therefore always look for a differnt tile.
20:02:25 <truebrain> one obvious failure .. I used the Windows commands .. lol
20:02:53 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #12237: Change: [CI] switch MacOS to the macos-14 runner https://github.com/OpenTTD/OpenTTD/pull/12237
20:03:25 <michi_cc> I just wanted to comment, but you were faster πŸ™‚
20:03:40 <truebrain> I don't need nobody to tell me I am an idiot πŸ˜„
20:04:51 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #12237: Change: [CI] switch MacOS to the macos-14 runner https://github.com/OpenTTD/OpenTTD/pull/12237
20:06:00 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1215752400434888774/image.png?ex=65fde4a7&is=65eb6fa7&hm=a4600b9384cd0fe5600883d80e1da3ae73215ec4e14cd121989edda1e89aa974&
20:06:00 <peter1138> That was too much effort just to make this visible :p
20:06:24 <truebrain> can you make it the default now? πŸ™‚
20:06:32 <truebrain> that seems so much more useful πŸ˜„
20:07:16 <xarick> okay, I seem to understand this time stuff
20:07:24 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #12236: [Crash]: during pathfinding with ships https://github.com/OpenTTD/OpenTTD/issues/12236
20:07:37 <xarick> it was reporting days
20:07:46 <xarick> but a day takes so long with 10080
20:07:53 <xarick> it was advancing slow
20:08:37 <truebrain> lol, we are building x64 for the CI on Mac .. I was wondering why it wasn't all that fast πŸ™‚
20:10:34 <xarick> talltyler: I think I know what's the problem. There is no conversion from calendar to economy for at least these two functions GetAge, GetAgeLeft
20:10:50 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #12237: Change: [CI] switch MacOS to the macos-14 runner and use arm64 for CI https://github.com/OpenTTD/OpenTTD/pull/12237
20:11:00 <truebrain> let's see which is faster .. 4m30s for x64
20:11:18 <xertov> Select the action to take at this depot = select the action you want to take right ?
20:11:20 <xarick> version 13 versus version 14
20:11:28 <xarick> compat files missing
20:11:30 <xarick> etc
20:11:54 <_glx_> they use calendar time
20:12:04 <_glx_> as expected
20:12:35 <xarick> that is actually not version 13 expects
20:12:55 <_glx_> but the issue is <https://github.com/OpenTTD/OpenTTD/pull/12142> πŸ˜‰
20:13:52 <_glx_> and this PR doesn't touch API but I think it should
20:14:01 *** Leopold has joined #openttd
20:14:41 <xarick> I wonder what GetProfitLastYear return, let's see
20:15:38 <peter1138> Hmm, might just be all the RVs queueing.
20:15:50 <truebrain> they all queue at the same time?
20:16:12 <truebrain> okay, x64 and arm64 are both equally fast on the CI. Both faster than all other targets, lol
20:16:36 <truebrain> but also no change with macos-latest
20:16:39 <truebrain> so that is good-ish
20:16:45 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #12142: Fix #12010: Use economy timer for vehicle stats minimum age, not calendar https://github.com/OpenTTD/OpenTTD/pull/12142#issuecomment-1986359704
20:17:06 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #12237: Change: [CI] switch MacOS to the macos-14 runner and use arm64 for CI https://github.com/OpenTTD/OpenTTD/pull/12237#issuecomment-1986360076
20:17:12 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1215755218160189552/image.png?ex=65fde747&is=65eb7247&hm=52ab2c1a657974143d3450646826e06e6c46414866ce1df0aa34c30552526009&
20:17:12 <peter1138> Somewhat.
20:17:23 <xertov> https://cdn.discordapp.com/attachments/1008473233844097104/1215755265224343642/image.png?ex=65fde752&is=65eb7252&hm=e552aaa6fb0504dec2cac2b406a3974a6c1d1f04e51ef263350d00b1da04aab2&
20:17:25 <xertov> what s a bn ?
20:17:31 <xertov> british nudes?
20:17:31 <truebrain> that is one hell of a traffic jam πŸ˜„
20:17:38 <andythenorth> peter1138: I am ignoring the RVs and looking at the flat docks
20:17:52 <_glx_> check the string name xertov (be it's billion)
20:18:06 <xertov> STR_CURRENCY_SHORT_GIGA
20:18:18 <xertov> i see
20:18:26 <xertov> thanks , i will check string names from now on
20:18:31 <truebrain> mostly our strings are more telling than the english text πŸ™‚
20:18:51 <xertov> however i think i ll keep this bn
20:19:16 <xertov> because there is not short for of δισΡκατομμύριο that i know of
20:19:27 <truebrain> bless you
20:19:41 <peter1138> Nobody wants British nudes.
20:19:56 <peter1138> Especially not British OpenTTD developer nudes.
20:19:57 <xertov> nevermind we got δις
20:20:08 <xarick> for (local go = false; go != true; go = !go) { very smart coding
20:20:49 <truebrain> peter1138: maybe LordAro is making a lot of money with his OnlyFans .. you don't know! DONT JUDGE
20:21:52 <truebrain> lol, Rb wrote in a comment " for me it would be mostly generating failed builds until something sticks. I doubt that's the way to go" .. and I ended up doing exactly that with #12237 .. lalalala πŸ˜› The irony sometimes πŸ™‚
20:22:08 <truebrain> like any of us actually understands GitHub workflows πŸ™‚
20:22:09 <xertov> british is the first nationality that came to mind with a B . in handsight i should had said Brazilian
20:22:30 <truebrain> xertov: where can I sign up for this .... site? book? video?
20:22:34 <truebrain> πŸ˜›
20:25:11 <xertov> idk do ur research i guess XD
20:27:00 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #12237: Change: [CI] switch MacOS to the macos-14 runner and use arm64 for CI https://github.com/OpenTTD/OpenTTD/pull/12237#issuecomment-1986370822
20:27:17 <frosch123> are peoples with B more likely to have no government?
20:27:25 <frosch123> brits, belgians, ...
20:27:38 <frosch123> bitaly
20:27:47 <truebrain> Betherlands
20:28:22 <frosch123> ah, right, you joined the belgians
20:28:52 <frosch123> at least you do no longer have to worry about the german wheat tourists
20:28:52 <peter1138> We have a government. They're too busy lining their own pockets though.
20:35:01 <andythenorth> should I play OpenTTD?
20:35:16 <truebrain> Are you a developer?
20:35:30 <andythenorth> no
20:35:37 <truebrain> Then: yes
20:35:37 <andythenorth> never wanted the responsibility
20:37:33 <frosch123> andy even left when we force-joined him
20:41:57 *** Leopold has quit IRC (Remote host closed the connection)
20:44:23 *** sherlockholmes1904 has joined #openttd
20:44:23 <sherlockholmes1904> andythenorth: Then who is developer?
20:44:50 <andythenorth> frosch123: oh yes, I used to have nml approval rights
20:44:52 <andythenorth> I forgot
20:45:15 <frosch123> sherlockholmes1904: ask watson
20:47:54 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1215762945468923925/image.png?ex=65fdee79&is=65eb7979&hm=31416db97a8b92948161fd8d091fc0fb86156b2f15c6af91a42075bada436f5f&
20:47:54 <xarick> for (local go = 0; go <= 1; go++) {
20:47:54 <xarick> local calendar_mode = AITimeMode(go.tobool());
20:49:46 <andythenorth> so Wallclock
20:50:14 <andythenorth> if I want the game to progress at half the normal speed, I set 24 minutes?
20:50:32 <peter1138> These RVs need to get Waze or something.
20:50:50 <truebrain> peter1138: Lol
20:52:23 <peter1138> Is there no road occupancy penalty for RVs...
20:53:34 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1215764373063336077/image.png?ex=65fdefce&is=65eb7ace&hm=1329141c3e24abba4ad6c8ee7ed1083fad51a1942cbc48201f085d1316544304&
20:53:34 <xarick> calendar mode doesn't do anything, or I don't understand
20:55:08 <xertov> https://cdn.discordapp.com/attachments/1008473233844097104/1215764764882374686/image.png?ex=65fdf02b&is=65eb7b2b&hm=e1a086940e23098206f1ac66be9e16960451aafa034972b51c51354ee33d74b6&
20:55:13 <xertov> ee i still dont get this
20:55:26 <xertov> maybe it means all cargo types with no ratign ?
20:59:02 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic opened pull request #12238: Fix #12236: Ship pathfinder causes crash when ship is already at destination https://github.com/OpenTTD/OpenTTD/pull/12238
21:02:05 <xarick> should test v->tile == src_tile, which probably is the case
21:02:39 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #12238: Fix #12236: Ship pathfinder causes crash when ship is already at destination https://github.com/OpenTTD/OpenTTD/pull/12238#pullrequestreview-1925833227
21:02:52 <xarick> or just revert peter's recent edge case removal?
21:02:53 <kuhnovic> xarick: I know you have this fix https://github.com/OpenTTD/OpenTTD/pull/12156
21:03:54 <kuhnovic> xarick: I did that locally, but that's actually not the cause. It's our good friend OT_LEAVESTATION again.
21:04:54 <kuhnovic> And on one hand I'm inclined to accept your fix, as it does make issue go away. However, I also feel that we are fixing symptoms and not causes.
21:06:21 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1215767587665743882/image.png?ex=65fdf2cc&is=65eb7dcc&hm=142e978d91993dc0570cc684a4eb10d7001f3f759d8f83c18d2fac1637d5f232&
21:06:21 <peter1138> I've got a different pattern now, nice.
21:06:24 <xarick> eh I don't think the fix i have there solves it....
21:07:16 <xarick> or does it? hmm must test, though I was a bit busy with the Time feature breaking my AI
21:08:16 <peter1138> Hmm, quantum vehicle queueing.
21:09:05 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1215768279155478568/Screencast_from_2024-03-08_21-08-43.webm?ex=65fdf371&is=65eb7e71&hm=008a69bea3c9025495ae3943450d4d618eb61e065edcd3a9f802a4152fc5b467&
21:09:05 <peter1138> That lorry is like YOLO
21:09:52 <xarick> it's to prevents deadlocks if they wait too much, unelegant though
21:11:24 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12156: Fix #11862: Ships leaving docks could be momentarily lost https://github.com/OpenTTD/OpenTTD/pull/12156
21:11:29 <truebrain> "I don't believe in physics" πŸ˜„
21:15:05 <xarick> confirmed, 12156 doesn't fix this new crash
21:17:06 <xarick> now testing with 12192 reverted
21:18:24 <xarick> nop, still crash
21:18:42 <xarick> 12156 + 12192 reverted
21:19:59 <xarick> oh, right... this is so confusing
21:20:34 <xarick> tile is the tile the vehicle enters, v->tile is the tile the ship is at, of course reverting 12192 wouldn't solve anything
21:21:26 <xarick> v->dest_tile is matching v->tile, not tile
21:21:38 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1215771435554050098/image.png?ex=65fdf662&is=65eb8162&hm=e1dc906884e301f97dddf6bed5cfa08a0bdd5cc265e97c3847fc0dfd790cee5a&
21:21:38 <peter1138> Who knows where they are going πŸ˜„
21:22:30 <belajalilija> you're redoing rv ai now?
21:22:41 <belajalilija> ngl
21:23:01 <belajalilija> it would be cool if trains would turn around to find a depot
21:24:00 <belajalilija> https://cdn.discordapp.com/attachments/1008473233844097104/1215772031799394434/image.png?ex=65fdf6f0&is=65eb81f0&hm=a196ef95a37268844e6d8741e7ceff1121da6eb4709c30d8e10609aaff1672d6&
21:24:00 <belajalilija> for ex in a case like this
21:24:27 <belajalilija> a train could go to a theoretical station, turn around, enter the depot
21:25:26 <talltyler> andythenorth: Yes
21:25:58 <talltyler> Assuming you’re playing nightly. RC1 is quite broken. πŸ˜„
21:26:48 *** nielsm has joined #openttd
21:29:56 <_glx_> xarick: I told you, AITimeMode affects only AIDate class
21:30:35 <_glx_> AIEngine and AIVehicle uses the appropriate one
21:30:37 <andythenorth> I built recent master
21:30:55 <_glx_> though in some case they might use the wrong one
21:31:15 *** Leopold__ has joined #openttd
21:39:09 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1215775841662009475/image.png?ex=65fdfa7c&is=65eb857c&hm=ded09366a3acbcd12aa39ce56f06819cc509424d855dcd87034cc1e8f4647578&
21:39:09 <peter1138> Oops?
21:39:16 *** Leopold__ has quit IRC (Remote host closed the connection)
21:40:29 *** Leopold has joined #openttd
21:42:34 <xarick> I really wish brazillians would stop translating everything on youtube!
21:42:55 <xarick> even voice overs Linus Tech Tips, why do you do that!!
21:47:09 <Eddi|zuHause> why not?
21:48:05 <xarick> We understand english very well, unlike Brazil
21:48:23 <xarick> we despise voice overs when the source is english
21:48:54 <xarick> but google thinks Portugal and Brazil are the same, so we're fed with that content by default...
21:52:20 <Rubidium> it's not like American, British and Australian English are the same, yet Google only "knows" one of them...
21:57:59 *** Leopold has quit IRC (Remote host closed the connection)
21:59:50 *** Leopold_ has joined #openttd
22:04:35 *** SigHunter has quit IRC ()
22:05:39 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #12237: Change: [CI] switch MacOS to the macos-14 runner and use arm64 for CI https://github.com/OpenTTD/OpenTTD/pull/12237#pullrequestreview-1925930504
22:07:04 <DorpsGek> [OpenTTD/OpenTTD] TheMowgliMan opened pull request #12239: Fix #10370: increase maximum user-set engine name length to 256 https://github.com/OpenTTD/OpenTTD/pull/12239
22:07:12 *** SigHunter has joined #openttd
22:07:24 <xarick> 256... seriously
22:07:28 <xarick> ^_^
22:09:11 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #12239: Fix #10370: increase maximum user-set engine name length to 256 https://github.com/OpenTTD/OpenTTD/pull/12239#issuecomment-1986490431
22:09:30 *** SigHunter has quit IRC ()
22:11:59 *** SigHunter has joined #openttd
22:12:22 *** nielsm has quit IRC (Ping timeout: 480 seconds)
22:13:05 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #12136: Fix #12118: When adding an unbunching order, properly check for unsafe conditions https://github.com/OpenTTD/OpenTTD/pull/12136
22:13:08 *** Leopold_ has quit IRC (Remote host closed the connection)
22:13:23 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #12136: Fix #12118: When adding an unbunching order, properly check for unsafe conditions https://github.com/OpenTTD/OpenTTD/pull/12136#pullrequestreview-1925937802
22:13:31 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:14:18 *** Leopold_ has joined #openttd
22:16:52 <xarick> Im receiving emails about 12136, interesting
22:17:03 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #12142: Fix #12010: Use economy timer for vehicle stats minimum age, not calendar https://github.com/OpenTTD/OpenTTD/pull/12142#issuecomment-1986497644
22:17:32 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler dismissed a review for pull request #12142: Fix #12010: Use economy timer for vehicle stats minimum age, not calendar https://github.com/OpenTTD/OpenTTD/pull/12142#pullrequestreview-1925698540
22:20:22 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #12142: Fix #12010: Use economy timer for vehicle stats minimum age, not calendar https://github.com/OpenTTD/OpenTTD/pull/12142#issuecomment-1986503501
22:20:54 <talltyler> I should stop trying to do critical thinking tasks on Friday evening πŸ˜›
22:21:03 <talltyler> My brain is mush
22:21:47 <xarick> version 13 scripts, and before need vehicle age related stuff to be what it used to be before
22:21:58 <xarick> economy timer I guess
22:22:19 <xarick> version 14 however... not sure
22:23:25 <_zephyris> peter1138: No, no, that's totally intentional!
22:23:28 *** SigHunter has quit IRC ()
22:25:57 *** SigHunter has joined #openttd
22:26:01 <_zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1215787639073017928/image.png?ex=65fe0579&is=65eb9079&hm=20a977f39f7d393e9802795671216a29a471426230ec54bead2f5b72a3e9a13d&
22:26:01 <_zephyris> Hmm, I might have already fixed it.
22:27:08 <xarick> I use GetAgeLeft to know whether my vehicles need replacement, due to their reliability decrease being faster in the final year of their lifetime. What timer is reliability counters based on?
22:30:03 <peter1138> Ah, I'm outdated.
22:30:26 <peter1138> Also the background gradient of the company president image is not company coloured.
22:30:39 <xarick> and I use GetAge on vehicles to check if the route they're servicing is profitable. Maybe I have to change this and store the date of construction of the route instead of looking for the oldest vehicle in the route
22:31:00 <_zephyris> peter1138: Oh yeah...
22:31:42 <truebrain> talltyler: I just stopped with thinking in general. Easier that way.
22:36:38 <peter1138> Thinking? What's that?
22:44:07 *** Ox7C5 has quit IRC ()
22:46:17 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic merged pull request #12238: Fix #12236: Ship pathfinder causes crash when ship is already at destination https://github.com/OpenTTD/OpenTTD/pull/12238
22:46:20 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic closed issue #12236: [Crash]: during pathfinding with ships https://github.com/OpenTTD/OpenTTD/issues/12236
22:51:21 *** Leopold_ has quit IRC (Remote host closed the connection)
22:52:37 *** Leopold has joined #openttd
22:55:36 *** SigHunter has quit IRC ()
22:58:06 *** SigHunter has joined #openttd
23:00:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #12240: Codefix: Fully initialise `MidiFile::DataBlock` to avoid gcc warning. https://github.com/OpenTTD/OpenTTD/pull/12240
23:03:54 <_glx_> xarick: age stuff should use economy not calendar
23:04:30 <peter1138> Mostly.
23:04:33 <_glx_> similar to #12142
23:05:17 <_glx_> but you can't do anything script related without #12142
23:09:22 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
23:18:30 <xarick> I'm afraid I won't get my AI ready for 14 release
23:22:20 <xarick> this code is messy enough
23:23:55 <peter1139> That's okay, you don't have to wait until 15 just because you missed it :)
23:26:30 <xarick> is there an easy way to convert a date to another?
23:26:41 <xarick> calendar to economy
23:31:09 *** Flygon has joined #openttd
23:32:39 <_glx_> no, they are not meant to be converted
23:35:40 <xarick> going to need a m_constructionDate for all 4 route types
23:39:52 <xarick> and then... look over 96 + 28 results for m_lastVehicleRemoved + m_lastVehicleAdded to update to using m_constructionDate where appropriate, 17 for GetAge + GetAgeLeft + 72 results for GetCurrentDate + 18 for GetProfitLastYear + GetProfitThisYear... it's basically the entire AI affected
23:40:03 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #12240: Codefix: Fully initialise `MidiFile::DataBlock` to avoid gcc warning. https://github.com/OpenTTD/OpenTTD/pull/12240#pullrequestreview-1926013125
23:42:01 <xarick> oh well, cyas goodnight
23:49:47 <xertov> xarick: thats hilarious
23:56:12 <matusguy> xarick: as a Portuguese person i hate that. I purposely put my youtube in english for such reason