IRC logs for #openttd on OFTC at 2023-09-17
#openttd / 2023 / 09 
            

00:57:44  *** tokai has quit IRC (Quit: c('~' )o)



01:16:13  <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #11306: Enable more warnings and fix them https://github.com/OpenTTD/OpenTTD/pull/11306



01:19:47  <peter1139> 217 files :D



01:21:35  <frosch123> apparently there are about 1400 files in total



01:21:45  <frosch123> so 1/7 affected



01:32:04  <frosch123> ah, more stuff in the osx build



01:32:16  <frosch123> will fix that tomorrow i guess



01:32:20  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened issue #11307: [Bug]: Vehicle count underflow when putting the cart before the horse https://github.com/OpenTTD/OpenTTD/issues/11307



02:09:11  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #11306: Enable more warnings and fix them https://github.com/OpenTTD/OpenTTD/pull/11306#issuecomment-1722369631



02:13:24  *** Flygon has joined #openttd



02:23:30  <DorpsGek> [OpenTTD/OpenTTD] github-code-scanning[bot] commented on pull request #11306: Enable more warnings and fix them https://github.com/OpenTTD/OpenTTD/pull/11306#pullrequestreview-1630031521



02:26:47  *** Wormnest_ has quit IRC (Quit: Leaving)



02:44:54  *** D-HUND has joined #openttd



02:48:27  *** debdog has quit IRC (Ping timeout: 480 seconds)



03:04:00  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #11306: Enable more warnings and fix them https://github.com/OpenTTD/OpenTTD/pull/11306#issuecomment-1722377369



04:55:13  <jfs> TallTylerviaGitHub: What does this look like on the other end of a network game? Same thing? And if then, could it possibly be a way to DoS a multiplayer server?



04:56:49  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #11308: Codechange: introduce and use function to raise and dirty a set of widgets when they are lowered https://github.com/OpenTTD/OpenTTD/pull/11308



05:06:11  *** keikoz has joined #openttd



06:16:39  <andythenorth> so do we have a way to kill the coop pastebin? https://paste.openttdcoop.org/all?/all



06:16:52  <andythenorth> don't click if you don't need to, it's got all kinds of crap in it



06:18:25  <andythenorth> in fact, link removed, it's not what you want in your browser history



06:20:32  <andythenorth> openttdcoop is becoming a liability, unmaintained services on an unmaintained host, still widely linked from a lot of our community



06:30:57  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #11306: Enable more warnings and fix them https://github.com/OpenTTD/OpenTTD/pull/11306#pullrequestreview-1630045343



06:48:49  <alfagamma7> I thought opentttdcoop has closed down



06:51:54  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #11309: Add: [GitHub] also test if release builds without asserts are warning-free https://github.com/OpenTTD/OpenTTD/pull/11309



06:52:02  <truebrain> let's see how that runs ..



06:52:26  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #11309: Add: [GitHub] also test if release builds without asserts are warning-free https://github.com/OpenTTD/OpenTTD/pull/11309



06:54:52  <andythenorth> woah this still exists? https://tinodidriksen.com/pisg/OFTC/openttd.html



06:55:12  <truebrain> that is some stable bot there



06:55:28  <truebrain> `Poor andythenorth, nobody likes him/her. He/She was attacked 27 times.`



06:55:30  <truebrain> can confirm



06:56:14  <andythenorth> `andythenorth spoke a total of 2171206 words!



06:56:14  <andythenorth> andythenorth's faithful follower, TrueBrain, didn't speak so much: 1383028 words.`



06:56:15  <andythenorth> lol



06:56:43  <andythenorth> that's some assumptions there



07:03:16  <andythenorth> anyway maybe planetbaker will see this ping



07:03:26  *** Wolf01 has joined #openttd



07:04:01  <andythenorth> Spike was another coop admin, but I don't know if discord Spike is the same person, likely not?



07:10:51  <alfagamma7> I am going to call Andy "the" from now on



07:11:22  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #11306: Enable more warnings and fix them https://github.com/OpenTTD/OpenTTD/pull/11306#pullrequestreview-1630048309



07:40:20  <TinoDidriksen> I am not a bot.



07:40:40  <_pruple> that's what they all say



07:41:11  *** keikoz has quit IRC (Ping timeout: 480 seconds)



07:56:32  *** keikoz has joined #openttd



08:16:01  *** keikoz has quit IRC (Ping timeout: 480 seconds)



08:49:40  <peter1139> > andythenorth wasn't very popular, getting kicked 14 times!



08:49:49  <peter1139> Awww



08:50:03  <alfagamma7> Mr "the"



08:51:07  <peter1139> Clearly I need the bot owner to link me and my numbers...



08:52:14  <alfagamma7> Peter on his way to contact diriksen



08:54:43  <peter1139> Hmm, apparently I am not cycling with the groups this morning.



09:01:40  <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #11310: Fix #11230: Widget layout also failed for group-less vehicle list window. https://github.com/OpenTTD/OpenTTD/pull/11310



09:02:10  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #11310: Fix #11230: Widget layout also failed for group-less vehicle list window. https://github.com/OpenTTD/OpenTTD/pull/11310#pullrequestreview-1630057721



09:20:32  *** ahyangyi has quit IRC (Quit: User went offline on Discord a while ago)



09:42:47  <peter1139> Uh oh, I changed one thing in a header file... 357 files to compile :D



10:03:28  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #11310: Fix #11230: Widget layout also failed for group-less vehicle list window. https://github.com/OpenTTD/OpenTTD/pull/11310



10:18:17  *** keikoz has joined #openttd



10:50:00  <peter1139> Hmm.



11:24:49  <talltyler> jfs: This originally happened in a network game to a player. I was able to reproduce it myself as the host, and again in single player mode.



11:37:21  <talltyler> So yes, it can irreversibly ruin companies.



11:39:51  <talltyler> The server owner can delete the company though, and new companies start with 0 vehicles as they should



11:54:06  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #11308: Codechange: introduce and use function to raise and dirty a set of widgets when they are lowered https://github.com/OpenTTD/OpenTTD/pull/11308#pullrequestreview-1630073875



12:00:38  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #10861: Codechange: Use correct invalid cargo constants. https://github.com/OpenTTD/OpenTTD/pull/10861#pullrequestreview-1630074537



12:28:36  <DorpsGek> [OpenTTD/OpenTTD] JGRennison opened pull request #11311: Fix #11307: Incorrect GroupStatistics after selling leading wagon when this results in a countable consist https://github.com/OpenTTD/OpenTTD/pull/11311



12:42:03  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #11311: Fix #11307: Incorrect GroupStatistics after selling leading wagon when this results in a countable consist https://github.com/OpenTTD/OpenTTD/pull/11311#pullrequestreview-1630078158



14:03:05  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #11308: Codechange: introduce and use function to raise and dirty a set of widgets when they are lowered https://github.com/OpenTTD/OpenTTD/pull/11308



14:11:15  <_glx_> ok C4127 warning is stupid, it warns for all `Debug(<type>, 0, ...)` because theres a `(level) == 0` in the macro



14:11:42  <_glx_> it also warns when bool template args are used



14:12:13  <_glx_> and for `sizeof() == sizeof()`



14:12:38  <_glx_> when types have the same size



14:16:45  <_glx_> C4458 won't help either (we shadow almost every class member in class functions parameters)



14:18:06  *** D-HUND is now known as debdog



14:21:34  <peter1139> I think we should try to avoid that though, apart from constructor parameters.



14:22:36  <_glx_> that's the main reason for mandatory `this->`



14:27:39  <_glx_> oh I see why string.cpp triggers C4702 in places supposedly disabled via preprocessor, it's during strgen/settingsgen build as they don't use the same defines



14:31:12  <_glx_> many other C4702 in templated math functions, of course some code is unreachable depending on template parameters



14:32:38  <_glx_> an unreachable NOT_REACHED() in script object (there are returns or throw in all paths before it)



14:35:55  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #11312: Codechange: replace WIDGET_LIST_END with more specific variants https://github.com/OpenTTD/OpenTTD/pull/11312



14:41:34  <_glx_> C4706 seems nice but the 7 warnings are for code intentionaly written that way



14:46:15  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #11311: Fix #11307: Incorrect GroupStatistics after selling leading wagon when this results in a countable consist https://github.com/OpenTTD/OpenTTD/pull/11311#pullrequestreview-1630090304



14:47:17  <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on pull request #11311: Fix #11307: Incorrect GroupStatistics after selling leading wagon when this results in a countable consist https://github.com/OpenTTD/OpenTTD/pull/11311#pullrequestreview-1630090417



14:57:56  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #11312: Codechange: replace WIDGET_LIST_END with more specific variants https://github.com/OpenTTD/OpenTTD/pull/11312#pullrequestreview-1630091493



15:31:46  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #11312: Codechange: replace WIDGET_LIST_END with more specific variants https://github.com/OpenTTD/OpenTTD/pull/11312



15:32:11  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #11312: Codechange: replace WIDGET_LIST_END with more specific variants https://github.com/OpenTTD/OpenTTD/pull/11312#pullrequestreview-1630094947



15:39:23  *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)



15:56:11  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #10861: Codechange: Use correct invalid cargo constants. https://github.com/OpenTTD/OpenTTD/pull/10861



16:28:43  *** Wormnest has joined #openttd



16:32:19  *** Smedles has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)



16:32:36  *** Smedles has joined #openttd



16:48:30  *** gelignite has joined #openttd



17:09:57  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #11312: Codechange: replace WIDGET_LIST_END with more specific variants https://github.com/OpenTTD/OpenTTD/pull/11312#issuecomment-1722521677



17:27:01  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #11312: Codechange: replace WIDGET_LIST_END with more specific variants https://github.com/OpenTTD/OpenTTD/pull/11312#issuecomment-1722525035



17:28:11  <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #11312: Codechange: replace WIDGET_LIST_END with more specific variants https://github.com/OpenTTD/OpenTTD/pull/11312#pullrequestreview-1630106156



17:31:32  <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #11313: Codechange: Cargo initialization changes. https://github.com/OpenTTD/OpenTTD/pull/11313



17:38:46  <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #11309: Add: [GitHub] also test if release builds without asserts are warning-free https://github.com/OpenTTD/OpenTTD/pull/11309#pullrequestreview-1630107089



17:39:48  <truebrain> when I merge that PR, everyone needs to rebase .. so merge now, or rebase, your choice 😄



17:39:58  <frosch123> _glx_: https://github.com/OpenTTD/OpenTTD/blob/master/src/music/dmusic.cpp#L565 <- is there a difference between the parameter "buffer" and the global "_buffer"?



17:41:21  <truebrain> (mostly looking at Rubidium here 😛 )



17:42:41  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #11311: Fix #11307: Incorrect GroupStatistics after selling leading wagon when this results in a countable consist https://github.com/OpenTTD/OpenTTD/pull/11311



17:42:44  <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #11307: [Bug]: Vehicle count underflow when putting the cart before the horse https://github.com/OpenTTD/OpenTTD/issues/11307



17:44:23  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #11312: Codechange: replace WIDGET_LIST_END with more specific variants https://github.com/OpenTTD/OpenTTD/pull/11312



17:46:04  <Rubidium> truebrain: you've got my blessing to go ahead :D



17:46:18  <truebrain> you don't want to press merge? Hmm, odd



17:46:19  <_glx_> frosch123: I'll have to check how the function is called



17:47:59  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #11309: Add: [GitHub] also test if release builds without asserts are warning-free https://github.com/OpenTTD/OpenTTD/pull/11309



18:04:55  <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #11306: Enable more warnings and fix them https://github.com/OpenTTD/OpenTTD/pull/11306



18:16:38  <DorpsGek> [OpenTTD/team] swxtz opened issue #447: [pt_BR] Translator access request https://github.com/OpenTTD/team/issues/447



18:19:48  <DorpsGek> [OpenTTD/team] swxtz opened issue #448: [pt_BR] Translator access request https://github.com/OpenTTD/team/issues/448



18:25:42  <andythenorth> frosch123: do you have any openttdcoop ssh any more ?



18:25:49  <andythenorth> we ought to kill the paste bin



18:25:58  <DorpsGek> [OpenTTD/team] frosch123 commented on issue #448: [pt_BR] Translator access request https://github.com/OpenTTD/team/issues/448



18:26:04  <andythenorth> not going to link it, because it's full of definitely no-question illegal stuff



18:26:29  <frosch123> andythenorth: no



18:26:56  <frosch123> it's possible my public key is still there, but i do not know the server names to loging, since the last server switch 5 (?) years ago



18:27:43  <andythenorth> do we know who hosts it?  If @planetmaker doesn't turn up, and nobody else can think of a coop contact, I might tell the hosting company what it's being used for and see if they'll pull it



18:28:06  <frosch123> it's all planetbaker



18:28:14  <truebrain> he was typing this morning, so I guess he did read your message 🙂



18:28:27  <andythenorth> ok cool



18:30:19  <frosch123> still did not catch all warnings for all platforms 🙂



18:30:34  <frosch123> but most warnings are independent of assertions



18:46:44  <truebrain> owh, only 53 left



18:46:46  <truebrain> that is not bad



18:49:36  <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #11306: Enable more warnings and fix them https://github.com/OpenTTD/OpenTTD/pull/11306



18:50:04  <frosch123> _glx_: looks like it's only called with buffer==_buffer, so i switched to using the parameter instead of the global



18:50:48  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #11313: Codechange: Cargo initialization changes. https://github.com/OpenTTD/OpenTTD/pull/11313



18:56:01  <_glx_> frosch123: yeah most likely missed in <https://github.com/OpenTTD/OpenTTD/commit/255549250f49522331b34ca693fb09c9d1807ac7>



18:57:39  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #11313: Codechange: Cargo initialization changes. https://github.com/OpenTTD/OpenTTD/pull/11313#pullrequestreview-1630114521



18:59:57  <frosch123> the parameter, which has been unused the longest, was used for the setting allowing/disallowing joining rail stations with different x/y rotations 🙂



19:01:39  <andythenorth> anyone fancy approving this?  I can make a test grf if needed, but eh https://github.com/OpenTTD/OpenTTD/pull/11253



19:02:44  <frosch123> aw, missed an sdl1 wanring



19:18:28  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #11306: Enable more warnings and fix them https://github.com/OpenTTD/OpenTTD/pull/11306#issuecomment-1722546675



19:18:57  <_glx_> picking only the warnings we want



19:20:51  <frosch123> i'll include that in the next push



19:21:14  <peter1139> Is there... no cargo type property for aircraft?



19:21:49  <frosch123> maybe of the W4 warnings looked like they would result in compilers fighting: some reporting things as "may not be initialised" and others as "assigned value unused"



19:22:07  <frosch123> peter1139: correct



19:22:13  <frosch123> it's always the first refittable



19:23:01  <frosch123> at some point i changed "first" to "first in cargo translation table" instead of "first in global ids"



19:23:35  <peter1139> *nod*



19:24:19  <peter1139> Houses have 3 ways to set cargo type it seems :D



19:24:34  <frosch123> but 2 of them only support 32 cargos, right?



19:25:16  <frosch123> (first 32 from ctt)



19:26:32  <peter1139> No, first one is by setting goods/candy/food/fizzy acceptance quantity, which automatically sets the cargo type depending on the landscape.



19:26:56  <peter1139> Second is the old property that only supported 3 cargo types.



19:27:06  <peter1139> 3 cargo slots, sorry.



19:27:45  <frosch123> ah yes, the limit was only with the callbacks



19:28:00  <peter1139> Third is the same but allows up to 16 slots, but it's variable.



19:28:44  <peter1139> In andythenorth-speak, that means Aircraft and Houses are unbalanced, I think.



19:34:08  <peter1139> Hmm, now to tidy up this translation.



19:35:08  *** gelignite has quit IRC (Quit: Stay safe!)



19:35:21  <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #11306: Enable more warnings and fix them https://github.com/OpenTTD/OpenTTD/pull/11306



19:38:11  <andythenorth> what is 'balanced'



19:38:28  <peter1139> Not road stops apparently.



19:38:48  <andythenorth> we shall see



19:39:09  <andythenorth> grf roadstoptypevariants



19:46:55  <peter1139> Right, now I need to remember which NewGRFs were those that fiddled with cargo slot order...



19:48:21  <frosch123> they what?



19:53:20  <peter1139> Urgh, this is annoying, game crashes and does not release/reveal the mouse cursor ... so I can't use a debugger.



20:13:06  <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #11306: Enable more warnings and fix them https://github.com/OpenTTD/OpenTTD/pull/11306



20:13:29  <frosch123> let's hope that's the last iteration...



20:22:33  <DorpsGek> [OpenTTD/wiki-data] MikZyth opened pull request #28: Updated startup screen. https://github.com/OpenTTD/wiki-data/pull/28



20:26:05  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #11313: Codechange: Cargo initialization changes. https://github.com/OpenTTD/OpenTTD/pull/11313



20:27:06  <DorpsGek> [OpenTTD/wiki-data] TrueBrain commented on pull request #28: Updated startup screen. https://github.com/OpenTTD/wiki-data/pull/28#issuecomment-1722561175



20:27:09  <DorpsGek> [OpenTTD/wiki-data] TrueBrain closed pull request #28: Updated startup screen. https://github.com/OpenTTD/wiki-data/pull/28



20:27:21  <truebrain> Sigh.



20:29:29  <peter1139> So weird.



20:40:53  <peter1139> andythenorth, cargo label 'WIND', produced by a Wind Factory that accepts 'PEAS' or 'CRRY'.



20:41:04  <andythenorth> lol



20:41:08  <andythenorth> did I do that?



20:41:21  <andythenorth> BEAN



20:41:30  <andythenorth> HNZ_



20:53:25  *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)



20:55:18  *** keikoz has quit IRC (Ping timeout: 480 seconds)



20:59:25  <peter1139> lldb) fr 1



20:59:26  <peter1139> invalid command 'frame 1'.



20:59:28  <peter1139> Uh...



21:04:55  <andythenorth> naptime?



21:08:40  <peter1139> Okay. Working now, but some of the steps that were intermediate last time are now all at once :/



21:09:38  <peter1139> Also it's a bit more verbose now -- using a function to 'translate' instead of directly looking into an array.



21:10:17  <peter1139> They're still intermediate commits currently but the game crashes :D



21:16:16  <DorpsGek> [OpenTTD/OpenTTD] github-code-scanning[bot] commented on pull request #11306: Enable more warnings and fix them https://github.com/OpenTTD/OpenTTD/pull/11306#pullrequestreview-1630127696



21:42:14  *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)



22:42:09  <peter1139> Hmm, not sure..