IRC logs for #openttd on OFTC at 2023-06-02
            
02:36:41 *** D-HUND has joined #openttd
02:40:06 *** debdog has quit IRC (Ping timeout: 480 seconds)
02:46:14 *** D-HUND is now known as debdog
03:41:39 <pickpacket> I've set "nearby_station_name: string(STR_FARM_INDUSTRY_NAME);" and as the nearby_station_name variable is described this should be the "Default additional name for a nearby station". Note the "additional". When I create a nearby station it only gets the STR_FARM_INDUSTRY_NAME as its name; no town name included
03:43:32 *** keikoz has joined #openttd
05:29:31 <Rubidium_> pickpacket: I guess it ends up in the list of https://github.com/OpenTTD/OpenTTD/blob/master/src/lang/english.txt#L5245, and I think you should include a {STRING1} to get the town name in there
05:31:06 <pickpacket> Rubidium_: thanks, I'll try that
05:31:24 <Rubidium_> I'm not 100% sure about having to include the {STRING} thing
05:33:32 <pickpacket> Rubidium_: I don't know how to work the string(STR_FARM_INDUSTRY_NAME) function to include it, but I'm tinkering with it
05:49:59 *** Artea has quit IRC (Ping timeout: 480 seconds)
05:55:41 <pickpacket> Actually I could just look at pretty much any industry in firsโ€ฆ theyโ€™re probably doing the same thing
05:59:19 <pickpacket> hm. FIRS is written in python, but the objects look like they correspond with the nml equivalents. And they don't have any explicit town name part to the station suffix
06:01:35 <pickpacket> Example: https://github.com/andythenorth/firs/blob/main/src/industries/arable_farm.py#L17
06:02:11 <pickpacket> https://github.com/andythenorth/firs/blob/main/src/lang/english.lng#L368
07:19:42 <TrueBrain> okay .. fixed IPv6 issues on the AWS cluster, now the wiki-preview loads really fast ๐Ÿ™‚ Glad that was the actual problem ๐Ÿ™‚
07:25:13 <TrueBrain> sentry should be alive too now .. getting there ๐Ÿ™‚
07:25:26 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #10905: Codechange: Sprite mapping for objects doesn't involve cargo types. https://github.com/OpenTTD/OpenTTD/pull/10905
07:25:26 <TrueBrain> now for the GitHub Actions magic .. let's see ...
07:26:44 <TrueBrain> lol, a better title for that PR: introducing magic numbers! ๐Ÿ˜„ Hihi, sorry .. not saying it is a bad thing, but you don't see that happening often ๐Ÿ˜„
07:27:28 <petern> Well I could add some constants I suppose.
07:28:20 <TrueBrain> the `case 0: return 0` is no longer there, so to approve this I actually need to understand this code ๐Ÿ˜›
07:28:21 <TrueBrain> darn it ..
07:28:36 <petern> I'd rather it was "default_spritegroup" and "purchase_spritegroup" but the system is set up to do it with arrays.
07:29:25 <petern> Yeah, 0 is handled as the default sprite group.
07:29:47 <TrueBrain> but code-wise that is now a difference .. as when `ctype` was 0, it would just continue .. and now it doesn't ๐Ÿ˜›
07:30:53 <petern> Now it ignores it, because spritegroup[0] is always set later as its used as the default sprite group.
07:31:18 <TrueBrain> well, with the difference it now throws a `invalid cargo bitnum` ๐Ÿ™‚
07:31:30 <TrueBrain> so it is not actually ignoring ๐Ÿ˜„
07:31:42 <TrueBrain> I wish I understood NewGRFs to put any value to that
07:32:04 <petern> Basically at that point, 0 means Passengers.
07:32:19 <Rubidium_> can't CT_PURCHASE_OBJECT's type be changed to size_t and its name to something like PURCHASE_OBJECT_SPRITE_GROUP_INDEX
07:32:19 <petern> (assuming default cargo types)
07:32:46 <petern> Is that verbose enough? ๐Ÿ˜„
07:33:03 <Rubidium_> then at least there won't be magic `1`s floating around
07:34:27 <TrueBrain> not your PR, but the more I look at this code, the more confused I get .. a normal day in NewGRF-land, I know .. but why does it loop over `cidcount` .. anything above 1 just overrides the last one, not?
07:34:58 <petern> It's a standard layout for all different features.
07:35:26 <petern> Other features can have different spritegroups depending on the cargo type.
07:35:36 <TrueBrain> but okay, a `ctype` of 0 before your PR would just silently be ignored, and now it tells you: fuck off (if you have `-dgrf=1` ofc)
07:35:59 <petern> It's merely a little message, it's not going to deactivate or anything...
07:36:05 <TrueBrain> the only flow that makes my statement untrue is if the `groupid` is invalid ๐Ÿ˜„
07:36:25 <petern> (And yes, I have tested it with a quite a lot of object NewGRFs and none of them trigger it)
07:36:45 <TrueBrain> owh, I have no doubt your code is good; I am always just surprised how difficult this is to understand ๐Ÿ™‚
07:36:50 <TrueBrain> my head is not made for this ๐Ÿ˜›
07:37:58 <Rubidium_> then maybe review some of my PRs; those might be better for your head ;D
07:38:18 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #10905: Codechange: Sprite mapping for objects doesn't involve cargo types. https://github.com/OpenTTD/OpenTTD/pull/10905#pullrequestreview-1456818792
07:38:21 *** Flygon has joined #openttd
07:38:24 <TrueBrain> no, I kinda gave up on those too ... sorry ๐Ÿ˜›
07:38:39 <TrueBrain> if you would make them trivial, it would be fine; but they rarely are ๐Ÿ˜„
07:38:46 <TrueBrain> (not your fault; annoying nevertheless)
07:39:02 <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #10905: Codechange: Sprite mapping for objects doesn't involve cargo types. https://github.com/OpenTTD/OpenTTD/pull/10905#pullrequestreview-1456818792
07:39:05 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10905: Codechange: Sprite mapping for objects doesn't involve cargo types. https://github.com/OpenTTD/OpenTTD/pull/10905
07:39:09 <petern> Oh, hah
07:39:24 <TrueBrain> well, at least you did it the right way
07:39:40 <petern> Hmm?
07:39:49 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #10905: Codechange: Sprite mapping for objects doesn't involve cargo types. https://github.com/OpenTTD/OpenTTD/pull/10905#pullrequestreview-1456820990
07:39:51 <TrueBrain> also fixing `0` ๐Ÿ™‚
07:39:56 <petern> Oh the magic 0, yeah.
07:40:03 <TrueBrain> most developers I know would only have done `1` and like: I did what you asked!
07:40:13 <petern> Ooof
07:40:43 <TrueBrain> the "it was already broken" argument ๐Ÿ™‚
07:40:48 <TrueBrain> broken .. wrong .. what-ever ๐Ÿ˜›
07:40:54 *** _aD has joined #openttd
07:41:01 <petern> Therefore we should keep shares?
07:41:07 <TrueBrain> yes! Absolutely!
07:41:16 <petern> Dare I look at the froom
07:42:16 <LordAro> ooh yeah
07:42:23 <LordAro> daily anger update
07:42:32 <petern> ๐Ÿ™‚
07:43:18 <LordAro> kamnet <3
07:44:15 <pickpacket> the froom has nothing exciting to offer today (yet)
07:45:59 <pickpacket> maybe instead help me figure out why nearby_station_name doesn't *add* something to the station name, but sets it entirely and removes the town prefix?
07:46:17 <TrueBrain> owh, you guys made me read the thread; at least it is funny ๐Ÿ™‚ I always love the arguments: "you did not validate the change!", with which they mean: "you did not validate the change with me!"
07:47:33 <pickpacket> I don't think the thread was too bad
07:48:04 <TrueBrain> it started horrible, as most of these threads go; then halfway down a few realise they have been holding pitchforks, put them down, and have a normal conversation.
07:48:14 <pickpacket> yeah
07:48:34 <TrueBrain> it is just a shitty way to interact with people, basically; but I always appreciate those people that tone down and try to have an actual conversation ๐Ÿ™‚
07:49:01 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #10745: Codechange: use more C++ constructs in strgen https://github.com/OpenTTD/OpenTTD/pull/10745#pullrequestreview-1456823871
07:49:03 <petern> They all consider that the only place for any discussion is the forum, everything being public on github does not matter at all.
07:50:54 <pickpacket> Little do they know that the only discussion that actually matters takes place in my living room
07:51:44 <petern> There's also a theme of people talking about issues on the forums but never actually creating a bug report, and then expecting that everyone just knows about it anyway because it was mentioned 5 years ago in a tiny subthread...
07:51:50 <TrueBrain> pickpacket: I think you worded it best in the thread; maybe next time I will use the longer sentence ๐Ÿ˜›
07:52:09 <TrueBrain> petern: in a post in the middle of a 500 long thread, yes ๐Ÿ˜„
07:52:32 <TrueBrain> anyway, I do like the idea of a button: buy-out-this-AI; seems to be the only complaint about the missing shares
07:53:24 <TrueBrain> I have seen code that forces bankruptcy of a company, so maybe that is the way in there. It was either in our codebase or in JGRPP, can't remember ๐Ÿ™‚
07:53:26 <LordAro> seems a strange way to play the game to me
07:53:34 <petern> Hmm, of course, someone will see what I've written and then use it as proof that we obviously hate the players ๐Ÿ™‚
07:53:40 <LordAro> but like many people say, maybe we shouldn't be trying to dictate how people play :p
07:54:07 <TrueBrain> haha, imagine if we did ... just remove all the settings ๐Ÿ˜„
07:55:03 <petern> As long as AIs can randomly buy out non-AI players, sure...
07:55:03 <TrueBrain> how I read it, people like playing with AIs till they are big enough and AIs annoy them .. a bit like: I don't want to be alone till I am a giant
07:55:32 <TrueBrain> hahaha, just imagine .... "You are bought out by an AI; goodbye"
07:55:35 <TrueBrain> and the game just closes ๐Ÿ™‚
07:56:22 <TrueBrain> owh, we should make an "evil" release of the game
07:56:23 <pickpacket> Aha!!! https://github.com/2TallTyler/lumberjack_industries/blob/main/src/farm.nml#L110
07:56:34 <TrueBrain> where it is just impossible to play it because of the amount of shitty things you get presented
07:56:52 <TrueBrain> Disaster++
07:57:13 <TrueBrain> "The people are forming an union, and are on strike", just 3 months of nothing moving
07:57:43 <TrueBrain> "Someone stole the copper of your tracks; it will take N time to replace"
07:57:54 <TrueBrain> yeah, we need to make custom disasters possible!
07:58:33 <Rubidium_> track will be fixed N time after copper has been delivered to the HQ :D
07:58:36 <petern> shares and dividends eh?
07:58:59 <TrueBrain> "Your investors are not happy about the dividend; they are considering replacing you as CEO"
07:59:08 <TrueBrain> and just being kicked out of your own company the following year
07:59:55 <TrueBrain> "Person X has silently bought 51% of your company, and you now have to get an approval for every expense from him first"
08:00:15 <TrueBrain> "You can't build this track as your shareholders don't like that"
08:00:35 <TrueBrain> "Your company colour is changed to green after a vote in the board of directors"
08:00:52 <TrueBrain> "You are forced to shave your beard"
08:00:54 <petern> Exactly
08:01:50 <Rubidium_> "Beeching has been appointed to the board" :D
08:01:52 <petern> You wanted to invest in cleaner modern trains? Tough, your investors wanted a higher return so you're stuck running those 20 year old derelicts.
08:02:24 <TrueBrain> I like this new game we are inventing ... OpenTTD goes political
08:02:37 <TrueBrain> you have to think about your company image etc
08:02:42 <petern> Hmm, I found a pain-au-chocolat, maybe time for second breakfast.
08:02:45 <LordAro> Rubidium_: D:
08:02:49 <TrueBrain> you had breakfast?!
08:03:09 <petern> Yes, I know.
08:03:37 <LordAro> TrueBrain: amazing
08:04:03 <petern> Where's andy when you need him to say "just write a GS"
08:04:31 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #10871: Codechange: replace C-style idioms with C++-style for file name generation https://github.com/OpenTTD/OpenTTD/pull/10871#pullrequestreview-1456840036
08:04:41 <LordAro> Rubidium_: there you go, i did 2 of them :)
08:07:18 <pickpacket> It works!!!!
08:07:29 * pickpacket is a happy little boy
08:08:19 <TrueBrain> if you happy and you know it clap your hands!
08:10:14 <pickpacket> https://help.hotschedules.com/hc/article_attachments/360047251112/giphy__12_.gif
08:17:09 <zephyris> Is it possible to have and set parameters in the baseset extra grf? Eg. Choosing cursor style, no terrain gridlines, etc. As the extra grf is essentially the a static newgrf I can't see why there would be major technical reasons why not... And a baseset options window (just like the standard newgrf one) would be great!
08:18:43 <Brickblock1> you might be able to do that by having it read parameters from a separate grf in the newgrf menu but that is a really weird workaround
08:19:01 <LordAro> such things are usually reserved for ogfx+, no?
08:19:28 <Brickblock1> why not have it in the baseset tho?
08:19:35 <pickpacket> Anyone opposed to making this addendum to the NML wiki? https://lounge.warmedal.se/uploads/600ca887c6b3df67/image.png
08:21:01 <Brickblock1> It seams complicated but if it is the easiest way I would see no problem with it
08:23:09 <pickpacket> it does, yes. Right now it says that the nearby_station_name is "Default additional name for a nearby station." but it doesn't appear to work that way. At least not for me. I found the solution I'm describing in https://github.com/2TallTyler/lumberjack_industries/blob/main/src/farm.nml#L110
08:23:54 <pickpacket> I saved the changes now. I guess andythenorth can correct me if I'm wrong :)
08:24:07 <zephyris> LordAro: Less user friendly... To me, if I'm looking to make client side cosmetic changes that is baseset rather than newgrf.
08:25:17 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #10905: Codechange: Sprite mapping for objects doesn't involve cargo types. https://github.com/OpenTTD/OpenTTD/pull/10905
08:28:09 <LordAro> zephyris: i agree, but base sets have always been just that, a base, set
08:28:38 <LordAro> more newgrfy people than me will be able to say more
08:28:52 <pickpacket> and onto bananas we go to upload new version of Tea Tea Deluxe!
08:30:05 <petern> Potentially parameters could be supported in the extra graphics GRF which is already a NewGRF.
08:31:03 <petern> But there is of course no way to specify parameters for that currently.
08:34:30 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #10871: Codechange: replace C-style idioms with C++-style for file name generation https://github.com/OpenTTD/OpenTTD/pull/10871#pullrequestreview-1456899088
08:35:15 *** Wolf01 has joined #openttd
08:37:38 *** Dekar has joined #openttd
08:42:06 <dP> just remove basesets :p
08:46:32 <pickpacket> Hmmm. I'm practicing terminus station design: https://lounge.warmedal.se/uploads/2537d49a2613dd78/image.png
08:46:36 *** Artea has joined #openttd
08:46:42 *** Dekar has quit IRC (Remote host closed the connection)
08:47:32 <petern> Ew
08:47:36 <pickpacket> It's surprisingly easy to extend, but when I look at it I do wonder how to scale it in terms of adding more inbound and outbound tracks
08:47:36 <Brickblock1> I think that a roro would be more efficient
08:47:47 <pickpacket> yeah, I think so too
08:48:45 <CK2347> I usually keep termini stations limited to 12 platforms
08:48:47 <JGR> pickpacket: Why on earth are you using two-way block signals?
08:48:56 <CK2347> Also that
08:49:16 <pickpacket> JGR: because they're the only block signals I've learned to use...
08:49:39 <dP> unless you have a slow cargo 3-4 platforms per line is enough
08:49:44 <dP> though I guess tea is a slow cargo xD
08:50:23 <pickpacket> and the upside of it is that sometimes when redesigning a section of track may need to change direction. It's nice to not have to switch signals then
08:50:31 <CK2347> I usually use some empty tile stations as yards so that the terminus doesn't get filled up
08:50:39 <pickpacket> dP: slow in what way? loading/unloading?
08:50:44 <CK2347> Oof too many excel sheets
08:50:45 <dP> yes
08:50:55 <dP> for vanilla cargos 3-4 is enough
08:51:06 <CK2347> Yes true
08:51:20 <pickpacket> My larger stations *always* fill up. Whether it's coal, tea, or something else.
08:51:33 <CK2347> Use timetables
08:51:45 <CK2347> Oh right it's not on vanilla
08:52:03 <dP> then you need more lines, not more platforms
08:52:26 <CK2347> How large are your stations?
08:52:46 <pickpacket> CK2347: I mean that I pretty much need to have loading/unloading at every platform at all times and cargo still tends to pile up
08:52:53 <pickpacket> 12 platforms, 7 tiles long
08:53:04 <CK2347> Hmm
08:53:28 <CK2347> I guess you need some greater wait times at some other station
08:53:48 <pickpacket> no, it's the same at the other end of the line
08:53:50 <dP> https://cdn.discordapp.com/attachments/1008473233844097104/1114114641220612116/Screenshot_from_2023-06-02_12-53-27.png
08:54:13 <CK2347> Oh dear
08:54:30 <CK2347> Lots of Signals
08:55:45 <dP> yeah, a bit too much, I don't thing gap1 is necessary on exits
08:55:51 <JGR> A huge city centre terminus for coal is a bit of a strange concept ๐Ÿ˜›
08:56:01 <pickpacket> JGR: that's not mine, though ;)
08:56:15 <dP> it's a screenshot from 1 mil citybuilder game
08:56:27 <pickpacket> dP has already seen this savefile: https://warmedal.se/~bjorn/files/openttd/quarndown-transport-openttd.sav it's a good example of where I usually end up with my games
08:57:01 <dP> for other cargos there are 3 more like this on each side
08:57:28 <pickpacket> Muhaven Woods, Quarndown North, and Geadstow Valley all have the problem of just not being able to move all their goods as fast as it comes in
08:59:34 <dP> https://cdn.discordapp.com/attachments/1008473233844097104/1114116084904239134/Screenshot_from_2023-06-02_12-59-09.png
08:59:34 <dP> dP: ๐Ÿ˜†
08:59:50 <pickpacket> ๐Ÿ˜†
09:00:24 <JGR> I prefer things a bit more aesthetically pleasing than that, even if it isn't strictly as efficient
09:00:39 <pickpacket> dP: How many platforms on each station? I.e whatโ€™s the maximum allowed width and length of a station?
09:00:50 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #10745: Codechange: use more C++ constructs in strgen https://github.com/OpenTTD/OpenTTD/pull/10745#pullrequestreview-1456914071
09:01:03 <dP> pickpacket: max station size is 7
09:02:05 <pickpacket> dP: w00t??? Thatโ€™s *a lot* of stations right next to each other. Are they all supplying the same cargo type?
09:03:33 <dP> not that many, first screenshot is just 3 stations, all coal
09:04:00 <pickpacket> I like roro stations because theyโ€™re quite beautiful and easy to scale, and Iโ€™ve learned how to use them well. The problem is that they take up a whole lot of space on both front, back, and to the side (as tracks turn back around)
09:04:09 <dP> second 8, all livestock+grain
09:04:21 <pickpacket> how do you distribute the cargo between stations?
09:04:44 <dP> just add industries until the line is full
09:05:36 <dP> https://cdn.discordapp.com/attachments/1008473233844097104/1114117601841385522/Screenshot_from_2023-06-02_13-05-18.png
09:05:36 <dP> other end of one group of stations xD
09:05:47 <dP> but it's the same for random industries
09:06:16 <dP> just more spread out
09:06:20 <pickpacket> I often have move goods from one station to transfer to another and then to another and then to the main station. This usually leads to two or three inbound lines transferring cargo to the main station and then as many trains as I can fit taking that cargo across the map to another station of similar size
09:07:27 <pickpacket> as the industries along the way increase production I wouldnโ€™t know how to efficiently distribute that cargo over more than one main station
09:07:46 <pickpacket> or how to efficiently distribute trains across those lines
09:09:42 <dP> well, in a goal games you eventually learn about how many industries you can connect to a line so it has enough capacity for the end game
09:10:09 <dP> so you just build that from the start and don't balance anything
09:10:19 <pickpacket> Even as production rates change?
09:11:12 <dP> yeah, goal games last about the same time so production increase is also about the same each game
09:11:52 <dP> if production changes are even allowed, that 1 mil server uses stable economy for example
09:12:09 <pickpacket> ah
09:12:45 <dP> but with typical goal game lasting under 3 hours industries don't really grow much anyway
09:12:54 <pickpacket> I'd like to start a map at 1950 and go way beyond 2050 just to try it out. But then I really need to figure out how to efficiently move cargo :D
09:16:54 <dP> if I were to play for so long game would just die in 50 years because of performance xD
09:17:21 <dP> or like 10 with build on pause xD
09:17:38 <pickpacket> lol
09:17:52 <pickpacket> I usually play 1024x1024 maps for 101 years
09:18:04 <pickpacket> with up to 1500 vehicles
09:27:33 <pickpacket> I should say that I need to have transparent cities and hide trees completely. Otherwise the computer really struggles
09:28:56 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #10745: Codechange: use more C++ constructs in strgen https://github.com/OpenTTD/OpenTTD/pull/10745#pullrequestreview-1456991850
09:32:16 <DorpsGek> [OpenTTD/OpenTTD] troilus closed issue #10704: [Bug]: Server does not apply the changes of openttd.cfg. https://github.com/OpenTTD/OpenTTD/issues/10704
09:41:59 *** _aD has quit IRC (Ping timeout: 480 seconds)
09:45:41 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #10745: Codechange: use more C++ constructs in strgen https://github.com/OpenTTD/OpenTTD/pull/10745#pullrequestreview-1457018184
09:54:15 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #10745: Codechange: use more C++ constructs in strgen https://github.com/OpenTTD/OpenTTD/pull/10745#pullrequestreview-1457032294
09:57:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #10745: Codechange: use more C++ constructs in strgen https://github.com/OpenTTD/OpenTTD/pull/10745
10:22:58 <petern> Oh.
10:34:20 <LordAro> Oh.
10:34:49 <LordAro> this test is looking for 4 instances of "bug2052" in a file that also happens to contain the version string of the program
10:34:54 <LordAro> my branch is named "bug20522"
10:40:27 <TrueBrain> Lol
10:51:00 <petern> Exposing bits of stl containers is a pain :/
11:33:09 <TrueBrain> hmm .. I am trying to find a nice way to get previews on PRs for the webservices we host .. the issue is, I can only have 1 preview site to deploy to. So I can't do the normal "deploy every PR on every update", as you wouldn't know what PR is deployed
11:33:31 <TrueBrain> GitHub has approvals on deployments you can add, but they are hidden 3 deep in the interface to approve .. so that is also not all that useful
11:34:55 <TrueBrain> and the label trick we use for OpenTTD itself also doesn't work, as again, only 1 PR can be deployed to preview at the time
11:35:13 <TrueBrain> so I guess something like a comment with `/preview` to trigger a deployment? And a comment stating if it is still deployed or not? Dunno .. tricky
11:36:44 *** _aD has joined #openttd
11:50:02 <Rubidium_> TrueBrain: is the copyright text on each page? If so, maybe you can inject the branch/PR/build number in there so it's clear what is deployed?
11:59:04 <TrueBrain> yeah, but from a PR point of view that would be a bit frustrating
11:59:11 <TrueBrain> say I want to test PR A, and you push new code to PR B
11:59:17 <TrueBrain> so now all of a sudden I get other code during my testing
12:01:09 <TrueBrain> just too bad it is way too much resources to deploy per PR .. that would make this simpler ๐Ÿ™‚
12:01:16 <TrueBrain> but we simply cannot afford that ๐Ÿ™‚
12:01:58 <TrueBrain> the thing we have going for us, that for most of these repositories we rarely have PRs. And more than one is even more rare.
12:02:28 *** _aD has quit IRC (Read error: Connection reset by peer)
12:07:59 <Rubidium_> so... another "perfect is the enemy of good" situation?
12:08:35 <TrueBrain> no, not really .. more a: GitHub has no integrated solution to build this in as little effort as possible
12:10:26 <TrueBrain> hmm, I guess it is either with a comment or with a label. I can of course make that only 1 PR can have the preview label .. and attaching it to one removes it from the other
12:10:32 <TrueBrain> at least visual clear which PR is under review
12:11:41 <petern> Should we pay attention to the rule that you should not inherit from stl containers?
12:11:58 <TrueBrain> aren't we doing that already?
12:12:00 <TrueBrain> what are you up to ๐Ÿ˜›
12:12:24 <petern> No, we have a few classes that inherit from STL containers. Most recently... MD5Hash.
12:14:42 <TrueBrain> yes, that is what I said, not? ๐Ÿ˜„
12:15:10 <TrueBrain> anyway, I have no clue about any of such rule, so *shrug*
12:16:10 <petern> Oh. Well the rule is that you shouldn't, because the destructors are not virtual.
12:16:20 <petern> <https://www.pietrolc.com/bad-class-design-inheritance-from-stl-container/>
12:16:23 <TrueBrain> they aren't? Scary ...
12:16:46 <petern> > The class design here below is for lazy programmers
12:16:50 <petern> I feel called out ๐Ÿ˜ฆ
12:16:57 <TrueBrain> so you always have to make it a member?
12:17:03 <TrueBrain> I guess that kinda makes sense honestly
12:17:20 <TrueBrain> just it makes for a lot of silly code
12:17:40 <petern> Yeah. So the recommendation is to just use using x = ... (like MD5Hash was, lol) with free functions, or make it a member.
12:17:43 <petern> Yup
12:18:09 <TrueBrain> well, the `using x =` didn't work either, as stupid PODs and their initialization ..
12:18:16 <TrueBrain> sad
12:20:47 <TrueBrain> okay, I think with a `preview` label is the easiest to implement .. and visually the most clear .. just too bad that a deployment per PR is just not feasable ๐Ÿ˜›
12:23:36 <TrueBrain> what always surprises me about these things, that it then looks like you are the only one that wants this .. but it is a very common flow in a lot of companies .. just none of them wrote a blog-post about it ๐Ÿ˜›
12:25:05 <TrueBrain> owh, I notice I haven't complained about this in a while: I miss GitHub CodeSearch so much ๐Ÿ˜ฆ Their normal search is shit .. I can't find anything with it. I could with their codesearch .. saddddd
12:26:29 *** _aD has joined #openttd
12:39:56 *** _aD is now known as Guest2013
12:40:01 *** _aD has joined #openttd
12:44:26 *** Guest2013 has quit IRC (Remote host closed the connection)
12:44:59 <DorpsGek> [OpenTTD/website] TrueBrain opened pull request #258: Fix: [CI] use alias as deployment URL https://github.com/OpenTTD/website/pull/258
12:45:34 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #10904: Fix: Re-opening GRF/script settings windows not closing drop down windows https://github.com/OpenTTD/OpenTTD/pull/10904#issuecomment-1573679056
12:55:22 <glx[d]> hmm dropdowns are really weird <https://github.com/OpenTTD/OpenTTD/blob/master/src/widgets/dropdown.cpp#L290>, they use an autoclose mechanism if parent is gone, I really don't get why they don't set `this->parent` at all
12:56:41 <petern> IIRC originally they always just closed if you released a mouse button
12:58:55 <glx[d]> I can see a delay after the click before firing the event yes
13:00:00 <glx[d]> and double fire even, as it's fired by this->Close() then right after it
13:01:56 <glx[d]> ah no, it's OnDropdownClose() followed by OnDropdownSelect()
13:07:18 <petern> The separate files for dropdown code goes back to the days of the WP() macro, so it probably wasn't immediately obvious to me when creating that that w->parent existed.
13:09:00 <petern> w->parent was added before that, but didn't update the original dropdown code.
13:09:48 <petern> So "really weird" just means "wasn't updated to use available info"
13:14:58 <petern> How safe is w->parent? Does closing a window also close its children?
13:16:02 <glx[d]> Window::Close() calls Window::CloseChildWindows()
13:18:38 <petern> Might not be safe to call OnDropdownClose() on a closing window.
13:18:39 <petern> Hmm
13:20:05 <DorpsGek> [OpenTTD/website] TrueBrain merged pull request #258: Fix: [CI] use alias as deployment URL https://github.com/OpenTTD/website/pull/258
13:49:54 *** _aD has quit IRC (Read error: Connection reset by peer)
14:16:23 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #10906: Codechange: use std::string to return the debug level information https://github.com/OpenTTD/OpenTTD/pull/10906
14:20:04 <petern> built with random?
14:21:17 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #10907: Codechange: replace strstr with more appropriate function https://github.com/OpenTTD/OpenTTD/pull/10907
14:21:20 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #10906: Codechange: use std::string to return the debug level information https://github.com/OpenTTD/OpenTTD/pull/10906#pullrequestreview-1457615870
14:21:50 <Rubidium_> petern: RANDOM_DEBUG
14:22:14 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #10907: Codechange: replace strstr with more appropriate function https://github.com/OpenTTD/OpenTTD/pull/10907#pullrequestreview-1457618468
14:22:28 <Rubidium_> EFINGERS_CANNOT_KEEP_UP_WITH_BRAIN
14:30:00 *** HerzogDeXtEr has joined #openttd
15:07:23 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #10906: Codechange: use std::string to return the debug level information https://github.com/OpenTTD/OpenTTD/pull/10906
15:07:26 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 closed issue #10903: [Bug]: Output of console command `debuglevel` without arguments may in some cases be truncated https://github.com/OpenTTD/OpenTTD/issues/10903
15:11:12 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #10907: Codechange: replace strstr with more appropriate function https://github.com/OpenTTD/OpenTTD/pull/10907
15:16:45 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #10899: Codechange: replace strecpy with string concatenation https://github.com/OpenTTD/OpenTTD/pull/10899
15:16:49 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #10908: Codechange: use fmt::format to create type prefixed driver names https://github.com/OpenTTD/OpenTTD/pull/10908
15:19:29 <DorpsGek> [OpenTTD/OpenTTD] anatolyeltsov commented on pull request #10541: Feature: Industry production graph https://github.com/OpenTTD/OpenTTD/pull/10541#issuecomment-1573907625
15:21:27 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #10908: Codechange: use fmt::format to create type prefixed driver names https://github.com/OpenTTD/OpenTTD/pull/10908#pullrequestreview-1457795254
15:40:47 *** Wolf01 is now known as Guest2029
15:40:49 *** Wolf01 has joined #openttd
15:46:13 *** Guest2029 has quit IRC (Ping timeout: 480 seconds)
15:49:48 <TallTyler> Wow, should have bought my tickets to Brussels sooner! I just snagged the very last seat on the 19:25 train back to Cologne. ๐Ÿ˜ฌ
15:50:21 <TallTyler> I'll have time for morning sightseeing too, as I'm arriving at 8:35 ๐Ÿ™‚
15:53:11 <DorpsGek> [OpenTTD/OpenTTD] ldpl commented on pull request #10541: Feature: Industry production graph https://github.com/OpenTTD/OpenTTD/pull/10541#issuecomment-1573957986
15:58:24 *** Compu has joined #openttd
16:01:38 *** Compu has quit IRC ()
16:02:26 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #10541: Feature: Industry production graph https://github.com/OpenTTD/OpenTTD/pull/10541#issuecomment-1573968933
16:05:46 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #10908: Codechange: use fmt::format to create type prefixed driver names https://github.com/OpenTTD/OpenTTD/pull/10908
16:09:22 <DorpsGek> [OpenTTD/OpenTTD] ldpl commented on pull request #10541: Feature: Industry production graph https://github.com/OpenTTD/OpenTTD/pull/10541#issuecomment-1573977883
16:11:22 <DorpsGek> [OpenTTD/OpenTTD] ldpl commented on pull request #10541: Feature: Industry production graph https://github.com/OpenTTD/OpenTTD/pull/10541#issuecomment-1573980438
16:11:35 <dP> I blame lag :/
16:29:02 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #10909: Codechange: use C++ strings/paths to resolve links in tars https://github.com/OpenTTD/OpenTTD/pull/10909
16:35:49 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #10909: Codechange: use C++ strings/paths to resolve links in tars https://github.com/OpenTTD/OpenTTD/pull/10909#pullrequestreview-1457978762
16:54:13 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #10909: Codechange: use C++ strings/paths to resolve links in tars https://github.com/OpenTTD/OpenTTD/pull/10909
16:54:22 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #10909: Codechange: use C++ strings/paths to resolve links in tars https://github.com/OpenTTD/OpenTTD/pull/10909#pullrequestreview-1458027596
17:31:35 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #10909: Codechange: use C++ strings/paths to resolve links in tars https://github.com/OpenTTD/OpenTTD/pull/10909#pullrequestreview-1458117030
17:59:15 *** _aD has joined #openttd
18:58:19 <TallTyler> dP: Cargo selection in the delivered cargo graph would be a nice thing to upstream, especially if that's already tracked and it's a simple UI addition to select from the totals
19:06:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #10909: Codechange: use C++ strings/paths to resolve links in tars https://github.com/OpenTTD/OpenTTD/pull/10909
19:28:25 <TallTyler> TrueBrain: Name tags acquired! I hope it's help with the awkwardness of whether to call people by their username or actual name...just use whatever they write down! ๐Ÿ™‚
19:28:49 <TallTyler> I'll have a Sharpie for writing, but anyone who wants fancy colours will have to bring their own markers ๐Ÿ˜›
19:28:57 <TrueBrain> Haha, be careful .. I might have fun with that statement
19:29:07 <TrueBrain> And nice ๐Ÿ˜„
19:31:58 <TrueBrain> I think I will use my alterego as name .. you know what DorpsGek means? ๐Ÿ˜„
19:38:39 <andythenorth> grf stocks and shares?
19:39:49 <TallTyler> Had to look it up, but yes
19:40:43 <petern> Hmm codespaces doesn't work well on android ๐Ÿ˜ฆ
19:49:40 <gnomechomsky> is anyone going to the meetup from germany?
19:51:59 <andythenorth> Eddi is ?
19:52:07 <andythenorth> maybe frosch?
19:52:42 <Eddi|zuHause> i'm still unsure
19:54:54 <gnomechomsky> Its quite expensive to make a train booking this late so I think I'll use the deutschland ticket to get to aachen and just pay for an express ticket for the final leg
19:56:05 <Eddi|zuHause> yes. but that would make more sense if you're spending the night in aachen
19:56:29 <Eddi|zuHause> otherwise you're spending the night on 8 different local trains
19:56:48 <gnomechomsky> even so I think a hostel in aachen is going to be cheaper
19:57:43 <Eddi|zuHause> i'm still looking for options, so if you're doing that, we could book the hostel together
19:57:44 <gnomechomsky> you have to spend the night because you can't rely on local trains to get you anywhere before the express departs
19:58:27 <Eddi|zuHause> probably two nights friday-sunday
19:58:34 <gnomechomsky> where are you coming from? Im in bayern
19:58:39 <Eddi|zuHause> east
19:59:36 *** gelignite has joined #openttd
19:59:47 <Eddi|zuHause> also, i'm thinking flixbus to brussels and back, frosch said the last train back is pretty early, and full
20:00:10 <gnomechomsky> yeah, that's possible too
20:01:13 <Eddi|zuHause> flixbus would be 7:25->9:30 and 22:10->1:25
20:01:41 <gnomechomsky> yeah I'll decide and buy tickets later
20:01:54 <gnomechomsky> but I'll let you know before i book a hostel
20:02:36 <frosch> yes, i am also staying in aachen, and the return from brussels to aachen is a problem
20:02:51 <Eddi|zuHause> are you staying in a hostel?
20:03:05 <frosch> earlier 2tt posted he got the last ticked on the train :p
20:03:11 <frosch> and it was already expensive when i booked
20:03:34 <frosch> i have a tiny (12mยฒ) hotel room next to the train station
20:04:01 <Eddi|zuHause> the return flixbus is also more expensive
20:05:24 <Eddi|zuHause> but that option is probably saner and healthier than spending 9:30 on a bus overnight
20:08:08 <Rubidium_> I can found a train route for ~50 euros from Brussel to Aachen (D 19:44).
20:08:42 <Eddi|zuHause> the flixbus is currently 26,99
20:08:57 <frosch> yes, the 19:44 route is the dangerous one
20:09:02 <frosch> i decided against it
20:09:13 <frosch> you have 7 minutes to switch trains in some belgian village
20:09:17 <frosch> and the connecting train is the last one
20:09:22 <Rubidium_> nah, I've got another one :D
20:09:23 <frosch> otherwise you have to walk 17km at night
20:09:43 <Rubidium_> Brussels -> Breda -> Eindhoven -> Heerlen -> Aachen
20:10:51 <Eddi|zuHause> why does it show me a 20:07 train connection?
20:11:29 <Eddi|zuHause> that's probably the one you meant
20:11:47 <frosch> 7 minutes in heerlen
20:11:50 <frosch> not much better
20:12:23 <Rubidium_> true
20:12:23 <frosch> also 4:28 in total :p
20:13:12 <frosch> i had to enter an intermediate stop in eindhoven to get that connection
20:13:19 <frosch> how did you find it? :p
20:14:09 <TrueBrain> Never underestimate the insane? :p
20:14:13 <frosch> the next train in heerlen after that is 7:48
20:14:24 <frosch> so if you want to stay 7 hours at the train station
20:14:25 <Rubidium_> knowing there's a shitload of relatively cheap trains from Brussels to Amsterdam. The first stop in the NLs is Breda, and then just checking Breda -> Aachen
20:15:14 <frosch> the problem is belgium for some reason. there are plenty of trains in nl and de later in the evening
20:15:18 <frosch> just be is shut down
20:15:53 <TrueBrain> You would almost think renting a car from aachen is cheaper ๐Ÿ™‚
20:16:01 <Rubidium_> there seem to be engineering works just north of Liege
20:16:06 <dP> TallTyler: cmclient has different style of charts so it's probably simpler to rewrite than upstream
20:16:12 <Eddi|zuHause> yesterday i googled renting a bike from aachen :p
20:16:21 <dP> and in vanilla charts changed comparad to original patch (that isn't even mine)
20:16:23 <Eddi|zuHause> said renting bikes is currently discontinued :p
20:16:31 <frosch> TrueBrain: probably true... did not consider that
20:16:35 <dP> and would be useful to have more years of history anyway
20:16:43 <frosch> too late now
20:17:05 <TrueBrain> For next time! ๐Ÿ˜›
20:17:47 <Eddi|zuHause> does belgian trains have a policy that you can get a taxi if you miss the last train?
20:18:10 <frosch> yep, 74โ‚ฌ for a car from aachen
20:18:27 <Eddi|zuHause> including fuel?
20:18:45 <frosch> is fuel ever included?
20:19:02 <frosch> hmm, though it's electric, so maybe
20:20:36 <frosch> i never rented an electric car, but the distance fits the offer
20:21:20 <Eddi|zuHause> well, if we are 3 or 4 people, car is probably the cheapest.
20:21:26 <Rubidium_> Eddi|zuHause: https://www.belgiantrain.be/en/support/faq/faq-routes-schedules/faq-delays-canceled-trains second to last question answers your question
20:21:45 <frosch> apparently the battery is just enough for aachen - brussels - aachen
20:21:56 <frosch> so maybe you run out of energy on the last meters :p
20:25:07 <frosch> TrueBrain: i actually learnt recently about a potential location for "the next time", i won't need a car for that distance either
20:25:33 <TrueBrain> What location?
20:25:56 <TrueBrain> Or what next time, depends how you look at it ๐Ÿ˜„
20:26:12 <frosch> https://bahnwelt.de/das-museum/fahrzeuge/
20:26:45 <frosch> i am "local" enough to that place, to also now a decent food place for a group of unknown size
20:27:01 <TrueBrain> And now he tells us, pfff :p
20:27:15 <frosch> i only learned about that place last week
20:27:21 <Eddi|zuHause> open only wednesday and sunday
20:27:40 <frosch> though i drove by it several times, and wondered about all the old train engines in sight from the track
20:28:08 <Eddi|zuHause> there are multiple places with old rolling stock spread around germany
20:28:28 <DorpsGek> [OpenTTD/team] ottdfevr opened issue #423: [fr_FR] Translator access request https://github.com/OpenTTD/team/issues/423
20:29:30 <frosch> oh i thought those times were only if you actually want to drive on the trains
20:29:47 <zephyris> Brickblock1: Wow, this actually works!
20:29:58 <Brickblock1> lol
20:30:05 <Brickblock1> nice
20:30:16 <Eddi|zuHause> i mean, i could offer you https://dbmuseum.de/halle/ :p
20:30:22 <zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1114289930051518555/baseset_params.png
20:30:22 <zephyris> I'd rather have this though ๐Ÿ™‚
20:30:37 <Brickblock1> me too
20:32:22 <frosch> Eddi|zuHause: is that more than 7 vehicles?
20:32:55 <Eddi|zuHause> it's rather small, in comparison...
20:33:18 <Eddi|zuHause> but probably more than 7 :p
20:36:07 <zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1114291379296817232/baseset_params2.png
20:36:07 <zephyris> Brickblock1: It even works in the title screen! It feels very odd, changing a NewGRF's parameters and seeing the cursor change!
20:36:52 <Brickblock1> only more reasons for an actual implementation
20:36:58 <frosch> offering settings for the extragrf in the baseset is not unthinkable, just noone did it yet ๐Ÿ™‚
20:37:04 <Brickblock1> but please chip this
20:38:59 <frosch> TrueBrain: food place would be https://www.bayerischer-biergarten.de/speisekarte/
20:39:10 <frosch> but yeah, we would need to ask for a special museum tour on a saturday
20:39:25 <TrueBrain> Bit late now, all this ๐Ÿ˜„
20:39:42 <frosch> ofc :p we said "next time"
20:39:46 <Rubidium_> can already plan for #12345 :D
20:41:19 <dP> static newgrfs already allow settings
20:41:33 <dP> baseset is basically static newgrf without settings but with gui dropdown
20:41:45 <Eddi|zuHause> what's this party called? #10k?
20:41:45 <dP> would be much better to have one way to do the same thing than make onether
20:41:57 <frosch> you need to find a place in openttd.cfg to store the baseset parameters :p
20:42:02 <frosch> that's probably the hardest part
20:42:32 <TrueBrain> Is there any place left in that file? /s
20:42:49 <Eddi|zuHause> wouldn't it be easier to just use a static newgrf?
20:43:48 <Brickblock1> static grfs aren't user frendly very few people are going to go digging in their configs
20:44:11 <dP> well, good reason to add gui for them
20:44:30 <Brickblock1> they also can't have parameters
20:44:51 <Eddi|zuHause> but it was just said they can
20:45:03 <dP> you sure? I didn't check
20:45:09 <dP> I just don't see why they wouldn't
20:45:21 <Brickblock1> doesn't it waste newgrf slots?
20:45:27 <Eddi|zuHause> no
20:45:55 <Eddi|zuHause> newgrf slot limit is for network protocol.
20:46:05 <Eddi|zuHause> static newgrfs are left out of that
20:47:27 <dP> Brickblock1: I just checked and it works fiine
20:47:39 <dP> ```[newgrf-static]
20:47:39 <dP> 56420505|317468DF8A58AA5262F5A4A2B246952E|BRIX-8bpp-x1.grf = 1 1 1 1 1 1 1 1 1 2 1 0
20:48:18 <Eddi|zuHause> i have two "sane" options to get to aachen. one with a 1h stopover, and one with only 5 minutes. but there's construction on the line, which breaks the train in two separate trains and a bus... which for me is a warning sign that it's probably going to be late :p
20:49:33 <dP> https://cdn.discordapp.com/attachments/1008473233844097104/1114294760300105788/Screenshot_from_2023-06-03_00-49-12.png
20:49:33 <dP> dP: ๐Ÿ˜†
20:57:28 <Eddi|zuHause> why doesn't bahn.de allow an option "avoid passing through this station" :p
20:57:41 <Ahyangyi> dP: That's... sub-arctic? ๐Ÿ˜ฎ
20:57:51 <frosch> Eddi|zuHause: frankfurt? :p
20:57:57 <Eddi|zuHause> dP: don't eat yellow snow
20:57:58 <dP> Ahyangyi: technically, yes
20:58:10 <Eddi|zuHause> frosch: no. Sangerhausen :)
20:58:33 <Eddi|zuHause> every time in the past year i've been going near that town, trains got weird...
20:58:42 <DorpsGek> [OpenTTD/team] glx22 commented on issue #423: [fr_FR] Translator access request https://github.com/OpenTTD/team/issues/423
20:58:58 <Ahyangyi> dP: How many shades does it have ๐Ÿ˜ฎ
20:59:22 <Eddi|zuHause> last time i took a train through there, i arrived by bus and left by bus.
21:02:22 <Eddi|zuHause> new record. connection taking 11 different trains? :p
21:03:11 <dP> Ahyangyi: shades of what? o_O
21:04:03 <dP> there are 4 levels of snow depth in the game
21:04:40 <dP> well, 5 I guess counting the absence of snow xD
21:05:03 <Ahyangyi> shades of terrain
21:05:18 <Ahyangyi> and are they tied to the snow lines?
21:05:34 <Eddi|zuHause> yes
21:05:34 <dP> yes, it's just a yellow "snow"
21:05:52 <dP> in brix you can chose between snow and desert tiles
21:07:32 <Ahyangyi> I see. Hilarious recursive acronym as well, why I didn't see it before ๐Ÿ˜ฎ
21:16:06 *** gelignite has quit IRC (Quit: Stay safe!)
21:48:44 *** keikoz has quit IRC (Ping timeout: 480 seconds)
21:49:40 *** Flygon has quit IRC (Remote host closed the connection)
21:56:33 <Eddi|zuHause> train to brussels in the morning is almost as cheap as the bus, but twice as fast
22:26:24 *** _aD has quit IRC (Quit: leaving)
22:32:07 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
22:48:42 <michi_cc[d]> gnomechomsky: I'm coming from Germany, but due to time constraints I'm doing the money solution (read flying).
23:49:08 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)