IRC logs for #openttd on OFTC at 2023-02-17
            
00:11:35 <petern> Hmm, "Noto Sans" has a massive space above it, even using the alternative metrics.
01:07:04 *** supermop_toil has quit IRC (Read error: Connection reset by peer)
02:09:13 *** Wormnest has quit IRC (Read error: Connection reset by peer)
02:09:27 *** Wormnest has joined #openttd
02:19:49 *** MaverickFischer has quit IRC (Quit: Due to budget cuts, the light at the end of the tunnel has been turned off.)
02:22:01 *** MaverickFischer has joined #openttd
02:53:43 *** Wormnest has quit IRC (Quit: Leaving)
03:06:14 *** tokai|noir has joined #openttd
03:06:14 *** ChanServ sets mode: +v tokai|noir
03:13:02 *** tokai has quit IRC (Ping timeout: 480 seconds)
03:45:27 *** D-HUND has joined #openttd
03:48:47 *** debdog has quit IRC (Ping timeout: 480 seconds)
04:13:46 *** TROILUS6 has joined #openttd
04:18:07 *** TROILUS has quit IRC (Read error: Connection reset by peer)
04:18:07 *** TROILUS6 is now known as TROILUS
04:41:27 *** keikoz has joined #openttd
04:59:34 *** Flygon has joined #openttd
05:23:35 <DorpsGek> [OpenTTD/OpenTTD] fmang commented on issue #10477: [Bug]: Build bridge window truncates speed and cost https://github.com/OpenTTD/OpenTTD/issues/10477
06:01:29 *** keikoz has quit IRC (Ping timeout: 480 seconds)
07:27:52 *** sla_ro|master has joined #openttd
08:00:48 *** Extrems has quit IRC (Ping timeout: 480 seconds)
08:04:40 *** keikoz has joined #openttd
08:10:46 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #10487: Fix #10486: [Script] Debug window requires AIs to be started before GS https://github.com/OpenTTD/OpenTTD/pull/10487#pullrequestreview-1302853882
09:18:46 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #10477: [Bug]: Build bridge window truncates speed and cost https://github.com/OpenTTD/OpenTTD/issues/10477
10:53:51 *** Samu has joined #openttd
11:24:56 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #10487: Fix #10486: [Script] Debug window requires AIs to be started before GS https://github.com/OpenTTD/OpenTTD/pull/10487
11:24:59 <DorpsGek> [OpenTTD/OpenTTD] glx22 closed issue #10486: [Crash]: Loaded savegame, crashed https://github.com/OpenTTD/OpenTTD/issues/10486
11:28:08 *** Samu has quit IRC (Read error: Connection reset by peer)
11:29:47 *** Samu has joined #openttd
12:11:36 <Samu> dang
12:12:16 <Samu> the window open code doesn't sync in multiplayer
12:12:29 <Samu> only when the host opens the window
12:22:26 <Samu> i dont understand this
12:23:14 <Samu> thid doesn't work in multiplayer at all... if (!GSWindow.IsOpen(GSWindow.WC_COMPANY_LEAGUE, window_number)) continue;
12:24:25 <petern> Why would you expect it to work?
12:25:44 <Samu> not even for the host
12:25:53 <Samu> i expected at least it would work for host
12:25:59 <Samu> https://docs.openttd.org/gs-api/classGSWindow.html#a8e52582c8f45b1384ad57e96ba6e326f
12:27:04 <petern> Check those preconditions eh?
12:29:34 <Samu> so i have to check each client clicks? that's :... daunting
12:36:33 <andythenorth> GS is a world of details
12:38:07 <glx[d]> The idea behind GSWindow is tutorials
13:00:34 *** ag has quit IRC (Quit: User went offline on Discord a while ago)
13:16:56 <petern> Ah, of course, andythenorth uses the sprite fonts.
13:17:35 <petern> Otherwise #10477 would've been... actually, no, it would still have slipped through as "normal"...
13:22:07 <Samu> i got another script instance crash... they never end
13:22:42 <Samu> ah nevermind, i'm outdated
13:23:21 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick dismissed a review for pull request #10471: Fix #10469, 5e14a20: [Script] League Table rating element is a int64 everywhere else https://github.com/OpenTTD/OpenTTD/pull/10471#pullrequestreview-1294806672
13:23:24 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #10471: Fix #10469, 5e14a20: [Script] League Table rating element is a int64 everywhere else https://github.com/OpenTTD/OpenTTD/pull/10471
13:23:45 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #10479: Fix 5e14a20: [GS] Save league table title into string https://github.com/OpenTTD/OpenTTD/pull/10479
13:56:56 <andythenorth> Sprite font -> truetype when?
14:04:03 <petern> When you even test it :p
14:07:31 * andythenorth having lunch
14:08:10 *** Extrems has joined #openttd
14:13:53 <Samu> hmm my method of detecting stations is flawed
14:14:34 <Samu> someone attached bus/lorry stations to a train station, but it's only using trains
14:15:04 <Samu> yet I point out as a lorry station
14:15:10 <Samu> with a great rating
14:15:14 <Samu> lol
14:18:31 <Samu> so i need to also check whether the station has road vehicles loading that cargo which has the highest rating
14:18:37 <Samu> omg
14:20:01 <glx[d]> I'm doing quick test with GS strings, there are so many things to validate beside param type
14:20:42 <glx[d]> param count is of course not checked, nor is the use of the right {STRINGX} flavour
14:33:26 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #10489: Fix #10477: Not enough space for text due to rounding down (OSX) https://github.com/OpenTTD/OpenTTD/pull/10489
14:41:23 <Samu> arg, i need to go through orders
14:41:26 <Samu> too complex
14:41:41 <Samu> check if they're actually loading
14:42:09 <Samu> it's doable, but it's gonna be so slow
14:42:21 <andythenorth> Samu: Many of these things might be done already in Superlib
14:42:52 <andythenorth> Or would be good candidates for including in a lib like superlib
14:43:09 <andythenorth> Possibly very very low use though
14:43:30 <andythenorth> I would guess there are mayve 10 GS authors?
14:43:48 <petern> Hmm, need cmath for std::ceil?
14:44:28 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10489: Fix #10477: Not enough space for text due to rounding down (OSX) https://github.com/OpenTTD/OpenTTD/pull/10489
15:24:06 <petern> M2 chip
15:24:06 <petern> MacBook Air
15:24:06 <petern> From £1,249
15:24:14 <petern> Hmm, that's quite a lot just to test a PR 😉
15:56:50 <andythenorth> Quite fast though
15:57:11 <andythenorth> Used M1?
15:59:30 *** D-HUND is now known as debdog
15:59:35 <andythenorth> michi_cc[d]: how about contractDist? Specific amounts per month between industry pairs?
16:07:19 <andythenorth> Wonder if we could do it by patching cdist _only_ at the first station the cargo arrives on the network, and leaving the rest up to cdist
16:07:36 <andythenorth> Hmm no that’s not how cdist works 😏
16:13:54 *** TROILUS has quit IRC (Read error: Connection reset by peer)
16:13:55 *** TROILUS9 has joined #openttd
16:14:05 *** TROILUS9 is now known as TROILUS
16:16:15 <Xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1076175256626155630/Flafingfield_Transport_1940-09-16.png
16:16:15 <Xarick> 4 tables ready
16:17:32 *** sla_ro|master has quit IRC ()
16:17:45 <Samu> ops, a string typo
16:50:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #10489: Fix #10477: Not enough space for text due to rounding down (OSX) https://github.com/OpenTTD/OpenTTD/pull/10489#pullrequestreview-1303808150
16:50:30 <dP> https://cdn.discordapp.com/attachments/1008473233844097104/1076183873806942278/Screenshot_from_2023-02-17_20-50-11.png
16:50:30 <dP> hm....
16:50:50 <Brickblock1> works flawlessly
16:51:30 <dP> f̷̀̅l̴͒͝ạ̴̽w̴͛͠l̶̅̇e̴̎̍ŝ̴̃s̵̻͂l̸̀̋y̶̐͝
16:57:07 <andythenorth> Lol
16:57:44 <Samu> what is that? RAW_STRING?
16:57:59 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #10483: Codechange: [Script] Don't expose static buffers outside of ScriptText https://github.com/OpenTTD/OpenTTD/pull/10483#pullrequestreview-1303835065
16:59:10 <dP> some messed up string codes I guess
17:01:20 <petern> dP: Sanitizing NewGRF strings could be better 🙂
17:04:28 <dP> sanitizing newgrf everything could be better xD
17:04:43 <petern> har har
17:06:25 <Brickblock1> https://cdn.discordapp.com/attachments/1008473233844097104/1076187878025084928/image.png
17:06:25 <Brickblock1> I might have found a bug
17:06:54 <Brickblock1> https://cdn.discordapp.com/attachments/1008473233844097104/1076188000674918580/image.png
17:07:25 <Brickblock1> train is set to elrl but still shows up on monorail tracks
17:08:09 <Brickblock1> this happened when I removed the railtype table
17:22:03 *** Wolf01 has joined #openttd
17:30:10 <petern> You removed the table which tells the game it is elrail, what did you expect?
17:31:20 <petern> (caveat, discord mobile won't let me zoom on the text so I can't read it)
17:31:53 <Brickblock1> fair I guess I was just dumb
17:40:50 <dP> isn't there a default railtype table?
17:41:08 <dP> `The default railtype labels are "RAIL", "ELRL", "MONO", "MGLV".`
17:41:23 <Brickblock1> yes in nml but it only has RAIL, MONO and MGLV
17:42:41 <Brickblock1> "Default railtype table: RAIL, MONO, MGLV."
17:42:45 <frosch> the default railtype of ttdp 🙂
17:42:58 <frosch> TTD had no ELRL
17:44:57 <frosch> either way, i would expect nml to not compile ELRL, if it is not defined
17:45:07 <Brickblock1> it did
17:45:24 <Brickblock1> tho it was an old version
17:47:27 <frosch> yeah, looks like yexo made a typo in 2010
17:52:02 <Gwyd> You put RAIL and set engine_class to ENGINE_CLASS_ELECTRIC
17:53:06 <Brickblock1> I know but I needed a railtype table which would make that not work as of openttd 13
17:54:14 <Samu> the plural of aircraft is aircrafts? :o
17:54:27 <debdog> no, just aircraft
17:54:33 <Samu> Ranks companies by profit of aircrafts per number of airport pieces.
17:54:39 <Samu> okay thx
17:55:20 *** Wormnest has joined #openttd
17:57:41 <Samu> im getting a strange error
17:58:13 <Samu> The index STR_MAIN_EMPTY does not exist?
17:58:15 <Samu> but it exists!
17:59:28 <DorpsGek> [OpenTTD/nml] frosch123 opened pull request #277: Fix: By default there is no ELRL railtype. https://github.com/OpenTTD/nml/pull/277
18:00:46 <Samu> assumes these 4 railtypes, 3 now?
18:01:25 <DorpsGek> [OpenTTD/nml] Brickblock1 commented on pull request #277: Fix: By default there is no ELRL railtype. https://github.com/OpenTTD/nml/pull/277#issuecomment-1435044068
18:03:17 <Samu> Ah, i had strings with the same name
18:03:32 <Samu> but the error wasn't clear at all...
18:03:45 <Samu> it should error more correctly
18:07:44 <DorpsGek> [OpenTTD/nml] frosch123 opened pull request #278: Update: reformat source with black 23.1 https://github.com/OpenTTD/nml/pull/278
18:09:05 <Xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1076203652697567232/Unnamed_1978-05-12.png
18:09:05 <Xarick> 6
18:09:06 <Gwyd> Brickblock1: In theory none on the train side
18:09:48 <Gwyd> railtype: rail; engine_class: ENGINE_CLASS_ELECTRIC; is the same as defining ELRL and using that
18:10:11 <Brickblock1> it isn't
18:11:05 <frosch> the ENGINE_CLASS_ELECTRIC thingie is a compatiblity thingie for stuff before railtypes were a thing. it only works if you have no railtype table
18:18:38 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
18:19:28 <DorpsGek> [OpenTTD/nml] glx22 approved pull request #278: Update: reformat source with black 23.1 https://github.com/OpenTTD/nml/pull/278#pullrequestreview-1303981098
18:22:23 <DorpsGek> [OpenTTD/nml] frosch123 merged pull request #278: Update: reformat source with black 23.1 https://github.com/OpenTTD/nml/pull/278
18:23:25 <DorpsGek> [OpenTTD/nml] frosch123 updated pull request #277: Fix: By default there is no ELRL railtype. https://github.com/OpenTTD/nml/pull/277
18:29:27 <Samu> wow, found a bug with ships
18:29:41 <Samu> they can't leave depot when there's a ship on the tile
18:29:55 <Samu> but the problem is that it's a ship from a competitor
18:31:33 <Samu> not sure if it's worth reporting
18:31:42 <DorpsGek> [OpenTTD/nml] glx22 approved pull request #277: Fix: By default there is no ELRL railtype. https://github.com/OpenTTD/nml/pull/277#pullrequestreview-1304007250
18:37:22 <DorpsGek> [OpenTTD/nml] frosch123 merged pull request #277: Fix: By default there is no ELRL railtype. https://github.com/OpenTTD/nml/pull/277
18:37:27 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened issue #10490: [Bug]: Ship can't leave depot because it's blocked by a competitor's ship https://github.com/OpenTTD/OpenTTD/issues/10490
18:37:40 <Samu> it's not really 13.0
18:37:48 <Samu> it's one of my branches
18:37:58 <Samu> not sure worth posting
18:38:04 <Samu> a savegame that won't load
18:39:46 <Samu> gonna try reproduce on 13.0
18:39:51 <glx[d]> I think it's known
18:40:00 <petern> Introduced by #6784 I assume.
18:42:12 <petern> Pretty easy fix tbh.
18:42:34 <TallTyler> #8578 is related, I think
18:42:36 <glx[d]> just need an owner check
18:43:12 <petern> TallTyler: Not really, that mitigates another problem, but 6784 introduced this issue 🙂
18:43:41 <TallTyler> Indeed. Related as in, where to look to put the easy fix 🙂
18:47:38 <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/2fdfc38da86d8bbc6486efb1e42d9e7517bde145
18:47:39 <DorpsGek> - Update: Translations from eints (by translators)
18:50:21 <glx[d]> yeah eints is fixed
18:56:18 <frosch> nightly is next 🙂
19:04:10 *** sla_ro|master has joined #openttd
19:12:22 <andythenorth> Ok so whilst we wait for WASM future
19:12:52 <andythenorth> Can we add some more traditional channels for town and industry comms?
19:13:08 <andythenorth> GS <-> grf
19:13:49 <andythenorth> I’d like to be able to assign a ‘type’ to towns, which could guide house placement etc
19:14:01 <andythenorth> Although regions could also do that
19:16:57 <petern> YouTube has put me on the Timberwolf algorithm.
19:17:18 <andythenorth> I’d also like to be able to call the random (rather than monthly) production change cb on an industry instance, with a hint value to the grf in a var
19:17:29 <andythenorth> petern: Same, all retro game stuff
19:17:43 <andythenorth> “Timberwolf is trending”
19:22:38 <andythenorth> Or we could extend INDUSTRY_CONTROL_FLAGS
19:26:47 <petern> Only in Doom can I defeat year another Cyberdemon, and yet die when ambushed by a Hellknight.
19:30:15 *** herms has quit IRC (Quit: bye)
19:33:48 *** herms has joined #openttd
19:39:07 <petern> Mainly because other games have other enemies.
19:39:26 <petern> andythenorth: does #10489 work?
20:04:52 <petern> M2 Mac time.
20:05:06 <petern> Maybe it can be emulated these days...
20:07:50 <frosch> nightly was successful \o/
20:12:36 <frosch> lol, ai/gs docs failed though
20:12:44 <frosch> everyday something different fails
20:14:45 <andythenorth> AWS can spot rent mac instances
20:20:11 *** Kuhnovic has joined #openttd
20:20:11 <Kuhnovic> Alright, I think it is time to confess. Time to come clean. I can't hold it in any longer...
20:20:11 <Kuhnovic> ... for the last 6 months I have been working on improving the ship pathfinder. I have always been annoyed by it, working with buoys is just a pain. I've read many tt-forums threads, several people have tried different but to no avail apparently. After many different attempts / ideas I've landed on something that seems to work really well. The TL;DR explanation is that it divides the world up into 8x8 "High Level Regions". The ship p
20:20:11 <Kuhnovic> world at this high level. If it finds a path then it will proceed with regular YAPF search, but only towards the next High Level Region.
20:21:36 <Kuhnovic> https://cdn.discordapp.com/attachments/1008473233844097104/1076236997829611570/image.png
20:21:36 <Kuhnovic> Here's a picture with lot's of ugly debug drawing enabled. The black 8x8 regions sort of show the high level path, and you see that the ship only finds it's path towards the next region (the white path)
20:21:47 <glx[d]> frosch: nightly workflow doesn't show any error
20:22:14 <frosch> https://github.com/OpenTTD/workflows/actions/runs/4207102207 <- it's there, but no imporant error
20:28:19 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #10483: Codechange: [Script] Don't expose static buffers outside of ScriptText https://github.com/OpenTTD/OpenTTD/pull/10483
20:29:20 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #10479: Fix 5e14a20: [GS] Save league table title into string https://github.com/OpenTTD/OpenTTD/pull/10479#issuecomment-1435232418
20:29:23 <DorpsGek> [OpenTTD/OpenTTD] glx22 closed pull request #10479: Fix 5e14a20: [GS] Save league table title into string https://github.com/OpenTTD/OpenTTD/pull/10479
20:29:47 <andythenorth> Kuhnovic: Intriguing 🙂
20:32:19 <petern> Kuhnovic: Nice, someone(tm) has actually done it ...
20:32:52 <Kuhnovic> What is the best place nowadays to show off / colaborate on something like this? We have github PRs and discussions, tt-forums, and the development forum here in discord....
20:33:25 <petern> If you have code (you clearly do) then a PR 🙂
20:34:25 <petern> This is someone that has been wanted for years too.
20:35:51 <Kuhnovic> petern: Yes I know, I found this thread https://www.tt-forums.net/viewtopic.php?t=58905&sid=3049d94370e755715090a93f8a7b9c85 . It inspired me to go the route that led to success. But there is of course a difference between having a patch and having something that is worthy of releasing. I want those damn ships fixed :
20:36:35 <andythenorth> PR 🙂
20:37:11 <andythenorth> Reviews here don’t always move quickly 🙂
20:37:21 <Kuhnovic> petern: Alright, then I'll go for a PR. Just a warning, I created a giant mess, it needs lots of cleanup. Right now I am trying to get the concept to work reliably. Just a little disclaimer 😉
20:39:42 <andythenorth> If you PR it and someone adds the preview tag it can be WASM tested
20:41:11 <glx[d]> mark it draft
20:42:51 <Kuhnovic> Does preview work even if any checks fail? I can 100% guarantee that there are accidental tabs-where-there-are-spaces, and worse 😛
20:43:32 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #10471: Fix #10469, 5e14a20: [Script] League Table rating element is a int64 everywhere else https://github.com/OpenTTD/OpenTTD/pull/10471
20:43:56 <glx[d]> preview doesn't care, it's a different workflow
20:55:58 <Samu> testing with infrastructure maintenance costs enabled, the statistics are very interesting
20:56:14 <Samu> I just don't know how to account for them exactly
20:56:24 <Samu> I'm adding the profit of all vehicles
20:56:34 <Samu> last year + current year
20:57:41 <Samu> then subtract by infra maint cost, which is a montly value, so i multiply between 12 + (range 1 to 12, depending on current month)
20:57:52 <Samu> and divide by number of pieces
20:58:03 <Samu> not sure it's fair
20:58:07 <Samu> or correct
20:58:36 <Samu> local efficiency = infrastructure_count > 0 ? (profits - maintenance_cost * 12 + GSDate.GetMonth(GSDate.GetCurrentDate())) / infrastructure_count : 0;
21:00:19 <Samu> i could be more pedantic, and do it for each day of the year
21:36:12 *** gelignite has joined #openttd
21:38:40 <Samu> https://gist.github.com/SamuXarick/29d18cd6bfa264bbb1f4fbf8ff40c757
21:39:32 <Samu> could someone check my efficiency formula is correct?
21:40:26 <Samu> if someone cheats the date, it breaks :p
21:45:56 *** HerzogDeXtEr has joined #openttd
22:00:12 *** gelignite has quit IRC (Quit: Stay safe!)
22:07:31 *** Tirili has joined #openttd
22:35:50 *** sla_ro|master has quit IRC ()
22:39:04 <DorpsGek> [OpenTTD/OpenTTD] SuborbitalPigeon commented on pull request #10141: Fix #10140: [SDL2] Lock mouse while moving viewport https://github.com/OpenTTD/OpenTTD/pull/10141#issuecomment-1435357943
22:51:49 *** keikoz has quit IRC (Ping timeout: 480 seconds)
23:08:44 *** Samu has quit IRC (Quit: Leaving)
23:14:29 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
23:54:21 <glx[d]> first step for validation of GS strings is done <https://github.com/OpenTTD/OpenTTD/compare/master...glx22:OpenTTD:GS_string_params>