IRC logs for #openttd on OFTC at 2023-01-28
            
00:03:15 *** _aD has quit IRC (Quit: leaving)
00:09:42 *** WormnestAndroid has joined #openttd
00:14:53 *** sla_ro|master has quit IRC ()
00:50:46 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
01:28:34 *** Wormnest has joined #openttd
02:21:11 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
02:40:50 *** Tirili has quit IRC (Remote host closed the connection)
02:58:40 *** Wormnest has joined #openttd
03:14:58 *** HerzogDeXtEr has joined #openttd
03:21:31 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
03:21:38 *** WormnestAndroid has joined #openttd
03:27:56 *** D-HUND has joined #openttd
03:29:41 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
03:29:56 *** WormnestAndroid has joined #openttd
03:31:21 *** debdog has quit IRC (Ping timeout: 480 seconds)
03:42:35 *** Wormnest has quit IRC (Quit: Leaving)
04:46:38 *** keikoz has joined #openttd
05:52:09 *** keikoz has quit IRC ()
05:53:43 *** APTX has quit IRC (singleton.oftc.net coherence.oftc.net)
05:54:11 *** APTX has joined #openttd
06:07:14 *** keikoz has joined #openttd
06:17:14 *** APTX has quit IRC (singleton.oftc.net coherence.oftc.net)
06:18:17 *** APTX has joined #openttd
08:05:09 <andythenorth[d]> JGR: :this:
08:07:45 *** Flygon has joined #openttd
08:31:56 *** nielsm has joined #openttd
09:10:24 *** sla_ro|master has joined #openttd
09:28:10 *** Wolf01 has joined #openttd
09:32:16 <andythenorth[d]> this is waiting for a 13.1 or so yes? https://github.com/OpenTTD/OpenTTD/pull/10399
09:32:49 * andythenorth[d] about to do a Horse branch (or not)
09:45:25 <Rubidium> well, it doesn't even have a `backport requested`, so it doesn't look like it's going to end in the 13 branch (yet)
09:46:40 *** playback2396[m] has joined #openttd
10:05:02 <andythenorth[d]> that label should only be added once it's approved/merged?
10:08:07 *** Samu has joined #openttd
10:18:45 <michi_cc[d]> On paper there should be no new features for 13.0, we already have enough bugs. And for 13.1 or so some master testing first doesn't sound too stupid.
10:20:30 <michi_cc[d]> In practice, as long as no one comes around to approve the backport PR, approve a changelog PR and decides on RC2 or proper 13.0, it does not matter either way.
10:21:10 <michi_cc[d]> BTW, was anything in any way or form done so that TB does not have to manually intervene again on tagging?
10:23:14 <Rubidium> do you mean the too many files to CDN issue? #10301 Then it doesn't look like anything to resolve the issue has been done
10:23:50 <michi_cc[d]> Yeah, that looks like it.
10:24:41 <andythenorth[d]> seems to need a decision on what we actually want?
10:26:08 <michi_cc[d]> Yeah, but it would really need some input from orudge for the Windows Store stuff.
10:26:38 <andythenorth[d]> ok but reversing it
10:26:49 <andythenorth[d]> what we *don't* want is a broken CDN index?
10:28:37 <michi_cc[d]> What we don't want is a manual intervention every tag.
10:29:06 <michi_cc[d]> I.e. a TrueBrain dependency.
10:29:37 <andythenorth[d]> ok so the JFDI thing would just be to stop that happening, by not publishing those files?
10:29:50 <andythenorth[d]> or by generating the checksums and prefix?
10:30:08 <michi_cc[d]> Yeah, and the proper response depends on if orude needs them for the Store or nor.
10:30:39 <andythenorth[d]> otherwise we're carrying pointless files around on the CDN?
10:30:42 <andythenorth[d]> but otherwise no harm?
10:30:58 <andythenorth[d]> but if we don't have them, we might not be able to make a Windows release without manual intervention?
10:31:12 <michi_cc[d]> Windows Store, not Windows.
10:31:18 <andythenorth[d]> ah ok 🙂
10:31:29 <michi_cc[d]> And I have no idea if they are really needed or not.
10:31:58 <andythenorth[d]> I always favour deleting things and seeing what goes wrong
10:32:16 <andythenorth[d]> but the safe thing is probably to have them on the CDN and use a tiny bit more coal to power an AWS disk
10:32:27 <andythenorth[d]> but then we might carry them around forever pointlessly
10:33:41 <andythenorth[d]> or we can ask orudge and see if there's a reply 🙂
10:42:00 <TrueBrain> michi_cc[d]: I can see what I can do to resolve that issue today. Given I have no additional input, I am just going to spin the wheel and pick what-ever 😛
10:42:28 <andythenorth[d]> 1 in 3 chance
10:43:05 * andythenorth[d] wonders if this is a Monty Hall game
10:43:16 <TrueBrain> but let's first make a nice little place for the backport stuff .. new repo? I guess that is best ..
10:43:31 <andythenorth[d]> oof I am supposed to be doing chores, but I want to nap
10:43:45 <TrueBrain> sounds like a you problem 😛
10:43:49 <andythenorth[d]> very
10:49:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #10420: Backport master into release/13 https://github.com/OpenTTD/OpenTTD/pull/10420#issuecomment-1407372190
11:01:51 <TrueBrain> michi_cc[d]: : so you just wanted to check if there is a label "backport squash" in the list, right?
11:03:11 <michi_cc[d]> Yeah, if the label is present, just pick the one commit, not the amount indicated in the PR itself.
11:03:14 <TrueBrain> you were like really close with a proper solution 🙂 The `next()` part only is a bit silly 😉
11:03:20 <TrueBrain> `if any(True for node in pr["node"]["labels"]["nodes"] if node["name"] == "backport squash"):` or something would be more readable 🙂
11:03:45 <michi_cc[d]> I think I tried any first, but I couldn't get it to do what I want
11:04:03 <TrueBrain> you now return a list, and with `next()` check if the first element is not None
11:04:14 <TrueBrain> with `any` you check if the returning list contains anything 'true-ish'
11:04:29 <michi_cc[d]> But I think I didn't try your line, because neither Google nor SO had it :p
11:05:09 <TrueBrain> odd 🙂 Pretty common ... 😛
11:05:35 <michi_cc[d]> There was something with any, but it looked slightly different and didn't work 🙂
11:06:47 <michi_cc[d]> (Can you tell I don't do Python? :p )
11:06:59 <TrueBrain> you got pretty far for someone who doesn't
11:07:09 <TrueBrain> most don't get even close to such list statements 😛
11:07:30 <andythenorth[d]> can't chatGPT write it? 😛
11:08:41 <michi_cc[d]> I searched for "python find element in list of dicts" and <https://stackoverflow.com/questions/8653516/python-list-of-dictionaries-search> is the first hit 🙂
11:09:35 <andythenorth[d]> lots of python golf in that SO
11:09:47 <TrueBrain> oof, such a weird suggestion for that use-case .. but what-ever floats people's boat 😛
11:10:03 <andythenorth[d]> black ruins some python golf games
11:11:07 <TrueBrain> still surprised that backport script actually works in so many cases 😄
11:14:20 <michi_cc[d]> One thing still missing in my script is that it should probably remove the "backport squash" as well when updating that tags for --mark-done.
11:14:57 <TrueBrain> https://github.com/OpenTTD/scripts/pull/2
11:15:04 <TrueBrain> I now at least put it at a place where we can PR things 🙂
11:16:40 <michi_cc[d]> Ah, no appropriate permission 🙂
11:17:40 <TrueBrain> you are now a backend horse 😛
11:19:22 <TrueBrain> right, now for the release flow ... did we ever do a vote on whether to keep those pesky linux distros?
11:19:32 <TrueBrain> I should check how often they are downloaded I guess ..
11:19:39 <TrueBrain> they also break a lot ...
11:22:38 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
11:24:37 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #10420: Backport master into release/13 https://github.com/OpenTTD/OpenTTD/pull/10420#issuecomment-1407378147
11:25:44 <michi_cc[d]> TrueBrain: I privmsg orudge for #10301 and he just said he'd have a look.
11:25:55 <TrueBrain> cheers
11:26:05 <TrueBrain> one downside of Discord .. no privmsg on IRC 😛
11:26:20 <michi_cc[d]> Well, even worse, I used tt-forums 🙂
11:26:24 <Rubidium> TrueBrain: just remove the EOL ones (i.e. Buster and Bionic), and next cycle or the one after it the other two are EOL and they're gone ;)
11:26:24 <TrueBrain> haha
11:26:43 <TrueBrain> I mainly need to know what his intentions are btw; the work we can do just fine 🙂
11:29:00 <TrueBrain> lol, the access-logs are stored in a single directory .. I assumed AWS would put them in sub-folders
11:29:02 <TrueBrain> it didn't 😛
11:29:27 <TrueBrain> few years of files in a single folder ... lovely 😄
11:31:07 <andythenorth[d]> chores done, nap or tanks or make GS minigames? 😛
11:33:09 <TrueBrain> lol, so in April last year, people actually downloaded OpenTTD 0.1.1 etc 😛
11:34:10 <TrueBrain> 23k Windows downloads, 3k MacOS downloads, and 3k Linux .deb downloads
11:34:14 <TrueBrain> people actually download those files
11:34:18 <TrueBrain> I am a bit surprised 😛
11:35:09 <DorpsGek> [OpenTTD/OpenTTD] orudge commented on issue #10301: [Bug]: GitHub Actions Release workflow publishes too many files to the CDN https://github.com/OpenTTD/OpenTTD/issues/10301
11:36:10 <TrueBrain> good; that is an easy fix
11:38:44 <Eddi|zuHause> how does that compare to steam download numbers?
11:54:44 <petern> Morning
11:55:30 <TonyPixel> Wow, orudge
12:09:45 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #10421: Codechange: pass large objects by reference instead of value https://github.com/OpenTTD/OpenTTD/pull/10421
12:14:44 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #10422: Remove: Ubuntu/Debian release binaries (instead, use the Generic) https://github.com/OpenTTD/OpenTTD/pull/10422
12:16:47 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #10422: Remove: Ubuntu/Debian release binaries (instead, use the Generic) https://github.com/OpenTTD/OpenTTD/pull/10422
12:20:23 <michi_cc[d]> I guess for Linux something like Flatpak would be more useful than various distro-specific releases.
12:20:35 <TrueBrain> the Generic version also works very well, from what I can tell
12:21:14 <TrueBrain> it is a manylinux2014
12:21:21 <TrueBrain> so any OS newer than 2014, works, basically
12:21:56 <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #10421: Codechange: pass large objects by reference instead of value https://github.com/OpenTTD/OpenTTD/pull/10421#pullrequestreview-1273912524
12:23:11 <michi_cc[d]> The advantage would be if we'd publish to Flathub.
12:23:40 <TrueBrain> similar could be said about snap, and the tons of other eco-systems that have been created over the last few years
12:24:02 <TrueBrain> we tried flatpack a while back; it was a bit of a nightmare in more than one way 😛
12:25:24 <TrueBrain> ah, yes, flatpack builds for specific Linux OSes, that was the annoying part there
12:25:34 <TrueBrain> so still something for us to visit every release, to see if things have changed
12:28:35 <petern> Odd, I thought part of the point of flatpak was to avoid that.
12:29:07 <TrueBrain> used for the "testing" part in the flatpack definition in the last PR we got from it
12:29:52 <TrueBrain> but in fairness, that was a while ago
12:30:04 <TrueBrain> it also only build for x86_64, so that is a bit dated anyway 😛
12:33:43 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #10422: Remove: Ubuntu/Debian release binaries (instead, use the Generic) https://github.com/OpenTTD/OpenTTD/pull/10422
12:43:26 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #10421: Codechange: pass large objects by reference instead of value https://github.com/OpenTTD/OpenTTD/pull/10421
13:04:21 <TrueBrain> pff, making changes to the release workflow is tricky .. hard to test 😛
13:04:28 <TrueBrain> and slow to test ...
13:27:45 <andythenorth[d]> https://tenor.com/view/hug-gif-25569675
13:27:53 <andythenorth[d]> inappropriate? probs
13:28:13 <TrueBrain> is it okay if I don't click that? 😛
13:29:08 <andythenorth[d]> oh it's clickable?
13:29:18 <andythenorth[d]> yeah it just lightboxes
13:29:30 <Merni> lightboxes?
13:29:39 <andythenorth[d]> expands the image
13:33:21 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #10422: Remove: [Actions] Ubuntu/Debian release binaries (instead, use the Generic) https://github.com/OpenTTD/OpenTTD/pull/10422#issuecomment-1407400211
13:33:55 <TrueBrain> "duplicate dep", well, that is lovely cryptic 😛
13:34:17 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #10406: Codechange: add annotation to selectively force inlining in debug build https://github.com/OpenTTD/OpenTTD/pull/10406
13:34:42 <TrueBrain> but yeah, for sure not for that PR 😛 Lol 🙂
13:34:49 <TrueBrain> I randomly triggered glx[d] 😛 😄
13:36:44 <TrueBrain> but yes, will remove the duplicated dependency thingy in the apt-get in my next PR 😉
13:57:44 *** TROILUS has quit IRC (Quit: Ping timeout (120 seconds))
13:58:40 <TrueBrain> takes ~20 minutes per attempt to make Windows Store work the way I want .. lol
13:59:05 <Merni> Do people actually use windows store?
14:00:04 <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #10420: Backport master into release/13 https://github.com/OpenTTD/OpenTTD/pull/10420
14:01:44 <michi_cc[d]> I'd assume there are stats somewhere, but probably only accessible by orudge.
14:02:26 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #10423: Fix several cases where global pointer outlives stack reference https://github.com/OpenTTD/OpenTTD/pull/10423
14:04:29 <TrueBrain> it does detect crashes 😛
14:05:02 <TrueBrain> ~100 downloads a week on Windows Store
14:05:05 <TrueBrain> so better than GOG 😛
14:05:13 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #10414: Codechange: use RAII to automatically restore _cur_dpi after use https://github.com/OpenTTD/OpenTTD/pull/10414
14:05:47 <TrueBrain> ~150 active sessions per day via Windows Store
14:06:19 <TrueBrain> vs 600 on Steam
14:06:27 <TrueBrain> well, no, Steam is peak
14:06:31 <TrueBrain> Windows Store is total
14:11:49 *** Soni has quit IRC (Quit: No Ping reply in 180 seconds.)
14:13:04 *** Soni has joined #openttd
14:19:47 <TrueBrain> michi_cc[d]: PS: you can access those stats too 😉 Login details are in 1password 🙂
14:21:34 *** Soni has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
14:23:26 *** Soni has joined #openttd
14:28:32 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #10423: Fix several cases where global pointer outlives stack reference https://github.com/OpenTTD/OpenTTD/pull/10423
14:29:36 *** D-HUND is now known as debdog
14:30:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #10380: Hide Tile and TileExtended implementation details inside Map structure https://github.com/OpenTTD/OpenTTD/pull/10380
14:33:09 <michi_cc[d]> TrueBrain: Nope, you only gave me the Socials vault.
14:33:18 <TrueBrain> I did?! 😮
14:33:19 <TrueBrain> I suck
14:36:11 <TrueBrain> right, seems windows-store will now work fine .. guess I should add automated GOG upload too ..
14:36:36 <TrueBrain> just how to test it .. long waiting times ahead .. 😛
14:48:38 <TrueBrain> an installer that asks to accept the license, which uses a `read` ... eeeuuuhhh .. that is tricky to automate 😛
14:53:20 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #10380: Hide Tile and TileExtended implementation details inside Map structure https://github.com/OpenTTD/OpenTTD/pull/10380
14:59:13 <DorpsGek> [OpenTTD/OpenTTD] github-code-scanning[bot] commented on pull request #10423: Fix several cases where global pointer outlives stack reference https://github.com/OpenTTD/OpenTTD/pull/10423#pullrequestreview-1273938127
15:02:50 *** Soni has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
15:05:13 *** Soni has joined #openttd
15:06:13 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #10422: Change: [Actions] several improvements for the release workflow https://github.com/OpenTTD/OpenTTD/pull/10422
15:06:41 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #10422: Change: [Actions] several improvements for the release workflow https://github.com/OpenTTD/OpenTTD/pull/10422
15:08:52 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #10423: Fix several cases where global pointer outlives stack reference https://github.com/OpenTTD/OpenTTD/pull/10423#pullrequestreview-1273940587
15:10:07 <michi_cc[d]> Soooo, 13.0-RC2 or 13.0???
15:11:08 <TrueBrain> okay, doing some final testing on the release workflow .. I -think- it mostly works
15:11:14 <TrueBrain> but it is really hard to actually test without making a release
15:12:23 <TrueBrain> as in, I cannot just publish a new version on GOG to "test it out" 😛 That would be a bit weird, for people to receive some random master version out of nowhere 😄
15:17:09 <Rubidium> sounds like RC2
15:18:03 <Rubidium> and if everthing's working right and whne no major issues show up a release on say the first that is just retagging 13.0-RC2 as 13.0
15:18:14 <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #10422: Change: [Actions] several improvements for the release workflow https://github.com/OpenTTD/OpenTTD/pull/10422#pullrequestreview-1273942351
15:18:46 <TrueBrain> hmm, one minor issue with GOG at least ...
15:19:55 <TrueBrain> let's just download 13.0-RC1 for testing GOG flow .. instead of my current attempts 😛
15:20:21 <TrueBrain> why does OpenTTD take so long to build again? 🙂
15:20:51 <TrueBrain> having a password with a `>` in it, turns out to be somewhat nasty for CLIs 😛
15:20:54 <glx[d]> 3 windows binaries, 2 macos
15:21:49 <michi_cc[d]> Okay, Rb volunteered to run the proper release run next weekend :p
15:25:11 <Rubidium> if only I would be near home and would actually know how to ;)
15:25:38 <TrueBrain> good news! The "how to" is extremely easy; even documented on the wiki!
15:27:26 <glx[d]> a lot of magic is done with just a button on github 🙂
15:29:51 <TrueBrain> okay .. GOG upload for Linux works
15:29:52 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #10422: Change: [Actions] several improvements for the release workflow https://github.com/OpenTTD/OpenTTD/pull/10422#pullrequestreview-1273942351
15:29:55 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #10422: Change: [Actions] several improvements for the release workflow https://github.com/OpenTTD/OpenTTD/pull/10422
15:29:57 <TrueBrain> didn't test the rest, but .. pretty sure it works too 😛
15:31:03 <TrueBrain> nevertheless, will do a test-run
15:31:16 <TrueBrain> will take an hour .. going out for dinner .. so if it works, will merge the above PR later tonight 😄
15:34:01 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #10301: [Bug]: GitHub Actions Release workflow publishes too many files to the CDN https://github.com/OpenTTD/OpenTTD/issues/10301
15:34:27 <TrueBrain> owh, and it might be that the next release breaks some of our tooling; either the CDN generator or our website. But that is hard to see now. So when it breaks, I will fix those when we release 🙂
15:34:36 <michi_cc[d]> Rubidium: It's in the Discord channel pins (oops, being evil here 🙂 )
15:35:27 <TrueBrain> lol, you made a step-by-step list, how nice 😄
15:35:31 <michi_cc[d]> Anybody wants to do something about #10420 (like approve or such stupid things)?
15:55:17 <Rubidium> stupid like adding a 'backport requested' label? ;)
15:55:58 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #10423: Fix several cases where global pointer outlives stack reference https://github.com/OpenTTD/OpenTTD/pull/10423#pullrequestreview-1273952618
15:57:42 <Rubidium> though seriously, shouldn't 10420 include 10422? Or would we put that in the changelog PR?
16:01:02 <michi_cc[d]> A second backport PR is not forbidden 🙂
16:01:33 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #10420: Backport master into release/13 https://github.com/OpenTTD/OpenTTD/pull/10420#pullrequestreview-1273958202
16:03:13 <DorpsGek> [OpenTTD/website] michicc opened pull request #247: Add: 13.0-RC2 announcement https://github.com/OpenTTD/website/pull/247
16:09:30 <DorpsGek> [OpenTTD/website] michicc commented on pull request #247: Add: 13.0-RC2 announcement https://github.com/OpenTTD/website/pull/247#issuecomment-1407429828
16:10:07 *** WormnestAndroid has joined #openttd
16:10:51 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #10420: Backport master into release/13 https://github.com/OpenTTD/OpenTTD/pull/10420
16:14:03 <Samu> wow, rc2
16:14:46 <DorpsGek> [OpenTTD/OpenTTD] michicc opened pull request #10424: Doc: Changelog for 13.0-RC2. https://github.com/OpenTTD/OpenTTD/pull/10424
16:19:45 <DorpsGek> [OpenTTD/website] rubidium42 approved pull request #247: Add: 13.0-RC2 announcement https://github.com/OpenTTD/website/pull/247#pullrequestreview-1273968112
16:21:59 <andythenorth[d]> \o/
16:22:13 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #10424: Doc: Changelog for 13.0-RC2. https://github.com/OpenTTD/OpenTTD/pull/10424#pullrequestreview-1273968349
16:23:34 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #10423: Fix several cases where global pointer outlives stack reference https://github.com/OpenTTD/OpenTTD/pull/10423
16:25:38 <Merni> rubidium42viaGitHub: The https://release-13-rc2.openttd-website.pages.dev/ shows the wrong title
16:25:43 <Merni> (RC1 instead of RC2)
16:27:45 <andythenorth[d]> ha ha remember when grf vehicles less than 8/8 couldn't be flipped safely?
16:27:50 <andythenorth[d]> seems like an age ago
16:28:44 <DorpsGek> [OpenTTD/website] michicc dismissed a review for pull request #247: Add: 13.0-RC2 announcement https://github.com/OpenTTD/website/pull/247#pullrequestreview-1273968112
16:28:47 <DorpsGek> [OpenTTD/website] michicc updated pull request #247: Add: 13.0-RC2 announcement https://github.com/OpenTTD/website/pull/247
16:29:07 <michi_cc[d]> Merni: Thanks for the check.
16:30:33 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #10424: Doc: Changelog for 13.0-RC2. https://github.com/OpenTTD/OpenTTD/pull/10424
16:38:07 <DorpsGek> [OpenTTD/website] rubidium42 approved pull request #247: Add: 13.0-RC2 announcement https://github.com/OpenTTD/website/pull/247#pullrequestreview-1273970260
16:57:08 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
17:20:22 <andythenorth[d]> GS things
17:20:58 <andythenorth[d]> opening story pages from some game items
17:21:01 <andythenorth[d]> towns, industries
17:21:11 <andythenorth[d]> maybe vehicles, stations, objects
17:21:18 <Samu> I'm being reviewed by a bot! https://github.com/SamuXarick/OpenTTD/pull/6#pullrequestreview-1273971441
17:21:29 <andythenorth[d]> could we have an optional UI button for story page
17:21:49 <andythenorth[d]> and methods like GSIndustry.AssociateStoryPage(page_id)
17:22:15 <andythenorth[d]> alternatively, an extra text string in the item window
17:22:19 <Samu> the bot reasoning is correct, but everybody does CommandCost ret over CommandCost ret
17:22:19 <andythenorth[d]> 'open story page'
17:24:39 <Rubidium> Samu: and everyone doing that is doing something that they should not be doing. There's a long list of places where that happens where that same thing is complaining about that are all still to be fixed
17:25:03 <DorpsGek> [OpenTTD/OpenTTD] andythenorth commented on discussion #10387: [GS] Extend GS story page button approach to other entities and button types https://github.com/OpenTTD/OpenTTD/discussions/10387
17:27:16 <Rubidium> Samu: especially because it can lead to misleading things when reading through the function when reasoning what the value of `ret` is in your cases
17:30:27 <Rubidium> I'm working on those alerts for master, but... I've taken on the higher severity ones first. In my opinion you should have a really good reason to dismiss such an alert, especially for ones that are trivial to solve
17:30:34 <glx[d]> and that's why we added CodeQL
17:31:01 <Rubidium> and "it exists already in the code" is a bad reason, especially when that code has the same alerts
17:31:39 <glx[d]> there are 2 annoying large objects (didn't check if you dismissed them)
17:32:29 <glx[d]> huge arrays passed as command callback and not even used there
17:33:32 <Rubidium> you mean CargoArray. Yeah, I dismissed them as there's not that much we can do about it without completely messing things up. I tried const reference and std::unique_ptr, but couldn't get that to work
17:34:42 <glx[d]> ah yes dismissed, it's a pain with templates
17:37:17 <Rubidium> for #10423 we did let a "new" alert in, but it also marked a similar alert as fixed probably because the function prototype changed. Similarly #10414 adds an alert that we know is a false positive, but it also remove 23 alerts
17:38:34 <Samu> okay, i reopened the alert
17:38:53 <Rubidium> and we know it's a false positive because the class has been constructed in such a manner that a stack variable can't outlive it, i.e. no allocation on the heap and deallocation on the stack happens in reverse order of allocation, so the state gets restored before the passed in new value's address goes out of scope
17:39:36 <Samu> how do i work with 2 commandcosts
17:40:09 <Rubidium> too bad that solving "simple" issues like short global variable names takes so much effort if you're refactoring the code as well ;)
17:40:13 <glx[d]> use a different name
17:40:53 <Rubidium> well, the first question would be: do you need two CommandCosts at the same time?
17:40:56 <Samu> how do i merge a ret into the other, i mean
17:41:29 <Samu> i guess in this situation i need a separate command cost
17:41:32 <Samu> a ret2
17:41:55 <Samu> but if it fails, i want this one to be returned
17:42:15 <Rubidium> where do you use the "old" ret after you create the new ret?
17:43:03 <glx[d]> old one is not use
17:43:21 <glx[d]> if I follow the code properly
17:43:48 <Samu> if ret2 fails, i don't want ret1 to know just yet, until I do check some game settings
17:44:17 <Samu> depending on the settings, i want ret1 to ignore the fail result of ret2
17:45:08 <Rubidium> if you can give them different names in chat, then you can give them different names in the code as well ;)
17:45:28 <Samu> okay, ret2 it is
17:45:35 <Rubidium> although maybe more descriptive than ret1 and ret2
17:46:07 <glx[d]> but for your 2 alerts it seems you can just reuse ret without redeclating
17:46:09 <Rubidium> but... can you point out where you ignore the fail result of "ret2" in your current code?
17:47:59 <glx[d]> because if I follow all paths from https://github.com/SamuXarick/OpenTTD/pull/6/files/a14396e3d8e41fa59b5be96c135814c5f0940728#diff-ce2189a945a85c2aec8e107e2845ab769d2f107f4a22287366a972caf7d796aeR1471 it's clearly free to be reused
17:49:30 <glx[d]> even line 1488 should reuse it (I think there's an existing alert for this one)
17:50:09 <Samu> I didn't touch 1488
17:50:34 <Samu> i touched 1493 to 1507
17:50:52 <Rubidium> glx[d]: #78
17:51:08 <Rubidium> or #77
17:53:02 <Samu> https://github.com/SamuXarick/OpenTTD/blob/a14396e3d8e41fa59b5be96c135814c5f0940728/src/industry_cmd.cpp#L1493-L1507
17:54:50 * Rubidium ponders picking up more of the alerts, but there's already a bit of a backlog for reviews
17:55:44 *** gelignite has joined #openttd
17:56:14 <glx[d]> yes you didn't touch them, but as you are "introducing" new alerts similar to the already existing alerts in the function, it seems to be a good idea to fix all of them in one go
17:56:57 <glx[d]> and not only the 2 new introduced ones
18:01:02 <glx[d]> especially when all "wrong" stuff seems to always be ```
18:01:02 <glx[d]> CommandCost ret;
18:01:02 <glx[d]> ret = <some command>;
18:01:02 <glx[d]> if (ret.Failed()) return ret;
18:01:02 <glx[d]> // ret is now discarded
18:05:09 <Samu> where do i see the entire list where this warning popped up?
18:05:20 <Samu> seems to only show on edited code
18:08:25 <glx[d]> security tab on top of the page
18:09:13 <Rubidium> it might be that most do not have access to that tab/page though
18:10:49 <glx[d]> but it should be available on their fork
18:12:00 <Samu> https://github.com/SamuXarick/OpenTTD/security/code-scanning
18:12:02 *** tokai|noir has joined #openttd
18:12:02 *** ChanServ sets mode: +v tokai|noir
18:12:06 <Samu> ah, wow 488 weoe
18:12:51 <glx[d]> yeah but some are dismissed in openttd
18:13:35 <glx[d]> oh still 501 open in my fork
18:13:42 <glx[d]> I should update master
18:15:16 <Samu> https://github.com/SamuXarick/OpenTTD/security/code-scanning?query=is%3Aopen+branch%3Amaster+rule%3Acpp%2Fdeclaration-hides-variable+
18:15:20 <Samu> wow, amazing stuff
18:15:58 <glx[d]> btw the links to your security tab are only accessible by you 🙂
18:16:47 <Samu> oh, sorry
18:18:51 *** tokai has quit IRC (Ping timeout: 480 seconds)
18:44:10 <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/4a58d197ee69ed063d4bbcc3f2d44c2f08733294
18:44:11 <DorpsGek> - Update: Translations from eints (by translators)
18:46:57 <Samu> okay, i fixed some CommandCost ret's on my branch
18:47:04 <Samu> related to the pr
18:48:53 <Samu> but wowzor, 80 something occurences of "declaration hides variable"
18:49:10 <Samu> some aren't even CommandCost related
18:55:24 <Samu> i failed at rebasing again
18:55:29 <Samu> why it's master always synced
18:55:37 <Samu> with upstream/master
18:55:49 <Samu> how do i make it so it's automated
18:56:21 <michi_cc[d]> You don't. Just rebase onto upstream/master, not master.
19:03:29 <michi_cc[d]> Hmm, no TB yet 😦 I don't want to change the date on the changelog/website.
19:03:37 <michi_cc[d]> Meanwhile, we can be nice...
19:03:51 <DorpsGek> [OpenTTD/OpenTTD] michicc opened pull request #10425: [130.-RC2] Be nice to translators. https://github.com/OpenTTD/OpenTTD/pull/10425
19:10:36 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #10426: Unhide some parameters/variables hidden by other variables https://github.com/OpenTTD/OpenTTD/pull/10426
19:11:44 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #10425: [13.0-RC2] Be nice to translators. https://github.com/OpenTTD/OpenTTD/pull/10425#pullrequestreview-1273999107
19:13:48 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #10414: Codechange: use RAII to automatically restore _cur_dpi after use https://github.com/OpenTTD/OpenTTD/pull/10414#pullrequestreview-1273999396
19:16:18 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #10425: [13.0-RC2] Be nice to translators. https://github.com/OpenTTD/OpenTTD/pull/10425
19:16:21 <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #10414: Codechange: use RAII to automatically restore _cur_dpi after use https://github.com/OpenTTD/OpenTTD/pull/10414#pullrequestreview-1273999768
19:17:02 <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #10406: Codechange: add annotation to selectively force inlining in debug build https://github.com/OpenTTD/OpenTTD/pull/10406#pullrequestreview-1273999854
19:18:00 <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #9924: Fix 7e1e275: Measure AI Collect Garbage performance https://github.com/OpenTTD/OpenTTD/pull/9924#pullrequestreview-1274000084
19:18:32 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #9924: Fix 7e1e275: Measure AI Collect Garbage performance https://github.com/OpenTTD/OpenTTD/pull/9924
19:19:20 <TrueBrain> michi_cc[d]: yes yes yes ..... 😛
19:19:34 <TrueBrain> MacOS takes for ever to run, and I made a boo-boo in the run I started before dinner
19:19:37 <TrueBrain> so at least another 30 minutes 😛
19:21:23 <TrueBrain> https://github.com/OpenTTD/OpenTTD/pull/10359 not backported?
19:22:13 <TrueBrain> https://github.com/OpenTTD/OpenTTD/pull/10352 also sounds like something we would like in 13.0? (assuming the rest of the font-stuff is also in 13.0?)
19:23:53 <TrueBrain> and given it is another RC, not #10342 and #10340?
19:25:10 <TrueBrain> sorry if that was already asked and answered, haven't been keeping up 😛
19:32:50 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #10406: Codechange: add annotation to selectively force inlining in debug build https://github.com/OpenTTD/OpenTTD/pull/10406
19:33:06 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #10414: Codechange: use RAII to automatically restore _cur_dpi after use https://github.com/OpenTTD/OpenTTD/pull/10414
19:33:58 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
19:36:21 <michi_cc[d]> Well, the initial backport PR was there since yesterday. But if someone ™️ wants to mark some more PRs, I'll run the backport script again, no problem.
19:37:05 <TrueBrain> I just looked after the list of merged PRs since the last release; those 4 stood out .. the last 2 are features, so sure, feature freeze and all .. but the first two seem to be an oversight?
19:37:16 <TrueBrain> I am not involved enough in development to make any call on it, one way or the other 😛
19:37:42 <michi_cc[d]> At least for #10352, did the font command actually make it to the branch? Have to check that first.
19:38:10 <TrueBrain> I do love that the PR closed list is now sorted by "merged" on GitHub
19:38:14 <TrueBrain> that wasn't always the case 😛
19:38:59 <michi_cc[d]> Okay, it did.
19:39:46 <DorpsGek> [OpenTTD/OpenTTD] merni-ns updated pull request #10384: Change #10370: Increased max length of vehicle type names https://github.com/OpenTTD/OpenTTD/pull/10384
19:40:17 <TrueBrain> https://github.com/OpenTTD/OpenTTD/pull/10422 ready for review now
19:40:31 <TrueBrain> GOG uploads looked very fine 🙂
19:40:57 <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #10422: Change: [Actions] several improvements for the release workflow https://github.com/OpenTTD/OpenTTD/pull/10422#pullrequestreview-1274002770
19:41:11 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #10422: Change: [Actions] several improvements for the release workflow https://github.com/OpenTTD/OpenTTD/pull/10422
19:41:14 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed issue #10301: [Bug]: GitHub Actions Release workflow publishes too many files to the CDN https://github.com/OpenTTD/OpenTTD/issues/10301
19:45:10 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #10380: Hide Tile and TileExtended implementation details inside Map structure https://github.com/OpenTTD/OpenTTD/pull/10380
19:49:32 <DorpsGek> [OpenTTD/OpenTTD] michicc opened pull request #10427: Backport master into relase/13 take 2 https://github.com/OpenTTD/OpenTTD/pull/10427
19:50:07 <michi_cc[d]> Well, RC2 can have features now. Somebody else will sort out the bugs for next weekend, right? 😛
19:50:33 <Rubidium> there won't be bugs, right? ;)
19:51:11 <michi_cc[d]> So if somebody approves that (and the CI gets done), I'd tag a thing.
19:54:57 <Rubidium> not that I can say anything reasonable about the yaml and json files...
19:55:03 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #10427: Backport master into relase/13 take 2 https://github.com/OpenTTD/OpenTTD/pull/10427#pullrequestreview-1274004496
19:56:04 <michi_cc[d]> Well, that we will only know after tagging, as usual 🙂
19:56:29 <michi_cc[d]> It wouldn't be the first tag that has do be re-made.
19:57:22 <Rubidium> you can enable autorebase in the PR, so it rebases as soon as all the required things are done. And you'll effectively get a notification in chat that the required parts that need to be built are done
19:59:22 <Rubidium> hmm, can the queued checks of all branches be reordered? Maybe give some priority to the backport one for exampel #10380
20:06:57 <Rubidium> otherwise it might still take a few hours
20:07:50 <TrueBrain> you can only cancel jobs
20:08:06 <TrueBrain> you could cancel, and rerun them directly after
20:08:10 <TrueBrain> which puts them at the bottom of the queue
20:10:41 <Rubidium> okay, cancelled some that didn't (really) start yet
20:17:02 <Rubidium> michi_cc[d]: build failure for the backport
20:17:23 <Rubidium> I guess with the diagonal tree PR
20:19:01 <TrueBrain> depends on another PR I guess? 🙂
20:19:30 <Rubidium> at least #10345
20:19:42 <TrueBrain> so remove it 😛 Silly me ... adding new feature sin an RC 😛
20:23:27 <DorpsGek> [OpenTTD/OpenTTD] michicc dismissed a review for pull request #10427: Backport master into release/13 take 2 https://github.com/OpenTTD/OpenTTD/pull/10427#pullrequestreview-1274004496
20:23:27 <michi_cc[d]> Yes, all your fault 🙂
20:23:30 <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #10427: Backport master into release/13 take 2 https://github.com/OpenTTD/OpenTTD/pull/10427
20:42:06 <michi_cc[d]> Optimistic person for a pre-emptive approve required.
20:43:00 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #10427: Backport master into release/13 take 2 https://github.com/OpenTTD/OpenTTD/pull/10427#pullrequestreview-1274017025
20:43:34 <Rubidium> was already checking/doing it ;)
20:50:36 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #10427: Backport master into release/13 take 2 https://github.com/OpenTTD/OpenTTD/pull/10427
20:54:36 <michi_cc[d]> TrueBrain: Well, lets see what you cooked up 🙂
20:54:54 <DorpsGek> [OpenTTD/OpenTTD] michicc created new tag: 13.0-RC2 https://github.com/OpenTTD/OpenTTD/releases/tag/13.0-RC2
20:55:09 <TrueBrain> pam pam pammm
20:55:19 <DorpsGek> [OpenTTD/website] michicc merged pull request #247: Add: 13.0-RC2 announcement https://github.com/OpenTTD/website/pull/247
20:57:12 *** Wormnest has joined #openttd
20:59:04 *** WormnestAndroid has joined #openttd
21:00:26 <TrueBrain> we will know how it went in ~ 30 minutes 😛
21:08:24 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #10380: Hide Tile and TileExtended implementation details inside Map structure https://github.com/OpenTTD/OpenTTD/pull/10380#issuecomment-1407488518
21:08:24 <LordAro> hype
21:35:07 <michi_cc[d]> Might have actually worked 🤩
21:36:06 <TrueBrain> I am shocked, I have to admit
21:36:28 <michi_cc[d]> For the record, we have Node.js warning on the update-cdn job and some more warnings on the OSX release part.
21:38:42 <andythenorth[d]> \o/
21:42:39 <michi_cc[d]> And "set-output" warning on publish_main and publish_latest_tag (website).
21:43:11 <TrueBrain> okay, `internal` was picked up, but nothing sane was done with it, which is fine
21:43:22 <michi_cc[d]> Other than that, we are live!
21:43:49 <DorpsGek> [OpenTTD/website] michicc created new tag: 1.4.48 https://github.com/OpenTTD/website/releases/tag/1.4.48
21:44:01 <TrueBrain> nice
21:44:34 <TrueBrain> GOG branch tagging didnt work
21:44:36 <TrueBrain> which is a shame
21:44:45 <TrueBrain> so I still manually have to assign it to the Testing branch
21:45:14 <TrueBrain> there are worst things 😛
21:45:21 <TrueBrain> worst? Yes.
21:46:36 <glx[d]> michi_cc[d]: it's in an external action
21:47:10 <glx[d]> I think
21:53:18 <michi_cc[d]> Did my share of the socials.
21:55:13 <michi_cc[d]> Who can I write done for the proper release next weekend? 👼
21:56:32 <glx[d]> ha looks like I missed some bumps last time
22:01:03 <andythenorth[d]> can chatGPT write how to do the release?
22:01:10 <andythenorth[d]> I don't have an account to try
22:03:39 <DorpsGek> [OpenTTD/workflows] glx22 opened pull request #26: Fix c6a585a: [Actions] missed some bumps https://github.com/OpenTTD/workflows/pull/26
22:05:53 <TrueBrain> the result is not good andythenorth[d]
22:06:09 <TrueBrain> it really like that you can create diagonal area of trees 😛
22:06:43 <TrueBrain> And it claims OpenAI wrote the game 😛
22:07:15 <TrueBrain> it did understand what kind of game it is
22:08:18 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:08:39 <TrueBrain> `OpenAI has just released a new update for their popular transportation simulation game ...`
22:08:56 *** nielsm has quit IRC (Ping timeout: 480 seconds)
22:09:15 <TrueBrain> it really REALLY likes the diagonal trees ..
22:09:22 <andythenorth[d]> what a silly bot it is
22:09:27 <TrueBrain> `"OpenAI just dropped a hot new update for their transportation game! Players can now build diagonal tree areas with just a press of a button and customize their industries in map generation. They've also made it easier to mess around with timetable speeds and waiting times, and improved the game's compatibility with different screen resolutions. Plus, honking your vehicle's horn has never been more fun with the new hotkey feature,
22:09:27 <TrueBrain> to build your transportation empire even faster. Check it out now!"`
22:09:35 <TrueBrain> it is not terrible .. just also not good 😛
22:09:46 <andythenorth[d]> we get what we pay for
22:09:49 <TrueBrain> I like the part about the honking
22:09:51 <andythenorth[d]> or what we deserve
22:09:51 <TrueBrain> that is pretty nice
22:09:55 <andythenorth[d]> honk!
22:10:05 <andythenorth[d]> https://tenor.com/view/chaos-nickfifs-fire-goose-hook-gif-20475840
22:10:43 <andythenorth[d]> it didn't mention the goose though
22:11:09 <TrueBrain> `Go forth and conquer the transportation world!"`
22:11:56 <TrueBrain> `"Get ready to take your transportation game to the next level! The latest update brings a bunch of new features including the ability to bulk edit timetable speeds and waiting times, making it easier than ever to optimize your transportation network. Honk your horn to your heart's content with the new hotkey and expand your empire by purchasing land multiple tiles at a time. And for those who like to get creative, you can now buil
22:11:56 <TrueBrain> ability to filter cargo in the vehicle list. Go forth and conquer the transportation world!"`
22:12:14 <TrueBrain> okay, after some guiding, it is producing something that I could have written .. somewhat 😛
22:12:15 <andythenorth[d]> loves the honk
22:13:33 <TrueBrain> https://cdn.discordapp.com/attachments/1008473233844097104/1069017416627130458/image.png
22:13:33 <TrueBrain> there we go!
22:15:07 <andythenorth[d]> so sorry
22:15:13 <andythenorth[d]> we're apologising
22:17:56 <TrueBrain> Steam news published
22:18:05 <TrueBrain> tnx for the image michi_cc[d]
22:19:43 <glx[d]> ok <https://github.com/OpenTTD/website/blob/main/.github/workflows/publish.yml> uses outdated actions that have been rewritten since
22:20:07 <glx[d]> but I don't fully understand what to change
22:22:33 <glx[d]> oh I guess it's supposed to use reusable workflow from <https://github.com/OpenTTD/actions/tree/main/publish-image>
22:22:53 <glx[d]> but TrueBrain should know better
22:23:47 <TrueBrain> Yeah, never finished migrating it, as the new flow is a bit annoying .. it is fine for now :p
22:24:12 <TrueBrain> Website doesn't need to be send to AWS anymore tbh ..
22:25:29 <glx[d]> no real issue before 1st of june 🙂
22:27:43 <TallTyler> I thought we weren't mentioning honking, and leaving it for people to discover on their own?
22:28:11 <andythenorth[d]> tell chatGPT 🙂
22:28:19 <andythenorth[d]> "honk is secret"
22:28:42 <TallTyler> "With the secret new honking feature..."
22:29:44 <TrueBrain> ChatGPT at least really enjoys the feature
22:32:46 <DorpsGek> [OpenTTD/website] glx22 opened issue #248: Publish Image workflow (publish.yml) require update/rework before 1st of June 2023 https://github.com/OpenTTD/website/issues/248
22:33:01 <glx[d]> so it's noted somewhere 🙂
22:39:44 <glx[d]> and the macos warnings are still waiting for <https://github.com/Apple-Actions/import-codesign-certs/pull/41>
22:44:01 *** supermop_Home has joined #openttd
22:44:04 <supermop_Home> yo
22:44:12 <Pruple> yoyo
23:01:00 *** Samu has quit IRC (Quit: Leaving)
23:23:09 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)