IRC logs for #openttd on OFTC at 2022-08-27
01:16:50 <DorpsGek> [OpenTTD/nml] glx22 updated pull request #247: Add: Translate ternary operator into varact2 if needed
02:09:40 *** lobstarooo has joined #openttd
02:14:08 *** lobster has quit IRC (Ping timeout: 480 seconds)
02:14:11 *** lobstarooo is now known as lobster
02:46:04 <DorpsGek> [OpenTTD/team] shenlong3010 opened issue #343: [en_US] Translator access request
02:52:07 *** D-HUND has joined #openttd
02:55:35 *** debdog has quit IRC (Ping timeout: 480 seconds)
03:23:59 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
03:24:05 *** WormnestAndroid has joined #openttd
03:24:09 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
03:24:10 *** WormnestAndroid has joined #openttd
05:05:33 *** eirc has quit IRC (Ping timeout: 480 seconds)
05:14:30 *** eirc has joined #openttd
06:24:05 *** nielsm has joined #openttd
06:41:42 *** D-HUND is now known as debdog
06:42:45 *** HerzogDeXtEr has joined #openttd
06:51:30 *** gelignite has joined #openttd
07:17:14 <DorpsGek> [OpenTTD/OpenTTD] nielsmh merged pull request #9979: Fix #9940: Print debuglevel parse errors to console when changed from console
07:17:17 <DorpsGek> [OpenTTD/OpenTTD] nielsmh closed issue #9940: [Bug]: `debuglevel` with invalid argument prints error to external dialog and may execute partially
07:20:48 <DorpsGek> [OpenTTD/OpenTTD] nielsmh updated pull request #9978: Fix #9977: Use a deque rather than linked list for console buffer
07:22:10 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on pull request #9978: Fix #9977: Use a deque rather than linked list for console buffer
07:30:55 <DorpsGek> [OpenTTD/OpenTTD] krysclarke opened issue #9981: [Bug]: FindAllegro.cmake doesn't find Allegro v5.2.8
08:31:22 *** wallabra_ has joined #openttd
08:32:34 *** WormnestAndroid has quit IRC (Read error: No route to host)
08:35:51 *** wallabra has quit IRC (Ping timeout: 480 seconds)
08:35:51 *** wallabra_ is now known as wallabra
08:38:24 <andythenorth> hmm
08:38:55 <andythenorth> Might need this for my forum sig (not in OpenTTD world)
08:38:55 <andythenorth> β€œNever argue with an idiot. They will drag you down to their level and beat you with experience.”
08:39:36 <Artea> hahahaha
08:40:14 <Artea> I really missed you andy
08:40:40 *** Flygon has joined #openttd
08:41:04 <andythenorth> I didn't go away
08:41:10 <Artea> I know
08:41:16 <Artea> was me who got banned
08:41:31 <Artea> then had to disguise to ban evade
08:41:59 * LordAro raises eyebrow
08:42:00 * Artea feels a little ashame for be an OpenTTD's outlaw
08:42:19 <Artea> I sux on social skills
08:42:20 <Artea> true fact
08:45:13 *** Wolf01 has joined #openttd
08:49:38 <LordAro> why do my farmers & fishermen keep dying of starvation?
08:50:01 <andythenorth> realism?
09:47:44 *** gelignite has quit IRC (Quit: Stay safe!)
10:02:49 <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #9978: Fix #9977: Use a deque rather than linked list for console buffer
10:02:57 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #9978: Fix #9977: Use a deque rather than linked list for console buffer
10:08:15 <DorpsGek> [OpenTTD/nml] frosch123 approved pull request #247: Add: Translate ternary operator into varact2 if needed
10:08:45 <andythenorth> \o/
10:09:34 * andythenorth awaits the merge :)
10:09:38 <andythenorth>
10:29:16 <andythenorth> do (rail) station tiles know if they have a vehicle in them?
10:29:26 <andythenorth> and if it's loading/unloading?
10:33:08 *** frosch has joined #openttd
10:33:08 <frosch> they know pbs reservation
10:33:20 <frosch> there are stations which open/close doors for vehicles
10:33:47 <frosch> they do not know the difference between entering/halting/leaving/passing through
10:35:17 <andythenorth> not sure I really want to animate pouring molten steel into torpedo wagons πŸ™‚
10:35:22 <andythenorth> but eh
10:36:09 <frosch> heat flares are hard to draw πŸ™‚
10:38:43 <DorpsGek> [OpenTTD/nml] glx22 merged pull request #247: Add: Translate ternary operator into varact2 if needed
10:39:50 <DorpsGek> [OpenTTD/nml] andythenorth updated pull request #254: Change: skip realsprite palette validation step iff output is nfo AND…
10:40:15 <andythenorth> oh I forgot I PRed that πŸ˜›
10:40:29 <andythenorth> treating it as a private nmlc build currently πŸ˜›
10:40:54 <andythenorth> palette validation really should be optional though, it's trying to safeguard something where some of us know better
10:40:57 <andythenorth> and it's expensive
10:49:07 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #9981: [Bug]: FindAllegro.cmake doesn't find Allegro v5.2.8
10:51:17 <DorpsGek> [OpenTTD/team] glx22 commented on issue #343: [en_US] Translator access request
10:54:50 *** glx has joined #openttd
10:54:50 <glx> Update your black andythenorth
10:55:06 <andythenorth> will do πŸ™‚
10:55:22 *** glx is now known as Guest1339
10:55:23 *** Guest1339 is now known as glx[d]
11:23:01 <peter1138> hi
11:25:00 <peter1138> Lose a bit of weight, get told "your tummy's very flat, don't lose too much weight!"... Yeah, cos I habitually hold it in all the time.
11:42:38 <andythenorth> It’s the abs innit
11:46:47 <peter1138> Antilock braking, yes.
11:47:08 <peter1138> Hungry now so eating a massive salad.
11:48:38 <peter1138> Life goals eh
11:49:57 *** gelignite has joined #openttd
11:50:31 <andythenorth> My current life goal is doing a hand stand
11:50:42 <andythenorth> Think it can be done
11:51:33 <Artea> funny peter1138
11:51:40 <Artea> I used to do that 20 years ago
11:52:01 <Artea> and I'm not fat or anything close of that
11:52:14 <Artea> I just have a "beer belly" without drinking i
11:52:16 <Artea> it
11:52:56 <Artea> btw, if any of you is hairy, whats out
11:53:05 <Artea> it can have a bad effect on you
11:53:14 <Artea> I took off some on March or so
11:53:35 <Artea> and from night to day, I stopped rip off my nails which I was doing for 31 years
11:53:40 <andythenorth> This is going to be TMI
11:53:47 <Artea> no
11:54:11 <Artea> is a good info for someone who are unaware of situation to begin
11:54:40 <Artea> I'm trying not to be disgusting and say things directly to not make all of you get nauseas
11:55:24 <Artea> damn you andy
11:55:51 <Artea> you couldn't wait, did you ?
11:55:56 <Artea> now I going play F.E.A.R.
11:56:13 <Artea> or Uplink
11:56:18 <Artea> perhaps Darwinia!
12:00:53 <peter1138> I'm pretty unhairy fortunately. Just the stupid mop on my head.
12:10:35 * peter1138 'ruins' all the good work with a Magnum iceream.
12:10:39 <peter1138> And icecream.
12:18:59 <DorpsGek> [OpenTTD/OpenTTD] ldpl commented on pull request #9973: Add #7889: Company rating via Server Admin Port
12:24:06 <DorpsGek> [OpenTTD/nml] frosch123 commented on pull request #244: Add: support for stations
13:15:45 <andythenorth> ok brains trust
13:21:13 *** wallabra_ has joined #openttd
13:26:10 *** wallabra has quit IRC (Ping timeout: 480 seconds)
13:26:10 *** wallabra_ is now known as wallabra
13:37:12 <andythenorth> let's try to square a circle or two
13:37:35 <andythenorth> stations with cargo graphics that change to convey gameplay information
13:38:05 <andythenorth> 1) it's nice to see the cargo sprites, but they only display when the station isn't being properly served by trains
13:38:23 <andythenorth> that's kind of the circle really
13:55:23 *** TallTyler has joined #openttd
13:55:23 <TallTyler> 2) Cargo sprites tell you that the station isn't being properly served, but can only tell you one cargo that isn't being served properly. With Engineering Supplies it's often best to do under-transport to avoid losing Gung-Ho status when trains can't always load on schedule, but then you can't tell other cargos which are under-transported (at the Wharf in Steeltown, for example)
13:55:44 <TallTyler> So maybe it's not as useful a feature as it could be
13:57:19 *** JGR has joined #openttd
13:57:19 <JGR> There are plenty of players who don't follow the "properly serving" idea of always having a vehicle loading
13:58:17 <JGR> I for one certainly don't bother with that
13:59:21 <TallTyler> I think it's much more important on vanilla daylength/tick speed, because it torpedoes your station ratings pretty quickly
13:59:30 <andythenorth> so things we might want to know
13:59:41 <andythenorth> - station is working 'as expected' i.e. shipping cargo
13:59:52 <andythenorth> - station is under-served
13:59:55 <andythenorth> - station has a good / bad rating
13:59:56 <JGR> Trying to micromanage station ratings is a bit pointless really
14:00:07 <JGR> You might as well redefine 75% as 100% and call it a day
14:00:09 <andythenorth> there was a FIRS version that set them to 100% and moved on πŸ˜›
14:00:12 <TallTyler> "station ratings are a bad feature"
14:00:22 <andythenorth> I removed it from FIRS because gameplay
14:00:28 <andythenorth> but eh
14:01:03 <TallTyler> Company owner statues are objectively a bad feature πŸ™‚
14:01:11 <JGR> They're not "bad", but it's simply not necessary to obsess over maximising them
14:02:09 <JGR> You're never forced to build statues so they are easy to ignore
14:03:45 <DorpsGek> [OpenTTD/OpenTTD] nielsmh merged pull request #9978: Fix #9977: Use a deque rather than linked list for console buffer
14:03:48 <DorpsGek> [OpenTTD/OpenTTD] nielsmh closed issue #9977: [Crash]: Console command `clear` can stack overflow and crash
14:24:31 *** Tirili has joined #openttd
14:25:44 *** Tirili has quit IRC ()
14:34:31 *** ioangogo_ has joined #openttd
14:36:22 *** WormnestAndroid has joined #openttd
14:36:23 *** ioangogo has quit IRC (Ping timeout: 480 seconds)
14:36:52 *** WormnestAndroid has quit IRC (Remote host closed the connection)
14:37:35 *** WormnestAndroid has joined #openttd
14:37:38 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
14:38:32 *** WormnestAndroid has joined #openttd
14:58:56 <andythenorth> frosch: if I provide specific strings for the FIRS location disallowed cases...can we do an empirical study of failures?
15:00:50 <peter1138> That's what happens when you turn a game with a limited set of difficulties and targets into a sandbox... the features that make up those seem to become pointless.
15:00:53 <nielsm> so when are we getting an update for the window system to do two-pass constraints sizing?
15:01:15 <peter1138> When you write it?
15:03:01 <andythenorth> peter1138: breakdowns and disasters anyone? πŸ˜›
15:03:27 <andythenorth>
15:03:27 <andythenorth> I like our train set though
15:04:42 <andythenorth>
15:05:16 <peter1138> I'm gonna Netflix and chill... and by that I mean continue watching Sandman, with a fan on.
15:54:56 *** virtualrandomnumber has joined #openttd
15:55:23 *** virtualrandomnumber has quit IRC (Remote host closed the connection)
16:16:19 <Wolf01> I usually netflix and sleep
16:16:58 <andythenorth> I usually stay up too late πŸ˜›
16:17:08 <andythenorth> and draw sprites like a man obsessed
16:17:10 <andythenorth> oof
16:23:07 *** Wormnest has joined #openttd
16:59:56 *** FemboyEggoWaffle has joined #openttd
17:00:17 *** ely-the-kitsune has quit IRC (Ping timeout: 480 seconds)
17:04:17 *** sla_ro|master has joined #openttd
17:16:45 *** esselfe has quit IRC (Quit: rebooting)
17:21:19 *** esselfe has joined #openttd
17:36:38 <frosch> andythenorth: yes, we can easily record, which result occurs most time, or whether it just fails on landscaping
17:39:52 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
17:48:25 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on issue #9972: [Bug]: Unused space in frame rate window (where texture doesn't update) in German language
18:07:33 <peter1138> "texture" :D
18:18:38 <andythenorth> I'll add some strings after dinner πŸ˜›
18:38:42 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
18:53:50 <peter1138> Making that UI adjust to the correct size should be pretty simple.
18:56:15 <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master
18:56:16 <DorpsGek> - Update: Translations from eints (by translators)
18:59:14 <frosch> oh dear...
18:59:38 <frosch> andythenorth: ottd calls the tile-check for all industry tiles before it calls the location check
19:00:04 <frosch> i guess we can speed up industry construction by factor 30 by swapping the order
19:01:06 <peter1138> Why I am doing flac/mp3 encoding on the Paspberry Bi's ARM instead of the quad core Xeon? :/
19:02:07 <LordAro> Paspberry
19:04:10 <peter1138> :(
19:04:21 <peter1138> Paspberry Bi
19:04:32 <peter1138> Whatever, fingers.
19:06:38 <andythenorth> frosch: tiles done
19:06:47 <andythenorth> industry checks next
19:06:49 <LordAro> peter1138: i always seems to have trouble with it too
19:08:28 <andythenorth> hmm
19:08:42 <andythenorth> the industry location checks AND or OR a set of procedure results
19:12:57 <andythenorth> can't pick out the string
19:13:04 <andythenorth> I guess I could bitmask?
19:27:27 <nielsm> peter1138: there might be a simple way to make the framerate window adjust, but I certainly can't find it
19:27:40 <nielsm> maybe the structure is wrong
19:28:37 *** jinks has quit IRC (Quit: ZNC -
19:28:57 *** jinks has joined #openttd
19:31:23 <nielsm> actually, I may have found it
19:34:23 <glx[d]> theorically it should resize fine, unless widget containers/organisation is wrong
19:34:44 *** jfs- has joined #openttd
19:34:44 <jfs->
19:34:44 <jfs->
19:35:08 <jfs-> was missing SetFill and SetResize on a few things
19:35:22 <jfs-> not the ones I was expecting
19:35:38 <andythenorth> frosch: pushed a rudimentary set of returns for the industry location checks πŸ˜›
19:35:41 <andythenorth> need a grf?
19:36:40 <glx[d]> oh yes missing properties is often a possibility
19:41:06 <DorpsGek> [OpenTTD/OpenTTD] nielsmh opened pull request #9982: Fix #9972: Add missing fill/resize flags on Framerate window widgets
19:45:45 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
19:47:29 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #9982: Fix #9972: Add missing fill/resize flags on Framerate window widgets
19:47:32 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #9982: Fix #9972: Add missing fill/resize flags on Framerate window widgets
19:47:36 <LordAro> lol
19:47:52 <glx[d]> hehe
19:52:05 *** WormnestAndroid has joined #openttd
19:56:29 <frosch> andythenorth: shall i use steeltown?
19:58:20 <frosch> Steeltown on 512x512 hilly smooth map ```
19:58:20 <frosch> All industries: 41224
19:58:20 <frosch> water-check: 12269
19:58:20 <frosch> CB2F: 001e require_road_adjacent: 9576
19:58:20 <frosch> GFX_WATERTILE_SPECIALCHECK failed: 9544
19:58:21 <frosch> CB2F: 0011 require_slope: 3745
19:58:21 <frosch> CB28: 000a get_post_player_founding_checks_AND: 3174
19:58:23 <frosch> CB28: 000b get_post_player_founding_checks_OR: 1611
19:58:23 <frosch> CB2F: 000e require_effectively_flat: 366
19:58:25 <frosch> outside map: 336
19:58:25 <frosch> success: 313
19:58:27 <frosch> CB2F: 0012 require_sea_tile: 133
19:58:27 <frosch> house required: 82
19:58:29 <frosch> CB2F: 0000 disallow_industry_adjacent: 42
19:58:29 <frosch> not clearable: 14
19:58:31 <frosch> CB2F: 0001 disallow_slopes: 12
19:58:31 <frosch> default slope check: 7
19:59:28 <frosch> individual industry types:
20:00:28 <frosch> wharf, bulk terminal and general store are the problematic ones
20:01:41 <frosch> so i guess some "near coast" and "in town" pre-filter may be worth it
20:03:33 <frosch> i don't remember the discussion from two days ago, but i don't think these were considered the top issues πŸ™‚
20:05:13 <TrueBrain> Given the amount of chatting in here, I guess I should add pastebin support for code blocks .. lol
20:05:29 <TrueBrain> Surprised it didn't cause a kick due to flood :p
20:05:31 <frosch> yeah, i triggered some irc throttling πŸ™‚
20:06:05 <frosch> took 11 seconds on irc πŸ™‚
20:06:32 <TrueBrain> My intent was to bridge IRC to Discord, not so much the other way around :p
20:06:42 <TrueBrain> I blame andy
20:06:47 <TrueBrain> πŸ˜„
20:07:14 <frosch> andy is the most active chatter on all channels, which i did not mute
20:07:17 <dwfreed> excess flood triggers at 30 pending lines
20:07:28 <frosch> i do not dare checking the muted channels πŸ™‚
20:07:34 <glx[d]> TrueBrain: or use dorpsgek gists
20:07:58 <TrueBrain> glx[d]: That would work too
20:08:13 <TrueBrain> But yeah, more complexity / work
20:09:09 <dwfreed> also risk of hosting inappropriate content
20:09:55 <FLHerne> frosch: I guess you're the person to ask, is there any special reason the number of industry tiles is still very low?
20:10:19 <FLHerne> there seems to be space in the maparray, the specs explicitly mention wanting to make it an extended byte
20:10:49 <frosch> there are a few properties, variables, which are limited to 128 tile types
20:10:57 <frosch> because bit 7 is used for "original industrytile"
20:11:18 <frosch> note: there are two limits "per grf" and "total"
20:11:28 <frosch> maparray is about "total" and is higher
20:11:34 <FLHerne> well, I meant in terms of not making it a word, or probably an 'extended byte' in most cases
20:11:38 <frosch> properties/vars is about "per grf"
20:11:44 <andythenorth> frosch: thanks looking now
20:12:04 <FLHerne> yeah, I mean per grf
20:12:13 <FLHerne> I didn't realise the maparray was already higher
20:12:39 <FLHerne> I guess that must be remapped somewhere to avoid confusing the grf?
20:13:25 <frosch> yes, global ids and grf-local ids are different things
20:14:41 <andythenorth> so the industry checks mask the causes
20:14:58 <frosch> flherne: hmm, you may be on to something. the places i suspected do not impose a hard limit
20:15:55 <DorpsGek> [OpenTTD/OpenTTD] nielsmh opened pull request #9983: Fix #9971: Don't assert that time moves forward
20:16:15 <andythenorth> Basic Oxygen Furnace and Slag Grinding Plant both have high failure counts - both use require_max_distance_to_another_industry_type
20:16:19 <FLHerne> I ask because the concept I was thinking of for better industry layouts doesn't really work with andy's "every tile is the same one only magic" hack
20:16:47 <FLHerne> which is obviously the only reason FIRS hasn't blown the limit by orders of magnitude
20:17:04 <frosch> andythenorth: i already swapped the order of 28 and 2F for those statistics
20:18:08 <frosch> flherne: why do you need more ids?
20:18:27 <nielsm> I hope that above PR comes off as snarky as I intend it to be
20:20:05 <DorpsGek> [OpenTTD/OpenTTD] nielsmh merged pull request #9982: Fix #9972: Add missing fill/resize flags on Framerate window widgets
20:20:08 <DorpsGek> [OpenTTD/OpenTTD] nielsmh closed issue #9972: [Bug]: Unused space in frame rate window (where texture doesn't update) in German language
20:20:09 <FLHerne> frosch: well, I'm dreaming of a system of 'sublayouts' that can be allowed to fail construction, or fall back to other ones
20:20:39 <FLHerne> or randomly chosen from different options because combinatorial industries are fun
20:21:06 <nielsm> I did try implementing a way to have sub-buildings for industries a while ago, and the big blocker I hit for it was adjusting landscape automatically, as some industries want
20:21:06 <FLHerne> but that doesn't work with tiles that have to look up their appearance from their coordinates
20:21:29 <FLHerne> unless the grf code for that gets even more unreasonable
20:21:52 <nielsm> because there isn't a good way to simulate doing some terrain adjustments without actually doing them, and there isn't a way to roll back the terrain to a snapshot from before starting experiments
20:22:29 <FLHerne> and adding grf vars to make the hack keep working, instead of simply raising the limit, would be crazy unless there's a good reason not to raise the limit
20:23:02 <nielsm>
20:24:36 <nielsm> but maybe the solution would be that "industries using procedural layouts don't get to level the terrain, they have to fit into what already is"
20:24:58 <FLHerne> yeah
20:25:27 <FLHerne> I was hoping that simply having smaller units that could be placed independently and possibly selected to fit would solve the problem enough
20:25:40 <nielsm> that's more or less what that above branch does yes
20:26:02 <FLHerne> yeah, I'm looking at it
20:26:34 <nielsm> I don't _think_ those parts of the code have changed too much since 2019 so it might be possible to bring forward without too much work
20:28:25 <nielsm> ahh right, the thing it does is select the sublayouts to use, and generate a new total layout, which is then placed
20:28:43 <nielsm> so all of it is placed in one go, instead of as individual parts
20:29:39 <nielsm> so it might need some way to handle that the sublayouts can be on different height levels
20:31:15 <nielsm> maybe only use the combined layout as an intermediate step to verify that the sublayouts don't overlap with other parts of the industry, and afterwards verify each sublayout against the landscape individually, and build them individually
20:33:22 <frosch> there was the idea to make industries place objects around them on certain events
20:33:29 <nielsm> that too
20:33:39 <frosch> for fields, mineral piles, and possibly also outposts
20:33:42 <nielsm> and potentially "harvest" those objects as well, right?
20:34:51 <nielsm> but that's kind of separate from this, which is multiple buildings that are part of the "industry proper" and participate in cargo acceptance and production
20:35:26 <frosch>
20:36:04 <frosch> nielsm: ok, i was unsure whether that was the actual goal πŸ™‚
20:36:52 <andythenorth> the main upside of combinatorial layouts seem to be
20:37:00 <andythenorth> (1) benefits players who can't just do it in the compile
20:37:08 <nielsm> random thought for that industry special effect proposal: should also have a way for industries to plant trees of specific or generic types
20:37:13 <andythenorth> (3) possibly more random than the generated combined layouts I'm doing
20:37:25 <andythenorth> (3) more reliable placement
20:37:30 <frosch> nielsm: newtrees :p
20:38:10 <andythenorth> frosch: so do these results suggest we want a tile shape / slope hint?
20:40:12 <frosch> i just reverted back the callback order, i found an issue which may require some tile checks first (like map-wrap-around)
20:40:24 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #9983: Fix #9971: Don't assert that time moves forward
20:40:34 <frosch> the water and road-adjacent checks are still the most
20:40:46 <frosch> half of the failures are water checks
20:41:12 <frosch> so a "near coast" pre-check may be worth it, as well as a "near town" check
20:41:23 <frosch> though technically there are already "near town" checks
20:41:58 <andythenorth> why don't I use that?
20:42:02 <andythenorth> maybe it checks for town sign
20:42:04 <andythenorth> not houses
20:42:11 <andythenorth> think it fails for larger towns
20:42:38 <frosch> the general store uses both
20:43:16 <frosch> the road check fails 7285 times, the house check only 88 times, even if i do the house check first
20:43:28 <frosch> hmm, or do i?
20:44:13 <frosch> oh, i don't, let's try that again
20:48:42 <frosch> yeah, that's better. now the general store fails 4k times on house check, and only 1 time on cb 2f
20:50:01 <frosch> so shuffling the check order seems to be worth it here
20:50:18 <frosch> it does not change the success rate, but does less callbacks, so probably faster
20:50:44 <glx[d]> testing predefined constraints before the callback should be faster yes
20:51:04 <glx[d]> as callbacks can be very complicated
20:51:38 <frosch> yeah, currently it does the tile-based callback even before the general industry callback πŸ™‚
20:52:42 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
20:53:10 *** WormnestAndroid has joined #openttd
20:55:38 <frosch> nielsm: <- last paragraph: clocks between cores may desync
20:59:02 *** birdjj has quit IRC (Quit: Ping timeout (120 seconds))
20:59:21 *** birdjj has joined #openttd
20:59:39 <DorpsGek> [OpenTTD/OpenTTD] nielsmh merged pull request #9983: Fix #9971: Don't assert that time moves forward
20:59:42 <DorpsGek> [OpenTTD/OpenTTD] nielsmh closed issue #9971: [Crash]: Assertion failed at line 968 of framerate_gui.cpp when pausing from brief hyper-fast-forward (1M+ TPS)
21:01:10 <andythenorth> frosch: for industries that have minimum-distance-to-another-industry check
21:01:25 <andythenorth> they seem to fail relatively a lot more than others
21:01:35 <andythenorth> or I'm cherrypicking the evidence I want to find πŸ˜›
21:03:12 <frosch> TrueBrain: it's annoying that you cannot tab-complete people on irc, but i guess that is unsolvable 😦
21:03:36 <TrueBrain> yeah, sadly it seems there is no way to fake members on Discord
21:03:48 <TrueBrain> but you can reply to people, it will handle that correctly
21:03:50 <TrueBrain> so that is something
21:03:58 <frosch> andythenorth: what is get_post_player_founding_checks_OR ?
21:06:25 <andythenorth> it ORs the 0 and 1 results from a set of procedures
21:08:29 <frosch> well, it's the most often newgrf failure reason πŸ™‚
21:10:03 <andythenorth> I could explicitly check a set of bits for failures
21:10:16 <andythenorth> then provide the reason
21:10:29 <andythenorth> but based on 'turn it off and on again'
21:10:43 <andythenorth> checking distance to an existing industry is expensive and failure prone
21:11:23 <andythenorth> JGR suggested using an industry type as a predefined constraint
21:15:31 <frosch> which result does the industry-type check trigger?
21:17:37 <frosch> the most often newgrf error condition is get_post_player_founding_checks_AND for the bulk terminal. 1311 failures compared to 7 successes
21:17:50 <frosch> that is still a low failure rate compared to the 2k attempts per success
21:18:10 <frosch> @calc 1311/7
21:18:10 <DorpsGek> frosch: 187.28571428571428
21:18:19 <frosch> it could fail 10 times more often πŸ™‚
21:18:31 <andythenorth> what's the failure rate on Basic Oxygen Furnace?
21:19:03 <andythenorth> might still be well within acceptable bounds
21:19:37 <andythenorth> but it's roughly factor 10 of other similar industries without the industry-type distance check
21:19:44 <frosch> <- that's the result with the condition-checks reshuffled to do cheap tests first
21:20:09 <andythenorth> doesn't seem particularly high
21:20:12 <frosch> 50 attemps per success
21:20:24 <andythenorth> that's probably not interesting
21:20:53 <frosch> the map has low sea and smooth hills, maybe too easy to place πŸ™‚
21:20:54 <DorpsGek> [OpenTTD/OpenTTD] ldpl commented on pull request #9983: Fix #9971: Don't assert that time moves forward
21:23:03 <frosch> yeah, it's a lot worse for high sea level
21:23:09 <frosch> i need to swap more checks
21:23:18 <frosch> do the tile-based water checks before cb28
21:24:08 <frosch> looks like get_post_player_founding_checks_OR triggers a lot on open sea πŸ™‚
21:24:32 <frosch> it never really gets to the actual water check, cb28 fails first
21:38:04 <frosch> ok, now with high sea level: the ports are now the most expensive ones.
21:54:31 *** _aD has joined #openttd
22:09:07 *** sla_ro|master has quit IRC ()
22:09:30 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
22:31:30 *** nielsm has quit IRC (Ping timeout: 480 seconds)
23:43:33 *** HerzogDeXtEr has joined #openttd