IRC logs for #openttd on OFTC at 2021-10-16
            
00:40:21 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
00:43:12 *** Etua has quit IRC (Quit: Etua)
01:13:34 *** snail_UES_ has joined #openttd
02:00:25 *** WormnestAndroid has joined #openttd
02:03:29 *** glx has quit IRC ()
02:09:18 *** innocenat__ has joined #openttd
02:10:02 *** mindlesstux has quit IRC (Ping timeout: 480 seconds)
02:10:28 *** twpol is now known as Guest3066
02:10:38 *** twpol has joined #openttd
02:10:42 *** Guest3066 has quit IRC (Ping timeout: 480 seconds)
02:10:53 *** innocenat_ has quit IRC (Ping timeout: 480 seconds)
02:10:53 *** innocenat__ is now known as innocenat_
02:11:32 *** colde has quit IRC (Ping timeout: 480 seconds)
02:13:39 *** colde has joined #openttd
02:20:21 *** snail_UES_ has quit IRC (Quit: snail_UES_)
02:36:35 *** mindlesstux has joined #openttd
02:50:14 *** D-HUND has joined #openttd
02:53:35 *** debdog has quit IRC (Ping timeout: 480 seconds)
03:00:13 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
03:00:25 *** WormnestAndroid has joined #openttd
03:04:37 *** Tirili has quit IRC (Quit: Leaving)
03:41:55 *** Flygon has joined #openttd
04:42:38 *** felix_ has quit IRC (Ping timeout: 480 seconds)
04:43:14 *** felix has joined #openttd
04:46:24 *** felix_ has joined #openttd
04:53:35 *** felix has quit IRC (Ping timeout: 480 seconds)
05:01:21 *** felix has joined #openttd
05:08:18 *** felix_ has quit IRC (Ping timeout: 480 seconds)
05:13:54 *** felix_ has joined #openttd
05:19:40 *** felix has quit IRC (Ping timeout: 480 seconds)
05:28:47 *** tokai|noir has joined #openttd
05:28:47 *** ChanServ sets mode: +v tokai|noir
05:35:36 *** tokai has quit IRC (Ping timeout: 480 seconds)
05:42:25 *** felix has joined #openttd
05:49:45 *** felix_ has quit IRC (Ping timeout: 480 seconds)
06:20:16 *** andythenorth has joined #openttd
06:42:50 *** sla_ro|master has joined #openttd
07:08:23 *** roadt_ has quit IRC (Ping timeout: 480 seconds)
07:13:45 *** tokai has joined #openttd
07:13:45 *** ChanServ sets mode: +v tokai
07:17:52 *** roadt_ has joined #openttd
07:20:30 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
07:49:25 *** Gustavo6046_ has joined #openttd
07:49:29 *** Gustavo6046_ has quit IRC ()
07:52:10 *** Gustavo6046_ has joined #openttd
07:53:09 *** Gustavo6046 has quit IRC (Read error: Connection reset by peer)
07:53:10 *** Gustavo6046_ is now known as Gustavo6046
08:06:04 *** tokai|noir has joined #openttd
08:06:04 *** ChanServ sets mode: +v tokai|noir
08:09:06 *** Wolf01 has joined #openttd
08:13:00 *** tokai has quit IRC (Ping timeout: 480 seconds)
08:35:55 *** tokai has joined #openttd
08:35:55 *** ChanServ sets mode: +v tokai
08:42:50 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
09:09:53 *** Samu has joined #openttd
09:11:14 <andythenorth> yo
09:42:24 *** HerzogDeXtEr has joined #openttd
09:43:00 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #9611: Backport master into release/12 https://git.io/JK8or
09:52:18 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9603: Doc: Prepare for 12.0 release & title game https://git.io/J2bDo
09:54:28 <DorpsGek> [OpenTTD/website] TrueBrain updated pull request #226: Add: 12.0 announcement https://git.io/J2NEm
09:55:44 <TrueBrain> that should prepare tomorrow
10:01:55 <andythenorth> :)
10:05:30 <DorpsGek> [OpenTTD/website] TrueBrain updated pull request #226: Add: 12.0 announcement https://git.io/J2NEm
10:05:43 <TrueBrain> I like Cloudflare Pages .. we can now preview these posts before they are merged :)
11:31:41 *** tokai|noir has joined #openttd
11:31:41 *** ChanServ sets mode: +v tokai|noir
11:38:41 *** tokai has quit IRC (Ping timeout: 480 seconds)
12:10:25 *** frosch123 has joined #openttd
12:18:01 *** virtualrandomnumber has joined #openttd
12:18:19 *** virtualrandomnumber has quit IRC ()
12:32:46 *** glx has joined #openttd
12:32:46 *** ChanServ sets mode: +v glx
12:46:22 *** Etua has joined #openttd
12:46:24 *** Etua has quit IRC ()
12:59:14 *** jottyfan has joined #openttd
13:05:36 <DorpsGek> [OpenTTD/py-protocol] TrueBrain opened pull request #20: Add: application performance monitoring via Honeycomb https://git.io/JK4E5
13:06:38 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain opened pull request #71: Add: application performance monitoring via Honeycomb https://git.io/JK4ui
13:08:02 <DorpsGek> [OpenTTD/py-protocol] TrueBrain updated pull request #20: Add: application performance monitoring via Honeycomb https://git.io/JK4E5
13:10:11 <TrueBrain> lets see if this helps getting a bit of insight what is actually going on :)
13:10:24 <DorpsGek> [OpenTTD/py-protocol] TrueBrain merged pull request #20: Add: application performance monitoring via Honeycomb https://git.io/JK4E5
13:10:34 <LordAro> is something happening that requires it?
13:10:38 <LordAro> or just out of interest?
13:10:50 <LordAro> also hi
13:10:56 <DorpsGek> [OpenTTD/py-protocol] TrueBrain created new tag: 1.4.0 https://git.io/JK4aC
13:11:00 <TrueBrain> hi :)
13:11:06 <TrueBrain> and no, nothing happening that requires it
13:11:14 <TrueBrain> but it is also kinda a blackbox in how connection are being created
13:11:22 <TrueBrain> so I hope this gives a bit of insight if everything is working as expected
13:11:39 <TrueBrain> so yeah, mostly out of interest
13:12:07 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain updated pull request #71: Add: application performance monitoring via Honeycomb https://git.io/JK4ui
13:12:51 <LordAro> will need to add beeline to requirements, no?
13:12:58 <TrueBrain> yes, tnx!
13:13:04 <LordAro> ^^
13:13:11 <LordAro> what would you do without me
13:13:11 <glx> would be nice if somebody would push opengfx 7.2 on bananas
13:13:29 <TrueBrain> LordAro: :D
13:13:37 <TrueBrain> glx: who has access? LordAro ? andythenorth ?
13:13:49 <glx> oh and it's 7.1
13:13:51 <LordAro> i feel like i do
13:14:04 <andythenorth> I probably do, but I'm about to go out :)
13:14:14 <LordAro> let's have a look
13:14:26 <glx> this time it should not be rejected I hope
13:14:51 <LordAro> also MSX (apparently) needs another release
13:15:00 *** jottyfan has quit IRC (Quit: jottyfan)
13:15:02 <LordAro> according to everyone's favourite wuzzy
13:15:51 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain updated pull request #71: Add: application performance monitoring via Honeycomb https://git.io/JK4ui
13:16:07 <LordAro> "opengfx-7.1.tar (5210 kB)" "Could not recognise this file; possibly the extension is wrong?"
13:16:14 <glx> yeah many translation changes since last release
13:16:26 <LordAro> do i need to unpack the zip?
13:16:29 <TrueBrain> yes
13:16:33 <LordAro> boring
13:16:37 <TrueBrain> yes
13:17:20 <TrueBrain> I hope my algorithm to rate limit traces is working as expected ... :D
13:17:26 <TrueBrain> @calc 100 * 10 * 24 * 30
13:17:26 <DorpsGek> TrueBrain: 720000
13:17:32 <LordAro> are there any version requirements of ogfx?
13:17:43 <TrueBrain> if everything goes well, it is just 7% of our allowed budget .. :D
13:18:05 <TrueBrain> LordAro: does any other version have a requirement set?
13:18:12 <TrueBrain> as I think it should be fine, but I am never sure
13:18:14 <glx> old openttd should understand newer versions
13:18:26 <LordAro> not afaik
13:18:35 <glx> will just drop extra sprites
13:18:37 <glx> I think
13:19:20 <LordAro> done
13:19:22 <frosch123> all nml grfs are ottd >= 1.2
13:20:52 <frosch123> but that probably applies to most stuff on bananas :p so ottd 0.7 users are used to stuff not working :p
13:21:43 <frosch123> did i mention that someone sent a ottd 0.7.5 screenshot for the website two weeks ago?
13:22:08 <TrueBrain> is he making a Go-port of 0.7? :D
13:22:20 <LordAro> lol
13:22:33 <LordAro> how is that java 'port' going?
13:22:37 *** jottyfan has joined #openttd
13:22:55 <glx> btw updating opengfx was more important than a new openmsx release ;)
13:23:19 <glx> people get a message with the outdated opengfx in newer openttd
13:25:56 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #71: Add: application performance monitoring via Honeycomb https://git.io/JK4ui
13:26:03 <TrueBrain> let's test this on staging :D
13:35:39 <TrueBrain> either way, any chance for a review on https://github.com/OpenTTD/OpenTTD/pull/9611 ? :)
13:44:10 <TrueBrain> okay, so honeycomb was working locally .. but on staging it seems to not send any events .. oops?
13:49:24 <andythenorth> key?
13:49:26 <andythenorth> dunno :)
13:49:27 <andythenorth> GTG
13:49:28 *** andythenorth has quit IRC (Quit: andythenorth)
14:02:33 <TrueBrain> lol, string vs int, yeah .. okay .. lets fix that :)
14:07:20 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain opened pull request #72: Fix: several application performance monitoring related fixes https://git.io/JKBck
14:08:21 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain updated pull request #72: Fix: several application performance monitoring related fixes https://git.io/JKBck
14:09:15 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #72: Fix: several application performance monitoring related fixes https://git.io/JKBck
14:13:15 <TrueBrain> yippie, traces :)
14:14:02 <TrueBrain> it is not perfect yet, and it needs work, but it is good enough for now :)
14:16:05 *** jottyfan has quit IRC (Quit: jottyfan)
14:16:15 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain created new tag: 1.5.0 https://git.io/JKBRq
14:20:22 <LordAro> TrueBrain: is there a way we can view these metrics?
14:20:41 <TrueBrain> if you would have an @openttd.org email address, yes :P
14:20:48 <LordAro> meh
14:20:53 <LordAro> i'll settle for screenshots :p
14:20:56 <TrueBrain> sorry :(
14:21:41 <TrueBrain> will take a few days to get decent profiles out of this :)
14:22:08 <TrueBrain> (it only samples 1 out of 10 traces, and only up to a max of 100 traces an hour)
14:22:45 <TrueBrain> there are around 30 unique traces to be created, of which some are a lot more rare than others .. so yeah, will take some time to give a decent overview :)
14:27:02 <TrueBrain> LordAro: https://cdn.discordapp.com/attachments/273533192601075712/898940069459656754/unknown.png <- for you! :)
14:27:23 <LordAro> !
14:27:37 <LordAro> intriguing
14:28:07 <TrueBrain> lol, it is sampling the redis communication a lot .. that is not the most interesting data :P
14:28:21 <TrueBrain> (as in, coordinator <-> coordinator traffic)
14:34:53 <DorpsGek> [OpenTTD/OpenSFX] LordAro opened pull request #44: Doc: Changelog for 1.0.2 release https://git.io/JKBiA
14:34:58 <DorpsGek> [OpenTTD/OpenMSX] LordAro opened pull request #25: Doc: Changelog for 0.4.1 release https://git.io/JKBij
14:45:41 <DorpsGek> [OpenTTD/OpenTTD] J0anJosep opened pull request #9612: Add: Draw rotor in cursor when dragging helicopters. https://git.io/JKBHo
14:46:13 *** OsteHovel has joined #openttd
14:46:15 *** OsteHovel has quit IRC ()
14:46:37 *** OsteHovel has joined #openttd
14:56:03 <DorpsGek> [OpenTTD/OpenSFX] TrueBrain approved pull request #44: Doc: Changelog for 1.0.2 release https://git.io/JKBxc
14:56:20 <DorpsGek> [OpenTTD/OpenMSX] TrueBrain approved pull request #25: Doc: Changelog for 0.4.1 release https://git.io/JKBxV
14:59:32 <DorpsGek> [OpenTTD/OpenMSX] LordAro merged pull request #25: Doc: Changelog for 0.4.1 release https://git.io/JKBij
14:59:37 <DorpsGek> [OpenTTD/OpenSFX] LordAro merged pull request #44: Doc: Changelog for 1.0.2 release https://git.io/JKBiA
14:59:40 <DorpsGek> [OpenTTD/OpenSFX] LordAro closed issue #43: Make a new release with new/updated translations https://git.io/JgtIQ
14:59:54 <LordAro> nothing needs doing except tagging, right?
14:59:59 <LordAro> nothing else*
15:01:17 <LordAro> https://pasteboard.co/3azgewpIGyfx.png oh that's fancy ('auto-generate release notes')
15:01:54 <DorpsGek> [OpenTTD/OpenSFX] LordAro created new tag: 1.0.2 https://git.io/JKRv0
15:10:05 <DorpsGek> [OpenTTD/OpenMSX] LordAro opened pull request #26: Codechange: [DorpsGek] Also announce tags https://git.io/JKRIW
15:17:04 *** Wormnest has joined #openttd
15:20:36 <DorpsGek> [OpenTTD/OpenMSX] TrueBrain approved pull request #26: Codechange: [DorpsGek] Also announce tags https://git.io/JKRGg
15:23:53 <DorpsGek> [OpenTTD/OpenMSX] LordAro merged pull request #26: Codechange: [DorpsGek] Also announce tags https://git.io/JKRIW
15:27:26 <LordAro> "There is already an entry with the same md5sum-partial for this package; this most likely means you are uploading the exact same content."
15:27:29 <LordAro> hmm.
15:28:32 <LordAro> changelog appears to be missing 0.4.2 data too
15:28:46 <LordAro> which is strange
15:30:15 <LordAro> I think maybe it's cached an incomplete update that i backed out of?
15:30:17 <LordAro> not really sure
15:30:38 <LordAro> oh hang on
15:30:41 <LordAro> i have become very confused
15:30:51 <LordAro> i have tagged 0.4.2, but it should be 0.4.1
15:33:07 <LordAro> TrueBrain: i have deleted the msx tag, can you remove from S3? (and the website?)
15:36:32 <LordAro> same md5sum-partial issue with sfx...
15:36:34 <LordAro> very strange.
16:02:56 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
16:07:52 <TrueBrain> I am home in a few hours and will see what you are trying to do :)
16:08:23 <TrueBrain> Removing from S3 is very difficult.. similar I never removed OpenGFX 7.0 :)
16:35:33 <glx> LordAro: if it checks only the actual data and not .obs that's to be expected
16:35:57 <LordAro> mm
16:36:17 <glx> only translation changes since last release
17:22:25 <TrueBrain> Languages not part of checksum .. not surprising :D
17:24:10 <TrueBrain> btw, next time I suggest we call it OpenMSX 4.1 and OpenSFX 1.1 or something :)
17:25:00 <LordAro> i couldn't be bothered working out if i needed to actually change anything in the build system for that
17:25:11 <TrueBrain> fair
17:25:15 <TrueBrain> OpenGFX paved the way, I would think
17:25:20 <LordAro> mm
17:25:31 <TrueBrain> anyway, seems you need to make a change to something "real" .. bit weird
17:25:45 <TrueBrain> guess fixing that will take a shitload of effort :D
17:27:28 <TrueBrain> I have no suggestions what you could change to generate another md5sum, honestly
17:28:16 <TrueBrain> I can revoke the uploads from S3 btw, but it takes me a lot of effort .. if it is easier to just release a new version, I prefer that :D
17:28:32 <TrueBrain> (removing the upload is easy, but changing the "latest" to an older version is manual labor)
17:28:40 <LordAro> mm
17:28:57 <LordAro> i suppose i could 'rerelease' with 0.4.3 or something
17:29:18 <TrueBrain> we did that for OpenGFX :P
17:29:25 <TrueBrain> but you need another md5 ..
17:29:31 <TrueBrain> as otherwise you cannot upload it to BaNaNaS :P
17:29:34 <LordAro> mm
17:29:36 <TrueBrain> and I have no idea how to make that happen
17:29:43 <LordAro> can we not fix bananas?
17:29:49 <TrueBrain> it isn't broken
17:29:59 <LordAro> seems like it's broken
17:30:02 <TrueBrain> you would first need to make changes to the OpenTTD client, I guess
17:30:25 <LordAro> oh i see, it's broken at that sort of level
17:30:37 <TrueBrain> BaNaNaS just mimic OpenTTD's md5 calculation :)
17:31:07 <LordAro> does midi have some sort of metadata field we can increment?
17:31:10 <TrueBrain> I guess it is "by design" .. as in: "why would we ever want to release a new version with only translation changes" kinda thought :P
17:31:17 <LordAro> mm
17:31:29 <TrueBrain> (not agreeing with that statement btw)
17:33:40 <TrueBrain> maybe frosch123 has ideas :)
17:34:55 <frosch123> in ogfx it is easy, the version number is inside the extra grf
17:35:09 <frosch123> for msx or sfx, i think we had that issue before...
17:36:43 <frosch123> hmm, or some other bananas music set
17:37:47 <TrueBrain> https://cdn.discordapp.com/attachments/273533192601075712/898987988686626936/unknown.png <- when someone doesn't accept the TURN connection, I guess. I need a bit more detail here to actual see what is happening :) MORE TRACES! :D
17:38:32 <frosch123> https://github.com/OpenTTD/OpenSFX/commit/7784f4945825db6138cb4d284c79b79babdc9a13
17:38:41 <frosch123> rb found some hack for opensfx :)
17:39:37 <TrueBrain> guess that got removed? :)
17:40:06 <TrueBrain> https://github.com/OpenTTD/OpenSFX/commit/3ea2863c7504d8ee6e6c84b04ddbe1e5e594f863
17:40:07 <TrueBrain> lol
17:40:35 <TrueBrain> so restoring that hack would at least allow you to rerelease OpenSFX and put it on BaNaNaS :)
17:40:44 <TrueBrain> frosch123: now do OpenMSX! :)
17:41:10 <LordAro> the .psfo had already been renamed to .sfo by that point, so presumably it was broken already?
17:41:10 <glx> yeah somebody changed a lot of things in sfx ;)
17:42:20 <glx> lol rb commit in 2010 followed by the rename in 2013
17:42:56 <LordAro> the dangers of not commenting your code properly
17:43:30 <TrueBrain> well, do better this time :D :)
17:44:24 <glx> main issue in sfx or msx is the generic openttdcoop makefile, with all nml/grf related stuff and it's hard to spot specific sfx or msx stuff
17:44:34 <LordAro> yeah
17:44:48 <LordAro> i'd definitely like to strip all that out
17:44:58 <TrueBrain> nobody is stopping you :D
17:45:38 <glx> well specific stuff should be in Makefile.in it seems
17:48:06 <glx> maybe they should have done a kind of modular makefile, like -include Makefile.version, -include Makefile.grf, ...
17:48:45 <TrueBrain> or, don't over engineer these repos? :D
17:49:19 <glx> one implemented a makefile, other copied it ;)
17:50:00 <frosch123> my best guess for opensfx: shuffle the order of the songs in themes.list
17:50:13 <frosch123> keep the title track frist, the rest does not matter
17:50:15 <TrueBrain> s/opensfx/openmsx/ ?
17:50:22 <frosch123> and there are a log of permutations, more than versions :p
17:50:28 <frosch123> yes, openmsx :)
17:51:14 <frosch123> @calc 10! * 10! * 10!
17:51:14 <DorpsGek> frosch123: Error: invalid syntax (<unknown>, line 1)
17:51:38 <TrueBrain> @calc (10 * 9 * 8 * 7 * 6 * 5 * 4 * 3 * 2) ** 3
17:51:38 <DorpsGek> TrueBrain: 47784725839872000000
17:51:53 <frosch123> enough?
17:51:54 <TrueBrain> fixed it :P
17:52:08 <TrueBrain> was it just me, or did DorpsGek need some time to answer that? :P
17:52:25 <glx> for now, https://github.com/OpenTTD/OpenMSX/pull/24 could be enough ;)
17:52:25 <frosch123> i did not look
17:52:31 <frosch123> @calc 1+1
17:52:31 <DorpsGek> frosch123: 2
17:52:35 <frosch123> pretty instant for me
17:52:44 <TrueBrain> frosch123: I meant my calculation :)
17:52:51 <frosch123> @calc (10 * 9 * 8 * 7 * 6 * 5 * 4 * 3 * 2) ** 3
17:52:51 <DorpsGek> frosch123: 47784725839872000000
17:52:57 <frosch123> no difference
17:53:00 <TrueBrain> it is warmed up now :P
17:54:07 <glx> both are in the same second here
17:54:17 <TrueBrain> I blame Matrix, no worries
17:54:26 <TrueBrain> currently the bug in Matrix is that it sometimes says lines twice
17:54:38 <TrueBrain> the deduplication over the different nodes is not always working as expected :P
17:54:41 <TrueBrain> which is hilarious
17:55:24 <glx> better get message twice than missing one I guess
17:56:57 <TrueBrain> true
17:57:02 <glx> ok approved MSX#24 workflows (knowing they will fail)
18:26:13 <TrueBrain> but in the meantime .. https://github.com/OpenTTD/OpenTTD/pull/9611 anyone? Pretty please?
18:26:32 <TrueBrain> it is like really simple, and requires no braincells :P
18:33:25 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #9611: Backport master into release/12 https://git.io/JK09R
18:33:40 <TrueBrain> cheers
18:33:54 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #9611: Backport master into release/12 https://git.io/JK8or
18:35:50 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9603: Doc: Prepare for 12.0 release & title game https://git.io/J2bDo
18:35:54 <TrueBrain> that should fix preview .. I hope :)
18:37:40 <LordAro> i can't understand how bundle_src actually does any copying of files
18:39:40 <LordAro> oh wait, yes i can
18:39:43 <LordAro> that's hilarious
18:40:10 <TrueBrain> bah, Preview still fails .. guess I actually need to check why and fix it? :P
18:40:13 <LordAro> bundle_src uses git to create the archive, then unpacks it
18:40:21 <TrueBrain> sounds useful :P
18:47:43 *** OsteHovel has quit IRC (Read error: Connection reset by peer)
18:56:08 <TrueBrain> lol .. 9603 shows warnings in Emscripten
18:56:11 <TrueBrain> but ... how? :P
18:56:15 <TrueBrain> owh, assert ...
18:56:18 <TrueBrain> joy
18:56:59 <TrueBrain> I wonder why only Emscripten complains about this
18:57:11 <TrueBrain> newer GCC? It is a "set but not used" error
18:57:26 <TrueBrain> of an unused function
18:57:27 <TrueBrain> lol
18:58:14 <TrueBrain> but why didn't it spot it before ... that is just odd
18:58:29 *** gelignite has joined #openttd
18:59:51 <TrueBrain> owh, yeah, ofc, I just said that already .. asserts .. euhm, yeah, what-ever, lets fix it
19:02:09 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9603: Doc: Prepare for 12.0 release & title game https://git.io/J2bDo
19:02:44 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #9613: Codechange: "set but not used" warning when disabling assert() https://git.io/JK07E
19:09:07 <glx> don't we use WITH_ASSERT instead of NDEBUG for this stuff ?
19:15:38 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
19:16:43 <glx> oh I see why you used NDEBUG, it's the only file already using that :)
19:19:57 *** WormnestAndroid has joined #openttd
19:32:25 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #9613: Codechange: "set but not used" warning when disabling assert() https://git.io/JK0dN
19:33:23 <TrueBrain> why am I not surprised about any of that :P
19:34:13 <TrueBrain> "The sanity check is actually disabled for any release build even with asserts, but maybe it should be enabled in this case." <- that sentence fails my parser
19:34:19 <TrueBrain> no clue what you are trying to say :)
19:35:34 <glx> I mean sanity check is only working with debug builds, so almost useless, it's disabled in nightlies and betas
19:37:44 <TrueBrain> tempted to change the other NDEBUG in our code too, about Squirrel stack size
19:37:49 <TrueBrain> we kinda want to know these things during beta/RC
19:38:10 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9613: Codechange: "set but not used" warning when disabling assert() https://git.io/JK07E
19:38:35 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9603: Doc: Prepare for 12.0 release & title game https://git.io/J2bDo
19:39:35 <glx> yeah I was just checking other NDEBUG, and I agree with you on the Squirrel one
19:40:00 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9613: Codechange: "set but not used" warning when disabling assert() https://git.io/JK07E
19:40:12 <glx> last one is in fmt, but we don't need to touch that
19:40:17 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9603: Doc: Prepare for 12.0 release & title game https://git.io/J2bDo
19:44:17 <TrueBrain> not going to do the Squirrel one in this PR btw
19:44:26 <TrueBrain> a day before release .. ;)
19:44:46 <glx> yeah can wait
19:45:32 <glx> "This way getting a false positive isn't that bad (releases work fine) and if there is something fishy it can be caught in RCs/nightlies." <-- that's the funny part ;)
19:46:47 <glx> catching something not reported
19:48:31 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #9613: Codechange: "set but not used" warning when disabling assert() https://git.io/JK0bU
19:49:36 *** andythenorth has joined #openttd
20:06:12 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #9613: Codechange: "set but not used" warning when disabling assert() https://git.io/JK07E
20:33:51 *** frosch123 has quit IRC (Quit: be yourself, except: if you have the opportunity to be a unicorn, then be a unicorn)
20:34:05 *** jottyfan has joined #openttd
20:53:53 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
21:10:40 *** jottyfan has quit IRC (Quit: jottyfan)
21:27:41 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
21:41:31 *** Samu has quit IRC (Ping timeout: 480 seconds)
21:48:52 *** andythenorth has quit IRC (Quit: andythenorth)
22:11:24 *** Beer has joined #openttd
22:17:46 *** gelignite has quit IRC (Quit: Stay safe!)
22:26:10 *** Beer has quit IRC (Quit: Leaving)
22:29:44 *** WormnestAndroid has joined #openttd
22:29:51 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
23:06:27 *** sla_ro|master has quit IRC ()
23:06:48 *** DooM is now known as ZDaemon