IRC logs for #openttd on OFTC at 2021-09-05
⏴ go to previous day
00:53:14 *** ChanServ sets mode: +v tokai
01:00:01 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
01:22:18 *** Gustavo6046 has quit IRC ()
01:22:55 *** Gustavo6046 has joined #openttd
01:25:57 *** Gustavo6046 has quit IRC ()
01:34:15 *** Gustavo6046 has joined #openttd
02:04:27 <DorpsGek> [OpenTTD/OpenTTD] EmperorJake commented on pull request #9532: Change: Return 'New company/Spectate' option to company toolbar menu https://git.io/JuIWP
02:25:31 *** tokai|noir has joined #openttd
02:25:31 *** ChanServ sets mode: +v tokai|noir
02:30:19 *** Gustavo6046 has quit IRC ()
02:31:45 *** D-HUND has quit IRC (Ping timeout: 480 seconds)
02:32:29 *** tokai has quit IRC (Ping timeout: 480 seconds)
02:36:36 *** Gustavo6046 has joined #openttd
03:00:46 *** _aD has quit IRC (Quit: leaving)
03:20:38 *** Gustavo6046 has quit IRC (Ping timeout: 480 seconds)
05:22:41 *** ChanServ sets mode: +v tokai
05:29:15 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
06:25:43 *** roadt_ has quit IRC (Ping timeout: 480 seconds)
06:39:18 *** andythenorth has joined #openttd
07:06:01 *** Progman has joined #openttd
07:07:40 *** tokai|noir has joined #openttd
07:07:40 *** ChanServ sets mode: +v tokai|noir
07:14:34 *** tokai has quit IRC (Ping timeout: 480 seconds)
07:49:48 <nielsm> <_dp_> nielsm, title screen exists for the main menu, not musing upon the title game :p <-- let me just comment on this, because I think having a good title game can actually work really well as a teaching tool: ship with a title game that shows solid design, and new players can learn from watching it run
07:50:56 <TrueBrain> also the feedback we received about title games. People learning new things from it.
07:51:20 <TrueBrain> you are such a madman :D (a compliment, to be clear)
07:52:38 <nielsm> I'm thinking about making a setting that makes the game load the last save as title game instead of opntitle.dat when you go back to the main menu
07:53:04 <nielsm> mainly as a tool for title game makers (it'd only be exposed via console/config file), but some players might also have fun with it
07:53:39 <TrueBrain> lol: can you make the GS open the main menu in the middle? :P
07:59:33 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on pull request #8980: Feature: Multiple rotating views on title screen https://git.io/JuLgu
08:00:04 <nielsm> I'm thinking the tool should also have a kind of command sign checker and a renumbering tool for them
08:00:56 <nielsm> can maybe fill up the goals list with the sequence
08:09:31 <nielsm> panning between two moving vehicles
08:09:57 <nielsm> follow train 1 for 10 seconds, pan to train 2 across 10 seconds, follow train 2 for 10 seconds, pan back to train 1 across 10 seconds, repeat
08:11:48 *** sla_ro|master has joined #openttd
08:20:13 *** OsteHovel has joined #openttd
08:20:54 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9532: Change: Return 'New company/Spectate' option to company toolbar menu https://git.io/JuLow
08:22:01 <TrueBrain> I love Discord; they could explain their workflow, after the initial "it was convenient" arguments :D
08:31:11 <nielsm> also I just discovered that story book pages are actually saved in the game, the GS does not need to re-create them on load (indeed if it tries, you end up with duplicate pages)
08:31:37 <TrueBrain> lol; do I dare to ask: why does it do that?
08:32:07 <nielsm> which could make even more of an argument for an in-game storybook editor, to use as e.g. a journal
08:33:06 <nielsm> well the storybook could be journaling things that happened in the past and the data to recreate it no longer exists, and rebuilding a large storybook takes a lot of back and forth since every element on a page requires a command to be sent and processed
08:33:26 <nielsm> so a page with 4 elements takes 5 ticks to create
08:33:45 <TrueBrain> lol, okay, also didn't expect that :D
08:33:56 <TrueBrain> for some reason I expected it would send a JSON blob for the whole book to the clients :D
08:34:09 <TrueBrain> but makes sense if it is done like that, yes
08:35:03 <nielsm> having a way to send arbitrary structured data over the command protocol would be useful, yes
08:35:36 <nielsm> have I talked about my wild dreams of remaking the command protocol with protobufs or similar?
08:36:23 <TrueBrain> doubt protobuf is going to help you here :P
08:36:38 <TrueBrain> you would just replace one structed protocol with another strongly structured protocol
08:37:35 *** ChanServ sets mode: +v tokai
08:37:37 <TrueBrain> but indeed, removing "p1" and "p2" would be good :)
08:44:36 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
09:21:56 <_dp_> nielsm, yes, but way more people use it for the main menu
09:22:11 <_dp_> so it's fine to improve title game but not at the cost of main menu usability
09:22:24 <_dp_> vertical menu like TB suggested can work though
10:05:03 <nielsm> huh, there's no GSGoalList ?
10:12:42 *** roadt__ has joined #openttd
10:18:09 <DorpsGek> [OpenTTD/OpenTTD] ldpl commented on pull request #9532: Change: Return 'New company/Spectate' option to company toolbar menu https://git.io/Jutvn
10:19:39 <DorpsGek> [OpenTTD/BaNaNaS] TrueBrain commented on issue #105: Policy: Uploads which are not usable with main/trunk OpenTTD https://git.io/JufUD
10:19:40 *** roadt_ has quit IRC (Ping timeout: 480 seconds)
10:24:27 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9532: Change: Return 'New company/Spectate' option to company toolbar menu https://git.io/Jutfy
10:27:05 <DorpsGek> [OpenTTD/OpenTTD] andythenorth commented on pull request #9532: Change: Return 'New company/Spectate' option to company toolbar menu https://git.io/JutJG
10:33:44 <_dp_> wtf, I even put a smile this time :p
10:34:16 <_dp_> btw, if it's still not clear, I don't even partucalrly care about that pr, I use cmclient, that pr is just few more lines for me to care about while merging
10:35:58 <TrueBrain> nielsm: nice .. I am very curious what people will do with that
10:37:10 <nielsm> hmm there isn't any way to force the goals list to pop up, other than the specific storybook goal element link
10:38:48 <TrueBrain> sadly, I have no clue either :(
10:48:44 <nielsm> and renumbering works too now
10:50:52 *** tokai|noir has joined #openttd
10:50:52 *** ChanServ sets mode: +v tokai|noir
10:51:25 <TrueBrain> hmm .. downloads getting stuck at 99% .. oh-oh ...
10:51:30 <TrueBrain> ah, no, it is just not closing the window
10:51:41 <TrueBrain> how did that happen?! :D
10:56:59 <Samu> i just witnessed something really weird, a ship got a transfer of -£65 and a cost of £1015
10:57:55 *** tokai has quit IRC (Ping timeout: 480 seconds)
11:02:06 *** Progman has quit IRC (Remote host closed the connection)
11:02:24 <TrueBrain> downloaded 924 KiB of 923 KiB
11:02:27 <TrueBrain> euhm .. yeah .. that is not right :P
11:06:51 <TrueBrain> haha, oops .. nasty bug
11:08:11 <DorpsGek> [OpenTTD/py-protocol] TrueBrain opened pull request #17: Fix: content protocol didn't close a file download correctly https://git.io/JutqX
11:08:28 <Wolf01> Ok, enough tank repairs for today... another maus destroyed by andythenorth to fix :P
11:10:28 <DorpsGek> [OpenTTD/py-protocol] TrueBrain merged pull request #17: Fix: content protocol didn't close a file download correctly https://git.io/JutqX
11:12:48 <DorpsGek> [OpenTTD/bananas-server] TrueBrain opened pull request #58: Change: switch over to openttd-protocols for the wire-protocol itself https://git.io/Jutm0
11:15:17 <DorpsGek> [OpenTTD/bananas-server] TrueBrain merged pull request #58: Change: switch over to openttd-protocol library for the wire-protocol https://git.io/Jutm0
11:18:26 <andythenorth> pretty much my favourite tank to drive for relaxation
11:20:22 *** andythenorth has quit IRC (Quit: andythenorth)
11:33:44 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #9541: Add: support filtering content entries for patchpacks https://git.io/Jutst
11:35:15 <DorpsGek> [OpenTTD/py-protocol] TrueBrain opened pull request #18: Add: support multiple branches for content listing https://git.io/JutsW
11:35:32 <DorpsGek> [OpenTTD/bananas-server] TrueBrain opened pull request #59: Add: support multiple branches for compatibility https://git.io/Juts4
11:37:46 <DorpsGek> [OpenTTD/bananas-api] TrueBrain opened pull request #100: Add: support for filtering content that is JGRPP-only https://git.io/Jutsy
11:38:19 *** sla_ro|master has quit IRC ()
11:38:56 <TrueBrain> for a change, but need review on the above set :)
12:18:26 <DorpsGek> [OpenTTD/OpenTTD] nielsmh updated pull request #8980: Feature: Multiple rotating views on title screen https://git.io/JOvM3
12:27:22 *** frosch123 has joined #openttd
12:36:50 *** roadt__ has quit IRC (Ping timeout: 480 seconds)
12:37:02 *** roadt__ has joined #openttd
12:43:58 <DorpsGek> [OpenTTD/BaNaNaS] frosch123 commented on issue #105: Policy: Uploads which are not usable with main/trunk OpenTTD https://git.io/JufUD
12:44:55 <frosch123> TrueBrain: some time ago we discussed renaming "official" to "vanilla". now may be the last chance for renaming. when the client sends it, it is kind of set in stone
12:45:20 <TrueBrain> I didn't want to bring it up, as I couldn't remember why we picked official to start with
12:45:56 <frosch123> pretty sure i picked "official", i always used that term in discussions
12:46:03 <frosch123> "vanilla" is not really my vocabulary
12:46:57 <frosch123> i used "official", because it is what you get from official openttd.org, and now official game stores
12:47:11 <frosch123> but once those sites would offer other branches, that term no longer works
12:47:16 <frosch123> so, "vanilla" is kind of better :)
12:48:17 <michi_cc> Maybe actually just call it "openttd"? Who knows if vanilla is just as PC insensitive as using master (not entirely joking) :)
12:48:26 <_dp_> official is both binding and ambiguous
12:48:35 <_dp_> like, citymania client is the official build of citymania
12:53:43 <DorpsGek> [OpenTTD/bananas-api] frosch123 commented on pull request #100: Add: support for filtering content that is JGRPP-only https://git.io/Jutzu
12:57:54 <TrueBrain> michi_cc: that is the ambiguous term we tried to get away from :P
13:16:58 *** andythenorth has joined #openttd
13:23:33 <DorpsGek> [OpenTTD/py-protocol] frosch123 approved pull request #18: Add: support multiple branches for content listing https://git.io/JutK2
13:44:04 <DorpsGek> [OpenTTD/OpenTTD] vituscze opened pull request #9542: Fix #9241: Grove and forest tree brushes also create rainforests https://git.io/JutMB
13:48:03 <DorpsGek> [OpenTTD/OpenTTD] vituscze updated pull request #9542: Fix #9241: Grove and forest tree brushes also create rainforests https://git.io/JutMB
13:48:44 <glx> ah yes it was 231 commits behind master :)
13:51:28 <Samu> #9523 is related to ship path cache
13:51:49 <Samu> it caches a path which didn't yet contain a lock
13:52:02 <Samu> will take time to update itself
13:54:21 <glx> no it's because there are 2 missing locks, but the message is not retriggered
13:54:38 <DorpsGek> [OpenTTD/bananas-api] JGRennison commented on pull request #100: Add: support for filtering content that is JGRPP-only https://git.io/JutS6
13:57:53 <Samu> do you have a savegame, need to look
13:58:21 <glx> no need for a savegame, it's the steps :)
13:59:26 <glx> we encountered this a lot during the #9017 play test
14:04:19 <Samu> where does it say it needs 2 locks?
14:05:15 <Samu> i built a lock, and problem was solved
14:05:25 <Samu> took a bit of time but the ship got on its way
14:13:00 <glx> it's still lost because one lock was not enough, but no message is issued
14:13:29 <glx> so still lost, but impossible to know it
14:18:48 <Samu> an indicator that the ship is currently lost
14:23:15 *** andythenorth_ has joined #openttd
14:25:27 *** andythenorth__ has joined #openttd
14:28:41 *** andythenorth has quit IRC (Ping timeout: 480 seconds)
14:32:30 *** andythenorth_ has quit IRC (Ping timeout: 480 seconds)
14:42:53 *** jottyfan has joined #openttd
14:43:00 <DorpsGek> [OpenTTD/py-protocol] TrueBrain merged pull request #18: Add: support multiple branches for content listing https://git.io/JutsW
14:50:05 <DorpsGek> [OpenTTD/bananas-server] TrueBrain updated pull request #59: Add: support multiple branches for compatibility https://git.io/Juts4
14:50:10 <TrueBrain> I think I did the logic correct .. :P
14:51:01 <TrueBrain> right, mass rename to vanilla it is, I guess ... meh, yet another one
14:51:05 <TrueBrain> I did one recently already! :P
14:51:30 <TrueBrain> going to do that some other time .. can't be fuzzed about it now. But of course before we release the new bananas-server :)
14:54:16 <andythenorth__> lol somehow I have configured a debug build of openttd
14:54:27 * andythenorth__ was confused by 'tab is broken' again
14:54:51 <glx> means you forgot to configure :)
14:55:55 <andythenorth__> I tried some flags for some reason recently
14:56:07 <andythenorth__> lol this train smoke is perfectly in time with the music I'm listening to
14:56:31 <andythenorth__> think someone (peter1138 maybe) once said its because it's a common BPM
14:57:15 <andythenorth__> it's particularly pleasing with double smoke :P
15:00:10 <DorpsGek> [OpenTTD/bananas-server] TrueBrain updated pull request #59: Add: support multiple branches for compatibility https://git.io/Juts4
15:19:38 <glx> I'd prefer icon in vehicle list, and explicit text in vehicle window
15:20:45 <glx> replacing "heading for" with "can't reach" maybe
15:37:26 <andythenorth__> also speed before destination :P
15:37:31 * andythenorth__ had a patch for that
15:42:10 <DorpsGek> [OpenTTD/OpenTTD] nielsmh updated pull request #8980: Feature: Multiple rotating views on title screen https://git.io/JOvM3
15:42:47 <nielsm> LordAro: There's the code documentation added too
15:59:44 *** Wormnest has joined #openttd
16:06:03 <TrueBrain> glx: I think it has to be both; both something per vehicle, and in the vehicle list. As some people use one, and not the other, and the other way around
16:06:15 <TrueBrain> having either is most likely falling short
16:06:50 <TrueBrain> for vehicle window, icon + change of text would be most clear, I think. Especially as the icon is reused in the vehicle list :)
16:07:27 *** jottyfan has quit IRC (Quit: jottyfan)
16:11:50 <Samu> vehicle list, not sure where to put it
16:13:03 <TrueBrain> that moment you write a bunch of review comment, and you realise: I don't care. It can do without that comment. And I happily remove the comment again :D
16:13:59 <Samu> the space below 1/, to the left of profit
16:15:08 *** Gustavo6046 has joined #openttd
16:15:47 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8980: Feature: Multiple rotating views on title screen https://git.io/Juqlt
16:16:14 <TrueBrain> I think before the order itself, or something
16:16:28 <TrueBrain> btw, your icon needs some alignment love :)
16:16:48 <TrueBrain> looking good so far Same, nice :)
16:17:00 <TrueBrain> bah, I cannot type, as it turns out
16:17:43 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #9534: Fix: use-after-free after ClientNetworkCoordinatorSocketHandler::CloseAllConnections() https://git.io/JEhfk
16:18:28 <TrueBrain> owh, it also does need a rebase, lol
16:18:53 <glx> oh that kind of PR divising users
16:19:23 <TrueBrain> now you see why I want another approval? :P
16:21:38 <TrueBrain> owh, that conflict really is a conflict .. lets see if I can fix that ..
16:24:59 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #8688: Feature: Hide block signals in GUI by default https://git.io/Juq8O
16:25:02 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #8688: Feature: Hide block signals in GUI by default https://git.io/JE0hP
16:25:05 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #8688: Feature: Hide block signals in GUI by default https://git.io/JtDJs
16:25:09 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #8688: Feature: Hide block signals in GUI by default https://git.io/Juq4R
16:27:52 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on pull request #8980: Feature: Multiple rotating views on title screen https://git.io/JuqBJ
16:28:34 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on pull request #8980: Feature: Multiple rotating views on title screen https://git.io/JuqBC
16:30:46 <_dp_> 8688 doesn't look that dividing actually
16:31:04 <_dp_> someone will probably miss non-pbs default but other than that seems fine
16:31:18 <_dp_> also it could've used 1 setting instead of 2
16:31:50 <_dp_> show all cycle all/show all cycle pbs/show pbs
16:32:27 <DorpsGek> [OpenTTD/bananas-api] TrueBrain opened pull request #101: Change: rename "official" to "vanilla" in branch compatibility https://git.io/JuqRc
16:32:30 <DorpsGek> [OpenTTD/bananas-server] TrueBrain opened pull request #60: Change: rename "official" to "vanilla" in branch compatibility https://git.io/JuqRC
16:32:39 <TrueBrain> still need to prepare BaNaNaS and BaNaNaS-staging
16:33:01 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
16:33:19 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on pull request #8980: Feature: Multiple rotating views on title screen https://git.io/JuqR1
16:34:53 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on pull request #8980: Feature: Multiple rotating views on title screen https://git.io/Juq0m
16:34:56 <DorpsGek> [OpenTTD/BaNaNaS] TrueBrain opened pull request #106: Change: rename "official" to "vanilla" in branch compatibility https://git.io/Juq0Y
16:35:02 <TrueBrain> ha, I still had the seds in my history :D
16:37:05 <TrueBrain> nielsm: tnx for the responses. As long as these things weren't by accident, I am all happy :)
16:43:24 <nielsm> the reason I went with the slightly unusual "performance order" was also that "execution" does have the second meaning of executing a death penalty
16:44:28 <TrueBrain> it is for me an unusual way of using that word, but I looked it up, it is fine :) Was my lack of english :P
16:46:16 <nielsm> just like stage plays and musical pieces are performed :)
16:49:14 <DorpsGek> [OpenTTD/OpenTTD] nielsmh updated pull request #8980: Feature: Multiple rotating views on title screen https://git.io/JOvM3
16:54:19 <Samu> such a short path and still reports ship is lost, kinda sad
16:57:40 <Samu> set ship_curve90_penalty 100
17:00:06 <Samu> are you aware of this penalty, TrueBrain ? it's relatively recent
17:02:26 <nielsm> the pf for some reason fails/gives up if there is a body of land in the way even if it's possible to navigate around
17:03:43 <andythenorth__> that's been there for a while though
17:04:48 <TrueBrain> Samu: maybe good to read up a bit how A* pathfinders work
17:04:58 <TrueBrain> but ANY penalty will have a "hurtful" effect on the ship PF
17:09:09 <Samu> curve90 penalty was invented once ships became unable to make 90 degrees without stopping to make a turn
17:09:20 <TrueBrain> huh? How did you conclude that from what I said :P
17:12:33 <Samu> funny that there isn't a penalty for moving up/down on locks
17:13:03 <Samu> and for good reason, hope there won't be one
17:15:54 <nielsm> I think your thinking of the way pathfinding works is colored by the word "penalty" being used instead of "cost"
17:15:55 <TrueBrain> but really, read up on A* pathfinders, they are amazing, and it will make much more sense
17:24:04 <Samu> how to invalidate vehicle list window data, don't know the name of this window
17:26:36 <nielsm> vehicle_gui.h has GetWindowClassForVehicleType(VehicleType)
17:28:52 <nielsm> but the window number for vehicle list windows isn't just a trivial value, there is a special class used to calculate it (it's a packed value of various things)
17:29:42 <nielsm> vehiclelist.h has the VehicleListIdentifier struct used to generate those window numbers
17:32:17 <nielsm> you just need the window class from GetWindowClassForVehicleType(VehicleType) to invalidate all ship list windows
17:34:11 <Samu> InvalidateWindowClassesData(GetWindowClassForVehicleType(this->type));
17:35:27 <TrueBrain> a++ in a ctor construction .. that .. seems like an accident waiting to happen
17:37:18 <nielsm> the evaluation order is well defined tho
17:37:29 <nielsm> but it's an ugly place to hide a side effect, I agree
17:37:43 <TrueBrain> kinda surprised it is allowed :D
17:38:45 <Samu> a bit overkill, but it works! thx nielsm
17:41:26 <Beer> TrueBrain: Did what you requested on OpenTTD/OpenTTD/pull/9105. Might fit well with the current network + debug messages overhaul (o:
17:41:48 <Samu> so, im not sure i wanna PR in its current state
17:41:53 <TrueBrain> the ++ in the ctor however is an accident waiting to happen Beer :)
17:41:58 <TrueBrain> haven't otherwise looked at the PR yet
17:42:57 <Beer> Well, I merely moved it as part of the use of member initialisers in 1st commit
17:45:54 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #9542: Fix #9241: Grove and forest tree brushes also create rainforests https://git.io/JuqXc
17:46:46 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #9538: Fix #9535: Maintain a reverse dependency map of network content https://git.io/JuqX4
17:53:21 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #9543: Feature #9523: Display icon or text in vehicle list or in vehicle window indicating whether a vehicle is lost https://git.io/Juq19
18:06:20 *** gelignite has joined #openttd
18:10:05 <andythenorth__> am I the only grf author who names trains for ease of tab completion in shell?
18:11:00 *** jottyfan has joined #openttd
18:22:31 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8688: Feature: Hide block signals in GUI by default https://git.io/JtDJs
18:26:01 <michi_cc> Somebody on the forums will get a breakdown now :P
18:27:36 <TrueBrain> that at least is the single constant on the forums :)
18:30:24 <andythenorth__> better than silence
18:41:25 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #9543: Feature #9523: Display icon or text in vehicle list or in vehicle window indicating whether a vehicle is lost https://git.io/Juq19
18:43:59 <Samu> how do I do a sprite for a PR?
18:44:02 <Timberwolf> You might even please the people who think they are the "pro option", by making it something special that has to be unlocked.
19:04:30 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
19:05:00 *** WormnestAndroid has joined #openttd
19:08:16 *** Progman has joined #openttd
19:10:25 <DorpsGek> [OpenTTD/bananas-api] frosch123 approved pull request #100: Add: support for filtering content that is JGRPP-only https://git.io/Juqxx
19:11:15 <DorpsGek> [OpenTTD/bananas-api] frosch123 approved pull request #101: Change: rename "official" to "vanilla" in branch compatibility https://git.io/JuqpU
19:11:23 <frosch123> "Vanilla OpenTTD" reads funny :p
19:11:50 <TrueBrain> As hoping you had a better suggestion :D
19:11:59 <frosch123> i would have written "OpenTTD (vanilla)", but then "OpenTTD (JGRPP)" looks stupid
19:13:04 <TrueBrain> Upstream, unmodified, patchless
19:13:25 <frosch123> it's fine. if it is written next to JGRPP, then people will understand the meaning
19:13:47 <glx> but if any newgrf is enabled it's no longer vanilla
19:14:21 <andythenorth__> 'vanilla' means '!JGRPP'
19:14:48 <frosch123> andythenorth__: what about TrueTTD?
19:14:58 <frosch123> does vanilla exclude that?
19:15:16 <TrueBrain> Sssttt, that project is a secretttttt
19:16:06 <frosch123> can you afford it though?
19:16:13 <glx> I remember something about a versus version
19:16:53 <DorpsGek> [OpenTTD/bananas-server] frosch123 approved pull request #60: Change: rename "official" to "vanilla" in branch compatibility https://git.io/JuqpX
19:17:01 <Xaroth> Oh yeah, that versus mode
19:17:06 <Xaroth> that would've been neat.
19:17:24 <andythenorth__> OpenTTD (True)
19:17:32 <TrueBrain> I need to coordinate the merges btw frosch .. Will be a bit of a hassle :)
19:21:58 <frosch123> #9541 contains "official", can't approve that :)
19:22:02 <nielsm> <TrueBrain> Head2head.. hmm <- split screen OTTD with two mice
19:22:27 <glx> but same map on both half
19:23:21 <TrueBrain> frosch123: as long as the rest is okay :)
19:23:44 <frosch123> not sure how useful the "patchpack" example is
19:23:44 <TrueBrain> I will fix it all up and merge it tomorrow :)
19:24:45 <_dp_> I'll do h2h server one day...
19:25:27 <frosch123> i like that bananas-server has special code for 12.0-beta now :p
19:25:31 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #9543: Feature #9523: Display icon or text in vehicle list or in vehicle window indicating whether a vehicle is lost https://git.io/Juqje
19:25:51 <TrueBrain> frosch123: yeah .......
19:26:51 <frosch123> is it a problem, if the int() in receive_PACKET_CONTENT_CLIENT_INFO_LIST throws?
19:26:55 <frosch123> because clients send non-numbers
19:27:22 <TrueBrain> The connection will be closed
19:27:30 <TrueBrain> As it violates protocol
19:28:06 <TrueBrain> Goes for any exception btw :)
19:28:11 <TrueBrain> Sentry does record it, just to spot issues we made :p
19:30:23 <frosch123> i wonder when i will get used to for-else :) i am not used to things which do not exist in c++
19:30:49 <TrueBrain> I liked how it fits in this problem perfectly
19:31:00 <TrueBrain> Doesn't happen often :D
19:31:43 <glx> is like the finally in a try-catch ?
19:32:11 <TrueBrain> Else triggers if the loop isn't "break"d
19:32:44 *** sla_ro|master has joined #openttd
19:32:49 <TrueBrain> For those "found = true" cases
19:34:55 <DorpsGek> [OpenTTD/bananas-server] frosch123 commented on pull request #59: Add: support multiple branches for compatibility https://git.io/JumeV
19:34:59 <frosch123> yay, found something :)
19:35:01 *** Gustavo6046_ has joined #openttd
19:36:30 <TrueBrain> Worst part, those datakey are pointless anyway :p
19:39:03 *** Gustavo6046 has quit IRC (Ping timeout: 480 seconds)
19:39:03 *** Gustavo6046_ is now known as Gustavo6046
19:40:09 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #9541: Add: support filtering content entries for patchpacks https://git.io/Jumvw
19:40:53 <TrueBrain> Tnx for the reviews, will make it all a reality tomorrow :D
19:42:24 <frosch123> hmm, 1524 items specify a version. i would have guessed less
19:42:44 <TrueBrain> Yeah, it is a bit crazy
19:42:51 <TrueBrain> Not sure it is used correctly :p
19:43:18 <frosch123> i expect people just set it to the version they used for testing
19:43:24 <frosch123> noone knows what runs in older versions
19:46:11 <Timberwolf> I think I set mine to the earliest version mentioned in the features I used (which was typically 1.10 for most of them)
20:01:52 *** gelignite has quit IRC (Quit: Stay safe!)
20:16:12 *** luaduck has quit IRC (Quit: Why do you need...?)
20:17:21 *** frosch123 has quit IRC (Quit: be yourself, except: if you have the opportunity to be a unicorn, then be a unicorn)
20:31:40 *** jottyfan has quit IRC (Quit: jottyfan)
20:54:22 *** Samu has quit IRC (Quit: Leaving)
20:55:46 *** ChanServ sets mode: +v tokai
21:02:38 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
21:07:33 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
21:09:04 *** WormnestAndroid has joined #openttd
21:17:25 *** luaduck has joined #openttd
21:20:41 *** nielsm has quit IRC (Ping timeout: 480 seconds)
22:07:13 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
22:13:28 *** sla_ro|master has quit IRC ()
22:15:38 *** Progman has quit IRC (Remote host closed the connection)
22:23:15 *** HerzogDeXtEr has joined #openttd
22:29:15 *** andythenorth__ has quit IRC (Quit: andythenorth__)
22:31:00 *** andythenorth has joined #openttd
22:36:40 *** tt has quit IRC (Quit: Page closed)
22:38:16 *** andythenorth has quit IRC (Quit: andythenorth)
22:56:06 *** tokai|noir has joined #openttd
22:56:06 *** ChanServ sets mode: +v tokai|noir
23:03:09 *** tokai has quit IRC (Ping timeout: 480 seconds)
23:03:12 *** Beer has quit IRC (Quit: Leaving)
23:24:36 *** NGC3982 has quit IRC (Ping timeout: 480 seconds)
continue to next day ⏵
