IRC logs for #openttd on OFTC at 2021-08-16
            
00:00:57 *** WormnestAndroid has joined #openttd
00:19:36 *** Kitrana has joined #openttd
00:26:35 *** Kitrana1 has quit IRC (Ping timeout: 480 seconds)
00:48:54 <_dp_> omg I just found a megabug
00:56:50 <_dp_> also why is openttd comparing strings with .compare() == 0 ?
00:57:20 <_dp_> instead of regular ==
00:59:23 <dwfreed> depends on context, I guess?
01:02:52 <_dp_> https://github.com/OpenTTD/OpenTTD/blob/master/src/network/network_server.cpp#L1550
01:07:19 <glx> because before https://github.com/OpenTTD/OpenTTD/commit/e3c9ed4d151a021e3f10492744915fc15b0bc0d6 it was comparing std::string with char*
01:08:22 <_dp_> can't == do that as well?
01:08:35 <glx> == should work now
01:09:14 <_dp_> guess I'll change it to == since I'm patching it anyway
01:09:35 <glx> but I'm not sure it's ok to do std::string == char*
01:11:19 <_dp_> well, C++ never ceases to surprise me, but what can possibly go wrong there?
01:12:02 <_dp_> except for memory violation I guess xD
01:23:15 <DorpsGek> [OpenTTD/OpenTTD] ldpl opened pull request #9485: Fix client dupes https://git.io/J0fHt
01:24:10 <_dp_> wtf did it pr...
01:24:12 <_dp_> silly github
01:24:42 <glx> it uses branch name by default
01:24:52 <glx> if multiple commits
01:25:06 <_dp_> yeah, but why are there multiple commits
01:25:24 <_dp_> oh, I probably had some junk in master...
01:26:10 <glx> the 3 merge commits yes
01:27:17 <DorpsGek> [OpenTTD/OpenTTD] ldpl updated pull request #9485: Fix client dupes https://git.io/J0fHt
01:29:13 <DorpsGek> [OpenTTD/OpenTTD] ldpl updated pull request #9485: Fix: connecting with the same name thrice hangs the server https://git.io/J0fHt
01:31:12 <_dp_> ok, looks good now
01:32:11 <glx> a nice overlooked disparition of a vital "++" :)
02:28:46 *** glx has quit IRC ()
02:33:20 *** Speeder_ has joined #openttd
02:38:14 *** Wormnest has quit IRC (Quit: Leaving)
02:40:25 *** Speeder has quit IRC (Ping timeout: 480 seconds)
02:52:23 *** debdog has joined #openttd
02:55:46 *** D-HUND has quit IRC (Ping timeout: 480 seconds)
03:09:40 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
03:10:01 *** WormnestAndroid has joined #openttd
03:16:10 *** Flygon has joined #openttd
03:22:10 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
03:24:04 *** WormnestAndroid has joined #openttd
04:17:42 *** urdh_ has joined #openttd
04:20:31 *** urdh has quit IRC (Ping timeout: 480 seconds)
04:24:38 <DorpsGek> [OpenTTD/OpenTTD] dgealow opened issue #9486: [Bug]: "Base graphics set missing 5 tiles" message in main menu in latest beta https://git.io/J0Jno
04:51:37 *** Kitrana1 has joined #openttd
04:56:40 *** Kitrana has quit IRC (Ping timeout: 480 seconds)
06:01:55 *** Wuzzy has joined #openttd
06:07:20 *** sla_ro|master has joined #openttd
06:41:27 *** Wolf01 has joined #openttd
07:15:54 <DorpsGek> [OpenTTD/nml] andythenorth commented on issue #196: Suspected integer underflow when switch returns a negative number https://git.io/JYJRU
07:18:33 <DorpsGek> [OpenTTD/nml] andythenorth commented on issue #209: Cargo callback "profit" probably broken https://git.io/JODbP
07:20:17 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on issue #9486: [Bug]: "Base graphics set missing 5 tiles" message in main menu in latest beta https://git.io/J0Jno
07:29:41 *** andythenorth has joined #openttd
07:41:08 *** HerzogDeXtEr has joined #openttd
07:50:24 *** nielsm has joined #openttd
07:54:57 *** virtualrandomnumber has joined #openttd
07:58:03 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #9485: Fix: connecting with the same name thrice hangs the server https://git.io/J0Jhy
08:05:46 *** virtualrandomnumber has quit IRC (Quit: virtualrandomnumber)
08:18:42 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #9417: Codechange: Improve LineCache queries https://git.io/J0UTe
08:22:07 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #9457: Feature: [Linkgraph] Prioritize faster routes for passengers and express cargo https://git.io/J0Uk7
08:24:53 *** virtualrandomnumber has joined #openttd
08:25:19 *** virtualrandomnumber has quit IRC ()
09:08:56 *** virtualrandomnumber has joined #openttd
09:09:06 *** virtualrandomnumber has quit IRC ()
09:09:58 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #9485: Fix: connecting with the same name thrice hangs the server https://git.io/J0fHt
09:18:51 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #9417: Codechange: Improve LineCache queries https://git.io/JcS0H
09:24:40 <LordAro> #9485 is serious enough that we probably want to do beta2 quite quickly
09:27:24 <_dp_> dunno, not many people join thrice
09:27:34 <_dp_> and "player" was banned finally xD
09:28:10 <_dp_> I mean it's serious but mb worth waiting a bit for other bugs to surface as well
09:29:26 <_dp_> anyway, looking at server list it seems I'll be the one to run 12.0 servers publically xD
09:29:30 <_dp_> and I have it fixed :p
09:30:04 <_dp_> though I guess it may be part of the reason why there are no servers...
09:40:13 *** virtualrandomnumber has joined #openttd
09:40:24 *** virtualrandomnumber has quit IRC ()
10:03:44 <peter1138> Release early, release often.
10:20:50 <DorpsGek> [OpenTTD/OpenGFX] LordAro opened issue #68: New network gui icons needed https://git.io/J0UVv
10:32:56 <TrueBrain> https://steamcommunity.com/app/1536610/eventcomments/4737210531938699502 what a bunch of lovely comments :)
10:33:28 <DorpsGek> [OpenTTD/nml] glx22 commented on issue #209: Cargo callback "profit" probably broken https://git.io/JODbP
10:34:03 <TrueBrain> And yeah, let's do beta2 tomorrow or so .. just bashing some buttons
10:38:49 <LordAro> "Maybe the best update that's ever been cooked up for this game"
10:49:48 <DorpsGek> [OpenTTD/OpenTTD] nchappe updated pull request #9457: Feature: [Linkgraph] Prioritize faster routes for passengers and express cargo https://git.io/J8PqI
10:52:58 <DorpsGek> [OpenTTD/OpenTTD] nchappe commented on pull request #9457: Feature: [Linkgraph] Prioritize faster routes for passengers and express cargo https://git.io/J0UiF
11:14:31 *** WormnestAndroid has quit IRC (Remote host closed the connection)
11:15:33 *** WormnestAndroid has joined #openttd
11:15:55 *** WormnestAndroid has quit IRC (Remote host closed the connection)
11:16:12 *** WormnestAndroid has joined #openttd
11:16:48 *** WormnestAndroid has quit IRC (Remote host closed the connection)
11:17:43 *** WormnestAndroid has joined #openttd
11:18:32 *** WormnestAndroid has quit IRC (Remote host closed the connection)
11:21:34 *** WormnestAndroid has joined #openttd
11:47:24 *** roadt_ has joined #openttd
11:53:25 *** roadt__ has quit IRC (Ping timeout: 480 seconds)
12:13:00 *** virtualrandomnumber has joined #openttd
12:13:44 *** glx has joined #openttd
12:13:44 *** ChanServ sets mode: +v glx
12:13:57 *** Speeder__ has joined #openttd
12:21:25 *** Speeder_ has quit IRC (Ping timeout: 480 seconds)
12:40:07 *** Samu has joined #openttd
13:20:38 *** roadt_ has quit IRC (Ping timeout: 480 seconds)
13:23:51 *** roadt_ has joined #openttd
13:27:35 *** virtualrandomnumber has quit IRC (Quit: virtualrandomnumber)
13:40:25 *** gelignite has joined #openttd
14:40:05 *** spnda has joined #openttd
14:40:22 *** iSoSyS has joined #openttd
14:44:02 *** iSoSyS has quit IRC ()
15:09:43 <TrueBrain> Wauw, more 12 servers online than I expected ..
15:10:22 <TrueBrain> And for some reason someone couldn't connect.. meaning they also failed a connection to the TURN server .. impressive
15:25:15 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
15:27:27 *** WormnestAndroid has joined #openttd
15:41:12 *** Wormnest has joined #openttd
15:42:50 <_dp_> Can I still pass all settings in one config file?
15:42:55 <_dp_> I only see -c option
15:43:23 <glx> hmm not sure about the 2 other files
15:44:23 <glx> but if everything is in openttd.cfg it will be loaded (and moved to new files)
15:45:10 <glx> and the option to not overwrite config file still exist
15:45:23 <_dp_> yeah, that sounds fine
15:48:57 <_dp_> now need to figure out how to load it from string again %)
15:56:26 <TrueBrain> hmm .. now I wonder if STUN over IPv6 works, or if we have a bug or something .. lets test!
15:58:42 <TrueBrain> okay, that is a bug :)
15:58:55 <TrueBrain> I think the GC forgets to send "[]"
15:59:10 <TrueBrain> two bugs even .. it fails on DNS for that reason
15:59:20 <TrueBrain> and next it doesn't report the failure to the GC correctly, so TURN isn't used as fallback
15:59:24 <TrueBrain> well, will fix that tomorrow
15:59:28 <TrueBrain> even more reason for beta2 ;)
15:59:45 <peter1138> Hmm, I guess still used if IPv6 is firewalled.
15:59:48 <TrueBrain> well, I might be able to mitigate this on the GC ..
16:00:26 <TrueBrain> but not something for tonight :)
16:06:15 <TrueBrain> yeah, for sure an issue in the GC .. and a bug somewhere else that it doesn't continue on with TURN after that .. well, tomorrow I will setup a test-setup, and debug the hell out of it :D
16:12:27 <_dp_> what's the point of using const string_view, isn't it already const?
16:12:28 <_dp_> https://github.com/OpenTTD/OpenTTD/blob/master/src/string_func.h#L54
16:17:00 <_dp_> it's like const std::string & const
16:17:06 <LordAro> same reason you use const char *
16:17:08 <LordAro> vs char *
16:18:35 <_dp_> no, that's const pointer, string_view pointers are const either way
16:19:06 <_dp_> const string_view is making string_view itself const which is pretty redundant
16:19:16 <_dp_> you may as well make every argument conts
16:19:24 <LordAro> if you're not changing it? sure
16:19:32 <LordAro> compilers are fickle things
16:22:00 <_dp_> what have compilers to do with it?
16:22:15 <_dp_> that const just prevents you from channging string_view in the function
16:22:20 <_dp_> big deal, it's copied anyway
16:22:33 <LordAro> exactly!
16:22:54 <LordAro> you can look at the function signature and know without looking at the function body that the parameter is not changed anywhere
16:23:00 <LordAro> s/parameter/variable/
16:23:01 <Xaroth> Sometimes you need to protect your code from the developer ;)
16:23:20 <Xaroth> because it cannot change, you can assume it will not
16:23:49 <_dp_> LordAro, you mean if you don't know string_view is const view?
16:24:20 <_dp_> otherwise it's irrelevant what function does with its copy
16:25:17 <_dp_> pretty sure you don't write const int, const double etc everywhere
16:25:26 <_dp_> in function args I mean
16:25:28 <LordAro> no, but you could
16:25:53 <LordAro> i retract my previous "compilers" thing
16:26:50 * LordAro disappears
16:41:52 <DorpsGek> [OpenTTD/team] Homyakin opened issue #241: [ru_RU] Translator access request https://git.io/J0kfB
16:47:42 <TrueBrain> wait, where did LordAro go? :D
17:19:58 *** Tirili has joined #openttd
17:27:09 *** Tirili has quit IRC (Quit: Leaving)
17:27:32 *** Tirili has joined #openttd
17:32:43 *** Progman has joined #openttd
17:32:57 *** Tirili has quit IRC (Quit: Leaving)
17:33:20 *** Tirili has joined #openttd
17:41:15 <_dp_> there still are plenty of mentions of openttd.cfg in the comments
17:43:23 <_dp_> ah, nvm, openttd.cfg still exists
17:43:30 <_dp_> I confused it with settings.ini
17:43:40 <glx> openttd.cfg is split in 3 :)
17:44:02 <glx> but there's still openttd.cfg, plus a private and a secret
18:25:06 *** tokai has joined #openttd
18:25:06 *** ChanServ sets mode: +v tokai
18:26:16 *** Progman has quit IRC (Remote host closed the connection)
18:26:56 <andythenorth> yo
18:30:35 *** Flygon has quit IRC (Read error: Connection reset by peer)
18:31:56 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
18:40:00 *** Speeder__ has quit IRC (Ping timeout: 480 seconds)
18:54:15 *** spnda has quit IRC (Quit: Page closed)
18:56:05 <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/J0kuY
18:56:06 <DorpsGek> - Update: Translations from eints (by translators)
18:58:01 *** Progman has joined #openttd
19:24:05 *** WormnestAndroid has quit IRC (Read error: No route to host)
19:24:11 *** WormnestAndroid has joined #openttd
19:30:11 *** gelignite has quit IRC (Quit: Stay safe!)
20:14:47 *** Compu has joined #openttd
20:15:07 *** Compu has quit IRC ()
20:42:14 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
21:14:59 *** Progman has quit IRC (Remote host closed the connection)
21:42:55 *** Samu has quit IRC (Ping timeout: 480 seconds)
21:53:29 *** sla_ro|master has quit IRC ()
22:05:31 *** andythenorth has quit IRC (Quit: andythenorth)
22:24:26 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
22:37:40 *** Speedyn has joined #openttd
22:43:36 *** Speedy` has quit IRC (Ping timeout: 480 seconds)
22:49:39 *** tokai|noir has joined #openttd
22:49:39 *** ChanServ sets mode: +v tokai|noir
22:51:31 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #9457: Feature: [Linkgraph] Prioritize faster routes for passengers and express cargo https://git.io/J0kjS
22:52:28 *** WormnestAndroid has quit IRC (Remote host closed the connection)
22:52:39 *** WormnestAndroid has joined #openttd
22:56:34 *** tokai has quit IRC (Ping timeout: 480 seconds)
23:37:58 *** Wuzzy has quit IRC (Quit: Wuzzy)
23:43:08 *** nielsm has quit IRC (Remote host closed the connection)