IRC logs for #openttd on OFTC at 2021-07-19
⏴ go to previous day
00:12:40 *** roadt_ has quit IRC (Ping timeout: 480 seconds)
01:06:51 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #9447: Feature: allow the use of TURN to connect client and server together https://git.io/JW5l9
01:08:10 *** Progman has quit IRC (Remote host closed the connection)
01:59:14 *** tokai|noir has joined #openttd
01:59:14 *** ChanServ sets mode: +v tokai|noir
02:06:11 *** tokai has quit IRC (Ping timeout: 480 seconds)
02:06:47 <DorpsGek> [OpenTTD/OpenTTD] perezdidac commented on pull request #9043: Feature: ability to build overlapping bridges on different axes (WIP) https://git.io/JW5rL
02:12:03 <DorpsGek> [OpenTTD/OpenTTD] perezdidac updated pull request #9043: Feature: ability to build overlapping bridges on different axes (WIP) https://git.io/JOWU8
02:24:28 *** snail_UES_ has joined #openttd
02:34:26 *** debdog has quit IRC (Ping timeout: 480 seconds)
02:40:33 <DorpsGek> [OpenTTD/OpenTTD] perezdidac updated pull request #9043: Feature: ability to build overlapping bridges on different axes (WIP) https://git.io/JOWU8
02:41:50 *** Wormnest has quit IRC (Quit: Leaving)
02:53:55 <DorpsGek> [OpenTTD/OpenTTD] perezdidac updated pull request #9043: Feature: ability to build overlapping bridges on different axes (WIP) https://git.io/JOWU8
03:15:20 *** WormnestAndroid has quit IRC (Remote host closed the connection)
03:16:13 *** WormnestAndroid has joined #openttd
03:41:02 *** snail_UES_ has quit IRC (Quit: snail_UES_)
04:22:20 *** supermop_Home has quit IRC (Ping timeout: 480 seconds)
05:28:09 *** andythenorth has joined #openttd
05:59:29 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9447: Feature: allow the use of TURN to connect client and server together https://git.io/JWdrw
06:26:10 *** sla_ro|master has joined #openttd
06:45:05 *** HerzogDeXtEr has joined #openttd
07:34:08 *** WormnestAndroid has quit IRC (Remote host closed the connection)
07:34:20 *** WormnestAndroid has joined #openttd
08:23:07 *** Progman has joined #openttd
08:23:30 *** jottyfan has joined #openttd
08:57:02 *** jottyfan has quit IRC (Quit: jottyfan)
09:07:42 <peter1138> Hmm, where would a name lookup response for "_gateway" be coming from...
09:08:15 <peter1138> It's not DNS, it's not /etc/hosts, but it's there :/
09:09:55 <LordAro> `dig` should tell you the source?
09:11:10 <peter1138> > nss-myhostname/systemd-resolved will now by default synthesize an A/AAAA resource record for the "_gateway" hostname
09:17:30 *** andythenorth has quit IRC (Quit: andythenorth)
10:28:57 <peter1138> Hmm, is there a linux FTP server that supports virtual hosts?
10:30:22 <peter1138> Hmm, ProFTPD maybe.
11:09:29 <TrueBrain> Funny how often people have mentioned the \r in mixer.cpp, yet nobody ever fixed it.. and everyone is surprised every time :p :p
11:09:39 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on issue #8900: GCC11 complains a lot about -Wmismatched-new-delete https://git.io/JYGSx
11:10:04 <LordAro> vim was complaining at me
11:10:20 <LordAro> iirc there's some files in there that are all \r\n as well? should we fix those too?
11:11:15 <LordAro> hmm, grep isn't finding any
11:14:33 *** WormnestAndroid has quit IRC (Remote host closed the connection)
11:16:48 *** WormnestAndroid has joined #openttd
11:19:11 *** Progman has quit IRC (Remote host closed the connection)
11:22:36 <TrueBrain> From what people have been saying u the past, only mixer.cpp had this issue :D
11:35:07 *** WormnestAndroid has quit IRC (Remote host closed the connection)
11:36:51 *** WormnestAndroid has joined #openttd
11:55:17 <DorpsGek> [OpenTTD/OpenTTD] Milek7 commented on issue #8900: GCC11 complains a lot about -Wmismatched-new-delete https://git.io/JYGSx
12:23:31 <DorpsGek> [OpenTTD/OpenTTD] LordAro opened pull request #9451: Fix potential undefined behaviour when using OverflowSafeInt https://git.io/JWbsL
12:41:42 *** virtualrandomnumber has joined #openttd
12:41:59 *** virtualrandomnumber has quit IRC ()
12:45:34 <Samu> wow, does that mean my company won't suddenly become rich after 500 years of inactivity?
12:46:29 <Samu> not really sure if its 500 years, btw
12:57:06 *** snail_UES_ has joined #openttd
13:00:22 <Rubidium> as long as the amount of settings there is smaller than in OpenTTD, and you still feel like adding a setting to OpenTTD... there are not enough settings there ;)
13:01:14 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on issue #8253: Very large company values are not graphed correctly https://git.io/JJUWy
13:16:35 <Samu> some setting choices are really bad for the AI
13:16:42 <Samu> full load doesn't work too well
13:18:03 <Samu> i tried to make full load an option, but i fail to manage it
13:18:11 <glx> capacity mode and load mode should not be settings at all I think
13:18:38 <TrueBrain> holy crap, 9451 is hard to review
13:18:56 <glx> yeah I don't follow some math :)
13:19:04 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9451: Fix potential undefined behaviour when using OverflowSafeInt https://git.io/JWbEb
13:19:07 <TrueBrain> lets start with some easy observations :)
13:21:09 <TrueBrain> I mainly do not understand why in the += operator, both have to be positive for it to be made T_MAX
13:21:12 <LordAro> though i'd be lying if i said i understood it well
13:21:58 <TrueBrain> guess my question to explain the commit a bit more will be hard in that case :D :D Sorry :P
13:22:08 <glx> I don't get why for +=, <0 + <0 case is so different than -=, <0 - >0
13:22:12 <TrueBrain> we just need unittests for this, tbfh
13:22:13 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #9451: Fix potential undefined behaviour when using OverflowSafeInt https://git.io/JWbzT
13:22:53 <TrueBrain> it is funny, "potential" to me means "we ar enot sure it happens in reality, but we noticed that there is a possibility this might eventually happen sometime" :)
13:22:59 <TrueBrain> but to me it reads someone ran into this :P
13:23:21 <TrueBrain> stupid english words :D
13:23:40 <Samu> in single player, start a company and fast forward, suddenly you become rich
13:23:56 <Samu> suddenly, like... after about 500 or so years in the red
13:24:01 <glx> suddenly requires a lot of time
13:24:24 <LordAro> not so much with a release build and a small map, these days
13:24:27 <TrueBrain> but so the possibility is 100% :D Anyway, not really important :)
13:24:46 <TrueBrain> I really do not understand why left and right have to be > 0 before it becomes T_MAX
13:25:07 <TrueBrain> T_MAX is not the full amount of possible values
13:25:21 <TrueBrain> That is T_MAX - T_MIN
13:25:51 <TrueBrain> what is wrong with making it unsigned internally, and just presenting it by doing -2^61? :P
13:27:33 <TrueBrain> and why don't we use one-compliment ... having T_MIN == -T_MAX would be easier :P
13:27:40 <TrueBrain> compliment? Complement
13:28:26 <glx> but then you'd have +0 and -0
13:36:31 <TrueBrain> I am just godbolting this :P
13:37:29 <TrueBrain> well, found a bug for sure :P
13:37:48 <TrueBrain> now to check if it is my copy/pasting at fault :D
13:38:30 <TrueBrain> okay, that is a broader issue .. lol
13:38:35 <TrueBrain> the OverflowSafeInt32
13:38:41 <TrueBrain> if you substract something from it that is bigger than an int32
13:38:52 <TrueBrain> it is not doing what it should be doing :D
13:39:17 <TrueBrain> but I guess that is a fair constraint
13:41:05 *** ChanServ sets mode: +v tokai
13:41:28 <TrueBrain> INT32_MIN - INT32_MIN != INT32_MIN .. hmm
13:48:01 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
13:50:40 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9451: Fix potential undefined behaviour when using OverflowSafeInt https://git.io/JWb6L
13:54:13 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9451: Fix potential undefined behaviour when using OverflowSafeInt https://git.io/JWbis
13:56:24 <TrueBrain> okay, so that seems to work fine .. we really need unittests :D
14:01:30 <TrueBrain> cannot believe LordAro send us on a math lesson today :P
14:03:24 <jez> anyone got any comments on the issue i raised a few hours ago regarding lumber mills not shutting down when they should/
14:03:55 <jez> ^ why does this change from a 1/2 to a 1/180 chance of an industry closing when there's no production in a smooth economy? i've been debugging my game with a lumber mill whose trees I remove completely, and there's almost no chance it will shut down even though it has zero production.
14:04:36 <nielsm> because smooth economy evaluates every industry more often
14:04:54 *** roadt_ has quit IRC (Ping timeout: 480 seconds)
14:12:03 <nielsm> in original economy, industries don't have monthly production changes, only random production changes
14:12:21 <nielsm> meaning in smooth economy, every month every industry on the map is guaranteed to be evaluated for a production change
14:13:06 <nielsm> so the much lower chance of closure on zero production in smooth economy is to level out the chances
14:23:32 *** gelignite has joined #openttd
14:27:08 *** Xaroth8 is now known as Xaroth
14:30:20 <Samu> i fail at estimating the correct number of ships for a mail route
14:30:38 <Samu> the ship carries 160 bags of mail and is slow
14:31:06 <Samu> because it's slow, i estimate more ships
14:31:28 <Samu> but mail is produced in short quantities for the amount of ships I put there
14:31:39 <Samu> how to counter balance this
14:32:34 <Samu> yes, it does that, but i wanted to avoid getting into that phase
14:33:00 <Zuu> Stop playing the game and write code instead?
14:33:00 <glx> buy vehicle, fill vehicle, go to destination, sell vehicle ;)
14:38:19 <TrueBrain> hmm .. guess we don't have a default window with 3 buttons .. only the yes/no variant we have .. meh :D
14:53:35 <jez> nielsm: as i discussed last night with FLHerne, the idea with that 1 in 180 is that secondary industries very rarely shut down, even if they have no production, because you usually want them to stay around for a while because people haven't gotten round to servicing them
14:54:15 <jez> lumber mills, though, are an exception. in the original game, they shut down when they have few or no trees to produce anything, and they should do so equally in OpenTTD with smooth economy. a 1 in 180 chance of shutting down is way way to low
15:17:13 <TrueBrain> peter1138: could I already draw multilines in a GUI, given the string is like "abc{}def"? I tried WWT_TEXT with "SetMinimalTextLines(2, 0)", but that doesn't seem to work. Or do I still need to do the custom drawing stuff?
15:18:54 <glx> TrueBrain: maybe check how GS can do it
15:19:23 <glx> IIRC they can have multiples buttons in message boxes
15:19:25 <TrueBrain> finding places that do it is not the question ;) But most use a custom drawing routine :)
15:19:45 <TrueBrain> and I remember peter1138 doing something in that area; so just wondering if that was already possible from within the widget system
15:19:49 <TrueBrain> or that I need the custom drawing stuff
15:40:58 <TrueBrain> okay .. that all works .. now all that is left is a setting to store whether you appreciate "relay" services or not
15:42:01 *** Wormnest has joined #openttd
15:55:29 <TrueBrain> lol .. I now have a setting that is neither a dropdown nor a button
15:55:34 <TrueBrain> it is a bit of a hybrid :D
15:57:02 <TrueBrain> I am not really sure why
15:58:53 <TrueBrain> it really is marked as a SF_GUI_DROPDOWN
16:00:31 <TrueBrain> SDTC_VAR vs SDTC_BOOL
16:09:42 <LordAro> needs some more padding
16:09:47 <LordAro> but yes, excellent stuff
16:09:55 <TrueBrain> be careful what you wish for :D
17:25:15 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9447: Feature: allow the use of TURN to connect client and server together https://git.io/JWDeR
17:28:29 *** Progman has joined #openttd
17:30:13 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9447: Feature: allow the use of TURN to connect client and server together https://git.io/JWNaR
17:31:53 <glx> haha the example message is funny TrueBrain
17:31:57 <Samu> i mean, one of my clients
17:32:52 <Samu> WARNING: server only command 53 from client 11 (IP: 95.143.138.51), kicking...
17:33:20 *** jottyfan has joined #openttd
17:33:23 <Samu> what message is this, what is command 53?
17:33:35 <TrueBrain> glx: the localhost part? :)
17:34:05 <glx> yes the localhost part, as if client can't connect, but another thing on the same machine will
17:34:40 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9447: Feature: allow the use of TURN to connect client and server together https://git.io/JWDeR
17:36:08 <DorpsGek> [OpenTTD/py-protocol] TrueBrain updated pull request #13: Feature: support Game Coordinator protocol 5 https://git.io/JW7SF
17:36:43 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain updated pull request #26: Feature: support for Game Coordinator protocol 5 https://git.io/JW79U
17:39:13 <glx> but it's doable only from GUI and disabled for non server
17:40:24 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain opened pull request #27: Cleanup: move local click arguments to the local file https://git.io/JWNwr
17:42:40 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain opened pull request #28: Fix: allow tracking-number zero to be used to stop the connection attempt https://git.io/JWNrU
17:43:21 <glx> same in 1.11.2, it can't happen with unmodified clien
17:45:07 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain opened pull request #29: Codechange: misleading variable names while loading NewGRFs https://git.io/JWNra
17:45:19 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain opened pull request #30: Fix 15ff1891: also publish the "listing" stats https://git.io/JWNrr
17:45:44 <Samu> i could rename a vehicle, and got kicked instantly
17:48:34 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain updated pull request #27: Cleanup: move local click arguments to the local file https://git.io/JWNwr
17:48:48 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain updated pull request #28: Fix: allow tracking-number zero to be used to stop the connection attempt https://git.io/JWNrU
17:49:08 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain updated pull request #29: Codechange: misleading variable names while loading NewGRFs https://git.io/JWNra
17:49:09 <TrueBrain> 4 PRs, 3 of them with a mistake, nice :D
17:49:32 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #27: Cleanup: move local click arguments to the local file https://git.io/JWNwr
17:50:01 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain updated pull request #28: Fix: allow tracking-number zero to be used to stop the connection attempt https://git.io/JWNrU
17:50:04 <TrueBrain> and now merge conflicts that don't exist .. grr @ GitHub :P
17:51:28 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #28: Fix: allow tracking-number zero to be used to stop the connection attempt https://git.io/JWNrU
17:51:43 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain updated pull request #29: Codechange: misleading variable names while loading NewGRFs https://git.io/JWNra
17:53:29 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #29: Codechange: misleading variable names while loading NewGRFs https://git.io/JWNra
17:53:47 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain updated pull request #30: Fix 15ff1891: also publish the "listing" stats https://git.io/JWNrr
17:54:19 <glx> it's disabled on init, but can be enabled on paint
17:59:59 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #30: Fix 15ff1891: also publish the "listing" stats https://git.io/JWNrr
18:00:34 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain updated pull request #26: Feature: support for Game Coordinator protocol 5 https://git.io/JW79U
18:02:17 <TrueBrain> okay .. I think this works ...
18:02:25 <TrueBrain> just still no clue how to deploy it to AWS, not really anyway :D
18:02:45 <DorpsGek> [OpenTTD/py-protocol] TrueBrain merged pull request #13: Feature: support Game Coordinator protocol 5 https://git.io/JW7SF
18:03:17 <TrueBrain> BAM! First "stable" release :)
18:08:12 *** jottyfan has joined #openttd
18:16:29 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #26: Feature: support for Game Coordinator protocol 5 https://git.io/JW79U
18:16:42 <TrueBrain> right ... next job ... getting TURN servers deployed on AWS ..... interesting
18:21:52 *** tokai|noir has joined #openttd
18:21:52 *** ChanServ sets mode: +v tokai|noir
18:26:42 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
18:28:50 *** tokai has quit IRC (Ping timeout: 480 seconds)
18:53:22 <DorpsGek> - Update: Translations from eints (by translators)
18:54:33 *** norri has quit IRC (Quit: Page closed)
19:22:27 *** gelignite has quit IRC (Quit: Stay safe!)
19:34:06 *** jottyfan has quit IRC (Quit: jottyfan)
19:36:34 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain opened pull request #31: Fix 8bddee92: only use TURN when Game Coordinator protocol is 5+ https://git.io/JWNAa
19:37:43 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #31: Fix 8bddee92: only use TURN when Game Coordinator protocol is 5+ https://git.io/JWNAa
19:43:40 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #9451: Fix potential undefined behaviour when using OverflowSafeInt https://git.io/JWNx6
19:44:30 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain opened pull request #32: Codechange: remove now unused variable to track if TURN is attempted https://git.io/JWNxS
19:45:27 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #32: Codechange: remove now unused variable to track if TURN is attempted https://git.io/JWNxS
19:46:12 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #9452: Fix 57734fd: Don't enable rename button for network clients in build vehicle window https://git.io/JWNpJ
19:48:44 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9452: Fix 57734fd: Don't enable rename button for network clients in build vehicle window https://git.io/JWNpE
19:49:03 <TrueBrain> I really appreciate you fixing the capital and dot in the comment glx :D
19:49:42 <glx> oh indeed it's broken again, in another way
19:50:46 <TrueBrain> those function-names always trick me :P
19:50:54 <TrueBrain> they don't only set it to disabled, but set the enable/disable state
19:54:15 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #9452: Fix 57734fd: Don't enable rename button for network clients in build vehicle window https://git.io/JWNpJ
19:55:12 <TrueBrain> forcing TURN is .. not the intended use :D
19:55:43 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #9452: Fix 57734fd: Don't enable rename button for network clients in build vehicle window https://git.io/JWNhg
19:56:02 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9447: Feature: allow the use of TURN to connect client and server together https://git.io/JWDeR
19:56:16 *** nielsm has quit IRC (Ping timeout: 480 seconds)
19:58:29 <Rubidium> TrueBrain / LordAro: TB's asserts could also be made static_asserts and thus a sort of compile time unit test: https://godbolt.org/z/nzbsTGWe5 so we only need a place to put them to have some sort of unit test. We can 'test' the non-builtin variant and builtin variant probably with the exact same code; then GCC/Clang builds test the builtin variant, and MSVC tests the other variant. That should be fine
19:59:14 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #9451: Fix potential undefined behaviour when using OverflowSafeInt https://git.io/JWNjO
20:01:06 <TrueBrain> I see a rabbit-hole forming .. as numeric_limits would be a lot better than this manual min/max :P
20:01:48 <TrueBrain> lol @ script_company.cpp ..why doesn't that just use OverflowSafeInt32 ? :)
20:02:13 <glx> numeric_limits can wait for uint32_t and friends ;)
20:02:39 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #9451: Fix potential undefined behaviour when using OverflowSafeInt https://git.io/JWNj5
20:03:48 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9451: Fix potential undefined behaviour when using OverflowSafeInt https://git.io/JWNjh
20:04:09 <TrueBrain> looking at old code is such a terrible idea :P
20:04:54 <TrueBrain> glx: mind testing TURN, both IPv4 and IPv6? Would require "host" tricks, sadly .. "turn-1.staging.openttd.org" would have to be adjusted to be either IPv4 or IPv6 :)
20:05:02 <TrueBrain> it should "just work", but .. yeah .. famous last words :P
20:07:02 <glx> oh no half the files needs a recompile
20:07:15 <TrueBrain> language changes ..
20:11:03 <TrueBrain> @calc 2 * 60 * 24 * 30
20:11:09 <TrueBrain> 86GB of Redis traffic per month
20:11:17 <TrueBrain> that is a lot :P But it should be fine
20:11:51 <glx> ok ports should be closed
20:13:03 <DorpsGek> - Add: deployment of TURN server (by TrueBrain)
20:17:35 <glx> ok dual stack says via relay
20:17:46 <TrueBrain> now try joining your own server :D
20:18:02 <TrueBrain> server should say it connects to "turn-1.staging.openttd.org", and client should show a fat red warning :)
20:18:29 <TrueBrain> also feel free to try to break it etc, but I am mostly interested if IPv6 works :)
20:19:23 <glx> so "search internet" doesn't work :)
20:20:48 <glx> ah no it works, there's only one server in the list, mine
20:22:03 <Rubidium> TrueBrain: I think the "do you want to use TURN" window stays too short in the lobby. Or rather, the timeout for connecting closes the window before I had time to fully read it
20:22:21 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JWAJY
20:22:24 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed pull request #9017: Feature: play easier together with friends from behind home routers https://git.io/JOk7C
20:22:26 <glx> yeah first time I didn't had enough time to click it
20:22:45 <TrueBrain> Rubidium: there should be ~7 seconds, before it closes
20:22:48 *** andythenorth has joined #openttd
20:23:06 <glx> and it asks once for the lobby window, then again for the real join
20:23:07 <TrueBrain> was it shorter, or is 7 seconds not enough?
20:23:18 <TrueBrain> glx: yup .. there is nothing I can do about that :)
20:23:34 <TrueBrain> it also asks every time you hit "refresh" on a server
20:25:09 <TrueBrain> currently any connection attempt fails after being pending for 10 seconds. The missing of the STUN takes away 2 seconds before you see the TURN message .. normally that would be a lot quicker. So you see that messages now somewhere between 7 and 8 seconds
20:25:18 <TrueBrain> let me know if it is much shorter, and let me know what you think a reasonable value is
20:25:35 <TrueBrain> it cannot be "indefinitely", but 10 seconds is otherwise fully arbitrary :)
20:26:56 <Rubidium> oh, that would be fun connecting IPv4 to an IPv6 server
20:27:06 <TrueBrain> via TURN not a single issue
20:27:53 <TrueBrain> well ... not completely true, if you have a 4to6 gateway in your IPv6, it might work
20:27:56 <TrueBrain> but not in the normal sense
20:28:13 <TrueBrain> STUN in the end connects 2 peers together, so they have to be the same IP protocol
20:28:27 <TrueBrain> TURN on the other hand is terminated on the TURN server, so it can mix and match
20:30:28 <glx> I can see an IPv4 connecting fine on IPv6 only
20:31:09 <TrueBrain> the IPv4 you see there is completely fake btw :P
20:31:19 <TrueBrain> it is injected in OpenTTD at a very late moment
20:31:28 <TrueBrain> just to make sure you can still ban annoying people, even with TURN :D
20:32:08 <TrueBrain> so the connection itself is IPv6, but I fake the other end to be the public IP of the client as the TURN server sees it
20:32:34 <TrueBrain> yeah ... otherwise I am fairly certain we get a lot of complaints about not being able to ban people using TURN :D
20:32:45 <glx> now the hardest test, IPv4 only
20:32:48 <TrueBrain> or people banning all TURN users :D
20:35:48 <TrueBrain> but, opinions about the timeout values?
20:35:59 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain opened pull request #34: Fix: "turn-bytes" and "turn-time" stats are merged into "turn" https://git.io/JWATJ
20:36:54 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #34: Fix: "turn-bytes" and "turn-time" stats are merged into "turn" https://git.io/JWATJ
20:37:32 <TrueBrain> that is not good :)
20:37:50 <glx> just pressed "search internet"
20:38:39 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #9452: Fix 57734fd: Don't enable rename button for network clients in build vehicle window https://git.io/JWNpJ
20:38:55 <TrueBrain> can you reproduce it with a debugger attached? :D
20:39:16 <TrueBrain> or is there a crashlog :)
20:39:43 <glx> decoded stack trace is weird
20:39:59 <TrueBrain> ah, not my fault at least
20:40:34 <TrueBrain> pretty sure there are more bugs in the serverlisting itself
20:40:41 <TrueBrain> it is a bit .. odd, in certain places :)
20:40:59 <TrueBrain> if I would to guess, it removed a server it was rendering, or updated it, or something
20:41:42 <glx> probably as my server was not fully started yet
20:41:52 <glx> but it was still in the list
20:42:51 <TrueBrain> possibly best to make it an issue on GitHub, so we don't forget to pick it up some day :)
20:43:17 <glx> call stack added to the gist for now
20:44:10 <glx> + s 0xdddddddddddddddd <Erreur durant la lecture des caractères de la chaîne.> const char *
20:44:30 <TrueBrain> yeah, so for sure not related to the current PR :)
20:44:59 <TrueBrain> would be fun to reproduce :P
20:45:08 <TrueBrain> as I think it is very difficult to do so :D
20:50:07 <glx> ok it was drawing last_joined line
20:52:36 <glx> and I guess this->last_joined->info.server_name disappeared at some point, and as the drawing uses c_str() at some point
20:52:57 <glx> won't be easy to reproduce
20:53:27 <TrueBrain> meh, Game Coordinator still has a memory issue ..
20:53:50 <TrueBrain> it is not releasing something .....
20:54:00 <glx> anyway let's restart a client to join the IPv4 only test
20:59:35 <TrueBrain> you think this popup about relaying is clear to users?
21:09:39 *** Samu has quit IRC (Quit: Leaving)
21:19:13 *** andythenorth has quit IRC (Quit: andythenorth)
21:19:22 <glx> only possible cause for the crash I can see is drawing happenning in the middle of NetworkGameListRemoveItem() or NetworkGameListRemoveExpired(), between delete and UpdateNetworkGameWindow()
21:19:40 <glx> but I don't know if it's really possible
21:24:14 <glx> can't be NetworkGameListRemoveItem() (it's called only from key press handler)
21:42:35 *** sla_ro|master has quit IRC ()
21:56:25 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
22:05:35 *** Gustavo6046 has quit IRC (Ping timeout: 480 seconds)
22:11:53 *** Gustavo6046 has joined #openttd
22:43:57 *** Gustavo6046_ has joined #openttd
22:48:10 *** Progman has quit IRC (Remote host closed the connection)
22:48:55 *** Gustavo6046 has quit IRC (Ping timeout: 480 seconds)
22:48:55 *** Gustavo6046_ is now known as Gustavo6046
22:57:31 *** ChanServ sets mode: +v tokai
23:04:15 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
23:48:18 *** ioangogo_ has joined #openttd
23:51:39 *** ioangogo has quit IRC (Ping timeout: 480 seconds)
continue to next day ⏵
