IRC logs for #openttd on OFTC at 2021-03-13
⏴ go to previous day
00:28:53 *** Flygon_ has joined #openttd
00:33:21 *** Flygon__ has joined #openttd
00:35:44 *** Flygon has quit IRC (Ping timeout: 480 seconds)
00:40:14 *** Flygon_ has quit IRC (Ping timeout: 480 seconds)
00:43:43 *** Flygon__ has quit IRC (Ping timeout: 480 seconds)
01:01:23 *** Flygon_ has joined #openttd
01:07:26 *** Progman has quit IRC (Remote host closed the connection)
01:08:13 *** Flygon has quit IRC (Ping timeout: 480 seconds)
02:05:53 *** Flygon__ has joined #openttd
02:12:44 *** Flygon_ has quit IRC (Ping timeout: 480 seconds)
02:46:48 *** nielsm has quit IRC (Ping timeout: 480 seconds)
02:51:40 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
03:04:40 *** Wormnest has quit IRC (Quit: Leaving)
03:07:00 *** Tirili has quit IRC (Quit: Leaving)
03:11:22 *** Flygon_ has joined #openttd
03:18:14 *** Flygon__ has quit IRC (Ping timeout: 480 seconds)
03:22:13 *** Flygon_ has quit IRC (Ping timeout: 480 seconds)
03:29:22 *** Flygon_ has joined #openttd
03:36:14 *** Flygon has quit IRC (Ping timeout: 480 seconds)
03:49:53 *** Flygon__ has joined #openttd
03:55:45 *** debdog has quit IRC (Ping timeout: 480 seconds)
03:56:44 *** Flygon_ has quit IRC (Ping timeout: 480 seconds)
04:09:22 *** Flygon_ has joined #openttd
04:16:14 *** Flygon__ has quit IRC (Ping timeout: 480 seconds)
04:40:49 <Wuzzy> Yay, OpenSFX 1.0.0 is officially out! Now with actually libre sounds, OpenSFX is now 100% libre! 😀
04:41:11 <Wuzzy> I'm so happy it is finally done!! 🙂
04:42:58 <Wuzzy> orudge: by the way, since OpenSFX is the official sound pack, and it's version 1.0.0, would it make sense to make an official announcement on the www.openttd.org news page?
04:43:22 *** Flygon__ has joined #openttd
04:44:03 <Wuzzy> Also, I just tested the addon from BaNaNaS, it works great, exactly as i expected. No issues found. Good clean release. 🙂
04:50:14 *** Flygon_ has quit IRC (Ping timeout: 480 seconds)
04:56:14 *** Flygon__ has quit IRC (Ping timeout: 480 seconds)
05:02:07 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
05:04:49 *** Wuzzy has quit IRC (Remote host closed the connection)
05:15:17 *** snail_UES_ has quit IRC (Quit: snail_UES_)
06:51:08 *** andythenorth has joined #openttd
07:21:35 *** andythenorth has quit IRC (Quit: andythenorth)
07:28:46 *** andythenorth has joined #openttd
08:04:51 *** J0anJosep has joined #openttd
08:40:07 *** sla_ro|master has joined #openttd
08:44:45 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #8852: Fix "exec" call depth and "exec" never returning to script https://git.io/JqCwT
08:45:45 <TrueBrain> LordAro: you used just few enough words that I do not understand you :D
08:45:50 <TrueBrain> you mean renaming of the variable?
08:46:29 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #8845: Feature: zstandard compression for network games https://git.io/JqnwH
08:47:03 <LordAro> TrueBrain: as in not a global
08:47:26 <TrueBrain> where would I store the variable that 2 functions can alter them? (honest question, to be clear)
08:47:36 <TrueBrain> I hate that so many questions on IRC can be read completely sarcastic :D
08:48:02 <LordAro> shows how closely i looked at it :p
08:48:16 <TrueBrain> :D I tried to point this out in various of places :P
08:48:20 <TrueBrain> DEF_CONSOLE_CMD(ConReturn) allows early-returns
08:48:33 <TrueBrain> but renaming the variable is a good idea
08:52:10 <andythenorth> why is writing guards (validators of input data) so satisfying?
08:52:11 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #8852: Fix "exec" call depth and "exec" never returning to script https://git.io/JqczS
08:52:34 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8852: Fix "exec" call depth and "exec" never returning to script https://git.io/JqCwG
08:54:16 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8604: Feature: allow limiting zoom level of NewGRF-provided sprites https://git.io/JqCwZ
08:54:37 <TrueBrain> did you just approve a PR that was already approved? :P
08:56:16 <LordAro> can you have a read through of ^ to check i've not missesd anything?
08:56:47 <TrueBrain> I understand 10% of these kind of PRs, but I can look for silly stuff :D
08:58:07 <TrueBrain> the commit message mostly feels a bit odd
08:58:14 <TrueBrain> Feature: rail station class name filtering
08:58:24 <TrueBrain> wouldn't do well in changelogs
08:58:43 <TrueBrain> "Feature: allow filtering in rail station window" ?
08:58:45 <LordAro> i was thinking to merge all 3 filtering things into one
08:59:07 <LordAro> regardless, commit message doesn't necessarily correspond to changelog entry
08:59:18 <LordAro> it should be a good commit message, changelog considerations are secondary :)
08:59:42 <TrueBrain> fully agree; it still is a poor commit message :P
09:00:19 <TrueBrain> I just change it into my suggestion and merge it, fine? :)
09:00:57 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8604: Feature: allow limiting zoom level of NewGRF-provided sprites https://git.io/JtsF7
09:01:08 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8852: Fix "exec" call depth and "exec" never returning to script https://git.io/JqczS
09:01:11 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed issue #8851: Console command "exec" can stack overflow and crash (bypassing crash handler) https://git.io/Jqcum
09:01:29 <TrueBrain> 1 left for 1.11 and RC1, I think .. and I can understand if we do not do that for 1.11 btw
09:02:19 <TrueBrain> wauw, #8854 seems to be originally a REALLY old savegame
09:02:24 <TrueBrain> Conversion from OTTD savegame without gamelog: version 4, 1
09:02:40 <TrueBrain> 4.1 is 0.3.3 / 0.3.4
09:03:42 <LordAro> add it to the list of savegames to use for testing :)
09:06:35 <TrueBrain> own, no, I was wrong
09:06:39 <TrueBrain> I was reading the gamelog wrong
09:06:42 <TrueBrain> it is one from 1.3.0 :P
09:07:09 <TrueBrain> I remember stadiums being an issue in the old days
09:08:19 <TrueBrain> I love how much the gamelog rats out what happened to a savegame :P
09:10:01 <LordAro> should keep an eye on #8794 for 1.11 as well
09:10:06 <LordAro> if it gets updated in time
09:10:13 <LordAro> shouldn't block though
09:10:22 <_dp_> interesting, I had 3 newgrfs missing in that save and stadiums were fine before I downloaded them
09:10:34 <_dp_> probably this one is the culprit tai_uk_houses-gamma1\tai_uk.grf
09:10:46 <TrueBrain> LordAro: we can always backport that
09:10:58 <TrueBrain> it is not really a "feature" as such
09:15:55 <TrueBrain> hmm, annoying, it is not easy to generate a new map based on the NewGRFs of a save, it seems :P
09:16:02 <TrueBrain> "restart" doesn't keep NewGRF settings
09:16:04 *** HerzogDeXtEr has joined #openttd
09:16:11 <TrueBrain> another "bug" with that new "restart" command :P
09:19:48 <_dp_> it feels like uk houses were added after mapgen, all towns use normal houses and only start replacing them if grown
09:20:18 <_dp_> and removing uk houses fixes the stadiums
09:21:18 <andythenorth> so don't add newgrf to running saves?
09:22:57 * andythenorth running a game on FFWD
09:23:05 <andythenorth> so much easier to sample now
09:23:12 <andythenorth> 50 years in 1 minute
09:24:07 <_dp_> well, it could be some conversion that un-grfed them I guess
09:30:41 *** Gustavo6046_ has joined #openttd
09:32:17 *** Gustavo6046 has quit IRC (Read error: Connection reset by peer)
09:32:17 *** Gustavo6046_ is now known as Gustavo6046
09:38:40 <TrueBrain> right, I should add OpenSFX 1.0.0 to the installers now I guess
09:39:31 <TrueBrain> I forgot how annoying it was :P
09:39:37 <TrueBrain> do we still offer it with new NSIS?
09:40:30 <TrueBrain> we let bootstrap do it
09:40:35 <TrueBrain> so .. I do not have to do anything :D
09:41:44 <andythenorth> no broken stadiums in my test game after 110 years of FFWD
09:41:50 <andythenorth> they have built and rebuilt a few times :P
09:42:19 <andythenorth> funny when they get replaced on same spot with same sprites
09:44:19 <TrueBrain> andythenorth: with that GRF, stadiums will never be build :P They are disabled because the game detected a size-mismatch :)
09:44:37 <andythenorth> I am just testing base game, no grf
09:44:57 <andythenorth> 'testing' is a strong word
09:45:11 <andythenorth> I haven't read the issue properly, I'm just running the game on FFWD while I list things on ebay for sale
09:46:27 <andythenorth> I will look in a bit
09:46:46 <andythenorth> I get a flash of black-red vertical lines on startup I think
09:46:50 * andythenorth was ignoring those
09:47:20 <TrueBrain> there is nothing for you to do here andythenorth
09:47:27 <TrueBrain> it is a duplicate of a bug we already fixed
09:47:58 <andythenorth> you already closed the feature request also :)
09:47:58 <TrueBrain> I am just being nice about it to the reporter :)
09:48:13 <TrueBrain> yeah, you weren't doing it :P :P
09:48:16 <andythenorth> I was going to close the feature request when I had fixed my attitude to 'people' :D
09:48:30 <TrueBrain> I couldn't wait 2 years <3
09:49:50 <_dp_> on my laptop openttd window shows some junk for a few seconds when started
09:52:30 <LordAro> game is still quite inefficient in that area, even if you can no longer make such chains
09:52:36 <LordAro> doesn't help existing broken games either
09:52:40 <TrueBrain> fully agree, hence the question :D
09:52:51 <LordAro> i don't think it's ready to be closed, anyway
09:53:21 <TrueBrain> there are always 2 ways to solve an issue .. make sure it can never happen again, or fix the issue :)
09:53:35 <TrueBrain> we did the first .. doing the second would be nice, but is a bit more optional :)
09:54:17 <TrueBrain> (as in the end, we will always have some upper-limit)
10:01:21 <LordAro> think you might need to full log, not just "relevant log messages"
10:06:09 <TrueBrain> LordAro: true; but it is weird either way :P
10:07:44 <LordAro> honestly, TrueBrain, you didn't think to test "download dir is a broken symlink" ? :p
10:07:56 <TrueBrain> LordAro: I feel bad :( I should have! :P
10:08:35 <TrueBrain> it really hangs if it cannot write in the folder
10:09:01 <LordAro> sounds like someone forgot to check a return value
10:09:13 <TrueBrain> or implement an OnError or something
10:12:22 <TrueBrain> bootstrap cannot show errors :)
10:12:43 <TrueBrain> so it is trying to show an error, but .. it just never pops up :D
10:14:09 <TrueBrain> not sure why they do not show up ..
10:17:20 <TrueBrain> if (_settings_client.gui.errmsg_duration == 0 && !no_timeout) return;
10:18:05 <TrueBrain> errors are not shown if the error message duration is 0
10:18:09 <TrueBrain> and as no config is loaded
10:18:12 <TrueBrain> that whole struct is zero
10:18:15 *** Progman has joined #openttd
10:18:44 <TrueBrain> ah, we cannot show an error message
10:18:51 <TrueBrain> so by accident, this works currently :P
10:19:01 <TrueBrain> the error window uses a sprite
10:19:03 <LordAro> mm, would have to be a console error only
10:19:04 <TrueBrain> which is not available :D
10:21:30 <TrueBrain> or, we let the bootstrap show the errors in a window that does not use those sprites
10:21:45 <TrueBrain> would allow to give additional instructions, I guess
10:40:38 <TrueBrain> that moment a window is already destroyed, making sure a callback is never called, before you can handle the error yourself
10:52:11 <michi_cc> nielsm: Apparently your tree shading hack is included in JGR now. Any chance to get that as a PR for OTTD proper, especially since almost everybody should run a 32bpp blitter by default now.
10:53:40 <michi_cc> TrueBrain: So bootstrap would need to use ShowOSErrorBox instead?
10:54:01 <TrueBrain> I am just facepalming at code
11:00:21 *** Samu has quit IRC (Read error: Connection reset by peer)
11:12:45 <TrueBrain> lol .. next problem: window is deleted before the error is queued .. grrrr :P
11:20:42 *** Compu has quit IRC (Remote host closed the connection)
11:37:46 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #8856: Fix: if boostrap failed, it could end with an empty screen instead of error https://git.io/JqC6D
11:38:18 <TrueBrain> silly humans thinking we write these error message for nothing (regarding #8854) :D
11:39:03 <TrueBrain> right, a really simple fix for the booostrap issue
11:39:09 <TrueBrain> that should at least be a bit more clear
11:39:52 <TrueBrain> LordAro: so what do we do with zstd? :D I made the PR as small as I could, but it is not a super easy review ..
11:40:02 <TrueBrain> (I mainly ask as I would like to make an RC1 today / tomorrow)
11:40:09 <_dp_> add a capcha for changing newgrfs
11:40:14 <_dp_> with newgrf dev questions :p
11:44:45 <andythenorth> 'type grfid here'
11:46:09 <_dp_> or a warning on game load that newgrfs were changed
11:52:30 <andythenorth> patch the UI colours so that all windows use the red-black colour cycle in the palette
12:07:54 <TrueBrain> "Current Outstanding Wishes 23,684"
12:09:07 <Eddi|zuHause> that sounds like a lie
12:16:09 <DorpsGek> [OpenTTD/OpenMSX] Wuzzy2 dismissed a review for pull request #7: Replace outdated Mercurial stuff, update README https://git.io/JtrB0
12:42:33 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #8856: Fix: if boostrap failed, it could end with an empty screen instead of error https://git.io/JqCP7
12:43:57 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #8856: Fix: if boostrap failed, it could end with an empty screen instead of error https://git.io/JqC6D
12:45:03 *** sla_ro|master has quit IRC ()
12:45:24 *** frosch123 has joined #openttd
12:53:38 <TrueBrain> something broke! :P
12:54:21 <TrueBrain> Certificate verification failed: The certificate is NOT trusted. The received OCSP status response is invalid. Could not handshake: Error in the certificate verification. [IP: 195.135.221.134 443]
12:54:25 <TrueBrain> that doesn't sound good :P
12:54:49 <TrueBrain> a GitHub Actions issue btw, not ours
13:02:05 <supermop_Home> thanks frosch123 and TrueBrain, catenary works better now
13:02:06 *** jottyfan has joined #openttd
13:03:04 <supermop_Home> though oddly enough on some slopes the rear catenary is kinda weird now
13:23:10 <Eddi|zuHause> supermop_Home: common problem with sprite order, if you fix one case, you break another
13:26:41 <frosch123> supermop_Home: it should work also for slopes, but i did not test it too well with foundations
13:26:56 <frosch123> so, when you have an example, i can have a look a again
13:27:36 <supermop_Home> frosch123 yeah, the center portion of the rear sprite seems missing on foundations, only for the slopes that slope away from the camera
13:33:19 <supermop_Home> its not noticeable with regular trams because they don't use the rear catenary for anything in the middle, its only my silly cheat that has the issue
13:51:26 <LordAro> TrueBrain: also, "boostrap"
13:52:05 <LordAro> Wuzzy: you don't need a corresponding issue for every PR
13:52:09 <LordAro> especially when they're not even linked
13:53:07 <Wuzzy> it just felt more complete to me, lol
13:53:20 <LordAro> well open the issue first then, if you must
13:53:30 <LordAro> and link them with Fix #<N>, etc
13:54:02 <Wuzzy> it was a good change that the sound_types.h was upgraded
13:54:11 <Wuzzy> the sound internal names make so much more sense now
13:54:38 <Wuzzy> I think the "train in tunnel" sound name is now misleading, however
13:54:54 <Wuzzy> from the code it is clear that this sound is really only allowed for steam trains
13:55:07 <Wuzzy> but otherwise, sound_types.h looks great now
13:56:13 <Wuzzy> anyway, i try to keep the GitHub spam lower next time 😉
13:59:06 <DorpsGek> [OpenTTD/OpenTTD] Wuzzy2 opened issue #8857: Clarify that SND_05_TRAIN_THROUGH_TUNNEL is for steam trains only https://git.io/JqCyd
14:07:59 <TrueBrain> LordAro: nothing wrong with boo strapping ..
14:08:08 <TrueBrain> funny enough, I am not the first to make that typo
14:09:29 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #8856: Fix: if bootstrap failed, it could end with an empty screen instead of error https://git.io/JqC6D
14:42:07 <TrueBrain> I wonder if we should add Sentry to OpenTTD, optionally of course, to automatically report crashes
14:42:26 <TrueBrain> I was looking at OpenRCT2 .. their application crashes a lot, by the looks of it :P
14:42:37 <TrueBrain> I -think- OpenTTD doesn't crash a lot
14:42:40 <TrueBrain> but I don't really know :P
14:43:11 <Eddi|zuHause> so you test more, then the crashes go up?
14:45:54 <TrueBrain> awh, requires libcurl for most OSes .. (Windows can use winhttp)
15:08:47 *** J0anJosep has quit IRC (Quit: Konversation terminated!)
15:31:18 <LordAro> Eddi|zuHause: MOTTDGA ?
15:31:34 <LordAro> TrueBrain: tbf, if the system does any sort of http, it's probably already got curl installed
15:36:10 <LordAro> TrueBrain: survey does sound sort of fun
15:36:30 <LordAro> though with all of these things, getting it spread properly is the challenge
15:37:56 <Eddi|zuHause> aside of all the data protection stuff, the main problem with automatic reporting is that at some point, someone has to go through it all and try to identify duplicates and interesting stuff
15:39:53 *** Marco has quit IRC (Remote host closed the connection)
15:42:22 <frosch123> factorio did that automatically. they extracted backtraces and then checked which code places/patterns crash most often
15:43:05 <frosch123> there is probably some fff about it
15:43:46 <andythenorth> just use it as telemetry for correlating with reports
15:45:34 <milek7> I guess sentry does that too
15:53:26 <andythenorth> sentry for newgrf pls
16:03:20 <TrueBrain> LordAro: yeah .. guess for 1.12 we need to look in libcurl, one way or the other :P
16:03:41 <TrueBrain> and indeed, Sentry deduplicates based on backtrace; we already use that for all our Python applications, and it does that rather well :D
16:04:23 <TrueBrain> Sentry even tells you if things are a regression of earlier versions etc .. really painful :P
16:15:47 *** snail_UES_ has joined #openttd
16:19:19 *** Wormnest has joined #openttd
16:20:26 *** jottyfan has quit IRC (Quit: jottyfan)
16:40:24 *** jottyfan has joined #openttd
17:02:26 <Marco> Hi there, I have a question regarding the building/compiling of OpenTTD. However such a question doesn't really fit in the Contribution Guidlines of the GitHub Issue Tracker and also doesn't fit into the Posting Rules of the Development-Forums. Where do I ask it then? :D
17:02:33 <Marco> I'm currently ignoring the fact, that such questions are present on both platforms. Just going straigt by the rules I don't really know where to post it.
17:03:12 *** J0anJosep has joined #openttd
17:03:47 <TrueBrain> Here, would be fine
17:08:35 * LordAro waits in anticipation
17:09:24 <Marco> I was trying to get OpenTTD get setup on Windows using Visual Studio 2019. However I ran into issues regarding strgen. If I run "Build-All" everything is running successful. However afterwards I still get errors about table/strings.h not being found. Am I just supposed to ignore the errors or is
17:09:25 *** sla_ro|master has joined #openttd
17:09:33 <Marco> something not running as it should?
17:10:10 <Marco> The files get properly generated in out/generated. However the Code is looking for them in src/table
17:10:55 <Marco> If I just run "strgen.exe" I get "(unknown file) (0): warning: Could not open .\english.txt (FATAL)" and "(unknown file) (0): warning: language is not compiled (warning)"
17:11:26 <Eddi|zuHause> no, strgen must be run with the correct files as parameters
17:11:46 <Eddi|zuHause> there's probably a path not correctly set up
17:12:04 <Eddi|zuHause> although i have no visual studio, so i can't help you
17:12:53 <Marco> Knowing this helps already :D So I keep searching which path went wrong
17:14:31 <LordAro> sounds very odd, cmake should handle all that stuff for you
17:15:38 * LordAro also cannot help in any great detail, for the same reasons
17:20:02 <Marco> Damn. Thanks anyway for offering help
17:33:12 <LordAro> i'd recommend cleaning it all out and starting from scratch :p
17:36:17 <Marco> I was following it down to a tee actually.
17:37:05 <LordAro> well, improvements are always welcome
17:37:15 <LordAro> but we'd have to know what's gone wrong first :p
17:37:30 <Marco> Thats correct I guess :D
17:39:21 <Marco> But currently I'm more inclined to switch to my Unix system and get it running there. Its for sure some default path deep in VS.
17:59:33 <TrueBrain> LordAro: should the changelog for RC1 mention stuff that is introduced in 1.11, noticed in any of the betas and now fixed?
17:59:39 <TrueBrain> or only focus on what is changed/fixed against 1.10?
18:00:04 <LordAro> TrueBrain: any released version
18:00:20 <TrueBrain> so also prereleases? :D
18:00:22 <michi_cc> Hmm, for those that tested one of the betas, the change from them would certainly be interesting.
18:00:39 <LordAro> yes, also prereleases
18:00:42 <TrueBrain> I know people always debate these kind of things, so better ask :D
18:04:11 <snail_UES_> ok, I just compiled the new version of JGRPP (0.40.4)
18:04:32 <snail_UES_> it runs fine, but the resolution seems to have doubled… all the windows, buttons etc. are now half the size as before
18:04:40 <snail_UES_> I wonder what caused this?
18:04:57 <LordAro> snail_UES_: we don't support JGRPP ;)
18:05:07 <LordAro> but i can tell you now that's not a JGR change
18:05:15 <michi_cc> We do support Retina now, though :)
18:05:19 <snail_UES_> is it an OTTD change?
18:05:31 <michi_cc> Just up the GUI and font zoom in the settings.
18:05:35 <LordAro> change gui/font size to "auto"
18:05:42 <snail_UES_> alright, let me try...
18:10:10 <snail_UES_> I had to play with it for a while, but now it workd. Thanks! :)
18:11:21 <LordAro> TrueBrain: urgh, oh dear
18:11:33 <TrueBrain> its now part of history :P
18:20:30 <LordAro> rewrite the master branch!
18:21:50 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened pull request #8858: Doc: Clarify comment that SND_05_TRAIN_THROUGH_TUNNEL is only for ste… https://git.io/JqChW
18:22:40 <TrueBrain> I did my best LordAro , but I am sure you would have done better :D Damn, that is annoyingly difficult :P
18:23:39 <TrueBrain> as I mentioned in that PR, I think that if nobody reviewed #8845 by tomorrow, we should bump it to 1.12 and continue with RC1 / feature-freeze honestly
18:23:53 <TrueBrain> it really is a nice-to-have, but nothing that cannot wait
18:24:08 <TrueBrain> we can always backport it if we really want to
18:26:48 <andythenorth> snail_UES_ do you have a retina mac?
18:26:58 <TrueBrain> we did 18 bugfixes in the last 2 weeks
18:27:01 <TrueBrain> that .. is impressive :P
18:35:34 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8654: Fix: [Emscripten] Only lock pointer on right click https://git.io/JqCjv
18:35:37 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed pull request #8654: Fix: [Emscripten] Only lock pointer on right click https://git.io/JtVsC
18:36:03 <DorpsGek> [OpenTTD/OpenTTD] perezdidac commented on pull request #8794: Feature: Show rail/road/tram NewGRF name in Land Area Information window https://git.io/JqCjf
18:36:58 <TrueBrain> tnx michi_cc ; sometimes hard to remember those things :P
18:37:25 <snail_UES_> andythenorth: yes, it’s a late 2013 15-inch macbook pro
18:41:10 <glx> Marco: it's strange, cmake should handle everything correctly (it does for me)
18:42:08 <glx> Marco: are you opening folder in VS or you generated VS project file with cmake then opened it in VS ?
18:43:29 <peter1138> I had to tell VS Code (not using VS) what the correct build directory is.
18:44:36 <peter1138> set_target_properties(openttd PROPERTIES VS_DEBUGGER_WORKING_DIRECTORY "${CMAKE_SOURCE_DIR}/bin")
18:45:01 <glx> but that's only to run openttd.exe in debug IIRC
18:45:04 <peter1138> And that felt wrong but isn't used in my case anyway.
18:45:41 <glx> (and it works fine only with Ninja)
18:45:51 <peter1138> I thought working directory would be CMAKE_BINARY_DIR
18:47:30 <glx> would probably be better but then we need to copyai/gs compatibility files I think
18:48:28 <glx> anyway table/strings.h is unrelated ;)
18:50:19 <LordAro> TrueBrain: github has an annotation on the commit for the first (and last) release that contains it, can be helpful in these cases (though you do have to click through several things)
18:50:44 <TrueBrain> LordAro: yeah .. I did for those I was not sure about
18:51:00 <TrueBrain> also a good way to find the PR that introduced the commit :)
18:52:08 <andythenorth> snail_UES_ I disabled retina support on my OpenTTD, the performance was poor
18:52:14 <andythenorth> there's a .cfg line for it
18:52:27 <DorpsGek> [OpenTTD/OpenTTD] perezdidac updated pull request #8794: Feature: Show rail/road/tram NewGRF name in Land Area Information window https://git.io/JthCX
18:52:53 <DorpsGek> [OpenTTD/OpenTTD] perezdidac commented on pull request #8794: Feature: Show rail/road/tram NewGRF name in Land Area Information window https://git.io/JqWef
18:54:56 <andythenorth> hmm retina really nulls the recent performance improvement
18:55:09 <andythenorth> FFWD speed with hidpi = true is about 1.5x game factor
18:56:34 <snail_UES_> andythenorth: interesting. Right now I’m just running some tests for my future set. I’m not really playing a game with an intensive rail network… so I don’t experience performance issues
18:56:37 <andythenorth> if I turn off hardware acceleration (to match default setting), game speed factor on FFWD is about 1.04x
18:56:53 <snail_UES_> btw now I can compile JGRPP again :)
18:58:13 <TrueBrain> I will promote RC1 on Steam to "default" branch; not that many people will see that, but it is needed to make the checklist of Steam happy :P
18:58:50 <TrueBrain> also means that if Steam opens the game too early or what-ever, people at least get a version that is almost the same as release, instead of 1.10 :D
18:59:02 * andythenorth wonders what has changed recently that has caused performance to regress so much on mac
18:59:25 <TrueBrain> michi_cc: I hate that in the last month you added more to OpenTTD than I have :P
18:59:35 <andythenorth> it's not just the retina switch, performance has dropped 20-50%
18:59:41 <TrueBrain> 107 commits vs 82 :P
18:59:59 <TrueBrain> it is a bit sad that translators are #3 :P
19:00:43 <andythenorth> my previous build was 21st Feb
19:01:09 <michi_cc> TrueBrain: Just means I broke more of OTTD than you :P
19:01:53 <andythenorth> we might want some changelog notes specific to mac users?
19:03:07 <DorpsGek> - Update: Translations from eints (by translators)
19:04:17 <TrueBrain> andythenorth: sure, we can make a changelog in a bigger font for them
19:04:19 <TrueBrain> not sure if it helps
19:04:50 <andythenorth> we could use "LOL" as the title
19:05:02 <TrueBrain> just to be clear, you suggestion was a bit .. vague, at best :P
19:05:12 <andythenorth> I'm compiling a list
19:05:27 <andythenorth> I got lost in why performance has dropped since last weekend
19:05:40 <TrueBrain> but in general, I wouldn't know why users of one OS would be more special than the rest
19:06:47 <andythenorth> do we know what any results for hardware acceleration performance gain / loss on other platforms?
19:10:41 <TrueBrain> right, everything for RC1 prepared, I think ..
19:10:47 <TrueBrain> just a matter of pressing buttons after reviews :D
19:12:50 <DorpsGek> [OpenTTD/BaNaNaS] TrueBrain merged pull request #85: Hide some obsolete GRFs from the content download list https://git.io/JqcTn
19:14:46 <TrueBrain> sorry I didn't see earlier
19:14:51 <DorpsGek> [OpenTTD/OpenTTD] JGRennison opened issue #8860: Windows: wrong stack pointer for crash log dialog window on non-main thread https://git.io/JqWvg
19:16:45 <TrueBrain> another reason to use Sentry, means we don't have to worry about these things ^^ :P
19:17:59 <TrueBrain> who of us knows enough about the crashlog stuff to give any value to JGR's commit? :D
19:20:59 <TrueBrain> otherwise we might want to YOLO-accept it, honestly :)
19:21:13 <TrueBrain> michi_cc? frosch123 ? By any chance? :D
19:30:39 <TrueBrain> just leaving this here
19:30:59 <TrueBrain> something for your livestream andythenorth
19:34:41 <J0anJosep> Nice, but now I want that included for next release...
19:38:29 *** didac has quit IRC (Remote host closed the connection)
19:42:42 *** jottyfan has quit IRC (Quit: jottyfan)
19:47:02 *** WormnestAndroid has quit IRC (Remote host closed the connection)
19:47:15 *** WormnestAndroid has joined #openttd
19:56:42 <michi_cc> TrueBrain: I could imagine capturing the stack pointer in a threadlocal upon each thread start. Will have to test that first, though.
19:57:19 <TrueBrain> that sounds like a solid idea :D
19:57:36 <TrueBrain> I did not know we had such a hack on the Windows crashlog code :P
19:59:21 <TrueBrain> for something we need to fix for 1.11 .. pretty sure most crashes are going to come from a thread now :D
20:00:54 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
20:01:07 *** WormnestAndroid has joined #openttd
20:01:20 *** jottyfan has joined #openttd
20:09:39 *** ChanServ sets mode: +v planetmaker
20:09:39 *** ChanServ sets mode: +o orudge
20:23:48 <Gustavo6046> Are train collisions handled as hitboxes or?
20:23:58 <Gustavo6046> I assume just segments of the length of the tracks they're in
20:24:37 *** jottyfan has quit IRC (Quit: jottyfan)
20:26:53 *** ChanServ sets mode: +v orudge
20:42:53 <DorpsGek> [OpenTTD/OpenTTD] michicc opened pull request #8861: Fix #8860: [Win32] Crashlog window wasn't reliably shown for crashes. https://git.io/JqWTr
20:46:48 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8861: Fix #8860: [Win32] Crashlog window wasn't reliably shown for crashes. https://git.io/JqWT9
20:46:59 <TrueBrain> nice solution michi_cc :)
20:47:04 <glx> michi_cc: would it be possible to indent preprocessor stuff ?
20:47:14 <glx> while you are in the area
20:49:04 *** gelignite has joined #openttd
20:50:25 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #8861: Fix #8860: [Win32] Crashlog window wasn't reliably shown for crashes. https://git.io/JqWTj
20:51:23 <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #8861: Fix #8860: [Win32] Crashlog window wasn't reliably shown for crashes. https://git.io/JqWTr
20:51:38 <michi_cc> glx: Not sure the preprocesser reads that much better this way, but there you go.
20:52:02 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #8861: Fix #8860: [Win32] Crashlog window wasn't reliably shown for crashes. https://git.io/JqWkk
20:52:29 <glx> at least it's easy to see matching if and endif
20:55:31 <LordAro> michi_cc: is that @note necessary?
20:55:44 <LordAro> surely it'll fail compile if it doesn't
20:55:47 <TrueBrain> past-us thought it was :P
21:09:09 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #8861: Fix #8860: [Win32] Crashlog window wasn't reliably shown for crashes. https://git.io/JqWTr
21:09:12 <DorpsGek> [OpenTTD/OpenTTD] michicc closed issue #8860: Windows: wrong stack pointer for crash log dialog window on non-main thread https://git.io/JqWvg
21:20:28 * andythenorth considers a tropical islands economy for FIRS
21:22:52 *** J0anJosep has quit IRC (Quit: Konversation terminated!)
21:23:10 <andythenorth> not much depth in the production chains though eh
21:28:59 <frosch123> that's its strength, isn't it?
21:29:17 <frosch123> otherwise all economies would be the same
21:29:38 <andythenorth> glx discord report, this_month_production("WDPR") is being evaluated as a function (I think)
21:30:14 <glx> it is a function, a built-in function
21:30:41 <andythenorth> I'll ask Chris what 'latest' means
21:31:00 <andythenorth> 40+ years of life experience, and now I'm acting as an irc-discord bridge :p
21:31:03 <andythenorth> good use of skills
21:35:17 <michi_cc> And glx is even on Discord :D
21:37:06 <glx> BTW this_month_production exists since nml 0.5
21:58:03 *** andythenorth has quit IRC (Quit: andythenorth)
22:20:38 *** jottyfan has joined #openttd
23:12:16 *** frosch123 has quit IRC (Quit: be yourself, except: if you have the opportunity to be a unicorn, then be a unicorn)
23:59:13 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
continue to next day ⏵
