IRC logs for #openttd on OFTC at 2021-02-11
⏴ go to previous day
00:03:46 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
00:08:35 *** moll has quit IRC (Ping timeout: 480 seconds)
00:12:40 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
00:27:05 *** Westie has quit IRC (Ping timeout: 480 seconds)
01:48:31 *** Wormnest has quit IRC (Read error: Connection reset by peer)
01:48:55 *** Wormnest has joined #openttd
03:11:03 *** Wormnest has quit IRC (Quit: Leaving)
03:40:00 *** D-HUND has quit IRC (Ping timeout: 480 seconds)
03:57:26 *** Wuzzy2 has quit IRC (Quit: Wuzzy2)
07:00:48 *** andythenorth has joined #openttd
07:08:57 *** sla_ro|master has joined #openttd
07:42:38 *** andythenorth has quit IRC (Quit: andythenorth)
07:49:38 *** andythenorth has joined #openttd
08:00:33 *** supermop_Home has quit IRC (Remote host closed the connection)
08:06:07 *** HerzogDeXtEr has joined #openttd
08:51:16 *** Gustavo6046 has quit IRC (Ping timeout: 480 seconds)
09:00:51 *** jgx_ has quit IRC (Ping timeout: 480 seconds)
09:34:16 *** roadt__ has quit IRC (Ping timeout: 480 seconds)
10:21:48 <TrueBrain> I understand what it does, but WHY it is doing that .... absolutely no clue
10:22:54 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
10:23:24 *** HerzogDeXtEr has joined #openttd
10:24:18 <TrueBrain> still no clue as to why :)
10:28:31 <LordAro> maybe you need to track down that paper :)
10:28:56 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #8664: Fix potential bug in SDL2 driver introduced in last cleanup, and cleanup some more https://git.io/JtK3K
10:29:55 <TrueBrain> I now just removed that line, as with OpenGL it was a bit troublesome
10:30:11 <LordAro> i presume you checked that it made no difference to performance?
10:30:12 <TrueBrain> it might have been an SDL1 only thing :P
10:30:27 <TrueBrain> I did; and that line is ONLY called on first tick
10:30:46 <LordAro> maybe you should test it with SDL1 as well :p
10:31:14 <TrueBrain> you make it sound I care enough :)
10:31:58 <TrueBrain> hmm, looking at the code some more .. _num_dirty_rects is initialized 0 anyway
10:32:20 <LordAro> it does seem unlikely to be doing anything
10:35:12 <TrueBrain> I found many minor issues with SDL driver, but none are influence by that variable being set to 0 :)
10:35:38 <TrueBrain> for example, increasing the window size can create random artifacts in the new (what-should-be-black) part of the screen
10:35:42 <TrueBrain> depending on when you resize
10:35:51 <TrueBrain> but .... not worth fixing :)
10:43:55 <TrueBrain> okay, the OpenGL patch became really small for SDL2, which is nice :D
10:44:21 <LordAro> are you intending to get this in 1.11 ?
10:44:57 <TrueBrain> personally, I would like that, yes
10:45:12 <TrueBrain> but it is not really my project :)
10:45:29 <TrueBrain> I guess it would be better if we can also add it for OSX
10:46:23 <TrueBrain> hmm, does my Ubuntu VM have OpenGL support, lets find out
10:47:02 <LordAro> might be nice to get it in as a non-default
10:47:25 <TrueBrain> not sure if non-default is needed even .. we might want to do RC1 with it being default
10:47:30 <TrueBrain> and if too many reports come in, make it non-default
10:48:02 <LordAro> but it's going to have to be done pretty soon if it wants to make RC1 :p
10:48:16 <TrueBrain> SDL and Win32 honestly are really done
10:48:36 <TrueBrain> sure, it needs a review, but I am also pretty sure it will be a review based on coding style
10:48:49 *** andythenorth has quit IRC (Quit: andythenorth)
10:48:56 <TrueBrain> I read the Win32 driver a few times now, as I made SDL similar
10:48:57 <TrueBrain> that part looks good
10:49:01 <TrueBrain> the OpenGL backend code itself
10:49:44 <TrueBrain> unless we magically find someone with OpenGL knowledge that can talk in a constructive matter, I think we should YOLO that part :)
10:49:45 <LordAro> my brief experiments with OpenGL have taught me that it's all magic and voodoo anyway
10:50:30 <TrueBrain> honestly, it is amasing he got this far with OpenGL
10:50:35 <TrueBrain> of the many attempts we had over a decade
10:50:41 <TrueBrain> this is by far the most mature and functional one
10:50:58 <TrueBrain> I am sure many things can be done better, but .. the increase in performance cannot be ignored here :)
10:58:27 *** arikover has joined #openttd
11:03:25 <TrueBrain> okay, on Linux it is also ~10 times as fast
11:06:33 <TrueBrain> even works on Wayland
11:11:18 <TrueBrain> the first 4 commits are in a PR to master
11:11:30 <TrueBrain> the next 2 you might or might not want to merge with your code; just two more things I found
11:11:35 <LordAro> an order of magnitude is ridiculous
11:11:44 <TrueBrain> LordAro: it really really is
11:11:55 <TrueBrain> just as a reminder, that doesn't make OpenTTD 10 times as fast :P
11:12:46 <TrueBrain> michi_cc: I think I have done everything correct for the SDL port, so I think you can consume it in your branch :)
11:13:11 <TrueBrain> if you can rebase your branch after that, we can build binaries for Windows and Linux, and ask some more stats from people, possibly :)
11:14:07 <TrueBrain> if there is anything else I can help with bringing OpenGL into master, let me know! No clue where you are with the OSX stuff, and if any of these need reviews etc .. just let me know :)
11:18:09 <LordAro> what a curious profile picture
11:32:31 <Eddi|zuHause> that username rings a bell
12:02:09 *** HerzogDeXtEr1 has joined #openttd
12:08:10 *** HerzogDeXtEr has quit IRC (Ping timeout: 480 seconds)
12:34:46 *** sla_ro|master has quit IRC ()
13:15:15 *** roadt__ has joined #openttd
13:18:54 *** supermop_Home__ has joined #openttd
13:22:31 *** roadt_ has quit IRC (Ping timeout: 480 seconds)
14:24:11 *** GNU_Pepe has joined #openttd
15:11:39 *** Gustavo6046 has joined #openttd
15:28:45 *** roadt__ has quit IRC (Ping timeout: 480 seconds)
15:35:23 *** roadt__ has joined #openttd
15:45:09 *** nielsm has quit IRC (Read error: Connection reset by peer)
15:45:43 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
15:53:33 *** arikover has quit IRC (Quit: ERC (IRC client for Emacs 27.1))
16:25:23 *** Progman has joined #openttd
16:30:33 *** Wormnest has joined #openttd
16:51:01 *** Gustavo6046 has quit IRC (Ping timeout: 480 seconds)
16:59:14 *** Gustavo6046 has joined #openttd
17:22:16 *** sla_ro|master has joined #openttd
17:43:46 *** frosch123 has joined #openttd
18:21:55 *** jottyfan has joined #openttd
18:47:29 *** andythenorth has joined #openttd
19:00:02 <supermop_Home__> I did make some generative whisky bottles in grasshopper to fill out the back bar for a rendering im working on
19:01:19 <DorpsGek> - Update: Translations from eints (by translators)
19:01:22 <supermop_Home__> although ideally a real back bar would be much more boring and less noisey, as one wouldn't stock a 1/3 full bottle of gin behind a full bottle of scotch
19:03:58 *** jottyfan has quit IRC (Quit: jottyfan)
19:05:01 *** gelignite has joined #openttd
19:15:30 <michi_cc> TrueBrain: Will look at your SDL stuff for the next round, but I have something else to push first :)
19:15:43 <TrueBrain> and no rush/hurry what so ever :)
19:16:11 * andythenorth can test mac stuff more at the weekend or next week
19:16:28 <andythenorth> probably other mac users would be more useful though :)
19:17:17 <michi_cc> andythenorth, orudge: You may test (or incinerate your computer, who knows :P)
19:18:01 * andythenorth is curious about an M1 build
19:18:03 <TrueBrain> well, if you merge my branch in it, we can send it to the farm to produce binaries for all supported OSes :D
19:19:15 <michi_cc> OSX works for me on 10.14 with the Apple software driver. Before handing it out, somebody should at check if it survives contact with a real GPU :)
19:21:33 <michi_cc> And at least with that setup, the OpenGL variant is a lot slower than the current (and updated variant from #8652) driver.
19:23:14 <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #8664: Fix potential bug in SDL2 driver introduced in last cleanup, and cleanup some more https://git.io/JtKMm
19:23:57 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8664: Fix potential bug in SDL2 driver introduced in last cleanup, and cleanup some more https://git.io/JtK3K
19:30:58 <TrueBrain> michi_cc: why all of a sudden call the file cocoa_ogl, and not like the rest cocoa_opengl? :D
19:31:06 <TrueBrain> (this is the quality review you can expect, honestly :P)
19:31:34 <michi_cc> It looks too long :P
19:31:50 <TrueBrain> win32_opengl is identical in length :P
19:33:19 <michi_cc> It needs a cleanup anyway later. Right now there are two alternative methods implemented (with a driver param to switch), because both peg the CPU at 100%, so I can't decide which one is better. The end should absolutely only have one variant. There's a bit more to clean as well.
19:34:39 <TrueBrain> for SDL, performance is both on Windows and Linux a magnitude better for video output time
19:34:46 <michi_cc> But just like with SDL, if you've done all the preparation work beforehand, the actual driver file and commit are deceptively small :)
19:35:16 <TrueBrain> which is a good thing, as that means your OpenGL backend is abstracted at just the right level :)
19:36:58 <michi_cc> Hmm, I push OSX support, and the OSX CI runner gets stuck :)
19:37:19 <michi_cc> Stuck at starting, not at building.
19:37:30 <TrueBrain> it felt what you were doing
19:44:48 *** WormnestAndroid has quit IRC (Remote host closed the connection)
19:45:01 *** WormnestAndroid has joined #openttd
19:53:11 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
19:53:24 *** WormnestAndroid has joined #openttd
19:54:06 <michi_cc> Let's see if we can get it unstuck...
19:55:17 <TrueBrain> oops, now spot that 1 commit message is wrong .. reads [SDL] , not [SDL2]
19:55:59 <michi_cc> I'm sure there are more bug to be found :)
19:56:34 <TrueBrain> pfft, commit message checker is being evil
19:56:40 <TrueBrain> seems I failed at tabs etc .. sorry :(
19:56:41 <michi_cc> Hmm, "src/video/sdl2_opengl_v.hpp:25: Invalid tab usage:" :P
19:56:56 <TrueBrain> vscode really does not understand our coding style
19:56:59 <TrueBrain> I cannot really blame it :P
19:57:06 <TrueBrain> normally it is either tabs or spaces
19:57:09 <TrueBrain> but we have a mix :)
19:57:23 <michi_cc> You could review and approve #8652 as a penance :P
19:57:40 <TrueBrain> is already reviewed for you
19:57:47 <TrueBrain> you just need to process the results :)
19:58:41 <TrueBrain> someone skipped lunch over that review, I have been told :P
20:04:17 <michi_cc> Take that, commit checker!
20:05:11 <_dp_> Wolf01, but my new gaming pc compiles openttd 10 times faster! :p
20:05:34 <michi_cc> Well, still "Queued — Waiting to run this check..."
20:06:19 <TrueBrain> guess the runners broke
20:06:21 <TrueBrain> that happens sometimes
20:22:44 <frosch123> Wolf01: which is the original? 9gag or reddit?
20:28:35 <Wolf01> Reddit for sure, 9gag is original only for stuff which talks about 9gag... and I'm not 100% sure about it too
20:40:12 <michi_cc> TrueBrain: You broke Emscripten :)
20:40:45 <TrueBrain> lolz ... every time I was: I should test Emscripten after this .. after "this".. what was it I had to do? *shrug*, continues with the next
20:40:51 <TrueBrain> so sorry .. will check in a bit :)
20:41:23 <michi_cc> I think it's just some missing CMake condition. I tries to link to OpenGL and is of course failing.
20:41:42 <TrueBrain> how did it detect OpenGL ? :P
20:45:16 <michi_cc> I'll take care of the few warnings in the CI log.
20:45:31 <TrueBrain> I will make sure to test Emscripten tomorrow
20:45:33 <TrueBrain> ensuring it really works
20:45:50 <TrueBrain> and I believe you can also use an OpenGL backend with WASM .. something to look at :P
20:48:58 <glx> doesn't seem to find opengl (at least cmake log says nothing about opengl for emscripten)
20:49:51 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
20:51:36 <michi_cc> Something's still trying to link to OpenGLBackend.
20:52:45 <glx> haha I like how detailled is macos failure
20:53:17 <michi_cc> Runner broke somewhere.
20:54:16 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
20:55:26 *** WormnestAndroid has joined #openttd
21:00:26 <michi_cc> TrueBrain: WASM will be OpenGL ES, which is very similar to normal OpenGL, except when it's not :(
21:02:21 <TrueBrain> ah, I see where I went wrong .. I assumed LockVideoBuffer() was a local function
21:02:24 <TrueBrain> I even made a commit for it in Win32
21:02:32 <TrueBrain> but that is wrong .. it is defined already in video_driver.hpp
21:02:43 <TrueBrain> I hate how unclear this is in both Visual Studio Code, and in C++ in general
21:02:56 <TrueBrain> so sorry michi_cc , that just needs a ton of "virtual" and "override" again :P
21:03:38 <TrueBrain> I wonder why the other compilers didn't complain
21:04:36 <TrueBrain> ah, and indeed, OpenGL is detected on emscripten
21:05:33 <TrueBrain> import object field '_ZN13OpenGLBackend7DestroyEv' is not a Function
21:05:53 <TrueBrain> why is that not a function .. eeeuuuhhhhhh
21:09:49 <TrueBrain> because the files are protected with WITH_OPENGL
21:10:33 <TrueBrain> michi_cc: isn't it enough to CMake condition with OPENGL_FOUND?
21:12:06 *** nielsm has quit IRC (Ping timeout: 480 seconds)
21:12:22 <michi_cc> Probably. I think my opengl repo was created a few months before CMake :)
21:12:35 <TrueBrain> error: undefined symbol: glTexImage1D (referenced by top-level compiled C/C++ code)
21:12:45 <michi_cc> It looked very differently back then, but still.
21:14:33 <TrueBrain> let's see if the 1D functions are the only ones that don't work ..
21:15:22 <michi_cc> OpenGL ES has some subtly but annoying differences.
21:16:02 *** jottyfan has joined #openttd
21:16:33 <milek7> extension loading code will be probably all wrong on GLES
21:16:33 <TrueBrain> only the two 1D functions prevent linking
21:16:57 <milek7> shaders will need tweaking
21:17:24 <milek7> and I guess some subtle breakage of doing something that is not allowed in GLES ;p
21:18:09 <TrueBrain> michi_cc: hihi, it doesn't pass the >= 1.3 OpenGL version detection :D
21:18:19 <TrueBrain> [driver] OpenGL driver: Mozilla - Mozilla (OpenGL ES 2.0 (WebGL 1.0))
21:18:31 <TrueBrain> The error was: OpenGL version >= 1.3 require
21:20:13 *** Wormnest has joined #openttd
21:28:19 <orudge> Hmm, trying to play OpenTTD on my iPhone via Steam Remote Link does technically work, but is... tricky
21:28:29 <TrueBrain> orudge: in what sense?
21:29:08 <orudge> TrueBrain: everything is too small :) Even with quad scaling it's fiddly for me at least
21:29:33 <TrueBrain> well, not having a mouse/keyboard is an issue too, I am sure :
21:29:45 <orudge> Plus lack of mouse, things like scrolling are tricky
21:30:07 <orudge> You can set up mappings for gestures etc in Steam I think
21:43:52 <LordAro> needs the android ui :p
21:54:13 <TrueBrain> michi_cc: w00p, CI passes on emscripten :P
21:54:23 <TrueBrain> has ..... other issues :P
21:55:20 <michi_cc> But it's almost done...
21:55:23 *** Samu has quit IRC (Quit: Leaving)
21:55:38 <michi_cc> Ha: "8 successful checks
21:55:55 <TrueBrain> YOLO approve now, right? :D
21:56:06 <michi_cc> Merge and release 1.11 :P
21:56:23 <TrueBrain> ideally, I would love to see this in 1.11 .. I wonder how Steam reacts if we delay the release :P
21:57:00 <TrueBrain> I also once again realised how backwards our video drivers really are :)
21:57:01 <michi_cc> If we can get people to actually test this, aiming for 1.11 is totally okay.
21:57:15 <TrueBrain> but that is something for 1.12 to address :P
21:57:39 <TrueBrain> michi_cc: yeah, if one or two people tried macOS, we can create binaries with a small guide what and how to test
21:57:43 <TrueBrain> and we can send it around a bit
21:58:37 <_dp_> there can always be 1.11.1 :p
21:59:11 <TrueBrain> what is the worst that can happen
21:59:16 <TrueBrain> me looks at Steam release
21:59:25 <TrueBrain> well, off to bed for me, night all
22:12:46 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
22:34:38 *** Progman has quit IRC (Remote host closed the connection)
22:35:35 <supermop_Home__> yay github unflagged me
22:36:31 <michi_cc> You've grown a tail in here instead :D
22:37:51 *** gelignite has quit IRC (Quit: Stay safe!)
22:41:46 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
22:42:10 *** WormnestAndroid has joined #openttd
22:44:10 *** Wormnest has joined #openttd
22:47:54 *** jottyfan has quit IRC (Quit: jottyfan)
22:50:29 *** frosch123 has quit IRC (Quit: be yourself, except: if you have the opportunity to be a unicorn, then be a unicorn)
22:57:08 *** GNU_Pepe has quit IRC (Remote host closed the connection)
23:06:15 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
23:08:12 *** andythenorth has quit IRC (Quit: andythenorth)
23:09:39 *** HerzogDeXtEr1 has quit IRC (Read error: Connection reset by peer)
23:12:59 *** sla_ro|master has quit IRC ()
23:13:46 <Eddi|zuHause> TrueBrain: i thought there should be a way to push "secret" beta binaries to steam, that you hide behind a beta code
23:14:07 <Eddi|zuHause> (not sure that is worth the effort)
23:21:14 <LordAro> supermop_Home__: yay!
23:27:02 *** jottyfan has joined #openttd
23:33:20 *** jottyfan has quit IRC (Quit: jottyfan)
continue to next day ⏵
