IRC logs for #openttd on OFTC at 2020-11-09
⏴ go to previous day
00:07:50 <DorpsGek_III> [OpenTTD/OpenTTD] TinCanTech reopened issue #8336: [Game play] Vehicle disasters should always be banner headlines. https://git.io/JTjuk
00:08:55 <DorpsGek_III> [OpenTTD/OpenTTD] TinCanTech commented on issue #8336: [Game play] Vehicle disasters should always be banner headlines. https://git.io/JTjuk
00:12:12 *** patricia[m] has joined #openttd
00:23:40 *** gretel[m] has joined #openttd
00:24:18 *** cawal[m] has joined #openttd
01:02:21 *** ChanServ sets mode: +v tokai
03:27:18 *** snail_UES_ has joined #openttd
03:48:42 *** m1cr0m4n has joined #openttd
03:59:20 <DorpsGek_III> [OpenTTD/OpenTTD] TinCanTech closed issue #8336: [Game play] Vehicle disasters should always be banner headlines. https://git.io/JTjuk
03:59:20 <DorpsGek_III> [OpenTTD/OpenTTD] TinCanTech commented on issue #8336: [Game play] Vehicle disasters should always be banner headlines. https://git.io/JTjuk
04:49:53 <Eddi|zuHause> anyone understand what this person wants?
04:50:31 <Eddi|zuHause> sounds like he's just confused about the news settings
05:54:11 *** Eddi|zuHause2 has joined #openttd
06:45:50 *** HerzogDeXtEr has joined #openttd
08:24:42 *** tokai|noir has joined #openttd
08:24:42 *** ChanServ sets mode: +v tokai|noir
08:25:55 *** jottyfan has joined #openttd
08:32:48 *** longtomjr has joined #openttd
08:39:34 <longtomjr> Yaay "Improve performance of trains and road vehicles with a continuously updating NewGRF vehicle image." (newest JGR release, he had a look at our server game that were giving issues and did some profiling)
09:12:32 *** longtomjr has joined #openttd
09:46:33 <TrueBrain> celebrate and give him a big hug!
10:01:43 <longtomjr> Maybe an elbow tap or something
10:02:16 <longtomjr> train ticks went from 20ms to 2ms
10:02:41 <longtomjr> That is an order of magnitude increase. He also added a setting to disable it completely, for folks who's PCs might struggle
10:05:20 <TrueBrain> which is everyone's PC if you add enough trains :P
10:33:10 *** andythenorth has joined #openttd
10:34:35 *** ChanServ sets mode: +v tokai
10:42:28 *** Eddi|zuHause2 is now known as Eddi|zuHause
10:49:59 *** WormnestAndroid has quit IRC
10:50:12 *** WormnestAndroid has joined #openttd
11:19:31 *** frosch123 has joined #openttd
11:22:25 *** Flygon_ has joined #openttd
11:25:07 <TrueBrain> today I learnt that a deployment key of Repo A also gives you read access to any public repo on GitHub
11:25:17 <TrueBrain> not what I expected .. I understand why, but I just didn't expect it
11:27:00 <frosch123> "read access to public repo" <- did you mean that, because that should not require any auth?
11:28:07 <TrueBrain> frosch123: it does if you use ssh, of course :)
11:28:24 <TrueBrain> in GitHub you can make deployment keys per repository, which allows read/write access to that repo over SSH
11:28:30 <TrueBrain> which is a very clean way of doing stuff
11:28:37 <TrueBrain> I just expected that deployment key to be bound to that repo
11:28:44 <TrueBrain> but .. it allows access to all public things too
11:29:00 <TrueBrain> which means I can use a deployment key on any repo to clone any other ... which is annoying when you want to debug stuff
11:29:09 <TrueBrain> especially as the audit log is on the deployment key of that repo
11:29:14 <TrueBrain> it is a bit weird .. I get it, but it is a bit weird
11:29:53 <TrueBrain> owh, shit, and now I am the actor of this key
11:33:38 <frosch123> but since there are actual relativepath extensions, i guess this is a bug
11:34:00 <TrueBrain> right, I forgot how weird deployment keys on GitHub are
11:34:03 <TrueBrain> they do have an owner
11:34:06 <TrueBrain> but that is not mentioned anywhere
11:34:29 <TrueBrain> but WHO adds keys is very important
11:34:43 <TrueBrain> which again, is not something that is clear when adding them .. technically, I get it
11:35:30 <longtomjr> You can create keys through the API btw, so you can make that part of your infrastructure setup
11:36:17 <TrueBrain> that is one downside of using CDK: I have nothing that can talk to other infrastructures :)
11:36:25 <TrueBrain> so this part is not automated
11:36:37 <TrueBrain> wouldn't hurt to automate it, honestly, as setting up secrets is a boring job :P
11:36:45 <longtomjr> Yep, I am doing that with my terraform setup, to get flux working
11:36:51 <TrueBrain> but every time I work with Deploy Keys, I am confused and annoyed by the implementation
11:37:05 <TrueBrain> every ... single ... time ...
11:37:09 <longtomjr> I mean you can still just do it using a python library
11:37:12 <TrueBrain> so either I am not growing/learning, or it is just weird :P
11:37:24 <TrueBrain> yeah, I could, but that would make it very hard for anyone else to understand, honestly
11:37:52 <TrueBrain> and I like having AWS decoupled from GitHub, honestly
11:38:00 <TrueBrain> if we want to migrate, there are no hardlinks between the two
11:38:04 <TrueBrain> I hope we never want to :P
11:38:53 <TrueBrain> but to terraform GitHub wouldn't be the worst idea
11:39:05 <TrueBrain> or ansible, or chef, or what-ever
11:39:31 <longtomjr> Terraform github is fine for deploy keys I found.
11:39:37 <longtomjr> Have not done much other stuff
11:40:14 <TrueBrain> I would also use it for branch protection, just to sync all those settings
11:40:22 <TrueBrain> they now "should" be in sync :P
11:40:54 <longtomjr> are you using the deploy key as an env var?
11:40:56 <TrueBrain> yippie, now the Deploy Key has the right actor
11:41:16 <TrueBrain> on AWS it is sent to the Python process as a base64 encoded env-variable, yes
11:41:32 <TrueBrain> it is stored as a secret
11:41:56 <TrueBrain> right, finally this works \o/
11:41:58 <longtomjr> Just wondering if you might want to setup some key rotation somehow
11:42:17 <TrueBrain> longtomjr: I rotate all keys every 6 months
11:42:21 <TrueBrain> but it is a manual action atm
11:42:39 <TrueBrain> same for IAM access to AWS
11:42:43 <TrueBrain> (from GitHub to AWS)
11:43:05 <TrueBrain> I often like doing it manually, as it allows me to check logs etc for abuse while at it :)
11:43:40 <TrueBrain> frosch123: as can be seen on the URLs above, I switched out your export for some dummy data, so I could test "git push" and "pushes to GitHub should update the wiki"
11:43:41 <longtomjr> Is there a way to get to your own user page
11:43:55 <TrueBrain> "own user page", what do you mean?
11:44:12 <longtomjr> If I want to go to my user page as a user
11:44:20 <TrueBrain> what "user page" do you mean?
11:44:25 <TrueBrain> I am missing context :)
11:45:15 <frosch123> TrueBrain: github already snitched it to me via mail :)
11:45:29 <longtomjr> say I want to go to User:longtomjr to start editing my user page, how does that work on truewiki?
11:45:31 <TrueBrain> frosch123: I assumed as much ;) Someone was reading those emails :D
11:45:39 <TrueBrain> longtomjr: we do not support the User namespace
11:45:51 <TrueBrain> the only usage we have seen on the current wiki, is abuse :P
11:45:55 <frosch123> TrueBrain: i even get them twice :)
11:46:05 <longtomjr> So no plans for user pages?
11:46:16 <TrueBrain> if anyone can present a use-case, we can talk it over
11:46:21 <TrueBrain> but history has shown people only abuse it :)
11:46:32 <frosch123> longtomjr: every github user can have their own wiki
11:46:46 *** CornsMcGowan[m] has quit IRC
11:46:46 *** ad5twoknebor[m] has quit IRC
11:46:47 *** shedidthedog[m] has quit IRC
11:46:47 *** emeraldsnorlax[m] has quit IRC
11:46:48 *** yur3shmukcik[m] has quit IRC
11:46:48 *** ist5shreawf[m] has quit IRC
11:46:49 *** hylshols7qui[m] has quit IRC
11:46:49 *** cyberjunkie[m] has quit IRC
11:46:51 <TrueBrain> well, yes, we could setup <yournamehere>.wiki.openttd.org :D
11:47:08 <TrueBrain> but User namespace is a terrible mediawiki idea
11:47:15 <TrueBrain> owh, Matrix being unstable as fuck
11:47:20 <frosch123> you have to decide, is your page personal (use your own wiki), or is is of general interest (put it on ottd wiki)
11:47:22 <TrueBrain> people should run their own ... lot less issues :P
11:47:38 <LordAro> "Quit: killed" is not normally a netsplit ;)
11:47:50 <TrueBrain> I would guess an upgrade of the IRC gateway :P
11:47:51 <reldred> loool, I didn't see that on my client
11:48:01 <TrueBrain> too bad, they are ALL connected via ONE gateway, it seems
11:48:25 <frosch123> at least we are back to a normal number of 90 idlers
11:48:31 <reldred> well, it's kinda a netsplit, they were all on one server just not the upstream OFTC server :P
11:48:47 <TrueBrain> well, strictly seen, with Matrix, you are not on any server
11:48:58 <TrueBrain> but they connect to IRC via a single gateway :P
11:49:31 *** albert[m] has joined #openttd
11:49:33 <longtomjr> anyways, I can see that there is probably no use for user namespaces.
11:49:57 <longtomjr> How often does the wiki sync with gh
11:50:08 <TrueBrain> 5 minutes after last change, a push is done to GitHub
11:50:17 <longtomjr> Also, the preview does not show newlines for some reason
11:50:35 <TrueBrain> I will add it to my bug-list!
11:51:12 <TrueBrain> possibly I will lower the 5 minute-delay, but that is always part of the experiment :)
11:51:47 <longtomjr> Do you have it flush when the container gets an exit signal?
11:51:48 <TrueBrain> - modified: en/More info (by longtomjr)
11:51:54 <TrueBrain> would be what DorpsGek_III would announce, if w ewould enable it
11:52:03 <TrueBrain> longtomjr: on my TODO-list, but no
11:54:31 <TrueBrain> so if the server crashes within that 5 minutes, changes will be lost :)
11:54:52 <TrueBrain> (same goes for BaNaNaS, btw)
11:55:28 <TrueBrain> but everything should be guarded, so crashes should never happen :D
11:55:30 <TrueBrain> famous last words :P
11:55:45 <TrueBrain> but okay, this all seems to work \o/ :D
11:55:48 <longtomjr> Hehe, what happens when you deploy a new version?
11:56:05 <TrueBrain> any pending changes will be lost; this is why it is on my TODO to "git push" on SIGHUP :)
11:56:28 <longtomjr> That is what I thought of initially, that is why I asked
11:56:36 <longtomjr> Can you have a sidecar do it?
11:56:38 <TrueBrain> it is just really unlikely to happen :P
11:56:55 <longtomjr> (does docker have sidecars or something similar?)
11:57:02 <TrueBrain> I use ECS, which has sidecars
11:57:30 <longtomjr> Ah ok, that might be the best approach, since then you don't require the main container to be in a healthy state.
11:57:39 <TrueBrain> but similar as with BaNaNaS, the chances of it ever happening are very slim .. as we have very low mutation rate
11:58:05 <TrueBrain> well, that is the thing: do you want to push if your main container is not healthy? :P
11:58:25 *** sla_ro|master has joined #openttd
11:58:52 <longtomjr> Hmm, you might want to push it to a branch and notify someone, and then it can be a manual merge if everything is opk
11:59:11 <TrueBrain> is that worth the effort, is the question :D
11:59:20 <longtomjr> Sounds interesting to do at least
11:59:38 <longtomjr> afk for a bit, need to help getting lunch ready
12:08:24 *** patricia[m] has joined #openttd
12:08:25 *** josef[m] has joined #openttd
12:08:26 *** hylshols7qui[m] has joined #openttd
12:08:27 *** amal[m] has joined #openttd
12:08:28 *** labs[m] has joined #openttd
12:08:28 *** iarp[m] has joined #openttd
12:08:29 *** paulus[m] has joined #openttd
12:08:30 *** julie[m] has joined #openttd
12:08:31 *** christoph[m] has joined #openttd
12:08:32 *** shedidthedog[m] has joined #openttd
12:08:32 *** dude[m] has joined #openttd
12:08:33 *** natmac[m] has joined #openttd
12:08:34 *** hamstonkid[m] has joined #openttd
12:08:35 *** cawal[m] has joined #openttd
12:08:35 *** twom[m] has joined #openttd
12:08:36 *** ircer[m] has joined #openttd
12:08:37 *** rudolfs[m] has joined #openttd
12:08:38 *** fiddeldibu[m] has joined #openttd
12:08:38 *** joey[m] has joined #openttd
12:08:40 *** jact[m] has joined #openttd
12:08:41 *** jeremy[m] has joined #openttd
12:08:41 *** ist5shreawf[m] has joined #openttd
12:08:41 *** tonyfinn[m] has joined #openttd
12:08:42 *** pina[m] has joined #openttd
12:08:43 *** menelaos[m] has joined #openttd
12:08:45 *** yoltid[m] has joined #openttd
12:08:45 *** glothit7ok[m] has joined #openttd
12:08:46 *** khavik[m] has joined #openttd
12:08:47 *** dave[m] has joined #openttd
12:08:48 *** Aileen[m] has joined #openttd
12:08:49 *** natalie[m] has joined #openttd
12:08:49 *** linda[m] has joined #openttd
12:08:50 *** yur3shmukcik[m] has joined #openttd
12:08:51 *** ad5twoknebor[m] has joined #openttd
12:08:52 *** philip[m] has joined #openttd
12:08:52 *** blikjeham[m] has joined #openttd
12:08:53 *** ciet[m] has joined #openttd
12:08:54 *** yoyo[m] has joined #openttd
12:08:55 *** phil[m] has joined #openttd
12:08:56 *** johanna[m] has joined #openttd
12:08:57 *** einar[m] has joined #openttd
12:08:57 *** fjodor[m] has joined #openttd
12:08:57 *** ookfof[m] has joined #openttd
12:08:58 *** pothyurf[m] has joined #openttd
12:08:59 *** olmvnec[m] has joined #openttd
12:09:00 *** gretel[m] has joined #openttd
12:09:00 *** karoline[m] has joined #openttd
12:09:01 *** jeeg[m] has joined #openttd
12:09:02 *** karl[m]1 has joined #openttd
12:09:04 *** igor[m] has joined #openttd
12:09:05 *** christoph[m]1 has joined #openttd
12:09:06 *** grag[m] has joined #openttd
12:09:06 *** leward[m] has joined #openttd
12:09:07 *** freu[m] has joined #openttd
12:09:08 *** patrick[m] has joined #openttd
12:09:09 *** CornsMcGowan[m] has joined #openttd
12:09:10 *** elliot[m] has joined #openttd
12:09:11 *** magdalena[m] has joined #openttd
12:09:11 *** emeraldsnorlax[m] has joined #openttd
12:09:12 *** cyberjunkie[m] has joined #openttd
12:09:13 *** robert[m] has joined #openttd
12:09:14 *** nartir[m] has joined #openttd
12:09:15 *** osvaldo[m] has joined #openttd
12:09:16 *** nolep[m] has joined #openttd
12:09:17 *** Heiki[m] has joined #openttd
12:09:18 *** dekeract[m] has joined #openttd
12:10:50 *** matt21347 has joined #openttd
12:17:12 <frosch123> omg... mediawiki actually does ../ links
12:22:38 <LordAro> C:\Documents and Settings\lunch
12:22:56 <andythenorth> bring back peter1138
12:41:19 *** grossing has joined #openttd
13:34:34 * FLHerne pretty much doesn't have any food
13:35:19 <FLHerne> I have a couple of eggs left, but you can only eat so many eggs in one day
13:35:40 <andythenorth> I have been in them
13:36:36 <FLHerne> Someone™ needs to add this black check to `make test`
13:47:22 <FLHerne> We have python, why can't we use unittest or pytest or something?
14:30:32 *** snail_UES_ has joined #openttd
14:41:20 <TrueBrain> right, all my pre-checks completed .. I think, ignoring the content, the wiki on staging is production-ready ... proof-me-wrong, I would say :D
14:44:30 <frosch123> i forgot... is supporting [[:Foobar]] on your list?
14:44:30 <longtomjr> maybe test it with the production content?
14:46:00 <TrueBrain> frosch123: it is on my list, but not for v1; do you have pages that actively use it?
14:46:19 <frosch123> everything that uses Template:Merge for example
14:46:34 <TrueBrain> longtomjr: we have done that for the last few days I would think :) I guess more interesting now is to test if everything works as expected, like editng, renaming, linking, etc
14:46:36 <frosch123> removing the : would break it for Categories and Files
14:46:48 <TrueBrain> k; let me see if I can fix that for now at least :)
14:47:03 <frosch123> i made the conversion remove it for non-templated links
14:47:28 <TrueBrain> how is [[en/Bla]] different from [[:en/Bla]] for Categories and Files?
14:47:56 <longtomjr> TrueBrain, what is the login timeout? Or am I just getting logged out because you did a new deploy?
14:48:06 <TrueBrain> longtomjr: new deploy logs everyone out
14:48:16 <frosch123> [[:Category:Foobar]] links to the category, [[Category:Foobar]] adds the page to the category?
14:48:29 <TrueBrain> yeah, but that already works
14:48:35 <TrueBrain> and has been for a while
14:48:56 <frosch123> yes, but Template:merge uses [[:{{{1}}}]] where 1 can be anything
14:49:04 <frosch123> page, category, tempalte, file
14:49:11 <longtomjr> I am going to run through a couple of tests. Is it ok to just post here if I pick something up?
14:49:26 <TrueBrain> ah, okay, it sounded like something else would break frosch123 :)
14:49:42 <TrueBrain> longtomjr: post here, make an issue in the TrueWiki repo, all the same to me
14:49:48 <TrueBrain> just .. don't spam :P
14:49:54 <TrueBrain> use gists or what-ever if it is more than a line :P
14:50:48 <longtomjr> ok, Gonna open issues for things that you might just close as 'wontfix
14:51:16 <longtomjr> also, you said you have a list, so it might duplicate some things
14:51:39 <TrueBrain> any and all feedback is appreciated, use what-ever channel works best for you :)
14:52:00 <TrueBrain> I will process them no matter what, so it is all good
14:56:07 <longtomjr> Am I just blind, or is there no way to upload media?
14:56:24 <TrueBrain> create a page in File/
14:56:54 <TrueBrain> either by browsing there via the breadcrumbs, or by first making a link to a file
15:02:01 <longtomjr> Did some clicking and some editing, nothing else I am picking up, but I have not worked with mediawiki in years, so I might be missing things.
15:04:20 <TrueBrain> nobody would admit if they have worked with mediawiki honestly :P
15:04:55 <TrueBrain> and for sure we will miss things, that is normal :D
15:05:12 <TrueBrain> but the more people that try stuff, the less chance it is something HUGE :P
15:05:16 <TrueBrain> so much appreciated :)
15:05:24 <frosch123> i learned various mediawiki "features" from our users :)
15:06:01 <frosch123> apparently you can install custom css and js in your userpages, and it will use it...
15:06:07 <TrueBrain> frosch123: merged [[:en/Bla]] fix; now being deployed to staging
15:15:15 <TrueBrain> and moved my TODO to issue-tracker :)
15:20:09 <frosch123> hmm, something broke... check-all finished in 2 minutes, usually it takes 10 on my machine
15:20:33 <frosch123> ah, nvm, user error
15:27:43 <frosch123> also, the wantedpages thingie only works for pages in the main namespace
15:29:04 <frosch123> but it does not contain Scenario: pages for example
15:29:24 <TrueBrain> somehow I am not really surprised :P
15:30:46 <frosch123> also, like 4 links on the wiki have duplicate " ", which mediawiki shortens to one :p
15:31:40 <TrueBrain> yeah, I am not doing that crap :P
15:32:01 <frosch123> fixing the source instead
15:33:59 <TrueBrain> longtomjr: you didn't even upload an image?! Awh :(
15:35:38 <TrueBrain> well, we are, aren't we? :D
15:35:54 <longtomjr> TrueBrain, I created the image redlink
15:35:57 <TrueBrain> I rather be upfront about that :P
15:36:13 <longtomjr> saw that I could upload, and realised I did not have something to upload
15:36:15 <TrueBrain> longtomjr: I am curious if uploading works, and if you see any problems with it .. if you don't mind testing :)
15:36:29 <longtomjr> will take a screenie
15:36:31 <TrueBrain> here, have a png :)
15:38:59 <longtomjr> "Maximum request body size 1048576 exceeded, actual body size 1051543"
15:39:03 <longtomjr> when clicking preview
15:39:24 <TrueBrain> hmm ... we have a size limit .. cool :D
15:39:33 <TrueBrain> let me get an image big enough to trigger that :P
15:39:56 <TrueBrain> well, that honestly is a bit big, yes :P
15:40:12 <longtomjr> In game screenshot, but 4k monitor
15:40:19 <longtomjr> also, size limit looks like the reverse proxy
15:40:26 <TrueBrain> I believe the current biggest upload is 2MB :P
15:42:17 <longtomjr> It goes from the file I selected, to "no file selected" when I hit preview
15:43:34 <longtomjr> also, the preview does not work
15:43:44 <TrueBrain> I know reading is hard, but come on :P
15:44:03 <longtomjr> Maybe gray out the button?
15:44:25 <longtomjr> I read the first line
15:44:52 <TrueBrain> it is only a problem if you change the file; so greying out the button is not the ideal solution
15:44:58 <TrueBrain> guess we need a bit of Javascript for this honestly
15:45:50 <longtomjr> I think my monkey brain kinda assumed that after the first line, the rest is just gonna be a list of potential compatible licences, or a link to somewhere that explains licences
15:46:08 <longtomjr> maybe a forum post that explains licences would be perfect :P
15:46:10 <TrueBrain> suggestions to improve it are welcome :)
15:46:23 <longtomjr> But yep, I did not read
15:47:05 <TrueBrain> Honestly, I knew people wouldn't read that when I wrote it
15:47:21 <TrueBrain> partial because of what you mention: there are 2 things, and if people read 1, that is already something
15:47:24 <TrueBrain> but also because people don't read
15:47:39 <TrueBrain> I think a piece of Javascript that repeats the message when pressing Preview is the best approach here
15:48:38 <longtomjr> Maybe at the top part of `This is a preview`
15:48:44 <longtomjr> say new uploads will not render
15:48:54 <TrueBrain> it is not that they don't render, the upload is lost
15:48:57 <TrueBrain> so that is already too late
15:49:24 <TrueBrain> (there is no "temporary" storage, basically)
15:49:43 <longtomjr> If "has selected file" then "Warn on preview page"
15:50:27 <longtomjr> Do you have to rollback changes via git btw?
15:50:58 <TrueBrain> copy/paste from GitHub history
15:51:55 <TrueBrain> frosch123: fun fact, nobody can upload a gif :P
15:52:00 <TrueBrain> do we want to support uploading gifs ..
15:52:09 <TrueBrain> (for the migration it doesn't matter btw :P)
15:52:27 <longtomjr> Also also, the picture on the more info page does clip overflow without a scroll bar
15:53:13 <longtomjr> Gifs are useful for illustrating something that might not fit an image, but, 2mb might be a bit small for that
15:54:39 <TrueBrain> tnx frosch123 , added all your comments :D
15:55:01 <TrueBrain> longtomjr: I will fix that in a bit; I was sure I already did, but clearly I did not :)
15:55:28 <frosch123> hmm, no idea idea whether we have any animated gif
15:56:28 <andythenorth> we should use some!
15:58:16 <frosch123> pff. people added gifs to the junctionary, to show how multiple trains travel through them
16:00:44 <frosch123> 6 animated gifs in total
16:00:51 <TrueBrain> ah, aiohttp limits the request body size, finally found it :)
16:01:03 <longtomjr> Yep, that is what I thought it was
16:01:14 <longtomjr> When I saw the message
16:01:48 <longtomjr> how does the uploads work, multipart request?
16:02:53 <TrueBrain> 4MiB limit sufficient?
16:03:34 <longtomjr> I would bump the aiohttp limit to like 10 or something, and then limit the file uploads at the file upload coad
16:04:04 <longtomjr> Since this way it will be hard to find where the limit gets set.
16:04:23 <TrueBrain> that is not answering my question really :D
16:04:29 <TrueBrain> biggest file atm is just over 2MiB
16:04:41 <longtomjr> Then 4 is plenty for file uploads yep
16:05:00 <TrueBrain> for now I am just going to raise the limit in aiohttp; making a pretty error is somethng for v1.1 :)
16:06:02 <TrueBrain> UGH! I sometimes hate Windows .. I was typing text
16:06:09 <TrueBrain> I pressed space, as I was typing text
16:06:12 <TrueBrain> and the popup was gone
16:06:15 <TrueBrain> NO CLUE what was on the popup
16:06:19 <TrueBrain> why ..... do people do that ...
16:06:24 <TrueBrain> don't steal focus ffs
16:06:37 <longtomjr> It asked if you want to forever lock in that windows can update whenever they feel like it
16:07:33 <longtomjr> tbh, that might not have been Windows, it could have been anything that runs in the background
16:08:54 <TrueBrain> but it is Windows that allows it
16:08:57 <TrueBrain> which is more my point
16:09:04 <TrueBrain> I expect my desktop manager to manage those things
16:09:21 <TrueBrain> I think it was a Discord popup, as Discord is acting up :P
16:11:47 <TrueBrain> right, fixed that images could boom in width (now clamped to max 900px), upload limit, and added GIF support
16:11:52 <TrueBrain> if black wouldn't fail on me :D
16:12:58 <TrueBrain> (and this is the reason I make a Pull Request out of everything ... github-actions validators ftw!)
16:13:43 <frosch123> TrueBrain: is there any remote chance error messages could show line numbers or similar?
16:14:06 <TrueBrain> frosch123: -very- difficult
16:14:12 <TrueBrain> because of templates, this information is lost, honestly
16:14:28 <TrueBrain> I have looked into it for a few hours even, but .. I did not see a clean way
16:14:30 <frosch123> ok, i hoped wikitextparser would know it all :)
16:14:40 <TrueBrain> no, wikitextparser knows nothing about templates
16:14:46 <TrueBrain> so we need to do the bookkeeping ourself
16:14:52 <TrueBrain> but internally "lines" have no meaning
16:14:55 <TrueBrain> it is a single bytearray
16:15:00 <TrueBrain> so that bookkeeping is very difficult
16:15:44 <TrueBrain> I have considered building the parsing in a different way, where that would be possible
16:15:49 <TrueBrain> might even make parsing a lot faster
16:15:56 <TrueBrain> but ... I decided to first finish v1 :P
16:16:03 <TrueBrain> so I agree, it would be a very welcome feature
16:22:43 <TrueBrain> okay, what else ... :D
16:23:51 <TrueBrain> can't believe we still render < 30ms for simple pages .. :D
16:25:08 <TrueBrain> good thing about that is, no need to add caching (which only makes the memory usage go up :P)
16:26:09 <TrueBrain> I still think we should prerender the whole site and publish that :P
16:27:13 <longtomjr> Yep, that just makes the view part so easy
16:28:02 <TrueBrain> lets see how long rendering everything currently takes ...
16:31:55 <TrueBrain> frosch123: "Cell attribute '[[Schleuse' is not a valid attribute" <- what is this new error? :P
16:32:53 <TrueBrain> 14681 deadlinks currently :D
16:32:57 <TrueBrain> pretty sure most are legit
16:33:01 <TrueBrain> that is .. insane :P
16:33:44 *** andythenorth has joined #openttd
16:33:53 <TrueBrain> but I also cannot believe we can render the full wiki in < 4 minutes .. that is also insane :D
16:35:49 <TrueBrain> I could make that a lambda@edge checks if you have a cookie; if so, you are logged in, send to the live instance. If not, serve from S3
16:36:08 <TrueBrain> hmm ... no, that would be rather expensive
16:36:13 <TrueBrain> a lambda@edge for every visit ..
16:57:05 <frosch123> TrueBrain: already fixed :p
16:57:32 <frosch123> i am currently running the export of the last fixes
16:57:40 <frosch123> then i expect 0 expected errors, let's see
16:59:05 <frosch123> 0 unexpected errors ofc :p
17:20:34 <frosch123> i wonder whether i can enter \u200e into truewiki filenames
17:20:51 <frosch123> people managed that twice on mediawiki, and i do not know how
17:35:59 *** SpeedStick has joined #openttd
17:40:33 <frosch123> 53 links to Special: left, the rest is fine
18:04:32 *** y2kboy23 has joined #openttd
18:50:02 *** Progman has joined #openttd
18:51:57 <DorpsGek_III> - Update: Translations from eints (by translators)
18:58:15 <TrueBrain> frosch123: Special:Contributions/<IP> <- people linked to special pages by IP? LOL .. now that is weird :P
18:58:22 <TrueBrain> (I removed the IP, to be clear :P)
18:59:01 <TrueBrain> frosch123: those PAGESINCAT and DISPLAYTITLE you already fixed?
18:59:59 <frosch123> no, i would fix them on the original wiki, be deleting the paragraphs they are in, or similar
19:00:14 <frosch123> but did not bother yet
19:00:24 <TrueBrain> k; I am just happy I do not have to implement that :P
19:00:29 <TrueBrain> I don't want to!! :P
19:00:40 <frosch123> oh, i implemented the DISPLAYTITLE
19:00:48 <frosch123> it can be deleted after the migration
19:01:00 <TrueBrain> it is a rather silly variable tbh :P
19:01:21 <frosch123> it works around mediawiki limitations that truewiki does not have
19:01:24 <frosch123> at least in this case
19:01:41 <TrueBrain> Table attribute '|-' is not a valid attribute <- that is still in your latest export
19:02:03 <frosch123> oh, yet another case...
19:02:35 <frosch123> well, it's in that pl guy stuff
19:02:35 <TrueBrain> people tried to make really weird tables over the years :P
19:02:42 <frosch123> still waiting for an answer, what to migrate
19:03:32 <TrueBrain> I like the ratio of 59 missing templates and 14655 linked pages not found :D
19:03:36 <TrueBrain> that ratio is just amazing :D
19:04:04 <frosch123> missing pages are mostly missing translations
19:04:10 <frosch123> so, they do not mean anything
19:04:46 <TrueBrain> I understand; still .. that number .. it is insane :)
19:05:50 <TrueBrain> I can add support for it, but I do not really see the point, honestly
19:05:54 <frosch123> i deleted those categories
19:06:00 <frosch123> so, even if you had implemented it
19:06:23 <frosch123> you would have to implement PAGESINFOLDER :)
19:06:44 <TrueBrain> okay .. so we are just going to leave that broken :)
19:06:50 <TrueBrain> fixed the DISPLAYTITLE on the live wiki
19:06:53 <TrueBrain> that resolves those :P
19:07:12 <frosch123> fixed? you removed it?
19:07:30 <frosch123> i made a special conversion rule to rename the page :)
19:07:47 <frosch123> (well, i already had the rule, i just added the page to the list)
19:07:49 <TrueBrain> mediawiki has this stupid rule that the first character has to be uppercase
19:08:12 <TrueBrain> is there anything left to do on your migration script?
19:08:42 <frosch123> on the script, no. but i need to review the folders of categories, templates and fiels
19:08:48 <frosch123> they ar eonly a rough approximation
19:08:57 <frosch123> i'll do that tomorrow.
19:09:05 <frosch123> then i'll do a full history export, just to see whether it works
19:09:22 <TrueBrain> when you are done, you can merge 1 or 2 commits from the wiki-data-staging
19:09:28 <TrueBrain> and we can push that over the current wiki-data-staging
19:09:36 <TrueBrain> wiki-staging-data, what-ever :P
19:09:51 <TrueBrain> ugh, why did I name it like that? That is silly
19:10:11 <TrueBrain> anyway, if you push it there, we can ask people to check it out on staging
19:10:23 <TrueBrain> and I think we have to set a date, like, end-of-the-week, to bring this to production
19:10:36 <TrueBrain> if we like, we can already "prefix" stuff on the staging
19:10:43 *** gelignite has joined #openttd
19:11:02 <TrueBrain> I can bring the current wiki to read-only if we like too
19:11:09 <frosch123> TrueBrain: with merge you mean the actions?
19:11:46 <TrueBrain> in fact, that is the only commit you would need to cherry-pick
19:12:11 <frosch123> TrueBrain: let me fix the Special: first, then we can set it to readonly
19:12:22 <frosch123> maybe the pl guy finally reads their mail then
19:12:25 <TrueBrain> when-ever you want the 3 hour long export, I would say
19:12:43 <frosch123> i have no idea how long it will take :p
19:12:59 <frosch123> making 100k git commits takes times
19:13:01 <TrueBrain> we just drop it in read-only mode till when-ever we are ready :P
19:13:13 <TrueBrain> damn ... current is 18k
19:13:14 <frosch123> one commit for every change
19:13:16 <TrueBrain> which is already slow as fuck
19:13:34 <TrueBrain> so that might be an issue ...
19:13:34 <frosch123> yes, git log <filename> is very slow
19:13:47 <TrueBrain> guess I do need to look into v2 protocol fetch-depth=1 checkout
19:13:53 <TrueBrain> well, I don't care about "git log" tbh
19:13:59 <TrueBrain> but "git commit" already takes ~1 second
19:14:08 *** Wormnest has joined #openttd
19:14:19 <frosch123> hmm, git commit is affected by number of commits present?
19:14:20 <TrueBrain> not sure how that scales to 100k commits :)
19:14:41 <TrueBrain> on the empty repository it is a lot quicker to save
19:14:46 <TrueBrain> than it is on the 10k one
19:14:52 <TrueBrain> like ... noticeable quicker
19:15:10 <TrueBrain> it fully might be GitPython, and that it is related to the amount of files
19:15:13 <TrueBrain> not the amount of commits
19:15:24 <TrueBrain> I will check out what makes it slow :)
19:16:19 <TrueBrain> hmm .. today it isn't that slow
19:16:24 <TrueBrain> might have been some other changes I did
19:16:33 <TrueBrain> I am testing wrong :P
19:18:26 <TrueBrain> yes, it is the amount of files :D
19:19:25 <TrueBrain> which, I am pretty sure, is due to how GitPython does things
19:19:32 <TrueBrain> owh well, don't care; so 10k commits of 100k commits, go for it :D
19:28:24 <longtomjr> Are you preserving the history from mediawiki?
19:28:55 <frosch123> except for deleted pages
19:29:03 <frosch123> they will just never have existed
19:31:07 <frosch123> i guess we do it because we can :)
19:32:35 <TrueBrain> as with many many many many many things we do :P
19:33:07 <longtomjr> It is just not something I thought about before that could be a problem with a migration like this
19:33:47 <TrueBrain> it is also the reason we still have the sources of SVN r1
19:33:57 <TrueBrain> and a snapshot of the source ever since every day
19:34:16 <TrueBrain> in case you want to compile it :P
19:34:30 <TrueBrain> we are a bit nuts when it comes to history :D
19:40:01 <frosch123> but we lack the vms with the old setup that is actually able to compile the old sources
19:40:11 <TrueBrain> well, I have them :P
19:40:20 <TrueBrain> but yeah, others it would take a bit more effort to set that up :D
19:40:42 *** jottyfan has joined #openttd
19:41:03 <frosch123> did you put them into the arctic code vault?
19:41:17 <TrueBrain> no, but I did in my own vault :)
19:41:48 <TrueBrain> over a TB of my backups and archive is OpenTTD related :P
20:06:08 *** jottyfan has joined #openttd
20:12:43 <andythenorth> today happened then
20:16:55 <frosch123> breakfast, lunch, dinner, second dinner?
20:18:24 <TrueBrain> don't forget about the tanks
20:18:43 <frosch123> didn't he ragequit?
20:18:50 <frosch123> i forgot what it was about
20:24:25 <andythenorth> there was a tank?
21:09:04 <glx> <TrueBrain> it is also the reason we still have the sources of SVN r1 <-- real r1 or r975 or something from crashed svn ?
21:10:04 * glx clicked and have the answer
21:10:29 <glx> too bad we lost 975 commits :)
21:22:21 <andythenorth> make the commits great again
21:26:12 <TrueBrain> Those commits, I am pretty sure, are lost forever :p
21:27:54 <andythenorth> no they must be counted
21:28:02 <andythenorth> I will launch many lawsuits
21:28:45 <frosch123> corona statistics are more interesting
21:29:13 <andythenorth> the missing commits are a GPL violation!
21:29:18 <andythenorth> now I get kicked :(
21:29:18 <frosch123> i may stretch the term "interesting" though
21:32:00 <TrueBrain> If you ever want a new job, in 4 years you can apply :p
21:33:34 <frosch123> brittish premiers can switch quite fast
21:33:53 <andythenorth> they are talking about removing Boris
21:34:57 <frosch123> "new premier" sounds like a possible excuse to delay another year :)
21:49:29 <TrueBrain> Funny, I fixed a bug that is now a bug again ... regression!!!
21:49:48 <TrueBrain> Tnx Sentry, you made it obvious where the error is :)
21:50:37 <frosch123> yeah, i didn't bother making notes :)
21:51:28 <TrueBrain> Happy you tested a fixed bug :D
21:55:22 *** jottyfan has joined #openttd
22:09:51 <frosch123> TrueBrain: is "Folder" always up-to-date, or does it wait for indexing?
22:12:16 <TrueBrain> Index is only for category, translations and 'used on pages'
22:12:44 <frosch123> the file may contain NBSP which got stripped somewhere
22:12:54 <TrueBrain> Very interesting :D
22:13:12 <TrueBrain> Told you people will find a case where I forgot escaping :p
22:13:29 <TrueBrain> Will check tomorrow :)
22:14:38 <TrueBrain> What ... did you do?! Lol
22:15:52 <frosch123> it's also funny that you can save a page, click browser back, edit the name, and create a new page
22:16:21 <TrueBrain> Yup .. bit intentional. Wasnt sure what to do otherwise
22:17:05 <TrueBrain> Yeah, you broke it nicely :D
22:17:12 <TrueBrain> I appreciate that :)
22:18:03 <TrueBrain> I wonder why the file listing fails.. would strip() remove nbsp?
22:19:20 <TrueBrain> Ah, well, that explains the difference :D
22:19:28 <TrueBrain> So it is not my escaping :D
22:19:39 <TrueBrain> I will blacklist nbsp too :p
22:19:59 <frosch123> maybe check whether strip() changes anything after split("/")
22:20:16 <TrueBrain> Will do that too yes, good idea
22:20:28 <frosch123> there are plenty more spaces :)
22:20:29 <TrueBrain> But I guess a nbsp in the middle is also a bit meh
22:20:57 <TrueBrain> Guess I could ask unicodedata for all spaces
22:21:18 <frosch123> when we get japanase, some spaces may be okay
22:21:29 <TrueBrain> On the other hand ... if people want to do stupid shit ...
22:27:04 <TrueBrain> Because the URL is invalid
22:27:18 <TrueBrain> That page cannot exist
22:28:36 <TrueBrain> We need to do a round of: show better errors :)
22:29:07 <frosch123> maybe the the 404 page of the invalid url should say something
22:29:43 <TrueBrain> But many different reasons etc.. but we can at least be more clear
22:31:16 <TrueBrain> Haha, yeah, that is a nice edgecase
22:31:45 <TrueBrain> Guess we should mention the link is invalid on the parent Page
22:32:15 <frosch123> gave sentry a self-recusive template
22:32:42 <TrueBrain> Ah, yes, that was still on my TODO but fell off
22:35:48 <frosch123> entering invalid names for Files says "file already exists"
22:39:58 <TrueBrain> Odd .. make that into an issue please with an example
22:40:07 <TrueBrain> Will pick that up tomorrow :)
22:44:04 <TrueBrain> Ah, yes, Main Page is an illegal name for Folder :)
22:44:11 <TrueBrain> But the error needs to be better
22:44:59 <TrueBrain> But guess it is true for any file without extension
22:46:42 <frosch123> no, then it told me to add .png for png files
22:55:58 <frosch123> hmm, we still have 92 links to wiki.openttd.org :)
23:00:42 <frosch123> File: and User: are new
23:09:02 <TrueBrain> Yeah, but I am going to fix that :p
23:38:34 *** tokai|noir has joined #openttd
23:38:34 *** ChanServ sets mode: +v tokai|noir
23:51:57 *** Gustavo6046 has joined #openttd
continue to next day ⏵
