IRC logs for #openttd on OFTC at 2020-10-17
⏴ go to previous day
00:00:02 <TrueBrain> they did put it in noinclude :)
00:00:16 <TrueBrain> still no clue what the added value is of having it at all
00:00:55 <frosch123> it translates the subtitles?
00:01:17 <frosch123> "Infrastructure" -> "Constructies"
00:01:53 <TrueBrain> well, translated templates is fine, but why the lookup table on top
00:02:14 <TrueBrain> meh, I guess, sure, why not
00:02:19 <TrueBrain> I will filter them out on my end
00:03:43 <TrueBrain> still some errors, but seemly on my end :)
00:03:49 <TrueBrain> "Template Template/en/table of contents not found"
00:03:55 <TrueBrain> pretty sure I saw it
00:04:00 <TrueBrain> might be casing error
00:04:36 <TrueBrain> okay, I will go through my issue tomorrow, update what is fixed
00:04:41 <TrueBrain> and leave what is left :)
00:04:50 <TrueBrain> but this update is already a huge improvement :)
00:06:03 <TrueBrain> most "page not found" errors I see are because of missing category in URL
00:06:09 <frosch123> all templates which have pagenames are parameters need special handling
00:07:27 <TrueBrain> there is no "Mac.mediawiki" in export :(
00:07:48 <TrueBrain> wait, it doesn't exist in the wiki at all
00:07:49 <frosch123> i think that's already in my trash list
00:08:00 <TrueBrain> ./Page/en/Archive/Other/Troubleshooting/Windows.mediawiki
00:08:06 <frosch123> shall i also upload the list of trashed pages?
00:08:44 <TrueBrain> ah, the Windows page is a redirect
00:08:50 <TrueBrain> those are still an issue :P
00:09:17 <TrueBrain> guess we could do with something like "Windows.redirect", with in there the URL to redirect to, or something
00:09:28 <TrueBrain> no, for history it is better if it is called .mediawiki
00:09:34 <TrueBrain> owh well, not the most important thing tbfh
00:10:13 <frosch123> all real pages on the wiki :)
00:10:35 <TrueBrain> rriiiggggghhhhtttttt
00:11:07 <TrueBrain> okay, tomorrow I am going to make this more in a library, but also add a "pedantic mediawiki" mode
00:11:14 <TrueBrain> I didn't want to do it, but I am
00:11:23 <TrueBrain> as that makes it a lot easier to confirm everything works a-okay
00:12:20 <TrueBrain> I noticed it yesterday in the export
00:12:28 <TrueBrain> made my script do weird shit :D
00:12:59 <TrueBrain> anyway, good improvements all around
00:13:05 <TrueBrain> I think we can bring this to the finishline tbh
00:13:17 <TrueBrain> I don't really see any blockers .. just some challenges
00:13:24 <TrueBrain> like, what to do with file history / "translations"
00:13:48 <TrueBrain> but first, time to get some zzzzzzzz
00:28:29 <rptr_> can i evalute scripts in console?
01:05:39 *** ChanServ sets mode: +v tokai
01:11:24 *** supermop_Home_ has quit IRC
01:40:09 *** WormnestAndroid has quit IRC
01:40:23 *** WormnestAndroid has joined #openttd
08:21:06 *** andythenorth has joined #openttd
08:47:54 *** andythenorth has joined #openttd
09:25:03 *** sla_ro|master has joined #openttd
09:54:51 *** andythenorth has joined #openttd
09:58:58 *** matt21347 has joined #openttd
09:59:41 *** jottyfan has joined #openttd
10:47:14 *** Progman has joined #openttd
11:15:15 *** longtomjr_ has joined #openttd
12:30:48 *** m1cr0man has joined #openttd
13:19:10 *** matt21347 has joined #openttd
13:43:41 *** HerzogDeXtEr has joined #openttd
14:39:57 *** andythenorth has joined #openttd
15:07:14 *** WormnestAndroid has quit IRC
15:13:20 *** WormnestAndroid has joined #openttd
15:46:36 *** WormnestAndroid has quit IRC
15:59:16 *** WormnestAndroid has joined #openttd
16:02:45 <FLHerne> Aaargh, the deprecation spam when compiling old-FIRS
16:06:11 *** jottyfan has joined #openttd
16:06:11 <FLHerne> I think nml needs some filters
16:06:28 <FLHerne> Or maybe stop printing them after the <nth> warning?
16:06:31 <andythenorth> how often do we anticipate people compiling old FIRS?
16:07:23 <LordAro> an equivalent of -Wno-deprecated might be nice
16:07:44 <FLHerne> I think I can understand 'accept_cargo_types' is deprecated, consider using 'cargo_types' instead after the first warning, I don't need another 500
16:08:24 <FLHerne> andythenorth: Until you make v4 the master branch, or I stop forgetting to check it out :p
16:09:38 <andythenorth> what's left to finish in FIRS 4?
16:10:09 <andythenorth> including closure, which is impossible
16:10:27 <andythenorth> probably strikethrough that
16:10:27 <FLHerne> Always good to keep an impossible task
16:10:41 <FLHerne> Then there's no pressure to finish the others, because they're not on the critical path
16:11:10 <andythenorth> there's only about 20 things left to do
16:13:11 <TrueBrain> bah .. ideally I want to upgrade mediawiki before comparing HTML .. the HTML of our version is .. shitty? :P
16:13:12 <FLHerne> Actually, impossible tasks aren't ideal
16:13:49 <FLHerne> What you really need is a task that relies on something outside your control, that isn't going to happen, hypothetically happening at some point
16:14:21 <FLHerne> Are you sure the new version is any less shitty?
16:14:30 <TrueBrain> the HTML got some love
16:14:35 <TrueBrain> and uses more modern functionalities
16:14:46 <TrueBrain> owh well .. I just have to proof once it is (near) identical :D
16:20:56 <TrueBrain> the use of capitals in our wiki is a total mess :D
16:23:03 <glx> FLHerne: yeah nml warns very easily and too much, but there's no way to filter warning types yet
16:26:50 *** supermop_Home_ has joined #openttd
16:27:54 *** WormnestAndroid has quit IRC
16:30:21 <FLHerne> glx: Yeah, I was thinking of adding it (again)
16:32:26 *** jottyfan has joined #openttd
16:34:24 <glx> oh and #78 will add more warnings ;)
16:38:36 <TrueBrain> (foo * 4) % 5 + 6) <- 160? Lol .. wtf is 160, lets find out ..
16:41:50 <LordAro> glx: you should merge #103
16:42:16 <LordAro> one of them, at least
17:05:35 <FLHerne> glx: I need to fix the circular import
17:06:00 <FLHerne> The trivial way would be to import binop inside the function call, but that might hurt performance a bit
17:06:11 <TrueBrain> w00p, the diff of comparing with mediawiki starts to become really small for some complex pages .. :D Hopefully soon I can just run the whole wiki :P I like knowing the parser does what it should be doing :D
17:07:10 <FLHerne> I'm quite sure it's not actually a problem, it just upsets the checker
17:07:58 <LordAro> it'd be nice to fix for code-cleanliness reasons, but ultimately we can just make the error as a false positive/won't fix
17:11:35 <FLHerne> LordAro: I guess that clears the way for your even bigger mass change :p
17:15:29 <LordAro> already reached that conflict :)
17:15:35 <FLHerne> Well, you'd see the rebase conflict anyway
17:18:12 <FLHerne> glx: Is anything needed for that one?
17:20:59 <glx> it should be ok, all my local tests passed
17:21:22 <LordAro> so very glad i rewrote the PR to break the changes up into re-runnable chunks
17:21:30 <LordAro> only had to fix 4 new flake8 errors :p
17:22:37 <LordAro> ah crap, missed something
17:23:22 <LordAro> except... no i didn't?
17:27:37 <LordAro> ooh, forgot the line length
17:28:22 <LordAro> well, the diff output will be useful anyway
17:49:19 <TrueBrain> Especially as another is open for longer :p
17:55:59 <FLHerne> LordAro: I guess the CodeQL issues are just reformatted versions of existing ones...
17:56:08 <FLHerne> The ones I checked so far are
17:58:07 <andythenorth> nml release? o_O
17:58:21 <LordAro> only codechanges really
18:04:20 <FLHerne> LordAro: What does the `assignment` -> `existing_assignment` change fix?
18:04:45 <FLHerne> It seems to just add verbosity for no reason
18:05:12 <FLHerne> (in 'non-formatting-related flake8 fixes')
18:09:29 <LordAro> FLHerne: there's an import named assignment
18:09:38 <LordAro> so fixing variable shadowing
18:17:04 * FLHerne tries to think of a shorter different name :p
18:17:42 <FLHerne> LordAro: What's going on with "Move Action0 properties table..."? It's a bit hard to interpret the every-line-changed diff :p
18:18:15 *** jottyfan has joined #openttd
18:19:23 <glx> the PR is easier to read now, with all the commits, than the last time :)
18:19:31 <andythenorth> hmm will deliveroo arrive on time?
18:21:07 <LordAro> FLHerne: there's a few commits you just have to trust that i only moved code, rather than actually changed anything :p
18:23:02 <andythenorth> we have complete test coverage.....right? :P
18:24:23 <LordAro> andythenorth: i don't think anyone's dared measure it
18:37:43 <FLHerne> LordAro: I meant 'mapped' instead of 'existing_assignment'
18:37:53 <FLHerne> i.e. `for mapped in self.mapping`
18:38:18 <LordAro> "mapped" is very different to "assignment"
18:38:27 <LordAro> but i don't really know the code
18:40:04 <glx> it's for recolour sprites
18:40:29 <FLHerne> LordAro: Recolour sprites are a mapping of one or more (ranges of) colours to different ones
18:40:59 <FLHerne> Each assignment is one mapped colour [range?]
18:41:07 <FLHerne> At least if I understand the code correctly
18:41:40 <FLHerne> Incidentally, I note that it's "Recolor sprite" in the NFO docs and "Recolour sprite" in NML :p
18:43:27 <glx> so mapping is a list of assignment.Assignment
18:44:34 <FLHerne> [afk, walk dog while light-ish]
18:44:46 <LordAro> "for recolour in self.mapping:" ?
19:23:30 <FLHerne> LordAro: I thought about the action0properties thing a bit more, I still think it's wrong :-(
19:24:55 <FLHerne> Semantically, it's a mapping from specific, meaningful, not-quite-contiguous values to each set of properties
19:25:11 <FLHerne> A dict represents that better than a list
19:25:55 <LordAro> i agree, but that's a bigger change than i was willing to go to
19:25:56 <FLHerne> And the reason it avoids #fmt on/off is that it moves all the pieces of code away from where they're actually used
19:26:14 <FLHerne> Which makes it harder to read, not easier
19:26:53 <FLHerne> At the moment, all the property-specific helper functions are next to the one or two properties they're used for
19:27:23 <FLHerne> It was a dict already, no?
19:27:56 <LordAro> it used hex indices, which made it a little less clear
19:28:27 <FLHerne> I don't think the hex indices make it less clear
19:28:32 <FLHerne> They're not arbitrary
19:29:09 <LordAro> they make it less clear between whether it's a list or dict, i mean
19:29:16 <glx> hex should be replaced with named values at some point probably
19:29:18 <LordAro> but i added the big comments with titles
19:29:25 <FLHerne> The comments do make it more clear
19:29:55 <LordAro> just as clear as it was, imo, even more so for the ones that are None
19:30:12 <LordAro> i do agree with the whole splitting code/data though, but i can't really think of a better solution
19:30:23 <LordAro> splitting it into individual files per property, perhaps?
19:30:36 <FLHerne> I think that would probably be overkill
19:30:45 *** gelignite has joined #openttd
19:31:07 <FLHerne> In the short term, more #fmt comments? :p
19:31:35 <FLHerne> Maybe it would make sense to split them out a bit
19:32:05 <FLHerne> e.g. all the tracktype properties in one file would make some sense
19:34:00 <FLHerne> I don't love any of the possible solutions :-/
19:45:21 <FLHerne> andythenorth: Dogs are good
19:52:05 <DorpsGek_III> - Update: Translations from eints (by translators)
20:06:38 *** sla_ro|master has joined #openttd
20:11:10 *** Eddi|zuHause has joined #openttd
20:27:53 *** Speeder_ has joined #openttd
20:31:03 *** Eddi|zuHause has joined #openttd
20:50:41 *** Eddi|zuHause has joined #openttd
20:53:37 <andythenorth> oof too much tanks
20:53:50 <andythenorth> priorities all wrong
21:01:15 <FLHerne> Not tanks of beer, then
21:11:04 *** Eddi|zuHause has joined #openttd
21:21:29 <TrueBrain> yippie, my compare script was not for nothing ..
21:21:31 <TrueBrain> -<tr style="background-color:transparent">
21:21:36 <TrueBrain> it finds mistakes in my renderer :D
21:46:38 <FLHerne> CodeQL seems to be producing some nonsense errors :-(
21:47:14 <FLHerne> `mul` should always be an integer, which isn't mutable
21:47:59 <FLHerne> And if you click 'Show paths' to see why it disagrees, it just highlights odd ranges at random
21:49:56 <andythenorth> hmm how do pre-signals work?
21:59:42 <andythenorth> I don't think pre-signals help me
21:59:55 <andythenorth> I want a signal that paths can be reserved through
22:00:07 <andythenorth> but a train will safely stop at if it cannot reserve a path
22:00:15 <andythenorth> this would allow prioritising merges
22:12:46 <andythenorth> seems I don't mean a merge
22:13:20 <andythenorth> 1 line per train anyone? o_O
22:25:55 *** Progman has joined #openttd
22:33:41 <FLHerne> What do you mean by a merge, then?
23:02:29 *** Xunie__ has joined #openttd
23:07:57 *** Xunie is now known as Guest3686
23:09:38 *** jottyfan has joined #openttd
23:19:30 <andythenorth> FLHerne I mean a junction, nothing like a merge
23:20:26 <andythenorth> it's a crossing, trains from sources A and B can choose between destinations C and D, and I wanted to prioritise trains on the track from A
23:21:29 <andythenorth> but I replaced it with dedicated lines for each source-destination instead, much easier
23:23:48 *** andythenorth has left #openttd
23:34:56 *** HerzogDeXtEr has joined #openttd
continue to next day ⏵