IRC logs for #openttd on OFTC at 2020-10-11
⏴ go to previous day
00:00:57 *** snail_UES_ has joined #openttd
01:45:48 *** ChanServ sets mode: +v tokai
02:53:13 *** tokai|noir has joined #openttd
02:53:13 *** ChanServ sets mode: +v tokai|noir
04:03:58 *** ChanServ sets mode: +v tokai
08:19:31 *** andythenorth has joined #openttd
08:32:51 *** sla_ro|master has joined #openttd
08:48:47 *** jottyfan has joined #openttd
09:05:36 *** Progman has joined #openttd
09:12:29 <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth commented on issue #6207: Autorenew fails for articulated vehicles with mixed cargo https://git.io/fh3Dt
09:12:29 <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth reopened issue #6207: Autorenew fails for articulated vehicles with mixed cargo https://git.io/fh3Dt
09:22:02 *** Wolf01 is now known as Guest3233
09:42:05 *** longtomjr_ has joined #openttd
09:48:36 *** matt21347 has joined #openttd
09:57:28 *** tokai|noir has joined #openttd
09:57:28 *** ChanServ sets mode: +v tokai|noir
10:41:29 *** andythenorth has joined #openttd
10:52:27 <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth commented on pull request #8278: Feature: tiles/day velocity unit https://git.io/JTTmo
11:02:52 *** HerzogDeXtEr has joined #openttd
11:13:55 <TrueBrain> don't be sane andythenorth :P
12:11:56 *** ChanServ sets mode: +v tokai
12:29:20 *** frosch123 has joined #openttd
13:30:17 <Eddi|zuHause> ... was i out of line?
13:30:33 <Eddi|zuHause> i haven't interacted with a lot of people lately
13:42:01 <andythenorth> Eddi|zuHause you forgot the smiley
13:42:09 <andythenorth> github is not great for emoticons
13:44:59 *** jottyfan has joined #openttd
13:48:11 <frosch123> andythenorth: yep, wiki migration is more interestnig
13:50:50 <andythenorth> I have designed out the problem for now :)
13:50:58 <andythenorth> only one of this vehicle type
13:56:46 <DorpsGek_III> [OpenTTD/OpenTTD] Eddi-z commented on issue #6207: Autorenew fails for articulated vehicles with mixed cargo https://git.io/fh3Dt
14:02:02 <andythenorth> could a vehicle be marked up as 'ineligible for auto-replace'?
14:02:12 <andythenorth> is that just more newgrf string?
14:02:48 <andythenorth> maybe we could move / copy the IsArticulatedVehicleCarryingDifferentCargoes check to wherever the valid replacements list is built?
14:03:30 * andythenorth wonders where that is
14:06:44 <Eddi|zuHause> andythenorth: no, i don't think that works. because the default configuration might be to carry all the same cargos, but then it is changed later by manual refitting
14:07:18 <andythenorth> I'm not so minded to try and make it work
14:07:23 <andythenorth> as to not silently fail
14:08:13 <andythenorth> that's why I think explicitly banning it in newgrf isn't an implausible solution
14:08:20 <andythenorth> although it does seem like a bad pattern
14:08:32 <Eddi|zuHause> i think there was a message for failed autoreplace, but it wasn't very helpful on giving a reason. and it is lumped with other vehicle info messages which people would probably disable because of spam
14:10:00 <andythenorth> interestingly I can't replace from mail+pax articulated vehicle to non-articulated pax vehicle
14:10:10 <andythenorth> or any other vehicle
14:10:33 <andythenorth> we could enforce that only one refit is possible in an articulated vehicle?
14:11:36 <Eddi|zuHause> because we can't retroactively invalidate existing newgrfs
14:12:06 <Eddi|zuHause> just because it conflicts with some obscure unrelated game mechanic
14:13:09 <andythenorth> could just say nml doesn't permit it?
14:13:14 <andythenorth> and enforce it on compile?
14:13:44 <Eddi|zuHause> i don't think nml has that kind of analysis capacity
14:14:50 <andythenorth> so was I correct when I closed the ticket as 'not supported'? :)
14:19:19 <glx> couldn't the line you linked return CT_NO_REFIT ?
14:20:26 <glx> (I didn't really check the code)
14:25:37 <andythenorth> could just put a note in buy menu
14:25:41 <andythenorth> 'broken with autoreplace'
14:38:34 <Eddi|zuHause> andythenorth: can you come up with a way to notify people which doesn't drown the player in repeated messages?
14:39:18 <Eddi|zuHause> ... assuming the player sends 200 vehicles to replace, and the check runs on every attempted refit
14:41:41 <glx> the best place to warn is probably when setting the replacement of an articulated engine ("this replacement may fail...")
14:42:18 <Eddi|zuHause> glx: i'm not sure we know enough at that moment
14:45:22 <glx> we now if the engine can carry different cargo by default, and the replacement can happen only if it has been refited to carry only one type
14:48:42 <Eddi|zuHause> trying to detect the situations that might fail sounds equally problematic than trying to pick a reasonable "best effort" resolution
14:59:57 <andythenorth> I am -1 to messages tbh
15:00:52 <andythenorth> I would favour banning these vehicles from autoreplace
15:01:03 <andythenorth> but I see no way to do that short of attempting a refit when the menu is constructed
15:01:07 <andythenorth> which seems very unwise
15:01:43 <frosch123> cloning works, right?
15:02:27 <frosch123> then autorenew could probably also work
15:03:36 <glx> yeah autorenew is not autoreplace
15:24:24 *** arikover has joined #openttd
17:16:44 *** snail_UES_ has joined #openttd
17:42:59 *** gelignite has joined #openttd
17:46:21 *** Wormnest has joined #openttd
17:49:17 *** azubieta has joined #openttd
17:54:42 *** andythenorth has joined #openttd
18:01:23 <andythenorth> ho, how do I fetch a PR from glx if not a remote?
18:02:49 <andythenorth> it's just a commit, not a PR yet?
18:03:01 <glx> don't, it doesn't really work
18:03:29 <glx> by luck it's ok for iron horse because they are not refitable
18:03:47 <glx> but I think it will fail for PKP
18:04:31 <andythenorth> I don't see how to do it with refittability
18:04:37 <andythenorth> short of trying the refits
18:04:47 <andythenorth> and then..in what order, for which vehicles...
18:04:53 <andythenorth> and then...does the newgrf allow it?
18:04:59 <glx> probably need to check how clone does it
18:38:04 <TrueBrain> openttd.org nameservers are now switched to AWS. This should not lead to any issue what-so-ever, but let me know if sites are now all of a sudden unreachable or what-ever :)
19:53:44 <DorpsGek_III> - Update: Translations from eints (by translators)
19:58:06 <andythenorth> glx works for simple cases I tested so far :)
20:03:41 <andythenorth> ok that's interesting
20:04:10 <andythenorth> I can replace articulated engine (pax+mail) <-> engine (no capacity)
20:04:38 <andythenorth> can't replace articulated engine (pax+mail) <-> articulated engine (pax+mail)
20:04:41 <andythenorth> intended result?
21:10:22 <glx> It just handles auto renew, auto replace stuff should be unchanged
21:33:02 <glx> <andythenorth> I can replace articulated engine (pax+mail) <-> engine (no capacity) <-- this works because it's tested before articulated check
21:33:24 <glx> and it's untouched in my code :)
21:38:51 <andythenorth> yup, I was testing wrong in trunk
21:47:54 <andythenorth> silly andythenorth
22:00:33 *** WormnestAndroid has quit IRC
22:06:59 *** WormnestAndroid has joined #openttd
22:27:26 *** Wormnest has joined #openttd
23:19:47 <frosch123> TrueBrain: sending mails from info@ may be broken :)
23:20:19 *** WormnestAndroid has quit IRC
23:24:48 *** WormnestAndroid has joined #openttd
23:28:53 <frosch123> TrueBrain: yeah, both snmp and imap did not survive the nameserver stuff
continue to next day ⏵