IRC logs for #openttd on OFTC at 2020-09-28
⏴ go to previous day
07:05:35 *** sla_ro|master has joined #openttd
07:32:11 *** jottyfan has joined #openttd
08:47:07 *** andythenorth has joined #openttd
09:01:19 <TrueBrain> DorpsGek_III doesn't mention when there are new discussions in Teams .. is that a new thing we want? :P
09:01:35 <TrueBrain> eints has bugs! Pretty sure this bug has always been there, just nobody bothered to report it :D
09:10:35 *** jottyfan has joined #openttd
09:13:04 <Eddi|zuHause> on a related note: apparently i'm now a team member and get emails about topics i can't possibly do anything about :p
09:18:02 <DorpsGek_III> [OpenTTD/eints] TrueBrain opened pull request #18: Error handling was a bit broken for string-editor https://git.io/JUiDP
09:18:48 <TrueBrain> we really should open "issues" on the GitHub eints page tbfh ..
09:20:51 <DorpsGek_III> [OpenTTD/eints] TrueBrain updated pull request #18: Error handling was a bit broken for string-editor https://git.io/JUiDP
09:21:03 <TrueBrain> as I am pretty sure this user used the Team discussion, as it could not find any other place :D
09:24:23 <DorpsGek_III> [OpenTTD/eints] TrueBrain updated pull request #18: Error handling was a bit broken for string-editor https://git.io/JUiDP
09:30:53 <LordAro> TrueBrain: does that fix telk's issue?
09:35:51 <TrueBrain> frosch123: by the time you read this: what is needed to migrate the issues from openttdcoop to GitHub for eints? :)
09:36:03 <TrueBrain> do they need migrating .. :)
10:01:52 *** jottyfan has joined #openttd
10:14:31 <TrueBrain> LordAro: euh, no, sorry; I confused two names
10:14:33 <TrueBrain> that is annoying :P
10:14:39 <TrueBrain> this resolves the issue reported by ..
10:15:06 <TrueBrain> I know of no issue with telk
10:15:17 <TrueBrain> sorry, there was only 1 open issue, so I jumped to a conclusion :D
10:15:53 <DorpsGek_III> [OpenTTD/eints] LordAro approved pull request #18: Error handling was a bit broken for string-editor https://git.io/JUi7b
10:15:57 <TrueBrain> when you make a {G or {P error, you get a backtrace, instead of telling you WHAT the error was :P
10:16:13 <DorpsGek_III> [OpenTTD/eints] TrueBrain merged pull request #18: Error handling was a bit broken for string-editor https://git.io/JUiDP
10:17:15 <TrueBrain> what other issue was there LordAro ?
10:19:25 <andythenorth> silly town limits
10:19:32 <andythenorth> we're really missing some opportunities
10:19:45 <andythenorth> we need a newgrf or GS NewLegislativeFramework
10:19:51 <TrueBrain> LordAro: you can check if he is really added to the right Team on GitHub
10:19:55 <andythenorth> speed limits, clean air zones, noise limits etc
10:19:59 <TrueBrain> otherwise, possibly he has to logout + login .. dunno
10:21:28 <TrueBrain> as you can see here, his invite is pending. When people are approved, they get an invite in their mailbox to join the organization
10:21:33 <TrueBrain> they have to click that link, of course :)
10:21:44 *** andythenorth has left #openttd
10:22:02 <TrueBrain> it is in the message DorpsGek gives
10:27:28 <TrueBrain> I am really surprised how many people either read the OpenTTD news, or were visiting the translator page on a regular base or something :D
13:03:16 <DorpsGek_III> [OpenTTD/OpenTTD] FayneAldan commented on issue #8313: OpenTTD does not find GM.CAT when named uppercase. https://git.io/JUudP
13:28:32 <DorpsGek_III> [OpenTTD/OpenTTD] FayneAldan commented on pull request #8321: Fix #8313: Baseset Capitalization https://git.io/JUPYM
13:33:40 <DorpsGek_III> [OpenTTD/OpenTTD] FayneAldan opened pull request #8322: Fix #8313: Correct capitalization on baseset filenames https://git.io/JUPO4
13:41:28 <TrueBrain> LordAro: btw, not sure how "complete" you considered your GitHub Action, but you can already of course merge the CI part without doing the release part
13:41:38 <TrueBrain> just remember to also make part of your PR to remove the azure-pipelines code :)
13:49:21 <LordAro> need to tidy it up a bit
13:49:29 <LordAro> and see about those composite things again
13:49:41 <DorpsGek_III> [OpenTTD/OpenTTD] FayneAldan commented on pull request #8321: Fix #8313: Baseset Capitalization https://git.io/JUPsW
13:50:58 <TrueBrain> for what you have now, composite isn't going to help, is it?
13:51:02 <TrueBrain> there is little to no duplication going on :)
14:00:14 <LordAro> there's the ogfx stuff
14:19:27 <TrueBrain> so I wouldn't worry about it for now
14:20:04 <TrueBrain> the duplication in workflows we have for all the Python repositories, that is something that we might want to fix :D
14:39:22 *** blathijs has joined #openttd
14:52:33 *** snail_UES_ has joined #openttd
14:52:37 <TrueBrain> LordAro: "composite" workflow is basically a GitHub Action, but instead of using nodejs or docker, it runs "composite" mode
14:52:51 <TrueBrain> otherwise, it behaves nearly identical to a GitHub Action :)
14:52:57 <TrueBrain> it is a clever way, tbh
14:53:11 <TrueBrain> but a bit of a mindfuck, as it is not like an "include"
15:44:01 <DorpsGek_III> [OpenTTD/actions] TrueBrain opened pull request #15: Share common GitHub workflows in "composite actions" https://git.io/JUPuU
15:44:06 <TrueBrain> still testing if this really works, but just to give an idea how they can be used
15:45:58 <DorpsGek_III> [OpenTTD/eints] TrueBrain opened pull request #19: Add: [Actions] use composite actions for commit-checker https://git.io/JUPuZ
15:46:54 <TrueBrain> well, that failed :D
15:47:36 <TrueBrain> you cannot "use" other actions from a composite action
15:47:40 <TrueBrain> okay, that makes it rather useless .. lol
15:47:57 <TrueBrain> so it only works for "bash" blobs, basically
15:48:45 <TrueBrain> well, that was a waste of time :P
15:51:56 *** supermop_Home_ has joined #openttd
15:53:21 <TrueBrain> owh, it is on their roadmap
15:56:29 <DorpsGek_III> [OpenTTD/eints] TrueBrain commented on pull request #19: Add: [Actions] use composite actions for commit-checker https://git.io/JUPz1
15:56:29 <DorpsGek_III> [OpenTTD/eints] TrueBrain closed pull request #19: Add: [Actions] use composite actions for commit-checker https://git.io/JUPuZ
15:57:51 <DorpsGek_III> [OpenTTD/actions] TrueBrain commented on pull request #15: Share common GitHub workflows in "composite actions" https://git.io/JUPz5
15:57:51 <DorpsGek_III> [OpenTTD/actions] TrueBrain closed pull request #15: Share common GitHub workflows in "composite actions" https://git.io/JUPuU
16:01:52 <TrueBrain> so basically LordAro , I tried this so you don't have to :P And really .. don't :D Unfinished work from GitHub (by an intern, as it turns out, who is no longer interning at GitHub .. so who knows how long it is going to take :D)
17:05:58 <LordAro> TrueBrain: could be useful for not rerunning redundant stages
17:06:24 <LordAro> e.g. if only docs have changed (not really work it for a repo of this size/build time though)
17:06:41 <LordAro> wonder if gitlab has something similar, could be useful for work...
17:35:44 *** frosch123 has joined #openttd
17:37:34 *** tokai|noir has joined #openttd
17:37:34 *** ChanServ sets mode: +v tokai|noir
17:53:19 *** Wormnest has joined #openttd
18:04:07 *** HerzogDeXtEr has joined #openttd
18:21:55 *** Progman has joined #openttd
19:31:19 *** andythenorth has joined #openttd
19:52:09 <DorpsGek_III> - Update: Translations from eints (by translators)
19:58:09 <TrueBrain> Translations haven't been this active in months :p
20:17:25 <LordAro> the first line of the commit message should contain the number of changes
20:24:55 *** gelignite has joined #openttd
22:19:03 <frosch123> TrueBrain: i enabled issues for eints
22:19:35 <frosch123> though no idea why you waited for me
22:30:05 *** andythenorth has joined #openttd
22:39:51 <TrueBrain> Didn't know if there was still a reason ;(
22:40:08 <TrueBrain> Do we want to port over the ones from Redmine?
22:42:29 <frosch123> noone did it in 1.5 years, do you want to?
22:43:40 <frosch123> but it was too meh for me
22:44:34 <TrueBrain> If nobody cared in 18 months .. I am sure we will survive :p
22:44:53 <TrueBrain> We can look over if anything useful is between them
22:47:53 <frosch123> andythenorth: do you still want to add font awesome? :)
22:50:41 <frosch123> i guess there are like 5 feature requests that are reasonable
22:52:10 <TrueBrain> So we copy/paste those over? :D
23:11:14 <andythenorth> frosch123 let's agree 'no'
continue to next day ⏵