IRC logs for #openttd on OFTC at 2020-09-06
⏴ go to previous day
00:02:14 *** Wormnest has joined #openttd
00:03:48 *** WormnestAndroid has quit IRC
00:03:51 *** WormnestAndroid has joined #openttd
01:00:15 <DorpsGek_III> [OpenTTD/OpenTTD] ldpl opened pull request #8305: Fix: Only check house acceptance when generating subsidies to towns https://git.io/JUGId
01:02:40 <DorpsGek_III> [OpenTTD/OpenTTD] ldpl updated pull request #8305: Fix: Only check house acceptance when generating subsidies to towns https://git.io/JUGId
01:04:39 <DorpsGek_III> [OpenTTD/OpenTTD] ldpl updated pull request #8305: Fix: Only check houses for cargo when generating subsidies with towns https://git.io/JUGId
02:19:16 *** daspork_ has joined #openttd
05:33:03 *** snail_UES_ has joined #openttd
05:41:00 *** WormnestAndroid has quit IRC
05:42:28 *** WormnestAndroid has joined #openttd
05:48:37 *** WormnestAndroid has quit IRC
05:50:42 *** WormnestAndroid has joined #openttd
08:37:33 *** andythenorth has joined #openttd
09:13:46 *** sla_ro|master has joined #openttd
09:29:39 *** Progman has joined #openttd
10:29:21 *** frosch123 has joined #openttd
10:54:08 *** gelignite has joined #openttd
10:56:11 *** WormnestAndroid has quit IRC
10:56:24 *** WormnestAndroid has joined #openttd
14:36:38 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #8305: Fix: Only check houses for cargo when generating subsidies with towns https://git.io/JUGVx
14:41:23 <TrueBrain> someone really did some math on that ...
14:48:35 <TrueBrain> hmm .. you cannot see the current date on a dedicated server?
14:53:17 <frosch123> hmm, i am not sure ruby is really an improvement over perl...
14:54:36 <TrueBrain> it was suppose to be?
14:55:06 <frosch123> i thought that was its plan
14:58:31 *** WormnestAndroid has quit IRC
15:00:06 *** WormnestAndroid has joined #openttd
15:11:26 <TrueBrain> okay, now sorting the serverlist .. eeuuuhhhh
15:11:43 <TrueBrain> lets see if we can do that in such way we never have to do it manually again
15:12:30 <frosch123> randomly drop servers which include "city" or "goal" in their name?
15:13:40 <TrueBrain> I was thinking of making a navigation with "Latest", "Official", "JGRPP", "Other"
15:13:46 <TrueBrain> where you only see servers of that type
15:13:51 <TrueBrain> would that be an improvement?
15:15:04 <glx> same as latest on the website
15:15:30 <frosch123> set with some gh action on release?
15:16:47 <TrueBrain> but sure, "stable" works for me
15:17:06 <frosch123> hmm, are we talking about the in-game server list? or the website server list?
15:17:23 <TrueBrain> I am not touching OpenTTD client; staying far away from that
15:18:07 <frosch123> did you figure out a purpose for the website except for answering "is my server advertised properly"?
15:18:22 <TrueBrain> was that question ever asked?
15:19:07 <frosch123> i thought there were some questions wrt. what is needed :) but i did not follow the discussion
15:20:28 <TrueBrain> only that we are dropping NewGRF info, that we talked about
15:20:34 <frosch123> but when people ask for how to debug their clients not finding their server, the answer used to be: check servers.openttd.org to figure out whether server or client is at fault
15:21:58 <glx> oh with #7981 it could be possible to lauch openttd from the website
15:24:27 <TrueBrain> anyway, that was not my question nor really helping :P
15:25:20 <glx> hehe, but yeah filtering on the website would be a nice feature
15:26:42 <TrueBrain> I wonder if I could hardcode "jgrpp"
15:27:04 <TrueBrain> we don't really have a place that indexes these things
15:27:28 <frosch123> we have a fixed format for the version
15:27:53 <TrueBrain> patchpacks can violate that :)
15:27:56 <frosch123> so you could do the reverse of what findversion used to do
15:28:14 <frosch123> and just split at the last "-" to dynamically create a list of branches
15:28:38 <TrueBrain> check the current server-list ;) The one non-official patchpack out there does not follow findversion :)
15:29:53 <frosch123> hmm, so i misremeber the findversion format? i thought it was "{branch}-{version}"
15:30:58 <TrueBrain> "20200813-master-g3db7cf54fd"
15:31:26 <TrueBrain> even findversion used the "tag"
15:31:37 <TrueBrain> and there is no absolute truth in that, when looking at patchpacks
15:31:52 <TrueBrain> the official releases always use major.minor.patch-beta etc
15:32:00 <TrueBrain> and jgrpp uses jgrpp-major.minor.patch
15:32:05 <TrueBrain> but there isn't a single truth
15:33:12 <TrueBrain> but anyway, that was not really the question
15:33:22 <TrueBrain> I want to make a button "Stable" / "Official" / "JGRPP"
15:33:31 <TrueBrain> and I wonder if I can hardcode the latter or not .. if I can do something more clever there
15:33:42 <TrueBrain> currently we only have jgrpp
15:33:53 <TrueBrain> not sure if it is worth the effort now to make that into anything more
15:33:55 <frosch123> and no nightlies :)
15:34:07 <TrueBrain> we rarely have nightlies, like .. there currently are no nightlies public
15:34:55 <frosch123> maybe just sort the versions by popularity
15:35:30 <TrueBrain> again, not what I am talking about :)
15:36:05 <frosch123> oh, that's what you mean with button
15:36:06 <TrueBrain> I wonder if hardcoding "JGRPP" is a good idea or not
15:36:21 <frosch123> i thought you just wanted a inner-page#link
15:36:31 <TrueBrain> "I was thinking of making a navigation with "Latest", "Official", "JGRPP", "Other"" <- that is how I started my story :P
15:37:12 <frosch123> i already have difficulties with "latest" and "official" :)
15:37:34 <frosch123> would a nightly go into latest? or would get dropped into the category of ancient releases?
15:38:25 <frosch123> does "official" mean "unmaintained servers that need upgrading"?
15:38:40 <frosch123> "better don't play here"?
15:38:56 <TrueBrain> I think you are greatly overthinking this, and trying ... "van een mug een olifant maken"
15:39:02 <TrueBrain> pretty sure you have something closely relating to that saying :P
15:39:33 <TrueBrain> I want to split out JGRPP servers from the official ones
15:39:39 <TrueBrain> what we label shit, I do not care :P
15:39:53 <TrueBrain> and currently we make a difference between "latest" release, and all others
15:40:00 <TrueBrain> not sure that is needed
15:40:26 <frosch123> it assumes that everyone should play latest, while the rest should upgrade
15:40:39 <frosch123> but the same holds for "latest jgr" and "jgr from 3 years ago"
15:41:07 <TrueBrain> how is upgrading relevant in this story? Not really following your thoughts here :(
15:41:43 <frosch123> ok, what is your intention for splitting out anything then?
15:41:53 <frosch123> why not a single list with everything?
15:42:28 <TrueBrain> because jgrpp is now drowning in a list of official servers
15:42:39 <TrueBrain> and if you visit that site, you most likely either want to see the official ones
15:42:45 <frosch123> or maybe a query param to filter for specific version string, so people can link to servers.openttd.org?version=jgrpp-0.36.0
15:42:48 <TrueBrain> basically, just being more friendly for patchpacks
15:44:11 <frosch123> anyway, i still think, if you do categories, it should detect them by itself, based on popularity
15:44:37 <TrueBrain> as there is no set way of defining a version, that is near-impossible
15:44:42 <TrueBrain> it can only be correct for the current set, basically
15:44:47 <frosch123> but i also think it is fine, if people could just link from extern sites to specific filters
15:45:09 <TrueBrain> so a filter is fine, which still leaves the question: what do we put in the navigation :)
15:45:34 <frosch123> "all servers", "servers with version with specific prefix", "servers with exact version"
15:46:00 <frosch123> i don't think it needs a navigation
15:47:12 <frosch123> a navigation only makes sense, if people are supposed to discover new versions through that page, and then you would need to provide a download link at least
15:47:51 <TrueBrain> that would be the next step, yes :P
15:54:09 <TrueBrain> okay ... sorting seems to be working now .. and better than the current solution .. lolz
15:54:46 <TrueBrain> we are missing flag-images of 7 countries
15:55:01 <TrueBrain> I wouldn't know where we got them from
15:57:02 <frosch123> they are in openttd.grf
15:57:24 <TrueBrain> I need them in a gif format :P
15:57:35 <TrueBrain> I am missing flag 29 .. 35
15:58:59 <TrueBrain> if someone can extract 29 .. 35 in gif format, that would be swell
15:59:10 <frosch123> maybe you can do some html magic to crop the image to the desired flag
15:59:29 <TrueBrain> yeah, but maybe I am completely and utterly done with this HTML + CSS crap :P
15:59:38 <TrueBrain> this was really a horrible 3 hours of my life :(
16:00:23 <TrueBrain> given all that remains is that someone makes me 6 GIFs, I am not going to drop them completely ;)
16:00:24 <frosch123> i think more people are annoyed about flags representing languages than there are people noticing them missing
16:00:50 <TrueBrain> lol, I haven't heard that debate in years :P But I remember it was a thing
16:01:33 <TrueBrain> I also always wonder what a language of "All" means
16:01:57 <frosch123> i thought it means "saying anything results in kick"
16:02:14 <TrueBrain> but okay, as mentioned, I just want this nightmare to be over, so people can make PRs if they want it fixed
16:10:22 <TrueBrain> if anyone would be so kind to approve those :)
16:15:04 <TrueBrain> and to rant a bit more: I really really do not enjoy writing webapps anymore, as it turns out :P I am fine with most other parts of the web, but HTML, CSS, and all the weird shit around that .. fuck me :P But okay, the web part is done, and looks mostly the same as the current servers.openttd.org :) (minus shit we removed, minus things that annoyed me :P)
16:18:18 <TrueBrain> frosch123: I btw simply copied bananas-frontend-web, and changed shit :P That made it go a lot quicker :D
16:39:27 <DorpsGek_III> [OpenTTD/master-server-web] TrueBrain merged pull request #1: Add: [DorpsGek] announce issues, pull-requests, and tags to IRC https://git.io/JUG6I
16:39:45 <DorpsGek_III> [OpenTTD/master-server-web] TrueBrain merged pull request #2: Add: [Actions] flake8, black, pytest, and docker build tests https://git.io/JUG6Y
16:41:27 <glx> as it's basically copy paste from other repos
16:41:58 <DorpsGek_III> [OpenTTD/master-server-web] TrueBrain opened pull request #3: Add: initial version of a web-frontend for the Master Server API https://git.io/JUGiD
16:42:38 <TrueBrain> as in, it really is :P
16:42:54 <TrueBrain> even the commit messages :D
16:43:49 <TrueBrain> right, tomorrow I will deploy all this to staging
16:43:54 <TrueBrain> see if it really works :)
16:44:04 <TrueBrain> (it does in dev, but .. that is not saying all :P)
17:15:17 *** Wormnest has joined #openttd
17:42:07 <frosch123> what... you added unittests to the master-server :)
17:42:49 <TrueBrain> Yeah ... not sure why :p
17:52:15 <frosch123> i think the reformatting of the tuples after the black update was about that flake warning
18:07:22 <DorpsGek_III> [OpenTTD/master-server-web] frosch123 commented on pull request #3: Add: initial version of a web-frontend for the Master Server API https://git.io/JUGMp
18:11:38 <DorpsGek_III> [OpenTTD/master-server] TrueBrain dismissed a review for pull request #1: Rewritten Master Server in Python https://git.io/JUG15
18:13:17 <DorpsGek_III> [OpenTTD/master-server-web] TrueBrain updated pull request #3: Add: initial version of a web-frontend for the Master Server API https://git.io/JUGiD
18:14:39 <frosch123> flake before push :)
18:14:44 <DorpsGek_III> [OpenTTD/master-server-web] TrueBrain updated pull request #3: Add: initial version of a web-frontend for the Master Server API https://git.io/JUGiD
18:15:03 <TrueBrain> and the frontend-web is missing a test-case .. hmm .. lets add that
18:16:13 <DorpsGek_III> [OpenTTD/bananas-frontend-web] TrueBrain opened pull request #41: Add: [Actions] test if the Docker image can be build https://git.io/JUGDZ
18:16:27 <TrueBrain> owh, more GitHub files are missing it seems ..
18:40:18 *** andythenorth has joined #openttd
19:01:16 <andythenorth> Timberwolf you're doing a US set? o_O
19:23:53 *** Progman has joined #openttd
19:35:19 *** Markk_ is now known as Markk
19:36:55 *** jottyfan has joined #openttd
19:40:06 <andythenorth> hmm my game has £2bn bank balance, the numbers go up / down fast enough to trigger motion sickness
19:45:18 <Timberwolf> andythenorth: I really hope not :)
19:51:27 <andythenorth> my advice is: start lots of projects
19:51:39 <andythenorth> get over-confident by shipping some of them
19:51:50 <andythenorth> then wonder how the hell you'll ever finish the rest
19:51:57 <andythenorth> winning strategy
20:02:53 *** gelignite has joined #openttd
20:18:17 *** sla_ro|master has joined #openttd
20:19:18 *** WormnestAndroid has quit IRC
21:03:26 *** WormnestAndroid has joined #openttd
21:09:38 *** Wormnest has joined #openttd
21:14:12 <TrueBrain> frosch123: with your comments fixed, these PRs can be merged? :)
21:16:48 <DorpsGek_III> [OpenTTD/master-server-web] frosch123 approved pull request #3: Add: initial version of a web-frontend for the Master Server API https://git.io/JUGQx
21:25:23 *** jottyfan has joined #openttd
21:26:52 <DorpsGek_III> [OpenTTD/master-server-web] TrueBrain merged pull request #3: Add: initial version of a web-frontend for the Master Server API https://git.io/JUGiD
21:32:00 <frosch123> does that count to our docker pull quota?
21:32:10 <DorpsGek_III> [OpenTTD/bananas-frontend-web] frosch123 approved pull request #41: Add: [Actions] test if the Docker image can be build https://git.io/JUG7g
21:33:08 <TrueBrain> but I will switch these repos to the GitHub variant soon
21:33:20 <DorpsGek_III> [OpenTTD/bananas-frontend-web] TrueBrain merged pull request #41: Add: [Actions] test if the Docker image can be build https://git.io/JUGDZ
21:33:34 <TrueBrain> hopefully someone else does the OpenTTD CI :)
21:34:22 <frosch123> do we have anyone who likes ruby?
21:34:53 <TrueBrain> sorry, that was not helpful :(
21:35:07 <frosch123> well, some people like apple, so i thought it was worth a try
21:35:33 <andythenorth> I have met people who like ruby
21:35:36 <andythenorth> they are not here though
21:38:04 <TrueBrain> given what we have seen from LordAro , I am sure he knows Ruby :)
21:39:31 <TrueBrain> that sounds very definite :)
21:39:58 <TrueBrain> frosch123: but what are you doing that you have to touch Ruby?
21:40:17 <frosch123> gollum wiki does not work the way it promises to work
21:40:48 <frosch123> the wikicloth gem that is supposed to render mediawiki markup completely fails with templates
21:40:57 <LordAro> i know python quite well
21:41:03 <frosch123> at first i thought it was some configuration setting, but now i am convinced that it is a bug
21:41:03 <LordAro> ruby is just broken python
21:42:05 <frosch123> whenever it wants to transclude a template, it tries to modify a frozen string... or so it says. so it may be easy to fix, if you know ruby or how to debug it
21:42:42 <frosch123> but those are only guesses on my side :)
22:03:41 <TrueBrain> LGTM found 2 (very minor) issues with my 1500 lines of MasterServer code .. I am happy with that result :D
22:04:00 <TrueBrain> frosch123: last I worked with Ruby, I guessed my way through it all
22:04:03 <TrueBrain> never understood what I did
22:04:15 <TrueBrain> in result, someone else had to fix my PR to be ... workable :P
22:16:41 <frosch123> it's even the second time today
22:16:49 <frosch123> earlier he complained about html and css
22:23:45 <TrueBrain> I learn from the best!
23:10:13 *** ChanServ sets mode: +v tokai
continue to next day ⏵
