IRC logs for #openttd on OFTC at 2020-07-03
⏴ go to previous day
00:27:07 *** WormnestAndroid has quit IRC
00:28:09 *** WormnestAndroid has joined #openttd
00:40:50 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz commented on pull request #8259: Fix: Globally apply preprocessor directive coding style https://git.io/JJTsM
00:42:25 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz commented on pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJTsA
00:42:46 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJTsp
00:44:20 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #8259: Fix: Globally apply preprocessor directive coding style https://git.io/JJTGT
00:52:30 *** WormnestAndroid has quit IRC
00:53:20 *** WormnestAndroid has joined #openttd
01:10:24 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJTnn
02:40:38 *** ChanServ sets mode: +v tokai
05:00:43 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz commented on pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJT4A
05:06:03 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz commented on pull request #8259: Fix: Globally apply preprocessor directive coding style https://git.io/JJTBk
05:53:09 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz updated pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJTYj
05:58:28 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz commented on pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJTR2
06:09:00 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz commented on pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJTRd
06:17:06 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz updated pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJTYj
06:40:59 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz updated pull request #8259: Fix: Globally apply preprocessor directive coding style https://git.io/JJTYb
07:57:03 *** andythenorth has joined #openttd
07:59:18 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz closed pull request #8254: Add: Extend DECLARE_ENUM_AS_BIT_SET with extra operations https://git.io/JJUBh
08:02:42 *** sla_ro|master has joined #openttd
08:26:53 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJTzP
08:28:32 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #8259: Fix: Globally apply preprocessor directive coding style https://git.io/JJTzM
08:29:45 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #8258: Codechange #8258: Remove unused town cargo caches from the savegame https://git.io/JJTzS
08:37:27 *** andythenorth has joined #openttd
08:41:54 *** andythenorth has joined #openttd
09:04:34 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJTgD
09:06:25 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJTgS
09:08:09 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJTgQ
09:08:49 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh merged pull request #8259: Fix: Globally apply preprocessor directive coding style https://git.io/JJTYb
09:09:03 <nielsm> now, how many existing PRs broke from that
09:12:08 <CornsMcGowan[m]> sweats nervously
09:12:28 <CornsMcGowan[m]> is there a function to check if two tiles are on the same orthogonal axis?
09:12:41 <CornsMcGowan[m]> eg for dragging roads or canals
09:13:29 <nielsm> not sure, but the way to do it is (x1-y1)==(x2-y2) afaik
09:14:10 <nielsm> depends on which axis you want to check
09:14:23 <CornsMcGowan[m]> just either axis
09:14:43 <CornsMcGowan[m]> oh i could just do
09:15:04 <CornsMcGowan[m]> if tileX(1) == tileX(2) || tileY etc etc
09:31:26 <CornsMcGowan[m]> nvm theres DiagdirBetweenTiles() which returns INVALID_DIAGDIR if not aligned
09:31:47 *** andythenorth has joined #openttd
09:32:49 <CornsMcGowan[m]> is there a way to search for functions by parameter/argument type(s)?
09:36:22 <nielsm> I actually don't think so no
09:36:39 <nielsm> doxygen could maybe have it, but I don't think it does
09:37:12 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz commented on pull request #8259: Fix: Globally apply preprocessor directive coding style https://git.io/JJT2F
09:37:33 *** arikover has joined #openttd
09:39:10 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz commented on pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJT2x
09:40:33 <andythenorth> CornsMcGowan[m] I do a lot of UK <-> AU/NZ conference calls, the timezones have kind of stuck with me :P
09:40:53 <andythenorth> if you'd been 30 minutes off the hour, I'd have known Canberra, but only for part of the year
09:51:40 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz dismissed a review for pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJTzP
09:51:40 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz updated pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJTYj
09:59:05 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz commented on pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJTau
10:01:03 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz updated pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJTYj
10:17:15 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJTVv
10:25:50 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz commented on pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJTVB
10:56:42 *** gelignite has joined #openttd
11:12:06 <CornsMcGowan[m]> if you want to try out the build planner tool, ive implemented a basic version for canals and locks
11:12:42 <CornsMcGowan[m]> i'm not sure if i should rebase onto 1.10.2 or master
11:13:36 <nielsm> master, unless you intend to make a compatible client
11:20:14 <CornsMcGowan[m]> i'm looking for feedback/suggestions on this tool, also bugs of course
11:22:05 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz commented on pull request #8217: Port GUI rendering improvements from JGRPP https://git.io/JJTrd
11:22:50 <CornsMcGowan[m]> should i keep all the build planner tools in one PR? eg rail, road, tram, canal
11:23:13 <CornsMcGowan[m]> or one per transport type
11:23:14 <LordAro> i don't think it should be a PR at all
11:24:04 <CornsMcGowan[m]> what if i want a central place to receive feedback/advice
11:24:22 <LordAro> forum thread, probably
11:24:48 <LordAro> (this is all my opinion, i can't stop you doing whatever you want)
11:25:16 <CornsMcGowan[m]> i could do both
11:25:28 <CornsMcGowan[m]> and a reddit post i guess
11:26:33 *** arikover has joined #openttd
12:02:26 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJTKy
12:03:11 <andythenorth> dP looks about right though
12:03:25 <andythenorth> will you teach it to avoid farm fields? :P
12:04:08 <dP> andythenorth, that could be an option I guess
12:04:19 <andythenorth> it's only relevant at game start :)
12:04:21 <andythenorth> for cost reasons
12:04:56 <CornsMcGowan[m]> could have a toggle between length and build cost
12:04:57 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJTK5
12:05:22 <andythenorth> 'favour shorter'
12:05:26 <andythenorth> 'favour lower cost'
12:05:36 <andythenorth> 'favour bypassing towns that are angry with you' :P
12:05:43 <dP> andythenorth, not quite, it's not that much work to add some weights and benefit is substantial for goal games
12:05:45 <andythenorth> 'prefer flat, I have crap trains
12:05:56 <andythenorth> 'use slopes, my trains are boss'
12:06:07 <CornsMcGowan[m]> yeah i'm thinking adjustable weight for slopes
12:06:20 <andythenorth> 'demolish rivers, they're stupid | fuck around building bridges over rivers'
12:06:31 <CornsMcGowan[m]> either in the same way as yapf does it or multiplied weight for consecutive slopes
12:07:28 <CornsMcGowan[m]> cost preview would be nice now i think about it
12:07:53 *** arikover has joined #openttd
12:08:02 <dP> weights are manageable, I'm more worried about how many states it now has with curves
12:08:24 <dP> since you kind of need to have last left and last right turn in a state
12:09:15 <CornsMcGowan[m]> oh yeah i ran into that last time i was working on it too
12:10:30 <CornsMcGowan[m]> if you're using an iterative deepening search like IDS* or IDA* then you dont have to embed it as a state, but it would take longer to process (less memory usage of course, only enough needed for the resulting path)
12:11:20 <CornsMcGowan[m]> dP: do you have a branch i can check out and play around with
12:13:22 <CornsMcGowan[m]> i've lost track of the citymania client repo
12:13:34 <dP> I'm using some dumb shit of a pathfinder xD
12:13:50 <dP> Well, it still counts as A* I guess but I haven't bothered optimizing it yet
12:14:23 <CornsMcGowan[m]> oh you shuffled to github :0
12:14:28 <CornsMcGowan[m]> no more bitbucket/mercurial?
12:14:54 <dP> it's not a ready to use tool though yet, just a planner to test pathfinding
12:15:06 <dP> CornsMcGowan[m], yeah, bb dropped mercurial support
12:15:13 <dP> so github mirror became the main repo xD
12:15:28 <dP> may move it to gitlab or smth though
12:16:34 *** Lejving has joined #openttd
12:27:58 <DorpsGek_III> [OpenTTD/OpenTTD] Hexus-One commented on pull request #7607: Feature Request/WIP: Rail Planner track builder https://git.io/JJT62
12:27:58 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz commented on pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJT6a
12:32:24 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJT6M
12:41:59 *** m1cr0m4n is now known as m1cr0man
12:43:22 *** m1cr0man has joined #openttd
12:49:28 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on pull request #8192: Change: Always generate API files at build time https://git.io/JJTiZ
13:30:19 *** WormnestAndroid has quit IRC
13:30:32 *** WormnestAndroid has joined #openttd
13:32:39 *** arikover has joined #openttd
14:45:14 <CornsMcGowan[m]> am i doing something wrong or is there a reason why openttd master branch compiled uses 2GB ram?
14:47:42 <dP> depends on what're you doing with it
14:47:44 <CornsMcGowan[m]> by comparison, 1.10.1 release client uses 160mb
14:48:14 <CornsMcGowan[m]> i'm compiling from visual studio 2019 as CMake with mostly default settings i believe
14:48:32 <CornsMcGowan[m]> oh...is it because it's in a debug configuration
14:52:02 <CornsMcGowan[m]> yep that was it HAHA
15:21:32 <CornsMcGowan[m]> why am i getting a "wrong client revision" error after compiling JGR and trying to connect to a server?
15:22:06 <LordAro> i would imagine because your client doesn't match the server
15:22:32 <CornsMcGowan[m]> i'm on the 0.34.4 tag i'm very sure
15:41:22 <FLHerne> ...and is the server?
15:41:26 <CornsMcGowan[m]> heck am i doing wrong
15:41:36 <CornsMcGowan[m]> yeah i compiled the server off the 0.34.4 tag as well
15:43:27 <CornsMcGowan[m]> server has 3 people playing on it right now so i think the server's fine
15:43:35 <FLHerne> And the header on the menu window in both builds says "OpenTTD jgrpp-0.34.4" or whatever?
15:43:36 <CornsMcGowan[m]> unsure why the revision num would change on my end though
15:44:17 <CornsMcGowan[m]> weird indeed (pic is the compiled client that doesn''t work)
15:44:27 <LordAro> there's probably some -d setting you can use to get the actual client/server revision
15:44:55 <CornsMcGowan[m]> ty i'll check on return
16:57:23 <CornsMcGowan[m]> i have returned
17:03:38 <CornsMcGowan[m]> dbg: [gamelog] Revision text changed to jgrpp-0.34.4, savegame version 218, modified, _openttd_newgrf_version = 0x1b086d64
17:03:38 <CornsMcGowan[m]> is given by my compiled client
17:03:49 <CornsMcGowan[m]> compared to JGR downloaded from the github releases which gives
17:04:41 <LordAro> you'd have to ask JGR about it, i suspect
17:04:42 <CornsMcGowan[m]> dbg: [gamelog] Revision text changed to jgrpp-0.34.4, savegame version 218, not modified, _openttd_newgrf_version = 0x1b006d64
17:05:42 <CornsMcGowan[m]> is he in this IRC?
17:06:00 <milek7> maybe you have dirty git checkout?
17:06:06 <CornsMcGowan[m]> i guess i'll ask his github
17:06:10 <CornsMcGowan[m]> :0 how to check
17:06:51 <milek7> git status should show 'nothing to commit, working tree clean'
17:07:07 <LordAro> well the newgrf_version is different
17:07:18 <LordAro> you'll have to look at how it's generated to decode it
17:07:25 <LordAro> and work out where the '8' is coming from
17:07:45 <CornsMcGowan[m]> i do indeed have an unstaged file chilling here, some visual studio file
17:07:54 <CornsMcGowan[m]> time to sleuth
17:08:03 <glx> the '8' is because modified IIRC
17:09:21 <CornsMcGowan[m]> had to change from x64-windows to x64-windows-static, which modifies openttd_vs142.vcxproj
17:09:28 <CornsMcGowan[m]> and that's a tracked file in the repo
17:10:54 <glx> ah no the '8' is stable release marker
17:10:59 <CornsMcGowan[m]> i forgot how i compiled this on ubuntu lmao
17:13:23 <CornsMcGowan[m]> lemme try with dynamic vcpkg
17:13:47 <glx> but that's weird, openttd projects used to set x64-windows-static, so maybe JGR changed that
17:14:02 <LordAro> i guess you could hack the version script as appropriate, but yeah, sounds like you need to talk to JGR
17:16:35 <CornsMcGowan[m]> on linux i installed these packages as such
17:16:35 <CornsMcGowan[m]> unsure if these are static or dynamic
17:17:03 *** HerzogDeXtEr has joined #openttd
17:17:17 <LordAro> because it's not insane about how libraries are handled
17:17:55 <glx> windows can be dynamic but it's a pain to distribute dlls with exe
17:21:31 <CornsMcGowan[m]> dynamic libraries: still borked
17:22:05 <glx> CornsMcGowan[m]: JGR 0.34-4 already set x64-windows-static
17:22:37 <glx> so I don't see why you need to edit the file
17:24:34 <CornsMcGowan[m]> okay i'm gonna wipe this repo and reclone it
17:32:13 <FLHerne> The version doesn't differ between debug and release builds, does it?
17:32:38 <FLHerne> I suppose the behaviour *could* differ because of asserts and things
17:32:53 <glx> debug and release are always compatible
17:33:02 <glx> but debug is usually slower
17:33:03 <CornsMcGowan[m]> oh yeah - client crashes when i click the multiplayer button with debug config
17:33:13 <CornsMcGowan[m]> debug also uses 10x more memory heh
17:33:28 <CornsMcGowan[m]> lemme check i've cleared everything properly
17:33:55 <CornsMcGowan[m]> i get "cannot open file: 'zlib.h'" etc
17:34:25 <glx> vcpkg is not fully installed I think
17:35:03 <glx> probably missing "vcpkg integrate install"
17:35:18 <CornsMcGowan[m]> i thought thats only needed once
17:35:35 <CornsMcGowan[m]> executed that just in case
17:35:37 <CornsMcGowan[m]> yeah same errors
17:35:45 <supermop_Home> andy: 37s carrying ore 4tile ore trains every 15 days, or 92s (flanders?) carrying 8 tile every 30?
17:35:47 <CornsMcGowan[m]> lemme wipe the global .git ignore list
17:35:57 <supermop_Home> i feel like the slugs are cuter
17:36:18 <CornsMcGowan[m]> yeah those four vcpkg packages
17:36:37 <glx> paste the output of "vcpkg list" somewhere (not here ;) )
17:39:37 <andythenorth> supermop_Home Vanguard 6 tiles 20 days
17:39:43 <andythenorth> so many options :P
17:39:46 <andythenorth> which one looks nicest?
17:39:47 <FLHerne> glx: I think it's possible to assert on something with side effects
17:40:13 <supermop_Home> don't have vanguard right now
17:40:29 <FLHerne> glx: Which would cause desyncs if you, say, changed the RNG state in a call made in an `assert`
17:40:42 <FLHerne> Of course that would be a bad idea :p
17:41:00 <glx> yeah assert should not call Random() :)
17:41:37 <glx> CornsMcGowan[m]: weird, the libs are installed with the correct triplet, and vcpkg should be usable by VS
17:42:12 <glx> CornsMcGowan[m]: build is x64 or win32 ?
17:42:30 *** Wormnest has joined #openttd
17:42:46 <CornsMcGowan[m]> x64 as far as i know
17:43:53 *** Progman has joined #openttd
17:52:33 <glx> really seems the issue is vcpkg
17:53:21 <glx> VS was open when you type "vcpkg integrate install" ?
17:53:49 <CornsMcGowan[m]> oh should i execute it while vs is closed
17:54:15 <glx> probably, as I think vcpkg needs to modify some config
17:54:45 <CornsMcGowan[m]> maybe i'll try the vcpkg commands as admin/root
17:55:40 <glx> "Then, to hook up user-wide integration, run (note: requires admin on first use)" <-- from vcpkg readme
17:59:22 <CornsMcGowan[m]> still nothing
17:59:29 <CornsMcGowan[m]> going to try reinstalling vcpkg
18:01:15 <CornsMcGowan[m]> it surely can't be related to the fact that i'm going off my fork of JGRPP? (with no changes, the exact same commits)
18:17:22 <glx> there should be "VcpkgTripletSelection" lines in the log (always x86-windows for strgen and settingsgen, but they don't use any libs)
18:17:49 <glx> for openttd it should be a -windows-static variant
18:18:13 <CornsMcGowan[m]> ty :) i'll have a go at that
18:19:15 <glx> in my log I have VcpkgTripletSelection: Using triplet "x64-windows-static" from "D:\developpement\GitHub\vcpkg\installed\x64-windows-static\"
18:19:39 <glx> on compile farm it's VcpkgTripletSelection: Using triplet "x64-windows-static" from "c:\vcpkg\installed\x64-windows-static\"
18:36:04 <CornsMcGowan[m]> tries non static for some reason
19:03:28 <CornsMcGowan[m]> idek where to go from here
19:05:48 <CornsMcGowan[m]> trying Win32 also uses the non-static triplet
19:06:46 <glx> so for some unknown reason it doesn't follow VcpkgTriplet set in the project
19:10:24 <CornsMcGowan[m]> could be some global setting?
19:10:25 *** b_jonas has joined #openttd
19:10:27 <CornsMcGowan[m]> lemme try reset to default
19:12:26 <CornsMcGowan[m]> okay i've reset all settings to default
19:13:13 <CornsMcGowan[m]> clean and rebuild solution...
19:17:46 <CornsMcGowan[m]> oh i guess i have to do integrate install again
19:23:53 <CornsMcGowan[m]> glx: found this line during failed build with Detailed build logs
19:23:53 <CornsMcGowan[m]> 7>Property reassignment: $(VcpkgTriplet)="x64-windows" (previous value: "x64-windows-static") at C:\Users\USER\source\repos\vcpkg\scripts\buildsystems\msbuild\vcpkg.targets (50,5)
19:25:05 <glx> but I don't know why it does it
19:26:20 <CornsMcGowan[m]> trying out .\vcpkg.exe integrate install --triplet x64-windows-static
19:31:11 <CornsMcGowan[m]> it's still reassigning
19:31:44 <glx> what's you vcpkg version ?
19:32:04 <CornsMcGowan[m]> i just cloned off master
19:32:20 <CornsMcGowan[m]> should i use a specific tag
19:32:45 <glx> master should work, unless they changed something recently
19:35:47 <CornsMcGowan[m]> but i guess the point is that option doesn't need to be touched
19:37:36 <glx> I never touched any settings
19:38:08 <CornsMcGowan[m]> i'm using VS2019 enterprise
19:39:50 <snail_UES_> andythenorth: how’s your european iron horse coming along? :)
19:41:20 <glx> oh with an updated vcpkg it now fails
19:41:34 <CornsMcGowan[m]> guess i'll revert to
19:41:41 <CornsMcGowan[m]> whichever one you were using?
19:42:22 *** WormnestAndroid has quit IRC
19:42:28 <glx> vcpkg version is still 2020.02.04-nohash, but it doesn't work
19:43:18 *** WormnestAndroid has joined #openttd
19:44:27 <CornsMcGowan[m]> i'll try rebuild off 2019.06 tag
19:53:25 <CornsMcGowan[m]> works now, thank god
19:54:14 *** Wormnest has joined #openttd
19:55:30 *** HerzogDeXtEr has joined #openttd
20:01:39 *** gelignite has joined #openttd
20:08:11 *** tokai|noir has joined #openttd
20:08:12 *** ChanServ sets mode: +v tokai|noir
20:28:35 *** jottyfan has joined #openttd
21:24:22 *** Wormnest has joined #openttd
21:45:40 *** WormnestAndroid has quit IRC
21:45:44 *** WormnestAndroid has joined #openttd
22:19:17 *** Wormnest has joined #openttd
22:22:27 *** WormnestAndroid has quit IRC
22:22:45 *** WormnestAndroid has joined #openttd
23:21:38 <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz commented on pull request #8260: Codechange: Spell 'Viewport' consistently https://git.io/JJkTF
continue to next day ⏵
