IRC logs for #openttd on OFTC at 2020-05-05
⏴ go to previous day
00:03:20 <DorpsGek_III> [OpenTTD/OpenTTD] Yexo opened pull request #8111: Fix: reset roadtype/streetcartype info for non-road bridges https://git.io/JfG8l
00:15:07 *** Lejving_ has joined #openttd
00:44:04 *** Lejving__ has joined #openttd
00:49:19 <glx> looks like memory is abused somewhere
00:58:16 *** Wormnest has joined #openttd
01:03:05 <supermop_Home> nielsm I want to play on that map
01:11:07 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on pull request #8111: Fix: reset roadtype/streetcartype info for non-road bridges https://git.io/JfGBy
01:44:17 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on pull request #8111: Fix: reset roadtype/streetcartype info for non-road bridges https://git.io/JfGRd
03:09:49 *** WormnestAndroid has quit IRC
03:11:30 *** WormnestAndroid has joined #openttd
03:13:51 *** WormnestAndroid has joined #openttd
03:43:29 *** Wormnest has joined #openttd
03:44:35 *** gelignite_ has joined #openttd
04:10:20 *** Yexo is now known as Guest24149
04:10:25 *** ChanServ sets mode: +o Yexo
04:38:30 *** Wormnest has joined #openttd
04:48:36 *** snail_UES_ has joined #openttd
05:55:02 *** Wormnest has joined #openttd
06:26:38 *** WormnestAndroid has quit IRC
06:29:09 *** WormnestAndroid has joined #openttd
08:04:12 *** sla_ro|master has joined #openttd
08:21:49 *** andythenorth has joined #openttd
09:06:25 <andythenorth> :o loads of fixes
09:06:34 * andythenorth wasn't paying attention yesterday
09:27:45 *** WormnestAndroid has quit IRC
09:27:58 *** WormnestAndroid has joined #openttd
10:11:47 <TrueBrain> hmm .. people marking BaNaNaS entries as "deleted" .. we really need to add the functionality to do that the proper way .. we need more help with the API etc :D
10:22:03 <planetmaker> @TrueBrain, there actually is a way already to achieve that - but it is not obvious: setting the version requirement such that it becomes unavailable.
10:22:24 <planetmaker> Yet, simply marking it as deprecated (but remaining available) certainly is the better way in many cases
10:22:40 <planetmaker> maybe with a user choice for download to show only non-deprectated content
10:23:26 <TrueBrain> planetmaker: no. There is an official way, by simply setting the availability to "savegames-only". After that, the content disapears. Nice and clean
10:23:36 <TrueBrain> just .. we need someone to implement it in the frontend + API to be able to do that
10:26:38 <TrueBrain> now it would require a Pull Request, which is a bit silly ..
10:27:22 <LordAro> TrueBrain: should we undo the "delete" commits, do you think?
10:28:10 <LordAro> or perhaps even merge the 2 versions (though that would be rather harder)
10:30:18 <TrueBrain> hmm, replaced_by would be better in this case
10:31:44 <TrueBrain> I just need a way to lint those PRs
10:31:49 <TrueBrain> as they can break everything now :D
10:51:23 <TrueBrain> FileExistsError: [Errno 17] File exists: '/home/runner/work/OpenTTD-BaNaNaS/OpenTTD-BaNaNaS/bananas-api/BaNaNaS' <- well, thank you for that piece of knowledge .. I love those errors :D
10:52:23 <LordAro> bananas bananas bananas bananas
10:58:11 <TrueBrain> that should be sufficient
10:58:27 <TrueBrain> happy I already wrote code to do this :D
10:59:25 <LordAro> TrueBrain: what does a failure mode look like?
10:59:42 <TrueBrain> it crashes and burn, basically
11:00:06 <LordAro> might be an idea to test it
11:00:19 <TrueBrain> but let me push a test you can see
11:00:46 <TrueBrain> I know, shocking, but I tend to test stuff :P :D
11:01:31 <TrueBrain> and you are right to do so, as it turns out :P LOLZ
11:01:37 <TrueBrain> it did crash and burn :P
11:01:39 <TrueBrain> bananas-server halts
11:01:44 <TrueBrain> bananas-api now continues .. :D
11:01:56 <TrueBrain> but I cannot use bananas-server, as it needs access to the S3 bucket
11:08:43 <DorpsGek_III> [OpenTTD/bananas-api] TrueBrain opened pull request #57: Fix: --validate should bail on any error, not continue https://git.io/JfG1Y
11:13:51 <LordAro> error message could be nicer, but at least it actually halts now :p
11:17:59 <TrueBrain> I really don't care about the error message tbh :P It only happens when a human makes manual changes and fucked up in writing YAML
11:18:14 <TrueBrain> when YAML parses correctly, the errors are a lot more to the point, as the frontend needs to be able to parse those too :D
11:22:30 *** gelignite has joined #openttd
11:28:02 <DorpsGek_III> [OpenTTD/bananas-api] lgtm-com[bot] commented on pull request #57: Fix: --validate should bail on any error, not continue https://git.io/JfG1A
11:31:06 <DorpsGek_III> [OpenTTD/OpenTTD] Yexo commented on pull request #8111: Fix: reset roadtype/streetcartype info for non-road bridges https://git.io/JfGMf
11:34:56 <TrueBrain> oooppss .. forgot something important there
11:35:43 <DorpsGek_III> [OpenTTD/bananas-api] TrueBrain updated pull request #57: Fix: --validate should bail on any error, not continue https://git.io/JfG1Y
11:48:56 <Samu> RailwAI replied with a pq5! yay gonna test
11:54:18 <LordAro> TrueBrain: now you broke the regression test :p
11:55:00 <LordAro> or at least, GH/the makefile thinks so
11:55:01 <DorpsGek_III> [OpenTTD/OpenTTD] fsimonis commented on pull request #7270: Introduce CMake (and removing all other project-related code) https://git.io/JfGDt
11:55:05 <LordAro> can't see any actual error message...
11:55:05 <Samu> 1885 became 1884 ticks, woah, barelly noticeable
11:57:13 <TrueBrain> LordAro: you can't see that, because it is not. But for some reason Make sometimes think it is .. still not sure why
11:57:47 <TrueBrain> cannot reproduce it locally, so difficult to debug
11:57:59 <LordAro> TrueBrain: presumably the process is exiting with non-zero?
11:58:06 <LordAro> that's the only reason make would think it had failed
11:58:13 <TrueBrain> yeah, but I don't know why
11:58:19 <TrueBrain> did tons of runs locally, never fails
11:58:26 <TrueBrain> I now hit rerun, and the PR validates
11:58:41 <TrueBrain> I am guessing it has to do with a cleanup
12:03:12 <TrueBrain> started the regression in a while loop now .. but after attempt 100, still doing fine on my local machine :P
12:04:24 <DorpsGek_III> [OpenTTD/OpenTTD] fsimonis commented on pull request #7270: Introduce CMake (and removing all other project-related code) https://git.io/JfGD1
12:07:30 <Samu> the unit below tick is AIController.GetOpsTillSuspend();
12:12:08 *** Smedles has joined #openttd
14:27:14 <Wolf01> Reenter has been... hard... about 2 months of not moving at all, I got kinetosis driving the car :S
14:59:07 *** mcbanhas has joined #openttd
15:14:17 *** supermop_Home_ has joined #openttd
15:28:20 <DorpsGek_III> [OpenTTD/bananas-api] LordAro approved pull request #57: Fix: --validate should bail on any error, not continue https://git.io/JfG59
15:28:41 <DorpsGek_III> [OpenTTD/bananas-api] TrueBrain merged pull request #57: Fix: --validate should bail on any error, not continue https://git.io/JfG1Y
15:44:49 *** Wormnest has joined #openttd
15:48:29 *** snail_UES_ has joined #openttd
15:48:34 <Samu> "About OpenTTD", it says 2002-2019
15:51:47 <andythenorth> Samu specifics pls :)
15:52:10 <LordAro> $ grep -R 2019 src/ | wc -l
15:52:14 <glx> usual forgotten update of english.txt
15:52:21 <Wolf01> Just put year(today()) :P
15:52:29 <andythenorth> Wolf01 that's what the website does I think
15:52:39 <Wolf01> Loke every other thing
15:53:03 <LordAro> andythenorth: yeah but that's build time rather than view time
15:53:35 <glx> doable with build time I think
15:53:49 <LordAro> i think this sort of thing is one of the few cases where updating the other lang files is probably the way to go
15:54:13 <andythenorth> templated lang file, compile macro :P
16:04:43 <supermop_Home_> should I try to play a multiplayer game?
16:05:15 <nielsm> sounds like a large risk to take, do you dare?
16:08:54 <supermop_Home_> no I do not dare
16:09:33 <supermop_Home_> i think i'll just refresh the usps tracking page for this package for the next few hours
16:43:06 <Eddi|zuHause> cities:skylines decided to forget everything i ever did with surface painter, and then crash on me...
16:46:33 <Eddi|zuHause> it's also gone from the autosave... even though it was still visible back then
16:48:40 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 updated pull request #7270: Introduce CMake (and removing all other project-related code) https://git.io/fhbqc
17:07:20 <Wolf01> Eddi|zuHause: I think some mod updated
17:36:31 *** WormnestAndroid has quit IRC
17:38:12 *** WormnestAndroid has joined #openttd
17:42:39 <luaduck> hm, we're still having reports of players joining people's passworded companies without authorization
17:42:50 <luaduck> nothing of interest in the net,2 debug log
17:43:38 <luaduck> I'd open an issue for it but I don't really have any useful logging for it
17:45:59 <nielsm> do open an issue, I had never heard of that happening
17:46:45 <luaduck> it'd be a rather open headed issue of "people joining passworded companies supposedly without the password" without any relevant logs, that's the thing
17:47:00 <luaduck> almost needs a packet dump but holy shit that would be a lot of packets I'd have to capture
17:47:19 <nielsm> at least having an issue about it lets it be tracked
17:51:01 <nielsm> but yes packet dumping might be necessary, and then replay it to allow attaching a debugger
17:51:14 *** arikover has joined #openttd
17:51:41 <Yexo> How frequently does this happen?
17:55:37 <DorpsGek_III> [OpenTTD/OpenTTD] duckfullstop opened issue #8112: Players report unauthorized clients joining passworded companies https://git.io/JfGhG
17:55:45 <luaduck> Yexo: once or twice a week
17:57:37 <nielsm> even worse for debuggability yay
18:06:43 <_dp_> luaduck, nielsm, that may actually be related to desync issue
18:06:49 <andythenorth> what does that do?
18:07:04 <andythenorth> my 10 year old builds tracks and signals, and then asks for help
18:07:08 <andythenorth> and I look at it
18:07:15 <andythenorth> and I'm like "no this is beyond help"
18:07:20 <luaduck> _dp_: potentially? iirc there was discussion about people getting put in the wrong slots?
18:07:31 <luaduck> (I thought that's supposed to get picked up by the wrong company in doCommand check though)
18:08:13 <_dp_> andythenorth, does nothing but deadlocking some trains
18:09:04 <andythenorth> ok, GOTO link above :P
18:09:15 *** D-HUND is now known as debdog
18:11:01 <Samu> the optimized versions of binary heap and fibonacci heap both post similar results
18:11:28 <Samu> strange coincidence, I wonder why
18:12:03 <Samu> I need a bigger sample size, brb
18:20:48 <Samu> it seems that for short paths, binary heap beats fibonacci heap, unsure
18:21:36 <DorpsGek_III> [OpenTTD/OpenTTD] embeddedt commented on issue #8112: Players report unauthorized clients joining passworded companies https://git.io/JfGhG
18:23:15 <Samu> nop, 240 tiles away, and binary heap beat fibonacci
18:23:46 <DorpsGek_III> [OpenTTD/OpenTTD] duckfullstop commented on issue #8112: Players report unauthorized clients joining passworded companies https://git.io/JfGhG
18:24:12 <Samu> I was always under the impression fibonacci would > binary, but now... I don't know
18:24:26 <_dp_> Samu, fib heap on practice isn't as good as in theory, so that's totally expected
18:24:58 <_dp_> in general they're about equal and it only depends on implementation
18:25:22 <DorpsGek_III> [OpenTTD/OpenTTD] embeddedt commented on issue #8112: Players report unauthorized clients joining passworded companies https://git.io/JfGhG
18:31:17 <Samu> well, binary heap had the most gains with optimizations though
18:36:33 *** gelignite has joined #openttd
18:42:20 <Samu> that's a 12.5% increase in speed for binary heap
18:43:09 <Samu> a mere 5% for fibonacci heap
19:07:31 <andythenorth> so how many open bugs do we have? :)
19:07:53 <andythenorth> can't possibly all be important
19:26:57 *** tokai|noir has joined #openttd
19:26:57 *** ChanServ sets mode: +v tokai|noir
19:38:10 <LordAro> nielsm: that is very funky
19:41:47 *** WormnestAndroid has quit IRC
19:42:02 *** WormnestAndroid has joined #openttd
19:55:42 *** frosch123 has joined #openttd
20:07:22 <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 approved pull request #8113: Codechange: Use a dynamic copyright year https://git.io/JfZU2
20:13:19 <_dp_> hm, idk if it actually breaks anything but this line seems wrong
20:13:36 <_dp_> INVALID_COMPANY is byte so can't << 16
20:15:39 <Yexo> _dp_: should be implicitly converted to (u)int before the shift
20:15:41 <Eddi|zuHause> i would expect that to be implicitly cast to int
20:16:12 <_dp_> hm... because of 16 being int?
20:17:06 <_dp_> I guess you're right, otherwise nothing would work actually
20:18:49 <_dp_> still a terrible code imo :p
20:19:05 <_dp_> are there mac compilers on godbolt?
20:20:28 <Eddi|zuHause> the bitstuffing could be abstracted away a bit
20:22:56 <nielsm> I'm not sure which of these changes made it work, but now it works
20:23:47 <nielsm> ...except it doesn't entirely
20:24:02 <nielsm> (transmission delay of patch data)
20:24:22 <Eddi|zuHause> and i'm missing a useful tunnel portal
20:25:10 <Eddi|zuHause> i have one that would be suitible for going into a mountain, but not one that would fit in shallow spaces like cut&cover tracks
20:37:12 <DorpsGek_III> [OpenTTD/OpenTTD] duckfullstop commented on issue #8102: Installer does not say that Windows 8 and 10 are supported. https://git.io/JfO7I
20:40:44 *** Progman has joined #openttd
20:50:51 <nielsm> hm, no turns out I did not fix it
20:51:08 <DorpsGek_III> [OpenTTD/OpenTTD] duckfullstop opened pull request #8114: Fix #8102: Update Windows installer strings to reference newer Windows version https://git.io/JfZkV
20:51:49 <nielsm> rather, a capture of the original MIDI stream contains something more than what I'm sending, which sets some parameters on the synth that makes it behave as intended, and I'm not sure exactly which part I'm missing here
21:17:02 <DorpsGek_III> [OpenTTD/OpenTTD] Yexo commented on pull request #8114: Fix #8102: Update Windows installer strings to reference newer Windows version https://git.io/JfZIV
21:30:01 <DorpsGek_III> [OpenTTD/OpenTTD] Yexo updated pull request #8111: Fix: reset roadtype/streetcartype info for non-road bridges https://git.io/JfG8l
21:35:33 *** snail_UES_ is now known as Guest24216
21:35:34 *** snail_UES_ has joined #openttd
21:38:40 <DorpsGek_III> [OpenTTD/OpenTTD] duckfullstop updated pull request #8114: Fix #8102: Update Windows installer strings to reference newer Windows version https://git.io/JfZkV
21:38:56 <DorpsGek_III> [OpenTTD/OpenTTD] duckfullstop commented on pull request #8114: Fix #8102: Update Windows installer strings to reference newer Windows version https://git.io/JfZLw
21:39:02 <DorpsGek_III> [OpenTTD/OpenTTD] duckfullstop commented on pull request #8114: Fix #8102: Update Windows installer strings to reference newer Windows version https://git.io/JfZLr
21:40:49 <DorpsGek_III> [OpenTTD/OpenTTD] Yexo approved pull request #8114: Fix #8102: Update Windows installer strings to reference newer Windows version https://git.io/JfZLi
21:56:16 <DorpsGek_III> [OpenTTD/OpenTTD] duckfullstop dismissed a review for pull request #8114: Fix #8102: Update Windows installer strings to reference newer Windows version https://git.io/JfZLi
21:56:16 <DorpsGek_III> [OpenTTD/OpenTTD] duckfullstop updated pull request #8114: Fix #8102: Update Windows installer strings to reference newer Windows version https://git.io/JfZkV
21:57:04 <DorpsGek_III> [OpenTTD/OpenTTD] duckfullstop commented on pull request #8114: Fix #8102: Update Windows installer strings to reference newer Windows version https://git.io/JfZtB
22:02:04 <DorpsGek_III> [OpenTTD/OpenTTD] Yexo approved pull request #8114: Fix #8102: Update Windows installer strings to reference newer Windows version https://git.io/JfZt2
22:05:44 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 merged pull request #8114: Fix #8102: Update Windows installer strings to reference newer Windows version https://git.io/JfZkV
22:05:44 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 closed issue #8102: Installer does not say that Windows 8 and 10 are supported. https://git.io/JfO7I
22:09:11 <DorpsGek_III> [OpenTTD/OpenTTD] ldpl opened pull request #8115: GS methods to let company have exclusive access to the industry https://git.io/JfZt7
22:22:40 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on pull request #8115: GS methods to let company have exclusive access to the industry https://git.io/JfZqa
22:28:23 <glx> hmm commit checker is picky
22:29:22 <glx> but the * is missing on the line ;)
22:31:01 <DorpsGek_III> [OpenTTD/OpenTTD] ldpl updated pull request #8115: GS methods to let company have exclusive access to the industry https://git.io/JfZt7
22:38:53 <DorpsGek_III> [OpenTTD/nml] frosch123 updated pull request #75: Fix ottd_display_speed to reflect changes done in OpenTTD https://git.io/Jedfs
22:42:27 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 dismissed a review for pull request #8113: Codechange: Use a dynamic copyright year https://git.io/JfZU2
22:43:06 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on pull request #8113: Codechange: Use a dynamic copyright year https://git.io/JfZmR
22:43:56 <DorpsGek_III> [OpenTTD/nml] frosch123 approved pull request #75: Fix ottd_display_speed to reflect changes done in OpenTTD https://git.io/JfZm0
22:46:07 <DorpsGek_III> [OpenTTD/nml] frosch123 closed pull request #35: Fix ottd_display_speed to reflect changes done in OpenTTD https://git.io/fjZKa
22:46:07 <DorpsGek_III> [OpenTTD/nml] frosch123 merged pull request #75: Fix ottd_display_speed to reflect changes done in OpenTTD https://git.io/Jedfs
22:46:09 <DorpsGek_III> [OpenTTD/nml] frosch123 closed issue #74: Speed values are slightly off when using metric units https://git.io/Je5po
22:47:37 <frosch123> such a mess, 1 issues, 2 PRs, all for the same
22:49:09 <glx> all issues are fixed (well there's still #112) but it's not blocking
22:51:53 <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 approved pull request #8113: Codechange: Use a dynamic copyright year https://git.io/JfZmM
23:00:55 <FLHerne> Although most of those are feature requests
23:08:58 <Yexo> I'm not sure if any automation for that is available, but you're more likely to get traction if you open a duplicate issue on github, since all activity has moved there
23:10:32 <glx> and the test case is incomplete (I can't just copy paste the code ;) )
23:12:03 <FLHerne> (copying lang/ from literally any other grf)
23:12:15 <FLHerne> Well, fails for me :P
23:13:12 <FLHerne> It's not my issue, just noting that "no github issues" doesn't mean the issues have run out :P
23:14:53 <Yexo> None of the issues on the devzone have had updates for 2+ years, and discounting the 7 most-recently updated that goes to 4.5+ years
23:15:56 <Yexo> Not sure how valuable it would be to move any of the really old issues, especially the feature requests
23:18:39 <DorpsGek_III> [OpenTTD/OpenTTD] James103 commented on pull request #8115: GS methods to let company have exclusive access to the industry https://git.io/JfZOs
23:24:23 <andythenorth> ottd bugs could do with some application of 'importance' hammer
23:25:01 <andythenorth> I closed hundreds of tickets in 2018, no kittens died
23:25:58 <Eddi|zuHause> i don't think that the feedback you got justifies the conclusion of "no kittens died"
23:26:14 <andythenorth> feedback isn't a particular outcome
23:26:30 <andythenorth> feedback is just a sign that the project isn't dead yet
23:27:02 <glx> FLHerne: indeed it crashes
23:29:34 <andythenorth> do we want more currencies or not?
23:29:39 <andythenorth> why aren't they newgrf?
23:30:44 <andythenorth> I really can't close any of these bugs
23:30:54 <andythenorth> I've found 2 pages of absolutely critical failures so far
23:30:58 <glx> FLHerne: but it's not the calculation, it's the use of layout parameter
23:31:02 <andythenorth> does this game even work?
23:31:08 <andythenorth> why do people play it?
23:31:12 <andythenorth> it's massively broken :)
23:31:21 <andythenorth> seriously nothing works
23:56:32 <glx> ok it seems parameters are allowed, but the code to use them doesn't exist yet
continue to next day ⏵
