IRC logs for #openttd on OFTC at 2019-01-12
⏴ go to previous day
00:02:28 <Eddi|zuHause> destroying my system now, farewell
00:40:36 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhnYf
00:52:42 <Samu> i dont know how to quote code on github
01:06:21 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhnY4
01:09:06 <Samu> it's not declared, I'm unsure what he meant
01:09:41 <Samu> opf_ship.h does not have it
01:13:33 *** Eddi|zuHause has joined #openttd
01:14:06 <Eddi|zuHause> it seems to work
01:22:54 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhnYu
01:25:04 *** Thedarkb-T60 has joined #openttd
01:25:47 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhnY2
01:26:23 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhnYV
01:27:19 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhnYw
01:35:44 <Samu> _settings_game.pf.npf.maximum_go_to_depot_penalty
01:37:18 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhnYi
01:38:20 <Samu> the nomenclature used by the other pathfinders, and even game settings, call it max_penalty
01:38:41 <Samu> why must opf be different?
01:39:45 <Samu> alright, i'll leave it as max_distance
01:45:30 <Samu> nooo, it makes no sense, it's driving me crazy! :(
02:11:32 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhZzm
02:11:51 <Samu> what the heck is wrong...
02:15:02 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhZzm
02:15:23 <Samu> rebases are the most complicated things I've ever had to deal with
02:27:01 *** Thedarkb-T60 has joined #openttd
02:38:02 <nnyby> often when i'm doing a rebase it's simpler to just start with the new master, and re-apply the changes semi-manually
02:55:04 <DorpsGek_II> [OpenTTD/OpenTTD] James103 commented on pull request #7038: Fix: Remove duplicate town name "Huacho" https://git.io/fhnOr
03:00:19 *** Thedarkb-X40 has joined #openttd
03:01:46 <DorpsGek_II> [OpenTTD/OpenTTD] nikolas commented on pull request #7038: Fix: Remove duplicate town name "Huacho" https://git.io/fhnOo
03:43:13 <Samu> framerates are not working properly peter1138
03:45:26 <Samu> oh actually I don't know, there was a lot of changes in that camp
03:45:36 <Samu> one of them broke framerate window
03:49:55 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhZzm
04:33:24 <Samu> so i just sent 5000 ships to their depots
04:35:06 <Samu> meh, i dont have a way to test it
04:40:24 <Samu> OPF: 14,5 seconds hiccup when sending 5000 ships to depots
04:42:41 <Samu> NPF: 14,4 seconds hiccup when sending 5000 ships to depots
04:44:40 <Samu> YAPF: 2.7 seconds hiccup when sending 5000 ships to depots
04:45:20 <Samu> this is with my patch applied, forgot to mention
04:46:04 *** HerzogDeXtEr has joined #openttd
04:46:19 <Samu> honestly, I expected much worse for OPF, I'm kinda surprised, even though 14 seconds stalls are huuge
05:13:49 *** Smedles has joined #openttd
08:03:21 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth approved pull request #7038: Fix: Replace duplicate town name "Huacho" https://git.io/fhnsR
08:15:58 <DorpsGek_II> [OpenTTD/OpenTTD] btzy updated pull request #7028: Feature: Option to group vehicle list by shared orders https://git.io/fhGxd
08:16:58 *** andythenorth has joined #openttd
08:32:33 *** chomwitt has joined #openttd
08:33:16 <DorpsGek_II> [OpenTTD/OpenTTD] planetmaker merged pull request #7038: Fix: Replace duplicate town name "Huacho" https://git.io/fhnYg
08:38:25 *** sla_ro|master has joined #openttd
08:39:52 <andythenorth> if we keep merging, LordAro won't be able to finish the changelog....ever
08:41:20 <planetmaker> if *that* is our main concern, then I'm happy to have him shove that problem on the feet :P
08:42:19 <planetmaker> and that sentence no grammar
08:43:23 <planetmaker> also... we have our commit message style so that a script can make the changelog :P
08:44:27 <planetmaker> I rather accidentially setup my git repo such that it pulls the pull requests, too. But I find that surprisingly convenient
08:47:56 <andythenorth> no need to fetch the PR from upstream?
08:48:20 <planetmaker> yep. And I can quickly build them to actually check what it looks or feels like
08:48:54 <planetmaker> it's all just different branches in my OpenTTD.git
08:58:38 <DorpsGek_II> [OpenTTD/OpenTTD] btzy opened issue #7039: In viewport.cpp at function UpdateViewportPosition(Window *w), what is the purpose of bool update_overlay? https://git.io/fhnGv
09:08:16 <DorpsGek_II> [OpenTTD/OpenTTD] btzy closed issue #7039: In viewport.cpp at function UpdateViewportPosition(Window *w), what is the purpose of bool update_overlay? https://git.io/fhnGv
09:23:59 <DorpsGek_II> [OpenTTD/OpenTTD] planetmaker commented on pull request #7003: Feature #6918: Add option to adjust font size separately from GUI size. https://git.io/fhnGk
10:13:08 <andythenorth> what visual effect for a zero-emissions hydrogen train?
10:15:28 <TrueBrain> dead people where ever it passes through
10:15:50 <TrueBrain> it sends out a vibration that instantly rips open all your organs
10:15:55 <TrueBrain> but, zero-emissions!
10:16:59 <Heiki> no effect normally, but a massive explosion when it breaks down
10:17:50 <Heiki> clearing at least 100 tiles around it in every direction
10:18:46 <SpComb> zero-emission unicorns fart rainbows, not unicorns
10:19:15 <TrueBrain> and if zero-emissions rainbows fart unicorns, we have infinite energy!
10:20:03 <andythenorth> assuming you can find the unicorn
10:20:11 <TrueBrain> and the rainbow, ofc
10:20:15 <andythenorth> it will be at the end of the rainbow
10:20:24 <TrueBrain> okay ... so today I have to find back a 'changelog.sh' script that is on some server in some /root folder ..
10:20:58 <TrueBrain> but in that script there should be some magic code that makes nice changelogs between nightlies
10:32:56 <TrueBrain> owh, that script mostly only works for subversion
10:33:01 <TrueBrain> owh well, something for later today :)
10:43:42 <nielsm> andythenorth just poopping out a trail of water as it travels
10:44:00 <andythenorth> there are some in toyland sprites
10:44:16 <nielsm> or really, some thin steam
10:45:31 <DorpsGek_II> [OpenTTD/OpenTTD] Gabda87 commented on pull request #7025: Add #6887: Option to show zone inside local authority boundary of towns https://git.io/fhnG1
10:51:53 <DorpsGek_II> [OpenTTD/OpenTTD] Gabda87 updated pull request #7025: Add #6887: Option to show zone inside local authority boundary of towns https://git.io/fhsu0
11:12:26 <TrueBrain> how do I find which commit was done 7 days before the current HEAD
11:15:35 <LordAro> oh hey, it'll even do --since="1 week ago"
11:16:39 <TrueBrain> yes .. but that is from the current date
11:16:42 <TrueBrain> not from the HEAD date
11:16:56 <TrueBrain> and I am not willing to change my clock :D
11:18:20 <LordAro> --since="somedate - 1 week" works as well
11:18:25 <LordAro> so just need to get the date of HEAD
11:20:14 <TrueBrain> so we are going old-style
11:20:19 <TrueBrain> revdate=$(git log -1 --pretty=format:"%ci")
11:20:19 <TrueBrain> last_week=$(date -u -d "$revdate -7days" +"%Y-%m-%d %H:%M")
11:20:23 <TrueBrain> was hoping to avoid that :)
11:20:55 <LordAro> you can avoid most of that
11:20:57 <TrueBrain> hmm .. by default 'git log' shows the author date
11:21:03 <TrueBrain> which is often weird
11:21:07 <TrueBrain> should I just use commit date instead?
11:22:00 <TrueBrain> and "most of that" is only the second line :P
11:22:07 <TrueBrain> so that is strictly seen 50% :P
11:22:15 <LordAro> it's longer than the first line
11:22:29 <TrueBrain> just less git-depending :)
11:22:33 <TrueBrain> (I copied this from the subversion script)
11:22:51 <TrueBrain> this is what it used to be
11:22:56 <TrueBrain> do I want to match that
11:23:00 <TrueBrain> or just use git log --pretty=fuller
11:28:24 <TrueBrain> I think fuller is more than sufficient
11:30:09 <TrueBrain> LordAro: difference between 'zip' and 'zip -9' is huge
11:30:37 <TrueBrain> and of course it is better to spend some extra CPU cycles getting binaries smaller :)
11:31:38 <TrueBrain> if I remember correctly, it was bytes with the other compressions, but huge chunks with zip :P
11:32:48 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhnZO
11:38:02 *** synchris has joined #openttd
11:41:30 *** Progman has joined #openttd
11:59:39 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE
11:59:47 <TrueBrain> hmm, that was unneeded
12:09:22 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhnZ6
13:06:29 <TrueBrain> "2019-01-12T12:05:25.6308700Z touch: illegal option -- d"
13:08:27 <LordAro> TrueBrain: why do you want to get a week old commit, anyway?
13:17:32 <DorpsGek_II> [OpenTTD/OpenTTD] btzy opened pull request #7040: Fix: Round up deltas for smooth scrolling, so that target will eventually be reached https://git.io/fhnn8
13:18:33 *** Thedarkb-T60 has joined #openttd
13:27:18 <DorpsGek_II> [OpenTTD/OpenTTD] btzy updated pull request #7040: Fix: Round up deltas for smooth scrolling, so that target will eventually be reached https://git.io/fhnn8
13:45:36 <Eddi|zuHause> so it's illegal in MacOS land to touch d?
14:14:56 *** gelignite has joined #openttd
14:17:18 *** tokai|noir has joined #openttd
14:17:18 *** ChanServ sets mode: +v tokai|noir
14:26:20 *** gelignite2nd has joined #openttd
14:33:59 <DorpsGek_II> [OpenTTD/OpenTTD] btzy opened issue #7041: Cargo flow legend not fully redrawn when middle of station is moved https://git.io/fhncf
14:45:47 *** chomwitt has joined #openttd
14:51:54 <TrueBrain> LordAro: changelog.txt for nightlies are always the last 7 days
14:51:58 <TrueBrain> just to put something in there :)
14:52:09 <TrueBrain> so I dont want a week old commit, I want the log between them
14:52:22 <TrueBrain> and in git world, getting the commit and the log is the same thing :)
14:56:06 *** Thedarkb-T60 has joined #openttd
14:56:12 <TrueBrain> okay, I now have a released.txt, README.md and changelog.txt .. last one left: manifest.yaml .. which is a post-job
14:57:06 <TrueBrain> Also changed the way I fetch the source .. just once now, make a tarball, give that to all the other jobs
14:57:11 <TrueBrain> so we are sure we are building the same thing :D
14:59:36 *** kragniz has joined #openttd
15:00:29 <TrueBrain> so many Doxygen errors and warnings
15:01:22 <LordAro> pretty much all of them should just be to do with missing docs
15:01:40 <LordAro> at least they were a couple of months ago when i fixed all of them :p
15:02:07 <TrueBrain> no clue; just watched the long list passing by :D
15:11:18 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE
15:18:03 *** WWacko1976-work has joined #openttd
15:56:42 <Gabda> is it normal that a road bridge is owned by 2 towns?
15:57:19 <Eddi|zuHause> owner or local authority?
15:57:24 <Eddi|zuHause> is a different thing
15:58:05 <Gabda> the 2 different ends has different owners and local authority
15:58:47 <TrueBrain> did they both pay for it? :P
15:59:04 <Gabda> i was looking for exotic town placements to understand how the local authority works on roads
15:59:24 <Samu> bt, I found a bug regarding town bridges, during world generation the code deletes towns that are generated with 0 population, but by doing so, nearby bridges are also removed
15:59:43 <Eddi|zuHause> then maybe the code that assigns bridge ownership is wrong?
16:00:01 <Samu> those bridges didn't belong to the town being deleted
16:00:09 <Gabda> it is a world generated bridge
16:00:56 <Samu> it results in disconnected towns
16:01:24 <Samu> posted a few screenshots a few days ago, let me find them
16:03:44 <Samu> chronologic order is, image at the top fist, then later on, image at the bottom
16:04:20 <Gabda> I pissed off one of the towns, so I couldn't demolish anything anymore, not even the bridge
16:04:42 <Eddi|zuHause> probably code that has opon founding a town take over ownership of nearby roads
16:04:54 <Gabda> but I could demolish it from the other side of the bridge :D
16:06:02 <Gabda> but the road continuing the bridge belongs to the first city again
16:06:47 <Gabda> like A city, B city, No owner, Road, Bridge
16:07:30 <Eddi|zuHause> other roads built after game start?
16:07:55 <Gabda> R R R R R B B B B B B B B B R R R R R
16:08:01 <Gabda> A A A A A A N N N N N N N B A A A A A
16:08:36 <Gabda> didn't play with the game, so I don't know that one
16:10:38 <Gabda> I think it doesn't have any effect on anything, I just found it funny enough to share :)
16:13:39 <peter1138> #7027 sounds interesting
16:15:08 <Samu> peter1138 hi, you broke framerate window recently, can u fix? was gonna use them to time ship pathfinders
16:15:32 <peter1138> -> report on github or it doesn't exist
16:19:12 <DorpsGek_II> [OpenTTD/OpenTTD] Gabda87 commented on pull request #7025: Add #6887: Option to show zone inside local authority boundary of towns https://git.io/fhnC2
16:21:15 <peter1138> Well there's some other windows I broke :p
16:21:41 <LordAro> are you suggesting that someone didn't review your PR well enough?
16:24:23 <Gabda> So it is not normal that you have to close and open the framerate window to update the data?
16:24:42 <peter1138> OnTick is no longer called, but a couple of windows still have it :p
16:24:46 <peter1138> That's why it doesn't update.
16:24:54 <Gabda> I used that window for the first time today, and it was a little odd.
16:31:19 *** Wormnest has joined #openttd
16:34:58 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #6926: Change: Allow dock to be constructed in more locations https://git.io/fhnCx
16:37:39 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick dismissed a review for pull request #6927: Change: Forbid dock placement on docking area https://git.io/fxptD
16:37:40 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #6927: Change: Forbid dock placement on docking area https://git.io/fhnCh
16:39:11 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #6933: Fix #6233: Improve lock pricing and infrastructure counting, to achieve better consistency https://git.io/fhnWe
16:43:31 <LordAro> Samu: you could also say it was "invalidated"
16:43:53 <Samu> Falling back to patching base and 3-way merge...
16:44:22 *** andythenorth has joined #openttd
16:44:40 <andythenorth> no but seriously
16:44:59 <TrueBrain> welcome back andythenorth
16:45:48 <Samu> if something's wrong, i hope i know it
16:45:58 <Samu> from azure pipeliner dude
16:48:13 <andythenorth> TrueBrain: today is the deadline you set for removing stale issues
16:48:17 <andythenorth> so I will be doing that
16:48:27 <andythenorth> anyone want to save any more FS patches? :)
16:49:23 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep opened pull request #7044: Codechange: Define INVALID_TOWN as a TownID. https://git.io/fhnW3
16:49:24 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #6925: Fix #6574 #6636 #5405 #6493: Aircraft hangar issues https://git.io/fpJfr
16:51:05 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #7044: Codechange: Define INVALID_TOWN as a TownID. https://git.io/fhnWc
16:52:57 <LordAro> andythenorth: i've not had chance to look through them yet, gimme a few more hours?
16:53:24 <TrueBrain> only approved? Not even merged?
16:53:34 <LordAro> CI hadn't finished :p
16:53:45 <TrueBrain> going for quickest PR of th week, I guess
16:54:03 <andythenorth> ^^^ pretty mixed batch
16:54:20 <Samu> how do i quote code on gitgub :(
16:54:20 <andythenorth> I already picked out some where I recognise the author, it's had prior review etc
16:54:31 <andythenorth> also the ones where it's not politics whether it's merged or not
16:55:04 <Samu> andythenorth I wanna reply to you but i fail at quoting code
16:55:13 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6927: Change: Forbid dock placement on docking area https://git.io/fhnW8
16:55:48 <andythenorth> Samu: "yes" / "no" would be enough :)
16:56:40 <andythenorth> for saving FS patches, the ones that are easy to test are also preferable
16:57:08 <andythenorth> e.g. timetable stuff is a fricking tarpit to test
16:57:26 <Samu> it's a resolved converstation thing
16:58:22 <TrueBrain> 15 minutes between attempts for the final pieces of the release pipeline .. this is annoyingly slow :D
16:59:39 <Samu> andythenorth you have to click to show "This conversation was marked as resolved by nielsmh
17:00:11 <DorpsGek_II> [OpenTTD/OpenTTD] Gabda87 commented on pull request #7025: Add #6887: Option to show zone inside local authority boundary of towns https://git.io/fhnWu
17:05:28 <Samu> somebody ruined my patch
17:05:43 <Samu> whoever made the airport tile check
17:06:51 <Samu> the rebase wasn't clear, it only said something weird about 3-way merge
17:07:09 <Gabda> does the codebase have a function that loops over all the tiles that are within a certain (manhattan) distance from a source tile?
17:07:48 <TrueBrain> plenty of variants :D
17:09:33 <Samu> he renamed tile_cur to tile_iter
17:09:51 <Samu> now I understand the importance of keeping the same variable names
17:11:35 <Gabda> TrueBrain: can you give a hint on the name, of the file they are defined in?
17:12:17 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep opened pull request #7045: Codechange #5859: Simplify CheckTrainStayInDepot(). https://git.io/fhnWi
17:13:51 <TrueBrain> Gabda: I wish I knew :D Havent touched the code in 10+ years :P
17:13:54 <TrueBrain> sorry for not being helpful
17:14:07 <TrueBrain> pretty sure that if you open any _cmd file you will find plenty
17:14:43 <Gabda> I found a search patter for it, I hope "#define FOR_" will help me :)
17:15:51 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on issue #6476: Suggested changes for pathfinding for automatic servicing https://git.io/fhnWX
17:16:14 <Gabda> this AddWrap can be interesting, thanks :)
17:16:34 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6476: Suggested changes for pathfinding for automatic servicing https://git.io/fhnWD
17:16:35 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6476: Suggested changes for pathfinding for automatic servicing https://git.io/fhnWy
17:17:37 *** Mahjong has joined #openttd
17:20:03 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on issue #5978: Autoreplace window isn't updated after group hierarchy changes https://git.io/fhnW9
17:20:35 <andythenorth> 'Hydrogen' or 'Fuel Cell'
17:20:42 <andythenorth> Pikka did 'Fuel Cell' in UKRS
17:20:47 <andythenorth> I never used them, dunno why
17:21:12 <TrueBrain> got annoyed by "security vuln"
17:22:35 <andythenorth> hmm novely train power doesn't really work
17:22:42 <andythenorth> Steam | Diesel | Electric
17:22:48 <andythenorth> stick to the knowns :P
17:23:05 <Samu> EnsureNoShipFromDiagDir, basically makes ship size appears like they're 3 tile-wide
17:23:09 <andythenorth> Fuel Cell, Hydrogen, Electro-diesel, Battery, not so good for ottd
17:23:16 <Eddi|zuHause> fuel cell is just a variation on diesel?
17:23:24 <andythenorth> hydrogen usually
17:23:30 <andythenorth> reverse electrolysis or something
17:23:35 * andythenorth chemically vague ;P
17:23:37 <Eddi|zuHause> i mean in terms of game mechanics
17:23:49 <andythenorth> and remove the visual effect
17:23:51 <Eddi|zuHause> just make fuel cell the diesel of 2020+
17:24:01 <andythenorth> the problem is that I like the rolling coal smoke effect :P
17:24:09 <andythenorth> and we don't have rainbows
17:24:21 <Eddi|zuHause> just like the switch from steam to diesel
17:24:28 <Eddi|zuHause> switch from diesel to fuel cell
17:24:31 <Eddi|zuHause> at a certain year
17:24:41 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE
17:24:51 <TrueBrain> now with a Manifest! :D
17:25:54 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhnWp
17:26:45 * andythenorth whistles innocently
17:27:04 <andythenorth> you could just highlight me :P
17:27:18 <TrueBrain> you didnt do the last round of testing :)
17:27:28 <TrueBrain> we have more MacOS users these days helping out!
17:27:30 <TrueBrain> YOU ARE NOT SPECIAL
17:27:46 <peter1138> Oops, I fell asleep o_O
17:28:11 <andythenorth> of course I'm special
17:28:15 <andythenorth> I have a fruit on my computer
17:28:23 <andythenorth> think of how important that makes me
17:29:15 <andythenorth> version # from azure 20190112-azure_release2-g7ba4856b
17:29:28 <andythenorth> version # in the binary package 20190112-azure_release2-g7ba4856b
17:30:15 <andythenorth> version # ingame: 20190112-azure_release2-g7ba4856b
17:30:20 <andythenorth> in all the many places
17:34:43 <andythenorth> Eddi|zuHause: switching at a certain point was my plan, but it's meaningless in-game, except for the loss of effects :P
17:35:00 <Eddi|zuHause> lots of things are meaningless
17:35:15 <andythenorth> so what effect can I abuse?
17:36:05 <andythenorth> there's some white vapour industry smoke
17:37:12 <andythenorth> think it's too big
17:38:44 <Gabda> Samu something happened that shouldn't have?
17:39:40 <Gabda> it seems like there was no merge conflict
17:43:24 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE
17:44:05 <andythenorth> so can we use the topology of the cargo graph as a factor in town pax generation?
17:44:36 <andythenorth> somewhat IRL, number of nodes in the network is a factor in pax numbers
17:44:59 <andythenorth> I think we can re-interpret that to a game world, in a way that is fun
17:45:29 <andythenorth> it doesn't have to be realistic, nor scale perfectly
17:46:30 <Samu> there was no conflict detected, but there was a problem, someone made changes to airport tile iterator and renamed a variable name which made my patch fail to pass the test on azure pipeliner
17:46:47 <Samu> now i wonder if there were more problems
17:48:25 <peter1138> Well, did you not actually compile it yourself?
17:48:36 <peter1138> That's your first mistake.
17:48:42 <Samu> because rebase 99% never fail
17:49:34 <Xaroth> Isn't the idiom "Compile before comitting/submitting" ?
17:50:03 <andythenorth> 99% of my failures are due to not compiling before commit
17:50:03 <Samu> I didn't make any change
17:50:17 <Samu> i only put everything up to date
17:50:23 <andythenorth> ^^ that is complete lies, 99% of my failures are due to not using 'hg add'
17:50:43 <Samu> somebody renamed tile_cur to tile_iter
17:51:02 <Samu> the rebase didn't mention any conflict
17:51:16 <Xaroth> Rebasing has little to do with checking the validity of your code
17:51:20 <andythenorth> thre is no conflict there
17:51:23 <Xaroth> only that changes can be applied one atop of another.
17:52:11 <Xaroth> If you assume that if a rebase works, that your changes will work as well, you're in for a lot of hurt :P
17:52:13 <TrueBrain> wait, there is no magic rabbit? AWH!
17:52:42 * andythenorth reading ground_vehicle.cmd for acceleration
17:52:46 <Samu> so it's my fault, not the fault of the other guy?
17:52:53 <andythenorth> I've been testing, would kind of like a gearing concept
17:53:44 <Samu> rebases are too complicated for my underttanding
17:53:48 <Xaroth> this problem isn't intrinsic to git, it's a common workflow in any programming collaboration
17:54:01 <Xaroth> nor is it inherent to rebases only :)
17:54:26 <Xaroth> if you have a patch set (plain old diff patches), and upstream something changes, your patch will fail to run, just like with this
17:55:47 <TrueBrain> LordAro: no, that sadly is more common than I would like
17:55:53 <TrueBrain> Docker Hub is really terrible in availability
17:55:58 <TrueBrain> I cannot understand that it is .. but it is
17:56:46 <LordAro> remind me, does anyone care either way wrt rebase vs squash?
17:57:07 <TrueBrain> squash is there to make it easier to squash in case someone didnt rebase, but merged/added to his PR
17:57:11 <TrueBrain> which is a fine workflow
17:57:18 <TrueBrain> rebase is the easiest in most cases
17:57:29 <LordAro> that's what i thought
17:57:31 <TrueBrain> I squash 1 commit PRs often so the PR number gets added
17:57:46 <TrueBrain> so what-ever .. just don't squash if the individual commits are useful
17:59:06 <TrueBrain> we are moving to slack?
17:59:16 <TrueBrain> retrigged the job LordAro
17:59:25 <TrueBrain> I really want to move away from Docker Hub
17:59:37 <TrueBrain> setting up our own registry, possibly
17:59:45 * andythenorth read how max_te is used
18:00:02 <andythenorth> practically, testing in-game with hills, TE makes piss all difference to trains
18:00:12 <andythenorth> only HP is relevant to acceleration
18:01:41 <andythenorth> fwiw, I'm not looking for realism, I'm looking for performance variation in vehicles :P
18:02:15 *** snail_UES_ has joined #openttd
18:02:18 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro requested changes for pull request #7040: Fix: Round up deltas for smooth scrolling, so that target will eventually be reached https://git.io/fhnl2
18:03:47 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #7045: Codechange #5859: Simplify CheckTrainStayInDepot(). https://git.io/fhnla
18:04:06 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro merged pull request #7045: Codechange #5859: Simplify CheckTrainStayInDepot(). https://git.io/fhnWi
18:04:09 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE
18:04:15 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro closed issue #5859: Calling VehicleEnterDepot for a train frees the reservation of the depot https://git.io/fhnlw
18:07:47 <TrueBrain> LordAro: read the pipeline :D
18:07:58 <TrueBrain> # If this is false, not all targets are triggered. For example:
18:07:58 <TrueBrain> # both the NSIS installer for Windows and the creation of debs only work
18:07:58 <TrueBrain> # for releases. Not for any other type of binary.
18:08:12 <TrueBrain> Azure Pipelines doesn't allow giving reasons WHY something is skipped
18:08:50 <TrueBrain> I wish I could make it more clear, but there isn't really ..
18:09:10 <LordAro> and because the linux build does so little as part of the pipeline (as opposed to in the docker image), it means it looks like the whole linux build was skipped?
18:10:51 *** frosch123 has joined #openttd
18:11:10 <LordAro> also 245 build is completely different to 223 anyway :>
18:11:15 <TrueBrain> LordAro: I can make it skip steps, instead of jobs, if that helps
18:11:33 <TrueBrain> there is no build 245
18:12:04 <TrueBrain> yes; check the URL :)
18:12:10 <TrueBrain> 2 completely different projects :P
18:12:23 <TrueBrain> and of course, that 245 is the CI
18:12:26 <TrueBrain> has nothing to do with releases :)
18:12:40 <Gabda> can I have two PR-s with the same commit msg?
18:13:13 <LordAro> Gabda: no reason why not, but.. why?
18:13:38 <TrueBrain> LordAro: basically, it skips the 'linux', as all those targets will not be able to build a release. I can also skip them after expansion I guess .. but it still is vague
18:13:43 <TrueBrain> I can make two pipelines
18:13:48 <TrueBrain> but that is a lot of duplication
18:14:22 <LordAro> wait, there is no linux build in 223?
18:14:28 <Gabda> I made a fundamentally different approach for a problem, and I want them reviewed separately
18:14:42 <TrueBrain> LordAro: you should be; you were going to make me a linux build that is generic :D
18:14:53 <LordAro> oh right, and you took that out for now?
18:15:06 <TrueBrain> so no generic linux builds for now :)
18:15:34 <TrueBrain> I am hoping someone comes up with a good way to make generic linux builds :)
18:15:47 <TrueBrain> can even be a .deb :P
18:15:52 <TrueBrain> but currently debs only really work for releases
18:15:57 <LordAro> Gabda: should probably put something in the PR title to show that its different. commit messages can be the same though
18:16:13 <TrueBrain> over time I hope we get Steam releases too, for nightlies .. but .. lets just do the bare minimum first :)
18:16:30 <TrueBrain> no need to build a complete castle first
18:16:35 <TrueBrain> I am happy with a house :)
18:16:59 <andythenorth> pretty similar weight and HP
18:17:02 <Gabda> I thought PR title is the first line of the commit msg. I set it when make a PR, of after that?
18:17:05 <TrueBrain> LordAro: if you click on the Linux (skipped), and than the (!), it shows why it was skipped btw
18:17:52 <LordAro> PR title is mostly unconnected with the commit messages
18:17:56 <LordAro> unless the PR gets squashed
18:18:09 <LordAro> but then whoever's squashing can review the message anyway
18:19:07 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep opened pull request #7046: Fix #5978: Update some stats and lists caused by group hierarchy. (3298 and Juanjo) https://git.io/fhnlj
18:20:14 <peter1138> Hmm, I wonder when the OnTick of a dropdown list happens.
18:20:18 <andythenorth> for the first time in years #openttd.dev might be useful :P
18:20:19 <TrueBrain> meh; seems we are not the only one with docker hub issues .. meh
18:20:31 <peter1138> Something to do with scrolling, but it seems to scroll fine without it;.
18:20:45 <peter1138> andythenorth, this is where we dev
18:21:29 <TrueBrain> LordAro: would it help if I call it "Linux (Stable)" .. meaning it would resolve to "Linux (Stable) linux-ubuntu-xenial-i386-gcc" when not skipped
18:22:52 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE
18:23:24 <TrueBrain> "Linux (Stable only)"
18:23:41 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE
18:24:35 <TrueBrain> looks better, I guess
18:25:02 <TrueBrain> but two pipelines might be better
18:25:31 <TrueBrain> hmm, yes, that would make other things easier too I guess
18:28:10 <Samu> looks like i have nothing more to refresh
18:31:50 <Samu> yesterday night I sent 5000 ships to depots
18:32:09 <Samu> the yapf result was surprisingly good
18:33:14 <Samu> which makes me wonder if my implementation was actually working
18:39:47 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhn8h
18:54:42 <Samu> forbid 90 degs improve pathfinder times
18:55:11 <peter1138> Let options to try.
18:58:51 <Samu> something that juanjo has done was the removal of water tracks if the adjacent tiles were land
18:59:16 <DorpsGek_II> [OpenTTD/OpenTTD] Gabda87 opened pull request #7047: Add #6887: Highlight tiles within local authority of towns https://git.io/fhn44
18:59:17 <Samu> wondering if that could be implemented on the real openttd
19:01:04 <Samu> it would break savegame compatibility
19:02:16 *** Thedarkb-T60 has joined #openttd
19:03:22 <Samu> maybe it could be implemented for pathfinders decision logic?
19:03:51 <peter1138> One way to improve ship pathfinding: explicit ship tracks.
19:04:32 <peter1138> Then it would be similar in performance to trains.
19:04:52 <peter1138> I wonder if implicit-semi-explicit could work.
19:08:51 <andythenorth> can we implicitly lay some?
19:08:56 <andythenorth> when orders are created?
19:09:46 <andythenorth> lay track bits in water tiles?
19:09:52 <andythenorth> then pathfinding is 'next tile'
19:14:54 <andythenorth> 'auto track maker'
19:15:19 *** Thedarkb1-T60 has joined #openttd
19:17:07 <Samu> strange, I have all 5000 ships stopped in depots but the framerate still registers ship tick activity
19:17:58 <peter1138> Could it be that checking 5000 ships to see if they are stopped costs CPU time?
19:19:32 <Samu> maybe it's doing some other type of checks, not just pathfinder
19:19:45 <Samu> dont know how this was implemented
19:22:08 <Samu> just started 5000 ships with opf, about 4100 ms spike
19:22:29 <Samu> the number disappears too fast
19:23:37 <peter1138> Hmm, should I double my RAM to 64GB?
19:23:45 <peter1138> And then add a few uint64s to the map array :D
19:27:25 <andythenorth> peter1138: free RAM with every OpenTTD download
19:27:31 <andythenorth> send us a coupon, we mail it out
19:30:35 <Samu> lets see how many opf ships get lost when sending them to depot
19:34:22 <Samu> going to compare the result with how many opf ships get lost when sending them to depot on 1.8.0
19:35:33 <andythenorth> can I name a train Hermes?
19:35:41 <andythenorth> or does it sound like a courier company? :P
19:41:59 <Samu> 26 ships lost with my implementation
19:46:50 <Samu> 52 ships lost for opf in 1.8.0, out of 5000
19:49:55 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5978: Autoreplace window isn't updated after group hierarchy changes https://git.io/fhnB3
19:54:20 <TrueBrain> "WARNING: Url has SSL/TLS available, switching to HTTPS for download" <- how is that a warning?
19:59:19 <Samu> 4 ships lost for npf in my implementation, out of 5000
19:59:45 <Samu> 7 ships lost for npf in 1.8.0, out of 5000
20:00:04 <Samu> something's wrong, I was expecting 0
20:00:12 <Samu> but ok, will investigate later
20:03:43 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE
20:03:57 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE
20:04:07 <TrueBrain> LordAro: this should fix most of the confusion, I hope :) Lemme know :)
20:04:30 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhnBg
20:04:59 <Samu> wow, yapf is really good
20:05:12 <Samu> 0 ships lost for yapf in my implementation, out of 5000
20:05:21 <Samu> 0 ships lot for yapf in 1.8.0, out of 5000
20:05:35 <LordAro> we call that "actually works"
20:05:46 <LordAro> TrueBrain: cool, will take a look
20:07:52 <andythenorth> oof, some projects might have quietly deleted the old pathfinders
20:08:01 <andythenorth> mumble mumble savegames
20:08:28 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN opened pull request #7048: Fix #6780: Some windows didn't get updated from OnTick() https://git.io/fhnBV
20:09:01 <TrueBrain> we still have multiple PFs? Silly :D
20:09:30 <andythenorth> the terrible even might happen
20:09:38 <andythenorth> one person might post something rude in the forums
20:10:10 <andythenorth> also the only person here who seems to like scorched earth
20:10:24 <Samu> must investigate why npf is failing
20:10:38 <TrueBrain> andythenorth: I honestly don't know why it still is in there
20:10:47 <andythenorth> TrueBrain: I posted the reason above
20:10:47 <TrueBrain> I know 10 years ago it was a hot thing to even talk about
20:10:49 <TrueBrain> but ... 10 years :P
20:10:49 <peter1138> I like scorched earth.
20:10:59 <andythenorth> it's the fear that someone has a saved game
20:11:07 <Samu> it's failing even in 1.8.0
20:11:08 <andythenorth> and makes a post questioning the decision
20:11:10 <TrueBrain> so start a deprecation! :P
20:11:16 <andythenorth> remember depot-flip controversy?
20:11:21 <peter1138> But... I played it about, hmm, 25-30 years ago?
20:11:22 <andythenorth> the only feature that was ever removed
20:11:34 <TrueBrain> you could flip depots? :P
20:11:41 <andythenorth> you could flip trains in depots
20:11:43 <TrueBrain> or was that what that AI did and made massive amounts of money
20:11:48 <andythenorth> it was / is broken for newgrf vehicles
20:11:52 <andythenorth> so it was removed
20:11:52 <TrueBrain> that clearly was abuse/bug :)
20:12:28 <TrueBrain> I love that an AI author found out it was better to have trains do one-ways (and sell/buy constantly)
20:12:31 <andythenorth> wait until I delete 'Extreme' in FIRS 4 :P
20:12:38 <andythenorth> then we'll see woe
20:13:09 <TrueBrain> okay, building nightlies seems to be in good order
20:13:17 <TrueBrain> just needs a CDN to publish the binaries on
20:13:27 <andythenorth> they would build faster
20:13:30 <TrueBrain> and .. then we need to get the new website online :)
20:13:33 <TrueBrain> sadly, 0 contributions :(
20:13:34 <andythenorth> if they had fewer pathfinders
20:15:00 <TrueBrain> I was hoping putting the issues there would attract a few people more helping out :P
20:16:02 <andythenorth> LA is also busy reviewing stuff
20:16:14 <andythenorth> and making some kind of changelog
20:17:17 <TrueBrain> hmm .. when I move everything to a DO CDN, I increase the montly bill with 30 dollars ..
20:17:27 <TrueBrain> in return I no longer have to maintain this custom mirror stuff :P
20:17:27 <andythenorth> what are our funds? :P
20:17:38 <TrueBrain> I have been told I have nothing to worry about
20:17:49 <andythenorth> I have NFI what the money situation is
20:18:08 <TrueBrain> the one thing we are not really open about; not sure why not
20:18:20 <andythenorth> because people can be weird about money?
20:18:22 <TrueBrain> something down the line to look at, I guess
20:18:36 <TrueBrain> yeah .. especially salaries :D
20:18:53 <TrueBrain> anyway, I believe that if we had no donations, we could still run our infrastructure for several years, or something
20:19:07 <TrueBrain> but people are kind enough to still donate
20:19:40 <TrueBrain> people are awesome like that
20:20:03 <Samu> it's turning an automatic service order to an unreachable depot into a manual order to stop at the same unreachable depot, instead of computing another
20:20:45 <Samu> and there really is a depot just 10 tiles away
20:21:41 <Samu> where in the code are automatic service orders changed to manual
20:24:36 <peter1138> My PR failed CI. Github issue or something I did?
20:25:02 <peter1138> Oh right. Commit message wrong. Hmm.
20:25:20 <peter1138> Haha old style -Fix :p
20:25:39 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7048: Fix #6780: Some windows didn't get updated from OnTick() https://git.io/fhnBV
20:26:06 <peter1138> Unable to find image 'openttd/compile-farm-ci:commit-checker' locally
20:26:12 <peter1138> ^ That kinda confused me :p
20:26:20 <TrueBrain> fix it and make a PR :D
20:26:34 <peter1138> I'm gonna fix dinner firsty.
20:27:35 <TrueBrain> Docker really is not the best piece of software out there :(
20:27:41 <TrueBrain> the CLI is so freakinglish inconsistent
20:37:21 <Samu> the same depot happens to be unreachable
20:37:35 <Samu> it doesn't even check with pathfinder
20:40:47 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro requested changes for pull request #7048: Fix #6780: Some windows didn't get updated from OnTick() https://git.io/fhnB7
20:41:10 <Eddi|zuHause> what's wrong with youtube? trying to show me videos such as "why are british trains so bad" and "why is DB so bad"?
20:43:31 <andythenorth> Eddi|zuHause: "why are british trains so bad" is being highly recommended to me also
20:45:57 <Wolf01> Meh, I finished the robotic arm and configured the sbrick profile with the controls (with icons too!) now I have *ache, put any body part in place of * and you'll guess right...
20:46:53 <Wolf01> Youtube for me only suggests lego, spacex, and numberphile
20:55:27 <Eddi|zuHause> i've been subscribed to numberphile for years
21:00:49 <frosch123> do you want links to ruin your suggestions?
21:01:49 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7048: Fix #6780: Some windows didn't get updated from OnTick() https://git.io/fhnBV
21:02:16 <peter1138> LordAro, such a noob ;(
21:04:30 <LordAro> peter1138: given you actually know stuff about the map array, do you think you could offer your thoughts on #7047?
21:04:50 *** Thedarkb1-T60 has joined #openttd
21:06:58 <TrueBrain> hmm .. so Sentry manual suggests to commit the sentry_sdk.init URL in your VCS
21:07:05 <TrueBrain> but that means anyone can report issues on that project ..
21:07:11 <TrueBrain> is it me, or does that sound strange
21:09:01 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7047: Add #6887: Highlight tiles within local authority of towns https://git.io/fhnR1
21:11:39 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7047: Add #6887: Highlight tiles within local authority of towns https://git.io/fhnRD
21:12:10 <LordAro> TrueBrain: depends what you want to achieve, i guess. the other project i know uses an environment variable when running. ...but that's because it's a single instance of an irc bot and rather easier to constrain access to it
21:12:46 <TrueBrain> if I want to achieve people being asses and submit all kinds of bugs via the public DSN, I should put it in git yes :P
21:12:49 <andythenorth> usually Sentry would be in a less open source env?
21:13:09 <andythenorth> access control and all that jazz
21:13:15 <TrueBrain> guess that means I have to setup a Secret on production, and put it in there
21:13:32 <TrueBrain> andythenorth: I don't follow, sorry? :(
21:13:54 <andythenorth> usually you'd be putting that URL in a private VCS?
21:13:59 <andythenorth> with only employees having access
21:14:07 <TrueBrain> or some other method
21:14:14 <TrueBrain> but the getting started kinda suggests to just put it in your code
21:14:25 <TrueBrain> but a search on github gave me a lot of people doing that :D
21:14:28 <andythenorth> we kinda dropped it
21:14:41 <TrueBrain> Sentry is pretty nice for Python and Javascript
21:14:48 <TrueBrain> and free for Open Source, so meh :)
21:14:57 <andythenorth> "the problem was us, not Sentry"
21:14:58 <TrueBrain> any monitoring better than none :D
21:15:10 <LordAro> andythenorth: less "open source env" and more "open env", i think
21:15:12 <peter1138> Hmm, I think I need a bigger microSD card for my retropie. PSX images are big :p
21:15:22 <LordAro> wonder how other systems do error reporting
21:15:26 <LordAro> there must be something out there
21:15:45 <andythenorth> datadog and stuff
21:15:54 <andythenorth> but Sentry seems to be default last time I checked
21:16:01 <andythenorth> or you can....read the logs :P
21:16:39 * andythenorth looking at flyspray patches
21:17:00 <TrueBrain> if you have any system that digests logs, you are fine :)
21:17:20 <TrueBrain> but reading logs yourself is ... very odd andythenorth :P
21:17:27 <TrueBrain> like someone is having a tail open 24/7 :D
21:17:39 <LordAro> yeah, who would do that
21:17:48 <andythenorth> I have to fill in security questionnaires that require it
21:18:02 <andythenorth> as part of bid process
21:18:14 <andythenorth> not even server logs, wifi access logs
21:18:17 <andythenorth> have to be read in detail
21:18:20 <TrueBrain> normally you use SIEMs/SIMs for that :P
21:18:31 <andythenorth> no they require them to be manually audited
21:18:56 <LordAro> andythenorth: idk, it's very weird that the oil rig would be "banned" from using its own station
21:19:07 <andythenorth> you bought exclusive transport rights
21:19:09 <andythenorth> the clue is in the name
21:19:27 <andythenorth> it's correct behavour
21:19:49 <LordAro> guess it boils down to whether "exclusive transport rights" in a town applies to oil rigs
21:20:19 <andythenorth> or we can roll a die
21:20:28 * TrueBrain sees andy drawing a line in the sand
21:20:28 <andythenorth> but changing it is...change
21:21:38 <andythenorth> this, NFI, sounds like a bug
21:21:50 <andythenorth> diff seems quite clean, but eh, dunno
21:22:58 <LordAro> andythenorth: also already part of a PR
21:23:42 <andythenorth> I can't see the PR reffed on the ticket, I should get my glasses
21:23:59 <LordAro> yeah, it's only referenced in the last commit, annoyingly
21:25:11 <LordAro> sounds like it would be confusing
21:25:22 <LordAro> can't imagine it would be difficult to make it apply again though
21:25:25 <nielsm> okay so I could write a decoder for the dos adlib music and import the dosbox adlib emulation to render it... or I could do something actually worthwhile but perhaps less fun
21:25:30 <nielsm> (for certain definitions of fun)
21:26:11 <andythenorth> it sounds confusing to have to ctrl-click titlebars
21:26:21 <andythenorth> windows remembering position isn't a bad idea, but meh
21:27:43 <andythenorth> this sounds like a bug patch
21:27:56 <andythenorth> but diff is relatively big for the issue
21:28:51 <andythenorth> has a test sav if anyone wants to try, otherwise closing
21:29:30 <LordAro> if nothing else it's a bug
21:29:35 <LordAro> even if the patch isn't useful
21:30:28 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6657: Buying exclusive transport rights prevents oil rigs from using their own dock/helipad https://git.io/fhn0i
21:30:29 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6657: Buying exclusive transport rights prevents oil rigs from using their own dock/helipad https://git.io/fhn0P
21:31:01 <peter1138> Hmm, MacOS Job failed.
21:31:26 <peter1138> "The agent: Hosted Agent lost communication with the server. Verify the machine is running and has a healthy network connection." o_O
21:31:46 <LordAro> can't blame docker hub for that one
21:33:18 <TrueBrain> funny error .. first time I have seen thatone :D Hopefully also the last ..
21:33:32 <TrueBrain> weird that the rerun button doesnt work
21:33:47 * andythenorth is not good enough to know how to resolve that :P
21:33:56 <LordAro> probably by skipping it :p
21:34:11 <LordAro> git blame to work out when it got included, see if anything else got included with it
21:35:07 <LordAro> a glance at build_vehicle_gui.cpp suggests that it has not been applied
21:35:38 <LordAro> also, `git apply` might be more effective
21:35:51 <LordAro> or it might barf at the hg patch, who knows
21:36:22 <andythenorth> meh, I did 'apply anyway' and the compile barfs
21:38:32 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6599: Can still click on buy button in vehicle selection window even if no vehicle is selected https://git.io/fhn0Q
21:38:41 <Eddi|zuHause> i don't think that applies cleanly on anything
21:38:51 <andythenorth> it's a stupid small issue
21:38:59 <andythenorth> it's more than an edge case
21:39:08 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7025: Add #6887: Option to show zone inside local authority boundary of towns https://git.io/fhn07
21:39:10 <Eddi|zuHause> you need to apply the patches in order
21:39:49 <andythenorth> I think that one should be left open TBH
21:40:38 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6598: Possible for client to be in a nonexistent company on a server; but then the client crashes. https://git.io/fhn05
21:40:39 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6598: Possible for client to be in a nonexistent company on a server; but then the client crashes. https://git.io/fhn0d
21:41:42 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #6935: Prevent water construction where it could block nearby ships https://git.io/fhn0b
21:43:02 <LordAro> andythenorth: easily reproducible crash/invalid state stuff should be kept open, imo
21:43:50 <andythenorth> NFI if it's worth saving or not
21:44:06 <andythenorth> I suspect fonso would have just committed it if was valid
21:44:40 <LordAro> presumably only because of the last comment?
21:44:51 <DorpsGek> LordAro: fonsinchen was last seen in #openttd 1 year, 44 weeks, 5 days, 3 hours, 38 minutes, and 25 seconds ago: <fonsinchen> There we go.
21:45:34 <LordAro> i'd like to keep it, those performance improvements seem worth it
21:45:51 <LordAro> and JGR's stuff is usually good
21:46:11 <LordAro> feel free to assign me :p
21:46:17 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6472: Cargodist: various link graph performance improvements https://git.io/fhn0x
21:46:18 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6472: Cargodist: various link graph performance improvements https://git.io/fhn0p
21:46:30 * andythenorth is behind the times
21:46:46 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6472: Cargodist: various link graph performance improvements https://git.io/fhn0h
21:48:27 <Eddi|zuHause> andythenorth: so the 3-patch seems to conflict on a uint32/CargoType rename, and something else that seems to already have happened on a completely unrelated thing. should be trivial to solve
21:49:15 <andythenorth> Eddi|zuHause: for 6599? Would definitely be worth solving
21:49:33 <andythenorth> if I can get a clean PR with no faff, I'll test it happily
21:49:44 <LordAro> oh, i didn't even notice that 4/5 patches had already been applied, but cool
21:50:04 <LordAro> andythenorth: given JGR is actually on github, give them a poke first
21:50:40 <Eddi|zuHause> andythenorth: i need to come up with commit messages before pushing this
21:51:16 <nielsm> yeah if the author of a flyspray-imported ticket has a github account, @-mentioning them when updating that ticket could help get it on track
21:51:53 <Eddi|zuHause> andythenorth: at least seems to compile now
21:52:11 <andythenorth> LordAro: I @ JGR already :)
21:52:19 <Eddi|zuHause> what's the easiest way to batch-edit commit messages?
21:52:20 <andythenorth> if the author is on GH, I do @ them
21:52:27 <LordAro> andythenorth: not on 6470
21:52:28 <andythenorth> Eddi|zuHause: rebase -i ?
21:52:50 <peter1138> Hmm, should I try rebasing my RGB company colours patch? :p
21:53:20 <peter1138> Last commit was in 2013, although it was rebased in May last year.
21:54:03 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6470: Link graph job thread-join schedule changes https://git.io/fhnEq
21:54:08 <andythenorth> peter1138: group liveries :P
21:54:30 <andythenorth> delete the current UI, put a menu on every group, just pick two colours
21:54:37 <andythenorth> make a nice palette colour choose thing
21:56:50 <Eddi|zuHause> where's the list of commit message prefixes?
21:57:22 <Wolf01> Uh oh, big update for mashinky
21:58:15 <LordAro> andythenorth: definitely bug, patch is... unclear
21:58:23 <andythenorth> yair I'll change the labels
21:59:24 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6468: Loading savegame with AI loaded as specific version of that AI fails to load correct version of AI https://git.io/fhnEn
21:59:51 <Eddi|zuHause> dunno what prefix applies to these... picking "Change" for now
22:00:41 <andythenorth> looks straightforward
22:01:15 <nnyby> so when will 1.9.0 be released? :P
22:01:47 <LordAro> probably betas and release candidates before that
22:02:09 <Eddi|zuHause> andythenorth: rebase -i just complains i have no tracking branch
22:02:29 <andythenorth> rebase -i is remarkably hard to learn
22:02:38 <andythenorth> but not remarkably hard to actually do
22:02:42 <Eddi|zuHause> ok, rebase -i master works
22:03:11 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6453: Crash: scrolling down list of (none) GS parameters https://git.io/fhnEW
22:03:12 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6453: Crash: scrolling down list of (none) GS parameters https://git.io/fhnEl
22:03:25 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhnE8
22:05:35 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6439: Aircraft will not move if company is bought while displaying "too far to next destination" https://git.io/fhnER
22:05:36 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6439: Aircraft will not move if company is bought while displaying "too far to next destination" https://git.io/fhnE0
22:05:55 <peter1138> andythenorth, hmm, the vehicle-type liveries was quite a wanted feature back in the day :/
22:06:32 <andythenorth> I'm not saying it's crap, burn it with fire
22:06:44 <andythenorth> but there's a more interesting way to do it?
22:06:48 <andythenorth> the UI is crap though :D
22:06:54 <peter1138> Well we can do that AND have group colours.
22:07:26 <peter1138> My livery patch removed the checkbox stuff.
22:07:34 <andythenorth> well ship that :D
22:07:43 <andythenorth> it's just weird, 4 ways to configure pax coach colours
22:07:49 <andythenorth> and freight gets 1 way
22:08:03 <Eddi|zuHause> dunno if any of that is right
22:08:06 <andythenorth> and the whole thing pretends newgrfs don' exist
22:08:35 <peter1138> Not really, it works with company-colour newgrfs.
22:09:00 <andythenorth> I mean the steam / diesel / electric split
22:09:08 <peter1138> And the original classes was done because that's how TTDPatch did it!
22:09:10 <andythenorth> although those are the correct categories :P
22:09:17 <andythenorth> I tried Hydrogen today, and it's weird
22:09:31 <Eddi|zuHause> andythenorth: newgrfs also only know about these three
22:09:35 <andythenorth> mail isn't pax though, I don't think I lose that argument
22:09:50 <andythenorth> Eddi|zuHause: I concede defeat on that point :P
22:09:53 <peter1138> Mail ISN'T passengers, but "pax" covers mail and passengers.
22:10:13 <andythenorth> ha ha the TTDP one is brilliant
22:10:17 <andythenorth> it colours the dropdowns in
22:10:29 <peter1138> The argument for mail being included is that passengers/mail often travel together.
22:10:37 <peter1138> Yeah, I didn't bother with that.
22:11:05 <andythenorth> the coloured dropdowns are every rule of UI design style broken
22:11:06 <nielsm> and might be possible to pull almost unchanged from his branch
22:11:35 <Eddi|zuHause> andythenorth: maybe rules of UI design were different 10 years ago?
22:12:00 <andythenorth> is it 20 years yet?
22:12:11 <Eddi|zuHause> bevels were more pronounced in original TT
22:12:18 *** snail_UES_ has joined #openttd
22:12:27 <Eddi|zuHause> so it got flatter between 1994 and 1996
22:13:33 <andythenorth> Eddi|zuHause: so 7049 - the fix is that it selects another vehicle, when hiding one?
22:13:41 <andythenorth> works for me, if that's the intent
22:13:52 <Eddi|zuHause> i have no clue about intent
22:14:28 <Eddi|zuHause> also no clue if my distribution of "Change" and "Codechange" is correct
22:14:53 <andythenorth> anyway it resolves the issue
22:15:41 <andythenorth> also for the "filter cargo 'none'" case
22:15:52 <Eddi|zuHause> only the first commit seems to be related to the original issue, the rest is "bonus" of some sort
22:15:59 <LordAro> i like #4540, and it has a fonsichen and/or 3298 patch, unstaled
22:16:07 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on pull request #7049: Fix #6599: Can still click on buy button in vehicle selection window even if no vehicle is selected https://git.io/fhnEw
22:16:15 <andythenorth> bonus scares me but eh
22:16:50 <andythenorth> LordAro aren't implicit orders solved yet?
22:17:44 <LordAro> i have no idea tbh, never use them :p
22:18:03 <DorpsGek_II> [OpenTTD/OpenTTD] Gabda87 commented on pull request #7047: Add #6887: Highlight tiles within local authority of towns https://git.io/fhnEr
22:18:24 <andythenorth> do the patches apply?
22:19:17 <LordAro> #4684 seems nice, but perhaps confusing?
22:19:47 <andythenorth> 4684 is tarpit politics
22:19:49 <andythenorth> and doesn't win much
22:20:14 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #4684: Use shift to estimate costs only with a certain type of commands https://git.io/fhnEo
22:20:21 <andythenorth> freeing up shift is questionable
22:20:27 <andythenorth> it often won't be free when it's wanted
22:20:53 <peter1138> Oh, this is a nightmare: "both modified: media/extra_grf/openttdgui.png"
22:20:59 <andythenorth> frigging openttdgui again
22:21:17 <nielsm> seriously, split it into multiple files
22:21:19 <peter1138> Was it not possible to use separate files?
22:21:20 <andythenorth> "but one spritesheet is so much more efficient"
22:21:21 <nielsm> possibly even one per sprite
22:21:42 <andythenorth> some retro misunderstood bollocks about minimising http requests probably
22:21:45 <nielsm> obviously not efficient for the workflow
22:21:58 <andythenorth> optimise for collaborative development
22:22:06 <nielsm> eh perhaps for the artist being able to easier copy-paste pixels bewteen sprites
22:22:16 <peter1138> Ok, when I have a rebase conflict on a binary file, how do I pick which file I want to edit?
22:22:37 <nielsm> (then group a few related sprites into each spritesheet, but still individual files per concern)
22:23:05 <andythenorth> peter1138: NFI, does it matter? You have to open both anyway
22:23:26 * andythenorth should merge all these spritesheets, for 'efficiency'
22:23:27 <peter1138> Yes, but in the rebased state you only get one.
22:23:40 <peter1138> git checkout --ours was the correct incantation.
22:25:02 <andythenorth> someone file a ticket for me to split it up?
22:25:07 <andythenorth> that's how work gets done right? :P
22:25:19 <peter1138> --ours/--theirs is the wrong way around to what I was expecting.
22:26:06 <Eddi|zuHause> <nielsm> eh perhaps for the artist being able to easier copy-paste pixels bewteen sprites <-- because it is so mind-boggingly difficult to have two images open at the same time?
22:26:24 <LordAro> andythenorth: #4540 doesn't apply, but i think it's quite close
22:26:38 <andythenorth> Eddi|zuHause: it probably started small and no-one split it
22:26:46 <andythenorth> the other sprite files are quite split up iirc
22:27:13 <peter1138> Not one per sprite.
22:27:27 <andythenorth> one per sprite is not useful for, e.g. the canals stuff
22:27:41 <andythenorth> that's split up by concern quite well
22:28:08 <andythenorth> but openttdgui.png is too many concerns in one file
22:28:21 <andythenorth> toolbar, window buttons etc
22:28:45 <peter1138> Well yeah, one-per-sprite for the GUI file is what I was thinking.
22:28:46 <andythenorth> LordAro: comment on #4540 then?
22:29:03 <andythenorth> I like implicit orders being displayed, but eh, people used to moan a lot about them
22:29:30 <Eddi|zuHause> clearly a toggle between show/hide implicit?
22:29:39 <andythenorth> peter1138: you proposing to do it, or you want to wait until I do?
22:30:09 *** Thedarkb2-T60 has joined #openttd
22:31:12 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6397: Keep town growth rate in sync with house count https://git.io/fhnEM
22:31:13 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6397: Keep town growth rate in sync with house count https://git.io/fhnED
22:32:52 <LordAro> difficult to tell how much
22:33:35 <andythenorth> I'm closing 6378 and @ dp to tell me if I'm wrong
22:33:35 <Eddi|zuHause> andythenorth: re: #6397: i'm not sure how much of that was actually in the commit. the description is a bit fuzzy
22:34:06 <peter1138> Hmm, how do I force openttd.grf to be rebuilt? o_O
22:34:07 <andythenorth> Eddi|zuHause: you could read the diffs if you could be bothered? :)
22:34:19 <Eddi|zuHause> i don't think i could be bothered :p
22:35:03 <Eddi|zuHause> peter1138: if in doubt, make -B :p
22:35:11 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6378: Erroneous behavior of Get/SetGrowthRate GS methods https://git.io/fhnEH
22:35:12 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6378: Erroneous behavior of Get/SetGrowthRate GS methods https://git.io/fhnEQ
22:35:16 <peter1138> I've never heard of -B
22:35:18 <Eddi|zuHause> there might be a makefile in /media
22:35:31 <Eddi|zuHause> -B ignores timestamps/dependencies
22:35:34 <Eddi|zuHause> and makes everything
22:35:43 <andythenorth> if grfcodec is in the path, and the nfo is changed?
22:35:47 <andythenorth> doesn't it just build?
22:36:04 <Eddi|zuHause> peter1138: only people who fucked up their dependencies usually need -B :p
22:36:09 <peter1138> make -B fails with OpenTTD.
22:36:44 <peter1138> andythenorth, hmm, maybe I need to reconfigure
22:36:52 <LordAro> did you configure with --without-grfcodec or similar?
22:36:58 <peter1138> Yeah that'll be it.
22:37:07 <andythenorth> because of those .obs files?
22:37:14 <peter1138> I installed grfcodec just now, after deinstalling it the other day due to those spurious changed files :p
22:37:21 <andythenorth> I have to git reset --hard every frigging time I want to rebase
22:37:32 <andythenorth> it's really low-level hostile :P
22:37:48 <andythenorth> I tried global .gitignore, but didn't do it right
22:38:10 <peter1138> Ah right, I remember now, the group livery stuff relied on resizing a matrix which just doesn't work :p
22:39:01 <LordAro> andythenorth: hmm, #5377 has a PR #6751... which was closed
22:39:50 <Eddi|zuHause> andythenorth: #6328 has a few more conflicts
22:40:02 <LordAro> it was closed unsatisfactorily, imo
22:40:28 <Eddi|zuHause> uhoh, saveload changes :/
22:40:57 <andythenorth> I would leave 6751 closed, no use case given
22:41:15 <andythenorth> maintainers go mad just trying to please people
22:41:29 <andythenorth> APIs *should* be complete in theory
22:41:38 <andythenorth> but let people come with actual problems they can't solve
22:42:22 <Eddi|zuHause> where do i edit my local gitignore?
22:42:58 <LordAro> andythenorth: i think my "GetWaterTile" idea is best :p
22:43:08 <nnyby> Eddi|zuHause: ~/.gitignore
22:43:48 <Eddi|zuHause> there also seems to be .git/info/exclude
22:43:50 <nnyby> well the filename is flexible. it's configured like this: git config --global core.excludesfile ~/.gitignore_global
22:43:52 <Eddi|zuHause> for repo-specific
22:44:00 <nnyby> just read the article LordAro linked to
22:44:22 <nnyby> Eddi|zuHause: for repo-specific it's just the .gitignore file in each directory
22:44:34 <nnyby> i wouldn't mess with what's in .git/, that's internal git stuff
22:44:50 <Eddi|zuHause> nnyby: no, there's a repo-specific-but-local-gitignore
22:44:57 <nnyby> only stuff i alter in there is .git/config, to set up origin to be my repo, vs upstream OpenTTD
22:45:17 <Eddi|zuHause> i.e. "only in this repo, and only on this computer"
22:45:36 <nnyby> yeah, i've never needed to use that feature
22:45:43 <Eddi|zuHause> where .gitignore is "only in this repo, but shared between everyone"
22:46:19 <Eddi|zuHause> but probably ~/.gitignore would be more appropriate for now
22:46:43 <LordAro> nielsm: care to take up #5735? :p
22:47:52 <andythenorth> I didn't test 5735 because it's queue faff, but it's a good feature
22:48:00 <andythenorth> *way* too many signals in the UI
22:49:26 <LordAro> #5977 is trivial, and applies
22:49:48 <andythenorth> yeah 3298's stuff was pretty good
22:49:52 <andythenorth> I tested quite a bit of it
22:50:13 <LordAro> shame he didn't get on with github
22:50:27 <andythenorth> there is a forum ticket with a bunch of useful fixes in
22:50:28 <LordAro> i noticed in his forum post that he cited having to pay for private repos as an issue
22:50:41 <LordAro> now that that is no longer the case...
22:50:44 <andythenorth> JJ has been picking some of the fixes out
22:51:05 <Eddi|zuHause> so... gitignore sorted out, distributed stuff between ~/.gitignore and .git/info/exclude appropriately, i think
22:51:07 <andythenorth> 3298's primary problem was being tracked
22:51:11 <andythenorth> but eh distractions
22:51:22 <andythenorth> Eddi|zuHause: can we all have our gitignore fixed?
22:51:26 <andythenorth> I will mail you my computer
22:51:26 <Eddi|zuHause> now back to the actual conflict
22:51:42 <Eddi|zuHause> andythenorth: teamviewer? :)
22:52:16 <andythenorth> there's no save attached
22:52:42 <andythenorth> it's not from a contributor I recognise
22:53:12 <nielsm> LordAro I'd do the signal GUI completely different myself from that patch in 5735 :)
22:53:24 <nielsm> but don't really feel like working on GUI right now
22:53:33 <LordAro> andythenorth: kill it ^
22:54:16 <andythenorth> I don't actually much like the new signal ui in the attached PNG
22:54:19 <andythenorth> it's not....good
22:54:25 <Eddi|zuHause> andythenorth: i'm not sure if i understand #2944, i thought that's how it already behaves?
22:54:38 <andythenorth> Eddi|zuHause: NFI, timetables don't work for me ever :)
22:54:51 <andythenorth> something about having to use full load, or not
22:54:59 <andythenorth> timetables are super confusing and broken
22:55:12 <andythenorth> actually I lie 100%
22:55:22 <nielsm> LordAro, I want to make a decoder for the dos adlib music (ADLIB.CAT) and play it through emulation
22:55:26 <andythenorth> I use 'wait at station for n days' on nearly all pax routes :P
22:55:54 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #6266: UI Zoom: ugly lists in network windows on double/quad interface sizes with custom fonts https://git.io/fhnuI
22:55:57 <Eddi|zuHause> timetables are ok, but miss a lot of advanced features
22:56:19 <Eddi|zuHause> too much micromanagement
22:57:43 <andythenorth> why it's not just a cadence of vehicles I don't know :P
22:57:46 <andythenorth> seems very complex
22:58:00 <andythenorth> it's for modelling real world timetables for train fans, right?
22:58:21 <LordAro> i can't actually compile on mingw
23:01:56 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5735: Signals: signal window - show one signal variant at a time https://git.io/fhnuq
23:01:57 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #5735: Signals: signal window - show one signal variant at a time https://git.io/fhnum
23:05:34 <andythenorth> I don't think making 'location' an icon is wise
23:05:55 <Eddi|zuHause> src/depot_base.h:46:13: error: ‘const struct Depot’ has no member named ‘type’
23:05:56 <Eddi|zuHause> return d->type == this->type;
23:06:04 <andythenorth> Eddi|zuHause: TMWFTLB?
23:06:30 <Eddi|zuHause> but also not trivial, like the other one
23:06:53 <andythenorth> order handling might need adjusted
23:07:26 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5981: Unify appearance and position of location buttons (wanted contributions-list) https://git.io/fhnus
23:07:27 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #5981: Unify appearance and position of location buttons (wanted contributions-list) https://git.io/fhnuG
23:08:22 <Eddi|zuHause> so what happened to depot types?
23:08:23 <andythenorth> TrueBrain: ready for Probot yet? ^
23:08:34 <andythenorth> NotDepotTypes Eddi|zuHause ?
23:10:24 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6060: Allow drawing dropdown lists with scrollbars above the widgets https://git.io/fhnuC
23:11:02 <Eddi|zuHause> can't i browse through just changes to a specific file on git?
23:11:08 <Eddi|zuHause> i can get the changelog for that file
23:11:18 <Eddi|zuHause> but it'll lead me to complete repo diffs
23:12:19 <andythenorth> is there a blame view
23:13:09 <andythenorth> can't figure out how to use it though :P
23:14:07 <andythenorth> nope wrong paste
23:15:20 <Eddi|zuHause> i found a deeply hidden thing in git gui that does what i want
23:15:50 <Eddi|zuHause> but i found no evidence of depot type ever being a thing
23:16:33 <Eddi|zuHause> maybe it's a badly ordered patch queue, i'll ignore it and go ahead
23:17:53 <Eddi|zuHause> if it works after all patches are applied, then maybe consider squashing?
23:20:09 <andythenorth> the original issue seems to be fixed
23:20:33 <andythenorth> I can crash r27656 by making the window size too small to display a dropdown menu
23:20:39 <andythenorth> which is clown shoes, but seems fixed in 1.8.0
23:20:50 <andythenorth> I don't know what the remaining patches fix
23:25:22 *** Thedarkb2-T60 has joined #openttd
23:25:39 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6583: Scrolling down/right out of map on a 255 high flat map bounces viewport back to edge of map https://git.io/fhnu0
23:26:35 *** Wormnest has joined #openttd
23:27:00 <Eddi|zuHause> so complete queue compiles
23:30:55 *** Thedarkb-T60 has joined #openttd
23:33:41 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6583: Scrolling down/right out of map on a 255 high flat map bounces viewport back to edge of map https://git.io/fhnur
23:35:48 <andythenorth> Eddi|zuHause: did you test it? o_O
23:36:48 <andythenorth> it's pretty neat
23:37:03 <andythenorth> the building / rebuilding is pretty straightforward
23:37:17 <Eddi|zuHause> yeah, i do remember going "why does this not work?" a while ago
23:37:49 <andythenorth> I've got a train stuck though
23:38:02 <andythenorth> I gave it orders to a depot, then deleted the depot
23:38:04 <Eddi|zuHause> but it's not quite merge-ready i think
23:38:21 <andythenorth> actually it's user error I think
23:38:25 <andythenorth> the order has been invalidated
23:38:39 <Eddi|zuHause> i'm assuming it's going to disappear after a month like invalid station?
23:39:39 <andythenorth> kind of thing that needs a long-run game to test it
23:39:47 <andythenorth> or just putting in a nightly :P
23:40:36 * andythenorth wonders what it does with airport hangars
23:41:27 *** Thedarkb1-T60 has joined #openttd
23:42:15 <andythenorth> distance is 8 tiles Eddi|zuHause ?
23:48:26 <LordAro> i feel like i saw something about an appdata.xml somewhere else recently anyway
23:48:28 <andythenorth> also the dude was just plain rude
23:48:41 <andythenorth> "Copying it into your repository shouldn't be that much of an effort. If your attitude would be more friendly and your source code repository more accessible, "
23:48:48 <andythenorth> is 50% accurate, at the time :P
23:49:30 <andythenorth> closing, there's nothing useful to test there, just another grumpy open source developer
23:49:57 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6490: appdata.xml metadata file for inclusion in Software Center https://git.io/fhnuF
23:49:58 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6490: appdata.xml metadata file for inclusion in Software Center https://git.io/fhnub
23:50:28 <andythenorth> scroll bug -> refactor tile heights completely :P
23:50:47 <Samu> ok, gonna create an assert
23:52:28 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6505: Allow rail when ships are on lower halftile https://git.io/fhnuN
23:53:21 <Samu> aha, an assert was triggered
23:57:38 <Samu> nielsm was right, now the ship is told to reverse
23:57:40 <frosch123> andythenorth: you need a dropdown with a lot of entries
23:57:49 <frosch123> possibly translation selection or so
23:58:03 <frosch123> then make the main window very small in height
23:58:04 <Samu> would not reverse otherwise, but I can't see where the shit is
23:58:10 <andythenorth> I did trigger the previous assert with very small window height
23:58:15 <frosch123> so that the whole selection doe snot fit
23:58:44 <frosch123> then position the combobox in the upper or lower half of the main window
23:58:58 <Eddi|zuHause> andythenorth: seems that regression failed
23:59:32 <andythenorth> frosch123: all of that seems to work fine ?
23:59:37 <Eddi|zuHause> and that errors are still useless
continue to next day ⏵
