IRC logs for #openttd on OFTC at 2018-10-26
⏴ go to previous day
00:11:34 <Eddi|zuHause> i think the point of spam is to penetrate the ignore-capacity of enough people
00:17:03 <planetmaker> if 1M read it and 100 click it, it might be successful
00:35:28 *** Thedarkb-X40 has joined #openttd
00:57:16 *** Wacko1976_ has joined #openttd
02:38:19 *** bigjazzsound has joined #openttd
04:04:01 *** zuzabrik has joined #openttd
04:16:51 *** triolus00 has joined #openttd
05:00:02 *** sh4rm4^Q has joined #openttd
05:20:37 *** HerzogDeXtEr has joined #openttd
05:59:00 *** bytesighs has joined #openttd
06:25:23 *** d-fence_ has joined #openttd
06:27:07 *** sim-al2 has joined #openttd
07:08:10 *** FrostFeline7 has joined #openttd
07:09:05 *** ramindia has joined #openttd
08:36:29 *** serialoverflow19 has joined #openttd
09:12:04 *** puddingpimp has joined #openttd
09:31:05 *** fryguybo1 has joined #openttd
10:09:17 *** matt21347 has joined #openttd
10:39:12 *** glavinics has joined #openttd
11:34:37 *** Thinkofname has joined #openttd
11:37:02 *** ianychoi has joined #openttd
11:47:03 *** Wacko1976 has joined #openttd
12:22:26 <glavinics> Hi, question regarding the "cleanup+moving to git" in general as I am totally new: Is there any plan to introduce cmake instead of simple make and with this support the cross platform compilation, it would support to generate visual studio and xcode project as well?
12:31:10 *** cypher6 has joined #openttd
12:36:00 <Xaroth> glavinics: You can always send in a PR
12:41:46 *** HerzogDeXtEr has joined #openttd
12:50:40 <FLHerne> glavinics: FWIW, the current buildsystem already generates MSVC projects
12:50:50 <FLHerne> glavinics: See projects/generate.vbs etc.
12:51:06 <FLHerne> (using CMake probably would save a lot of awkward custom code there)
13:11:44 *** dcraig8 has joined #openttd
13:23:08 <LordAro> it's not a high priority
13:54:45 *** atomizer has joined #openttd
14:37:05 *** automatical has joined #openttd
15:08:29 <glavinics> thanks, I'm going to check this branch
15:12:35 <LordAro> it's very very incomplete
15:12:59 <LordAro> i did get it into a compiled state, can't remember whether i ever finished adding any video libraries
15:13:11 <LordAro> which makes it a bit fun for usability :)
15:14:38 <glavinics> I'm new so everything is good for practice and get familiar with the environment, no worries :)
15:20:33 *** Stimrol has joined #openttd
15:39:03 <ST2> oh, we're almost on the time for scary things :D
17:12:25 *** Wormnest has joined #openttd
17:16:46 *** rocky11384497 has joined #openttd
17:45:39 <Eddi|zuHause> i'm not sure i should have watched that
17:56:42 *** wodencafe has joined #openttd
18:00:34 *** Stimrol has joined #openttd
18:16:23 *** yellyFish has joined #openttd
18:23:34 *** Thedarkb has joined #openttd
18:27:45 *** TheMask96 has joined #openttd
18:42:58 <yellyFish> I have been trying to measure some functions with the in-game framerate thing but can't seem to make it work. i added a new row for it in framerate_gui.cpp and in framerate_type.h but still nothing. I just get a 'Game loop' row in blue in the frame rate window
18:43:08 <yellyFish> It compiles fine and all
18:43:49 *** Thedarkb has joined #openttd
18:44:41 <nielsm> you need to add a bunch of things in different places, in the right order
18:45:45 <nielsm> and most or none of it is sanity checked at compile time
18:46:01 <nielsm> can you make a diff of your changes and put it on a pastebin?
18:46:18 <nielsm> (or a branch on github)
18:46:45 <yellyFish> yeah. the thing is i am doing this with JGRPP
18:46:57 <yellyFish> but i don't think it changes that much
18:59:19 <nielsm> you also need to add the string to english.txt
18:59:25 <Eddi|zuHause> usually people make "unified diff"s, because they are a lot more readable
18:59:40 <Eddi|zuHause> also, versioning tools like git make those by default
18:59:46 <nielsm> if you're using git, use the 'git diff' command
19:01:08 <yellyFish> i have been learning git with my own little toy projects, but i don't know if it's possible to use it with not the newest version to test on the same version of the server
19:01:44 <Eddi|zuHause> yes, that's easy
19:02:00 <nielsm> git diff <- makes a diff of unstaged, uncommitted changes
19:02:04 <Eddi|zuHause> just "git checkout <hash>"
19:02:11 <nielsm> git diff --cached <-- makes a diff of stages, uncommitted changes
19:02:37 <nielsm> git diff <revisionorbranchname> <-- makes a diff from current committed version to that commit
19:02:54 <Eddi|zuHause> the hash is in the server version "OpenTTD g<hash>"
19:03:49 <Eddi|zuHause> instead of a hash you can also use a tag
19:03:52 <LordAro> no mention of if it's been fixed in 2017
19:04:02 <yellyFish> uhhh, let me try this english.txt thing first
19:06:27 <Samu_> 2015 update 3 is what I use I think
19:14:13 <yellyFish> welp. at least it shows the name. but it shows 0.00 ms but that's not possible because i know this function is used a lot
19:14:26 <nielsm> LordAro, would you prefer solving that compile error via removing the static assert, moving it inside the constructor,m or moving it inside the event function near the point of variables' use?
19:14:36 <yellyFish> i'll do the git thing first tho
19:15:29 <LordAro> nielsm: i would probably say the constructor
19:15:32 <nielsm> yellyFish ah yeah, when using PerformanceAccumulator you need to also add a "reset" of the accumulator somewhere
19:17:01 *** Thedarkb has joined #openttd
19:18:40 <nielsm> yellyFish, probably add PerformanceAccumulator::Reset(PFE_SPRITEGROUP); on openttd.cpp line 1360
19:18:45 <nielsm> just below the other reset
19:19:23 <nielsm> it's not entirely obvious from that function name, but it's actually in the Reset function the measurement gets recorded
19:19:38 <nielsm> the constructor only accumulates timing into the current measurement
19:20:13 <yellyFish> am i too picky or this should be made into a object so we can insert more easily new measurements?
19:20:36 <yellyFish> or something like that to automate this process at least
19:20:40 <nielsm> I tried making it as simple to add new things as possible :)
19:21:21 <yellyFish> or is it already somewhere?
19:21:35 <nielsm> any easier to plug in than this and you'd need to either sacrifice runtime performance, or use some preprocessor step on the code
19:21:48 <nielsm> nah, more documentation would be in place, you're right
19:22:07 <yellyFish> i am not trying to be rude btw ;)
19:22:10 <Eddi|zuHause> we used to have a "Cookbook" in the wiki to record that kind of "howto", but that typically is outdated by the time it is written...
19:22:34 <nielsm> yeah, it's better to add it to the doc comment on the class
19:25:33 <yellyFish> so i clone, then checkout to the version i want and branch?
19:43:12 *** _1horimiya1 has joined #openttd
19:43:14 *** _1horimiya1 has left #openttd
19:43:54 *** _1horimiya1 has joined #openttd
19:47:56 *** andythenorth has joined #openttd
19:53:35 *** gelignite has joined #openttd
20:08:05 *** frosch123 has joined #openttd
20:13:06 *** wodencafe has joined #openttd
20:18:57 *** gelignite has joined #openttd
20:19:58 *** Thedarkb has joined #openttd
20:20:35 *** gelignite2nd has joined #openttd
20:26:05 <andythenorth> wondering if I can get forums fixed
20:26:14 <andythenorth> kind of used to like htem
20:31:06 <andythenorth> more horse or something
20:31:14 <andythenorth> can we get any more PRs through?
20:31:27 *** MC_saban has joined #openttd
20:37:20 <Eddi|zuHause> i don't think i have useful input for any of those
20:43:30 *** yellyFish has joined #openttd
20:45:08 *** Thedarkb1-X40 has joined #openttd
20:45:22 *** Thedarkb1 has joined #openttd
21:15:46 *** Wacko1976 has joined #openttd
21:16:10 *** yellyFish has left #openttd
21:16:53 *** yellyFish has joined #openttd
21:31:59 <Wolf01> I should burn my credit card
21:36:31 *** yellyFish has joined #openttd
21:44:58 <andythenorth> any new technic?
21:45:54 <Wolf01> I'm curious about the new pneumatic valves
21:46:43 <Wolf01> You might say "buy the valves alone", no, MOAR PIECES!
21:46:48 <Eddi|zuHause> i don't trust people who don't articulate the "p" in "pneumatic"
21:48:00 <andythenorth> I ordered new valves on BL
21:49:56 <Eddi|zuHause> that's because of brexit
21:54:29 *** yellyFish has joined #openttd
21:55:07 *** yellyFish has joined #openttd
22:04:00 <yellyFish> is it possible to make the same change to two branches? i want to change where i measure the timing for both the base case and the one with changes
22:05:12 <nielsm> cherry-pick the revision from one branch to the other
22:05:37 <nielsm> or, make the change on a separate branch and merge than branch into both
22:05:44 <nielsm> actually do the latter
22:07:11 <yellyFish> but shouldn't it work to change the base case branch only if i made the branch with changes from it ?
22:08:10 <yellyFish> or am i misunderstanding how branching works
22:09:47 <nielsm> you probably are, but I'd need a drawing board to explain things well so I'll just tell you to read up on it somewhere else that already has pre-made illustrations
22:10:11 <yellyFish> yeah. i am also reading
22:11:25 <andythenorth> it's just a tree
22:11:40 <nielsm> nah it's a directed acyclic graph
22:12:31 <nielsm> if you know what a DAG is git becomes a lot easier to understand
22:12:46 <andythenorth> the problem with DAGs
22:12:51 <andythenorth> is you start seeing them everywhere :P
22:12:51 <yellyFish> i know what a DAG is
22:14:09 <yellyFish> DAGs are trees but not all tress are DAGs
22:14:22 <Eddi|zuHause> <yellyFish> but shouldn't it work to change the base case branch only if i made the branch with changes from it ? <-- you'd want to have a script that duplicates the commit you make on one branch automatically on the other one
22:15:40 <Eddi|zuHause> or, you have a branch and rebase it onto whatever checkout you want
22:16:30 <Eddi|zuHause> so your branch can be on top of anything you want, but you have only one copy of the branch at any given time
22:17:57 *** Progman has joined #openttd
22:21:41 *** leerg319 has joined #openttd
22:25:13 *** glavinics has joined #openttd
22:27:16 <yellyFish> mmm. so if i rebase the common node for both branches then they will also have those changes?
22:46:19 <Eddi|zuHause> yellyFish: by rebasing your branch, you take it off one node, and reattach it to another node on the graph
22:46:38 <Eddi|zuHause> so it will disappear at one place, and reappear at another
22:52:24 *** andythenorth has left #openttd
23:45:01 *** Gustavo6046 has joined #openttd
continue to next day ⏵
