⏴ go to previous day
01:11:25 *** FLHerne has quit IRC
01:35:16 *** Supercheese has joined #openttd.dev
08:08:33 *** Zuu has joined #openttd.dev
08:08:33 *** ChanServ sets mode: +v Zuu
08:18:29 *** FLHerne has joined #openttd.dev
08:27:02 *** FLHerne has quit IRC
09:23:35 *** Supercheese has left #openttd.dev
09:23:39 *** Supercheese has quit IRC
09:49:42 *** frosch123 has joined #openttd.dev
09:49:42 *** ChanServ sets mode: +v frosch123
13:01:09 *** michi_cc has quit IRC
13:02:39 *** michi_cc has joined #openttd.dev
13:02:40 *** ChanServ sets mode: +v michi_cc
14:34:21 <Belugas> hello
15:52:55 *** Knogle has joined #openttd.dev
16:09:04 *** Er00 has joined #openttd.dev
16:56:27 *** FLHerne has joined #openttd.dev
16:56:31 <Yexo> ..\src\newgrf_station.cpp(538): warning C4355: 'this' : used in base member initializer list <- msvc spits out this warning multiple times due to the new newgrf resolver code
16:57:06 <frosch123> yes, we already discussed it
16:57:23 <Yexo> ah, ok :)
16:57:24 <frosch123> best option seems to be disabling the warning
16:58:19 <frosch123> http://devs.openttd.org/~frosch/diffs/stuff3/ <- multiple editboxed cannot be far, but that is not my target
16:58:42 <frosch123> hmm, not sorted numerically, but i guess you can figure it out :)
16:59:54 <frosch123> looks fine if it works
17:00:03 <Yexo> it does
17:04:10 <Yexo> in 15_ maybe add a little comment that the check is for hotkeys? Something like: /** OnClick is also called for hotkeys, this can happen even if the widget is disabled. */
17:06:14 <Yexo> I really like 20_, didn't expect that to be so simple :)
17:07:21 <frosch123> yeah, that was also my thought :p
17:08:30 <Yexo> The name is only allowed when it starts with a letter! */ <- that check seems a bit too simple, but that's not really part of your patch
17:12:11 <Yexo> no obvious mistakes in 50/60/70, but it's hard to validate them without looking at a lot of code
17:16:00 <Yexo> in 90: + if (this->ok_button) {
17:16:12 <Yexo> that doesn't look right, ok_button is an int, right?
17:16:24 <frosch123> hmm, yeah, needs a != 0
17:16:38 <Yexo> isn't 0 a valid widget index?
17:17:13 <frosch123> hmm... then i might need -1
17:17:19 <Yexo> exactly
17:18:29 <frosch123> also wrong in the old osk then :)
17:18:38 <frosch123> i'll insert a fix for that earlier in the queue
17:21:14 <Yexo> 100_ is hard to check without more context
17:21:23 <Yexo> would be a lot easier if the patches before it were already applied
17:22:42 <Yexo> any special plans with 120_?
17:22:49 <Yexo> not sure I like that patch the way it's now
17:23:49 <frosch123> no, it was just the next logical step
17:23:57 <Yexo> in that case: great :)
17:23:59 <frosch123> for eliminating QueryStringBaseWindow
17:24:04 <frosch123> but i won't finish that
17:24:14 <frosch123> i don't need 120, it was just easy :p
17:25:15 <frosch123> support for multiple editboxes is now basically replacing the dynamic_cast with something that gives the QueryString for a widget num
17:25:29 <frosch123> while QueryStringWindow already has no point at all
17:25:44 <frosch123> except defining some member variables which only the derived class uses
17:34:57 *** Supercheese has joined #openttd.dev
17:50:56 <frosch123> updated the queue, esp. inserted 75
18:11:59 <planetmaker> hm, nice cleanup queue, frosch123 :-)
18:12:58 <frosch123> :)
18:13:19 <frosch123> planetmaker: there is a parameter in swissrails about bridge overlays
18:13:32 <frosch123> what value do i set it to, resp. what bridgeset do i use for best result?
18:13:39 <frosch123> *swedrails
18:14:57 <frosch123> or does the readme still apply: no bridgegrfs yet?
18:15:31 <frosch123> i guess so :p
18:19:27 <planetmaker> indeed, the readme still applies
18:19:57 <planetmaker> with default settings it should thus work for each bridgeset :-)
18:45:11 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24719 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:40:51 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24720 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:41:56 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24721 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:46:10 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24722 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:46:15 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24723 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:46:20 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24724 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:46:23 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24725 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:46:33 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24726 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:46:38 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24727 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:46:41 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24728 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:46:47 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24729 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:46:50 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24730 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:46:54 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24731 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:46:59 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24732 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:47:03 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24733 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:47:08 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24734 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:47:14 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24735 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
22:52:07 *** frosch123 has quit IRC
23:28:30 *** FLHerne has quit IRC
continue to next day ⏵