⏴ go to previous day
00:00:21 *** Yexo- has joined #openttd.dev
00:00:51 *** pm has joined #openttd.dev
00:00:51 *** ChanServ sets mode: +v pm
00:01:48 *** Hirundo has quit IRC
00:02:11 *** SmatZ has quit IRC
00:02:21 *** |Terkhen| has joined #openttd.dev
00:03:38 *** frosch123 has quit IRC
00:05:01 *** Yexo has quit IRC
00:05:10 *** Terkhen has quit IRC
00:05:36 *** planetmaker has quit IRC
00:05:36 *** pm is now known as planetmaker
00:33:56 *** Webster has quit IRC
00:35:40 *** Webster has joined #openttd.dev
00:35:41 *** ChanServ sets mode: +v Webster
07:04:55 *** Knogle has quit IRC
07:05:41 *** Knogle has joined #openttd.dev
07:16:55 *** Knogle has quit IRC
07:25:54 *** |Terkhen| has left #openttd.dev
07:26:06 *** Terkhen has joined #openttd.dev
07:26:06 *** ChanServ sets mode: +v Terkhen
07:30:06 *** Zuu has joined #openttd.dev
07:30:06 *** ChanServ sets mode: +v Zuu
07:51:45 *** Zuu has quit IRC
08:11:55 *** Supercheese has quit IRC
09:44:09 *** frosch123 has joined #openttd.dev
09:44:09 *** ChanServ sets mode: +v frosch123
12:00:19 *** planetmaker has quit IRC
12:00:19 *** Terkhen has quit IRC
12:00:19 *** Yexo- has quit IRC
12:00:19 *** Hirundo_ has quit IRC
12:00:45 *** Hirundo has joined #openttd.dev
12:01:45 *** Terkhen has joined #openttd.dev
12:01:45 *** ChanServ sets mode: +v Terkhen
12:02:15 *** Yexo has joined #openttd.dev
12:02:45 *** planetmaker has joined #openttd.dev
12:02:45 *** ChanServ sets mode: +v planetmaker
15:11:19 *** V453000 has joined #openttd.dev
16:59:52 <frosch123> http://devs.openttd.org/~frosch/diffs/stuff2/ <- random selection of fixes, codechanges and featurettes
17:01:01 *** V453000 has left #openttd.dev
17:04:39 *** V453000 has joined #openttd.dev
17:04:42 *** V453000 has left #openttd.dev
17:14:53 *** SmatZ has joined #openttd.dev
17:14:53 *** ChanServ sets mode: +v SmatZ
17:32:02 *** FLHerne has joined #openttd.dev
17:34:07 *** ChanServ sets mode: +v Yexo
17:34:13 <Yexo> in 10_ the first chunk seems unnecesary if you apply the second chunk, but it's more clear to add it
17:34:50 <frosch123> well, multiplayer scenario editor :)
17:35:17 <Yexo> which we don't have :P
17:35:29 <Yexo> in 20_nop, where is it initialized already?
17:35:35 <frosch123> in constructor
17:35:48 <frosch123> of GoodsEntry
17:41:36 <Yexo> in 50_docs I'd like to see some more docs for last_speed, most notable the unit of the speed
17:42:12 <Yexo> and is days_since_pickup really in days or is it in "2.5 days"?
17:43:58 <Yexo> + * @param front The Vehicle to check. For trains, use the first engine. <- I assume it should be the first part for all vehicles types (articulated road vehicles, multiple aircraft parts)?
17:44:41 <frosch123> it's the front of the consist
17:45:03 <Yexo> that's what I thought, second part of that comment seems a bit off since it only talks about trains
17:45:16 <frosch123> do you have a better wording?
17:46:14 <Yexo> @param front The first Vehicle of the consist to check. <- perhaps like that?
17:46:58 <Yexo> No more comments up to and including 70_simplify.diff, will look at the other diffs later
17:47:17 <frosch123> thanks :)
17:51:54 *** LordAro has joined #openttd.dev
17:51:54 *** ChanServ sets mode: +v LordAro
17:57:52 *** V453000 has joined #openttd.dev
18:01:21 <frosch123> V453000: you won't get rid of us :p
18:01:44 *** V453000 has left #openttd.dev
18:07:12 *** LordAro has quit IRC
18:09:33 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24703 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
18:10:04 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24704 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
18:10:22 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24705 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
18:10:43 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24706 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
18:11:05 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24707 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
18:11:28 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24708 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
18:11:47 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24709 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
18:20:41 *** FLHerne has quit IRC
18:21:52 *** Zuu has joined #openttd.dev
18:21:52 *** ChanServ sets mode: +v Zuu
18:45:08 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24710 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
18:48:06 <michi_cc> frosch123: The commit message in 91_fs5262.diff has an obiwan ;)
18:49:37 <frosch123> has it?
18:50:33 *** Alberth has joined #openttd.dev
18:50:33 *** ChanServ sets mode: +v Alberth
18:55:26 <frosch123> hai albert :)
18:55:37 *** pachuco has joined #openttd.dev
18:55:41 <frosch123> http://devs.openttd.org/~frosch/diffs/stuff2/ <- in case you also want something to read
18:55:48 *** pachuco has quit IRC
18:55:50 <frosch123> 10-70 are already committed though
18:58:33 *** FLHerne has joined #openttd.dev
19:00:41 <Alberth> 80 message: no other vehicle unloading s/un// ? (unless pickup means something else than I think
19:01:10 <Alberth> since 10k3 :) quite old :)
19:01:30 <frosch123> well, it is about checking whether a vehicle only unloads, or also loads
19:02:14 <Alberth> 91 Tollerate s/ll/l/
19:02:28 <Terkhen> I was just going to mention that :)
19:02:30 <Terkhen> hello btw
19:02:34 <Alberth> hi :)
19:02:35 <frosch123> michi_cc: did you mean that with obiwan? one "l" instead of two?
19:03:53 <michi_cc> Yeah, you're off by one l :
19:04:58 <frosch123> i checked the fs number 3 times :p
19:08:35 <Alberth> queue seems ok to me, with my barely existing newgrf knowledge
19:08:57 <frosch123> the first part was less about newgrfs :p
19:10:49 <Alberth> I was reading that now :) Trying to fix the station acceptance thingie?
19:11:53 <frosch123> no, only the weird documentation of the GoodsEntry, and the numerous bugs and inconsistencies which resulted of it
19:12:17 <frosch123> but, it might be a some preparation for the accept/deny supplies thingie
19:12:24 <Alberth> I like 20 :)
19:12:34 <Yexo> I'd like to propose a rename of "days_since_pickup" to "station_ticks_since_pickup" or so
19:12:47 <frosch123> yeah, 20 is nice :p
19:12:54 <frosch123> smatz would also love it :)
19:13:48 <frosch123> GES_PICKUP might also profit from some renaming
19:14:08 <Yexo> + case 0x61: return ge->HasVehicleEverTriedLoading() ? ge->days_since_pickup : 0; <- is that change required?
19:14:09 <frosch123> something like GES_HAS_RATING or so
19:15:10 <Yexo> HasBit(ge->acceptance_pickup, GoodsEntry::GES_HAS_RATING) <- would look strange
19:15:16 <frosch123> Yexo: technically not, but i tried to remove all magic values
19:16:39 *** FLHerne has quit IRC
19:17:05 <Yexo> VEHICLE_LENGTH should be renamed to VEHICLE_MAX_LENGTH or so
19:17:13 *** FLHerne has joined #openttd.dev
19:20:57 <Yexo> didn't check all code of 93_, but the rest looks fine
20:12:27 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24711 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
20:12:46 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24712 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
20:13:03 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24713 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
20:13:17 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24714 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
20:13:35 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24715 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
20:13:52 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24716 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
20:14:08 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24717 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:34:29 *** Alberth has left #openttd.dev
21:47:54 <frosch123> http://devs.openttd.org/~frosch/diffs/renaming/ <- the earlier suggested renamings
21:48:00 <frosch123> i am not sure whether MAX_VEHICLE_LENGTH fits
21:48:08 <frosch123> could as well be DEFAULT_VEHICLE_LENGTH
21:48:26 <Yexo> define both to be the same and use them where appropriate?
21:48:51 <frosch123> that's thard
21:49:03 <frosch123> i would need a MAX_VEHICLE_SHORTENING then :p
21:49:08 <frosch123> which makes it even more weird
21:50:08 <Yexo> hmm, I see
21:51:04 <Yexo> last chunk of stationticks.diff still has a var named "days"
21:51:28 <frosch123> ah, i only did sed :p
21:52:17 <Yexo> not sure about the MAX_VEHICLE_LENGTH, given the problem above
21:52:33 <frosch123> i rename the "days" to "traveltime", ok?
21:52:38 <Yexo> fine :)
21:52:44 <frosch123> VEHICLE_LENGTH fits stuff like TILE_SIZE
21:52:49 <frosch123> maybe we should not rename it
21:52:53 <Yexo> exactly
21:54:43 <frosch123> oh, we have Station::time_since_load and _unload
21:54:46 <frosch123> which use the same units
21:54:53 <frosch123> so maybe time_since_pickup then?
21:55:12 <Yexo> fine with me too
21:55:22 <Yexo> as long as "days" is gone I'm happy :)
21:59:03 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24718 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:59:49 <Yexo> thanks :)
22:05:44 *** FLHerne has quit IRC
22:07:33 *** FLHerne has joined #openttd.dev
23:03:04 *** frosch123 has quit IRC
23:49:10 *** Zuu has quit IRC
continue to next day ⏵