⏴ go to previous day
00:12:47  *** olinuxx has quit IRC

01:18:46  <DorpsGek> SVN: glx (r1179) -Cleanup: remove some unneeded checks and removed C-ified functions from function_names.txt

03:58:06  <glx> http://svn.opendune.org/~glx/temp.patch <-- there's a memory leak in dune2 :) (gui.c:1696-1702)

03:59:15  <glx> select a house, click "No", repeat, and you will probably trigger OOM

03:59:48  <glx> I didn't try, but the code clearly leaks

04:02:32  *** glx has quit IRC

10:55:23  *** fjb_ has joined #openDune

10:55:24  *** fjb is now known as Guest117

10:55:24  *** fjb_ is now known as fjb

11:02:10  *** Guest117 has quit IRC

12:43:10  *** glx has joined #openDune

12:43:10  *** ChanServ sets mode: +o glx

12:43:34  <glx> hello

17:14:12  <DorpsGek> SVN: glx (r1180) -Add: C-ified GUI_Palette_2BA5_00A2()

17:15:09  <TrueBrain> lol @ name :D

17:15:42  <glx> that's when I don't know exactly what it does :)

17:21:02  <DorpsGek> SVN: glx (r1181) -Fix (r1180): little mistake and some optimisation

17:21:41  <glx> oops ;)

17:22:36  <TrueBrain> haha

17:22:37  <TrueBrain> :D

17:30:08  <glx> do you confirm the leak I detected ?

17:33:43  <TrueBrain> haven't looked, sorry :)

17:33:46  <TrueBrain> been a bit busy :(

17:33:52  <TrueBrain> now dinner; will check after that :)

18:01:51  <TrueBrain> glx: no, I don't see how it leaks

18:01:58  <TrueBrain> it allocs 3 widgets, but frees them later on

18:02:23  <TrueBrain> of, you can hit a break

18:02:30  <TrueBrain> of = oh

18:02:37  <TrueBrain> bit bad

18:02:40  <TrueBrain> no biggy, but a bit bad

18:02:45  <glx> it allocates twice for each widget

18:02:46  <TrueBrain> comment about it, or fix it :)

18:03:08  <glx> one time with malloc, 1 time with widget_allocate

18:03:20  <glx> and the malloced one is never freed

18:03:28  <TrueBrain> lol

18:03:29  <TrueBrain> even worse :p

18:03:31  <TrueBrain> so, fix it

18:03:44  <TrueBrain> if it works without the malloc, just remove it

18:04:04  <TrueBrain> if you are absolutely positively sure it is not used :)

18:05:10  <glx> it puts malloced data in w2csip, the replace that with next call

18:05:17  <glx> *then

18:06:28  <glx> works without malloc

18:06:37  <glx> so it's indeed a leak :)

18:08:06  <TrueBrain> well, you could of course always made a conversion error ;)

18:08:13  <TrueBrain> but yeah .. it seems weird :)

18:08:19  <glx> not this time ;)

18:17:02  <DorpsGek> SVN: glx (r1182) -Add: C-ified GUI_PickHouse()

18:51:05  *** tneo has quit IRC

18:52:02  *** tneo has joined #openDune

18:52:48  *** Yexo has quit IRC

18:53:44  *** Yexo has joined #openDune

18:53:44  *** ChanServ sets mode: +v Yexo

20:22:21  *** olinuxx has joined #openDune

continue to next day ⏵